[Koha-bugs] [Bug 25123] MaxFines does not count the current updating fine

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25123

--- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Martin Renvoize from comment #14)
> (In reply to Nick Clemens from comment #10)
> > (In reply to Jonathan Druart from comment #9)
> > > What about the FIXME a couple of lines above?
> > 
> > That behaviour doesn't change, and is still a valid question, how did we get
> > two fines on one issue and how should we resolve? But these patches fix the
> > other case so I don't think we need to address here

> I know at least Katrin has her own fines code so I didn't remove it 'just in
> case', but would like to clean it up at some point.

Guilty, but it's not a super bad hack... only a little bit bad. We just do the
fine calculation differently, but use the standard methods for triggering and
placing the fine (might have to make that work again with all the changes to
accounts in last versions? :) I will see when it comes to it)

>  how did we get two fines on one issue and how should we resolve?
Do you mean 2 accrueing fines? Or just fines? In some older DB we didn't do the
FU > F change cleanly, so bad data could be an issue. Generally:
Checkout
Gets overdue + fines
Renew
Gets overdue + fines again
Renew...

-- 
You are receiving this mail because:
You are watching all bug changes.