[Koha-bugs] [Bug 25227] SIP server returns wrong error message if item was lost and not checked out

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25227

--- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 103363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103363&action=edit
Bug 25227: SIP server returns wrong error message if item was lost and not
checked out

Even if a library allows returns of lost items, the SIP server returns the
error message "Item lost, return not allowed" if the checkin was not ok for any
reason other than it being withdrawn ( and withdrawn items not being returnable
).

The most clear example of this is that when a lost item is not checked out to a
patron and is returned. SIP returns that message even though lost items *can*
be returned. The actual problem being that the item was not checked out.

Test Plan:
1) Ensure you can return lost items
2) Mark an item as lost
3) Check it in via SIP
4) Note the message you get back is "Item lost, return not allowed"
5) Apply this patch
6) Restart your SIP server
7) Repeat steps 2 and 3
8) Note you no longer get the incorrect message!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.