[Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Nick Clemens from comment #20)
> (In reply to Martin Renvoize from comment #18)
> > 3/ Add a manual invoice with a valid, but old, barcode (Not a LOST type)
> 
> Do you mean a deleted barcode? The code tries, but there is a CONSTRAINT
> error

I meant a deleted item, i.e. where the item has moved to deleted_items.. though
this actually makes me wonder about the case where a barcode is deleted from an
item.. I'll ponder that case.  As for the constraint, hmm.. I'll investigate
that.. could be a bad constraint and lose of data elsewhere I've not fully
considered.

> 
> > 6/ Add a manual invoice with type 'LOST' and a valid barcode, but not
> > one that will match a checkout for your user. Note an error is displayed
> 
> This succeeds with no problems, and I think that is right. If a patron comes
> in, takes a book off the shelf and destroys it they may want to won up. Or a
> parent taking responsibility for a child. There are many cases you may want
> to charge a lost with no checkout

Agreed, this should be allowed.. I think I just miswrote the plan there.

> 
> > 7/ When errors are displayed, note the form contains data from the
> > previous submission so you can just correct the error rather than
> > re-enter all data.
> 
> The amount does not pass through, this would be helpful too

Hmm, I thought I tested that

-- 
You are receiving this mail because:
You are watching all bug changes.