[Koha-bugs] [Bug 24201] Attach desk to intranet session

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201

--- Comment #33 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 101883
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101883
Bug 24201: (follow-up) Rework Desks Plugin

Review of attachment 101883:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24201&attachment=101883)
-----------------------------------------------------------------

Hi Nicolas, good job

I just found a minor terminology issue from my point of view (see bellow)

And I have a logical problem with setting desks functionality:
Imaginewe have two libraries defined and each have some desks defined, for
example
Library1: Desk 1A and Desk1B
Library2: Desk 2A and Desk2b

When I set Library1 and Desk 1A and then, I need to work with Library2. There
is still Desk 1A set... I need to go at another page - setdesk.pl and set a
correct desk (2A or 2B)

I maybe have one easy solution for this - instead of adding a setdesk page,
implement the ability of setting desks into set-library page.

It also fixes the issue which Owen mentioned - using setdesk page even if it is
useless

::: Koha/Template/Plugin/Desks.pm
@@ +76,5 @@
>  returns all desks existing at the library
>  
>  =cut
>  
> +sub ListForBranch {

Would be a bit better to use 'Library' instead 'Branch' - for consistant
terminology

-- 
You are receiving this mail because:
You are watching all bug changes.