[Koha-bugs] [Bug 24718] Introduce hour-based holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind <david at davidnind.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david at davidnind.com
             Status|Needs Signoff               |Failed QA

--- Comment #16 from David Nind <david at davidnind.com> ---
Hi Aleisha.

Everything seems to work as expected according to the test plan.

There is one failed test though (after the patch is applied):

root at 40629b80bd10:koha(bz24718)$ prove t/db_dependent/Holds.t
t/db_dependent/Holds.t .. 1/61 
#   Failed test 'holds_placed_today should return a valid borrowernumber'
#   at t/db_dependent/Holds.t line 104.
#          got: '247'
#     expected: '246'
t/db_dependent/Holds.t .. 61/61 # Looks like you failed 1 test of 61.
t/db_dependent/Holds.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/61 subtests 

Test Summary Report
-------------------
t/db_dependent/Holds.t (Wstat: 256 Tests: 61 Failed: 1)
  Failed test:  8
  Non-zero exit status: 1
Files=1, Tests=61,  7 wallclock secs ( 0.04 usr  0.00 sys +  5.63 cusr  0.52
csys =  6.19 CPU)
Result: FAIL

In addition, there is also an error happening after the patches are applied
when you go the patrons details page and the holds tab:

> DataTables warning: table id=holds-table - Ajax error. For more information 
> about this error, please see http://datatables.net/tn/7

I've reported this error before on bug 24769 - it only seems to happen for me
when testing ILS-DI bugs, but is now happening for this bug as well.

-- 
You are receiving this mail because:
You are watching all bug changes.