[Koha-bugs] [Bug 21781] message_transport_type should allow fallbacks

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781

--- Comment #3 from Alex Buckley <alexbuckley at catalyst.net.nz> ---
Hi all, 

I've attached a patch which extends the use of FallbackToSMSIfNoEmail syspref
to the following files which Martin noted:

* opac/opac-shareshelf.pl
* misc/cronjobs/membership_expiry.pl
* misc/cronjobs/automatic_renewals.pl
* circ/pendingreserves.pl
* C4/Acquisition.pm

I've included an individual test plan for each of these files to test the
changes. The individual test plans are sequential though, so you can start
testing 'Test plan for C4/Acquisition.pm' where you apply the patch and then
you keep it applied through all the other test plans. 

The following files I have not included for the following rationale, very happy
to discuss if you disagree :)

* opac/svc/checkout_notes -> Sends 'CHECKOUT_NOTE' notice to library inbound
email address if AllowCheckoutNotes
* opac/opac-issue-note.pl -> ditto
* opac/opac-memberentry.pl -> Sends 'OPAC_REG_VERIFY' notice to entered email
address, defining sms address should be on separate bug report
* opac/opac-shareshelf.pl -> One of 2 hardcoded message_transport_types I have
made. Regarding unchanged one this is unchanged as 'SHARE_INVITE' notice sent
to inputted sharee email address.
Defining sharee sms number should be different bug report
* circ/article-request-slip.pl -> Hardcoded message_transport_type of 'print'
on master
* C4/Reserves.pm -> Sends 'HOLDPLACED' notice to library inbound email address
if 'emailLibrarianWhenHoldIsPlaced' syspref is enabled
* misc/cronjobs/stockrotation.pl -> Sends 'SR_SLIP' stock rotation report
notice to library inbound email address or KohaAdminEmailAddress 
* Koha/ArticleRequests.pm -> No longer contains notice being queued
* Koha/Patron/Password/Recovery.pm -> Hardcoded message_transport_type for
'PASSWORD_RESET' is requiring email from OpacResetPassword syspref
*  Koha/Account.pm -> Requires email to be hardcoded as only run if
UseEmailReceipts is enabled

Thanks,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.