[Koha-bugs] [Bug 21395] Make perlcritic happy

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21395

Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Hi Julian,
an extensive change!

All your test pass (1,2,3) but qa tools reports some errors, a lot of them are
from tab chars, bout others are more real

For example
FAIL   misc/migration_tools/22_to_30/export_Authorities_xml.pl
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   OK     spelling
   FAIL   valid
                Global symbol "$time" requires explicit package name (did you
forget to declare "my $time"?) 
                Global symbol "$string" requires explicit package name (did you
forget to declare "my $string"?) 
                misc/migration_tools/22_to_30/export_Authorities_xml.pl had
compilation errors.

this is because of a missing ';' at the end of this line 
34          my $string= ($time=~m/([0-9\-]+)/) ? $1 : undef

Others need exploring.

-- 
You are receiving this mail because:
You are watching all bug changes.