[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Comment on attachment 103947
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103947
Bug 23185: Make Koha::Objects->update loop on the object set if needed

Review of attachment 103947:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23185&attachment=103947)
-----------------------------------------------------------------

I'm open to opinions on the below comment but I feel it's clearer to keep the
two things distinct.

::: Koha/Objects.pm
@@ +199,5 @@
> +
> +sub update {
> +    my ($self, $params) = @_;
> +
> +    my $no_triggers = delete $params->{no_triggers};

Personally, I think I'd rather keep method options distinct from the row data..
so I would have prefered

my ($self, $params, $options) = @_;

my $no_triggers = $options->{no_triggers};

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.