[Koha-bugs] [Bug 25260] Add a new 'holds' table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260

--- Comment #11 from Agustín Moyano <agustinmoyano at theke.io> ---
Created attachment 103993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103993&action=edit
Bug 25260: Adapt all the things

This patch adapts many pm and test files to work with unified holds
table.

To test:

1. Remove all previous holds in reserves and old_reserves tables.
2. Create 6 holds. Cancel 2 of them, fulfill one, set one in waiting and
   another in transit.
CHECK => "select reserve_id, found from reserves" query in mysql should return
3 rows, where in found
column should find 'W', 'T' and another with null values.
      => "select reserve_id, found from old_reserves" query in mysql should
return 3 rows, where in found column you should find 2 with 'C', and one with
'F' values.
3. in mysql change reserve_id to the value of a hold in reserve table.
4. apply patches
5. updatedatabase
SUCCESS => you should get the following warning "There were 1 old reserves that
could not be moved, please check '_old_reserves'"
        => "select id, status, completed from holds" query in mysql should
return 5 rows.
          => The hold that had null value in found column, now should have
'placed' status and 0 in completed.
          => The one that had 'W' in found column, now should have 'waiting'
status and 0 in completed.
          => The one that had 'T' in found column, now should have 'in_transit'
status and 0 in completed.
          => The one that had 'F' in found column, now should have 'fulfilled'
status and 1 in completed.
          => The unmodified cancelled hold, now should have 'cancelled' status
and 1 in completed.
        => "select * from _old_reserves" should give you one row with the
modified hold.
6. in staff interface create, cancel, modify priorities, etc and everything
should work exactly as before.

 # Run every test that has reserve and hold word wihtin
 # check that you are in main koha directory
 # check you have correctly setted KOHA_INTRANET_URL and KOHA_OPAC_URL
environment variables
 # check plack is up and running.. tests will use selenium
 # prepare yourself a mug of coffe/te or take a nap.. this will take a while
7. prove $(grep -ilr -e reserve -e hold t|grep "\.t$")

 # finally
8. Sign off

Sponsored-by: ByWater Solutions
Sponsored-by: Theke Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.