[Koha-bugs] [Bug 25297] Consistent return value in K::A::Order->current_item_level_holds

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Apr 30 12:51:09 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297

--- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 104015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104015&action=edit
Bug 25297: Consistent return value in K::A::Order->current_item_level_holds

This patch makes the return values for 'current_item_level_holds'
consistent: they will always be a Koha::Holds iterator.

To test:
1. Apply the regression tests
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Order.t
=> FAIL: It doesn't work as expected, cannot call ->count on undef, etc
3. Apply this patch
4. Repeat 2.
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Frédéric Demians <f.demians at tamil.fr>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list