[Koha-bugs] [Bug 23111] Setting a custom framework as the default for cataloguing is not possible

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111

Aleisha Amohia <aleisha at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #22 from Aleisha Amohia <aleisha at catalyst.net.nz> ---
(In reply to Bernardo Gonzalez Kriegel from comment #21)
> Hi, 
> no problem searching, test pass, works.
> 
> qa-tools complains
>  FAIL   installer/data/mysql/kohastructure.sql
>    OK     boolean_vs_tinyint
>    OK     charset_collate
>    OK     git manipulation
>    FAIL   tinyint_has_boolean_flag
>                 The new column biblio_framework.is_default is using
> TINYINT(1) as type but is not defined as boolean in the schema file
> (Koha/Schema/Result/BiblioFramework.pm), see the SQL12 coding guideline
> 
> Why not use an smallint/int type?
> Seems like a false positive to me.

See the coding guidelines on the Koha Community wiki about booleans:
https://wiki.koha-community.org/wiki/Coding_Guidelines#SQL12:_Booleans

I realise I have done this wrong so will fix it up anyway, but guidelines say
to use tinyint.

-- 
You are receiving this mail because:
You are watching all bug changes.