[Koha-bugs] [Bug 26037] openlibrary.org is hit on every Koha requests
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sat Aug 1 00:08:07 CEST 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26037
Lucas Gass <lucas at bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #107429|0 |1
is obsolete| |
--- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> ---
Created attachment 107658
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107658&action=edit
Bug 26037: openlibrary.org is hit on every Koha requests
This patch moves the inclusion of Open Library JavaScript from
opac-bottom.inc to the three templates where it might be used.
In addition, the Open Library JS has been modified to check for the
existence of the relevant markup on the page before executing a query.
Unrelated: The Open Library label is now hidden when the status returned
is "Not found." Previously this information was displayed.
To test, apply the patch and enable the OpenLibrarySearch system
preference.
- Perform a search in the OPAC which will return results from Open
Library. Some ISBNs: 0140423826, 0395082552, 0679436405.
- On the search result page there should be an Open Library "Read
now" button for each result that can be opened for reading in Open
Library.
- Add these titles to a list and view the list.
- The "Read now" button should appear on the list page.
- View the details for one of these titles.
- The "Read now" button should appear on the page below the holdings.
- Watch the browser's developer tools on these and other pages in the
OPAC. There should be no errors in the console and no 404 errors in
the network tab.
Signed-off-by: Lucas Gass <lucas at bywatersolutions.com>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list