[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #528 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Some work should be done according to QA tools:

C4/Circulation.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got
2 violation(s).
C4/Overdues.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1
violation(s).
koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.ttforbidden
pattern: Attribute type should not be used for script tags (bug 20053) (line
158)
koha-tmpl/intranet-tmpl/prog/js/recalls.js
Untranslatable string found (Are you sure you want to remove this recall?) -
See coding guideline JS5
        Untranslatable string found (The recall may have already been
cancelled. Please refresh the page.) - See coding guideline JS5
        Untranslatable string found (Cancelled) - See coding guideline JS5
        Untranslatable string found (Are you sure you want to expire this
recall?) - See coding guideline JS5
        Untranslatable string found (The recall may have already been expired.
Please refresh the page.) - See coding guideline JS5
        Untranslatable string found (Expired) - See coding guideline JS5
        Untranslatable string found (Are you sure you want to revert the
waiting status of this recall?) - See coding guideline JS5
        Untranslatable string found (The recall waiting status may have already
been reverted. Please refresh the page.) - See coding guideline JS5
        Untranslatable string found (Status updated) - See coding guideline JS5
        Untranslatable string found (Are you sure you want to mark this recall
as overdue?) - See coding guideline JS5
        Untranslatable string found (The recall may have already been marked as
overdue. Please refresh the page.) - See coding guideline JS5
        Untranslatable string found (Marked overdue) - See coding guideline JS5
        Untranslatable string found (Are you sure you want to remove this
recall and return the item to it's home library?) - See coding guideline JS5
        Untranslatable string found (The recall may have already been removed.
Please refresh the page.) - See coding guideline JS5
        Untranslatable string found (Cancelled) - See coding guideline JS5
        Untranslatable string found (Are you sure you want to remove the
selected recall(s)?) - See coding guideline JS5
        Untranslatable string found (Please make a selection.) - See coding
guideline JS5

misc/cronjobs/recalls/expire_recalls.pl
Code before strictures are enabled at line 20, column 1. See page 429 of PBP.
misc/cronjobs/recalls/overdue_recalls.pl
Code before strictures are enabled at line 20, column 1. See page 429 of PBP.
svc/checkouts
# Variables::ProhibitConditionalDeclarations: Got 1 violation(s).

-- 
You are receiving this mail because:
You are watching all bug changes.