[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Few minor things found:

* I think "Batch item modification results" should display the value in the
table if it has been modified

* https://snipboard.io/NWPmMg.jpg
Maybe we need a "legend" for the first fieldset and a less specific one for the
one you add? What other field/attribute could we add to "Priority"?
Double check with a English native speaker but maybe we would prefer "MARC
fields" and "Other attributes"?

* "Exclude from local holds priority" does not appear in the header of the
"Patron categories" table

* moredetails.pl
+    updated_exclude_from_local_holds_priority =>
$query->param('updated_exclude_from_local_holds_priority')
=> Force scalar context is missing for ->param

* 
-print
$cgi->redirect("moredetail.pl?biblionumber=$biblionumber&itemnumber=$itemnumber#item$itemnumber");
+print $cgi->redirect("moredetail.pl?" . $alerts .
"biblionumber=$biblionumber&itemnumber=$itemnumber#item$itemnumber");

Put $alerts after existing params I'd say
Also maybe "$messages" would be more appropriated

* I think the following block is not translator friendly
+        <i>Exclude from local holds priority</i> updated to
+        [% IF updated_exclude_from_local_holds_priority %]<i>Yes</i>[% ELSE
%]<i>No</i>[% END %]


* Not blocker, in the tests you could have set the default value for
exclude_from_local_holds_priority in t::lib::TestBuilder

-- 
You are receiving this mail because:
You are watching all bug changes.