[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Works as expected, and with the QA follow-up, passes the QA scripts..

Signing off.

Minor niggle; It would have been nice to move
C4::Circulation::_FixAccountForLostAndFound into Koha::Item at the same time -
But I can do that in a followup bug.

Second minor niggle; I'm not sure about the return value of
Koha::Item->set_found.. as it stands we are returning a boolean that denotes
whether the set triggered a refund or not. I could see this being easily
mistaken for a boolean denoting success vs failure.  This could be a good
opportunity to introduce a more 'fluent interfaces' inspired design.

-- 
You are receiving this mail because:
You are watching all bug changes.