[Koha-bugs] [Bug 26078] "Item returns to issuing library" creates infinite transfer loop

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26078

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
If I understand correctly, by modifying the return branch we actually want to
not transfer. I'd suggest to use a meaningful separated bool variable.

I noticed there is a $validTransfer variable that is not used, and its last
used come from 0a64cfba5e10be80a220f6c8164905788ba5a78b where we have:

-    if ($doreturn and ($branch ne $hbr) and not $messages->{'WrongTransfer'}
and ($validTransfert ne 1) ){                                                   
+    if (($doreturn or $messages->{'NotIssued'}) and !$resfound and ($branch ne
$hbr) and not $messages->{'WrongTransfer'}){

It seems that is was actually used for that.

-- 
You are receiving this mail because:
You are watching all bug changes.