[Koha-bugs] [Bug 24632] Plugins should support simple signing for security/verifiability

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I've rebased the patches (kohastructure.sql and plugins-home.tt, but there are
a lot of QA script fails:

 FAIL   Koha/Plugins/Key.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   OK     spelling
   OK     valid

 FAIL   Koha/Plugins/Keys.pm
   OK     critic
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 57)
                forbidden pattern: tab char (line 61)
                forbidden pattern: tab char (line 83)
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for 'verify_plugin'
   OK     spelling
   OK     valid

 FAIL   Koha/Schema/Result/PluginKey.pm
   OK     critic
   OK     forbidden patterns
   OK     git manipulation
   OK     pod
   FAIL   pod coverage
                POD is missing for koha_object_class
                POD is missing for koha_objects_class
   OK     spelling
   OK     valid

 OK     installer/data/mysql/kohastructure.sql
   OK     boolean_vs_tinyint
   OK     charset_collate
   OK     git manipulation
   OK     tinyint_has_boolean_flag

 OK     installer/data/mysql/sysprefs.sql
   OK     git manipulation
   OK     semicolon
   OK     sysprefs_order

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt
   OK     filters
   FAIL   forbidden patterns
                forbidden pattern: trailing space char (line 58)
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-keys.tt
   FAIL   filters
                missing_filter at line 68 (                                    
               <li><a class="uninstall_plugin"
href="/cgi-bin/koha/plugins/plugins-keys.pl?keyid=[% plugin_key.keyid
%]&op=Delete"><i class="fa fa-trash fa-fw"></i> Delete</a></li>)
   FAIL   forbidden patterns
                forbidden pattern: tab char (line 28)
                forbidden pattern: tab char (line 42)
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

 OK     koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-upload.tt
   OK     filters
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   OK     tt_valid
   OK     valid_template

 FAIL   plugins/plugins-keys.pl
   OK     critic
   FAIL   forbidden patterns
                forbidden pattern: Script permissions is authnotrequired => 0,
it could be correct for an OPAC script if it is was you really want error (bug
24663) (line 42)
   OK     git manipulation
   OK     pod
   OK     spelling
   OK     valid

Additional notes:

1) The 2 .perl files for database updates [c/sh]ould be combined.
2) Add comment before new table in kohastructure.sql
3) I wonder if the permission for the new page should not be a little stricter.
Currently if you can use plugins, you can also access the page. I'd suggest:
manage - Manage plugins ( install / uninstall )
This should then also affect the visibility of the buttons/links to the page
from plugin home.

-- 
You are receiving this mail because:
You are watching all bug changes.