[Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #43 from Arthur Suzuki <arthur.suzuki at biblibre.com> ---
fixed conflicts but i get errors, also qa-tools are not happy.
Http response from api:
<pre>
{
    "errors": [
        {
            "message": "Properties not allowed: suggestionid, rejecteddate,
date, acceptedby, place, patronreason, manageddate, price, copyrightdate,
suggesteddate, branchcode, collectiontitle, rejectedby, accepteddate, STATUS,
total, itemtype, managedby, lastmodificationdate, biblionumber, publishercode,
suggestedby, publicationyear, budgetid, lastmodificationby, volumedesc,
archived.",
            "path": "/"
        }
    ],
    "status": 500
}
</pre>

errors from qa tools:
<pre>
testing 5 commit(s) (applied to 6d7ff0d '04 Bug 16371: (follow-up) DB changes')

Processing files before patches
|========================>| 2 / 2 (100.00%)
Processing files after patches
|========================>| 2 / 2 (100.00%)

 FAIL   Koha/Patron.pm
   FAIL   pod
                *** ERROR: Apparent command =cut not preceded by blank line  in
file Koha/Patron.pm

 FAIL   Koha/REST/V1/Suggestions.pm
   FAIL   forbidden patterns
                forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)
                forbidden pattern: Do not assume male gender, use they/them
instead (bug 18432) (line 178)
                forbidden pattern: tab char (line 181)
                forbidden pattern: tab char (line 182)
                forbidden pattern: tab char (line 190)
                forbidden pattern: tab char (line 224)
                forbidden pattern: tab char (line 231)
                forbidden pattern: tab char (line 238)
   FAIL   pod
                *** ERROR: Spurious =cut command  in file
Koha/REST/V1/Suggestions.pm
                *** WARNING: =head3 without preceding higher level  in file
Koha/REST/V1/Suggestions.pm
                *** WARNING: =head2 without preceding higher level  in file
Koha/REST/V1/Suggestions.pm
   FAIL   pod coverage
                POD is missing for add
                POD is missing for delete
                POD is missing for get
                POD is missing for list
                POD is missing for update


Processing additional checks

        * Commit title does not start with 'Bug XXXXX: ' - 0fd078368e
        * Commit title does not contain 'follow-up' correctly spelt -
2195ec1b0a
        * Commit title does not contain '(QA follow-up)' correctly spelt -
2195ec1b0a
</pre>

-- 
You are receiving this mail because:
You are watching all bug changes.