[Koha-bugs] [Bug 18501] Automatic refunds need protection from failure

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18501

--- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Jonathan Druart from comment #41)
> Martin, I have the feeling that the last patch embeds changes that is not
> directly related to the original changes. I'd like to avoid side-effects as
> much as possible.
> 
> I'd say there is at least one unrelated change, if we call ->store and
> ->itemlost is set but unchanged, then itemlost_on was updated. Now it won't.

Please explain.. I don't see this occurring and can't see how it could be in
the code before or after the changeset?

> 
> Can you rebuild the last patch to have the minimum changes to get the tests
> pass?

I think it's fairly minimal as is.. I'm not sure I can reduce it any further.

-- 
You are receiving this mail because:
You are watching all bug changes.