[Koha-bugs] [Bug 26059] Create guarantor/guarantee links on patron import

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26059

--- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> ---
$patron is scoped to a different sibling block and doesn't survive to reach the
code where the relationship is set. $borrowernumber is scoped to the parent
block. Since we only need the borrowernumber, it was simpler to set
$borrowernumber than to re-engineer $patron to be in the parent block.

(In reply to Jonathan Druart from comment #7)
> Comment on attachment 108319 [details] [review]
> Bug 26059: Create guarantor/guarantee links on patron import
> 
> Review of attachment 108319 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: Koha/Patrons/Import.pm
> @@ +354,4 @@
> >                  Koha::Patron->new(\%borrower)->store;
> >              };
> >              unless ( $@ ) {
> > +                $borrowernumber = $patron->id;
> 
> Is this line really needed? If so please explain.

-- 
You are receiving this mail because:
You are watching all bug changes.