[Koha-bugs] [Bug 25872] Advanced search on OPAC with limiter but no search term fails when re-sorted

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25872

Nick Clemens <nick at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108258|0                           |1
        is obsolete|                            |

--- Comment #10 from Nick Clemens <nick at bywatersolutions.com> ---
Created attachment 108507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108507&action=edit
Bug 25872: Fix scoping of $limits

The code in build_query_compat contained a 'my' in the assigning of limits for
the search in a conditional

This meant the limits were being set correctly during the conditional, but we
blanked when passed to the rest
of the code. The effect was that the searches worked, however, the template
params to repeat the search were
incomplete.

Removing the my ensures the same limits are applied during search and on
re-sorting

To test:
1 - Enable Elasticsearch
2 - On OPAC perform advanced search, selecting only an itype, ccode, or LOC
limit
3 - Attempt to sort results
4 - You are returned to Advanced search
5 - Apply patch
6 - Repeat
7 - It sorts!

Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.