[Koha-bugs] [Bug 25114] Remove duplicated logic from GetLoanLength()

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25114

Lari Taskula <lari.taskula at hypernova.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

--- Comment #8 from Lari Taskula <lari.taskula at hypernova.fi> ---
Forgot to mention this the commit text but this was sponsored by The National
Library of Finland.

(In reply to Katrin Fischer from comment #6)
> The change made me wonder if we should keep GetLoanLength at all. It's
> currently only used by CalcDueDate.
> 
> Should we replace the call there and get rid of this method?

I agree and confirm it is only being used in C4::CalcDueDate(). These days one
can easily Get Loan Length via Koha::CirculationRules->get_effective_rules().
Let's open a new Bug for it.

-- 
You are receiving this mail because:
You are watching all bug changes.