[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Aug 18 21:52:34 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343

--- Comment #82 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Kyle M Hall from comment #67)
> Seems like a simple failure to fix, but I'm not sure what the fix should be.
> Is this a difference in response that will crop up from server differences?
> Or does it fail on your system as well now?

The test relied too much on a specific way the header was built.

It actually highlighted bad design because the tests were showing the charset
was being set as 'utf8' regardless. So I tweaked it a little bit so it actually
sets the charset, following the design on Email::MIME and Email::Stuffer.

No place in the codebase is setting it with this rewrite, though. As we return
UTF-8 email body. But worth leaving room for passing it, just in case, in the
right way. The tests now check iso-8859-1 is being set if requested.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list