[Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #126 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
This one is a little scary already, but going in for a first review :)

1) QA script

Several issues found, please fix:

 FAIL   Koha/Biblio/Volume.pm
   FAIL   forbidden patterns
                forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)

 FAIL   Koha/Biblio/Volume/Item.pm
   FAIL   forbidden patterns
                forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)
   FAIL   pod
                *** WARNING: 
                empty section in previous paragraph

                 in file Koha/Biblio/Volume/Item.pm

 FAIL   Koha/Biblio/Volume/Items.pm
   FAIL   forbidden patterns
                forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)
   FAIL   pod
                *** WARNING: 
                empty section in previous paragraph

                 in file Koha/Biblio/Volume/Items.pm

 FAIL   Koha/Biblio/Volumes.pm
   FAIL   forbidden patterns
                forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)
   FAIL   pod
                *** WARNING: 
                empty section in previous paragraph

                 in file Koha/Biblio/Volumes.pm

 FAIL   Koha/REST/V1/Biblios/Volumes.pm
   FAIL   forbidden patterns
                forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)

 FAIL   Koha/REST/V1/Biblios/Volumes/Items.pm
   FAIL   forbidden patterns
                forbidden pattern: Incorrect license statement (using postal
address), may be a false positive if the file is coming from outside Koha (bug
24545) (line 16)

 FAIL   Koha/Schema/Result/Volume.pm
   FAIL   pod coverage
                POD is missing for koha_object_class
                POD is missing for koha_objects_class

 FAIL   Koha/Schema/Result/VolumeItem.pm
   FAIL   pod coverage
                POD is missing for koha_object_class
                POD is missing for koha_objects_class

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
   FAIL   forbidden patterns
                forbidden pattern: simple-quote string (line 1446)


 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
   FAIL   filters
                missing_filter at line 20 (  var has_volumes = [% volumes.count
%];)
   FAIL   js_in_body


2) Doubled up use statement in Biblio.pm

+use Koha::Biblio::Volumes;
+use Koha::Biblio::Volumes;

3) REST API

I'd love to have Tomas take a look on the REST API bits here. 

4) sysprefs.sql

After all the use statements were so nicely alphabetically resorted, THIS?

+('EnableVolumes','0','','Enable volumes feature','YesNo'),
 ('viewISBD','1','','Allow display of ISBD view of bibiographic
records','YesNo'),

;)

5) Pref (question)

Enable|Don't enable
volumes feature to allow collecting groups of items on a record into volumes.

Does it mean the items have to be from the same record or could they be from
different ones?

6) Table configuration

The new volumn column on the holdings table needs to be added to the table
configuration options.

7) GUI

"Create new" on the items table would work nicer as "Create new volume" or "New
volume" to give context to translators and for better accessibility.

Future improvements:
It might be nice to offer a kind of grouped view for the items in volumes...
but I am not sure yet how this would work best. 
It might be nice to show the volumes in the OPAC as well.

8) Use case and future plans?

Can you tell a bit about in what context or use case this partner is using
this? Serials?

-- 
You are receiving this mail because:
You are watching all bug changes.