[Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Hola Agustin,

1. The first patch ("Set default value in tests") is dealing with default
values we want to apply for all tests.  It replaces your last patch.
It's the way to go when you face such situations, easier than update all test
scripts ;)

2. I am not sure we should modify misc/admin/set_password.pl
It's an sysop script, and sysops (are supposed to) know what they are doing.
It's a behaviour change that is not advertised.
(for discussion)

3. It seems that we need make categorycode param mandatory. The only call to
adjust is from the onboarding tool

4. I don't think we need a new test file, t/AuthUtils.t can be reused easily.
The only thing you need is to mock the categories table (search for
'fixtures_ok' in t)

-- 
You are receiving this mail because:
You are watching all bug changes.