[Koha-bugs] [Bug 19889] LocalHoldsPriority needs exclusions

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19889

--- Comment #84 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
(In reply to Jonathan Druart from comment #80)
> (In reply to Jonathan Druart from comment #58)
> > * I think the following block is not translator friendly
> > +        <i>Exclude from local holds priority</i> updated to
> > +        [% IF updated_exclude_from_local_holds_priority %]<i>Yes</i>[% ELSE
> > %]<i>No</i>[% END %]
> 
> You replaced it with:
> 
> -        [% IF updated_exclude_from_local_holds_priority %]<i>Yes</i>[% ELSE
> %]<i>No</i>[% END %]
> +        [% IF updated_exclude_from_local_holds_priority %]
> +            <i>Yes</i>
> +        [% ELSE %]
> +            <i>No</i>
> +        [% END %]
> 
> What I meant is that it will be displayed with the TT block in the po files.
> I think it would be better:
>         [% IF updated_exclude_from_local_holds_priority %]
>             <i>Exclude from local holds priority</i> updated to <i>Yes</i>
>         [% ELSE %]
>             <i>Exclude from local holds priority</i> updated to <i>No</i>
>         [% END %]
> 
> Asking confirmation to Katrin.

I think I'd avoid the <i> - as HTML tags they break up the strings. I haven't
tested this, but with your suggestion I think we could end up with:

Exclude from local holds priority
updated to
Yes

(Best is always to confirm by updating the po files if unsure)

Better, I think, would be something like:

Exclude from local holds priority updated to ... [IF ELSE for yes and no, maybe
with apostropes instad of italic? 'Yes']

-- 
You are receiving this mail because:
You are watching all bug changes.