[Koha-bugs] [Bug 26250] Test suite does not pass if Elastic is used as search engine

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26250

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #9)
> We have a QA script fail here:
> 
>  FAIL	t/db_dependent/Koha/Patrons.t
>    OK	  critic
>    FAIL	  forbidden patterns
> 		forbidden pattern: Use of DateTime->now should certainly be replaced with
> dt_from_string (bug 24840) (line 612)
> 		forbidden pattern: Use of DateTime->now should certainly be replaced with
> dt_from_string (bug 24840) (line 613)
> 		forbidden pattern: Use of DateTime->now should certainly be replaced with
> dt_from_string (bug 24840) (line 1427)
> 		forbidden pattern: Use of DateTime->now should certainly be replaced with
> dt_from_string (bug 24840) (line 1428)

That's not valid, the diff is:
-    AddIssue( $patron, $item_1->{barcode}, DateTime->now->subtract( days => 1
) );
-    AddIssue( $patron, $item_2->{barcode}, DateTime->now->subtract( days => 5
) );
-    AddIssue( $patron, $item_3->{barcode} );
+    AddIssue( $patron, $item_1->barcode, DateTime->now->subtract( days => 1 )
);
+    AddIssue( $patron, $item_2->barcode, DateTime->now->subtract( days => 5 )
);
+    AddIssue( $patron, $item_3->barcode );


> Hm, and some tests are failing?
> t/db_dependent/CourseReserves/CourseItems.t
> Test Summary Report
> -------------------
> t/db_dependent/CourseReserves/CourseItems.t (Wstat: 1536 Tests: 35 Failed: 6)
>   Failed tests:  2, 7, 12, 17, 22, 34
>   Non-zero exit status: 6

It passes for me :-/

-- 
You are receiving this mail because:
You are watching all bug changes.