[Koha-bugs] [Bug 26268] Remove items.paidfor once and for all

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Aug 22 12:46:14 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
I see that there is a lot of history here, but I am not quite following yet.

1) Before dropping the column: Did we move the information stored there in
previous developments? 

If we didn't, we might just want to print a warning if there is any content to
be found in the db and ask people to drop themselves. It has been done in the
past with some of the columns in borrowers (ethnicity?) I think. If there is no
data, we can drop it in the update.

2) Looking for "paidfor" I found some more references this patch is not taking
care of:

catalogue/moredetail.pl:    # Add paidfor info
catalogue/moredetail.pl:                $item->{paidfor} = { patron => $patron,
created_on => $payment_offset->created_on };

koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt:               
[% IF ( ITEM_DAT.paidfor ) %]<li><span class="label">Paid for?:</span> [%
INCLUDE 'patron-title.inc' patron=ITEM_DAT.paidfor.patron
hide_patron_infos_if_needed=1 %] on [% ITEM_DAT.paidfor.created_on | $KohaDates
%]</li>[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list