[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #76 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
1) Copyright date changed

The patch set changes the size on coyprightdate and add a pattern check:

-                                                    <input type="text"
id="copyrightdate" name="copyrightdate" pattern="[12]\d{3}" size="4" max
length="4" value="[% copyrightdate | html %]" required="required" />
+                                                    <input type="text"
id="copyrightdate" name="copyrightdate" pattern="[12]\d{3}" size="10" ma
xlength="4" value="[% copyrightdate | html %]" required="required" />

I am not sure about this one, especially since it causes issues as Lisette
noted on comment#75. The message is just: Please match the requested format.
The label and the check also don't match and add a bit to the confusion - we
ask for "date" but expect "year". 

I think adding a hint on the field with the expected format or improving the
validation feedback, would be a worthwhile addition here to complement the new
check.

I am not sure if we can agree on this, but maybe we can discuss renaming
Copyright date to publication year? I think this is the only context we use
this specific term. (not blocker, asking for opinion and can file separately)

2) Translations in .js files

This trick is no longer necessary, you can now wrap translations in js files in
__( ) to make them translatable. As Owen is just working hard on switching all
the old constructs to the new one, we should avoid adding more work for him.
Can you please change that?

+    var MSG_UNDO_AUTOFILL_SUGGESTION =  _("Undo");
+    var MSG_SEARCH_GOOGLE_BOOKS = _("Search Google Books");

3) Undo

Not blocker, but wondering if "Clear form" or similar would work a bit better
in this case and be more specific for translations.

Failing for 2) and a missing hint on 1). Really close and works nicely already,
hope to see this come back soon!

-- 
You are receiving this mail because:
You are watching all bug changes.