[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Nick,

the QA script found some problems, please fix:

AIL     installer/data/mysql/kohastructure.sql
   OK     boolean_vs_tinyint
   OK     charset_collate
   OK     git manipulation
   FAIL   tinyint_has_boolean_flag
                The new column search_field.mandatory is using TINYINT(1) as
type but is not defined as boolean in the schema file
(Koha/Schema/Result/SearchField.pm), see the SQL12 coding guideline

 FAIL  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt
   FAIL   filters
                missing_filter at line 193 (                        <input
type="text" name="search_field_name" value="[% search_field.name | html %]" [%
is_readonly %]/>)
                missing_filter at line 196 (                        <input
type="text" name="search_field_label" value="[% search_field.label | html %]"
[% is_readonly %]/>)
                missing_filter at line 383 (                                   
<td><a class="btn btn-default btn-xs delete mandatory" data-field_name="[%
mapping.search_field_name %]" style="cursor: pointer;"><i class="fa
fa-trash"></i> Delete</a></td>)
   OK     forbidden patterns
   OK     git manipulation
   OK     js_in_body
   OK     spelling
   FAIL   tt_valid
                lines 193, 196
   OK     valid_template


* Commit title does not start with 'Bug XXXXX: ' - df373aaf1f
* Commit title does not start with 'Bug XXXXX: ' - 7c2fb8cbb1

-- 
You are receiving this mail because:
You are watching all bug changes.