[Koha-bugs] [Bug 26076] Paying selected accountlines in full may result in the error "You must pay a value less than or equal to $x"

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Aug 22 23:47:34 CEST 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26076

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #107590|0                           |1
        is obsolete|                            |

--- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Created attachment 108938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108938&action=edit
Bug 26076: Sum the amount due in the database query instead of a loop in Perl

This appears to be a bug due to inaccuracies in floating point math. I've been
unable to reproduce it on demand. Sometimes when using the "Write off selected"
button, Koha will give the error that the payment is more than the amount owed,
even though they are the same. The solution I've implemented is to move the
summation from Perl code to the database query. This video demonstrates the
issue and afterward, shows the error goes away after the patch is applied:
https://monosnap.com/file/pG69HC7iI9mU9kkuoCtbkVzVTffKlE

Test Plan:
1) Apply this patch
2) Restart all the things!
3) Verify that "Write off selected" functions as usual

Signed-off-by: Amit Gupta <amit.gupta at informaticsglobal.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list