[Koha-bugs] [Bug 22343] Add SMTP configuration options to Administration

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22343

--- Comment #125 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
The test plan was spread between different commits and some steps were missing.
I'll try to sumarize

Test plan:

0. Install a new dependency:
   $ apt install libemail-stuffer-perl
1. Apply this patchset
2. Run:
   $ updatedatabase
3. Run all the tests:
   $ kshell
  k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove 
=> SUCCESS: All tests pass
4. Add a privileged user, notice there's a 'manage_smtp_servers' subpermission
in 'parameters'
5. Play with adding/removing the permission and reloading the admin page
=> SUCCESS: the admin page displays/doesn't display the entry for SMTP servers
management correctly.
6. Enter the SMTP servers page
=> SUCCESS: the left column displays an entry for the SMTP admin page
7. Have a known working SMTP configuration (I used an app-specific password on
my Gmail account), enable debug mode if you want deeper knowledge on what's
happening, on the logs
8. Add the SMTP server
=> SUCCESS: The table displays the server
9. Add/Edit/Remove dummy servers
=> SUCCESS: Things work as expected
10. Go to the libraries admin page
11. Edit all libraries, choosing the known working SMTP server
12. Try sending a cart or list from the admin interface and the OPAC
=> SUCCESS: It works! Or otherwise the logs show why it failed, YAY!
13. Generate some notices (fulfilled holds, checkin notices, etc)
14. Run:
  k$ perl misc/cronjobs/process_message_queue.pl
=> SUCCESS: Email goes out! 
15. Sign off :-D


A note about 'runreport.pl'.

'runreport.pl' is THE script that doesn't have an obvious 'library' associated
to it. At least not without a change in behaviour. As this patches allow you to
set an SMTP server for a library, but keep a hardcoded default that replicates
the current behaviour (localhost:25, no auth, no ssl/tls) the only way to test
this is by having an SMTP server (postfix?) running locally. Or with bug 26290,
by setting the default in koha-conf.xml. On my tests, what I did was putting my
SMTP config in Koha/SMTP/Servers.pm in the default hashref. That's another
option

-- 
You are receiving this mail because:
You are watching all bug changes.