[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271

--- Comment #264 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Nick Clemens from comment #260)
> (In reply to Jonathan Druart from comment #259)
> > Patches have been rebased against master.
> 
> Looking here:
> 1 - Foreign key constraints on items table 'ON DELETE' updates are affected
> here - for instance a hold is not deleted if an item is deleted (can be done
> from additem.pl)

See previous comment and the pad for discussion

> 2 - Batch mod and batch delete should not allow altering deleted items

Done!

> 3 - CanBookBeReserved should not check deleted items (missing is_current =>
> 1)

Done!

(In reply to Nick Clemens from comment #261)
> Maybe it is too late to ask this question: Rather than joining items and
> deleteditems, can we join them into a new table and provide views for both
> of the old tables? This would prevent breaking reports across the board.
> 
> biblio, deletedbiblios => biblios?
> items,deleteditems => all_items?
> 
> This is going to be a big problem for existing users, it is going to be many
> reports, and it is going to cause disruption. Havign views that keep the
> reports working would be a huge boon.

Yes Nick, this will be addressed on bug 25921.
However, I don't think it's a good idea to rename the table to have an
inconsistent name. We could rename biblio to biblio, but items is correct.
My opinion is that it should be quite trivial to fix the report in an update
DB.
* \sitems can be replaced with items_legacy
* \sbiblio => biblio_legacy
* and so on

What do you think?

> Otherwise:
> 
> I mostly tested functionality in this pass rather than reading the code,
> there are some areas that need attention.
> 
> Acquisitions - Can delete ordered items and recieve them
> 
> Can edit deleted items by forcing URL in additem.pl
> 
> Can add to list using deleted barcodes
> 
> Can add deleted items to label batches and rotating collections
> 
> Batch record modification: Can load deleted records - then modification fails
> 
> Can attach images to deleted records

All fixed.

> Canned reports - I don't think these were checked:
> grep items /kohadevbox/koha/reports/* -c
> grep is_current /kohadevbox/koha/reports/* -c

That one sounds tricky, will try to fix later.

-- 
You are receiving this mail because:
You are watching all bug changes.