[Koha-bugs] [Bug 25067] Move PO file manipulation code into gulp tasks

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25067

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #53 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Katrin Fischer from comment #49)
> 1. Run `yarn install` and install Locale::XGettext::TT2
> 
> It looks like Locale::XGettext::TT2 has no packages for Debian yet, can you
> confirm?
That's true. It is not packaged in Debian.

> 3. Verify the contents of updated PO files
> 
> I have verified the contents of the de-DE files. 
> 
> Problem: It appears that a strings have jumped from one po file to another,
> requiring a lot of retranslations. Namely this seems to be the value_builder
> plugins that are no longer in the MARC flavor files but appear in staff now:
> 
> Example string:
> twentyfour track
> 
> This is now in the UNIMARC file, but with this patch appears in staff.
Good catch! Thanks :)
It seems that the update to gulp v4 has some issues with file globs and
case-sensitivity. Fixed in one of the latest patches

I compared the number of msgid before and after the patch:

Before:
  de-DE-installer-MARC21.po 1738
  de-DE-installer.po 754
  de-DE-marc-MARC21.po 3152
  de-DE-marc-NORMARC.po 449
  de-DE-marc-UNIMARC.po 1797
  de-DE-messages-js.po 80
  de-DE-messages.po 25
  de-DE-opac-bootstrap.po 2014
  de-DE-pref.po 2538
  de-DE-staff-prog.po 9705
After:
  de-DE-installer-MARC21.po 1738
  de-DE-installer.po 754
  de-DE-marc-MARC21.po 3154   # 2 additional strings picked from
koha-tmpl/intranet-tmpl/prog/en/data/marc21_field_CF.xsd, can be excluded if
needed
  de-DE-marc-NORMARC.po 449
  de-DE-marc-UNIMARC.po 1797
  de-DE-messages-js.po 80
  de-DE-messages.po 27   # 2 additional strings picked, thanks to the
transition to Locale::XGettext::TT2
  de-DE-opac-bootstrap.po 2014
  de-DE-pref.po 2538
  de-DE-staff-prog.po 9705

> Question: Reviewing the pref po looks like before, correct?
Yes, the pref po file content should not change (except for long lines
wrapping, and maybe the order of strings ? I did not check)

> 4. Run `cd misc/translator && ./translate install <lang>`
> 
> Testing with de-DE again.
> Question: do we need a follow-up to change the package commands as well?
I haven't tested those, but I don't think a change is needed

> Activated the language and the language switcher in the preferences.
> 
> 5. Verify that all (templates, sysprefs, xslt, installer files) is
>    correctly translated
> 
> ! System preferences: remained English
> Staff GUI: OK
> OPAC GUI: OK
> XSLT in staff and OPAC: OK
> messages JS: OK (verified with OPAC cart strings)
> messages: OK (verified with "item" and "items" in staff result list)
> installer: OK (tested with es-ES)
> installed sample files: OK (tested with notices and frameworks)
> 
> Preferences don't translate.
> Stopping here for now because of the problem with prefs.
Fixed by the last patch

> 7. Run `prove t/misc/translator`
> 
> Test Summary Report
> -------------------
> t/misc/translator/xgettext-pref.t     (Wstat: 3840 Tests: 16 Failed: 15)
>   Failed tests:  1, 3-16
>   Non-zero exit status: 15
> Files=3, Tests=56,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.34 cusr  0.07
> csys =  0.45 CPU)
> Result: FAIL
Fixed

Thank you Katrin for testing !
It's now ready to be tested again :)

-- 
You are receiving this mail because:
You are watching all bug changes.