From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 02:29:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 01:29:10 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #6 from David Cook --- (In reply to Jonathan Druart from comment #4) > It would be nice to have bug 26048 before we turn this on. Very true -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 02:33:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 01:33:12 +0000 Subject: [Koha-bugs] [Bug 27116] Send CGI to Koha plugins adding JS/CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27116 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- While I can see the short-term gain, this sounds like a long-term headache. Wherever possible, we should be trying to avoid all things CGI these days. Not doing so is just adding technical debt... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 05:41:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 04:41:05 +0000 Subject: [Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #51 from David Cook --- (In reply to Martin Renvoize from comment #50) > Could you possibly write an example of how you'd expect a plugin to use the > new task queue stuff as an alternative to this? I'm happy for this bug to > be replaced with such an example.. right now I don't know enough of how that > code fits together to really do such an example myself. I don't think it's possible at the moment, but here's what I would envision: 1. Have a module/function registry for koha-worker to check when it gets a message 2. A plugin registers a module/function when it's installed 3. The plugin provides an API where it gives an immediate response and stages some data but does the actual processing via the task queue (ie koha-worker) 4. The koha-worker verifies the message against the registry, and invokes the code provided by the Koha plugin I think that Tomas may have had a similar idea? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 07:22:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 06:22:35 +0000 Subject: [Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 [Bug 20582] Turn Koha into a Mojolicious application -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 07:22:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 06:22:35 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 [Bug 26791] Build Mojolicious controller replacement for export.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 08:42:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 07:42:11 +0000 Subject: [Koha-bugs] [Bug 27116] Send CGI to Koha plugins adding JS/CSS In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27116 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|ASSIGNED |RESOLVED --- Comment #2 from Fridolin Somers --- (In reply to David Cook from comment #1) > While I can see the short-term gain, this sounds like a long-term headache. > > Wherever possible, we should be trying to avoid all things CGI these days. > Not doing so is just adding technical debt... Ahhh I see your point, specially for OPAC we encourage REST API. Since plugins can create API routes, lets say its the way to provide datas. I close. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 09:24:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 08:24:35 +0000 Subject: [Koha-bugs] [Bug 27120] New: Sent biblio to Koha plugins hook 'intranet_catalog_biblio_tab' Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 Bug ID: 27120 Summary: Sent biblio to Koha plugins hook 'intranet_catalog_biblio_tab' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Koha plugins hook 'intranet_catalog_biblio_tab' should have the datas of the current biblio record. Koha::Biblio is aleady in template, send it with hooks call. Depends on Bug 27114 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 09:24:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 08:24:43 +0000 Subject: [Koha-bugs] [Bug 27120] Sent biblio to Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 09:24:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 08:24:49 +0000 Subject: [Koha-bugs] [Bug 27120] Sent biblio to Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27114 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27114 [Bug 27114] Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 09:24:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 08:24:49 +0000 Subject: [Koha-bugs] [Bug 27114] Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27114 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27120 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 [Bug 27120] Sent biblio to Koha plugins hook 'intranet_catalog_biblio_tab' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 09:26:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 08:26:23 +0000 Subject: [Koha-bugs] [Bug 27120] Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sent biblio to Koha plugins |Send biblio to Koha plugins |hook |hook |'intranet_catalog_biblio_ta |'intranet_catalog_biblio_ta |b' |b' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 09:30:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 08:30:33 +0000 Subject: [Koha-bugs] [Bug 27120] Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 --- Comment #1 from Fridolin Somers --- Created attachment 114061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114061&action=edit Sample plugin Sample plugin for test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 09:31:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 08:31:06 +0000 Subject: [Koha-bugs] [Bug 27120] Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 09:31:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 08:31:09 +0000 Subject: [Koha-bugs] [Bug 27120] Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 --- Comment #2 from Fridolin Somers --- Created attachment 114062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114062&action=edit Bug 27120: Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' Koha plugins hook 'intranet_catalog_biblio_tab' should have the datas of the current biblio record. Koha::Biblio is aleady in template, send it with hooks call. This will be very usefull to be able to fetch external datas (wikipedia, youtube, ...) depending on current biblio record. Test plan : 1) Enable Koha plugins 2) Install plugin attached to this bug 3) Go to staff interface on a biblio record details page 4) Check you see tab 1 containing 'Tab for record {title}' 5) Check you see tab 2 containing 'Tab for record {isbn}' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 09:31:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 08:31:13 +0000 Subject: [Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #52 from Jonathan Druart --- An easy (but lazy) implementation could be: - Have a Koha::BackgroundJob::Plugin - Your plugin class inherit it and has a job_type="plugin|Your::Plugin::Class" - Your plugin implement ->process You can now call ->enqueue to enqueue the job, and the worker will process it when possible. However we don't have the "at" part here, it should be done on a separate bug report with bug 1993 in mind. I think Tomas's idea was to have REST API routes to enqueue new jobs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 09:50:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 08:50:39 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #7 from Jonathan Druart --- diff --git a/populate_db.pl b/populate_db.pl index 097bbda..7d07aa6 100755 --- a/populate_db.pl +++ b/populate_db.pl @@ -92,8 +92,8 @@ if ( $marcflavour ne 'MARC21' my $dbh = C4::Context->dbh; # At the beginning to die if DB does not exist. -my ( $prefs_count ) = $dbh->selectrow_array(q|SELECT COUNT(*) FROM systempreferences|); -my ( $patrons_count ) = $dbh->selectrow_array(q|SELECT COUNT(*) FROM borrowers|); +my ( $prefs_count ) = eval { $dbh->selectrow_array(q|SELECT COUNT(*) FROM systempreferences|) }; +my ( $patrons_count ) = eval { $dbh->selectrow_array(q|SELECT COUNT(*) FROM borrowers|) }; if ( $prefs_count or $patrons_count ) { die "Database is not empty!"; } You will need to apply this to koha-misc4dev first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:19:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 09:19:20 +0000 Subject: [Koha-bugs] [Bug 27121] New: Merge items Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27121 Bug ID: 27121 Summary: Merge items Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl As it exists for bibliographic records, it could be great if we could have a new feature to merge items (especially useful after merging records for exemple). When we can face duplicate of items with both incomplete datas, instead of editing one and copy-paste the missing informations coming from the second item, we could have a form to check which datas coming from each items we want to keep after merging. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:19:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 09:19:43 +0000 Subject: [Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 --- Comment #8 from Jonathan Druart --- Victor, I don't understand some of the changes, can you explain them? - $self->click_when_visible( $default_submit_selector ); + $self->driver->find_element($default_submit_selector)->click and - $self->click_when_visible( $xpath_selector ); + $self->driver->find_element($xpath_selector)->click >From the commit message: Fix: remove usage of click_when_visible() because it doesn't work with elements not in the top of the page. Because they are off screen. We are certainly going to reintroduce some random issues we tried to fix during the last cycle. What are the elements at the top, and why are they out of the screen? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:22:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 09:22:03 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #110 from Joonas Kylmälä --- (In reply to Lari Taskula from comment #107) > 1. Considering class naming - These patches add > "Koha::Patron::Message::Preference::*", but to avoid confusion between > "message_queue" and "messages" table, would Koha::Notice::Preference better > match the purpose? > > As far as I understand, message_queue and messaging preferences are related, > but "messages" is something different as it is only delivered in the web > browser in staff client and/or OPAC. > > As of now: > - message_queue = Koha::Notice::Messages > - messages = Koha::Patron::Message > - message preferences = Koha::Patron::Message::Preference > > Right now this class naming makes it seem as if these preferences have > something to do with "messages" when in fact it is only related to > "message_queue". > > I believe the work on this Bug overlapped Bug 17959 so we ended up with this > confusion. > > Still, notices vs messages is pretty confusing. It seems "Notice" is being > used for the messages that end up in message_queue. Since notices are > related to messaging preferences, should we call it notice preferences > instead? I've switched this Bug into "In Discussion" in order to solve this > problem first. We use messaging preferences in the GUI so I would not switch to notice preference. I see these message preferences as their own object tied to a patron (not to a patron's individual message). This would mean the name would be Koha::Patron::MessagePreference and Koha::Patron::MessagePreferences. Then this message preference is combination of a Attribute and Transports. Important thing to note, reading the code C4::Members::Messaging::GetMessagingPreferences it appears that one MessagePreference would correspond to one message_attribute. As far as I can tell the table message_attributes is incorrectly named / created, the columns should be in my opinion in the borrower_message_preferences table. So the final structure could be Koha::Patron::MessagePreference (contains both borrower_message_preferences and message_attributes with JOIN) Koha::Patron::MessagePreferences (contains MessagePreference) Koha::Patron::MessagePreference::Transport (message_transports) Koha::Patron::MessagePreference::Transports (contains all Transport of a MessagePreference) The message_transports seems to contains also unrelated columns to transport types, namely the is_digest information which seems to be preference of the patron instead of something that is decided based on the transportation medium. But maybe you can fit this somehow nicely anyway? If it seems impossible we could restructure first the messaging preference related tables. Also see comment #80 from Jonathan, I think it the $patron->messaging_preferences suggestion is a bit like what I have here but instead with an object. Using object allows now modifying all the message preference fields easily so I would go with the object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:23:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 09:23:34 +0000 Subject: [Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 --- Comment #9 from Jonathan Druart --- Tests are passing but I see lot of occurrences of this error: selenium_1 | [Child 3211, Main Thread] WARNING: fallocate failed to set shm size: No space left on device: file /builds/worker/checkouts/gecko/ipc/chromium/src/base/shared_memory_posix.cc:184 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:26:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 09:26:36 +0000 Subject: [Koha-bugs] [Bug 27122] New: Add flags to batch patrons modification Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27122 Bug ID: 27122 Summary: Add flags to batch patrons modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It could be useful to add the 2 flags "Lost card" and "Gone no address" to the batch patrons modification form. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:31:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 09:31:55 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #23 from Jonathan Druart --- There is a JS error if a select2.js is used outside of addbiblio.tt: ReferenceError: select2Width is not defined Edit items view for instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:32:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 09:32:21 +0000 Subject: [Koha-bugs] [Bug 27123] New: Add messages to batch patrons modification Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27123 Bug ID: 27123 Summary: Add messages to batch patrons modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It could be useful if using the batch patrons modification form, we could add new circulation messages for all selected patrons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:33:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 09:33:05 +0000 Subject: [Koha-bugs] [Bug 27124] New: JS error "select2Width is not defined" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Bug ID: 27124 Summary: JS error "select2Width is not defined" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 22399 There is a JS error if select2.js is used outside of addbiblio.tt: ReferenceError: select2Width is not defined Edit items view for instance. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:33:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 09:33:05 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27124 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 [Bug 27124] JS error "select2Width is not defined" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 10:33:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 09:33:31 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #24 from Jonathan Druart --- (In reply to Jonathan Druart from comment #23) > There is a JS error if a select2.js is used outside of addbiblio.tt: > ReferenceError: select2Width is not defined > > Edit items view for instance. See bug 27124. Owen can you deal with it please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:00:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:00:24 +0000 Subject: [Koha-bugs] [Bug 26356] Search by first and last name takes a long time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26356 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #11 from Jonathan Druart --- Closing this one. Please ask the mailing list (koha-devel) if the problem persists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:08:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:08:03 +0000 Subject: [Koha-bugs] [Bug 26375] SIP checkout message does not renew item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26375 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Is it a regression? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:12:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:12:08 +0000 Subject: [Koha-bugs] [Bug 27118] Typo in manual: If allowed, the patron chan choose the specific item to request. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27118 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:19:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:19:14 +0000 Subject: [Koha-bugs] [Bug 27088] Searching with just OR or AND gives error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27088 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I am seeing: /cgi-bin/koha/catalogue/search.pl?q=OR No results found No results match your search for 'kw,wrdl: OR'. /cgi-bin/koha/catalogue/search.pl?q=AND No results found No results match your search for 'kw,wrdl: AND'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:26:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:26:32 +0000 Subject: [Koha-bugs] [Bug 27102] Filter late orders by vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27102 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25266 --- Comment #1 from Jonathan Druart --- Can you try on a more recent version of Koha? I think it has been fixed by bug 25266. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:26:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:26:32 +0000 Subject: [Koha-bugs] [Bug 25266] Not all vendors are listed in the filters on the late order claims page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27102 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:30:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:30:07 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- It's working for me on master on both Firefox 68.12.0esr and Chromium 83.0.4103.116 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:37:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:37:07 +0000 Subject: [Koha-bugs] [Bug 27088] Searching with just OR or AND gives error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27088 --- Comment #2 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #1) > I am seeing: > > /cgi-bin/koha/catalogue/search.pl?q=OR > No results found Which Elasticsearch version you are using and are you using koha-testing-docker? I created the koha-testing-docker with > docker-compose -f docker-compose.yml -f docker-compose.mariadb_latest.yml -f docker-compose.es6.yml -p koha up --force-recreate and then run > koha-elasticsearch --rebuild -d kohadev and then in systempreferences I changed searchengine to Elasticsearch. After that doing the AND or OR search it gives error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:41:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:41:12 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #129 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #128) > I thought a bit more about the priority=1 thing this morning. > > And actually I have the feeling that the original issue described on this > bug report could be fixed with the following (...one line!) change: > > diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl > index 01cf877b55..962ebe5609 100755 > --- a/circ/pendingreserves.pl > +++ b/circ/pendingreserves.pl > @@ -230,7 +230,7 @@ my $strsth = > AND items.itemnumber NOT IN (SELECT itemnumber FROM branchtransfers > where datearrived IS NULL) > AND items.itemnumber NOT IN (SELECT itemnumber FROM reserves WHERE > found IS NOT NULL AND itemnumber IS NOT NULL) > AND issues.itemnumber IS NULL > - AND reserves.priority <> 0 > + AND reserves.priority = 1 > AND reserves.suspend = 0 This doesn't work because then rcount i.e. "Pull this many items" would only show 1 when in reality you need to pull many more items also to fill those other reserves. PS. unrelated, but rcount is also incorrect, it should be the number of holds, not amount of borrowers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:50:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:50:18 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:50:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:50:21 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 --- Comment #1 from Jonathan Druart --- Created attachment 114063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114063&action=edit Bug 27117 : Only place_holds permission is needed to adjust pickup locations The GET /pickup_locations route is requesting the whole reserveforothers permission whereas only the subpermission place_holds is needed. Test plan: 0. Don't apply this patch 1. Set the subpermission place_holds but modify_holds_priority 2. Edit a hold and click the pickup library dropdown list 3. You get a JS alert and log displays GET /api/v1/app.pl/api/v1/holds/5/pickup_locations 403 Forbidden 4. Apply this patch 5. Reload the page, click the dropdown list, modify the pickup location and save => Success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:51:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:51:12 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.05 |master See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18729 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:51:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:51:12 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27117 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 11:54:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 10:54:52 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114063|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 114064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114064&action=edit Bug 27117 : Only place_holds permission is needed to adjust pickup locations The GET /pickup_locations route is requesting the whole reserveforothers permission whereas only the subpermission place_holds is needed. Test plan: 0. Don't apply this patch 1. Set the subpermission place_holds but modify_holds_priority 2. Edit a hold and click the pickup library dropdown list 3. You get a JS alert and log displays GET /api/v1/app.pl/api/v1/holds/5/pickup_locations 403 Forbidden 4. Apply this patch 5. Reload the page, click the dropdown list, modify the pickup location and save => Success! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:01:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:01:46 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #130 from Joonas Kylmälä --- (In reply to Martin Renvoize from comment #127) > This looks like a great improvement, movin us to searching via objects > etc... but... dare I say it, can we move this to a module and thus add tests? I think this definitely needs to use a module, the code population of @all_items should be replaced with an object's method call that returns items that can fill holds. Then it will make super easy to read code where you just iterate over all the items and add the callnumber, shelving location, etc. info to the $reserves variable that goes. Btw, to resolve the original issue, can't we just order by reserve priority? This refactoring could be in a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:21:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:21:10 +0000 Subject: [Koha-bugs] [Bug 26336] Cannot import items if items ignored when staging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:21:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:21:12 +0000 Subject: [Koha-bugs] [Bug 26336] Cannot import items if items ignored when staging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114052|0 |1 is obsolete| | Attachment #114053|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 114065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114065&action=edit Bug 26336: Disable 'Item processing' dropdown if no item If there is no item to process and they have been ignored during the stage step, we should not let the user modify the dropdown value Test plan: 0 - Check the count of import_items SELECT COUNT(*) FROM import_items; 1 - Import a marc file with items , process the items 2 - Check the count of import items, it has increased 3 - Stage the file again, do not process items 4 - Count of import_items has not increased 5 - Manage the stage batch Confirm that you cannot modify the "Item processing" value Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:21:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:21:15 +0000 Subject: [Koha-bugs] [Bug 26336] Cannot import items if items ignored when staging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 --- Comment #7 from Nick Clemens --- Created attachment 114066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114066&action=edit Bug 26336: Add hint before and remove select after staging with no items Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:29:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:29:35 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27117 | Depends on| |27117 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:29:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:29:35 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18729 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18729 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:30:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:30:18 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #15 from Jonathan Druart --- Created attachment 114067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114067&action=edit Bug 18729: Add PUT /holds/{hold_id}/pickup_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:30:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:30:56 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #16 from Jonathan Druart --- Tomas, can you have a look at this patch please? I think I am almost there, but the test is failing (500 instead of 200) and the UI is getting a 400. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:38:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:38:01 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #131 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #130) > (In reply to Martin Renvoize from comment #127) > > This looks like a great improvement, movin us to searching via objects > > etc... but... dare I say it, can we move this to a module and thus add tests? > > I think this definitely needs to use a module, the code population of > @all_items should be replaced with an object's method call that returns > items that can fill holds. Then it will make super easy to read code where > you just iterate over all the items and add the callnumber, shelving > location, etc. info to the $reserves variable that goes. Yes, it would be nice to have tests and make the code even more clean. But given from when we started, I think it's already a great improvement. I really would like to have this into master at the beginning of the release cycle, and I am not sure we are going to find volunteers to write tests soon... > Btw, to resolve the original issue, can't we just order by reserve priority? > This refactoring could be in a separate bug. No, I don't think it will work, because of the group by. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:43:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:43:08 +0000 Subject: [Koha-bugs] [Bug 27102] Filter late orders by vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27102 --- Comment #2 from Daphne Hoolahan --- You are correct, this is working on 20.05 Although worded differently, this bug 27102 is a duplicate of 25266, can you close this bug please? Thanks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:50:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:50:52 +0000 Subject: [Koha-bugs] [Bug 27088] Searching with just OR or AND gives error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27088 --- Comment #3 from Jonathan Druart --- Sorry, something wrong on my side, Zebra was set (I am not used to check that, I setup my ktd with ES). I do recreate the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:51:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:51:58 +0000 Subject: [Koha-bugs] [Bug 27102] Filter late orders by vendor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27102 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Jonathan Druart --- Thanks for the confirmation Daphne. *** This bug has been marked as a duplicate of bug 25266 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 12:51:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 11:51:58 +0000 Subject: [Koha-bugs] [Bug 25266] Not all vendors are listed in the filters on the late order claims page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25266 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch at interleaf.ie --- Comment #34 from Jonathan Druart --- *** Bug 27102 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 13:42:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 12:42:09 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #141 from Emmi Takkinen --- Patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:02:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:02:35 +0000 Subject: [Koha-bugs] [Bug 27088] Searching with just OR or AND gives error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27088 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Jonathan Druart --- IMO we should keep this behaviour. The query has not a correct syntax and so it makes more sense to tell the user that there was an error than no results were found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:11:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:11:53 +0000 Subject: [Koha-bugs] [Bug 27088] Searching with just OR or AND gives error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27088 --- Comment #5 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #4) > IMO we should keep this behaviour. The query has not a correct syntax and so > it makes more sense to tell the user that there was an error than no results > were found. In that case we should treat this as invalid query and notify the user along the lines "The search cannot be processed because of invalid usage of OR/AND." and don't don't even send the query to Elasticsearch. Now there is unhandled error coming from Elasticsearch which makes it then impossible to spot real system errors. This bug can also be triggered with "something OR". With this "something OR" case it might be more desirable to just search for "something" or then convert OR to lower case and search for "something or" ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:14:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:14:24 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #132 from Jonathan Druart --- I had a (quick) look at how we could move the @all_items construction into a Koha::Items->filter_by_ method. I didn't find a simply way to do it, keeping code readable and without duplication. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:17:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:17:21 +0000 Subject: [Koha-bugs] [Bug 20561] Don't allow holds when all items are withdrawn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20561 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Jonathan Druart --- This is working as expected in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:22:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:22:34 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 --- Comment #133 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #132) > I had a (quick) look at how we could move the @all_items construction into a > Koha::Items->filter_by_ method. I didn't find a simply way to do it, keeping > code readable and without duplication. Having it under Koha::Items was not my intention and would not lead to any clearer result. It should be something like Koha::Holds->find($biblionumber)->items_that_can_fill and Koha::Hold->items_that_can_fill. But for this we need the CanItemFillHold from https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659#c6 I think. And of course some other naming scheme might be better, take items_that_can_fill as just an example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:22:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:22:38 +0000 Subject: [Koha-bugs] [Bug 27027] Typo: has successfully been modified.. %s In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27027 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22417 Keywords| |Academy CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/background_jobs.tt 125 Authority record [% m.authid | html %] has successfully been modified.. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:22:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:22:38 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27027 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27027 [Bug 27027] Typo: has successfully been modified.. %s -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:24:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:24:06 +0000 Subject: [Koha-bugs] [Bug 27006] If a record has no title, the list of checkouts breaks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27006 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 25293 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:24:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:24:06 +0000 Subject: [Koha-bugs] [Bug 25293] Don't call escapeHtml on null In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Jonathan Druart --- *** Bug 27006 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:24:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:24:36 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:24:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:24:40 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111872|0 |1 is obsolete| | Attachment #111873|0 |1 is obsolete| | Attachment #112990|0 |1 is obsolete| | --- Comment #29 from Nick Clemens --- Created attachment 114068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114068&action=edit Bug 21886: Add option to send notices from owning library instead of issuing library The provided patch adds the following functionality: * Add --owning to both advance_notice.pl and overdue_notice.pl * Add --library to advance_notice.pl like the way overdue_notice.pl already works When specifying "--owning" both scripts will use items.homebranch instead of issues.branchcode to determine sending library. For advance_notice.pl this affects non-digest DUE and PREDUE, but not digest notices. To test: 1. Have a patron who wants advance notices as email with 2 days in advance (not digest) 2. Have the first overdue date set 3 days past due date 3. Have issue for that patron where date_due is 2 days away where the item homebranch differs from the issuing branch 4. Have issue for that patron where date_due is 3 days old 5. Run advance_notices.pl without --owning 6. Run overdue_notices.pl without --owning 7. Confirm that two messages were created for that patron with the sender being the issuing branch 8. Delete messages or create two more issues according to (3) and (4) 9. Run advance_notices.pl with --owning 10. Run overdue_notices.pl with --owning 11. Confirm that the two messages created has the item homebranch as sender Extra feature for advance_notices.pl is that it adds "--library" the same way overdue_notices.pl has. Adding variants of that flag in steps (5) and (9) above can confirm this option as well. Sponsored-by: Gothenburg University Library Signed-off-by: Björn Nylén Signed-off-by: Timothy Alexis Vass Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:24:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:24:43 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #30 from Nick Clemens --- Created attachment 114069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114069&action=edit Bug 21886: (QA follow-up) Fix QA script errors This patch fixes a perlcritic issue and also replaces tabs with four spaces where appropriate. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:24:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:24:46 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #31 from Nick Clemens --- Created attachment 114070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114070&action=edit Bug 21886: (QA follow-up) Update parameters As discussed, this patch updates the --owning parameter to more clearly represent it's function. --owning boolean => --frombranch=item-homebranch|item-issuebranch Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:24:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:24:49 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 --- Comment #32 from Nick Clemens --- Created attachment 114071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114071&action=edit Bug 21886: (QA follow-up) Fix indentation, prevent warns, fix parameter, simplify SQL The SQL code was duplicated, I combine them here frombranch needs to take input switch owning to frombranch in second script initialize hash as empty list, not a reference add a newline after printed output if not mailing notices Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:26:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:26:22 +0000 Subject: [Koha-bugs] [Bug 27125] New: Show authority type for UNIMARC in authority search result display Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Bug ID: 27125 Summary: Show authority type for UNIMARC in authority search result display Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Bug 12533 added authority type in authority search result display. But it does not work for UNIMARC, due to : https://git.koha-community.org/Koha-community/Koha/src/commit/be9f64b638335cac7465ca302e187c7914534fbe/C4/AuthoritiesMarc.pm#L798 I propose to use result->{authtype} -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:26:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:26:29 +0000 Subject: [Koha-bugs] [Bug 27125] Show authority type for UNIMARC in authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 [Bug 12533] Improve authority search result display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:26:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:26:29 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27125 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 [Bug 27125] Show authority type for UNIMARC in authority search result display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:27:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:27:41 +0000 Subject: [Koha-bugs] [Bug 27125] Show authority type for UNIMARC in authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:30:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:30:10 +0000 Subject: [Koha-bugs] [Bug 27008] Broken SQL statement formed in Breeding.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I don't recreate, please provide steps to recreate the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:31:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:31:00 +0000 Subject: [Koha-bugs] [Bug 27125] Show authority type for UNIMARC in authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:31:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:31:03 +0000 Subject: [Koha-bugs] [Bug 27125] Show authority type for UNIMARC in authority search result display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27125 --- Comment #1 from Fridolin Somers --- Created attachment 114072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114072&action=edit Bug 27125: Show authority type also for UNIMARC in authority search result display Bug 12533 added authority type in authority search result display. But it does not work for UNIMARC, due to : https://git.koha-community.org/Koha-community/Koha/src/commit/be9f64b638335cac7465ca302e187c7914534fbe/C4/AuthoritiesMarc.pm#L798 I propose to use result->{authtype} Test plan : 1) Use UNIMARC catalogue 2) Search for autorities 3) Check you see autority type in column 4) Same for a MARC21 catalogue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:31:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:31:56 +0000 Subject: [Koha-bugs] [Bug 27008] Broken SQL statement formed in Breeding.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27008 --- Comment #2 from Jonathan Druart --- I get an explosion if I search " " or "-", but not on the SQL query. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:35:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:35:40 +0000 Subject: [Koha-bugs] [Bug 27008] Broken SQL statement formed in Breeding.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27008 --- Comment #3 from Joonas Kylmälä --- You can reproduce with this command in koha-shell: perl -e 'use C4::Context; use C4::Breeding; C4::Breeding::BreedingSearch();' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:36:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:36:44 +0000 Subject: [Koha-bugs] [Bug 27088] Searching with just OR or AND gives error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27088 --- Comment #6 from Jonathan Druart --- IMO it's not a good idea to parse the query for such problems before we sent it to ES. We should request ES and eventually provide feedback to the user about why their query might have been syntactically wrong. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:55:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:55:22 +0000 Subject: [Koha-bugs] [Bug 27008] Broken SQL statement formed in Breeding.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27008 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor --- Comment #4 from Jonathan Druart --- Well ok, but it's never called as it. It could be fixed however. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 14:59:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 13:59:16 +0000 Subject: [Koha-bugs] [Bug 27008] Broken SQL statement formed in Breeding.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27008 --- Comment #5 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #4) > Well ok, but it's never called as it. It could be fixed however. In some real life situation it happens as well but I don't know which one yet, I just got the error waiting in production logs and thought to report it to not forget to fix this :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:03:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:03:13 +0000 Subject: [Koha-bugs] [Bug 27010] Warnings produced by Elasticsearch QueryBuilder.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- >From where do you get this warning? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:10:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:10:18 +0000 Subject: [Koha-bugs] [Bug 27126] New: [OMNIBUS] Warnings from logs must be removed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 Bug ID: 27126 Summary: [OMNIBUS] Warnings from logs must be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org We have lot of warnings in our logs that must be removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:10:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:10:31 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27126 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 [Bug 27126] [OMNIBUS] Warnings from logs must be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:10:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:10:31 +0000 Subject: [Koha-bugs] [Bug 27126] [OMNIBUS] Warnings from logs must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18320 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 [Bug 18320] patroncards/edit-layout.pl raises warnings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:10:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:10:35 +0000 Subject: [Koha-bugs] [Bug 14740] Cataloging plugins: remove no warnings redefine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14740 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27126 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 [Bug 27126] [OMNIBUS] Warnings from logs must be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:10:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:10:35 +0000 Subject: [Koha-bugs] [Bug 27126] [OMNIBUS] Warnings from logs must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14740 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14740 [Bug 14740] Cataloging plugins: remove no warnings redefine -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:10:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:10:38 +0000 Subject: [Koha-bugs] [Bug 13344] Warnings on addorderiso2709.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13344 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Blocks| |27126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 [Bug 27126] [OMNIBUS] Warnings from logs must be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:10:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:10:38 +0000 Subject: [Koha-bugs] [Bug 27126] [OMNIBUS] Warnings from logs must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13344 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13344 [Bug 13344] Warnings on addorderiso2709.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:10:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:10:45 +0000 Subject: [Koha-bugs] [Bug 27010] Warnings produced by Elasticsearch QueryBuilder.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 [Bug 27126] [OMNIBUS] Warnings from logs must be removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:10:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:10:45 +0000 Subject: [Koha-bugs] [Bug 27126] [OMNIBUS] Warnings from logs must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27010 [Bug 27010] Warnings produced by Elasticsearch QueryBuilder.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:11:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:11:21 +0000 Subject: [Koha-bugs] [Bug 25993] SIP2 server logs polluted with warnings about uninitialized value $key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Blocks| |27126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 [Bug 27126] [OMNIBUS] Warnings from logs must be removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:11:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:11:21 +0000 Subject: [Koha-bugs] [Bug 27126] [OMNIBUS] Warnings from logs must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25993 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25993 [Bug 25993] SIP2 server logs polluted with warnings about uninitialized value $key -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:12:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:12:03 +0000 Subject: [Koha-bugs] [Bug 25515] Remove warnings and errors from tests output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27126 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:12:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:12:03 +0000 Subject: [Koha-bugs] [Bug 27126] [OMNIBUS] Warnings from logs must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25515 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:12:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:12:14 +0000 Subject: [Koha-bugs] [Bug 27011] Warnings in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Blocks| |27126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 [Bug 27126] [OMNIBUS] Warnings from logs must be removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:12:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:12:14 +0000 Subject: [Koha-bugs] [Bug 27126] [OMNIBUS] Warnings from logs must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 [Bug 27011] Warnings in returns.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:13:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:13:13 +0000 Subject: [Koha-bugs] [Bug 27126] [OMNIBUS] Warnings from logs must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 25790 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:13:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:13:13 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 --- Comment #2 from Jonathan Druart --- *** Bug 27126 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:13:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:13:35 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13344, 14740, 18320, 25993, | |27010, 27011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13344 [Bug 13344] Warnings on addorderiso2709.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14740 [Bug 14740] Cataloging plugins: remove no warnings redefine https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 [Bug 18320] patroncards/edit-layout.pl raises warnings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25993 [Bug 25993] SIP2 server logs polluted with warnings about uninitialized value $key https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27010 [Bug 27010] Warnings produced by Elasticsearch QueryBuilder.pm https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 [Bug 27011] Warnings in returns.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:13:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:13:35 +0000 Subject: [Koha-bugs] [Bug 13344] Warnings on addorderiso2709.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13344 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:13:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:13:35 +0000 Subject: [Koha-bugs] [Bug 14740] Cataloging plugins: remove no warnings redefine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14740 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:13:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:13:35 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:13:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:13:35 +0000 Subject: [Koha-bugs] [Bug 25993] SIP2 server logs polluted with warnings about uninitialized value $key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:13:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:13:35 +0000 Subject: [Koha-bugs] [Bug 27010] Warnings produced by Elasticsearch QueryBuilder.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:13:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:13:35 +0000 Subject: [Koha-bugs] [Bug 27011] Warnings in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:13:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:13:49 +0000 Subject: [Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25515 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:13:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:13:49 +0000 Subject: [Koha-bugs] [Bug 25515] Remove warnings and errors from tests output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25790 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:14:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:14:17 +0000 Subject: [Koha-bugs] [Bug 27126] [OMNIBUS] Warnings from logs must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13344, 14740, 18320, 25993, | |27010, 27011 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13344 [Bug 13344] Warnings on addorderiso2709.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14740 [Bug 14740] Cataloging plugins: remove no warnings redefine https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 [Bug 18320] patroncards/edit-layout.pl raises warnings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25993 [Bug 25993] SIP2 server logs polluted with warnings about uninitialized value $key https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27010 [Bug 27010] Warnings produced by Elasticsearch QueryBuilder.pm https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 [Bug 27011] Warnings in returns.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:14:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:14:17 +0000 Subject: [Koha-bugs] [Bug 13344] Warnings on addorderiso2709.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13344 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27126 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 [Bug 27126] [OMNIBUS] Warnings from logs must be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:14:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:14:17 +0000 Subject: [Koha-bugs] [Bug 14740] Cataloging plugins: remove no warnings redefine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14740 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27126 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 [Bug 27126] [OMNIBUS] Warnings from logs must be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:14:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:14:17 +0000 Subject: [Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27126 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 [Bug 27126] [OMNIBUS] Warnings from logs must be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:14:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:14:17 +0000 Subject: [Koha-bugs] [Bug 25993] SIP2 server logs polluted with warnings about uninitialized value $key In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25993 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27126 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 [Bug 27126] [OMNIBUS] Warnings from logs must be removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:14:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:14:17 +0000 Subject: [Koha-bugs] [Bug 27010] Warnings produced by Elasticsearch QueryBuilder.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27126 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 [Bug 27126] [OMNIBUS] Warnings from logs must be removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:14:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:14:17 +0000 Subject: [Koha-bugs] [Bug 27011] Warnings in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27126 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27126 [Bug 27126] [OMNIBUS] Warnings from logs must be removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:34:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:34:59 +0000 Subject: [Koha-bugs] [Bug 27127] New: Wrong display of messages if there was only 1 record modified Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Bug ID: 27127 Summary: Wrong display of messages if there was only 1 record modified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Task Scheduler Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 22417 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:34:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:34:59 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27127 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 [Bug 27127] Wrong display of messages if there was only 1 record modified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:38:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:38:30 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:40:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:40:42 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:40:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:40:45 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 --- Comment #1 from Jonathan Druart --- Created attachment 114073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114073&action=edit Bug 27127: Make Koha::BackgroundJob->messages return a scalar Otherwise the code in the template is not handled correctly: 112 [% FOR m IN job.messages %] m will become each key/val of the message hash: {"type":"success","biblionumber":"1","code":"biblio_modified"} And not the whole hash Test plan: Modify one biblio using the batch record modification tool Modify two biblios using the batch record modification tool Go to the detail view of each job and confirm that with this patch the display is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:43:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:43:53 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:43:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:43:56 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 --- Comment #1 from Jonathan Druart --- Created attachment 114074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114074&action=edit Bug 27109: Remove Replay action - not implemented -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:44:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:44:08 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 --- Comment #2 from Jonathan Druart --- Created attachment 114075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114075&action=edit Bug 27109: Improve labels on the background job views Replace "enqueued_on" with "Enqueued on", same for started_on and ended_on -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:45:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:45:27 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 --- Comment #2 from Jonathan Druart --- Without this patch the display is: https://snipboard.io/JKRlkU.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:51:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:51:20 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |need_backport_stable CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:51:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:51:43 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |need_backport_stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:56:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:56:14 +0000 Subject: [Koha-bugs] [Bug 26533] Searching authorities using 'is exactly' doesn't work as expected In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26533 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers --- Code tries to perform "all of subfield field must match" : https://git.koha-community.org/Koha-community/Koha/src/commit/be9f64b638335cac7465ca302e187c7914534fbe/C4/AuthoritiesMarc.pm#L184 Zebra doc indicates 6=3 is implemented : https://software.indexdata.com/zebra/doc/querymodel-rpn.html#querymodel-bib1-structure But looks like it does not work with actual Zebra version. Maybe it was implemented in GRS-1 mode. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 15:56:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 14:56:27 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:06:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:06:12 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|need_backport_stable |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:06:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:06:19 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|need_backport_stable |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:17:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:17:29 +0000 Subject: [Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 --- Comment #10 from Victor Grousset/tuxayo --- > Fix: remove usage of click_when_visible() because it doesn't work with > elements not in the top of the page. Because they are off screen. click_when_visible() uses wait_for_element_visible() which now use the current viewport for it's definition of visibility. Thus with elements out of the screen - lower in the page - wait_for_element_visible() waits forever. > We are certainly going to reintroduce some random issues we tried to fix during the last cycle. Before, the implicit_wait_timeout was 0, now it's 5sec, hopefully that should catch the the bulk of flaky tests. The whole suite was stable during more than 150 runs locally. > fallocate failed to set shm size: No space left on device This is due to a small /dev/shm and multiple Firefox staying open. Which shouldn't happen as close() is called at the end of each file. And in the error_handler. Remaining Firefox instances can be checked with: docker exec -it koha_selenium_1 bash df -h top Did you interrupt (ctrl-c) the runs several times? Or was it on a freshly started env on the first runs of the tests? That's only way I know for now about how to hit this issue with the new selenium container. ------- Good news, it's possible to change size of /dev/shm :D docker-compose.yml selenium: image: selenium/standalone-firefox + shm_size: 1gb This seems to be a recurring problem for running browsers in docker. As the default is only 64MiB. Testing shows that it doesn't increase the RAM usage, it might work like tmpfs thus only using more RAM as it's filled up. References for the size change: https://stackoverflow.com/questions/58952478/changing-shared-memory-size-in-docker-compose https://docs.docker.com/compose/compose-file/#shm_size -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:17:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:17:54 +0000 Subject: [Koha-bugs] [Bug 27128] New: Follow-up to bug 25728 - Don't prefill av's code Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 Bug ID: 27128 Summary: Follow-up to bug 25728 - Don't prefill av's code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Bug 25728 patch "Don't prefill av's code" does not work. Calling empty val() retruns the attribut. Should be val(''). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:24:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:24:15 +0000 Subject: [Koha-bugs] [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:24:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:24:18 +0000 Subject: [Koha-bugs] [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 --- Comment #1 from Fridolin Somers --- Created attachment 114076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114076&action=edit Bug 27128: Follow-up to bug 25728 - Don't prefill av's code Bug 25728 patch "Don't prefill av's code" does not work. Calling empty val() retruns the attribut. Should be val(''). Test plan : 1) Without patch 2) Edit a record 3) Edit a subfield with AV 4) Enter a new value to create it 5) You see the modal popup, edit and save 6) Enter another new value to create it 7) You see the modal popup => value is prefilled 8) Re-do test plan with patch => value is empty -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:25:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:25:13 +0000 Subject: [Koha-bugs] [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114076|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 114077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114077&action=edit Bug 27128: Follow-up to bug 25728 - Don't prefill av's code Bug 25728 patch "Don't prefill av's code" does not work. Calling empty val() retruns the attribut. Should be val(''). Test plan : 1) Without patch 2) Edit a record 3) Edit a subfield with AV 4) Enter a new value to create it 5) You see the modal popup, edit and save 6) Enter another new value to create it 7) You see the modal popup => value is prefilled 8) Re-do test plan with patch (+ clear JS cache) => value is empty -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:25:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:25:46 +0000 Subject: [Koha-bugs] [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:26:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:26:08 +0000 Subject: [Koha-bugs] [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25728 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords| |rel_20_11_candidate Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 [Bug 25728] Add the ability to create a new authorised value within the cataloguing module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:26:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:26:08 +0000 Subject: [Koha-bugs] [Bug 25728] Add the ability to create a new authorised value within the cataloguing module In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27128 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:28:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:28:18 +0000 Subject: [Koha-bugs] [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:28:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:28:21 +0000 Subject: [Koha-bugs] [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114077|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 114078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114078&action=edit Bug 27128: (bug 25728 follow-up) Don't prefill av's code Bug 25728 patch "Don't prefill av's code" does not work. Calling empty val() retruns the attribut. Should be val(''). Test plan : 1) Without patch 2) Edit a record 3) Edit a subfield with AV 4) Enter a new value to create it 5) You see the modal popup, edit and save 6) Enter another new value to create it 7) You see the modal popup => value is prefilled 8) Re-do test plan with patch (+ clear JS cache) => value is empty Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:28:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:28:37 +0000 Subject: [Koha-bugs] [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 16:28:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 15:28:47 +0000 Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100082|0 |1 is obsolete| | --- Comment #13 from Cori Lynn Arnold --- Created attachment 114079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114079&action=edit Bug 24709: Advanced editor - show space after delimiter visually This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be surrounded by an orange dotted border. To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the **delimiter the space and delimiter should be surrounded by a red dotted border. - Remove the extra space and confirm that the red dotted border is removed **To create a delimiter in the advanced editor, go to a non-control field (after 010) and hit the control button with the letter "d" then enter any letter or single digit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:24:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 16:24:39 +0000 Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 --- Comment #14 from Cori Lynn Arnold --- Created attachment 114080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114080&action=edit Correct Ubuntu versions in release notes - md Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:27:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 16:27:55 +0000 Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114080|1 |0 is patch| | Attachment #114080|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:45:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 16:45:13 +0000 Subject: [Koha-bugs] [Bug 26144] Due date should not be subtracted from billable days with FinesCalendar on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26144 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com Summary|Due date should not be |Due date should not be |subtracted from billable |subtracted from billable |days with FinesCaendar on |days with FinesCalendar on -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 17:46:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 16:46:18 +0000 Subject: [Koha-bugs] [Bug 24709] Advanced editor - show space after delimiter visually In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24709 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #15 from Cori Lynn Arnold --- This patch updates the JavaScript and CSS for the advanced MARC editor so that a space immediately following a delimiter will be surrounded by an orange dotted border. To test the EnableAdvancedCatalogingEditor system preference should be enabled. Apply the patch and clear your browser cache if necessary. - Go to Cataloging -> Advanced editor. - On any text entry line (e.g. 245), add a space immediately following the **delimiter the space and delimiter should be surrounded by a red dotted border. - Remove the extra space and confirm that the red dotted border is removed **To create a delimiter in the advanced editor, go to a non-control field (after 010) and hit the control button with the letter "d" then enter any letter or single digit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 19:21:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 18:21:43 +0000 Subject: [Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 19:21:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 18:21:45 +0000 Subject: [Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 --- Comment #15 from Cori Lynn Arnold --- Created attachment 114081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114081&action=edit Bug 24108: Advanced editor: configure if biblionumber or control number is used for saved files Creates a new system preference "SaveRecordbyControlNumber" which is initially set to 0 (off/no). By default saving .mrc (and .xml) will be saved by the biblionumber. If the record does not yet have a biblionumber, the record will be saved as record.mrc or record.xml Test plan: 1) Apply the patch, flush_memcached and restart_all 2) Enable the "EnableAdvancedCatalogingEditor" system preference 4) Save the record using the drop down box selecting "Save as MARC (.mrc) file. 5) Note that the file saved is the same as the biblionumber at the top of the Advanced Editor interface. 6) Repeat steps 3-5 for the .xml save option 7) Update the new system preference "SaveRecordbyControlNumber" and change to "Save by ControlNumber" 8) Verify that there is not a 001 field in the record (delete it if there is) 9) Repeat steps 3-5 for both .mrc and .xml options (the file should still be saved as the biblionumber if there is no control field) 10) Add a 001 field to the record such as "001 abc00012345" 11) Repeat step 4 for both .mrc and .xml and verify that the files saved are named abc00012345.mrc and abc00012345.xml 12) Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 19:31:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 18:31:32 +0000 Subject: [Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101381|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 19:31:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 18:31:43 +0000 Subject: [Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101382|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 19:32:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 18:32:00 +0000 Subject: [Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101384|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 19:49:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 18:49:26 +0000 Subject: [Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114081|0 |1 is obsolete| | --- Comment #16 from Cori Lynn Arnold --- Created attachment 114082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114082&action=edit Bug 24108: Advanced editor: configure if biblionumber or control number is used for saved files Fix typo with .xml extension -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 19:50:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 18:50:16 +0000 Subject: [Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 20:06:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 19:06:28 +0000 Subject: [Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 --- Comment #11 from Victor Grousset/tuxayo --- Merge requests to update koha-testing-docker and KohaDevBox https://gitlab.com/koha-community/koha-testing-docker/-/merge_requests/184 https://gitlab.com/koha-community/kohadevbox/-/merge_requests/285 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 20:58:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 19:58:36 +0000 Subject: [Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114081|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 21:15:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 20:15:22 +0000 Subject: [Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #17 from Cori Lynn Arnold --- Bug 24108: Advanced editor: configure if biblionumber or control number is used for saved files Updates based on QA feedback: 1. If the biblionumber is not set (not yet in the system) default to save to "record.mrc" and "record.xml", emulating the old behavior. 2. Lowercase "control number" and "biblionumber" in description. 3. Better system preference description. Creates a new system preference "SaveRecordbyControlNumber" which is initially set to 0 (off/no). By default saving .mrc (and .xml) will be saved by the biblionumber. If the record does not yet have a biblionumber, the record will be saved as record.mrc or record.xml Test plan: 1) Apply the patch, flush_memcached and restart_all 2) Enable the "EnableAdvancedCatalogingEditor" system preference 4) Save the record using the drop down box selecting "Save as MARC (.mrc) file. 5) Note that the file saved is the same as the biblionumber at the top of the Advanced Editor interface. 6) Repeat steps 3-5 for the .xml save option 7) Update the new system preference "SaveRecordbyControlNumber" and change to "Save by ControlNumber" 8) Verify that there is not a 001 field in the record (delete it if there is) 9) Repeat steps 3-5 for both .mrc and .xml options (the file should still be saved as the biblionumber if there is no control field) 10) Add a 001 field to the record such as "001 abc00012345" 11) Repeat step 4 for both .mrc and .xml and verify that the files saved are named abc00012345.mrc and abc00012345.xml 12) Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:40:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 22:40:44 +0000 Subject: [Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20582 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 [Bug 20582] Turn Koha into a Mojolicious application -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:40:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 22:40:44 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26791 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 [Bug 26791] Build Mojolicious controller replacement for export.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:41:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 22:41:44 +0000 Subject: [Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 [Bug 20582] Turn Koha into a Mojolicious application -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:41:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 22:41:44 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 [Bug 26791] Build Mojolicious controller replacement for export.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:43:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 22:43:24 +0000 Subject: [Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 --- Comment #20 from David Cook --- Technically Bug 26791 doesn't depend on Bug 20582, but I will need to do something for app.psgi from Bug 20582 before this work is complete... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 1 23:43:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 22:43:57 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 --- Comment #109 from David Cook --- Realizing too that app.psgi will need to be updated to include the plack.psgi changes for using timestamped logs.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 00:21:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 23:21:14 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Claudio changed: What |Removed |Added ---------------------------------------------------------------------------- CC|costalc at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 00:27:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 01 Dec 2020 23:27:41 +0000 Subject: [Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #53 from David Cook --- (In reply to Jonathan Druart from comment #52) > An easy (but lazy) implementation could be: > - Have a Koha::BackgroundJob::Plugin > - Your plugin class inherit it and has a > job_type="plugin|Your::Plugin::Class" > - Your plugin implement ->process > > You can now call ->enqueue to enqueue the job, and the worker will process > it when possible. Could you elaborate on this part? The koha-worker code would need to be updated to support that job_type="plugin|Your::Plugin::Class", right? > However we don't have the "at" part here, it should be done on a separate > bug report with bug 1993 in mind. > I'd love to do a POC for this. I'll comment on Bug 1993. (Now to find the time/energy...) > I think Tomas's idea was to have REST API routes to enqueue new jobs. +1 I like the idea although we'd want that API route to be private/highly privileged. Otherwise it might be accidentally abused. (I have been thinking how Koha could use a better separation of private/public API routes...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 02:07:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 01:07:30 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #56 from David Cook --- Since Koha has embraced Mojolicious, I'm thinking that I could write a "task_scheduler.pl" (koha-scheduler) using Mojo::EventEmitter and Mojo::IOLoop to get a reasonably good scheduler with a minimum amount of code. Ideally, its output would be sending messages to RabbitMQ. The real question is input and task storage. Bug 22417 gave us task storage. We could extend that to include scheduler information. As for input... I'd say the best solution would be communicating over a socket. Where all services are running locally, Unix socket is the easiest. For more distributed setups, we could make sure to use a TCP socket (we could even make it a HTTP API). (Looking at Minion, you can run it as a standalone job queue or leverage the event loop in a Mojolicious application. The latter option might not work when using Mojolicious as a PSGI application though. We do have Bug 20582 for turning Koha into a Mojolicious application though.) I can try to do a POC soon but can't make any guarantees... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 02:18:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 01:18:59 +0000 Subject: [Koha-bugs] [Bug 27088] Searching with just OR or AND gives error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27088 --- Comment #7 from David Cook --- (In reply to Jonathan Druart from comment #6) > IMO it's not a good idea to parse the query for such problems before we sent > it to ES. We should request ES and eventually provide feedback to the user > about why their query might have been syntactically wrong. Agreed. Putting too much query parsing into Koha has gotten us into trouble in the past. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 02:46:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 01:46:21 +0000 Subject: [Koha-bugs] [Bug 27114] Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27114 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- Can you explain why it would be better to do this in a Template::Toolkit plugin rather than doing it in the Perl script? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 06:20:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 05:20:48 +0000 Subject: [Koha-bugs] [Bug 27129] New: Issue in searching records in opac Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27129 Bug ID: 27129 Summary: Issue in searching records in opac Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: ujjwalguptax202 at gmail.com QA Contact: testopia at bugs.koha-community.org I successfully import books data in koha but when i try to find the book in opac section it not showing data but in staff interface data are present i dont know what to do i tried with zebra indexing of data using this command "sudo koha-rebuild-zebra -v -f library" but its not helpful whenever i run this command after few minutes my sever response closed so please help me out with this issue...... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:16:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 07:16:42 +0000 Subject: [Koha-bugs] [Bug 27130] New: Adding local cover image at item level shows 'File type' section Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 Bug ID: 27130 Summary: Adding local cover image at item level shows 'File type' section Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When adding a local cover image at item level, after file upload there is a section 'File type'. This is for multiple files upload into a zip for biblio level. Not sure how to fix this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:16:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 07:16:47 +0000 Subject: [Koha-bugs] [Bug 27130] Adding local cover image at item level shows 'File type' section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26145 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 [Bug 26145] Add the ability to attach a cover image at item level -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:16:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 07:16:47 +0000 Subject: [Koha-bugs] [Bug 26145] Add the ability to attach a cover image at item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27130 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 [Bug 27130] Adding local cover image at item level shows 'File type' section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:39:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 07:39:20 +0000 Subject: [Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the Koha bibliographic level itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #56 from Fridolin Somers --- Preference 'BiblioItemtypeInfo' should say it depends on preference 'OpacNoItemTypeImages' right ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:47:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 07:47:58 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113939|0 |1 is obsolete| | --- Comment #2 from Timothy Alexis Vass --- Created attachment 114083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114083&action=edit Bug 27080 - Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. According to Swedish law, fees become statute-barred after 3 years. With this option, we can use cleanup_database.pl to purge those from accountlines. NOTE: This commit also fixes indentations. You can use the -w option with git to ignore space differences. To test: 1) You will need a record in the accountlines table WHERE status = 'RETURNED' AND amountoutstanding > 0. 2) Run ./misc/cronjobs/cleanup_database.pl --statute-barred DAYS Where DAYS is 1 or greater. This will delete records from accountlines WHERE date is DAYS day(s) or older. 3) Confirm that records have been deleted. Sponsored-by: Lunds Universitetsbibliotek -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:55:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 07:55:35 +0000 Subject: [Koha-bugs] [Bug 27130] Adding local cover image at item level shows 'File type' section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:57:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 07:57:37 +0000 Subject: [Koha-bugs] [Bug 27130] Adding local cover image at item level shows 'File type' section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 08:57:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 07:57:40 +0000 Subject: [Koha-bugs] [Bug 27130] Adding local cover image at item level shows 'File type' section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 --- Comment #1 from Jonathan Druart --- Created attachment 114084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114084&action=edit Bug 27130: Don't display itemnumber under "File type" section There is no need to have the "File type" section when we attach a cover item to an item (we cannot upload a zip file) This patch removes the legend of the fieldset. Test plan: Attach a cover image to an image, then to a bibliographic record. Notice the change and confirm it makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:20:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:20:39 +0000 Subject: [Koha-bugs] [Bug 27131] New: Move code from circ/pendingreserves.pl to modules Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Bug ID: 27131 Summary: Move code from circ/pendingreserves.pl to modules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org We need the code covered by tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:21:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:21:24 +0000 Subject: [Koha-bugs] [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27131 --- Comment #134 from Jonathan Druart --- I've opened a new bug report. I don't think we should add more patch to this one. See bug 27131. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 [Bug 27131] Move code from circ/pendingreserves.pl to modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:21:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:21:24 +0000 Subject: [Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24488 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24488 [Bug 24488] Holds to Pull sometimes shows the wrong 'first patron' details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:23:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:23:56 +0000 Subject: [Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #1 from Jonathan Druart --- Created attachment 114085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114085&action=edit Bug 27131: Add get_items_that_can_fill -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:24:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:24:30 +0000 Subject: [Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #2 from Jonathan Druart --- Joonas, is that what you had in mind? Or where you talking about more code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:25:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:25:18 +0000 Subject: [Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #3 from Jonathan Druart --- This bug report has been opened after the discussion on bug 24488 starting at bug 24488 comment 127 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:38:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:38:52 +0000 Subject: [Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:39:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:39:02 +0000 Subject: [Koha-bugs] [Bug 26995] Drop column relationship from borrower tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26995 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Keywords| |rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:47:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:47:29 +0000 Subject: [Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #4 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #2) > Joonas, is that what you had in mind? Or where you talking about more code? Thanks! Something like this but I hope we could add more checks here for this to be useful for many other places in Koha, at least similar stuff is needed in . So ideally this would be the same check as when you check-in a book in staff interface and Koha check's whether the item can satisfy any of the holds in that biblio using this item. This includes checking also circulation rules. Currently the pendingreserves.pl has more bugs than just the incorrect patron information, it lists at least also wrong amount of items to pull and wrongs items / callnumbers to pull. To achieve a reusable solution across the whole Koha codebase we probably need to go on more granular level: Koha::Item::can_fill_hold Koha::Hold::get_items_that_can_fill Koha::Holds::get_items_that_can_fill -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:47:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:47:51 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Version|20.05 |unspecified See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26470 Status|NEW |ASSIGNED Depends on| |23463 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:47:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:47:51 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 [Bug 27003] action_logs table error when adding an item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:47:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:47:51 +0000 Subject: [Koha-bugs] [Bug 26470] itemnumber not available for plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26470 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27003 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:57:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:57:09 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:57:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:57:12 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 --- Comment #1 from Jonathan Druart --- Created attachment 114086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114086&action=edit Bug 27003: Item creation log must be done after the item is created Otherwise we don't have its itemnumber yet! Test plan: Add and modify an item and confirm that the action logs are created correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:57:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:57:33 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 09:59:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 08:59:19 +0000 Subject: [Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 --- Comment #5 from Joonas Kylmälä --- To further elaborate on the idea when we have Koha::Holds::get_items_that_can_fill then we could have in pendingreserves.pl something like this for biblio in biblios_with_holds: holds = biblio->holds items = holds->get_items_that_can_fill callnums = _get_callnumbers(items) itemtypes = _get_itypes(items) first_hold = biblio->first_hold_to_fill push @reservedata, { biblio->biblionumber, first_hold->hold_id, callnums, itemtypes .. } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:25:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:25:32 +0000 Subject: [Koha-bugs] [Bug 26150] Remove the use of jquery.checkboxes plugin from inventory page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26983 [Bug 26983] Selecting ALL Items in Inventory- only selects 20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:25:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:25:32 +0000 Subject: [Koha-bugs] [Bug 26983] Selecting ALL Items in Inventory- only selects 20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26150 Version|20.05 |unspecified Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26150 [Bug 26150] Remove the use of jquery.checkboxes plugin from inventory page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:28:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:28:27 +0000 Subject: [Koha-bugs] [Bug 26983] Selecting ALL Items in Inventory- only selects 20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26983 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:28:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:28:29 +0000 Subject: [Koha-bugs] [Bug 26983] Selecting ALL Items in Inventory- only selects 20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26983 --- Comment #1 from Jonathan Druart --- Created attachment 114087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114087&action=edit Bug 26983: Fix [un]select all links in inventory The select/unselect all links took into account only the items displayed when the page was loaded (so 20). Test plan: 1. Go to Tools-> Inventory-> Do a Search to produce more than 20 results 2. Select 50, 100 or All entries to show 3. click on Select All => All items must be selected, not only the first 20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:28:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:28:36 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi Status|Needs Signoff |Failed QA --- Comment #3 from Joonas Kylmälä --- Hi, I spotted few things to improve: 1) Instead of doing RAW SQL use Koha Koha::Account::Line objects and ->delete. 2) Move code somewhere else than C4: https://wiki.koha-community.org/wiki/Coding_Guidelines#DEPR3:_C4_deprecated_for_new_modules – unfortunately I don't have good suggestions as to what could be better place right now. 3) Split the formatting changes of the patch to its own patch in order to ease reviewing the changes and give us more confidence that the whitespace change won't accidentally do any logic changes, also it eases reverting and usage of git in general. 4) Add unit test for the new function I must say I don't know what those RETURNED accountlines are about so regarding whether this feature is something we want or if it should be implemented in some other way I cannot say, maybe I can research this topic later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:32:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:32:34 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #4 from Joonas Kylmälä --- And one more thing regarding the commit title: The format we use is "Bug XXX: YYY", and now in the patch it was "Bug XXXX - YYYY" so replace the dash with colon. Then the title doesn't have to be so long, it could be just "Bug 27080: Add --statute-barred option to cleanup_database.pl" and in body explain more verbosely e.g. The option purges all fees where the item has been returned and the fee is older than the given number of days. [...] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:37:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:37:20 +0000 Subject: [Koha-bugs] [Bug 26956] Allow "Show checkouts/fines to guarantor" to be set without a guarantor saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26956 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:37:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:37:22 +0000 Subject: [Koha-bugs] [Bug 26956] Allow "Show checkouts/fines to guarantor" to be set without a guarantor saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26956 --- Comment #1 from Jonathan Druart --- Created attachment 114088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114088&action=edit Bug 26956: Allow guarantor's controls to be set when a guarantee is created With AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor set to Allow, one can only see the controls for these values in the patron record *after* the patron has been saved with a guarantor. That makes a frustrating 2-step process. We should be able to set those values regardless of whether or not there is currently a guarantor on the account. Test plan: Create a guarantee and confirm that the 2 options "Show checkouts to guarantors" and "Show fines to guarantors" are displayed Select Yes, save Confirm that the values have been correctly saved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:37:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:37:28 +0000 Subject: [Koha-bugs] [Bug 26956] Allow "Show checkouts/fines to guarantor" to be set without a guarantor saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26956 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:42:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:42:13 +0000 Subject: [Koha-bugs] [Bug 26961] Patron name not shown at checkin if HidePatronName set to "Don't show" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26961 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |nick at bywatersolutions.com --- Comment #3 from Jonathan Druart --- The first occurrence of hide_patron_infos_if_needed=1 is coming from commit 258c538e76914e6c2023242b555bb38c6f1970b9 Bug 22203: Holds modal does not link to patorn account And I've asked Nick, see bug 22203 comment 9. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:52:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:52:23 +0000 Subject: [Koha-bugs] [Bug 26953] Phone & SMS transports always displayed in overdue status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26953 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Summary|Phone & SMS transports |Phone & SMS transports |always displayed in overdue |always displayed in overdue |status triggers and notices |status triggers |editor | CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- I don't them in the notice editor if the prefs are off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:54:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:54:13 +0000 Subject: [Koha-bugs] [Bug 26953] Phone & SMS transports always displayed in overdue status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26953 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:54:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:54:16 +0000 Subject: [Koha-bugs] [Bug 26953] Phone & SMS transports always displayed in overdue status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26953 --- Comment #2 from Jonathan Druart --- Created attachment 114089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114089&action=edit Bug 26953: Hide phone and itiva from "Overdue notice/status triggers" If the prefs are off we should not display the checkboxes Test plan: 1. Turn off PhoneNotification and TalkingTechItivaPhoneNotification 2. Go to the "Overdue notice/status triggers" and confirm that phone and itiva columns are not displayed 3. Turn the prefs on and confirm the checkboxes are now displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:56:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:56:01 +0000 Subject: [Koha-bugs] [Bug 26953] Phone & SMS transports always displayed in overdue status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26953 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114089|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 114090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114090&action=edit Bug 26953: Hide phone and itiva from "Overdue notice/status triggers" If the prefs are off we should not display the checkboxes Test plan: 1. Turn off PhoneNotification and TalkingTechItivaPhoneNotification 2. Go to the "Overdue notice/status triggers" and confirm that phone and itiva columns are not displayed 3. Turn the prefs on and confirm the checkboxes are now displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 10:56:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 09:56:19 +0000 Subject: [Koha-bugs] [Bug 26953] Phone & SMS transports always displayed in overdue status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26953 --- Comment #4 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > I don't them in the notice editor if the prefs are off. I don't *see* them in the notice editor if the prefs are off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:00:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:00:43 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org --- Comment #1 from Jonathan Druart --- Owen, Katrin, do you have any ideas where we could add this link? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:11:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:11:02 +0000 Subject: [Koha-bugs] [Bug 26859] Options to Batch Edit Batch Delete and Batch Merge are Sticky In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- I don't recreate this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:11:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:11:11 +0000 Subject: [Koha-bugs] [Bug 26859] Options to Batch Edit Batch Delete and Batch Merge are Sticky In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23349 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 [Bug 23349] Add batch operations to staff interface catalog search results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:11:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:11:11 +0000 Subject: [Koha-bugs] [Bug 23349] Add batch operations to staff interface catalog search results In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23349 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26859 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26859 [Bug 26859] Options to Batch Edit Batch Delete and Batch Merge are Sticky -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:12:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:12:02 +0000 Subject: [Koha-bugs] [Bug 26796] Error when trying to access Relative Checkouts between Professional and Organizational patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26796 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 26797 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:12:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:12:02 +0000 Subject: [Koha-bugs] [Bug 26797] Error when trying to access Relative Checkouts between Professional and Organizational patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 --- Comment #1 from Jonathan Druart --- *** Bug 26796 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:12:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:12:32 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #5 from Timothy Alexis Vass --- Look at the patch and see that I have added the functionality for purge_statute_barred_fees to be exactly as purge_zero_balance_fees that is already there. If the changes you suggest need to be done, they need to be done on a deeper level than this patch. That would increase the scope of this. I have adapted this to what is available, in precise alignment with what is already there. If C4 is deprecated, then there needs to be an alternative. Again, it increases the scope. The whitespace changes are strictly in the help section, to align all text that is already there, in alignment with what is already there. Also, I copy the Patch title from the top of this page, which is: Bug 27080 - Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. This patch introduces functionality which is required by Swedish law, so it will be applicable for all libraries using Koha in Sweden. The RETURNED is about items that have been returned. In Sweden, by law, fees are statute-barred after 3 years for books which have been returned. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:19:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:19:26 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #6 from Joonas Kylmälä --- (In reply to Timothy Alexis Vass from comment #5) > Look at the patch and see that I have added the functionality for > purge_statute_barred_fees to be exactly as purge_zero_balance_fees that is > already there. > > If the changes you suggest need to be done, they need to be done on a deeper > level than this patch. That would increase the scope of this. > > I have adapted this to what is available, in precise alignment with what is > already there. If C4 is deprecated, then there needs to be an alternative. > Again, it increases the scope. Yes, a bit more work, please look first if there is already a module for this under Koha/ directory, if not create a new module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:19:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:19:58 +0000 Subject: [Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 --- Comment #15 from Emmi Takkinen --- (In reply to Joonas Kylmälä from comment #14) > I think earlier I must have meant that in the patch "Bug 12388: Adjust > tests" the tests' the changes are made so that the expected order is by > issue date). If you read the code for the first test case changed here it > sets for both of the checkouts the same due date "$date_due = $today_daily;" > so it won't be able to test whether the sorting by date_due works. But yes, > what I meant that maybe we should have tests for the correct sorting, now I > understand that the original patch "Adjust tests" might have not had that > goal because it changed a test that was only for checking whether we get > separate "Checked out" and "Overdues" sections in the slip. So I think the > patch "Bug 12388: Adjust tests" is okay, but/and if you think it is > important there should be test for testing sorting order as well for the > slip. Yeah, "Bug 12388: Adjust tests" was simply meant to prevent tests from failing after adding sort with date_due. Just swapping titles and barcodes was enough to achieve this but maybe it wouldn't hurt to have different date due for another of those items (or just add another item with different date due). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:24:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:24:05 +0000 Subject: [Koha-bugs] [Bug 27132] New: Add a 'table_exists' method Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27132 Bug ID: 27132 Summary: Add a 'table_exists' method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org It would be handy if plugins had access to the method used by the installer/updatedatabase.pl, for the same use :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:25:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:25:29 +0000 Subject: [Koha-bugs] [Bug 26797] Error when trying to access Relative Checkouts between Professional and Organizational patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Version|20.05 |master --- Comment #2 from Jonathan Druart --- Confirmed on master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:28:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:28:25 +0000 Subject: [Koha-bugs] [Bug 26797] Error when trying to access Relative Checkouts between Professional and Organizational patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:28:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:28:28 +0000 Subject: [Koha-bugs] [Bug 26797] Error when trying to access Relative Checkouts between Professional and Organizational patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 --- Comment #3 from Jonathan Druart --- Created attachment 114091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114091&action=edit Bug 26797: Escape firstname to prevent relative's checkouts to crash If no firstname is defined for a relative, the "Relative's checkouts" tab will be "processing" forever. JS error: TypeError: oObj.borrower.firstname is null Test plan: Patron A is Org and guarantor of patron B Check an item out to B Go to the details page of A, click "Relative's checkouts" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:30:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:30:12 +0000 Subject: [Koha-bugs] [Bug 27133] New: Header missing for "Copy no" on the relative's checkouts table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Bug ID: 27133 Summary: Header missing for "Copy no" on the relative's checkouts table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:30:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:30:31 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19351 --- Comment #1 from Jonathan Druart --- Caused by commit a8e5d9ab9f3dc690f007bb6893af71edf26a473f Bug 19351: Add items.copynumber to the checkouts table Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19351 [Bug 19351] Add copynumber in the checkouts table in staff interface -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:30:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:30:31 +0000 Subject: [Koha-bugs] [Bug 19351] Add copynumber in the checkouts table in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19351 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 [Bug 27133] Header missing for "Copy no" on the relative's checkouts table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:31:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:31:03 +0000 Subject: [Koha-bugs] [Bug 26797] Error when trying to access Relative Checkouts between Professional and Organizational patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27133 --- Comment #4 from Jonathan Druart --- Note that there is a UI issue display (header number mismatch). See bug 27133. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:31:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:31:03 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26797 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:32:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:32:45 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:32:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:32:48 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 --- Comment #2 from Jonathan Druart --- Created attachment 114092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114092&action=edit Bug 27133: (bug 19351 follow-up) Add missing "Copy no" header to relative's checkouts Test plan: Add a guarantee, go to the relative's checkouts list and confirm that the number of headers is not correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:34:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:34:16 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:34:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:34:26 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:36:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:36:56 +0000 Subject: [Koha-bugs] [Bug 27132] Add a 'table_exists' method for using on plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27132 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a 'table_exists' method |Add a 'table_exists' method | |for using on plugins -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:41:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:41:21 +0000 Subject: [Koha-bugs] [Bug 26701] Deal with scripts in C4/SIP directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26701 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com --- Comment #1 from Jonathan Druart --- There don't bring much, I am in favour of removing them. At least C4/SIP/interactive_renew_all_dump.pl is broken since commit d85f757ce7bf446705a8d76bc0d2280705a2d88d Date: Thu Oct 30 15:36:09 2014 +0000 Bug 7904 Change SIP modules to use standard LIB path Kyle, Colin, are you using them? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:50:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:50:02 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:50:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:50:04 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114086|0 |1 is obsolete| | --- Comment #2 from Nick Clemens --- Created attachment 114093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114093&action=edit Bug 27003: Item creation log must be done after the item is created Otherwise we don't have its itemnumber yet! Test plan: Add and modify an item and confirm that the action logs are created correctly Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:50:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:50:20 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Nick Clemens --- Small patch, passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:51:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:51:49 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #7 from Timothy Alexis Vass --- (In reply to Joonas Kylmälä from comment #6) > (In reply to Timothy Alexis Vass from comment #5) > > Look at the patch and see that I have added the functionality for > > purge_statute_barred_fees to be exactly as purge_zero_balance_fees that is > > already there. > > > > If the changes you suggest need to be done, they need to be done on a deeper > > level than this patch. That would increase the scope of this. > > > > I have adapted this to what is available, in precise alignment with what is > > already there. If C4 is deprecated, then there needs to be an alternative. > > Again, it increases the scope. > > Yes, a bit more work, please look first if there is already a module for > this under Koha/ directory, if not create a new module. So the scope becomes rewriting the entire C4/Accounts.pm module as a new module? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:55:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:55:59 +0000 Subject: [Koha-bugs] [Bug 27050] Allow multiple category_codes in delete_patrons.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27050 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:56:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:56:01 +0000 Subject: [Koha-bugs] [Bug 27050] Allow multiple category_codes in delete_patrons.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27050 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114042|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 114094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114094&action=edit Bug 27050 - Allow multiple category_codes in delete_patrons.pl This patch allows multiple --category_code in delete_patrons.pl The t/db_dependent/Members.t test has 2 added testcases with multiple category_code. To test: 1) Run the test: prove -l . -v t/db_dependent/Members.t 2) This requires records in the database with at least two category codes. For example PT and ST. 3) Run the script: delete_patrons.pl --category_code PT 4) Confirm the number of patrons that would have been deleted. 5) Run the script: delete_patrons.pl --category_code PT --category_code ST 6) Confirm the number of patrons that would have been deleted. 7) Sign Off Sponsored-by: Lunds Universitetsbibliotek Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:56:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:56:20 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #8 from Timothy Alexis Vass --- At minimum, what you are requesting changes the scope to move and rewrite purge_zero_balance_fees and also purge_statute_barred_fees from C4/Accounts.pm to Koha/Accounts.pm along with updated unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:57:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:57:11 +0000 Subject: [Koha-bugs] [Bug 8879] Silence unneeded messages from running prove ./t (omnibus) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8879 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 25515 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:57:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:57:11 +0000 Subject: [Koha-bugs] [Bug 25515] Remove warnings and errors from tests output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #3 from Jonathan Druart --- *** Bug 8879 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:58:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:58:49 +0000 Subject: [Koha-bugs] [Bug 26700] Remove unused C4/SIP/t directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26700 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15956, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9848, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9845, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9842, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9838 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:58:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:58:49 +0000 Subject: [Koha-bugs] [Bug 15956] Rearranging some SIP unit tests (testable without SIP server) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15956 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26700 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:58:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:58:49 +0000 Subject: [Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additional checkin) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26700 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:58:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:58:49 +0000 Subject: [Koha-bugs] [Bug 9845] SIP tests : fix in 08checkin.t ("alert" field) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9845 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26700 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:58:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:58:49 +0000 Subject: [Koha-bugs] [Bug 9842] SIP tests : fix for 07hold.t on Cancel Hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9842 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26700 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:58:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:58:49 +0000 Subject: [Koha-bugs] [Bug 9838] SIP tests : fix in 04patron_status.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9838 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26700 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 11:59:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 10:59:25 +0000 Subject: [Koha-bugs] [Bug 27050] Allow multiple category_codes in delete_patrons.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27050 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Note that step 5 should be: 5) Run the script: delete_patrons.pl --category_code PT --category_code ST The last category_code was category-code in the original test plan, with that you get 'Unknown option: category-code' error when running. Everything then works as per the test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:00:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 11:00:47 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #4 from Jonathan Druart --- Thanks Nick! I'd like a separate QA stamp, just in case. We are going to backport it and it touches a ->store method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:02:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 11:02:41 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #9 from Joonas Kylmälä --- (In reply to Timothy Alexis Vass from comment #7) > So the scope becomes rewriting the entire C4/Accounts.pm module as a new > module? No, just focus on the parts that matter for this bug. It would be welcome, but not necessary, to refactor the already existing related functions. In this case it would be only purge_zero_balance_fees() and that would need to be moved to some module in Koha namespace. Then the new function purge_statute_barred_fees() could be added in later patch to go to this same module. Or you can also go the easier route, which is to add only purge_statute_barred_fees() to a module in Koha namespace. Then in the future we can tidy up C4/Accounts.pm a bit by moving purge_zero_balance_fees() also to the module in Koha namespace. Let me know if you get stuck somewhere or need clarifications on the requested improvements. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:06:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 11:06:26 +0000 Subject: [Koha-bugs] [Bug 26957] Find duplicate removes operators from the middle of search terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26957 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:12:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 11:12:13 +0000 Subject: [Koha-bugs] [Bug 27134] New: Zebra reindexing Searching issue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27134 Bug ID: 27134 Summary: Zebra reindexing Searching issue Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: ujjwalguptax202 at gmail.com i installed my koha on AWS and i backup my old koha data and update in new koha but when i was trying to search my data on catalog it not there so i use this command "sudo koha-rebuild-zebra -v -f library" for reindexing but it stop at the record of 70401 and after that killed the process and shows the "Something went wrong rebuilding biblio indexes for library" and also my AWS instace running but when i open my staff interface it not connecting after few min. it automatcally start but my reindexing not working please help me with this i also tied this to export PERL5LIB=/usr/share/koha/lib export KOHA_CONF=/usr/share/koha/koha-conf.xml /usr/share/koha/bin/migration_tools/rebuild_zebra.pl -b -r -v -x but again i got same issue please please help me with this issue may be its issue with AWS or in koha i dont know and i am not able to any solution for this please help me..... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:13:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 11:13:49 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24254 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:13:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 11:13:49 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Biblio get_visible_items method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15448 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:18:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 11:18:01 +0000 Subject: [Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the Koha bibliographic level itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #57 from Nick Clemens --- (In reply to Fridolin Somers from comment #56) > Preference 'BiblioItemtypeInfo' should say it depends on preference > 'OpacNoItemTypeImages' right ? I don't think so. This controls whether we display information about the record itemtype (description or code) the other controls if the images are displayed or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 12:56:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 11:56:44 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #10 from Timothy Alexis Vass --- If one part is to be refactored then it's a tiny step to refactor what is related too. I suggest changing the scope of this one to refactor and update command line cleanup of accountlines, that would include both functions and related unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 13:34:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 12:34:04 +0000 Subject: [Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:33:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 13:33:42 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20168 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:33:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 13:33:42 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26665 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:34:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 13:34:11 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 --- Comment #1 from Jonathan Druart --- Request URL: http://kohadev.mydnsname.org:8080/opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.min.js Request Method: GET Status Code: 404 Not Found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:36:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 13:36:43 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:36:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 13:36:46 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 --- Comment #2 from Jonathan Druart --- Created attachment 114095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114095&action=edit Bug 26665: (bug 20168 follow-up) Fix path to bootstrap js file 20168 moved it to /opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.bundle.min.js It fixed the OAI-PMH view Test plan: Hit /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marc21 and confirm that you can click "Metadata" and it opens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:37:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 13:37:03 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Keywords| |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:40:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 13:40:26 +0000 Subject: [Koha-bugs] [Bug 26422] Can't call method "title" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-detail.pl line 459. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26422 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED --- Comment #2 from Jonathan Druart --- Hi Pablo, Either your search engine did not have its index up-to-date, or you were facing bug 25826. I am closing this bug report, please reopen if it's still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:43:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 13:43:42 +0000 Subject: [Koha-bugs] [Bug 26405] Circulation.t fails on 'AddRenewal left both fines' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26405 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Yes, we could mock the pref. Can you provide a patch please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:46:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 13:46:23 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |20.05 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- Valid in 20.05.x Owen, could you have a look? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 14:50:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 13:50:52 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 --- Comment #2 from Jonathan Druart --- It's coming from bug 10309, but it has never been copied from ccsr. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:10:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:10:24 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:10:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:10:47 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 --- Comment #2 from Owen Leonard --- Created attachment 114096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114096&action=edit Screenshot of proposed change I suggest we add it to the "More" menu in the header -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:33:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:33:40 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:33:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:33:43 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 --- Comment #3 from Owen Leonard --- Created attachment 114097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114097&action=edit Bug 26905: Purchase suggestion button hidden for users with suggestion permission but not acq permission This patch adds a link to purchase suggestions from the header menu's "More" submenu for users with suggestions management permission. To test, apply the patch and log in to the staff interface as a user with "suggestions_manage" permission. - Click the "More" menu item in the header. You should see a link to "Suggestions" which takes you to the suggestions management page. - Log in as a user without "suggestions_manage" permission. The link should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:36:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:36:03 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:38:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:38:01 +0000 Subject: [Koha-bugs] [Bug 26578] OverDrive results can return false positives when searches contain CCL syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26578 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:38:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:38:03 +0000 Subject: [Koha-bugs] [Bug 26578] OverDrive results can return false positives when searches contain CCL syntax In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26578 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114058|0 |1 is obsolete| | --- Comment #4 from Kelly McElligott --- Created attachment 114098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114098&action=edit Bug 26578: Clean overdrive searches before passing to OD This patch copies regex used in buildQuery to detect ccl code in queries, but here we adapt it to remove any ccl signifiers to ensure correct results from OD To test: 1 - Have OverDrive enabled and configured 2 - set UseAuthoritiesForTracings to "Don't use" 3 - Search in the catalog for a record 4 - From the details page for a record click on an author link 5 - Note the query in catalog is like 'au:"Whitford, Bradley."' 6 - Some overdrive catalogs will return records matching 'au:' 7 - Apply patch 8 - Reload the page, if there were spurious results before, they should now be gone 9 - Perform a search that returns overdrive results 10 - For a title in overdrive search koha with: au:{Author} AND ti:{Title} 11 - Confirm overdrive results are returned 12 - Check the link to overdrive results and note query section is: q=Author AND Title Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:39:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:39:55 +0000 Subject: [Koha-bugs] [Bug 26436] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|19.11 |unspecified Depends on| |3766 --- Comment #1 from Jonathan Druart --- Confirmed in master. Certainly broken by commit 4605d76a73f9b13ba3b0259e3f480fb396051309 Bug 3766: Cities/Towns only on one address Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 [Bug 3766] Cities/Towns only on one address -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:39:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:39:55 +0000 Subject: [Koha-bugs] [Bug 3766] Cities/Towns only on one address In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 [Bug 26436] Quick add patron will not copy over details from cities and towns pull down into patron details -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:40:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:40:23 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #13 from Fridolin Somers --- DBIx class changes has been pushed in 19.11.08 : 58e7d0b44a Bug 20882: DBIC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:40:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:40:44 +0000 Subject: [Koha-bugs] [Bug 26436] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26436 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18569 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:40:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:40:44 +0000 Subject: [Koha-bugs] [Bug 18569] Quick add patron will not copy over details from cities and towns pull down into patron details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18569 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26436 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:42:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:42:05 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 --- Comment #4 from Jonathan Druart --- Yes, I thought about that as well. Maybe after "Acquisition"? Right now it's between a R and T, but others are not alpha ordered :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:42:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:42:55 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 --- Comment #5 from Jonathan Druart --- And... maybe we weird "suggestion", but shouldn't we display it only if it's not accessible from the acquisition module? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 15:59:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 14:59:57 +0000 Subject: [Koha-bugs] [Bug 26797] Error when trying to access Relative Checkouts between Professional and Organizational patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:00:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 15:00:00 +0000 Subject: [Koha-bugs] [Bug 26797] Error when trying to access Relative Checkouts between Professional and Organizational patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114091|0 |1 is obsolete| | --- Comment #5 from Kelly McElligott --- Created attachment 114099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114099&action=edit Bug 26797: Escape firstname to prevent relative's checkouts to crash If no firstname is defined for a relative, the "Relative's checkouts" tab will be "processing" forever. JS error: TypeError: oObj.borrower.firstname is null Test plan: Patron A is Org and guarantor of patron B Check an item out to B Go to the details page of A, click "Relative's checkouts" Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:06:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 15:06:06 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:06:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 15:06:08 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114092|0 |1 is obsolete| | --- Comment #3 from Kelly McElligott --- Created attachment 114100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114100&action=edit Bug 27133: (bug 19351 follow-up) Add missing "Copy no" header to relative's checkouts Test plan: Add a guarantee, go to the relative's checkouts list and confirm that the number of headers is not correct Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:07:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 15:07:29 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:07:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 15:07:32 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 --- Comment #3 from Owen Leonard --- Created attachment 114101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114101&action=edit Bug 26397: opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:27:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 15:27:26 +0000 Subject: [Koha-bugs] [Bug 27114] Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27114 --- Comment #3 from Fridolin Somers --- (In reply to David Cook from comment #2) > Can you explain why it would be better to do this in a Template::Toolkit > plugin rather than doing it in the Perl script? It will be easier to add it in other places, like MARC details page for example. Hooks intranet/opac_js/header are already in this TT plugin. Maybe easier to include in test suite ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:27:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 15:27:53 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Biblio get_visible_items method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #4 from Tomás Cohen Arazi --- Hi, Nick. I like your approach but have two suggestions: 1. Allow to optionally get passed the rules. This way if the caller is (say) the opac-search.pl script, we could read the rules once and reuse them. 2. Add this method to Koha::Items, renamed as ->filter_by_visible_in_opac or similar in the way we've been adding lately. The method would basically do the same: sub filter_by_visible_in_opac { my ($self, $params) = @_; my $rules = (exists $params->{rules}) ? $params->{rules} : get_yaml_pref_hash('OpacHiddenItems'); my $search_params; foreach my $field (keys %$rules){ $search_params->{$field}->{'not in'} = $rules->{$field}; } return $self->search( $search_params ); } Then when you use it, you can chain the calls: my $visible_items = $biblio->items->filter_by_visible_in_opac; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:39:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 15:39:49 +0000 Subject: [Koha-bugs] [Bug 27130] Adding local cover image at item level shows 'File type' section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 --- Comment #2 from Fridolin Somers --- When attaching a cover image to an item, form has a
    without
  1. :
    add a
  2. ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:42:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 15:42:38 +0000 Subject: [Koha-bugs] [Bug 8732] Add a system preference to allow users to choose to display an icon based on the Koha bibliographic level itemtype In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8732 --- Comment #58 from Fridolin Somers --- (In reply to Nick Clemens from comment #57) > (In reply to Fridolin Somers from comment #56) > > Preference 'BiblioItemtypeInfo' should say it depends on preference > > 'OpacNoItemTypeImages' right ? > > I don't think so. This controls whether we display information about the > record itemtype (description or code) the other controls if the images are > displayed or not. Ah ok thanks :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 16:54:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 15:54:23 +0000 Subject: [Koha-bugs] [Bug 27130] Adding local cover image at item level shows 'File type' section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114084|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 114102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114102&action=edit Bug 27130: Don't display itemnumber under "File type" section There is no need to have the "File type" section when we attach a cover item to an item (we cannot upload a zip file) This patch removes the legend of the fieldset. Test plan: Attach a cover image to an image, then to a bibliographic record. Notice the change and confirm it makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:08:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 16:08:28 +0000 Subject: [Koha-bugs] [Bug 27130] Adding local cover image at item level shows 'File type' section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:08:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 16:08:31 +0000 Subject: [Koha-bugs] [Bug 27130] Adding local cover image at item level shows 'File type' section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114102|0 |1 is obsolete| | --- Comment #4 from Fridolin Somers --- Created attachment 114103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114103&action=edit Bug 27130: Don't display itemnumber under "File type" section There is no need to have the "File type" section when we attach a cover item to an item (we cannot upload a zip file) This patch removes the legend of the fieldset. Test plan: Attach a cover image to an image, then to a bibliographic record. Notice the change and confirm it makes sense. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:09:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 16:09:19 +0000 Subject: [Koha-bugs] [Bug 27130] Adding local cover image at item level shows 'File type' section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114103|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers --- Created attachment 114104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114104&action=edit Bug 27130: Don't display itemnumber under "File type" section There is no need to have the "File type" section when we attach a cover item to an item (we cannot upload a zip file) This patch removes the legend of the fieldset. Test plan: Attach a cover image to an item, then to a bibliographic record. Notice the change and confirm it makes sense. Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:17:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 16:17:54 +0000 Subject: [Koha-bugs] [Bug 27135] New: Viewing local cover images at item level shows a link to upload image at record level Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 Bug ID: 27135 Summary: Viewing local cover images at item level shows a link to upload image at record level Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When viewing local cover images at item level : /cgi-bin/koha/catalogue/imageviewer.pl?itemnumber=X&imagenumber=Y Page shows a link to upload image at record level : /cgi-bin/koha/tools/upload-cover-image.pl?biblionumber=108&filetype=image This link should point to uploading at item level no ? PS : viewer should display some information about the item, like barcode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:18:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 16:18:05 +0000 Subject: [Koha-bugs] [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26145 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 [Bug 26145] Add the ability to attach a cover image at item level -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:18:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 16:18:05 +0000 Subject: [Koha-bugs] [Bug 26145] Add the ability to attach a cover image at item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26145 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27135 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:49:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 16:49:40 +0000 Subject: [Koha-bugs] [Bug 26943] Show not for loan descriptions in cataloging search (addbooks.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:49:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 16:49:43 +0000 Subject: [Koha-bugs] [Bug 26943] Show not for loan descriptions in cataloging search (addbooks.pl) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26943 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113429|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 114105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114105&action=edit Bug 26943: Add notforloan statuses to catalog search - create a positive value and a description of "Positive" - set an item to your "Positive" value - pull up the related bib in a cataloging search - confirm it shows "Not for loan" in the Location column - create a negative value and a description of "Negative" - set an item to your "Negative" value - pull up the related bib in a cataloging search - confirm it shows "On order" in the Location column - Apply patch - re-do the cataloing search, instead of 'Not for loan' or 'On order' you should instead see the actual nfl description Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:54:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 16:54:47 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114059|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 114106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114106&action=edit Bug 25026: Turn on RaiseError This is a follow-up for bug 22001. The patch "Bug 22001: Set unsafe only if RaiseError is not set" proved that unsafe => 1 and RaiseError => 0 was wrong. We should move forward and turn RaiseError for the UI, and... see what's happening. The change goes to the right direction, but we need to know how big is the task to have a stable release with these parameters correctly set. We will have a lot of fun once this patch is pushed! :) Test plan: 0. Does not apply the patch 1. Add, somewhere in mainpage.pl C4::Acquisition::NewBasket(); 2. restart_all 3. Hit the mainpage => Hum... nothing happens! However there is an error in the logs DBI Exception: DBD::mysql::db do failed: Column 'booksellerid' cannot be null No basket has been created! 4. Apply the patch, restart_all 5. Hit the mainpage => Here we go, there was something wrong and the user is aware of that! Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 17:58:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 16:58:44 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Needs Signoff |Signed Off --- Comment #9 from Victor Grousset/tuxayo --- It works! 💥💥💥 About comment 7 , in koha-testing-docker, I edited misc4dev/populate_db.pl and did reset_all, was that correct? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 18:54:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 17:54:02 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Biblio get_visible_items method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 19:07:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 18:07:17 +0000 Subject: [Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|agustinmoyano at theke.io |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 19:16:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 18:16:20 +0000 Subject: [Koha-bugs] [Bug 26991] Add action logs to search engine administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26991 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david at davidnind.com --- Comment #2 from David Nind --- Patch no longer applies 8-(.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 19:58:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 18:58:47 +0000 Subject: [Koha-bugs] [Bug 25583] When ClaimReturnedLostValue is not set, the claim returned tab doesn't appear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 20:39:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 19:39:42 +0000 Subject: [Koha-bugs] [Bug 27136] New: Add languages and avoid displaying nothing in facet Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Bug ID: 27136 Summary: Add languages and avoid displaying nothing in facet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: alexis.ripetti at inLibro.com Adding some languages : Cree, Afrikaans and Multiple languages, Undetermined and No linguistic content. Also adding a way to avoid displaying nothing in facet for opac and client staff when using elasticsearch as SearchEngine. Test plan: 1) Do a search, like 'a' 2) Look in the bottom of the sidebar on the left and see that there is an empty language 3) Apply patch 4) Update database 5) Do the same research 6) See that there is now "No information provided" You can test translation : TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for opac, e.g. misc/translator/po/fr-FR-opac-bootstrap.po - Locate strings pulled from koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-facets.inc for translation, e.g.: msgid "%s%s%sNo information provided%s" msgstr "" - Edit the "msgstr" string however you want (it's just for testing), example : msgstr "%s%s%sAucune information fournie%s" Do the same for the client staff : - Open the corresponding .po file for opac, e.g. misc/translator/po/fr-FR-staff-prog.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/en/includes/facets.inc for translation, e.g.: msgid "%s%s%sNo information provided%s" msgstr "" - Edit the "msgstr" string however you want (it's just for testing), example : msgstr "%s%s%sAucune information fournie%s" - Install the updated translation: > perl translate install fr-FR -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 20:44:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 19:44:07 +0000 Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 20:44:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 19:44:10 +0000 Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 --- Comment #1 from Alexis Ripetti --- Created attachment 114107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114107&action=edit Bug 27136 - Add languages and avoid displaying nothing in facet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 20:59:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 19:59:16 +0000 Subject: [Koha-bugs] [Bug 25583] When ClaimReturnedLostValue is not set, the claim returned tab doesn't appear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113878|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo --- Created attachment 114108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114108&action=edit Bug 25583: Disable the "claim returned" button if the feature is disabled It's possible to display the "Return claims" column on the checkout list, even if the feature is disabled. We should disable the link and add an explanation. Test plan: - Make sure ClaimReturnedLostValue is empty - Go to a patron account - Check out an item - Make the claims returned column visible in the table of checkouts => The button is disabled and a tooltip explains that the feature is disabled Signed-off-by: Kyle M Hall Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:04:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:04:36 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 --- Comment #6 from Owen Leonard --- (In reply to Jonathan Druart from comment #5) > And... maybe we weird "suggestion", but shouldn't we display it only if it's > not accessible from the acquisition module? I don't see any reason to hide it. Whether or not the user has acquisitions permissions it's still a tool that one might want to access directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:28:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:28:57 +0000 Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97404|0 |1 is obsolete| | Attachment #97566|0 |1 is obsolete| | Attachment #98728|0 |1 is obsolete| | --- Comment #8 from Cori Lynn Arnold --- Created attachment 114109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114109&action=edit Bug 24429 - Advanced editor - Add ability to generate an export file as cataloger saves Adds the ability for catalogers to *automatically* save a list of bibs to export as they are cataloging. To test, apply patch: 0/Verify that the advanced editor is enabled by going to "Administration" and searching for "EnableAdvancedCatalogingEditor" 1/Set it to "Enable" if it isn't already. 2/Go to "Cataloging", click on "Advanced editor" 3/Click on "Export" button (verify a modal window comes up) 4/Click on the link for "New Export File", name the export file 5/Close the modal window 6/Search for a record by entering "specious" in the keyword box and hitting enter 7/Click "import" on a record 8/Make some changes and hit "Save", note the bib number 9/Repeat steps 6-8 for several records, getting records from the catalog and importing through the "import" button in the UI 10/Click on "Export..." button 11/Click on the link for the name you created in step 4 12/Verify the bib numbers from step 8 are in the Export Files Editor 13/Click "Generate Export File" 14/Verify that all the records for every bib listed is in the file generated 15/Repeat steps with different file names / records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:31:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:31:48 +0000 Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429 --- Comment #9 from Cori Lynn Arnold --- Created attachment 114110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114110&action=edit Bug 24429 - Advanced editor - Add ability to generate an export file as cataloger saves Adds the ability for catalogers to *automatically* save a list of bibs to export as they are cataloging. To test, apply patch: 0/Verify that the advanced editor is enabled by going to "Administration" and searching for "EnableAdvancedCatalogingEditor" 1/Set it to "Enable" if it isn't already. 2/Go to "Cataloging", click on "Advanced editor" 3/Click on "Export" button (verify a modal window comes up) 4/Click on the link for "New Export File", name the export file 5/Close the modal window 6/Search for a record by entering "specious" in the keyword box and hitting enter 7/Click "import" on a record 8/Make some changes and hit "Save", note the bib number 9/Repeat steps 6-8 for several records, getting records from the catalog and importing through the "import" button in the UI 10/Click on "Export..." button 11/Click on the link for the name you created in step 4 12/Verify the bib numbers from step 8 are in the Export Files Editor 13/Click "Generate Export File" 14/Verify that all the records for every bib listed is in the file generated 15/Repeat steps with different file names / records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:32:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:32:41 +0000 Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114109|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:35:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:35:26 +0000 Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429 Cori Lynn Arnold changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114110|0 |1 is obsolete| | --- Comment #10 from Cori Lynn Arnold --- Created attachment 114111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114111&action=edit Bug 24429: Advanced editor - Add ability to generate an export file as cataloger saves Adds the ability for catalogers to *automatically* save a list of bibs to export as they are cataloging. To test, apply patch: 0/Verify that the advanced editor is enabled by going to "Administration" and searching for "EnableAdvancedCatalogingEditor" 1/Set it to "Enable" if it isn't already. 2/Go to "Cataloging", click on "Advanced editor" 3/Click on "Export" button (verify a modal window comes up) 4/Click on the link for "New Export File", name the export file 5/Close the modal window 6/Search for a record by entering "specious" in the keyword box and hitting enter 7/Click "import" on a record 8/Make some changes and hit "Save", note the bib number 9/Repeat steps 6-8 for several records, getting records from the catalog and importing through the "import" button in the UI 10/Click on "Export..." button 11/Click on the link for the name you created in step 4 12/Verify the bib numbers from step 8 are in the Export Files Editor 13/Click "Generate Export File" 14/Verify that all the records for every bib listed is in the file generated 15/Repeat steps with different file names / records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:35:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:35:29 +0000 Subject: [Koha-bugs] [Bug 24429] Advanced editor - Add ability to generate an export file as cataloger saves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24429 --- Comment #11 from Cori Lynn Arnold --- Created attachment 114112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114112&action=edit Bug 24429 - Advanced editor - Add ability to generate an export file as cataloger saves Adds the ability for catalogers to *automatically* save a list of bibs to export as they are cataloging. To test, apply patch: 0/Verify that the advanced editor is enabled by going to "Administration" and searching for "EnableAdvancedCatalogingEditor" 1/Set it to "Enable" if it isn't already. 2/Go to "Cataloging", click on "Advanced editor" 3/Click on "Export" button (verify a modal window comes up) 4/Click on the link for "New Export File", name the export file 5/Close the modal window 6/Search for a record by entering "specious" in the keyword box and hitting enter 7/Click "import" on a record 8/Make some changes and hit "Save", note the bib number 9/Repeat steps 6-8 for several records, getting records from the catalog and importing through the "import" button in the UI 10/Click on "Export..." button 11/Click on the link for the name you created in step 4 12/Verify the bib numbers from step 8 are in the Export Files Editor 13/Click "Generate Export File" 14/Verify that all the records for every bib listed is in the file generated 15/Repeat steps with different file names / records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:52:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:52:36 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:52:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:52:51 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 Arthur Suzuki changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109972|0 |1 is obsolete| | Attachment #109973|0 |1 is obsolete| | Attachment #109974|0 |1 is obsolete| | Attachment #109975|0 |1 is obsolete| | Attachment #109976|0 |1 is obsolete| | Attachment #109977|0 |1 is obsolete| | --- Comment #53 from Arthur Suzuki --- Created attachment 114113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114113&action=edit Bug 17314: Routes to handle purchase suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:53:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:53:09 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #54 from Arthur Suzuki --- Created attachment 114114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114114&action=edit Bug 17314: Migration from Swagger2 to OpenApi This patch migrates the original implementation so it uses the new OpenAPI plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:53:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:53:16 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #55 from Arthur Suzuki --- Created attachment 114115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114115&action=edit Bug 17314: (QA follow-up) Test plan unchanged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:53:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:53:23 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #56 from Arthur Suzuki --- Created attachment 114116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114116&action=edit Bug 17314: Added _to_model and _to_api methods and changed attirbutes naming -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:53:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:53:33 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #57 from Arthur Suzuki --- Created attachment 114117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114117&action=edit Bug 17314: (QA follow-up) Adjust spec This patch makes the exposed attribute names match what is defined in the internal mapping in the code, and also the query parameters. It also: - Makes 'status' an enum, as we know the list of possible values/codes... - Removes allow-owner and allow-guarantor, as said before, endpoints in /public namespace are allowed to use those. I didn't go and write those endpoints becuase I wasn't sure about the restrictions that apply in the OPAC and might differ from the ones in the staff interface. - Some numeric values are marked as such - Dates are strings in OpenAPI, but there's a way to specify the format inside the string: "format": "date". Use it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:53:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:53:40 +0000 Subject: [Koha-bugs] [Bug 17314] Routes to create, list and delete a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314 --- Comment #58 from Arthur Suzuki --- Created attachment 114118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114118&action=edit Bug 17314: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 21:56:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 20:56:17 +0000 Subject: [Koha-bugs] [Bug 27136] Add languages and avoid displaying nothing in facet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27136 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114107|0 |1 is obsolete| | --- Comment #2 from Alexis Ripetti --- Created attachment 114119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114119&action=edit Bug 27136 - Add languages and avoid displaying nothing in facet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 22:16:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 21:16:47 +0000 Subject: [Koha-bugs] [Bug 25583] When ClaimReturnedLostValue is not set, the claim returned tab doesn't appear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 --- Comment #8 from Victor Grousset/tuxayo --- It works :) About the phrasing, should we say "Claim returned is disabled" or "Return claims are disabled"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 22:36:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 21:36:57 +0000 Subject: [Koha-bugs] [Bug 26976] When renewalsallowed is empty the UI is not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26976 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113883|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 114120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114120&action=edit Bug 26976: Display 0 if renewalsallowed is not defined If the circulation rule "renewalsallowed" is not set (or an empty string) then the checkout list displays (0 of renewals remaining) It should display "0 of 0" Test plan: Set renewalsallowed to an empty string Check an item out Notice the change Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 22:39:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 21:39:45 +0000 Subject: [Koha-bugs] [Bug 26976] When renewalsallowed is empty the UI is not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26976 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 22:40:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 21:40:00 +0000 Subject: [Koha-bugs] [Bug 26976] When renewalsallowed is empty the UI is not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26976 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:07:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 22:07:58 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #11 from David Cook --- Can you elaborate on what "statute-barred" means? At a glance, it doesn't mean anything obvious in English. At a stretch, I'd guess that it means something isn't allowed by law (ie statute), but it's not clear what's not allowed. There might not be a problem with the wording per se, but we might want to add some more description about the meaning of the wording, since it's not clear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:31:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 22:31:37 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:31:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 22:31:42 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110576|0 |1 is obsolete| | --- Comment #46 from Aleisha Amohia --- Created attachment 114121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114121&action=edit Bug 12224: Print a slip of borrower's checkins for today To test: 1) Apply patch and run installer 2) Check out two items (or more) to a borrower 3) Check in two items (or more) for this borrower (you should end up on circ/returns.pl) 4) Notice the checked-in items table has started building. There should be a new column with the button 'Print checkin slip' in each row. 5) Click the button and confirm the checkin slip opens for printing in a new window. 6) Go to the patron's account 7) Click the Print dropdown. Confirm there is a 'Print checkin slip' option. Click this and confirm the checkin slip opens for printing in a new window. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Alexandra Speer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:31:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 22:31:47 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110577|0 |1 is obsolete| | --- Comment #47 from Aleisha Amohia --- Created attachment 114122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114122&action=edit Bug 12224: (follow-up) Move button to patron column in checkins table This patch moves the "Print checkin slip" out of its own column and into the colum containing patron information. I think this makes more sense because the slip is specific to a patron, not the individual item which has been checked in. Also changed: printcheckinslip function should be triggered via a class, not a non-unique ID. The function should handle the click using "preventDefault" rather than "return false." To test, apply the patch and check in some items checked out to various patrons. - In the table of checked-in items, confirm that the "Print checkin slip" appears correctly in the column of patron information. - Confirm that the button works correctly to print the correct slip for the associated patron. Signed-off-by: David Nind Signed-off-by: Alexandra Speer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:31:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 22:31:51 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110578|0 |1 is obsolete| | --- Comment #48 from Aleisha Amohia --- Created attachment 114123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114123&action=edit Bug 12224: (follow-up) Access old_issues table when editing notice This QA follow-up allows access to the old_issues table when editing the notice in Tools. Signed-off-by: Alexandra Speer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:31:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 22:31:56 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #49 from Aleisha Amohia --- Created attachment 114124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114124&action=edit Bug 12224: (follow-up) Switching to TT notice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:52:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 22:52:19 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #12 from Katrin Fischer --- (In reply to David Cook from comment #11) > Can you elaborate on what "statute-barred" means? At a glance, it doesn't > mean anything obvious in English. At a stretch, I'd guess that it means > something isn't allowed by law (ie statute), but it's not clear what's not > allowed. > > There might not be a problem with the wording per se, but we might want to > add some more description about the meaning of the wording, since it's not > clear. I was wondering about the term too, but the translations to German make sense and it appears to be an existing English term :) It's a legal term meaning kind of "expired". There has so much time passed, that the fee has "expired". In German: verjährt. Timothy - it's usually not good to broaden the scope, keep it to small steps. I suggest to do the refactoring of the existing code on a separate bug, making sure the havaviour is kept and then add the new option on top if you want to change both subs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 2 23:55:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 22:55:24 +0000 Subject: [Koha-bugs] [Bug 26713] Add pagination to bottom of saved SQL reports table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26713 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:37:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 23:37:44 +0000 Subject: [Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113900|0 |1 is obsolete| | --- Comment #4 from Agustín Moyano --- Created attachment 114125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114125&action=edit Bug 27068: Control hold group logic in HoldsQueue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 00:43:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 02 Dec 2020 23:43:05 +0000 Subject: [Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io --- Comment #5 from Agustín Moyano --- Hello Kyle, could you please checkout this patch? I've placed holds policy checking (including hold groups) inside a function called _checkHoldsPolicy, and call it whenever it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 01:37:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 00:37:45 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #13 from David Cook --- (In reply to Katrin Fischer from comment #12) > I was wondering about the term too, but the translations to German make > sense and it appears to be an existing English term :) It's a legal term > meaning kind of "expired". There has so much time passed, that the fee has > "expired". In German: verjährt. Thanks for the clarification, Katrin. It does appear to be an English legal term, and that it typically refers to debts. I love learning new things. Maybe --statue-barred-fees or --statute-barred-debts might be a little more explicit? Before Katrin explained the term to me, I probably could've intuited the meaning of "statue-barred-fees" or "statute-barred-debts", but I was confused what "thing" that "statute-barred" would refer to without my newfound knowledge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 01:39:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 00:39:01 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #10 from David Cook --- (In reply to Jonathan Druart from comment #7) > diff --git a/populate_db.pl b/populate_db.pl > index 097bbda..7d07aa6 100755 > --- a/populate_db.pl > +++ b/populate_db.pl > @@ -92,8 +92,8 @@ if ( $marcflavour ne 'MARC21' > > my $dbh = C4::Context->dbh; # At the beginning to die if DB does not exist. > > -my ( $prefs_count ) = $dbh->selectrow_array(q|SELECT COUNT(*) FROM > systempreferences|); > -my ( $patrons_count ) = $dbh->selectrow_array(q|SELECT COUNT(*) FROM > borrowers|); > +my ( $prefs_count ) = eval { $dbh->selectrow_array(q|SELECT COUNT(*) FROM > systempreferences|) }; > +my ( $patrons_count ) = eval { $dbh->selectrow_array(q|SELECT COUNT(*) FROM > borrowers|) }; > if ( $prefs_count or $patrons_count ) { > die "Database is not empty!"; > } > > You will need to apply this to koha-misc4dev first. Can you clarify why we need to do this? Is koha-misc4dev currently broken? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 01:39:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 00:39:31 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #11 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #9) > It works! 💥💥💥 > This could give me my first opportunity to QA! Looking forward to it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 01:46:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 00:46:56 +0000 Subject: [Koha-bugs] [Bug 27114] Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27114 --- Comment #4 from David Cook --- Hmm ok. I think I was opposed to this idea yesterday, but for some reason I seem in favour of it today heh. Since it's not modifying any existing data in detail.pl, I suppose there's no reason why it shouldn't just be handled in detail.tt, since it's really just updating the view. And then Bug 27120 makes sense too. In fact... I recently did a local customization that probably could've been done as a plugin, if Bug 27120 were pushed. (Actually, it was an OPAC one... so not relevant here, so having an OPAC equivalent would be good after all...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 01:47:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 00:47:42 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27120, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27114 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 01:47:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 00:47:42 +0000 Subject: [Koha-bugs] [Bug 27120] Send biblio to Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27120 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26890 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 01:47:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 00:47:42 +0000 Subject: [Koha-bugs] [Bug 27114] Use Template Toolkit plugin for Koha plugins hook 'intranet_catalog_biblio_tab' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27114 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26890 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 01:48:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 00:48:51 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 --- Comment #17 from David Cook --- After looking at Bug 27114 and Bug 27120, I reckon that it would be a good idea to get an "opac_catalog_biblio_tab" enhancement done. In fact, I just did a local customization recently which I could've done as a plugin instead, if an OPAC equivalent of those above bugs was completed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:04:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 01:04:39 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #60 from David Cook --- Actually, I got caught out by this one today, so I think I will have another crack at this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:23:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 01:23:35 +0000 Subject: [Koha-bugs] [Bug 27137] New: Move item doesn't show the title of the target record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Bug ID: 27137 Summary: Move item doesn't show the title of the target record Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Bug 11529 added this change to cataloguing/moveitem.pl my $biblio = Koha::Biblios->find( $biblionumber ); -$template->param(bibliotitle => $biblio->title); +$template->param(biblio => $biblio); But the template was not updated so it still tries to access the bibliotitle variable
    The item has successfully been attached to [% INCLUDE 'biblio-default-view.inc' %][% bibliotitle | html %]. Which no longer exists. So when the item is successfully moved, no biblio title is shown. This bug exists in 19.11 and 20.05 but not 20.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:23:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 01:23:49 +0000 Subject: [Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11529 Severity|enhancement |minor Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 [Bug 11529] Add subtitle, medium and part fields to biblio table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:23:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 01:23:49 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 [Bug 27137] Move item doesn't show the title of the target record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:35:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 01:35:16 +0000 Subject: [Koha-bugs] [Bug 27138] New: Host items are not included in Z39 results when using EasyAnalytics Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Bug ID: 27138 Summary: Host items are not included in Z39 results when using EasyAnalytics Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If a library enables EasyAnalytics and links two records in the catalog then the host items show on the child record. If you search for these records via Z3950 (via zebra directly or the responder) the host items are not shown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:45:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 01:45:39 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:45:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 01:45:42 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 --- Comment #1 from Nick Clemens --- Created attachment 114126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114126&action=edit Bug 27138: Index host items in child records when sending to search engine On the Koha side we seperate the items from the MARC record but we do put them in the search engines For easy analytics we embed host items when displaying results after fetching from the search engine We can simpify things and improve results by including the host items when indexing To test: 1 - Enable EasyAnalyticalRecords 2 - Find a record in the staff client 3 - From details page select Edit->Link to host record 4 - Attach a barcode from a different record 5 - Search for that barcode in the staff client 6 - Only host record is returned 7 - Perform a search that returns the child record and others 8 - Note the host item is listed on the child record in the results page 9 - Repeat on OPAC 10 - Note on opac that host item is missing on results 11 - Apply patch 12 - Search for barcode 13 - Child and host record returned on both staff and OPAC 14 - Child record correctly includes host item on staff and OPAC 15 - Connect to the Z3950 responder or zebra directly yaz-client localhost:2100 yaz-client unix:/var/run/koha/kohadev/bibliosocket 16 - Search for the child record base biblios find record_keyword show 1+10 17 - Note the record includes the host item 18 - Repeat tests for Elasticsearch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:45:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 01:45:58 +0000 Subject: [Koha-bugs] [Bug 27138] Host items are not included in Z39 results when using EasyAnalytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27138 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:47:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 01:47:05 +0000 Subject: [Koha-bugs] [Bug 27139] New: Search errors are incorrectly shown to users as no results found Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 Bug ID: 27139 Summary: Search errors are incorrectly shown to users as no results found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org When there is an error submitting a query to Zebra or Elasticsearch, the user should be informed that their query could not be completed due to an error with their search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 02:57:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 01:57:30 +0000 Subject: [Koha-bugs] [Bug 27088] Searching with just OR or AND gives error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27088 --- Comment #8 from David Cook --- (In reply to Jonathan Druart from comment #6) > IMO it's not a good idea to parse the query for such problems before we sent > it to ES. We should request ES and eventually provide feedback to the user > about why their query might have been syntactically wrong. I'm sure it's probably a duplicate but I've raised Bug 27139 about showing users that there has been a search query error. That being said... you can type gibberish into Google and Google will never tell you that you have a syntax error. (Although I just tried doing an "any of these words" advanced search in Google using "miniature OR" and it created a search query for "miniature OR OR" so even Google is a bit buggy / incorrectly documented when it comes to complex search.) (Typing '"urban keith" and "pickles"' into Google without the single quotes also gives different results to what I'd expect. I want to know about Urban Keith and not Keith Urban, although it seems that Google thinks I've made a typo.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 03:08:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 02:08:41 +0000 Subject: [Koha-bugs] [Bug 27139] Search errors are incorrectly shown to users as no results found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #1 from David Cook --- Related note: If you're using Zebra, you have QueryAutoTruncate enabled, and QueryWeightFields enabled, you'll have fairly simple query building happening. It leads to the following situation: Search: "Emperor penguin (Aptenodytes forsteri) foraging ecology" Query: @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 "Emperor penguin (Aptenodytes forsteri) foraging ecology" Search: Emperor penguin (Aptenodytes forsteri) foraging ecology Query: ZOOM error 10014 "CCL parsing error" (addinfo: "Operator expected") from diag-set 'ZOOM' Search: Emperor penguin \(Aptenodytes forsteri\) foraging ecology Query: @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 "Emperor penguin (Aptenodytes forsteri) foraging ecology" ZOOM::Query::CCL2RPN returns an exception with code, addinfo, message, and diagset fields: $VAR1 = bless( { 'code' => 10014, 'addinfo' => 'Operator expected', 'message' => 'CCL parsing error', 'diagset' => 'ZOOM' }, 'ZOOM::Exception' ); We would need to return this exception or derived data from C4::Search::getRecords() and then from Koha::SearchEngine::Zebra::Search::search_compat(). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 03:48:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 02:48:16 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #9 from Aleisha Amohia --- Created attachment 114127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114127&action=edit Bug 3150: WIP This is not ready yet! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 03:53:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 02:53:47 +0000 Subject: [Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 03:53:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 02:53:50 +0000 Subject: [Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 --- Comment #1 from Aleisha Amohia --- Created attachment 114128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114128&action=edit Bug 27137: Correctly show biblio title after successfully moving item In Bug 11529 we changed the variable that was passed to the template but missed updating the template. This patch ensures we correctly access the variable to show the title of the biblio. To test: 1) Create two biblios (Biblio A and Biblio B) 2) Add an item to Biblio A (Item A) 3) Go to Biblio B 4) In the cataloguing toolbar, click Edit, then Attach item 5) Enter the barcode for Item A and submit 6) Notice the item has successfully moved by Biblio B's title does not show 7) Apply patch 8) Go to Biblio A 9) In the cataloguing toolbar, click Edit, then Attach item 10) Enter the barcode for Item A and submit 11) Confirm Biblio A's title shows correctly Sponsored-by: Toi Ohomai Institute of Technology -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 03:54:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 02:54:15 +0000 Subject: [Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 03:54:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 02:54:55 +0000 Subject: [Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes a small release notes| |bug to ensure that the | |title of the target | |bibliographic record shows | |as expected upon | |successfully attaching an | |item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 04:28:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 03:28:53 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #61 from David Cook --- root at kohadevbox:koha(master)$ git checkout bug12430 Switched to branch 'bug12430' Your branch and 'origin/master' have diverged, and have 1 and 19114 different commits each, respectively. (use "git pull" to merge the remote branch into yours) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 04:32:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 03:32:23 +0000 Subject: [Koha-bugs] [Bug 16581] ICU tokenization bug in idzebra-2.0 2.0.59-1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16581 --- Comment #11 from David Cook --- We should probably update debian/control to require a newer version of Zebra since we know that 2.0.59 is buggy... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 04:35:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 03:35:11 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #62 from David Cook --- (In reply to David Nind from comment #51) > Everything works as per the the test plan, but tests fail: > > Test Summary Report > ------------------- > t/Search.t (Wstat: 256 Tests: 6 Failed: 1) > Failed test: 5 > Non-zero exit status: 1 > Files=1, Tests=6, 4 wallclock secs ( 0.03 usr 0.01 sys + 3.42 cusr 0.12 > csys = 3.58 CPU) > Result: FAIL It looks like the first patch is good, but my "Unit tests for buildQuery" patch is not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 04:59:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 03:59:12 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #63 from David Cook --- Changing the 2nd patch to use t/Search/buildQuery.t instead of t/Search.t because it's so complex it deserves to be in its own file... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 05:33:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 04:33:38 +0000 Subject: [Koha-bugs] [Bug 27140] New: koha-zebra doesn't properly stop Zebra Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27140 Bug ID: 27140 Summary: koha-zebra doesn't properly stop Zebra Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org So I just tried "koha-zebra --restart kohadev" after making a change to log levels to include request in koha-conf.xml in koha-testing-docker and it's a mess: root at kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" kohadev+ 808 1 0 02:04 ? 00:00:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 840 808 0 02:04 ? 00:00:00 [zebrasrv] kohadev+ 5183 1 0 04:28 ? 00:00:00 /usr/bin/zebrasrv -v none,fatal,warn -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 5373 3959 0 04:31 pts/1 00:00:00 grep zebrasrv Using "kill -9", I kill off all those. I run "koha-zebra --start kohadev": root at kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" kohadev+ 5418 1 0 04:31 ? 00:00:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 5422 5418 0 04:31 ? 00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 5424 3959 0 04:31 pts/1 00:00:00 grep zebrasrv That's much better now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 05:57:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 04:57:36 +0000 Subject: [Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 --- Comment #10 from David Cook --- Using koha-testing-docker w/o patch using CHR in /etc/koha/zebradb/etc/default.idx: QueryAutoTruncate: Query: test Request: @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 test Query: "test" Request: @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 @attr 2=102 test QueryWeightFields: Query: test Request: @attrset Bib-1 @or @or @or @or @or @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 test @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 test @attr 1= 36 @attr 4=1 @attr 9=26 @attr 2=102 test @attr 1=4 @attr 4=6 @attr 9=24 @attr 2=102 test @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 test @attr 4=6 @attr 5=1 @attr 9=14 @attr 2=102 "test? " @attr 4=6 @attr 9=14 @attr 2=102 test Query: "test" Request: @attrset Bib-1 @or @or @or @or @or @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 " test " @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 " test " @att r 1=36 @attr 4=1 @attr 9=26 @attr 2=102 " test " @attr 1=4 @attr 4=6 @attr 9=24 @attr 2=102 " test " @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 " test " @attr 4=6 @attr 5=1 @attr 9=14 @attr 2=102 "test? " @attr 4=6 @attr 9=14 @attr 2=1 02 " test " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:08:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:08:15 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99141|0 |1 is obsolete| | --- Comment #64 from David Cook --- Created attachment 114129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114129&action=edit Bug 12430: Force relevance ranking when not using QueryParser The system preference "QueryWeightFields" is mutually exclusive with the system preference "QueryAutoTruncate" and the * truncation modifier, when not using QueryParser. If you use truncation, relevance won't work anymore. (N.B. Relevance doesn't work probably when using QueryParser, but for a very different reason beyond the current scope of this bug.) This patch adds relevance ranking when using truncation (or basically when QueryWeightFields is disabled). _TEST PLAN_ 0) Use koha-testing-docker 1) Ensure that "QueryWeightFields" is enabled and "QueryAutoTruncate" is set to auto 2) Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?q=e 3) Note that the results are ordered by biblionumber ascending 4) Apply patch 5) Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?q=e 6) Note that the results are not ordered by biblionumber ascending (presumably they are in relevance order) If you edit /etc/koha/sites/kohadev/koha-conf.xml and add "requests" to the end of "zebra_loglevels", uncomment that option, and carefully restart Zebra, you should be able to see the following in /var/log/koha/kohadev/zebra-output.log: Search biblios OK 394 1 1+0 RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 @attr 2=102 e The 2=102 indicates a relevance search. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:08:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:08:21 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99158|0 |1 is obsolete| | --- Comment #65 from David Cook --- Created attachment 114130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114130&action=edit Unit tests for buildQuery This patch adds unit tests for buildQuery, especially focusing on the use of the (rk=()) wrapper. Note that the Net::Z3950::ZOOM library is used to test the queries for CCL validity on top of the string matching used in the got/expected comparisons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:09:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:09:15 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #66 from David Cook --- To run the unit tests: root at kohadevbox:koha(bug_12430)$ prove t/Search/buildQuery.t t/Search/buildQuery.t .. ok All tests successful. Files=1, Tests=10, 3 wallclock secs ( 0.03 usr 0.01 sys + 2.87 cusr 0.15 csys = 3.06 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:09:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:09:28 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:25:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:25:22 +0000 Subject: [Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from David Cook --- Using koha-testing-docker w/o patch using ICU in /etc/koha/zebradb/etc/default.idx: For "index w", replace "charmap word-phrase-utf.chr" with "icuchain words-icu.xml" For "index p", replace "charmap word-phrase-utf.chr" with "icuchain phrases-icu.xml" koha-rebuild-zebra -f -b -v kohadev QueryAutoTruncate: Query: test Request: Search biblios OK 3 1 1+0 RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 test Query: "test" Request: Search biblios OK 3 1 1+0 RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 test QueryWeightFields: Query: test Request: Search biblios ERROR 120 1 1+0 RPN @attrset Bib-1 @or @or @or @or @or @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 test @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 test @attr 1=3 6 @attr 4=1 @attr 9=26 @attr 2=102 test @attr 1=4 @attr 4=6 @attr 9=24 @attr 2=102 test @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 test @attr 4=6 @attr 5=1 @attr 9=14 @attr 2=102 "test? " @attr 4=6 @attr 9=14 @attr 2=102 test Query: "test" Request: Search biblios ERROR 120 1 1+0 RPN @attrset Bib-1 @or @or @or @or @or @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 " test " @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 " test " @ attr 1=36 @attr 4=1 @attr 9=26 @attr 2=102 " test " @attr 1=4 @attr 4=6 @attr 9=24 @attr 2=102 " test " @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 " test " @attr 4=6 @attr 5=1 @attr 9=14 @attr 2=102 "test? " @attr 4=6 @attr 9=14 @attr 2=102 " test " (Via yaz-client this query yields: [120] Unsupported Truncation attribute -- v2 addinfo '103') -- Actually, it doesn't look like this problem is related to double quotes at all. Interesting... if I disable QueryFuzzy it will work: Query: test Request: Search biblios OK 3 1 1+0 RPN @attrset Bib-1 @or @or @or @or @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 test @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 test @attr 1=36 @attr 4 =1 @attr 9=26 @attr 2=102 test @attr 1=4 @attr 4=6 @attr 9=24 @attr 2=102 test @attr 4=6 @attr 5=1 @attr 9=14 @attr 2=102 "test? " @attr 4=6 @attr 9=14 @attr 2=102 test Query: "test" Request: Search biblios OK 3 1 1+0 RPN @attrset Bib-1 @or @or @or @or @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 " test " @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 " test " @attr 1=36 @attr 4=1 @attr 9=26 @attr 2=102 " test " @attr 1=4 @attr 4=6 @attr 9=24 @attr 2=102 " test " @attr 4=6 @attr 5=1 @attr 9=14 @attr 2=102 "test? " @attr 4=6 @attr 9=14 @attr 2=102 " test " -- If I re-enable QueryFuzzy *but* DISABLE QueryStemming it causes catastrophic problems: Query: test Request: Search biblios ERROR 120 1 1+0 RPN @attrset Bib-1 @or @or @or @or @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 test @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 test @attr 1=36 @a ttr 4=1 @attr 9=26 @attr 2=102 test @attr 1=4 @attr 4=6 @attr 9=24 @attr 2=102 test @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 test @attr 4=6 @attr 9=14 @attr 2=102 test Query: "test" Request: Search biblios ERROR 120 1 1+0 RPN @attrset Bib-1 @or @or @or @or @or @attr 1=36 @attr 4=1 @attr 6=3 @attr 9=32 @attr 2=102 " test " @attr 1=4 @attr 4=1 @attr 6=3 @attr 9=28 @attr 2=102 " test " @att r 1=36 @attr 4=1 @attr 9=26 @attr 2=102 " test " @attr 1=4 @attr 4=6 @attr 9=24 @attr 2=102 " test " @attr 4=6 @attr 5=103 @attr 9=16 @attr 2=102 " test " @attr 4=6 @attr 9=14 @attr 2=102 " test " (Via yaz-client this query yield: [120] Unsupported Truncation attribute -- v2 addinfo '103') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:26:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:26:11 +0000 Subject: [Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 --- Comment #12 from David Cook --- (In reply to David Cook from comment #10) > Using koha-testing-docker w/o patch using CHR in > /etc/koha/zebradb/etc/default.idx: Note I have a typo in the QueryAutoTruncate section. By accident, a @attr 2=102 snuck in there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:27:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:27:14 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #67 from David Cook --- When this is pushed, I'm half tempted to push for a removal of "QueryWeightFields" completely as I reckon it causes more grief than it's worth... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:29:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:29:24 +0000 Subject: [Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 --- Comment #13 from David Cook --- Hmm I've just noticed that I didn't have "UseICU" turned on... but that doesn't look relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:48:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:48:04 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #68 from David Cook --- Very old style commit message name. I might just fix that up now... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:49:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:49:22 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114129|0 |1 is obsolete| | --- Comment #69 from David Cook --- Created attachment 114131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114131&action=edit Bug 12430: Use releance ranking without QueryWeightFields The system preference "QueryWeightFields" is mutually exclusive with the system preference "QueryAutoTruncate" and the * truncation modifier, when not using QueryParser. If you use truncation, relevance won't work anymore. (N.B. Relevance doesn't work probably when using QueryParser, but for a very different reason beyond the current scope of this bug.) This patch adds relevance ranking when using truncation (or basically when QueryWeightFields is disabled). _TEST PLAN_ 1) Turn on "QueryWeightFields" and set "QueryAutoTruncate" to auto 2) Turn off "UseQueryParser" 3) Do a keyword search in the OPAC 4) Note that the results are ordered by biblionumber ascending 5) Apply patch 6) Do the same keyword search in the OPAC 7) Note that the results are never ordered differently (presumably in relevance order :P) If you're a stickler, throw in some warns so that you can see what CCL query is being sent to Zebra. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:49:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:49:28 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #70 from David Cook --- Created attachment 114132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114132&action=edit Bug 12430: Add unit tests for C4::Search::buildQuery This patch adds unit tests for buildQuery, especially focusing on the use of the (rk=()) wrapper. Note that the Net::Z3950::ZOOM library is used to test the queries for CCL validity on top of the string matching used in the got/expected comparisons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:49:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:49:50 +0000 Subject: [Koha-bugs] [Bug 12430] Search truncation disables relevance ranking In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114130|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:50:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:50:28 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search truncation disables |Relevance ranking should |relevance ranking |also be used without | |QueryWeightFields system | |preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:53:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:53:49 +0000 Subject: [Koha-bugs] [Bug 24006] Switching on QueryWeightFields (relevance ranking) breaks search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24006 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I think that this is a duplicate of Bug 12430 *** This bug has been marked as a duplicate of bug 12430 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:53:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:53:49 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernard.scaife at ptfs-europe. | |com --- Comment #71 from David Cook --- *** Bug 24006 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:55:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:55:07 +0000 Subject: [Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 --- Comment #14 from David Cook --- I'm tempted to mark this as a duplicate of Bug 9715 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:55:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:55:19 +0000 Subject: [Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9715 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:55:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:55:19 +0000 Subject: [Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25900 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:56:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:56:14 +0000 Subject: [Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715 --- Comment #11 from David Cook --- We could just not use QueryFuzzy when UseICU is enabled and then add a warning to the syspref description? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:57:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:57:47 +0000 Subject: [Koha-bugs] [Bug 27141] New: QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 Bug ID: 27141 Summary: QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Since QueryAutoTruncate automatically disables QueryWeightFields, it does not make sense that both are set to 1 in "./installer/data/mysql/sysprefs.sql" I think that we should have QueryWeightFields set to 0 for new installations. It would even be tempting to set QueryWeightFields to 0 where QueryAutoTruncate is set to 1 on existing installs, except that someone might be (unwisely) trialling different Query* settings before/during a Koha upgrade. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:57:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:57:58 +0000 Subject: [Koha-bugs] [Bug 27141] QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9715 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:57:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:57:58 +0000 Subject: [Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27141 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 06:58:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 05:58:34 +0000 Subject: [Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715 --- Comment #12 from David Cook --- I would note that QueryStemming, based on my tests on Bug 25900, is also problematic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 07:10:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 06:10:41 +0000 Subject: [Koha-bugs] [Bug 27142] New: Patron batch update from report module - no patrons loaded into view Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Bug ID: 27142 Summary: Patron batch update from report module - no patrons loaded into view Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: somesecretemail at mailinator.com QA Contact: testopia at bugs.koha-community.org Can't batch update patrons from reports module. Steps to reproduce: 1. Navigate to reports module 2. Create sql report with `select * from borrowers` 3. Save report 4. Run report 5. Click "Batch operation with 20 visible patrons" 6. Click "Batch patron modification" Result: no patrons are loaded in the view. Koha shows message "Warning, the following cardnumbers were not found:" and presents all cardnumbers of patrons from the sql query. I verified that the same steps in Koha version 19.11 works fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 07:37:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 06:37:11 +0000 Subject: [Koha-bugs] [Bug 27140] koha-zebra doesn't properly stop Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27140 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from Marcel de Rooy --- Remember some similar experience. But is the info clear enough for someone to solve this ticket ? :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 08:04:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 07:04:20 +0000 Subject: [Koha-bugs] [Bug 27143] New: Error Occured during Koha Installation Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27143 Bug ID: 27143 Summary: Error Occured during Koha Installation Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: muhd.raimee at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Created attachment 114133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114133&action=edit The menu that was mentioned in post description Hello and Good day everyone, I was wondering if anyone could tell or help on how to solve this error that i encountered during the 2nd stage of Koha installation? The error "DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_bookreader.search_marc_map' doesn't exist at /usr/share/koha/lib/Koha/Objects.pm line 207" occurred after the menu of "Selecting default settings". Anyone that knows or experience on how to solve the matter? Thank you on advance! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 08:24:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 07:24:20 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 --- Comment #18 from Mark Hofstetter --- I still think plugabiltiy would be a good idea (even if it would be just for the sake of concistency) but thanks to all your advice I was able to to todo it in a plugin (https://github.com/HKS3/koha-plugin-subordinate-items) just create the tab with js -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 08:38:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 07:38:01 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #14 from Timothy Alexis Vass --- I will make it --statue-barred-fees. The fees are literally statute-barred. Thank you everyone for the clarifications. I will refactor this according to the insights shared in the comments above. I will make another bug report and patch for the relating parts and correct those too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 08:40:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 07:40:39 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add --statute-barred option |Add --statute-barred-fees |to cleanup_database.pl to |option to |purge all fees where the |cleanup_database.pl to |item has been returned and |purge all fees where the |the fee is older than the |item has been returned and |given number of days. |the fee is older than the | |given number of days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 09:44:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 08:44:11 +0000 Subject: [Koha-bugs] [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 09:44:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 08:44:14 +0000 Subject: [Koha-bugs] [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 --- Comment #1 from Jonathan Druart --- Created attachment 114134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114134&action=edit Bug 27135: Adjust "upload image" button when viewing item's cover images When viewing the cover image of an item, the "upload image" button is about to upload an image at biblio level. Test plan: - Attach a cover image to an item - View it - Notice the "Upload image" button, confirm that with this patch applied the wording changed and that clicking it will attach a cover image to the item - Attach a cover image to the biblio - View it - Notice the "Upload image" button, confirm that with this patch applied the wording changed and that clicking it will attach a cover image to the biblio -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 09:46:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 08:46:06 +0000 Subject: [Koha-bugs] [Bug 26405] Circulation.t fails on 'AddRenewal left both fines' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26405 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|chris at bigballofwax.co.nz |emmi.takkinen at koha-suomi.fi --- Comment #2 from Emmi Takkinen --- Created attachment 114135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114135&action=edit Bug 26405: Prevent Circulation.t failing on 'AddRenewal left both fines' Bug 23051 added option to skip calculating fines even when "CalculateFinesOnReturn" is enabled. Due this Circulation.t fails on test "AddRenewal left both fines" if "CalculateFinesOnReturn" is disabled on ones system. Mocking syspref while testing fixes failig tests. To test: 1. Disable "CalculateFinesOnReturn". 2. Run prove t/db_dependent/Circulation.t => Tests fail 3. Apply patch. 4. Run prove t/db_dependent/Circulation.t again => Tests are succesful -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 10:06:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 09:06:12 +0000 Subject: [Koha-bugs] [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 10:18:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 09:18:51 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #12 from Jonathan Druart --- (In reply to David Cook from comment #10) > (In reply to Jonathan Druart from comment #7) > > diff --git a/populate_db.pl b/populate_db.pl > > index 097bbda..7d07aa6 100755 > > --- a/populate_db.pl > > +++ b/populate_db.pl > > @@ -92,8 +92,8 @@ if ( $marcflavour ne 'MARC21' > > > > my $dbh = C4::Context->dbh; # At the beginning to die if DB does not exist. > > > > -my ( $prefs_count ) = $dbh->selectrow_array(q|SELECT COUNT(*) FROM > > systempreferences|); > > -my ( $patrons_count ) = $dbh->selectrow_array(q|SELECT COUNT(*) FROM > > borrowers|); > > +my ( $prefs_count ) = eval { $dbh->selectrow_array(q|SELECT COUNT(*) FROM > > systempreferences|) }; > > +my ( $patrons_count ) = eval { $dbh->selectrow_array(q|SELECT COUNT(*) FROM > > borrowers|) }; > > if ( $prefs_count or $patrons_count ) { > > die "Database is not empty!"; > > } > > > > You will need to apply this to koha-misc4dev first. > > Can you clarify why we need to do this? Is koha-misc4dev currently broken? Hum, good question. I did not spend much time on it, but we should not need it as we have the KOHA_DB_DO_NOT_RAISE_OR_PRINT_ERROR flag set. I will investigate a bit more and see if there is not something hidden behind it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 10:51:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 09:51:10 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #13 from Jonathan Druart --- Created attachment 114136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114136&action=edit Bug 25026: Use HandleError to not raise or print error DBIC has its own HandleError, and so it does not work to unset RaiseError or PrintError if unsafe is not set (what we don't want here). The idea of this patch is to overwrite the HandleError when we need it: Either if KOHA_DB_DO_NOT_RAISE_OR_PRINT_ERROR is set (misc4dev) Or if the installer is triggered (we don't want to explode if the DB does not exist). There is an additional trick, when the installer is completed, we want to restore the original behaviour, and so a disconnect is made. Note that during the installer we want to display eventual SQL errors, that's why we still display the errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 10:53:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 09:53:46 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #14 from Jonathan Druart --- The installer was broken! This follow-up should do it. We need to test `reset_all` and the install process. Also hit circ/pendingreserves.pl which should explode when the install is done (see the "trick" in the commit message) Now the change in misc4dev is: diff --git a/populate_db.pl b/populate_db.pl index 097bbda..563cb28 100755 --- a/populate_db.pl +++ b/populate_db.pl @@ -92,6 +92,8 @@ if ( $marcflavour ne 'MARC21' my $dbh = C4::Context->dbh; # At the beginning to die if DB does not exist. +my $HandleError = $dbh->{HandleError}; +$dbh->{HandleError} = sub { return 1 }; my ( $prefs_count ) = $dbh->selectrow_array(q|SELECT COUNT(*) FROM systempreferences|); my ( $patrons_count ) = $dbh->selectrow_array(q|SELECT COUNT(*) FROM borrowers|); if ( $prefs_count or $patrons_count ) { To hide the 2 errors that will be risen when the DB is empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 12:14:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 11:14:54 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114131|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize --- Created attachment 114137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114137&action=edit Bug 12430: Use releance ranking without QueryWeightFields The system preference "QueryWeightFields" is mutually exclusive with the system preference "QueryAutoTruncate" and the * truncation modifier, when not using QueryParser. If you use truncation, relevance won't work anymore. (N.B. Relevance doesn't work probably when using QueryParser, but for a very different reason beyond the current scope of this bug.) This patch adds relevance ranking when using truncation (or basically when QueryWeightFields is disabled). _TEST PLAN_ 1) Turn on "QueryWeightFields" and set "QueryAutoTruncate" to auto 2) Turn off "UseQueryParser" 3) Do a keyword search in the OPAC 4) Note that the results are ordered by biblionumber ascending 5) Apply patch 6) Do the same keyword search in the OPAC 7) Note that the results are never ordered differently (presumably in relevance order :P) If you're a stickler, throw in some warns so that you can see what CCL query is being sent to Zebra. Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 12:14:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 11:14:58 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114132|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize --- Created attachment 114138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114138&action=edit Bug 12430: Add unit tests for C4::Search::buildQuery This patch adds unit tests for buildQuery, especially focusing on the use of the (rk=()) wrapper. Note that the Net::Z3950::ZOOM library is used to test the queries for CCL validity on top of the string matching used in the got/expected comparisons. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 12:16:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 11:16:45 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off QA Contact| |martin.renvoize at ptfs-europe | |.com --- Comment #74 from Martin Renvoize --- This one's been signed off a number of times and the final implementation appears to just move, and fix, the tests.. Setting to SO'd and QAing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 12:20:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 11:20:23 +0000 Subject: [Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 12:20:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 11:20:26 +0000 Subject: [Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113735|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 114139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114139&action=edit Bug 24658: (bug 22008 follow-up) Correct update DB entry 18.12.00.031 If the original constraint does not exist, the second one is not added. Test plan: 1. checkout dbrev 18.12.00.030 2. Remove the constraint: ALTER TABLE accountlines DROP FOREIGN KEY accountlines_ibfk_2 3. checkout master 4. % updatedatabase => The constraint accountlines_ibfk_items is not added 5. Repeat 1 to 4 => The constraint is added correctly Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 12:24:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 11:24:41 +0000 Subject: [Koha-bugs] [Bug 27143] Error Occured during Koha Installation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27143 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 12:49:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 11:49:26 +0000 Subject: [Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 12:49:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 11:49:29 +0000 Subject: [Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114125|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 114140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114140&action=edit Bug 27068: Control hold group logic in HoldsQueue Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 12:49:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 11:49:54 +0000 Subject: [Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #7 from Kyle M Hall --- Created attachment 114141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114141&action=edit Bug 27068: Fix errors in _checkHoldPolicy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 12:49:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 11:49:57 +0000 Subject: [Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 --- Comment #8 from Kyle M Hall --- Created attachment 114142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114142&action=edit Bug 27068: Fetch libraries once for speed Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:06:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 12:06:21 +0000 Subject: [Koha-bugs] [Bug 26713] Add pagination to bottom of saved SQL reports table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |master Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:15:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 12:15:13 +0000 Subject: [Koha-bugs] [Bug 26713] Add pagination to bottom of saved SQL reports table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:15:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 12:15:16 +0000 Subject: [Koha-bugs] [Bug 26713] Add pagination to bottom of saved SQL reports table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26713 --- Comment #1 from Owen Leonard --- Created attachment 114143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114143&action=edit Bug 26713: Add pagination to bottom of saved SQL reports table This patch adds a second pagination menu to the bottom of the report results table. To test, apply the patch and go to Reports. - Run a report which will return multiple pages of results (greater than 20). - The results should display with a pagination bar at the top and bottom of the table. - Confirm that both pagination menus work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:24:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 12:24:52 +0000 Subject: [Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:24:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 12:24:55 +0000 Subject: [Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114128|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 114144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114144&action=edit Bug 27137: Correctly show biblio title after successfully moving item In Bug 11529 we changed the variable that was passed to the template but missed updating the template. This patch ensures we correctly access the variable to show the title of the biblio. To test: 1) Create two biblios (Biblio A and Biblio B) 2) Add an item to Biblio A (Item A) 3) Go to Biblio B 4) In the cataloguing toolbar, click Edit, then Attach item 5) Enter the barcode for Item A and submit 6) Notice the item has successfully moved by Biblio B's title does not show 7) Apply patch 8) Go to Biblio A 9) In the cataloguing toolbar, click Edit, then Attach item 10) Enter the barcode for Item A and submit 11) Confirm Biblio A's title shows correctly Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:42:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 12:42:22 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |24886 Version|20.05 |master Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 [Bug 24886] Reports template should be reindented -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:42:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 12:42:22 +0000 Subject: [Koha-bugs] [Bug 24886] Reports template should be reindented In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24886 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27142 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 [Bug 27142] Patron batch update from report module - no patrons loaded into view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:48:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 12:48:45 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #75 from Martin Renvoize --- All works well and this is a really good bug to fix.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:53:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 12:53:28 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:58:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 12:58:24 +0000 Subject: [Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 --- Comment #15 from Owen Leonard --- This doesn't seem to have correctly addressed batch patron modifications: Bug 27142 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 13:59:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 12:59:47 +0000 Subject: [Koha-bugs] [Bug 27129] Issue in searching records in opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27129 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:10:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 13:10:23 +0000 Subject: [Koha-bugs] [Bug 27144] New: Cannot delete any patrons Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Bug ID: 27144 Summary: Cannot delete any patrons Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, kyle at bywatersolutions.com Depends on: 14708 The try catch introduced in bug 14708 breaks deletion of borrowers totally via the staff interface, giving 500 error and also it hides the error message in log because it is in try catch so this is very hard to spot in error logs. To reproduce: go to any patron record and try to delete, you will get http 500 error back. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 [Bug 14708] The patron set as the anonymous patron should not be deletable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:10:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 13:10:23 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 [Bug 27144] Cannot delete any patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:22:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 13:22:10 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Depends on| |25942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:22:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 13:22:10 +0000 Subject: [Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27142 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 [Bug 27142] Patron batch update from report module - no patrons loaded into view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:26:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 13:26:20 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:26:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 13:26:22 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 --- Comment #1 from Joonas Kylmälä --- Created attachment 114145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114145&action=edit Bug 27144: Fix syntax error that prevents deleting patrons To test: 1) In staff interface open up a patron record 2) Click More -> Delete, and then "Yes, delete" 3) Notice 500 error 4) Apply patch 5) Notice error is now gone when deleting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:29:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 13:29:54 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:34:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 13:34:26 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:34:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 13:34:29 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 --- Comment #1 from Nick Clemens --- Created attachment 114146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114146&action=edit Bug 27142: Don't interpolate batch_type variable To test: 1 - Create a report like: SELECT * FROM borrowers LIMIT 50 2 - Run the report 3 - Attempt batch modification - it fails showing every row as an unfound cardnumber 4 - Apply patch 5 - Repeat 6 - Success! 7 - Edit report to: SELECT * FROM biblio LIMIT 50 8 - Repeat test 9 - Ensure batch modification and deletion work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:35:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 13:35:48 +0000 Subject: [Koha-bugs] [Bug 27145] New: Patron deletion via intranet doesn't handle exceptions well Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Bug ID: 27145 Summary: Patron deletion via intranet doesn't handle exceptions well Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, kyle at bywatersolutions.com Depends on: 14708 Bug 14708 introduced a try catch around $patron->delete in commit "Bug 14708: (QA follow-up) Use try/catch blocks when calling ". However, in the catch block it only assumes the exception was from trying to delete anonymous patron when it can be anything else as well, the code should be modified so that it will handle the anonymous patron case and if it is anything else we log the other exception. Kyle, can you have a go at this? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 [Bug 14708] The patron set as the anonymous patron should not be deletable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 14:35:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 13:35:48 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27145 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 [Bug 27145] Patron deletion via intranet doesn't handle exceptions well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:03:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:03:33 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:03:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:03:35 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114145|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 114147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114147&action=edit Bug 27144: Fix syntax error that prevents deleting patrons To test: 1) In staff interface open up a patron record 2) Click More -> Delete, and then "Yes, delete" 3) Notice 500 error 4) Apply patch 5) Notice error is now gone when deleting Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:04:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:04:14 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at helsinki.fi |ity.org | Severity|major |critical CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:05:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:05:14 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:05:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:05:19 +0000 Subject: [Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:05:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:05:22 +0000 Subject: [Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114144|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 114148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114148&action=edit Bug 27137: Correctly show biblio title after successfully moving item In Bug 11529 we changed the variable that was passed to the template but missed updating the template. This patch ensures we correctly access the variable to show the title of the biblio. To test: 1) Create two biblios (Biblio A and Biblio B) 2) Add an item to Biblio A (Item A) 3) Go to Biblio B 4) In the cataloguing toolbar, click Edit, then Attach item 5) Enter the barcode for Item A and submit 6) Notice the item has successfully moved by Biblio B's title does not show 7) Apply patch 8) Go to Biblio A 9) In the cataloguing toolbar, click Edit, then Attach item 10) Enter the barcode for Item A and submit 11) Confirm Biblio A's title shows correctly Sponsored-by: Toi Ohomai Institute of Technology Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:05:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:05:34 +0000 Subject: [Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:06:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:06:22 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|critical |major Keywords| |rel_20_11_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:06:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:06:35 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:14:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:14:12 +0000 Subject: [Koha-bugs] [Bug 27146] New: add pluggability to save/store on add/edit bibliographic data Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27146 Bug ID: 27146 Summary: add pluggability to save/store on add/edit bibliographic data Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: koha at trust-box.at QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl as discussed on IRC on 2.12.2020 on editing bibliograpic data cgi-bin/koha/cataloguing/addbiblio.pl quite often "functional defaults" are needed, like dates, sequence numbers and so on mostly those values should be transparent for the users ie those values must not be edited or even not seen by the users the only possibility at the moment (at least I am aware of) are the value_builder plugins /usr/share/koha/intranet/cgi-bin/cataloguing/value_builder which need a least some user intervention, like clicking the fields good examples are controlnumber 001 and 005 (maybe 003) which mostly would need no user intervention at all see bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:15:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:15:04 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:15:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:15:07 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 --- Comment #1 from Kyle M Hall --- Created attachment 114149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114149&action=edit Bug 27145: Rethrow all other exceptions Bug 14708 introduced a try catch around $patron->delete in commit "Bug 14708: (QA follow-up) Use try/catch blocks when calling ". However, in the catch block it only assumes the exception was from trying to delete anonymous patron when it can be anything else as well, the code should be modified so that it will handle the anonymous patron case and if it is anything else we log the other exception. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:15:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:15:22 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:15:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:15:38 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14708 |27144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 [Bug 14708] The patron set as the anonymous patron should not be deletable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 [Bug 27144] Cannot delete any patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:15:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:15:38 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27145 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 [Bug 27145] Patron deletion via intranet doesn't handle exceptions well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:15:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:15:38 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27145 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 [Bug 27145] Patron deletion via intranet doesn't handle exceptions well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:18:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:18:15 +0000 Subject: [Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 --- Comment #15 from Fridolin Somers --- (In reply to David Cook from comment #13) > Hmm I've just noticed that I didn't have "UseICU" turned on... but that > doesn't look relevant. Indeed, this is only used by XSLT links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:19:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:19:09 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 --- Comment #3 from Joonas Kylmälä --- This might have caused some corruption/duplicated data in the DB, to check if you have any use: > select count(*) FROM deletedborrowers WHERE borrowernumber IN (SELECT borrowernumber FROM borrowers); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:21:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:21:37 +0000 Subject: [Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 --- Comment #16 from Fridolin Somers --- (In reply to Fridolin Somers from comment #5) > Oh indeed, even Debian Buster has Zebra 2.0.59. > > You can use indexdata repo to upgrade the version : > http://ftp.indexdata.dk/debian/ koha-testing-docker uses Debian version no ? This change is harmless I'd say. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:26:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:26:50 +0000 Subject: [Koha-bugs] [Bug 27147] New: Self registration broken if PatronSelfRegistrationBorrowerUnwantedField contains "categorycode" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27147 Bug ID: 27147 Summary: Self registration broken if PatronSelfRegistrationBorrowerUnwantedField contains "categorycode" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: OPAC Assignee: agustinmoyano at theke.io Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org If the category dropdown list is not appearing on the self registration form, then the form submision fails. First the form displays "Password must contain at least undefined characters", then a 500 "[You must provide a patron's category to validate password's strength and length] at /usr/share/perl5/Exception/Class/Base.pm line 88" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:27:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:27:26 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | --- Comment #78 from Jonathan Druart --- Removing the "release notes needed" keyword, as it's released now... Would have been good to have it in time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:27:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:27:52 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 --- Comment #79 from Jonathan Druart --- There is a critical bug for 20.11 caused by this patchset, see bug 27147. Please fix ASAP. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:28:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:28:43 +0000 Subject: [Koha-bugs] [Bug 27147] Self registration broken if PatronSelfRegistrationBorrowerUnwantedField contains "categorycode" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27147 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:30:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:30:28 +0000 Subject: [Koha-bugs] [Bug 27148] New: Internal Server Error during self registration 20.11 Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Bug ID: 27148 Summary: Internal Server Error during self registration 20.11 Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jan.michael.mueck at uni-hamburg.de QA Contact: testopia at bugs.koha-community.org Internal Server Error during self registration if categorycode is checked in PatronSelfRegistrationBorrowerUnwantedField. Error could be reproduced. Installation was updated from 19.05 where is worked fine. IRC Chat: [14:20] Hello, i just updatet to 20.11. and try to register a new patreon in opac. Upon submitting the form i get an internal server error. Plack-Error.log shows "[You must provide a patron's category to validate password's strength and length]". In the Form there is a message to provide a password with undefind lenght. In the administrator setting the passwor lenght is defindet as 4 letters minimum. Can anyone help? [14:31] do you have patron categories defiend in your system? is the field hidden from the patron form maybe? [15:12] @cait1 We have got some categorys defined but can you tell me where i can check the visibility setting? The setup worked fine before the update btw. [15:12] Guest7457: I'll give you the answer just as soon as RDA is ready [15:12] i already had it that way, huginn. [15:18] Guest7457: can you open a bug report please? [15:18] I do recreate the problem if PatronSelfRegistrationBorrowerUnwantedField contains "categorycode" About Koha: Koha-Version: 20.11.00.000 OS Version ('uname -a'): Linux www2 5.4.0-54-generic #60-Ubuntu SMP Fri Nov 6 10:37:59 UTC 2020 x86_64 Perl Interpreter: /usr/bin/perl Perl-Version: 5.030000 Perl @INC: /usr/share/koha/lib /usr/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.30.0 /usr/local/share/perl/5.30.0 /usr/lib/x86_64-linux-gnu/perl5/5.30 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.30 /usr/share/perl/5.30 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base /var/lib/koha/testothek/plugins MySQL-Version: mysql Ver 15.1 Distrib 10.3.25-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2 Apache-Version: Server version: Apache/2.4.41 (Ubuntu) PSGI: Plack (deployment) Memcached: Server: 127.0.0.1:11211 | Namespace: koha_testothek | Status: wird ausgeführt. | Konfiguration gelesen aus: koha-conf.xml Zebraversion: Zebra 2.1.4 (C) 1994-2017, Index Data Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: 45c729bb18ecdd3e0455f47765700b1c9754b1ce Using ICU Message Broker: Status: wird ausgeführt Datum und Zeit: 03.12.2020 15:28 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:31:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:31:10 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 --- Comment #4 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #3) > This might have caused some corruption/duplicated data in the DB, to check > if you have any use: > > > select count(*) FROM deletedborrowers WHERE borrowernumber IN (SELECT borrowernumber FROM borrowers); Why, can you detail please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:32:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:32:10 +0000 Subject: [Koha-bugs] [Bug 27147] Self registration broken if PatronSelfRegistrationBorrowerUnwantedField contains "categorycode" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27147 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 27148 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:32:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:32:10 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- *** Bug 27147 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:33:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:33:25 +0000 Subject: [Koha-bugs] [Bug 26991] Add action logs to search engine administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26991 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:33:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:33:28 +0000 Subject: [Koha-bugs] [Bug 26991] Add action logs to search engine administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26991 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113542|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers --- Created attachment 114150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114150&action=edit Bug 26991: Add action logs to search engine administration Search engine administration is very important, we should log who/when it is changed. I don't add a preference system to disable it, like there is no for preference system logs. Test plan : 1) Use searchengine Elasticsearch 2) Go to Administation > Search engine configuration (Elasticsearch) 3) Click on 'Reset Mappings' and accept 4) Edit some lines and save 5) Go to 'Tools' > 'Log viewer' 6) Select only 'Search engine' in Modules and submit 7) Select only 'Edit mappings' in Actions 8) Check you see a log 9) Select only 'Reset mappings' in Actions 10) Check you see a log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:35:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:35:05 +0000 Subject: [Koha-bugs] [Bug 26991] Add action logs to search engine administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26991 --- Comment #4 from Fridolin Somers --- Updated on master, which is now 20.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:40:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:40:35 +0000 Subject: [Koha-bugs] [Bug 27147] Self registration broken if PatronSelfRegistrationBorrowerUnwantedField contains "categorycode" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27147 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:42:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:42:01 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |agustinmoyano at theke.io Keywords| |rel_20_11_candidate Version|20.11 |master Status|NEW |ASSIGNED Depends on| |23816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 [Bug 23816] Allow to have different password strength and length settings for different patron categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:42:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:42:01 +0000 Subject: [Koha-bugs] [Bug 23816] Allow to have different password strength and length settings for different patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27148 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 [Bug 27148] Internal Server Error during self registration 20.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:47:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:47:51 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 --- Comment #2 from Agustín Moyano --- This bug started because password strength and length now it's defined by patron's category. As Jonathan told me, we've got PatronSelfRegistrationDefaultCategory preference. So I believe we should check if a patron category is visible in the form. If not visible, we should check fi PatronSelfRegistrationDefaultCategory is set with a valid patron category, and get password requirements from it. If PatronSelfRegistrationDefaultCategory is not set, then we should fetch system's default password strength and length -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:49:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:49:33 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 15:50:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 14:50:58 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 --- Comment #3 from Jonathan Druart --- (In reply to Agustín Moyano from comment #2) > If PatronSelfRegistrationDefaultCategory is not set, then we should fetch > system's default password strength and length The self registration feature is disabled is this pref is not set. So we don't need to take this case into account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:14:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 15:14:35 +0000 Subject: [Koha-bugs] [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:14:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 15:14:38 +0000 Subject: [Koha-bugs] [Bug 27135] Viewing local cover images at item level shows a link to upload image at record level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27135 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114134|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 114151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114151&action=edit Bug 27135: Adjust "upload image" button when viewing item's cover images When viewing the cover image of an item, the "upload image" button is about to upload an image at biblio level. Test plan: - Attach a cover image to an item - View it - Notice the "Upload image" button, confirm that with this patch applied the wording changed and that clicking it will attach a cover image to the item - Attach a cover image to the biblio - View it - Notice the "Upload image" button, confirm that with this patch applied the wording changed and that clicking it will attach a cover image to the biblio Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 16:41:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 15:41:13 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Summary|Add Koha::Biblio |Add |get_visible_items method |Koha::Items->filter_by_visi | |ble_in_opac -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:00:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 16:00:00 +0000 Subject: [Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #4 from Lucas Gass --- Fridolin, I have encounter a problem while testing this patch. To recreate: 1. apply your patch 2. try opac-password-recovery.pl without an email, I see the new error message 3. in the staff client add an email for the same patron 4. try opac-password-recovery.pl again, it blows up with the error: Invalid 'from' parameter: root at localhost at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:16:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 16:16:48 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 17:16:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 16:16:51 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 --- Comment #1 from Owen Leonard --- Created attachment 114152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114152&action=edit Bug 27124: JS error "select2Width is not defined" This patch changes the way select2.js checks for an existing value of the "select2Width" variable in order to avoid errors when it is undefined. To test, apply the patch and view various pages where the select2 plugin is used: - Basic MARC editor - Items edit - Batch item edit - Authority editor In each case check that the Select2 plugin works correctly to style fields like collection code and home library. On the basic MARC editor page these s should have a width that adjusts as the browser window changes. On other pages the width should be fixed. Check the browser console and confirm that there are no JavaScript errors. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:01:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:01:35 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #4 from Lucas Gass --- The display for modifying 1 record looks much better now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:02:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:02:23 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #3 from Lucas Gass --- Seems to fix the console error in all the places! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:12:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:12:05 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:12:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:12:09 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114095|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 114164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114164&action=edit Bug 26665: (bug 20168 follow-up) Fix path to bootstrap js file 20168 moved it to /opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.bundle.min.js It fixed the OAI-PMH view Test plan: Hit /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marc21 and confirm that you can click "Metadata" and it opens Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:15:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:15:04 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Notes from testing (koha-testing-docker): 1. Enable OIA-PMH - set the OAI-PMH system preference to Enable. 2. Visit /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marc21 3. If you click Metadata for any of the search results it does not open to display additional information. 4. Apply the patch (and flush_memcached and restart_all). 5. Repeat step 2 (or refresh the page). 6. Now if you click on Metadata for one of the search results it will now open to display the additional information. 7. Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:16:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:16:20 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 --- Comment #7 from Agustín Moyano --- (In reply to David Nind from comment #6) > Notes from testing (koha-testing-docker (KTD)): > > - Step 2: should be PatronSelfRegistration rather than SeflRegistration, is > set to allow by default in KTD; PatronSelfRegistrationDefaultCategory is set > to SELFREG as the patron category in KTD > > - Step 6: > . to change the password settings for the patron category go to > Administration > Patrons and circulation > Patron category and edit the > SELFREG category; combinations of settings to experiment with are Minimum > password length and Require strong password > . system preferences for password security are minPasswordLength and > RequireStrongPassword > > Everything works as expected with the test plan. Thanks David for this comments, and testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:17:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:17:50 +0000 Subject: [Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:17:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:17:53 +0000 Subject: [Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 --- Comment #2 from Nick Clemens --- Created attachment 114165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114165&action=edit Bug 26208: Perform batch checkin/renewals serially rather than asynchronously The issue here seems to be that when multiple requests hit at once they may not register that the renewal performed by the request should lift restrictions on the account. To mitigate this we can simply perform the renewals one after the other. To test: 1 - have multiple overdue items on one patron 2 - run overdues.pl with triggers set to generate a restriction 3 - renew all overdues with the Renew All button 4 - restriction is not removed even though patron no longer has overdue items 5 - Apply patch 6 - Make all items overdue again 7 - Click Renew All 8 - Items are renewed and restriction removed 9 - Checkout items to patron again (overdue or not) 10 - Click 'Select all' in checkin column 11 - Click 'Renew/Checkin selected items' 12 - Confirm checkin succeeds as before patches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:19:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:19:00 +0000 Subject: [Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:19:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:19:27 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:24:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:24:09 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26208 --- Comment #14 from Nick Clemens --- Investigating this, as near as I can tell it only occurs during 'Renew all' when too many processes hit the server at once. I cannot recreate locally, but can verify on larger active koha instances The renewals silently fail and the user is never notified leading to problems later. We have other issues from the multiple concurrent renewals, see bug 26208 I attached a patch there to perform the actions serially which I believe will mitigate this issue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:24:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:24:09 +0000 Subject: [Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26457 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:24:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:24:27 +0000 Subject: [Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:32:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:32:46 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |With OIA-PMH enabled, if release notes| |you clicked on Sets or | |Metadata in the search | |results no additional | |information was displayed | |(example query: | |/cgi-bin/koha/ | |oai.pl?verb=ListRecords&met | |adataPrefix=marc21). This | |patch fixes this so that | |the additional information | |for Sets and Metadata is | |now correctly displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 20:51:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 19:51:21 +0000 Subject: [Koha-bugs] [Bug 26991] Add action logs to search engine administration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26991 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |logging of changes made to | |Elasticsearch. These can be | |viewed in the log viewer | |tool, where you can view | |all search engine changes, | |or limit to edit mapping | |and reset mapping actions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 21:37:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 20:37:58 +0000 Subject: [Koha-bugs] [Bug 25716] Add ability to specify additional options in koha-conf.xml for z3950_responder.pl when using koha-z3950-responder In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25716 --- Comment #3 from Kyle M Hall --- Created attachment 114166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114166&action=edit Bug 25716: Don't exit if config doesn't exist in Koha conf file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:20:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 21:20:10 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:20:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 21:20:14 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114146|0 |1 is obsolete| | --- Comment #2 from David Nind --- Created attachment 114167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114167&action=edit Bug 27142: Don't interpolate batch_type variable To test: 1 - Create a report like: SELECT * FROM borrowers LIMIT 50 2 - Run the report 3 - Attempt batch modification - it fails showing every row as an unfound cardnumber 4 - Apply patch 5 - Repeat 6 - Success! 7 - Edit report to: SELECT * FROM biblio LIMIT 50 8 - Repeat test 9 - Ensure batch modification and deletion work Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:26:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 21:26:59 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 --- Comment #1 from Ivan Dziuba --- Created attachment 114168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114168&action=edit Bug 27113: ElasticSearch: Autocomplete in input search Usually the user knows only part of the title of the book or only the name of the author, etc. When he starting search something Koha (ElasticSearch) predicts the rest of a word or expression which user is typing. Autocomplete predicts that thanks to index of ElasticSearch. TEST PLAN Important! We need do reindex ElasticSearch. ElasticSearch must have all information in his index. 1. Go Intranet -> Preference -> SearchEngine -> ElasticSearch !! APPLY PATCH !! 2. Mapping is good (Intranet -> Catalog -> Search engine configuration (Elasticsearch) ). If need do 'Reset Mapping' -> 'Yes' 3. In your koha-conf.xml file you must have good for 4. Update Preference: ./installer/data/mysql/updatedatabase.pl If that passe good you can look the lines: - DEV atomic update: bug_27113-elasticsearch_autocomplete_input_search.perl - Upgrade to XXX done : Bug 27113 - Autocomplete input on main page with elasticsearch 4. For add information in the index we need run script for indexing: ./misc/search_tools/rebuild_elasticsearch.pl -v -d 5. Waiting for the end of indexing 6. Go on Preference and find "AutocompleteElasticSearch". Value must be "Show". 7. Now we have Autocomplete for all search input (advanced search also) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:27:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 21:27:24 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:29:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 21:29:17 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin at inLibro.com, | |philippe.blouin at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:29:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 21:29:42 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |ivan.dziuba at inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:30:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 21:30:15 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This fixes an error when release notes| |batch modifying patrons | |using the reports module. | |After running a report | |(such as SELECT * FROM | |borrowers LIMIT 50) and | |selecting batch | |modification an error was | |displayed: "Warning, the | |following cardnumbers were | |not found:", and you were | |not able to modify any | |patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 3 22:32:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 03 Dec 2020 21:32:38 +0000 Subject: [Koha-bugs] [Bug 27113] ElasticSearch: Autocomplete in input search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27113 Ivan Dziuba changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ivan.dziuba at inlibro.com --- Comment #2 from Ivan Dziuba --- Created attachment 114169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114169&action=edit Result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:46:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 01:46:08 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:46:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 01:46:13 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103610|0 |1 is obsolete| | --- Comment #112 from Aleisha Amohia --- Created attachment 114170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114170&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:46:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 01:46:20 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103611|0 |1 is obsolete| | --- Comment #113 from Aleisha Amohia --- Created attachment 114171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114171&action=edit Bug 13952: (follow-up) Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:46:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 01:46:25 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103612|0 |1 is obsolete| | --- Comment #114 from Aleisha Amohia --- Created attachment 114172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114172&action=edit Bug 13952: (follow-up) Fixing import for default auth type Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:46:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 01:46:30 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103613|0 |1 is obsolete| | --- Comment #115 from Aleisha Amohia --- Created attachment 114173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114173&action=edit Bug 13952: (follow-up) Fixing export on default biblio framework Signed-off-by: Katrin Fischer Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:46:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 01:46:36 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103614|0 |1 is obsolete| | --- Comment #116 from Aleisha Amohia --- Created attachment 114174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114174&action=edit Bug 13952: (follow-up) template filters, moving js to separate file This patch adds filters to the template file and moves the JS into a separate file. Signed-off-by: Owen Leonard Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:46:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 01:46:42 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103615|0 |1 is obsolete| | --- Comment #117 from Aleisha Amohia --- Created attachment 114175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114175&action=edit Bug 13952: (follow-up) Tests Run: prove -v t/db_dependent/ImportExportFramework.t and confirm all tests pass. I've also added a fix to remove the warns when exporting in ODS format. Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:46:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 01:46:47 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103616|0 |1 is obsolete| | --- Comment #118 from Aleisha Amohia --- Created attachment 114176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114176&action=edit Bug 13952: (follow-up) Removing XML options -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 02:46:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 01:46:53 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #119 from Aleisha Amohia --- Created attachment 114177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114177&action=edit Bug 13952: (follow-up) fixing indentation and rebasing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:11:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:11:03 +0000 Subject: [Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- This sounds like an anti-feature to me. Nick's note on Bug 26457 says that renewals are silently failing. I'd say it would be better to make them fail loudly rather than making this work serially? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:11:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:11:55 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 --- Comment #15 from David Cook --- It would be good to have more data from real life examples. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:13:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:13:30 +0000 Subject: [Koha-bugs] [Bug 26701] Deal with scripts in C4/SIP directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26701 --- Comment #3 from David Cook --- (In reply to Kyle M Hall from comment #2) > I can state confidently that I didn't even know about this script :) I'm glad that I'm not the only one who didn't know that these existed! (Koha is so big O_O.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:14:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:14:37 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:17:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:17:02 +0000 Subject: [Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 --- Comment #17 from David Cook --- (In reply to Fridolin Somers from comment #16) > This change is harmless I'd say. It's harmless but the description is inaccurate. If you renamed this issue to "QueryWeightFields creates unnecessary whitespace", then I would happily test again and probably sign off. But it wouldn't be fixing any functional bug I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:19:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:19:00 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #76 from David Cook --- (In reply to Martin Renvoize from comment #75) > All works well and this is a really good bug to fix.. Passing QA Cheers, Martin :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:22:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:22:27 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Assignee|oleonard at myacpl.org |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:27:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:27:50 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #15 from David Cook --- I'm not sure about this change... Why don't we just set RaiseError and PrintError in Database.pm and then deal with localizations in install.pl and misc4dev? For example: "If you want to temporarily turn RaiseError off (inside a library function that is likely to fail, for example), the recommended way is like this:" https://metacpan.org/pod/DBI#RaiseError { local $h->{RaiseError}; # localize and turn off for this block ... } I'd prefer that ideally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:29:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:29:16 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #15 from David Cook --- (In reply to Timothy Alexis Vass from comment #14) > I will make it --statue-barred-fees. > The fees are literally statute-barred. > Thanks for humouring me, Timothy. I know I am being pedantic, but I really do think it will be helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:32:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:32:17 +0000 Subject: [Koha-bugs] [Bug 26890] opac-detail plugin like intranet/cgi-bin/catalogue/detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26890 --- Comment #19 from David Cook --- (In reply to Mark Hofstetter from comment #18) > I still think plugabiltiy would be a good idea (even if it would be just for > the sake of concistency) > > but thanks to all your advice I was able to to todo it in a plugin > (https://github.com/HKS3/koha-plugin-subordinate-items) just create the tab > with js I'm glad that I was able to help! While I used to be worried about UIs built with Javascript, I think a lot of accessibility tools have advanced to the point where it is OK now. And as a result I think that we should actually be moving more work client-side. (One of the advantages of moving things client-side is also that we can make more robust reusable APIs and make calls to the same API from different places in the system or even from other systems. Koha is a big system so I'd love to see less replication and more reuse.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:49:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:49:26 +0000 Subject: [Koha-bugs] [Bug 27140] koha-zebra doesn't properly stop Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27140 --- Comment #2 from David Cook --- (In reply to Marcel de Rooy from comment #1) > Remember some similar experience. But is the info clear enough for someone > to solve this ticket ? :) Good point heh. Interestingly... I just tried "koha-zebra --stop -v kohadev" and "koha-zebra --start -v kohadev" and it worked correctly. "koha-zebra --restart -v kohadev" just worked too... -- Aha... I just went to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test and then I tried "koha-zebra --stop -v kohadev" but it didn't work. Evidence: ------------------------------ ---------------------------------------- ------------------------------------- root at kohadevbox:koha(bug_12430)$ koha-zebra --start -v kohadev [ ok ] Starting Koha Zebra daemon for kohadev:. root at kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" kohadev+ 25286 1 1 02:38 ? 00:00:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25308 25286 0 02:38 ? 00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25310 3959 0 02:38 pts/1 00:00:00 grep zebrasrv ------------------------------ ---------------------------------------- ------------------------------------- root at kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" kohadev+ 25286 1 0 02:38 ? 00:00:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25308 25286 0 02:38 ? 00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25315 25308 0 02:38 ? 00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25320 3959 0 02:38 pts/1 00:00:00 grep zebrasrv ------------------------------ ---------------------------------------- ------------------------------------- root at kohadevbox:koha(bug_12430)$ koha-zebra --stop -v kohadev [ ok ] Stopping Koha Zebra daemon for kohadev:. root at kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" kohadev+ 25286 1 0 02:38 ? 00:00:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25308 25286 0 02:38 ? 00:00:00 [zebrasrv] kohadev+ 25315 1 0 02:38 ? 00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25357 3959 0 02:38 pts/1 00:00:00 grep zebrasrv ------------------------------ ---------------------------------------- ------------------------------------- It looks like the daemon stop killed the original zebrasrv process but it didn't kill the child process of the original zebrasrv process... If I kill the child process (pid 25315), then everything will terminate: root at kohadevbox:koha(bug_12430)$ kill -9 25315 root at kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" root 25417 3959 0 02:42 pts/1 00:00:00 grep zebrasrv ------------------------------ ---------------------------------------- ------------------------------------- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:53:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:53:02 +0000 Subject: [Koha-bugs] [Bug 27140] koha-zebra doesn't properly stop Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27140 --- Comment #3 from David Cook --- If you manually try to kill the parent zebrasrv, you get the same problem. ------------------------------ ---------------------------------------- ------------------ root at kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" kohadev+ 25532 1 0 02:48 ? 00:00:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25553 25532 0 02:48 ? 00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25560 25553 1 02:48 ? 00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25563 3959 0 02:48 pts/1 00:00:00 grep zebrasrv ------------------------------ ---------------------------------------- ------------------ root at kohadevbox:koha(bug_12430)$ kill 25553 ------------------------------ ---------------------------------------- ------------------ root at kohadevbox:koha(bug_12430)$ ps -efww | grep "zebrasrv" kohadev+ 25532 1 0 02:48 ? 00:00:00 daemon --name=kohadev-koha-zebra --pidfiles=/var/run/koha/kohadev/ --errlog=/var/log/koha/kohadev/zebra-error.log --output=/var/log/koha/kohadev/zebra-output.log --verbose=1 --respawn --del ay=30 --user=kohadev-koha.kohadev-koha -- /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml kohadev+ 25553 25532 0 02:48 ? 00:00:00 [zebrasrv] kohadev+ 25560 1 0 02:48 ? 00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25575 3959 0 02:49 pts/1 00:00:00 grep zebrasrv ------------------------------ ---------------------------------------- ------------------ If we manually kill the parent zebrasrv process, it becomes a zombie and pid 25560 is adopted by pid 1. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 03:57:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 02:57:10 +0000 Subject: [Koha-bugs] [Bug 27140] koha-zebra doesn't properly stop Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27140 --- Comment #4 from David Cook --- If I manually run zebrasrv by hand I'll get the same result which shows that zebrasrv isn't set up to propagate SIGTERM to its child processes. /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml Visit http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test root at kohadevbox:kohadevbox$ ps -efww | grep "zebrasrv" root 25693 3959 0 02:52 pts/1 00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25697 25693 0 02:53 pts/1 00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25712 25617 0 02:53 pts/2 00:00:00 grep zebrasrv root at kohadevbox:kohadevbox$ kill 25693 root at kohadevbox:kohadevbox$ ps -efww | grep "zebrasrv" root 25697 1 0 02:53 pts/1 00:00:00 /usr/bin/zebrasrv -v none,fatal,warn,request -k 1024 -f /etc/koha/sites/kohadev/koha-conf.xml root 25727 25617 0 02:53 pts/2 00:00:00 grep zebrasrv ------------------------------ ---------------------------------------- ------------------ On koha-testing-docker, we are using 2.0.59 (and I have mine set up for ICU atm): root at kohadevbox:kohadevbox$ zebraidx -V Zebra 2.0.59 (C) 1994-2014, Index Data Zebra is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. SHA1 ID: c00bfddbf0f3608340d61298acc61dafb167f9b2 Using ICU Looking at the Zebra news https://github.com/indexdata/idzebra/blob/master/NEWS, I don't see anything about SIGTERM specifically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 04:02:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 03:02:18 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #2 from Aleisha Amohia --- Created attachment 114178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114178&action=edit Bug 16522: Adding 773 to basket and cart WIP Not yet ready for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 04:02:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 03:02:35 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 04:14:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 03:14:36 +0000 Subject: [Koha-bugs] [Bug 27140] koha-zebra doesn't properly stop Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27140 --- Comment #5 from David Cook --- Ultimately, I'd say that we can't reliably use the "daemon" utility to stop "zebrasrv", since "daemon" just sends a SIGTERM signal to "zebrasrv" and "zebrasrv" does not propagate SIGTERM to its child processes. This prevents "zebrasrv" from being stopped by "daemon --stop". Since "zebrasrv" comes with its own -l logfile, -D daemon, and -p pidfile options, I think it would be trivial to just manage zebrasrv via a koha-zebra script that does not use the "daemon" utility. Of course, we'd have to SIGKILL zebrasrv to get it to really stop. Interestingly, looking at https://github.com/indexdata/idzebra/blob/master/etc/init.d/idzebra-init-script shows that they try to "stop" their zebrasrv by just using SIGTERM. (It's also a poorly written service overall...) My guess is that they think it works correctly but I bet that it doesn't... We're running Zebra 2.2.2 on Ubuntu and it looks like someone has provided a different script for /etc/init.d/zebrasrv which uses "start-stop-daemon". This is how that service stops zebrasrv: start-stop-daemon --stop --quiet --retry=TERM/30/KILL/5 --pidfile $PIDFILE --name $NAME However, SIGKILL probably won't work any better as it won't propagate to the child process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 05:16:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 04:16:00 +0000 Subject: [Koha-bugs] [Bug 27134] Zebra reindexing Searching issue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27134 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |dcook at prosentient.com.au Resolution|--- |INVALID --- Comment #1 from David Cook --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 06:29:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 05:29:17 +0000 Subject: [Koha-bugs] [Bug 26328] barcode.pl: ValueBuilder::incremental should filter non-natural numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 --- Comment #4 from David Cook --- I actually ran into this problem again today, and at the moment the query I like best is actually the following: SELECT max(cast(barcode as unsigned)) from items; I'll write up a patch now... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 06:40:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 05:40:50 +0000 Subject: [Koha-bugs] [Bug 26328] barcode.pl: ValueBuilder::incremental should filter non-natural numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 06:40:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 05:40:53 +0000 Subject: [Koha-bugs] [Bug 26328] barcode.pl: ValueBuilder::incremental should filter non-natural numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 --- Comment #5 from David Cook --- Created attachment 114179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114179&action=edit Bug 26328: Cast barcode from varchar to integer for incremental barcode Without this patch, the incremental barcode generation will treat 978e0143019375 as having an exponent and interpret it as a very large number. With this patch, the incremental barcode generation will first cast barcode varchar strings to integers before finding a max() value. In this case 978e0143019375 becomes 978 instead of 1.7976931348623157e308 Test plan: 0. Using koha-testing-docker Before applying patch: 1. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=autobarcode 2. Set to "generated in the form 1, 2, 3" 3. Go to http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?biblionumber=1#additema&searchid=scs_1607059974968 4. Add item with barcode 978e0143019375 5. Click "p - Barcode" 6. Note the barcode is "Inf" After applying patch: 1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/additem.pl?biblionumber=1#additema&searchid=scs_1607059974968 2. Click "p - Barcode" 3. Note the barcode is "39999000019194" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 06:43:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 05:43:31 +0000 Subject: [Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|barcode.pl: |incremental barcode |ValueBuilder::incremental |generation fails when |should filter non-natural |incorrectly converting |numbers |strings to numbers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 06:43:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 05:43:40 +0000 Subject: [Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 07:07:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 06:07:26 +0000 Subject: [Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 --- Comment #6 from Pablo AB --- (In reply to David Cook from comment #4) > I actually ran into this problem again today, and at the moment the query I > like best is actually the following: > > SELECT max(cast(barcode as unsigned)) from items; Why you like the most this one (except for the ABS identical to my first suggestion), instead of your alternative con comment 1? I remember that at the time your suggestion seems better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 07:37:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 06:37:01 +0000 Subject: [Koha-bugs] [Bug 27150] New: Batch delete items broke. Returns "0 item(s) deleted" Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27150 Bug ID: 27150 Summary: Batch delete items broke. Returns "0 item(s) deleted" Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: somesecretemail at mailinator.com QA Contact: testopia at bugs.koha-community.org Steps to reproduce: 1. Navigate to a biblio with available items (ie https://kodevsod-intra.dev.imcode.com/cgi-bin/koha/catalogue/detail.pl?biblionumber=3296381) 2. Check boxes for två available items 3. Click "🗑 Delete selected items" 4. Batch item deletion view is loaded. Click button "Delete selected items" 5. System presents text "0 item(s) deleted" Expected result: 2 item(s) deleted. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 08:30:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 07:30:18 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #16 from Timothy Alexis Vass --- (In reply to David Cook from comment #15) > (In reply to Timothy Alexis Vass from comment #14) > > I will make it --statue-barred-fees. > > The fees are literally statute-barred. > > > > Thanks for humouring me, Timothy. I know I am being pedantic, but I really > do think it will be helpful. I agree David. It definitely is more obvious and that is definitely important. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 10:16:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 09:16:21 +0000 Subject: [Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 --- Comment #16 from Emmi Takkinen --- Created attachment 114180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114180&action=edit Bug 12388: Adjust tests some more We should now test if issues are really sorted with date_due. This patch adjusts test for daily loans so that test issues have different date_due values. Also removes some now unneeded code from IssueSlip.t. To test prove t/db_dependent/Members/IssueSlip.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 10:16:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 09:16:35 +0000 Subject: [Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 10:27:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 09:27:07 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114164|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 114181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114181&action=edit Bug 26665: (bug 20168 follow-up) Fix path to bootstrap js file 20168 moved it to /opac-tmpl/bootstrap/lib/bootstrap/js/bootstrap.bundle.min.js It fixed the OAI-PMH view Test plan: Hit /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marc21 and confirm that you can click "Metadata" and it opens Signed-off-by: David Nind Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 10:27:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 09:27:17 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 10:28:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 09:28:32 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|With OIA-PMH enabled, if |With OAI-PMH enabled, if release notes|you clicked on Sets or |you clicked on Sets or |Metadata in the search |Metadata in the search |results no additional |results no additional |information was displayed |information was displayed |(example query: |(example query: |/cgi-bin/koha/ |/cgi-bin/koha/ |oai.pl?verb=ListRecords&met |oai.pl?verb=ListRecords&met |adataPrefix=marc21). This |adataPrefix=marc21). This |patch fixes this so that |patch fixes this so that |the additional information |the additional information |for Sets and Metadata is |for Sets and Metadata is |now correctly displayed. |now correctly displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 10:33:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 09:33:27 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114147|0 |1 is obsolete| | --- Comment #7 from Julian Maurice --- Created attachment 114182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114182&action=edit Bug 27144: Fix syntax error that prevents deleting patrons To test: 1) In staff interface open up a patron record 2) Click More -> Delete, and then "Yes, delete" 3) Notice 500 error 4) Apply patch 5) Notice error is now gone when deleting Signed-off-by: Kyle M Hall Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 10:34:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 09:34:09 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 10:53:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 09:53:30 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- We should move $patron->move_to_deleted into the try and execute the two statements inside a transaction. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 11:16:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 10:16:03 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #16 from Jonathan Druart --- See the commit message, it does not work. It is what we are doing currently. Without unsafe, DBIC does not accept RaiseError turned off. Have a look at DBIx::Class::Storage::DBI->_connect for more information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 11:33:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 10:33:47 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #4 from Julian Maurice --- The use of global variable `select2Width' can be easily avoided here by replacing it by a call to $.fn.select2.defaults.set directly after [% INCLUDE 'select2.inc' %] in addbiblio.tt Is there any benefit using this global variable ? (except for the shorter name) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 11:52:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 10:52:32 +0000 Subject: [Koha-bugs] [Bug 27151] New: SIP2 server doesn't handle broken connections which then kills SIP2 server Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27151 Bug ID: 27151 Summary: SIP2 server doesn't handle broken connections which then kills SIP2 server Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Koha SIP2 server doesn't handle the situation where a client unexpectedly closes socket, this leads to the SIP2 server processes being killed and therefore SIP2 service being unavailable. sip-error.log when this happens: koha3-koha-sip: client (pid 1181) killed by signal 13, stopping More info on this issue I found from the perl website manual (https://perldoc.perl.org/perlipc): "Be careful to check the return values from both open() and close(). If you're writing to a pipe, you should also trap SIGPIPE. [...]" Another problem we have is that the koha-common service doesn't start the process if it gets killed, but let's focus here only on the SIGPIPE issue. This has happened now 2 times in around 1 month period on our Koha SIP instances. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:11:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 11:11:33 +0000 Subject: [Koha-bugs] [Bug 27151] SIP2 server doesn't handle broken connections which then kills SIP2 server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27151 Andrew Nugged changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:20:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 11:20:00 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:20:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 11:20:27 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24254 | Depends on| |24254 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 [Bug 24254] Add Koha::Items->filter_by_visible_in_opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:20:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 11:20:27 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15448 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15448 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:24:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 11:24:30 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 --- Comment #16 from Nick Clemens --- (In reply to David Cook from comment #15) > It would be good to have more data from real life examples. >From the access logs, there are three requests with the same timestamp: somesite.bywatersolutions.com:80 IP.IP.IP.IP - - [30/Nov/2020:16:02:14 -0700] "POST /cgi-bin/koha/svc/renew HTTP/1.1" 200 349 "https://staff.somesite.bywatersolutions.com/cgi-bin/koha/circ/circulation.pl?borrowernumber=250710" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.198 Safari/537.36" somesite.bywatersolutions.com:80 IP.IP.IP.IP - - [30/Nov/2020:16:02:14 -0700] "POST /cgi-bin/koha/svc/renew HTTP/1.1" 200 350 "https://staff.somesite.bywatersolutions.com/cgi-bin/koha/circ/circulation.pl?borrowernumber=250710" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.198 Safari/537.36" somesite.bywatersolutions.com:80 IP.IP.IP.IP - - [30/Nov/2020:16:02:14 -0700] "POST /cgi-bin/koha/svc/renew HTTP/1.1" 200 349 "https://staff.somesite.bywatersolutions.com/cgi-bin/koha/circ/circulation.pl?borrowernumber=250710" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.198 Safari/537.36" In the plack log: DBD::mysql::st execute failed: Deadlock found when trying to get lock; try restarting transaction [for Statement "UPDATE issues SET date_due = ?, renewals = ?, lastreneweddate = ? WHERE borrowernumber=? AND itemnumber=?" with ParamValues: 0='2020-12-30 23:59', 1=1, 2=DateTime=HASH(0x5561e7d4fb08), 3="borrowernumber", 4="itemnumber"] at /usr/share/koha/lib/C4/Circulation.pm line 2964. In the action_logs: *************************** 15. row *************************** action_id: 10050103 timestamp: 2020-11-30 16:02:14 user: staff_borrowernumber module: CIRCULATION action: RENEWAL object: borrowernumber info: itemnumber interface: intranet Statistics: *************************** 19. row *************************** datetime: 2020-11-30 16:02:14 branch: BRANCH value: 0.0000 type: renew other: itemnumber: itemnumber itemtype: BOOK location: ADULT borrowernumber: borrowernumber ccode: FICTION Issues table: *************************** 1. row *************************** Table: issues Create Table: CREATE TABLE `issues` ( `issue_id` int(11) NOT NULL AUTO_INCREMENT, `borrowernumber` int(11) NOT NULL, `itemnumber` int(11) NOT NULL, `date_due` datetime DEFAULT NULL, `branchcode` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL, `returndate` datetime DEFAULT NULL, `lastreneweddate` datetime DEFAULT NULL, `renewals` tinyint(4) NOT NULL DEFAULT '0', `auto_renew` tinyint(1) DEFAULT '0', `auto_renew_error` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL, `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, `issuedate` datetime DEFAULT NULL, `onsite_checkout` int(1) NOT NULL DEFAULT '0', `note` longtext COLLATE utf8mb4_unicode_ci, `notedate` datetime DEFAULT NULL, `noteseen` int(1) DEFAULT NULL, PRIMARY KEY (`issue_id`), KEY `issuesborridx` (`borrowernumber`), KEY `bordate` (`borrowernumber`,`timestamp`), KEY `itemnumber_idx` (`itemnumber`), KEY `branchcode_idx` (`branchcode`), CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE, CONSTRAINT `issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON UPDATE CASCADE ) ENGINE=InnoDB AUTO_INCREMENT=increment DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci Server version: 10.1.47-MariaDB-0+deb9u1 Debian 9.13 Koha 19.1108000 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:34:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 11:34:40 +0000 Subject: [Koha-bugs] [Bug 27152] New: Add a batch/bulk renewal endpoint Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27152 Bug ID: 27152 Summary: Add a batch/bulk renewal endpoint Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 26457 and bug 26208 are related to problems from too many renewal transactions hitting the database simultaneously. Ideally we would be able to send a single renewal request for all of a patrons checkouts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:34:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 11:34:56 +0000 Subject: [Koha-bugs] [Bug 27152] Add a batch/bulk renewal endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27152 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:38:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 11:38:30 +0000 Subject: [Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 --- Comment #4 from Nick Clemens --- (In reply to David Cook from comment #3) > This sounds like an anti-feature to me. > > Nick's note on Bug 26457 says that renewals are silently failing. I'd say it > would be better to make them fail loudly rather than making this work > serially? In these cases with restrictions there are no failures, just a race condition: # Remove any OVERDUES related debarment if the borrower has no overdues if ( $patron && $patron->is_debarred && ! $patron->has_overdues && @{ GetDebarments({ borrowernumber => $borrowernumber, type => 'OVERDUES' }) } ) { DelUniqueDebarment({ borrowernumber => $borrowernumber, type => 'OVERDUES' }); } When all the transactions hit at once they are getting conflicting information and not removing the debarment, so all items renewed but restrictions stay I filed bug 27152, but currently this is a bug affecting many sites and this is a simple solution. There is a performance cost, but there will be with a bulk endpoint too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 12:56:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 11:56:00 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 --- Comment #3 from Kyle M Hall --- Created attachment 114183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114183&action=edit Bug 27145: Wrap delete and move_to_deleted in a transaction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 13:07:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 12:07:06 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 13:07:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 12:07:09 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 --- Comment #17 from Nick Clemens --- Created attachment 114184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114184&action=edit Bug 26457: Throw exception if update of issues table fails While this won't prevent the deadlock, it should catch the case where a deadlock causes the DB update to fail and provide feedback to the user and rollback the transaction I don't know how to trigger the deadlock, I can only confirm that we see it, and that this should catch it. To test: 1 - Apply patches 2 - Confirm that 'Renew all' feature continues to work as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 13:08:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 12:08:17 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114184|0 |1 is obsolete| | --- Comment #18 from Nick Clemens --- Created attachment 114185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114185&action=edit Bug 26457: Throw exception if update of issues table fails While this won't prevent the deadlock, it should catch the case where a deadlock causes the DB update to fail and provide feedback to the user and rollback the transaction I don't know how to trigger the deadlock, I can only confirm that we see it, and that this should catch it. To test: 1 - Apply patches 2 - Confirm that 'Renew all' feature continues to work as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 13:09:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 12:09:44 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114185|0 |1 is obsolete| | --- Comment #19 from Nick Clemens --- Created attachment 114186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114186&action=edit Bug 26457: Throw exception if update of issues table fails While this won't prevent the deadlock, it should catch the case where a deadlock causes the DB update to fail and provide feedback to the user and rollback the transaction I don't know how to trigger the deadlock, I can only confirm that we see it, and that this should catch it. To test: 1 - Apply patches 2 - Confirm that 'Renew all' feature continues to work as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 13:19:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 12:19:16 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 13:19:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 12:19:19 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113875|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 13:19:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 12:19:22 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113876|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 13:20:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 12:20:59 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114186|0 |1 is obsolete| | --- Comment #20 from Nick Clemens --- Created attachment 114187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114187&action=edit Bug 26457: Throw exception if update of issues table fails While this won't prevent the deadlock, it should catch the case where a deadlock causes the DB update to fail and provide feedback to the user and rollback the transaction I don't know how to trigger the deadlock, I can only confirm that we see it, and that this should catch it. To test: 1 - Apply patches 2 - Confirm that 'Renew all' feature continues to work as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 13:21:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 12:21:50 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 114188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114188&action=edit Bug 15448: Filter out items hidden in OPAC on placing hold This patch leverages on bug 24254's Koha::Items->filter_by_visible_in_opac to filter out items that shouldn't be presented to the end user in the OPAC interface. To test: 1. Circulation and Fine rules for item-level holds are set to allow. 2. Setting the OpacHiddenItems preference to "ccode: [SUPPRESS]" 3. An item with collection Code Suppress is set. 4. Search for the title in the OPAC. => SUCCESS: The Suppress ccode item isn't shown. 5. View the detail page for the title. => SUCCESS: The suppress ccode item isn't shown. 6. Place a hold on the item: -- Click "Show more options" -- Select "A specific item" => FAIL: the ccode with the opachiddenitems rule has an item that appear in the list to place a hold 7. Apply this patch and repeat 6 => SUCCESS: The item doesn't show! 8. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 13:21:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 12:21:55 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 114189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114189&action=edit Bug 15448: (follow-up) Fetch the patron category once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 13:30:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 12:30:50 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114187|0 |1 is obsolete| | --- Comment #21 from Nick Clemens --- Created attachment 114190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114190&action=edit Bug 26457: Throw exception if update of issues table fails While this won't prevent the deadlock, it should catch the case where a deadlock causes the DB update to fail and provide feedback to the user and rollback the transaction I don't know how to trigger the deadlock, I can only confirm that we see it, and that this should catch it. To test: 1 - Apply patches 2 - Confirm that 'Renew all' feature continues to work as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 14:08:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 13:08:05 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 114191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114191&action=edit Bug 15448: (QA follow-up) Move fetching the rules outside the loop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 14:08:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 13:08:29 +0000 Subject: [Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPACHiddenItems show in |Placing hold on specific |OPAC when patron places a |items doesn't enforce |hold on a specific item |OpacHiddenItems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 14:16:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 13:16:58 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114093|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 114192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114192&action=edit Bug 27003: Item creation log must be done after the item is created Otherwise we don't have its itemnumber yet! Test plan: Add and modify an item and confirm that the action logs are created correctly Signed-off-by: Nick Clemens Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 14:17:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 13:17:06 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 14:20:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 13:20:15 +0000 Subject: [Koha-bugs] [Bug 27009] Use 301 to redirect from tracklinks.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27009 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Julian Maurice --- Changing status to Failed QA to get feedback -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 14:29:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 13:29:33 +0000 Subject: [Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Severity|minor |critical --- Comment #14 from Kyle M Hall --- Bumping the severity. This bug do to the nature of the bug causing ISEs that make some actions impossible. No data loss so not a blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:01:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:01:54 +0000 Subject: [Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:01:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:01:58 +0000 Subject: [Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:02:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:02:03 +0000 Subject: [Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114191|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:02:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:02:31 +0000 Subject: [Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 114193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114193&action=edit Bug 15448: Filter out items hidden in OPAC on placing hold This patch leverages on bug 24254's Koha::Items->filter_by_visible_in_opac to filter out items that shouldn't be presented to the end user in the OPAC interface. To test: 1. Circulation and Fine rules for item-level holds are set to allow. 2. Setting the OpacHiddenItems preference to "ccode: [SUPPRESS]" 3. An item with collection Code Suppress is set. 4. Search for the title in the OPAC. => SUCCESS: The Suppress ccode item isn't shown. 5. View the detail page for the title. => SUCCESS: The suppress ccode item isn't shown. 6. Place a hold on the item: -- Click "Show more options" -- Select "A specific item" => FAIL: the ccode with the opachiddenitems rule has an item that appear in the list to place a hold 7. Apply this patch and repeat 6 => SUCCESS: The item doesn't show! 8. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:02:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:02:36 +0000 Subject: [Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 114194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114194&action=edit Bug 15448: (follow-up) Fetch the patron category once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:04:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:04:07 +0000 Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:04:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:04:10 +0000 Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114021|0 |1 is obsolete| | Attachment #114022|0 |1 is obsolete| | Attachment #114023|0 |1 is obsolete| | Attachment #114024|0 |1 is obsolete| | Attachment #114025|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 114195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114195&action=edit Bug 26947: Add scheam-only option to koha-dump This patch adds a new --schema-only optoin to the koha-dump script. This can be used to generate a new kohastructure.sql file during the release, and later to compare the DB structure of a koha instance to the kohastructure.sql file shipped with a version to identify any missing constraints or other db structure issues To test: 1 - debian/scripts/koha-dump kohadev 2 - Confirm db and configs are dumped correctly 3 - Apply patch 4 - debian/scripts/koha-dump --help 5 - Confirm new option is listed and makes sense 6 - debian/scripts/koha-dump --schema-only kohadev 7 - Confirm only schema is dumped and is not zipped 8 - debian/scripts/koha-dump kohadev 9 - Confirm entire db is dumped as before Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:04:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:04:23 +0000 Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 --- Comment #36 from Kyle M Hall --- Created attachment 114196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114196&action=edit Bug 26947: (follow-up) Set key checks to disabled for kohastructure This patch adds sql calls to disable foreign key checks for the initial kohastructure schema load and then re-enables them again for subsequent actions. Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:04:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:04:31 +0000 Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 --- Comment #37 from Kyle M Hall --- Created attachment 114197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114197&action=edit Bug 26947: Move -- comment to the COMMENT clause Sed command from bug 26947 comment 8 sed -r --in-place 's/,\s*-- (.*)$/ COMMENT "\1",/g;' installer/data/mysql/kohastructure.sql Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:04:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:04:34 +0000 Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 --- Comment #38 from Kyle M Hall --- Created attachment 114198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114198&action=edit Bug 26947: Replace double quotes from comments Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:04:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:04:38 +0000 Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 --- Comment #39 from Kyle M Hall --- Created attachment 114199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114199&action=edit Bug 26947: Correct path for chown and chmod Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:13:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:13:07 +0000 Subject: [Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |joonas.kylmala at helsinki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:14:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:14:11 +0000 Subject: [Koha-bugs] [Bug 26996] Elasticsearch: Multiprocess reindexing sometimes doesn't reindex all records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26996 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi Status|Needs Signoff |Failed QA --- Comment #2 from Joonas Kylmälä --- Thanks, this fixes the problem indeed. Few things to improve on the patch: - In the commit title describe what the fix does, not what the problem is. E.g. "Convert Elasticsearch indexer commit buffer size to int" and in the body describe that it fixes the buffer counter not resetting and the reason why it fixes it. - In the commit title use "Bug XXXX: YYY" format which is used by every other commit we have (now there is the "-" character instead). - Add whitespace between the multiplication and parentheses. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:20:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:20:27 +0000 Subject: [Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 --- Comment #6 from Kyle M Hall --- The unit test isn't failing wit the second patch applied. Should it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:20:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:20:48 +0000 Subject: [Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 --- Comment #7 from Kyle M Hall --- (In reply to Kyle M Hall from comment #6) > The unit test isn't failing wit the second patch applied. Should it? With the second patch *not* applied, that is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:20:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:20:59 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #71 from Jonathan Druart --- Nick, why did you copy/pasted get_yaml_pref_hash in Koha/Config/SysPref.pm and Koha/Util/SystemPreferences.pm? Koha/Config/SysPref.pm:sub get_yaml_pref_hash { Koha/Util/SystemPreferences.pm:sub get_yaml_pref_hash { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:24:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:24:00 +0000 Subject: [Koha-bugs] [Bug 12224] Allow easy printing of patron check-in slip In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12224 --- Comment #50 from Emmi Takkinen --- Followed test plan(s), "Print checkin slip" buttons work and new window is opened for printing. However list of checked in items isn't printed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:24:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:24:23 +0000 Subject: [Koha-bugs] [Bug 27032] CanBookBeRenewed is not understandable and needs refactoring In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27032 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:28:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:28:31 +0000 Subject: [Koha-bugs] [Bug 27137] Move item doesn't show the title of the target record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27137 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Pushed to stable --- Comment #4 from Jonathan Druart --- Sending to 20.05 RM queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:32:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:32:47 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114138|0 |1 is obsolete| | --- Comment #77 from Jonathan Druart --- Created attachment 114200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114200&action=edit Bug 12430: Add unit tests for C4::Search::buildQuery This patch adds unit tests for buildQuery, especially focusing on the use of the (rk=()) wrapper. Note that the Net::Z3950::ZOOM library is used to test the queries for CCL validity on top of the string matching used in the got/expected comparisons. Signed-off-by: Martin Renvoize JD amended patch: fix spelling connexion ==> connection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:40:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:40:11 +0000 Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 --- Comment #40 from Jonathan Druart --- Created attachment 114201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114201&action=edit Bug 26947: Update kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:55:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:55:27 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #17 from Timothy Alexis Vass --- Created attachment 114202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114202&action=edit Bug 27080: Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. According to Swedish law, fees become statute-barred after 3 years. With this option, we can use cleanup_database.pl to purge those from accountlines. NOTE: This commit also fixes indentations. You can use the -w option with git to ignore space differences. To test: 1) You will need at least one record in the accountlines table WHERE status = 'RETURNED' AND amountoutstanding > 0. 2) Run ./misc/cronjobs/cleanup_database.pl --statute-barred-fees DAYS Where DAYS is 1 or greater. This will delete records from accountlines WHERE date is DAYS day(s) or older. 3) Confirm that records have been deleted. Sponsored-by: Lunds Universitetsbibliotek -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:55:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:55:54 +0000 Subject: [Koha-bugs] [Bug 27153] New: ElasticSearch should search keywords apostrophe blind Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Bug ID: 27153 Summary: ElasticSearch should search keywords apostrophe blind Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.field at ptfs-europe.com We are often asked why keyword searches don't ignore apostrophes. If you searched for "carries war" on Google, the first hits that come up are for Carrie's War by Nina Bawden. If you do a keyword search in Koha for "carries war" you get 0 hits. If you search for "carrie's war" you will find copies of this book. Koha with ElasticSearch should search apostrophe-blind (ignore the apostrophe). This was a perennial problem with zebra. In zebra you had to change words-icu.xml to ignore apostrophes. We should deliver an ES index_config.yaml that handles this scenario. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:56:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:56:12 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:56:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:56:41 +0000 Subject: [Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113824|0 |1 is obsolete| | Attachment #113825|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä --- Created attachment 114203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114203&action=edit Bug 27058: Add test to show ordered items cannot be checked out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:56:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:56:44 +0000 Subject: [Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 --- Comment #9 from Joonas Kylmälä --- Created attachment 114204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114204&action=edit Bug 27058: Make checkout availability use all notforloan reasons The ItemsAnyAvailableAndNotRestricted function is checking whether an item can be checked out and it incorrectly only checks the positive notforloan values when there can be also negative notforloan values. If notforloan value is not 0 then it means the item cannot be checked out. In the case of ordered items the value is negative (-1) and thus before this change the checkout availability was reported incorrectly. To test: 1) Run prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Notice it fails 2) Apply this patch 3) Run prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Notice it passes now. To test via Koha sandbox (Alternatively): 1) Create circ rule with If all unavailable 2) Create new biblio 3) Order a new item to the biblio via acquisitions and set the not for loan value to Ordered / -1 4) Notice you cannot place a hold to the biblio 5) Apply patch 6) Notice you can now place a hold to the biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:58:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:58:39 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114083|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 15:59:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 14:59:40 +0000 Subject: [Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 --- Comment #10 from Joonas Kylmälä --- (In reply to Kyle M Hall from comment #6) > The unit test isn't failing wit the second patch applied. Should it? yes, it should have failed. I fixed the test now – the circulation rule in the scenario was made for $itemtype itemtype when the ordered item had $itemtype2 itemtype. Not sure why I didn't spot this on my testing, maybe the test database I had was different for me earlier? Anyway, ready for review now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:00:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:00:54 +0000 Subject: [Koha-bugs] [Bug 27154] New: Koha/Util/SystemPreferences.pm must be removed Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154 Bug ID: 27154 Summary: Koha/Util/SystemPreferences.pm must be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: nick at bywatersolutions.com Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org On bug 15494, the same method "get_yaml_pref_hash" has been added to two modules, Koha/Config/SysPref.pm and Koha/Util/SystemPreferences.pm? Koha/Config/SysPref.pm:sub get_yaml_pref_hash { Koha/Util/SystemPreferences.pm:sub get_yaml_pref_hash { We should remove the whole Koha/Util/SystemPreferences.pm package. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:01:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:01:05 +0000 Subject: [Koha-bugs] [Bug 15494] Block renewals by arbitrary item values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27154 --- Comment #72 from Jonathan Druart --- (In reply to Jonathan Druart from comment #71) > Nick, why did you copy/pasted get_yaml_pref_hash in Koha/Config/SysPref.pm > and Koha/Util/SystemPreferences.pm? > > Koha/Config/SysPref.pm:sub get_yaml_pref_hash { > Koha/Util/SystemPreferences.pm:sub get_yaml_pref_hash { Opened bug 27154. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154 [Bug 27154] Koha/Util/SystemPreferences.pm must be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:01:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:01:05 +0000 Subject: [Koha-bugs] [Bug 27154] Koha/Util/SystemPreferences.pm must be removed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27154 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15494 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 [Bug 15494] Block renewals by arbitrary item values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:04:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:04:44 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | --- Comment #22 from Jonathan Druart --- Could you provide a test? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:04:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:04:48 +0000 Subject: [Koha-bugs] [Bug 15791] Don't delete a fund if existing orders are linked to it In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15791 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:05:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:05:50 +0000 Subject: [Koha-bugs] [Bug 26849] Fix Array::Utils dependency in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:06:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:06:13 +0000 Subject: [Koha-bugs] [Bug 26848] Fix Readonly dependency in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:15:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:15:36 +0000 Subject: [Koha-bugs] [Bug 27155] New: Biblio and Item hooks should pass a deleted object on record deletion Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155 Bug ID: 27155 Summary: Biblio and Item hooks should pass a deleted object on record deletion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org The biblio and item hooks now look up a record which is deleted already. We could pass the deletedbiblio or deleteditem? Especially on item deletion I am interested in receiving the biblionumber. The code for items differs between 19.11 and master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:27:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:27:06 +0000 Subject: [Koha-bugs] [Bug 27156] New: Add column configuration to Item Search results table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27156 Bug ID: 27156 Summary: Add column configuration to Item Search results table Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org It would be helpful to be able to hide columns from the results table of an Item Search in the staff client. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:33:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:33:22 +0000 Subject: [Koha-bugs] [Bug 27157] New: Add batch editing capability to the Item Search results table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27157 Bug ID: 27157 Summary: Add batch editing capability to the Item Search results table Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org It would be great if batch editing capability, such as batch edit, batch delete and merge records, was available from the list of results in Item Search. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:38:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:38:02 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #78 from Jonathan Druart --- t/db_dependent/Search.t is failing, can you have a look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:38:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:38:11 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #79 from Jonathan Druart --- # Failed test 'buildQuery should keep 0 value' # at t/db_dependent/Search.t line 669. # got: 'su,phr=(rk=(0)) ' # expected: 'su,phr=0 ' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 16:40:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 15:40:39 +0000 Subject: [Koha-bugs] [Bug 27155] Biblio and Item hooks should pass a deleted object on record deletion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27155 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:02:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:02:56 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #80 from Jonathan Druart --- Apparently the other failure is also coming from here. t/db_dependent/selenium/regressions.t # Looks like you planned 4 tests but ran 3. t/db_dependent/selenium/regressions.t .. 2/5 # Failed test 'OPAC - Remove from cart' # at t/db_dependent/selenium/regressions.t line 109. Error while executing command: clickElement: An unknown server-side error occurred while processing the command.: Element is not clickable at point (583.7000122070312, 14). Other element would receive the click: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:03:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:03:39 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | --- Comment #81 from Jonathan Druart --- Ho by the way, I pushed these patches to master! Pushed to master for 21.05.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:04:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:04:39 +0000 Subject: [Koha-bugs] [Bug 16067] Koha::Cache, fastmmap caching system is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16067 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:04:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:04:41 +0000 Subject: [Koha-bugs] [Bug 16067] Koha::Cache, fastmmap caching system is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16067 --- Comment #13 from Jonathan Druart --- Pushed to master for 20.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:04:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:04:43 +0000 Subject: [Koha-bugs] [Bug 26336] Cannot import items if items ignored when staging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:04:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:04:45 +0000 Subject: [Koha-bugs] [Bug 26336] Cannot import items if items ignored when staging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:04:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:04:47 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:04:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:04:49 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:04:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:04:51 +0000 Subject: [Koha-bugs] [Bug 26976] When renewalsallowed is empty the UI is not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:04:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:04:52 +0000 Subject: [Koha-bugs] [Bug 26976] When renewalsallowed is empty the UI is not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26976 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:04:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:04:54 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:04:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:04:56 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 --- Comment #6 from Jonathan Druart --- Pushed to master for 20.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:04:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:04:58 +0000 Subject: [Koha-bugs] [Bug 27030] The new "Processing" hold status is missing in C4::Reserves module documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27030 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:05:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:05:00 +0000 Subject: [Koha-bugs] [Bug 27030] The new "Processing" hold status is missing in C4::Reserves module documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27030 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:05:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:05:01 +0000 Subject: [Koha-bugs] [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:05:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:05:03 +0000 Subject: [Koha-bugs] [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 --- Comment #4 from Jonathan Druart --- Pushed to master for 20.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:05:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:05:05 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:05:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:05:07 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 --- Comment #8 from Jonathan Druart --- Pushed to master for 20.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 17:07:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 16:07:19 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #82 from Jonathan Druart --- Created attachment 114205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114205&action=edit Bug 12430: Fix selenium/regressions.t failure Test failed with # Looks like you planned 4 tests but ran 3. t/db_dependent/selenium/regressions.t .. 2/5 # Failed test 'OPAC - Remove from cart' # at t/db_dependent/selenium/regressions.t line 109. Error while executing command: clickElement: An unknown server-side error occurred while processing the command.: Element is not clickable at point (583.7000122070312, 14). Other element would receive the click: https://pic.infini.fr//Qhq7pLBq/jT9wZ7F1 The remove from basket link for the biblio 3 is hidden by the floating toolbar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:12:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 18:12:08 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:23:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 18:23:08 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:23:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 18:23:11 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114159|0 |1 is obsolete| | Attachment #114160|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 114206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114206&action=edit Bug 24254: Unit tests Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:23:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 18:23:21 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #8 from Kyle M Hall --- Created attachment 114207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114207&action=edit Bug 24254: Add Koha::Items->filter_by_visible_in_opac This patch adds a method based on the original idea from Nick, but on Koha::Items. The idea is to build a proper filter, based on the current rules for hiding things, directly on the DBIC query. The caller takes care of knowing if the filtering should apply (i.e. checking the patron category exceptions) and then it would do something like: my @items; if ( ) { @items = $biblio->items->filter_by_visible_in_opac( { rules => $rules } ); } else { # still want to enforce 'hidelostitems' @items = $biblio->items->filter_by_visible_in_opac; } To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Look at the use cases on the tests, read the code => SUCCESS: It all makes sense 4. Compare with Koha::Item->hidden_in_opac => SUCCESS: It all makes sense 5. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:27:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 18:27:15 +0000 Subject: [Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:27:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 18:27:19 +0000 Subject: [Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114193|0 |1 is obsolete| | Attachment #114194|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 114208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114208&action=edit Bug 15448: Filter out items hidden in OPAC on placing hold This patch leverages on bug 24254's Koha::Items->filter_by_visible_in_opac to filter out items that shouldn't be presented to the end user in the OPAC interface. To test: 1. Circulation and Fine rules for item-level holds are set to allow. 2. Setting the OpacHiddenItems preference to "ccode: [SUPPRESS]" 3. An item with collection Code Suppress is set. 4. Search for the title in the OPAC. => SUCCESS: The Suppress ccode item isn't shown. 5. View the detail page for the title. => SUCCESS: The suppress ccode item isn't shown. 6. Place a hold on the item: -- Click "Show more options" -- Select "A specific item" => FAIL: the ccode with the opachiddenitems rule has an item that appear in the list to place a hold 7. Apply this patch and repeat 6 => SUCCESS: The item doesn't show! 8. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:27:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 18:27:30 +0000 Subject: [Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #27 from Kyle M Hall --- Created attachment 114209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114209&action=edit Bug 15448: (follow-up) Fetch the patron category once Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:30:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 18:30:05 +0000 Subject: [Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:30:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 18:30:08 +0000 Subject: [Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114203|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 114210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114210&action=edit Bug 27058: Add test to show ordered items cannot be checked out Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 19:30:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 18:30:20 +0000 Subject: [Koha-bugs] [Bug 27058] Cannot place hold to ordered item when on shelf holds are not allowed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27058 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114204|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 114211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114211&action=edit Bug 27058: Make checkout availability use all notforloan reasons The ItemsAnyAvailableAndNotRestricted function is checking whether an item can be checked out and it incorrectly only checks the positive notforloan values when there can be also negative notforloan values. If notforloan value is not 0 then it means the item cannot be checked out. In the case of ordered items the value is negative (-1) and thus before this change the checkout availability was reported incorrectly. To test: 1) Run prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Notice it fails 2) Apply this patch 3) Run prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Notice it passes now. To test via Koha sandbox (Alternatively): 1) Create circ rule with If all unavailable 2) Create new biblio 3) Order a new item to the biblio via acquisitions and set the not for loan value to Ordered / -1 4) Notice you cannot place a hold to the biblio 5) Apply patch 6) Notice you can now place a hold to the biblio Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:56:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 19:56:50 +0000 Subject: [Koha-bugs] [Bug 27158] New: software error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27158 Bug ID: 27158 Summary: software error Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs at lists.koha-community.org Reporter: nishathahmed at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Hi THere, In the given link on OPAC (i.e.) your list http://localhost/cgi-bin/koha/opac-shelves.pl?op=list&category=1 when I click I get following error Software error: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.created_on' in 'field list' at /usr/share/perl5/Data/Page.pm line 49 For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. Please help me out. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 20:58:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 19:58:26 +0000 Subject: [Koha-bugs] [Bug 27158] software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27158 Nishath Ahmed changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Z39.50 / SRU / OpenSearch |OPAC |Servers | Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | CC| |nishathahmed at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 4 23:58:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 22:58:23 +0000 Subject: [Koha-bugs] [Bug 27036] Confusing translation of "Sort by date" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27036 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com Resolution|--- |INVALID Status|Needs Signoff |RESOLVED --- Comment #2 from Caroline Cyr La Rose --- I did the corrections on translate.koha-community.org. Closing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 00:29:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 23:29:31 +0000 Subject: [Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 00:29:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 23:29:35 +0000 Subject: [Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #1 from Agustín Moyano --- Created attachment 114212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114212&action=edit Bug 23207: Add test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 00:29:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 23:29:38 +0000 Subject: [Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #2 from Agustín Moyano --- Created attachment 114213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114213&action=edit Bug 23207: Add automatic_checkin column to itemtypes table installer/data/mysql/kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 00:29:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 23:29:42 +0000 Subject: [Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #3 from Agustín Moyano --- Created attachment 114214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114214&action=edit Bug 23207: Set automatic_checkin column as boolean in Itemtype schema -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 00:29:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 04 Dec 2020 23:29:46 +0000 Subject: [Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 --- Comment #4 from Agustín Moyano --- Created attachment 114215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114215&action=edit Bug 23207: Add automatic checkin feature This patch adds the posibility to set an itemtype with automatic checkin. It means that when the checkout is due, it will automatically check in. To test: 1. apply patches 2. updatedatabase 3. go to koha administration -> item types and edin an item type (from now on called itemtype1) CHECK => there is a checkbox almost at the end called automatic checkin 4. check that checkbox and save 5. checkout 2 items from itemtype1 and one item from another itemtype (from now on called itemtype2) 6. go to mysql database console (koha-mysql) and manually set date_due = current_timestamp in issues table for the item of itemtype2 and only one of the items of itemtype1 7. run cronjob at misc/cronjobs/automatic_checkin.pl 8. go to mysql database console again and select * from issues SUCCESS => All issues are present except for the issue of itemtype1 which had it's date_due set to current_timestamp. That one was automatically checked in. 9. prove t/db_dependent/Koha/Checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 5 08:10:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 05 Dec 2020 07:10:10 +0000 Subject: [Koha-bugs] [Bug 27159] New: Sorting A-Z Catalogue Incorrect Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27159 Bug ID: 27159 Summary: Sorting A-Z Catalogue Incorrect Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: ariffshah at gmi.edu.my QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 114216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114216&action=edit Sorting A-Z incorrect in catalogue Sorting A-Z mixed & not correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 06:04:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 05:04:07 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Assignee|wizzyrea at gmail.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 06:04:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 05:04:34 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC|alex.arnaud at biblibre.com, | |arouss1980 at gmail.com, | |ByWaterSandboxes at gmail.com, | |chris at bigballofwax.co.nz, | |gmcharlt at gmail.com, | |hayleymapley at catalyst.net.n | |z, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |julian.maurice at biblibre.com | |, katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |liz at catalyst.net.nz, | |m.de.rooy at rijksmuseum.nl, | |mtj at kohaaloha.com, | |nick at bywatersolutions.com, | |paul.poulain at biblibre.com, | |sandboxes at biblibre.com, | |victor at tuxayo.net | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 06:37:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 05:37:27 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #234 from Mason James --- Created attachment 114217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114217&action=edit Bug 6473: Test bug for Git-bz add test for debian/control -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 06:37:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 05:37:56 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114217|0 |1 is obsolete| | --- Comment #235 from Mason James --- Created attachment 114218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114218&action=edit Bug 6473: Test bug for Git-bz add test for debian/control -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 06:38:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 05:38:54 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114218|0 |1 is obsolete| | --- Comment #236 from Mason James --- Created attachment 114219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114219&action=edit Bug 6473: Test bug for Git-bz add test for debian/control -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 06:49:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 05:49:00 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114219|0 |1 is obsolete| | --- Comment #237 from Mason James --- Created attachment 114220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114220&action=edit Bug 6473: Test bug for Git-bz add test for debian/control -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 06:49:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 05:49:16 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114220|0 |1 is obsolete| | --- Comment #238 from Mason James --- Created attachment 114221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114221&action=edit Bug 6473: Test bug for Git-bz add test for debian/control -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 07:45:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 06:45:42 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #239 from Mason James --- Created attachment 114222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114222&action=edit buildbot 20.12.00-0 for stretch: update debian/control modified: debian/control -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 07:49:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 06:49:45 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114221|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 07:49:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 06:49:53 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114222|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 07:51:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 06:51:40 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #240 from Mason James --- Created attachment 114223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114223&action=edit Bug 27030: Add missing perldoc for Processing hold status to C4::Reserves Test plan: Look into diff and confirm the comment does make sense Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 07:52:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 06:52:17 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #241 from Mason James --- Created attachment 114224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114224&action=edit buildbot 20.12.00-0 for stretch: update debian/control modified: debian/control -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 13:51:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 12:51:45 +0000 Subject: [Koha-bugs] [Bug 27141] QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 --- Comment #1 from Katrin Fischer --- I think we should do the opposite - turn QueryWeightFields on and turn QueryAutoTruncate off. In my testing for a recent presentation I felt tihs to give much better and expected results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 13:54:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 12:54:19 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 --- Comment #9 from Katrin Fischer --- (In reply to Jonathan Druart from comment #8) > Pushed to master for 20.05, thanks to everybody involved! I think the script might need updating? :) 21.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 13:57:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 12:57:50 +0000 Subject: [Koha-bugs] [Bug 27150] Batch delete items broke. Returns "0 item(s) deleted" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27150 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 14:00:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 13:00:10 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi Jonathan, I believe this to be a duplicate of bug 21357 - maybe you could add your voice to that bug for a simplified solution (ignore ') *** This bug has been marked as a duplicate of bug 21357 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 14:00:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 13:00:10 +0000 Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field at ptfs-europe. | |com --- Comment #58 from Katrin Fischer --- *** Bug 27153 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 14:02:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 13:02:08 +0000 Subject: [Koha-bugs] [Bug 27159] Sorting A-Z Catalogue Incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27159 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- This is not a bug, but expected behaviour. Articles like A and The are ignored in sorting when they have been specified as non-sorting in the 245 indicators. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 23:14:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 22:14:15 +0000 Subject: [Koha-bugs] [Bug 27141] QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 --- Comment #2 from David Cook --- (In reply to Katrin Fischer from comment #1) > I think we should do the opposite - turn QueryWeightFields on and turn > QueryAutoTruncate off. > > In my testing for a recent presentation I felt tihs to give much better and > expected results. Personally, I hate the query mangling done by QueryWeightFields, but I think that you make a good point. Recently, I turned off QueryAutoTruncate and turned on QueryWeightFields to get a better search experience for a new Koha library. (I have also been thinking about creating a QuerySimplified or QueryCCL option to get rid of all the query mangling and instead do something more simple and straightforward.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 23:37:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 22:37:10 +0000 Subject: [Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 --- Comment #5 from David Cook --- (In reply to Nick Clemens from comment #4) > In these cases with restrictions there are no failures, just a race > condition: > # Remove any OVERDUES related debarment if the borrower has no > overdues > if ( $patron > && $patron->is_debarred > && ! $patron->has_overdues > && @{ GetDebarments({ borrowernumber => $borrowernumber, type => > 'OVERDUES' }) } > ) { > DelUniqueDebarment({ borrowernumber => $borrowernumber, type => > 'OVERDUES' }); > } > > When all the transactions hit at once they are getting conflicting > information and not removing the debarment, so all items renewed but > restrictions stay > Ok that's interesting. So the last 2 renewals for overdues will be happening around the same time, so $patron->has_overdues will be true for both. Yeah that's not good. Thanks for the clarification. > I filed bug 27152, but currently this is a bug affecting many sites and this > is a simple solution. There is a performance cost, but there will be with a > bulk endpoint too I would say that a bulk endpoint could actually have less of a performance cost, because with a bulk endpoint you could do less database I/O by fetching all the database data with 1 query. Although I guess with our use of DBIC we don't really do that as we currently prioritize convenience over performance. Anyway, food for thought. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 6 23:41:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 22:41:22 +0000 Subject: [Koha-bugs] [Bug 27141] QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 --- Comment #3 from Katrin Fischer --- Hm I think the "query mangling" is actually good in this case. I recently looked at the code and it does make sense to me what we are trying to do here - judging from results it also appears to work reasonably well. Do you have a specific issue with it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 00:05:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 23:05:22 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 --- Comment #23 from David Cook --- Thanks for the info, Nick. And yeah I think throwing an exception is a good immediate improvement. Looking at Bug 20086, I think that we're trying to do way too much in 1 database transaction. I've seen this on other systems with a lot of concurrent activity, and debugging these deadlocks is a struggle. The AddRenewal function is a bit of a mess in general... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 00:35:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 23:35:50 +0000 Subject: [Koha-bugs] [Bug 23207] Allow automatic checkin/return at end of circulation period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23207 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 00:49:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 06 Dec 2020 23:49:42 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #83 from David Cook --- (In reply to Jonathan Druart from comment #78) > t/db_dependent/Search.t is failing, can you have a look please? Is this still needed? And should it be on a separate bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 01:41:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 00:41:17 +0000 Subject: [Koha-bugs] [Bug 27141] QueryWeightFields should be 0 on new installs since QueryAutoTruncate is 1 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27141 --- Comment #4 from David Cook --- (In reply to Katrin Fischer from comment #3) > Hm I think the "query mangling" is actually good in this case. I recently > looked at the code and it does make sense to me what we are trying to do > here - judging from results it also appears to work reasonably well. > > Do you have a specific issue with it? I think that it's trying to be too smart for its own good. >From my perspective, the user should be able to build up their own query and get search results that actually reflect their query, rather than a mangled query. That being said, I am a power user, so maybe novice users would prefer the system to think for them. Maybe my other issues are actually about inconsistency and inefficiency in the query building in general, but... my latest buildQuery unit tests actually provide the start for improving the search code overall... maybe I'm just having a grump ;). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 01:57:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 00:57:16 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #17 from David Cook --- (In reply to Jonathan Druart from comment #16) > See the commit message, it does not work. It is what we are doing currently. > Without unsafe, DBIC does not accept RaiseError turned off. > > Have a look at DBIx::Class::Storage::DBI->_connect for more information. I've read through the commit messages and DBIx::Class::Storage::DBI->_connect but I still don't see why it's necessary. It sounds like perhaps more so an issue with populate_db.pl than Koha... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 02:02:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 01:02:15 +0000 Subject: [Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 --- Comment #7 from David Cook --- (In reply to Pablo AB from comment #6) > Why you like the most this one (except for the ABS identical to my first > suggestion), instead of your alternative con comment 1? I remember that at > the time your suggestion seems better. Option 1: SELECT MAX(ABS(barcode)) FROM items WHERE barcode REGEXP '^[0-9]+$'; This query won't generate any warnings, so that's good. But it's also fairly long and a little complex. Option 2: SELECT max(cast(barcode as unsigned)) from items; This query will show "Truncated incorrect..." warnings, but it's simpler/easier to read/maintain. -- In the end, it doesn't really matter too much I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 02:03:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 01:03:11 +0000 Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 --- Comment #41 from David Cook --- I haven't followed this change line by line, but does this mean that developers will no longer have to update kohastructure.sql? We'll just have to provide atomic updates? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 02:06:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 01:06:42 +0000 Subject: [Koha-bugs] [Bug 27151] SIP2 server doesn't handle broken connections which then kills SIP2 server In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27151 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 03:46:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 02:46:10 +0000 Subject: [Koha-bugs] [Bug 27160] New: Fatal error when ReservesMaxPickUpDelay is empty and item with hold is checked in Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27160 Bug ID: 27160 Summary: Fatal error when ReservesMaxPickUpDelay is empty and item with hold is checked in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If you don't have any value in ReservesMaxPickUpDelay and you try to check in an item that has a hold, you will get an Internal Server Error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 04:45:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 03:45:57 +0000 Subject: [Koha-bugs] [Bug 26947] kohastructure.sql should be updated for each release In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26947 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 05:32:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 04:32:25 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #242 from Mason James --- Created attachment 114225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114225&action=edit Subject: [PATCH] buildbot 20.12.00-0 for stretch: update debian/control Content-Type: text/plain; charset="utf-8" modified: debian/control xxx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 05:33:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 04:33:34 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114225|0 |1 is obsolete| | --- Comment #243 from Mason James --- Created attachment 114226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114226&action=edit Subject: [PATCH] buildbot 20.12.00-0 for stretch: update debian/control Content-Type: text/plain; charset="utf-8" modified: debian/control xxx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 05:59:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 04:59:48 +0000 Subject: [Koha-bugs] [Bug 27084] Cron Daemon Email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27084 Faiz Ahmed changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |20.05 --- Comment #11 from Faiz Ahmed --- Hello, I upgraded my Koha to the next stable version i.e. 20.05 But still facing the same issue. It's extremely annoying to receive this cron email in every 15 minutes or so.. Any help would be highly appreciated. Thanks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 06:05:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 05:05:58 +0000 Subject: [Koha-bugs] [Bug 27084] Cron Daemon Email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27084 --- Comment #12 from David Cook --- (In reply to Faiz Ahmed from comment #11) > Hello, > I upgraded my Koha to the next stable version i.e. 20.05 > But still facing the same issue. > > It's extremely annoying to receive this cron email in every 15 minutes or > so.. Any help would be highly appreciated. > > Thanks It seems unlikely that this issue would be persisting based on the current information. What emails are being processed every 15 minutes or so? Tracing back the specific emails may yield some clues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 06:06:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 05:06:51 +0000 Subject: [Koha-bugs] [Bug 27161] New: Base.pm complains about unitialized value Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 Bug ID: 27161 Summary: Base.pm complains about unitialized value Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: cornejo.alvaro at gmail.com QA Contact: testopia at bugs.koha-community.org I get several errors on Use of uninitialized value in subroutine entry at /usr/share/koha/lib/Koha/Plugins/Base.pm line 182. 177 sub get_metadata { 178 my ( $self, $args ) = @_; 179 180 #FIXME: Why another encoding issue? For metadata containing non latin characters. 181 my $metadata = $self->{metadata}; 182 utf8::decode($metadata->{$_}) for keys %$metadata; 183 return $metadata; 184 } Verifying that $metadata value is set before applying utf8::decode will avoid that log error 177 sub get_metadata { 178 my ( $self, $args ) = @_; 179 180 #FIXME: Why another encoding issue? For metadata containing non latin characters. 181 my $metadata = $self->{metadata}; 182 if ($metadata !~ "") { 183 utf8::decode($metadata->{$_}) for keys %$metadata; 184 } 185 return $metadata; 186 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 06:07:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 05:07:15 +0000 Subject: [Koha-bugs] [Bug 27161] Base.pm complains about unitialized value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 Alvaro Cornejo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cornejo.alvaro at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 06:44:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 05:44:54 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (19.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatic debian/control |Automatic debian/control |updates (stable/19.05.x) |updates (19.05.x) CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 06:45:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 05:45:12 +0000 Subject: [Koha-bugs] [Bug 20952] Automatic debian/control updates (17.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatic debian/control |Automatic debian/control |updates |updates (17.11.x) |(oldoldstable/17.11.x) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 06:46:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 05:46:55 +0000 Subject: [Koha-bugs] [Bug 27162] New: Automatic debian/control updates (19.11.x) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27162 Bug ID: 27162 Summary: Automatic debian/control updates (19.11.x) Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com QA Contact: testopia at bugs.koha-community.org CC: mtj at kohaaloha.com Automatic updates for debian/control in 19.11.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 06:47:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 05:47:08 +0000 Subject: [Koha-bugs] [Bug 27162] Automatic debian/control updates (19.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27162 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 06:47:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 05:47:34 +0000 Subject: [Koha-bugs] [Bug 17111] Automatic debian/control updates (18.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com Summary|Automatic debian/control |Automatic debian/control |updates (oldstable/18.05.x) |updates (18.05.x) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 06:48:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 05:48:02 +0000 Subject: [Koha-bugs] [Bug 20952] Automatic debian/control updates (17.11.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 06:48:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 05:48:46 +0000 Subject: [Koha-bugs] [Bug 17108] Automatic debian/control updates (19.05.x) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 08:20:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 07:20:44 +0000 Subject: [Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta at informaticsgloba | |l.com, | |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:02:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 08:02:47 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #18 from Timothy Alexis Vass --- (In reply to Timothy Alexis Vass from comment #17) > NOTE: This commit also fixes indentations. > You can use the -w option with git to ignore space differences. I removed the whitespace changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:04:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 08:04:16 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:06:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 08:06:33 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:07:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 08:07:54 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:08:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 08:08:12 +0000 Subject: [Koha-bugs] [Bug 27003] action_logs table error when adding an item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27003 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:16:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 08:16:23 +0000 Subject: [Koha-bugs] [Bug 27128] Follow-up to bug 25728 - Don't prefill av's code In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27128 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | --- Comment #5 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:17:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 08:17:46 +0000 Subject: [Koha-bugs] [Bug 26996] Elasticsearch: Multiprocess reindexing sometimes doesn't reindex all records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26996 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113482|0 |1 is obsolete| | --- Comment #3 from Björn Nylén --- Created attachment 114227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114227&action=edit Truncate commit size to make sure it's an integer - QA update New patch with suggested QA changes. Moved the truncation to a separeate line to make it more obvious. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:18:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 08:18:42 +0000 Subject: [Koha-bugs] [Bug 26996] Elasticsearch: Multiprocess reindexing sometimes doesn't reindex all records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26996 Björn Nylén changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:18:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 08:18:46 +0000 Subject: [Koha-bugs] [Bug 26976] When renewalsallowed is empty the UI is not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26976 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:28:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 08:28:34 +0000 Subject: [Koha-bugs] [Bug 27163] New: SIP2 stopped working Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27163 Bug ID: 27163 Summary: SIP2 stopped working Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: ujjwalguptax202 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com after enabling the sip using this cd /usr/share/koha/lib export PERL5LIB=/usr/share/koha/lib export KOHA_CONF=/etc/koha/sites/library/koha-conf.xml perl -IC4/SIP/ -MILS C4/SIP/SIPServer.pm /etc/koha/SIPconfig.xml after a while it stopped working and if again we use these command it will start but again it stopped whenever i reboot my system or few minutes wait any suggestion???? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:41:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 08:41:07 +0000 Subject: [Koha-bugs] [Bug 26336] Cannot import items if items ignored when staging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 09:44:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 08:44:00 +0000 Subject: [Koha-bugs] [Bug 16067] Koha::Cache, fastmmap caching system is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16067 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #14 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 RIP ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 10:01:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 09:01:02 +0000 Subject: [Koha-bugs] [Bug 27030] The new "Processing" hold status is missing in C4::Reserves module documentation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27030 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #5 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 10:14:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 09:14:08 +0000 Subject: [Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 --- Comment #5 from Fridolin Somers --- (In reply to Lucas Gass from comment #4) > Fridolin, > > I have encounter a problem while testing this patch. To recreate: > > 1. apply your patch > 2. try opac-password-recovery.pl without an email, I see the new error > message > 3. in the staff client add an email for the same patron > 4. try opac-password-recovery.pl again, it blows up with the error: > Invalid 'from' parameter: root at localhost at > /usr/share/perl5/Exception/Class/Base.pm line 88 I think you need to set a real email adress into preference 'KohaAdminEmailAddress'. You may test without my patch first Thanks a lot for testing :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 10:15:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 09:15:13 +0000 Subject: [Koha-bugs] [Bug 25900] Double quotes breaks search with Zebra and QueryWeightFields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 --- Comment #18 from Fridolin Somers --- (In reply to David Cook from comment #17) > (In reply to Fridolin Somers from comment #16) > > This change is harmless I'd say. > > It's harmless but the description is inaccurate. If you renamed this issue > to "QueryWeightFields creates unnecessary whitespace", then I would happily > test again and probably sign off. > > But it wouldn't be fixing any functional bug I think. Sur, good idea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 10:15:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 09:15:39 +0000 Subject: [Koha-bugs] [Bug 25900] QueryWeightFields creates unnecessary whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Double quotes breaks search |QueryWeightFields creates |with Zebra and |unnecessary whitespace |QueryWeightFields | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 10:19:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 09:19:18 +0000 Subject: [Koha-bugs] [Bug 25900] QueryWeightFields creates unnecessary whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 10:19:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 09:19:21 +0000 Subject: [Koha-bugs] [Bug 25900] QueryWeightFields creates unnecessary whitespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25900 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106432|0 |1 is obsolete| | --- Comment #19 from Fridolin Somers --- Created attachment 114228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114228&action=edit Bug 25900: trim spaces in search with Zebra and QueryWeightFields Search with Zebra and system preference QueryWeightFields on builds a query with surrounding double quotes : q=tree => q="tree". Therefore existing double quotes are replaced by a space : q="tree" => q=" tree ". Patch corrects by adding trim on operand after transforming quotes into spaces. Test plan : 1) Use Zebra searchengine and enable system preference QueryWeightFields 2) Go to advanced search 3) Search on two words from a title, surrounded by double quotes. Like "Order of the Phoenix" 4) Check you get same results with an without patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:09:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 10:09:24 +0000 Subject: [Koha-bugs] [Bug 27163] SIP2 stopped working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27163 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #1 from Joonas Kylmälä --- Do you have any clues why this might be, for example try to see sip-error.log or sip.log if there is any messages about any issues. We came across bug 27151 which sometimes kills/stops the sip2 server for us. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 11:52:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 10:52:58 +0000 Subject: [Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 --- Comment #6 from Björn Nylén --- Will this actually keep indexing after an error. The commit buffer and counter isn't reset in the catch block so would only keep filling the buffer and never commit the again. Didn't actually test but looks like it would act like that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 12:03:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 11:03:16 +0000 Subject: [Koha-bugs] [Bug 27163] SIP2 stopped working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27163 --- Comment #2 from Vihaan Gupta --- (In reply to Joonas Kylmälä from comment #1) > Do you have any clues why this might be, for example try to see > sip-error.log or sip.log if there is any messages about any issues. We came > across bug 27151 which sometimes kills/stops the sip2 server for us. no but when i check the status of sip it show running but but when i use sip tool to check it not be able to connect until i again repeat these process cd /usr/share/koha/lib export PERL5LIB=/usr/share/koha/lib export KOHA_CONF=/etc/koha/sites/library/koha-conf.xml perl -IC4/SIP/ -MILS C4/SIP/SIPServer.pm /etc/koha/SIPconfig.xml if i run these command its working fine for some time but after that same issue occured and when i check sip status for instance it shows running -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 12:09:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 11:09:45 +0000 Subject: [Koha-bugs] [Bug 27163] SIP2 stopped working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27163 --- Comment #3 from Joonas Kylmälä --- Ok, please figure out first why koha-sip --enable and koha-sip --start doesn't work – otherwise it is quite difficult to help if you have custom procedure to starting the server. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 12:33:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 11:33:33 +0000 Subject: [Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 --- Comment #7 from Nick Clemens --- Created attachment 114229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114229&action=edit Bug 26312: (follow-up) Reset buffers even if commit fails -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 12:34:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 11:34:09 +0000 Subject: [Koha-bugs] [Bug 26312] Add some error handling during Elasticsearch indexing In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26312 --- Comment #8 from Nick Clemens --- (In reply to Björn Nylén from comment #6) > Will this actually keep indexing after an error. The commit buffer and > counter isn't reset in the catch block so would only keep filling the buffer > and never commit the again. Didn't actually test but looks like it would act > like that. Thanks! You are right, I moved the resets out of the try/catch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 13:02:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 12:02:52 +0000 Subject: [Koha-bugs] [Bug 14417] Facet labels sorted incorrectly (OPAC) and inconsistently (OPAC vs Staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14417 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25701 CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger --- Is this fixed by bug 25701, or is the scope different? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 13:02:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 12:02:52 +0000 Subject: [Koha-bugs] [Bug 25701] Facets display in random order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25701 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14417 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 13:26:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 12:26:18 +0000 Subject: [Koha-bugs] [Bug 27163] SIP2 stopped working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27163 --- Comment #4 from Vihaan Gupta --- (In reply to Joonas Kylmälä from comment #3) > Ok, please figure out first why koha-sip --enable and koha-sip > --start doesn't work – otherwise it is quite difficult to help if > you have custom procedure to starting the server. koha-sip --start library not working thats why i use the manual way to start sip but it not possible to cause after a while it stopped working -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 13:32:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 12:32:09 +0000 Subject: [Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Fridolin Somers --- Sorry Bug 27149: Unit tests does not apply on current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 13:34:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 12:34:56 +0000 Subject: [Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 --- Comment #4 from Fridolin Somers --- Main patch works. I see no reason to strip itemnumber from item fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 13:47:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 12:47:05 +0000 Subject: [Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 13:47:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 12:47:08 +0000 Subject: [Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114155|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 114230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114230&action=edit Bug 27149: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 13:47:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 12:47:10 +0000 Subject: [Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114156|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 114231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114231&action=edit Bug 27149: Don't strip itemnumber when adding item status via Z3950Responder To test: 1 - sudo koha-z3950-responder --stop kohadev 2 - Run it manually: perl /kohadevbox/koha/misc/z3950_responder.pl -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 3 - Connect and search to verify itemnumber is in item records yaz-client localhost:2100 base biblios find shuffle show 1+1 4 - sudo koha-z3950-responder --stop kohadev 5 - Run it manually to add item status perl /kohadevbox/koha/misc/z3950_responder.pl --add-item-status k -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 6 - Connect and search, no itemnumber in records 7 - Apply patch 8 - Stop, restart all the things, and manually start server with item status again 9 - Connect and search, itemnumbers are included -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 13:53:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 12:53:30 +0000 Subject: [Koha-bugs] [Bug 14417] Facet labels sorted incorrectly (OPAC) and inconsistently (OPAC vs Staff) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14417 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Nick Clemens --- (In reply to Magnus Enger from comment #1) > Is this fixed by bug 25701, or is the scope different? I believe this is resolved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 13:59:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 12:59:51 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #330 from Joonas Kylmälä --- Currently adding permissions items_batchdel items_batchmod is required if one wants to include piece of JavaScript that will bring up confirmation box for the deletion of holdings records. This also depends on the StaffDetailItemSelection syspref. The librarian without those permissions can already delete holdings so these permissions should not be required to just bring up the confirmation box for deletion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 14:44:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 13:44:06 +0000 Subject: [Koha-bugs] [Bug 26996] Elasticsearch: Multiprocess reindexing sometimes doesn't reindex all records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26996 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 14:44:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 13:44:09 +0000 Subject: [Koha-bugs] [Bug 26996] Elasticsearch: Multiprocess reindexing sometimes doesn't reindex all records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26996 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114227|0 |1 is obsolete| | --- Comment #4 from Joonas Kylmälä --- Created attachment 114232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114232&action=edit Bug 26996: Convert Elasticsearch indexer commit buffer size to integer When multithreaded indexing is used, the commit size for children are spread out resulting in them being of type float. When records are processed and the commit counter decreased it may then never reach *exactly* 0. This means records are never commited. This patch makes sure the counter is an integer to avoid the problem. To test you must find a set of circumstances that causes the issue. For me: 1. Run: ./rebuild_elasticsearch -v -b -p 2 -c 400 2. Note that only one process is logging "Committing xxx records..." 3. Kill processes. 4. Apply patch. 5. Repeat 1 6. Note that both processes are logging "Committing xxx records..." Sponsored-by: Lund University Library Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 14:58:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 13:58:30 +0000 Subject: [Koha-bugs] [Bug 17485] Add Marc modification templates to z39.50 import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17485 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |aleisha at catalyst.net.nz CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 15:02:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 14:02:09 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 16:59:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 15:59:29 +0000 Subject: [Koha-bugs] [Bug 27164] New: Double quotes everywhere in item search CSV export Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 Bug ID: 27164 Summary: Double quotes everywhere in item search CSV export Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In item search CSV export, data cells are exported with double quotes. There should also be double quotes in header cells. Also some spaces can be removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:01:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:01:01 +0000 Subject: [Koha-bugs] [Bug 27164] Double quotes everywhere in item search CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:07:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:07:38 +0000 Subject: [Koha-bugs] [Bug 27164] Double quotes everywhere in item search CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:07:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:07:41 +0000 Subject: [Koha-bugs] [Bug 27164] Double quotes everywhere in item search CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 --- Comment #1 from Fridolin Somers --- Created attachment 114233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114233&action=edit Bug 27164: Double quotes everywhere in item search CSV export In item search CSV export, data cells are exported with double quotes. There should also be double quotes in header cells. Also some spaces can be removed. This may help to open the CSV with any table/calc software. Test plan : 1.0) Without patch 1.1) Perform an item search 1.2) Export as a CSV file and save the file locally 1.3) Open the file with a table/calc software 2.0) Apply patch 2.1) Perform same item search 2.2) Export as a CSV file and save the file locally 2.3) Open the file with a table/calc software 3.0) Compare files with diff/meld => you see only double quotes arround header cells and removal of space after coma 3.1) In table/calc software they should look the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:24:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:24:05 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #2 from Martin Renvoize --- Created attachment 114234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114234&action=edit Bug 27153: Default to apostrophe blind search Keyword searching in elasticsearch should be apostrophe blind; this patch updates the default configuration to filter apostrophe's. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:29:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:29:03 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #3 from Martin Renvoize --- In my understanding elisions and apostrophes are not equal and as such distinct bugs can/should be opened to handle the two cases. This case is for apostrophes only and leaves elisions, which appear to be more difficult to reach a consensus, to the other bug. As such, I don't think this is a duplicate at all.. I've uploaded Jonathans patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:29:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:29:08 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:29:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:29:46 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.field at ptfs-europe. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:40:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:40:05 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:40:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:40:17 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:40:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:40:28 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:44:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:44:34 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114161|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 114235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114235&action=edit Bug 27148: Fix bug on self registration when user category is hidden This patch fixes the bug when there is no patron category available for selection in self registration form. It uses PatronSelfRegistrationDefaultCategory to get patron's password length and strength. To test: 1. Do not apply this patch 2. Allow SeflRegistration, set PatronSelfRegistrationDefaultCategory to a valid patron category and finally add categorycode to PatronSelfRegistrationBorrowerUnwantedField 3. Go to opac and enter self registration form CHECK => There is no patron category available for selection => Password's info alert shows "Password must contain at least undefined characters" 4. Fill the form setting a password and send. CHECH => You get an exception saying "You must provide a patron's category to validate password's strength and length" 5. Apply this patch and restart_all 6. repeat steps 3 and 4 SUCCESS => Password's info alert message shows a number instead of "undefined" => Password's strength and length checks are working => If you change default category's lenght or strength parameter it get's reflected when you refresh the page => When you click send, patron is saved Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:44:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:44:59 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- Works as expected, no regressions found, passes QA scripts. Passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 7 17:46:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 07 Dec 2020 16:46:56 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114163|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 114236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114236&action=edit Bug 27124: JS error "select2Width is not defined" This patch changes the way select2.js checks for an existing value of the "select2Width" variable in order to avoid errors when it is undefined. To test, apply the patch and view various pages where the select2 plugin is used: - Basic MARC editor - Items edit - Batch item edit - Authority editor In each case check that the Select2 plugin works correctly to style fields like collection code and home library. On the basic MARC editor page these s should have a width that adjusts as the browser window changes. On other pages the width should be fixed. Check the browser console and confirm that there are no JavaScript errors. Update: Thanks to Julian for the suggested optimization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 12:55:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 11:55:55 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 --- Comment #11 from Owen Leonard --- (In reply to Julian Maurice from comment #9) > Do you think that the suggested solution in comment 4 is a better solution ? Yes. I was making an incorrect assumption about when the default had to be set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:06:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:06:12 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114281|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 114301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114301&action=edit Bug 27166: Unit tests Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:06:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:06:15 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114282|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 114302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114302&action=edit Bug 27166: Set destination_loc to item->homebranch In bug 21020 we used the issue to fetch the item and then the homebranch. This fails when the item is not issued. We fetch the item already, so we can use it directly To test: 1 - Have an item belonging to branch A 2 - Check it in via sip at branch B: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --item CHESS1 -l FPL -m checkin 3 - The read command is blank and there is a warn about uninitialized data 4 - Apply patch 5 - Restart sip server 6 - Check the item in at branch A using the sip cli emulator 7 - Check it in at branch B 8 - This time the checkin should succeed and the output msg should be included Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:07:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:07:00 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- This makes sense and also provides a minor performance boost (not double fetching the item). Tests pass, QA script passes... Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:07:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:07:09 +0000 Subject: [Koha-bugs] [Bug 27163] SIP2 stopped working In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27163 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Joonas Kylmälä --- Discussion has moved to bug 27169, marking this as duplicate. *** This bug has been marked as a duplicate of bug 27169 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:07:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:07:09 +0000 Subject: [Koha-bugs] [Bug 27169] sip2 not enable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27169 --- Comment #5 from Joonas Kylmälä --- *** Bug 27163 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:07:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:07:15 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:08:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:08:53 +0000 Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:08:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:08:57 +0000 Subject: [Koha-bugs] [Bug 21958] _check_valid_auth_link checks too many subfields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21958 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108182|0 |1 is obsolete| | --- Comment #14 from Nick Clemens --- Created attachment 114303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114303&action=edit Bug 21958: Fix bibliographic record field comparison with authority This makes the comparison between bibliographic field and authority field more robust and per subfield. This makes the comparison not consider the same e.g. the following fields: $a Test User $a Test $b User The actual issue cannot be as easily reproduced with the patches for bug 21826 applied, but here's a test plan anyway: 1. Make sure tests pass (especially t/db_dependent/AuthoritiesMarc*) 2. Make sure authority linking still works properly 3. Make sure authority and biblio frameworks allow subfield i 4. Make sure that even if you add subfield i to 700 in biblio, authority link is kept the same 5. Make sure that even if you add subfield i to the authority record, the authority link is kept the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:18:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:18:33 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:18:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:18:37 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114101|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 114304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114304&action=edit Bug 26397: [20.05.x] opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. This patch is specifically for Koha 20.05.x. The bug does not appear in master. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:19:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:19:23 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 --- Comment #6 from Owen Leonard --- (In reply to David Nind from comment #4) > Patch no longer applies 8-( Sorry I should have made it more clear, so I've modified the commit message: The patch is specifically for 20.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:24:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:24:44 +0000 Subject: [Koha-bugs] [Bug 27169] sip2 not enable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27169 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #6 from Joonas Kylmälä --- Based on the other duplicate bug report it looks like you might be using wrong configuration file with probably wrong connections details so the server might be running and working just fine but not in the way you expect because it is using different configuration. In the other bug report you used /etc/koha/SIPconfig.xml but the instance specific configs should be in /etc/koha/sites//SIPconfig.xml. You might have also firewall not setup correctly, using wrong IP address, etc. So unless there is evidence that the SIP2 server is having a bug then please let's keep the discussion on IRC or mailing list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:45:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:45:52 +0000 Subject: [Koha-bugs] [Bug 27158] software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27158 --- Comment #2 from Nishath Ahmed --- Created attachment 114305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114305&action=edit Koha-sys-info Dear Jonathan Druart , I tried everything and dropped a bug here. I have attached system information for your reference. Regards! Nishath -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:53:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:53:29 +0000 Subject: [Koha-bugs] [Bug 27158] software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27158 --- Comment #3 from Jonathan Druart --- Does the column virtualshelves.created_on exist in DB? % koha-mysql $INSTANCE MariaDB > desc virtualshelves; You should see: | created_on | datetime | NO | | NULL || -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 13:57:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 12:57:40 +0000 Subject: [Koha-bugs] [Bug 27189] New: Unable to delete patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27189 Bug ID: 27189 Summary: Unable to delete patron Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nishathahmed at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 114306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114306&action=edit Koha-anon-info Hi There! I couldn't delete patrons it says "Unable to delete patron that is set as AnonymousPatron This patron cannot be deleted while set as AnonymousPatron in the system preferences." I set an account with borrower-number (which is superlibrarian account and not meant for deletion) as well there on system preferences. Please check the attachment. But still no luck. Please advice. Regards! Nishath -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 14:00:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 13:00:22 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 --- Comment #8 from Caroline Cyr La Rose --- Your comment is to redo the patch completely. I was asking because it was already signed off and PQA as it is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 14:00:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 13:00:55 +0000 Subject: [Koha-bugs] [Bug 26597] Transfer information from guarantor when adding a guarantor to an existing patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26597 --- Comment #9 from Caroline Cyr La Rose --- Sorry, not PQA, I was mistaking it for another one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 14:12:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 13:12:01 +0000 Subject: [Koha-bugs] [Bug 27158] software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27158 --- Comment #4 from Nishath Ahmed --- Created attachment 114307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114307&action=edit Koha-shelves-info cgi-bin/koha/opac-shelves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 14:14:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 13:14:07 +0000 Subject: [Koha-bugs] [Bug 26516] Importing records with unexpected format of copyrightdate fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26516 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in| |19.11.13 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #10 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 14:19:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 13:19:55 +0000 Subject: [Koha-bugs] [Bug 27158] software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27158 --- Comment #5 from Jonathan Druart --- So you don't have the column. That's very weird, it has been added by 3.19.00.038, so a long time ago. >From which Koha version did you upgrade? You can try the two following queries, to add the missing column, but you should have seen an error during the upgrade. ALTER TABLE virtualshelves ADD COLUMN created_on DATETIME NOT NULL AFTER lastmodified; UPDATE virtualshelves SET created_on = lastmodified, lastmodified = lastmodified; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 14:20:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 13:20:25 +0000 Subject: [Koha-bugs] [Bug 27178] OPAC results and lists pages contain invalid attributes (xmlns:str="http://exslt.org/strings") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27178 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114298|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 114308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114308&action=edit Bug 27178: Add 'str' namespace to exclude-result-prefixes Some nodes in the generated HTML document contain the 'str' namespace. For instance, at the OPAC on the search result list, you can see: The solution is to add 'str' to exclude-result-prefixes. >From https://developer.mozilla.org/en-US/docs/Web/XSLT/Element/stylesheet """ Specifies any namespace used in this document that should not be sent to the output document. The list is whitespace separated. """ Test plan: 0. Don't apply this patch 1. Launch a search at the OPAC 2. Inspect the title link for the records => Note the 'xmlns:str' attribute on tag "a" 3. Apply this patch 4. restart_all 5. Repeat 1. and 2. => Note that the attribute is gone now. QA will check that no other occurrences is missing (note that one NORMARC xsl is missing it, but NORMARC is deprecated) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 14:20:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 13:20:41 +0000 Subject: [Koha-bugs] [Bug 27178] OPAC results and lists pages contain invalid attributes (xmlns:str="http://exslt.org/strings") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27178 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize --- Great work, well found Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 14:38:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 13:38:06 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 14:51:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 13:51:20 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron at biblibre.c | |om --- Comment #2 from Didier Gautheron --- Hi It's a known issue with datatables.js library. cf all regular expression in koha-tmpl/intranet-tmpl/lib/datatables/datatables.js The easiest workaround would be: disable excel export if not using US CurrencyFormat. Regards Didier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:04:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:04:12 +0000 Subject: [Koha-bugs] [Bug 26986] Second try to prevent Selenium's StaleElementReferenceException In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26986 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in| |19.11.13 --- Comment #8 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:05:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:05:33 +0000 Subject: [Koha-bugs] [Bug 15050] Nonpublic note searchable from OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15050 --- Comment #13 from Katrin Fischer --- This pops up as an issue at our libraries quite regularly. Has someone found a solution to this yet? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:07:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:07:51 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #1 from Jonathan Druart --- This is terrible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:12:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:12:07 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:12:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:12:10 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 --- Comment #2 from Jonathan Druart --- Created attachment 114309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114309&action=edit Bug 24398: Fix 500 when viewing a single news item at the OPAC Test plan: 0. Set the NewsAuthorDisplay preference to 'OPAC' or 'Both OPAC and staff client.' 1. Open the OPAC main page and click on an individual news item Without this patch you get an ugly 500 Template process failed: undef error - The method Koha::NewsItem->author_title is not covered by tests! With this patch applied you see the news with the author's info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:15:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:15:24 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14272 Severity|critical |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 [Bug 14272] Allow OPAC to show a single news entry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:15:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:15:24 +0000 Subject: [Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24398 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:19:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:19:14 +0000 Subject: [Koha-bugs] [Bug 26846] serial-collections page should select the expected and late serials automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26846 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:23:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:23:42 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood at ptfs-europ | |e.com --- Comment #5 from Andrew Isherwood --- Hi Emmi I tried to sign this off but ran into a few problems, sorry! 1. prove -v t/db_dependent/Hold.t fails with: t/db_dependent/Hold.t .. 1/34 found extra parameters: []# Looks like your test exited with 2 just after 1. t/db_dependent/Hold.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 33/34 subtests Test Summary Report ------------------- t/db_dependent/Hold.t (Wstat: 512 Tests: 1 Failed: 0) Non-zero exit status: 2 Parse errors: Bad plan. You planned 34 tests but ran 1. Files=1, Tests=1, 4 wallclock secs ( 0.04 usr 0.01 sys + 3.28 cusr 0.42 csys = 3.75 CPU) Result: FAIL 2. In your test plan, you say "Holds expiration date should be set according your settings", this doesn't appear to be happening. The expiry date is not being populated according to the value in the DefaultHoldExpirationdatePeriod syspref. Maybe I'm misunderstanding the test plan? You can see what I mean here: https://nimb.ws/Sw048R 3. In the video I manually selected a date and the hold was created, however, if I leave the date selection blank I receive an error page (the relevant part of which is here https://nimb.ws/pWzZNO), I note the error is the same as the one in the failing test. Sorry to report bad news! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:28:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:28:25 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart --- 1. Wouldn't it make sense to keep "login" instead of "username" in the koha-conf.xml? 2. You are adding a die in the ->connect method, is it really useful? If $stomp->connect fails we already get an exception. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:34:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:34:10 +0000 Subject: [Koha-bugs] [Bug 26944] Help link from automatic item modification by age should go to the relevant part of the manual In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26944 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:35:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:35:30 +0000 Subject: [Koha-bugs] [Bug 26337] Remove unused authorities script should skip merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26337 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:37:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:37:16 +0000 Subject: [Koha-bugs] [Bug 25313] Add optional skip_merge parameter to ModAuthority In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25313 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:53:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:53:07 +0000 Subject: [Koha-bugs] [Bug 25726] Holds to Pull made empty by pathological holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25726 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27166 CC| |nick at bywatersolutions.com --- Comment #15 from Nick Clemens --- possible cause on 27166 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:53:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:53:07 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25726 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:55:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:55:51 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:56:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:56:19 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 --- Comment #4 from Tomás Cohen Arazi --- Created attachment 114310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114310&action=edit Bug 27117: Only place_holds permission is needed to adjust pickup locations The GET /pickup_locations route is requesting the whole reserveforothers permission whereas only the subpermission place_holds is needed. Test plan: 0. Don't apply this patch 1. Set the subpermission place_holds but modify_holds_priority 2. Edit a hold and click the pickup library dropdown list 3. You get a JS alert and log displays GET /api/v1/app.pl/api/v1/holds/5/pickup_locations 403 Forbidden 4. Apply this patch 5. Reload the page, click the dropdown list, modify the pickup location and save => Success! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:56:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:56:46 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:57:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:57:41 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 --- Comment #5 from Tomás Cohen Arazi --- This works as expected (today), not sure what mistake I made yesterday. The QA script is happy, and the changes to the tests make sense (and they pass). Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 15:58:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 14:58:13 +0000 Subject: [Koha-bugs] [Bug 27165] Online Resource link displays as HTML in OPAC MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27165 --- Comment #2 from Owen Leonard --- I can confirm this in master too. Testing with a record that has 856u populated with a regular link, the MARC view shows HTML. An example from our catalog, currently at v19.11.08: https://search.myacpl.org/cgi-bin/koha/opac-MARCdetail.pl?biblionumber=239528 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 16:08:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 15:08:22 +0000 Subject: [Koha-bugs] [Bug 27165] Online Resource link displays as HTML in OPAC MARC view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27165 --- Comment #3 from Owen Leonard --- opac-MARCdetail.pl checks whether a subfield should be a link, and outputs HTML if it is. The template assumes that the subfield value *doesn't* contain HTML and uses the "html" filter on the variable. The template needs a check on whether the subfield is a link in order to selectively use the "$raw" filter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 16:25:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 15:25:37 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 16:25:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 15:25:41 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114067|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Created attachment 114311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114311&action=edit Bug 18729: Add PUT /holds/{hold_id}/pickup_priority Bug 18729: Fix return type -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 16:25:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 15:25:58 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #18 from Jonathan Druart --- Thanks Tomas! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 16:50:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 15:50:46 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 16:50:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 15:50:49 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114309|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 114312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114312&action=edit Bug 24398: Fix 500 when viewing a single news item at the OPAC Test plan: 0. Set the NewsAuthorDisplay preference to 'OPAC' or 'Both OPAC and staff client.' 1. Open the OPAC main page and click on an individual news item Without this patch you get an ugly 500 Template process failed: undef error - The method Koha::NewsItem->author_title is not covered by tests! With this patch applied you see the news with the author's info Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 16:55:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 15:55:10 +0000 Subject: [Koha-bugs] [Bug 27190] New: Debug REST API tests Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27190 Bug ID: 27190 Summary: Debug REST API tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org It can be tricky to debug REST API tests. You can get a "received 500 when 200 expected", but you don't have the error. There is one manual way to do it: $t->put_ok($url)->status_is(200)->json_is($expected_json)->or( sub { warn $t->tx->res->to_string }); But could we provide a generic way to add a diag in case Test::Mojo fails? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 16:55:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 15:55:10 +0000 Subject: [Koha-bugs] [Bug 25504] Wrong API spec breaks plack without meaningful error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25504 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27190 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 16:56:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 15:56:50 +0000 Subject: [Koha-bugs] [Bug 27190] Debug REST API tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27190 --- Comment #1 from Jonathan Druart --- Created attachment 114313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114313&action=edit Bug 27190: [DO NOT PUSH] example of failure Apply patches from 18729 to test this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 16:57:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 15:57:16 +0000 Subject: [Koha-bugs] [Bug 27190] Debug REST API tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27190 --- Comment #2 from Jonathan Druart --- Created attachment 114314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114314&action=edit Bug 27190: Test::Mojo - Always warn the error string on error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 16:58:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 15:58:29 +0000 Subject: [Koha-bugs] [Bug 27190] Debug REST API tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |jonathan.druart at bugs.koha-c | |ommunity.org CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com Status|NEW |In Discussion --- Comment #3 from Jonathan Druart --- That's pretty ugly, and we will certainly never push it. But at least I will remember next time I need it, hopefully! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:06:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:06:25 +0000 Subject: [Koha-bugs] [Bug 27191] New: Set focus for cursor to category code input box when creating new patron categories Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27191 Bug ID: 27191 Summary: Set focus for cursor to category code input box when creating new patron categories Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When adding a new patron category on categories.pl you have to click in the category code input box, which is a required field, so that you can enter text. It would be more efficient to set the focus for the cursor to always be in the category code input box so that you could just begin typing and eliminate an extra click. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:09:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:09:33 +0000 Subject: [Koha-bugs] [Bug 27192] New: Set focus for cursor to item type input box when creating new item types Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Bug ID: 27192 Summary: Set focus for cursor to item type input box when creating new item types Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When adding a new item type on itemtypes.pl you have to click in the item type input box, which is a required field, so that you can enter text. It would be more efficient to set the focus for the cursor to always be in the item type input box so that you could just begin typing and eliminate an extra click. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:15:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:15:16 +0000 Subject: [Koha-bugs] [Bug 27193] New: Set focus for cursor to patron attribute type code input box when creating new patron attributes Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Bug ID: 27193 Summary: Set focus for cursor to patron attribute type code input box when creating new patron attributes Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When adding a new patron attribute type on patron-attr-types.pl you have to click in the patron attribute type code input box, which is a required field, so that you can enter text. It would be more efficient to set the focus for the cursor to always be in the patron attribute type code input box so that you could just begin typing and eliminate an extra click. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:18:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:18:00 +0000 Subject: [Koha-bugs] [Bug 27194] New: Using Batch Patron Modification from Reporting Module is not working correctly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27194 Bug ID: 27194 Summary: Using Batch Patron Modification from Reporting Module is not working correctly Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Using Batch Patron Modification from the Reporting Module is not working correctly Steps: 1. Create a report where you query borrower information including cardnumber. 2. Click the option to use batch operations, choosing Batch Patron Modification. 3. Get an error "CardNumber not found" because Koha has actually combined the values of all the patrons in the report into one card number instead of separate ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:18:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:18:21 +0000 Subject: [Koha-bugs] [Bug 27194] Using Batch Patron Modification from Reporting Module is not working correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27194 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:18:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:18:26 +0000 Subject: [Koha-bugs] [Bug 27195] New: Set focus for cursor to city input box when creating new cities Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Bug ID: 27195 Summary: Set focus for cursor to city input box when creating new cities Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When adding a new city on cities.pl you have to click in the city input box, which is a required field, so that you can enter text. It would be more efficient to set the focus for the cursor to always be in the city input box so that you could just begin typing and eliminate an extra click. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:21:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:21:17 +0000 Subject: [Koha-bugs] [Bug 27158] software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27158 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org Component|OPAC |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:30:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:30:17 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #6 from Fridolin Somers --- (In reply to Katrin Fischer from comment #4) > I don't mind a simple solution, but can you explain the difference? Elision removes the text : l'europe = europe This apostrophe filter creates : l'europe = leurope Wrong in french but surely ranking will bet better for the exact match. I have to test combined with ellision. But : Maybe it is bad for authorities : "Pierre d'Anjou" and Pierre Danjou". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:33:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:33:04 +0000 Subject: [Koha-bugs] [Bug 27164] Fix item search CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114262|0 |1 is obsolete| | --- Comment #11 from Fridolin Somers --- Created attachment 114315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114315&action=edit Bug 27164: Fix item search CSV export In item search CSV export, data cells are exported with double quotes. There should also be double quotes in header cells. Also some spaces can be removed. Delimiter must be from system preference 'delimiter'. TT filter must be $raw not html, only double quotes must be espaped by duplication of it. This may help to open the CSV with any table/calc software. Test plan : 1.0) Create a record with title : Laurel & "Hardy" 1.2) Create an item on this record 2.0) Without patch 2.1) Perform an item search on title 'Laurel' 2.2) Export as a CSV file and save the file locally 2.3) Open the file with a table/calc software 3.0) Apply patch 3.1) Perform same item search 3.2) Export as a CSV file and save the file locally 3.3) Open the file with a table/calc software 4.0) Compare files with diff/meld => you see double quotes arround header cells and removal of space after coma 4.1) Check that delimiter is from system preference 'delimiter' 4.2) In table/calc software they should look the same -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:34:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:34:37 +0000 Subject: [Koha-bugs] [Bug 27164] Fix item search CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Fridolin Somers --- My bad ;) Test plan fixed : 4.0) Compare files with diff/meld => you see double quotes arround header cells -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:34:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:34:48 +0000 Subject: [Koha-bugs] [Bug 26854] stage-marc-import.pl does not properly fork In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26854 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in| |19.11.13 --- Comment #30 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:40:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:40:19 +0000 Subject: [Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #22 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, shouldn't affect it then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:40:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:40:20 +0000 Subject: [Koha-bugs] [Bug 27027] Typo: has successfully been modified.. %s In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27027 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:57:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:57:49 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #51 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:58:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:58:13 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:58:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:58:13 +0000 Subject: [Koha-bugs] [Bug 24483] When batch deleting patrons, report who was not deleted and why In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24483 Bug 24483 depends on bug 14708, which changed state. Bug 14708 Summary: The patron set as the anonymous patron should not be deletable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:58:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:58:14 +0000 Subject: [Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984 Bug 26984 depends on bug 14708, which changed state. Bug 14708 Summary: The patron set as the anonymous patron should not be deletable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 17:58:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 16:58:14 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Bug 27144 depends on bug 14708, which changed state. Bug 14708 Summary: The patron set as the anonymous patron should not be deletable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 18:00:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 17:00:38 +0000 Subject: [Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #21 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 18:00:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 17:00:43 +0000 Subject: [Koha-bugs] [Bug 26984] Tests are failing if AnonymousPatron is configured In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 18:00:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 17:00:44 +0000 Subject: [Koha-bugs] [Bug 27062] pickup_location tests don't deal correctly with existing libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Bug 27062 depends on bug 26984, which changed state. Bug 26984 Summary: Tests are failing if AnonymousPatron is configured https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26984 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 18:03:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 17:03:49 +0000 Subject: [Koha-bugs] [Bug 27007] GetMarcSubfieldStructure called with "unsafe" in tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27007 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 18:18:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 17:18:38 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #21 from Owen Leonard --- (In reply to David Cook from comment #18) > when other projects have already sorted out internationalization > more gracefully. If you're referring to the question of syntax, other projects I've seen do something similar. For instance in Drupal: Translatable strings are wrapped in the t() function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 19:38:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 18:38:53 +0000 Subject: [Koha-bugs] [Bug 26694] Set focus for cursor to search input box on guarantor_search.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26694 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27191 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 19:38:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 18:38:53 +0000 Subject: [Koha-bugs] [Bug 27191] Set focus for cursor to category code input box when creating new patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27191 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|System Administration |Templates Version|20.05 |master Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26694 Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 19:40:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 18:40:19 +0000 Subject: [Koha-bugs] [Bug 27192] Set focus for cursor to item type input box when creating new item types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27192 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|System Administration |Templates Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 19:40:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 18:40:20 +0000 Subject: [Koha-bugs] [Bug 27193] Set focus for cursor to patron attribute type code input box when creating new patron attributes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Component|System Administration |Templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 19:40:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 18:40:20 +0000 Subject: [Koha-bugs] [Bug 27195] Set focus for cursor to city input box when creating new cities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27195 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Component|System Administration |Templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 19:43:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 18:43:24 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #19 from Tomás Cohen Arazi --- Hi, I'd like to mention that: - The idea of having a route to change the pickup location *only*, was meant so we could have a more granular permission set. So I expect this route to require something like "reserveforothers": "modify_pickup_location". That permission should be set on an atomicupdate to all users having place_holds, as per bug 27117. - I liked the idea of calling them 'pickup locations' instead of the already used 'pickup_library' (see the hold objects definition). I like the fact that we prepare for some future in which there could be other pickup locations (shelves? special lockers for sanitized materials on this new world?). With this in mind, I have two other comments to make: - The PUT verb is accepting (and returning) a string, that actually represents what we already call pickup_library_id, but named generically 'pickup location'. I suggest we drop this and in turn expect a JSON object, with a 'pickup_library_id' attribute, replicating the already used terminology. It will also allow us to add new options for the future. - I regret not proposing this before, but we should really have a class abstracting pickup locations, that could initially just be a wrapper for libraries, but with a ->to_api method that makes it return the pickup_library_id and the name. If we need more things, we can solve that through embedding (e.g. embed the library object altogether). This will allow us to have simpler routes for dropdowns (right now we should take care of 'private' attributes for such dropdowns in the OPAC, for example). About this last comment, I haven't polished the idea. But the main message is 'do not put any design constraint ourselves at this point'. And I'm willing to have the full discussion when appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 19:55:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 18:55:57 +0000 Subject: [Koha-bugs] [Bug 27196] New: Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Bug ID: 27196 Summary: Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com The problem occurs when we find a hold during SIP checkin - we check the message form AddReturn for the hold value - but for a waiting hold at wrong location the hold has been reverted and, in the case of a title level hold, has no itemnumber We partially succeed in setting the hold to transit and leave the hold in limbo This is due to passing $messages->{ResFound}->{itemnumber} to ModReserveAffect rather than $item->itemnumber which we have available To recreate: 1 - Place a next available hold for delivery at library A 2 - Check the item in at library A to set it waiting 3 - Check the item in via SIP at library B perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --item BARCODE -l FPL -m checkin 4 - The SIP emulator dies: Use of uninitialized value $data in concatenation (.) or string at misc/sip_cli_emulator.pl line 344, chunk 1. READ: 5 - Check the hold in the db: SELECT * FROM reserves WHERE itemnumber IS NULL and found IS NOT NULL; 5 - Try to load the biblio - ISE Can't call method holdingbranch on an undefined object -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 20:00:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 19:00:29 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21020, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27166 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 20:00:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 19:00:29 +0000 Subject: [Koha-bugs] [Bug 21020] Return branch not set for transfer when using SIP In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21020 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27196 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 20:00:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 19:00:29 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27196 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 20:02:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 19:02:37 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #1 from Nick Clemens --- Internal server error mentioned is: Can't call method "holdingbranch" on an undefined value at /kohadevbox/koha/reserve/request.pl line 654 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 20:30:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 19:30:20 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 20:30:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 19:30:27 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #55 from Agustín Moyano --- Created attachment 114316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114316&action=edit Bug 18532: (follow-up) Fix notice message, add notice to all installer languages and fix preference message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 20:39:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 19:39:23 +0000 Subject: [Koha-bugs] [Bug 12643] Emailing cart should send more details view instead of simple view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12643 Patrick Robitaille changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 21:18:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 20:18:42 +0000 Subject: [Koha-bugs] [Bug 11443] Refactoring code sending basket from OPAC/intra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11443 --- Comment #4 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 21:20:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 20:20:06 +0000 Subject: [Koha-bugs] [Bug 27197] New: Empty information in libraries table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27197 Bug ID: 27197 Summary: Empty information in libraries table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I added an email address to a library and it caused the display to display everything even if this particular library had no information. (Sorry, I can't find a way to explain it, see screen capture...) To replicate : 1- Go to Administration > Libraries 2- Edit a library 3- Enter an email address (the library name and address line 1 were already filled in my db) 4- Save 5- See table, it's all stretched with empty information -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 21:20:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 20:20:28 +0000 Subject: [Koha-bugs] [Bug 27197] Empty information in libraries table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27197 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 114317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114317&action=edit Libraries table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 21:22:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 20:22:41 +0000 Subject: [Koha-bugs] [Bug 27197] Empty information in libraries table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27197 --- Comment #2 from Caroline Cyr La Rose --- Created attachment 114318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114318&action=edit In comparison, the libraries table with the same information in 20.05.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 22:20:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 21:20:54 +0000 Subject: [Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | Status|Pushed to master |Pushed to stable --- Comment #17 from Andrew Fuerste-Henry --- backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 22:21:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 21:21:01 +0000 Subject: [Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 22:22:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 21:22:21 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01, 20.05.07 released in| | --- Comment #7 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 22:30:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 21:30:04 +0000 Subject: [Koha-bugs] [Bug 26903] Authority records not being indexed in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | --- Comment #11 from Andrew Fuerste-Henry --- backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 22:30:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 21:30:10 +0000 Subject: [Koha-bugs] [Bug 26903] Authority records not being indexed in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 22:41:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 21:41:24 +0000 Subject: [Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | --- Comment #7 from Andrew Fuerste-Henry --- Decided to backport this after all. It's not strictly dependent on 26172, applies fine without it. Backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 22:41:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 21:41:30 +0000 Subject: [Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 22:42:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 21:42:34 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #12 from Victor Grousset/tuxayo --- I tried even though I don't know well these places ^^" > - Basic MARC editor Is it cataloguing/addbiblio.pl ? Because I don't have the JS error before applying the patch. And I don't field a field that look like a Select2. > - Authority editor Which field? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 22:49:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 21:49:29 +0000 Subject: [Koha-bugs] [Bug 25514] REST/Plugin/Objects.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |andrew at bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | --- Comment #13 from Andrew Fuerste-Henry --- Backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 22:49:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 21:49:35 +0000 Subject: [Koha-bugs] [Bug 25514] REST/Plugin/Objects.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 22:56:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 21:56:07 +0000 Subject: [Koha-bugs] [Bug 27062] pickup_location tests don't deal correctly with existing libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05, please rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 23:04:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 22:04:05 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | CC| |andrew at bywatersolutions.com --- Comment #54 from Andrew Fuerste-Henry --- backported to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 23:04:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 22:04:11 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 23:12:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 22:12:20 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |andrew at bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | --- Comment #32 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 23:12:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 22:12:30 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 10 23:19:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 10 Dec 2020 22:19:06 +0000 Subject: [Koha-bugs] [Bug 26922] SendAlerts does not correctly handle error on sending emails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26922 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #17 from Andrew Fuerste-Henry --- Missing dependencies, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 01:23:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 00:23:04 +0000 Subject: [Koha-bugs] [Bug 24826] Use of uninitialized value $mail{"Cc"} in substitution (s///) at /usr/share/perl5/Mail/Sendmail.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24826 --- Comment #11 from David Cook --- *** Bug 27084 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 01:23:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 00:23:04 +0000 Subject: [Koha-bugs] [Bug 27084] Cron Daemon Email In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27084 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Version|20.05 |19.05 Status|REOPENED |RESOLVED --- Comment #15 from David Cook --- (In reply to Faiz Ahmed from comment #13) > > Any clue would be extremely helpful for me, as it is extremely annoying to > have my inbox full with these email every morning. > If you followed our advice and still have this problem, then you've failed to upgrade your Koha properly. My suggestion would be to seek paid support (https://koha-community.org/support/paid-support/), since this bug has already been fixed in Bug 24826, as Jonathan noted in November. I'm marking this bug report as a duplicate, since there's no evidence that there's a problem in an up-to-date Koha. *** This bug has been marked as a duplicate of bug 24826 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 01:27:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 00:27:53 +0000 Subject: [Koha-bugs] [Bug 27160] Fatal error when ReservesMaxPickUpDelay is empty and item with hold is checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27160 --- Comment #6 from David Cook --- (In reply to Jonathan Druart from comment #4) > In which situation ReservesMaxPickUpDelay got removed entirely from the DB? A library had applied Bug 8367 to a customized production instance. The patches for that bug removed ReservesMaxPickUpDelay. They then exported their database and tried to load it into a new non-customized Koha 19.11.x instance, and that's where they encountered the issue. I will admit that it's an extreme edge case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 01:29:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 00:29:41 +0000 Subject: [Koha-bugs] [Bug 27160] Fatal error when ReservesMaxPickUpDelay is empty and item with hold is checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27160 --- Comment #7 from David Cook --- (In reply to Jonathan Druart from comment #5) > Created attachment 114296 [details] [review] > Bug 27160: Prevent 500 when checking an item in if ReservesMaxPickUpDelay > has been deleted > > We could default to 0 if the syspref does not exist. > However I don't think we should deal with that kind of issue, sysprefs > must be in DB. > The default in sysprefs.sql is 7, so we might prefer that over 0. I'm not sure that we should deal with this kind of issue either. As you say, sysprefs must be in the database. I'd probably be fine marking this as invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 01:29:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 00:29:50 +0000 Subject: [Koha-bugs] [Bug 27160] Fatal error when ReservesMaxPickUpDelay is empty and item with hold is checked in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27160 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8367 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 01:29:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 00:29:50 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27160 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 01:35:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 00:35:42 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 --- Comment #8 from David Cook --- (In reply to Jonathan Druart from comment #7) > 1. Wouldn't it make sense to keep "login" instead of "username" in the > koha-conf.xml? > I don't think so, since "username" is more standard than "login". It correlates better with the RabbitMQ documentation for instance (https://www.rabbitmq.com/access-control.html), so I think sysadmins and such would find username more user-friendly. > 2. You are adding a die in the ->connect method, is it really useful? > If $stomp->connect fails we already get an exception. I am very sure that $stomp->connect does not raise an exception when it fails without my patch. Without my patch, when would you get that exception? When it tries to subscribe? if that's the case, I think that's raising an exception too late. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 01:46:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 00:46:34 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #22 from David Cook --- (In reply to Owen Leonard from comment #21) > If you're referring to the question of syntax, other projects I've seen do > something similar. For instance in Drupal: > > > > Translatable strings are wrapped in the t() function. Drupal is an old project as well, and that example looks worrying. Based on https://en.wikipedia.org/wiki/Drupal#Themes, it looks like that example must be one of those "hard-coded PHP" templates. I wonder what they do in Drupal 8+ with Twig. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 01:53:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 00:53:08 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #23 from David Cook --- (In reply to Jonathan Druart from comment #19) > (In reply to David Cook from comment #18) > > Overall, I'll do whatever other people decide needs to be done, but I just > > worry that we're trying to re-invent the wheel sometimes and do things a > > harder way, when other projects have already sorted out internationalization > > more gracefully. > > How could we do that better? Do you have any suggestions? Suggestion 1: Referring back to https://developer.atlassian.com/server/framework/atlassian-sdk/pluralising-internationalisation-strings/, I think that we could do easy things like "Simplify the Message into a Plural-Independent Phrase". Suggestion 2: Use a token based i18n scheme like Java (which has a huge history in internationalization as it was the origin of ICU): https://docs.oracle.com/javase/tutorial/i18n/intro/steps.html Suggestion 3: Look at what others have done in Perl: https://metacpan.org/pod/Catalyst::Plugin::I18N https://metacpan.org/pod/Mojolicious::Plugin::I18N -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 01:59:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 00:59:53 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #24 from David Cook --- (In reply to David Cook from comment #22) > (In reply to Owen Leonard from comment #21) > > If you're referring to the question of syntax, other projects I've seen do > > something similar. For instance in Drupal: > > > > > > > > Translatable strings are wrapped in the t() function. > > Drupal is an old project as well, and that example looks worrying. Based on > https://en.wikipedia.org/wiki/Drupal#Themes, it looks like that example must > be one of those "hard-coded PHP" templates. I wonder what they do in Drupal > 8+ with Twig. Admittedly, https://metacpan.org/pod/Catalyst::Plugin::I18N uses a similar method using l() instead of t(). I suppose I wouldn't mind t() that much (although the Java way of doing it is still better I think) if that were the only macro we were required to use, but Bug 26392 introduces t(), tx(), tnx(), txn(), tp(), tpx(), tnp(), tnpx(). In my opinion, it's a bit absurd to expect developers to use 8 different macros which look almost exactly the same. I think that it'll make front-end developments take 10x* as long, as QA will constantly need to be telling people to re-do their templates. But I could be wrong. Maybe we'll all get used to the 8 different macros. I was going to say that I'll probably just stop contributing template changes to Koha, but I guess I'm on the QA team these days, so I should probably memorize them. *arbitrary order of magnitude -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 02:03:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 01:03:50 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #25 from David Cook --- Regarding the Java method, look at "Fetch the Text from the ResourceBundle" at https://docs.oracle.com/javase/tutorial/i18n/intro/steps.html. In my mind, we'd fetch the relevant translated string using a msgId in the Perl, and then we'd pass the translated string via a variable to the template. I think it would make templates look much cleaner and I think that it would make it easier to handle translations on the backend too. It could also potentially allow plugins to override the output to the template, but that's a whole other thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 02:05:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 01:05:14 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #26 from David Cook --- However, I defer to those people who actually *do* the translation work. I am not pretending that I know what is best. These are just ideas I have encountered in my other non-Koha projects, and none of those projects support as many translations/translators as Koha. So feel free to tell me to shut up ;). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 03:02:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 02:02:39 +0000 Subject: [Koha-bugs] [Bug 27175] Jenkins instance exposed to public In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27175 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- I don't think that this is a genuine issue. If there is a documented security vulnerability, it should be reported as a security bug instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 03:26:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 02:26:46 +0000 Subject: [Koha-bugs] [Bug 27161] Base.pm complains about unitialized value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 Alvaro Cornejo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |cornejo.alvaro at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 05:23:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 04:23:37 +0000 Subject: [Koha-bugs] [Bug 27198] New: Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 Bug ID: 27198 Summary: Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au ./debian/templates/marc21-retrieval-info-auth-dom.xml is out-dated and should be synchronized with ./etc/zebradb/retrieval-info-auth-dom.xml The main issue is that the XML retrieval syntax is wrong which prevents a person from using the Zebra special retrieval elements documented at https://software.indexdata.com/zebra/doc/special-retrieval.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 05:23:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 04:23:46 +0000 Subject: [Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 05:42:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 04:42:21 +0000 Subject: [Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 --- Comment #1 from David Cook --- Before patch: root at kohadevbox:koha(bug27198)$ yaz-client unix:/var/run/koha/kohadev/authoritysocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.000754 Z> base authorities Z> format xml Z> elements zebra::snippet Z> find e Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 21, setno 1 SearchResult-1: term=e cnt=21 records returned: 0 Elapsed: 0.002167 Z> show 1 Sent presentRequest (1+1). Diagnostic message(s) from database: [25] Specified element set name not valid for specified database -- v2 addinfo 'zebra::snippet' nextResultSetPosition = 2 Elapsed: 0.000218 Z> exit See you later, alligator. After patch: root at kohadevbox:koha(bug27198)$ yaz-client unix:/var/run/koha/kohadev/authoritysocket Connecting...OK. Sent initrequest. Connection accepted by v3 target. ID : 81 Name : Zebra Information Server/GFS/YAZ Version: 4.2.30 98864b44c654645bc16b2c54f822dc2e45a93031 Options: search present delSet triggerResourceCtrl scan sort extendedServices namedResultSets Elapsed: 0.000840 Z> base authorities Z> format xml Z> elements zebra::snippet Z> find e Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 21, setno 1 SearchResult-1: term=e cnt=21 records returned: 0 Elapsed: 0.002212 Z> show 1 Sent presentRequest (1+1). Records: 1 Record type: XML Gontarski, S. E nextResultSetPosition = 2 Elapsed: 0.013929 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 05:44:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 04:44:29 +0000 Subject: [Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 05:44:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 04:44:31 +0000 Subject: [Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 --- Comment #2 from David Cook --- Created attachment 114319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114319&action=edit Bug 27198: Fix syntax in marc21-retrieval-info-auth-dom.xml This patch fixes the syntax in marc21-retrieval-info-auth-dom.xml, so that one can use the Zebra special retrieval elements documented at https://software.indexdata.com/zebra/doc/special-retrieval.html These are very useful when troubleshooting issues with authority records in Zebra. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 08:15:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 07:15:59 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #20 from Timothy Alexis Vass --- (In reply to Joonas Kylmälä from comment #19) > Hi, > > - can you explain why only RETURNED fees? It would probably good to have > this explanation in the help documentation too. Some other fees that might > need to be removed also could be RENEWED and LOST? Please see > installer/data/mysql/mandatory/account_debit_types.sql, although it doesn't > contain every type of fee Koha generates currently. Statute-barred is a legal term. It is proper to say: "The fees have become statute-barred." According to Swedish statutes "perussäännöt", fees for library material are forbidden to claim after 3 years if the material has been returned. They are thus "statute-barred" as in "blocked by the fundamental rules of law". In the other situations "Renewed" and "Lost", it is different. Then the debt has been handed over to "Kronofogdemyndigheten", which is the Swedish Enforcement Agency. All 60+ Swedish libraries using Koha are required by Swedish law to remove statute-barred fees. Very likely, something similar will be required in some of the other 1000+ (?) libraries using Koha around our planet. > - Depending on your answer to the above question, would it make sense to > make the name of this option something more generic, like --unpaid-fees? The only thing that makes sense is to call it --statute-barred-fees because that is exactly what it is. They are not --unpaid-fees, they are not --expired-fees, they are not --old-fees, they are fees that have been barred according to ruling statutes. > - The commit title is still too long, see comment #4. Thank you. > - The code is now not in a function, i.e. cannot be tested. Would something > like Koha::Account::Lines::statute_barred (depending on the scope of this > function maybe a different name) sound good to you? Then you can call > ->delete or ->count on those and the code will look super cool in the > script, wouldn't it? :) Easy to maintain, simple code is preferred. I would suggest removing all this insane complexity and do database maintenance in the database, such as: CREATE EVENT cleanup_statute_barred_fees ON SCHEDULE EVERY 1 DAY DO DELETE FROM accountlines WHERE date < date_sub(curdate(), INTERVAL 1095 DAY) AND status = 'RETURNED' AND amountoutstanding > 0 Quite seriously, if you want to make it redundnantly complex because you find that interesting, you are free to make it happen. If your purpose here on the planet is to make yourself busy in other's efforts and to waste time, I advice you to take some time to think about how you can be a beneficial force for our commonwealth and coexistence here on Earth. > - The whitespace changes would still be nice to have, just in a separate > patch. Tip: add it as last in the series so any rebase conflicts will be > easier to resolve when you only need to redo the whitespace patch and not > also the feature patch. I can add them as another patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 09:06:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 08:06:15 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #27 from Julian Maurice --- (In reply to David Cook from comment #22) > Drupal is an old project as well, and that example looks worrying. Based on > https://en.wikipedia.org/wiki/Drupal#Themes, it looks like that example must > be one of those "hard-coded PHP" templates. I wonder what they do in Drupal > 8+ with Twig. They still do the same: use t() and formatPlural(). Context and variables to substitute are passed as optional arguments (In reply to David Cook from comment #23) > Suggestion 1: > Referring back to > https://developer.atlassian.com/server/framework/atlassian-sdk/pluralising- > internationalisation-strings/, I think that we could do easy things like > "Simplify the Message into a Plural-Independent Phrase". Yep, we can do that. No need to change the i18n framework for that. And we can do things differently too if needed, which is not a bad thing IMO. (In reply to David Cook from comment #24) > Admittedly, https://metacpan.org/pod/Catalyst::Plugin::I18N uses a similar > method using l() instead of t(). > > I suppose I wouldn't mind t() that much (although the Java way of doing it > is still better I think) if that were the only macro we were required to > use, but Bug 26392 introduces t(), tx(), tnx(), txn(), tp(), tpx(), tnp(), > tnpx(). > > In my opinion, it's a bit absurd to expect developers to use 8 different > macros which look almost exactly the same. If we can't expect developers to use 8 functions, what can we expect from them ? We can probably reduce the number of functions to 2: t and tn, and transform the other ones into optional arguments of these 2 functions (the same as drupal). But developers would now have to remember the name of the options. (And the parser which extracts translatable strings would have to be modified too) (In reply to David Cook from comment #25) > Regarding the Java method, look at "Fetch the Text from the ResourceBundle" > at https://docs.oracle.com/javase/tutorial/i18n/intro/steps.html. > > In my mind, we'd fetch the relevant translated string using a msgId in the > Perl, and then we'd pass the translated string via a variable to the > template. > > I think it would make templates look much cleaner and I think that it would > make it easier to handle translations on the backend too. > > It could also potentially allow plugins to override the output to the > template, but that's a whole other thing. I really don't see how what you're describing is a better solution than what we already have. This is looking worse actually. Correct me if I'm wrong but are you're suggesting that [% t('Hello, World!') %] should be replaced by $template->param('hello_world_str' => fetch('hello_world_str')) in Perl script and [% hello_world_str %] in template ? I don't find that very clean. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 09:08:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 08:08:47 +0000 Subject: [Koha-bugs] [Bug 26814] Add onsite_checkout to circulation rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26814 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi Status|Needs Signoff |Patch doesn't apply --- Comment #28 from Joonas Kylmälä --- Doesn't apply anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 09:13:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 08:13:55 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #9 from Jonathan Druart --- There is "Failed to connect: Error connecting to localhost:61613: Cannot assign requested address at /usr/share/perl5/Net/Stomp.pm line 27.; giving up at /usr/share/perl5/Net/Stomp.pm line 27" that is raised by the constructor. So you are right, not by $stomp->connect but already by our Koha::BackgroundJob->connect. It hasn't been advertised by the commit message, I think it need discussion and tests are missing. Can we move this part to its own bug report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 09:31:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 08:31:45 +0000 Subject: [Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 09:31:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 08:31:48 +0000 Subject: [Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114230|0 |1 is obsolete| | --- Comment #7 from Fridolin Somers --- Created attachment 114320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114320&action=edit Bug 27149: Unit tests Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 09:32:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 08:32:02 +0000 Subject: [Koha-bugs] [Bug 27149] Z3950Responder removes itemnumber when adding item statuses In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27149 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114231|0 |1 is obsolete| | --- Comment #8 from Fridolin Somers --- Created attachment 114321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114321&action=edit Bug 27149: Don't strip itemnumber when adding item status via Z3950Responder To test: 1 - sudo koha-z3950-responder --stop kohadev 2 - Run it manually: perl /kohadevbox/koha/misc/z3950_responder.pl -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 3 - Connect and search to verify itemnumber is in item records yaz-client localhost:2100 base biblios find shuffle show 1+1 4 - sudo koha-z3950-responder --stop kohadev 5 - Run it manually to add item status perl /kohadevbox/koha/misc/z3950_responder.pl --add-item-status k -c /etc/koha/sites/kohadev/z3950 -u kohadev-koha -p /var/run/koha/kohadev/z3950-responder.pid -D -d kohadev-koha-z3950 -l /var/log/koha/kohadev/z3950.log 6 - Connect and search, no itemnumber in records 7 - Apply patch 8 - Stop, restart all the things, and manually start server with item status again 9 - Connect and search, itemnumbers are included Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 09:46:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 08:46:22 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 09:50:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 08:50:34 +0000 Subject: [Koha-bugs] [Bug 27062] pickup_location tests don't deal correctly with existing libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 --- Comment #6 from Jonathan Druart --- No need to backport I'd say. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 09:50:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 08:50:44 +0000 Subject: [Koha-bugs] [Bug 27062] pickup_location tests don't deal correctly with existing libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27062 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 09:52:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 08:52:04 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #21 from Timothy Alexis Vass --- Created attachment 114322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114322&action=edit Bug 27080: Add --statute-barred-fees option to cleanup_database.pl. According to Swedish law, fees become statute-barred after 3 years. With this option, we can use cleanup_database.pl to purge those from accountlines. NOTE: This commit also fixes indentations. You can use the -w option with git to ignore space differences. To test: 1) You will need at least one record in the accountlines table WHERE status = 'RETURNED' AND amountoutstanding > 0. 2) Run ./misc/cronjobs/cleanup_database.pl --statute-barred-fees DAYS Where DAYS is 1 or greater. This will delete records from accountlines WHERE date is DAYS day(s) or older. 3) Confirm that records have been deleted. Sponsored-by: Lunds Universitetsbibliotek -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 09:53:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 08:53:26 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114322|0 |1 is obsolete| | --- Comment #22 from Timothy Alexis Vass --- Created attachment 114323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114323&action=edit Bug 27080: Add --statute-barred-fees option to cleanup_database.pl. According to Swedish law, fees become statute-barred after 3 years if the material has been returned. With this option, we can use cleanup_database.pl to purge those from accountlines. To test: 1) You will need at least one record in the accountlines table WHERE status = 'RETURNED' AND amountoutstanding > 0. 2) Run ./misc/cronjobs/cleanup_database.pl --statute-barred-fees DAYS Where DAYS is 1 or greater. This will delete records from accountlines WHERE date is DAYS day(s) or older. 3) Confirm that records have been deleted. Sponsored-by: Lunds Universitetsbibliotek -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 09:58:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 08:58:58 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114202|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 10:10:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 09:10:20 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #23 from Joonas Kylmälä --- (In reply to Timothy Alexis Vass from comment #20) > (In reply to Joonas Kylmälä from comment #19) > > In the other situations "Renewed" and "Lost", it is different. Then the debt > has been handed over to "Kronofogdemyndigheten", which is the Swedish > Enforcement Agency. What about RESERVE_EXPIRED fees? In Finland those could become statute barred depending on whether the library reminds the customer about the fees: . I think also RENEWED fees could become statute barred in Finland in the case where the item was just lost for 1 day and patron went to library then immediately and wanted to renew the book, and has been renewing it ever since so the status is still RENEWED 3 years later. > > > - Depending on your answer to the above question, would it make sense to > > make the name of this option something more generic, like --unpaid-fees? > > The only thing that makes sense is to call it --statute-barred-fees because > that is exactly what it is. They are not --unpaid-fees, they are not > --expired-fees, they are not --old-fees, they are fees that have been barred > according to ruling statutes. The problem with using statute barred term is that the legal definition and usage of this option might vary by the region/country and library (if they have different processes in place that prevent some things getting statute barred like in the Finnish example above). How will the user know which country's definition is being used? It is not good idea to do one statute-barred for each country/region because it will make the program complex by having to adapt to each case. > > - The code is now not in a function, i.e. cannot be tested. Would something > > like Koha::Account::Lines::statute_barred (depending on the scope of this > > function maybe a different name) sound good to you? Then you can call > > ->delete or ->count on those and the code will look super cool in the > > script, wouldn't it? :) > > Easy to maintain, simple code is preferred. > I would suggest removing all this insane complexity and do database > maintenance in the database, such as: > CREATE EVENT cleanup_statute_barred_fees ON SCHEDULE EVERY 1 DAY > DO > DELETE FROM accountlines > WHERE date < date_sub(curdate(), INTERVAL 1095 DAY) > AND status = 'RETURNED' > AND amountoutstanding > 0 > > Quite seriously, if you want to make it redundnantly complex because you > find that interesting, you are free to make it happen. My goal is the same, easy to maintain and simple code. Easy to maintain for me means we have tests, then any modifications to the search method can be done without testing manually all the places where it is being used. Maybe it is a bit overkill, what do others think? Other benefits of using a function is that now we can document the statute debarred fines in a standard way in the perldoc that goes along with it. As for simple, I find Koha::Account::Lines::statute_barred->delete simpler/easier to understand than the call the search with multiple params, the same goes with the statute_barred function definition: I will find it easier to understand the reasons behind RETURNED, amountoutstanding > 0 when these are documented right next to the lines of code in question either using variables or the perldoc. When this is in a function we can also reuse this code in other places in the future. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 10:12:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 09:12:21 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #28 from Martin Renvoize --- Just for documentation, we had a good discussion around this on IRC this morning with a few options to think about.. discussion is around 8.13: http://irc.koha-community.org/koha/2020-12-11#i_2316124 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 10:21:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 09:21:28 +0000 Subject: [Koha-bugs] [Bug 27200] New: "Browse search" is broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Bug ID: 27200 Summary: "Browse search" is broken Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 20168 The error is displayed (when it must be hidden): "An error occurred, please try again." and clicking the "Search" button does not do anything. Caused by commit 9cb89b46397efc5e288723829613c33e7eea0d69 Bug 20168: Update of the OPAC bootstrap template to bootstrap v4 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 10:21:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 09:21:28 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27200 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 [Bug 27200] "Browse search" is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 10:47:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 09:47:58 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 --- Comment #18 from Jonathan Druart --- The problem also exists for the install, when the tables don't exist yet. I can try to explain again, it's as simple as: Without unsafe we cannot disable RaiseError (passing RaiseError => 0 to ->connect), because DBIC set its own HandleError (and will raise the error anyway, because it considers it's the right thing to do, unless you passed unsafe => 1). The idea of this patch is the remove this HandleError and ignore the error in both case: - KOHA_DB_DO_NOT_RAISE_OR_PRINT_ERROR is set (to not have errors *displayed* on reset_all, ie. misc4dev/do_all_you_can_do.pl) - we are hitting the installer for the first time I have not retested, but I don't think misc4dev could deal with the replacement of the HandleError, $dbh is init at compilation and that's why we have KOHA_DB_DO_NOT_RAISE_OR_PRINT_ERROR in the BEGIN block. Even if we could, I don't think we should drop KOHA_DB_DO_NOT_RAISE_OR_PRINT_ERROR's behaviour without deprecation notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 10:54:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 09:54:30 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #6 from Emmi Takkinen --- (In reply to Andrew Isherwood from comment #5) > Hi Emmi > > I tried to sign this off but ran into a few problems, sorry! > > 1. prove -v t/db_dependent/Hold.t fails with: > t/db_dependent/Hold.t .. 1/34 found extra parameters: []# Looks like your > test exited with 2 just after 1. > t/db_dependent/Hold.t .. Dubious, test returned 2 (wstat 512, 0x200) > Failed 33/34 subtests > > Test Summary Report > ------------------- > t/db_dependent/Hold.t (Wstat: 512 Tests: 1 Failed: 0) > Non-zero exit status: 2 > Parse errors: Bad plan. You planned 34 tests but ran 1. > Files=1, Tests=1, 4 wallclock secs ( 0.04 usr 0.01 sys + 3.28 cusr 0.42 > csys = 3.75 CPU) > Result: FAIL > > 2. In your test plan, you say "Holds expiration date should be set according > your settings", this doesn't appear to be happening. The expiry date is not > being populated according to the value in the > DefaultHoldExpirationdatePeriod syspref. Maybe I'm misunderstanding the test > plan? You can see what I mean here: https://nimb.ws/Sw048R > > 3. In the video I manually selected a date and the hold was created, > however, if I leave the date selection blank I receive an error page (the > relevant part of which is here https://nimb.ws/pWzZNO), I note the error is > the same as the one in the failing test. > > Sorry to report bad news! Hi Andrew and thanks for your feedback. 1. There is something wrong with the tests but mine fail for other reason(s): "attempting to use non-existent class sorting routine CIG" followed by bunch of "Use of uninitialized value $cn_class in concatenation", then fail to insert into special_holidays and lastly "The method age is not covered by tests!". But they fail also on master. 2. I should have been more clear with my test plan, sorry! These sysprefs have effect only if expiration date is left blank. As Fiona above said: "A member of staff or a user can manually enter an expiry date when placing the hold but if they do not, then the expiry date is blank which means that the hold never expires." 3. Hmm, I'm unable to repeat this. I'll set this back to assigned and see if I can figure this out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 11:19:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 10:19:32 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 11:20:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 10:20:31 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 --- Comment #1 from Jonathan Druart --- Created attachment 114324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114324&action=edit Bug 27200: (bug 20168 follow-up) Fix 'Browse search' The 'hidden' class has been replaced by 'd-none' on bug 20168 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 11:21:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 10:21:26 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |oleonard at myacpl.org |ommunity.org | --- Comment #2 from Jonathan Druart --- This patch fixes the original issue, but screen still does not look very nice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 11:49:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 10:49:17 +0000 Subject: [Koha-bugs] [Bug 26983] Selecting ALL Items in Inventory- only selects 20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26983 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 11:49:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 10:49:20 +0000 Subject: [Koha-bugs] [Bug 26983] Selecting ALL Items in Inventory- only selects 20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26983 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114087|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 114325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114325&action=edit Bug 26983: Fix [un]select all links in inventory The select/unselect all links took into account only the items displayed when the page was loaded (so 20). Test plan: 1. Go to Tools-> Inventory-> Do a Search to produce more than 20 results 2. Select 50, 100 or All entries to show 3. click on Select All => All items must be selected, not only the first 20 Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 11:52:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 10:52:15 +0000 Subject: [Koha-bugs] [Bug 26983] Selecting ALL Items in Inventory- only selects 20 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26983 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- Ok fix is working. Will testing I see that "Select all" in fact selects the visible lines. Maybe we should rename it "Select visible rows", like in items search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:02:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:02:02 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:02:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:02:07 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:02:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:02:10 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:02:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:02:13 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:02:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:02:17 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:02:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:02:21 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:02:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:02:24 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:11:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:11:01 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112852|0 |1 is obsolete| | --- Comment #101 from paxed --- Created attachment 114326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114326&action=edit Bug 11175: Show record component parts in the detail view Shows the component records of a host, on the hosts detail view in staff client or OPAC, with clickable links to the component records. The host does not require linking entries to the components, but components do require a link to the host record via 773$w. Adds a new search index, Control-number-identifier (aka cni), which indexes the 003 controlfield. Adds 'Yet Another System Preference', ShowComponentRecords, which can be used to turn this feature on or off in staff client and/or OPAC, and defaults to off. When looking up the component part records, the code searches for records with (773$w=Host001 and 003=Host003) or 773$w='Host003 Host001' or, if the 003 is not defined in the Host, 773$w=Host001. Does not use easyanalytics or useControlNumber. Only for MARC21 biblios - UNIMARC has not been updated. staff-global.css and opac.css have not been recreated, so you need to use sass to recreate those from staff-global.scss and opac.scss Test plan: 0) Apply patch 1) perl bulkmarcimport -file /tmp/easypiano.mrc -m MARCXML (This file is an attachment on the bug) 2) rebuild the zebra biblio index 3) Search for "easy piano" in staff client, and go to the biblio detail page. You should not see anything different in the record detail page. 4) Do the same on OPAC. 5) Change the ShowComponentRecords syspref appropriately and check the record detail page in staff client and OPAC. You should see a list of component part records. Rebased-by: Joonas Kylmälä Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:11:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:11:06 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112853|0 |1 is obsolete| | --- Comment #102 from paxed --- Created attachment 114327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114327&action=edit Bug 11175: (follow-up) Don't return explicitly undef This would create in list context an list of one element that is undef, which we don't want, we want empty list if there are no components. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:11:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:11:11 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112854|0 |1 is obsolete| | --- Comment #103 from paxed --- Created attachment 114328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114328&action=edit Bug 11175: (follow-up) Return empty array if no components Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:11:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:11:16 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112855|0 |1 is obsolete| | --- Comment #104 from paxed --- Created attachment 114329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114329&action=edit Bug 11175: (follow-up) Add tests Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:11:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:11:21 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112856|0 |1 is obsolete| | --- Comment #105 from paxed --- Created attachment 114330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114330&action=edit Bug 11175: (follow-up) Relocate and reword ShowComponentRecords syspref description The syspref is not only affecting staff interface so moving it to Cataloguing section. Added also notes about UNIMARC and Elasticsearch not being supported. Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:11:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:11:26 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112857|0 |1 is obsolete| | --- Comment #106 from paxed --- Created attachment 114331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114331&action=edit Bug 11175: Add Elasticsearch support Signed-off-by: Nick Clemens Signed-off-by: Pasi Kallinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:11:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:11:32 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113649|0 |1 is obsolete| | --- Comment #107 from paxed --- Created attachment 114332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114332&action=edit Bug 11175: Keep component part record list items inside the box Without this the number denoting the component part item in the list will overflow and is partly hidden. To test: 1) Create 100 component parts 2) Notice without this patch the number next to the component part is not fully shown Signed-off-by: Pasi Kallinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:11:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:11:37 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113650|0 |1 is obsolete| | --- Comment #108 from paxed --- Created attachment 114333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114333&action=edit Bug 11175: Limit the amount of component parts returned There was already before this a limit of 100 results when using Elasticsearch but then the list of component parts was truncated silently. This change now limits the amount to hard coded limit of 300 which is still fast to render. Also when the 300 component part record limit is reached there is a link in the list now to list all the records via the cataloging search. To test: 1) Create 300+ component part records and see if the link to list all the component part records shows up 2) Make sure prove t/Koha/Util/Search.t passes Signed-off-by: Pasi Kallinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:11:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:11:42 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 paxed changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113964|0 |1 is obsolete| | --- Comment #109 from paxed --- Created attachment 114334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114334&action=edit Bug 11175: Search using double quotes to support Elasticsearch With Elasticsearch if you would use the search string here without the change to double quotes, i.e. (rcn='1234' AND cni='FI-XXX') OR rcn='FI-XXX 1234' then the search would somehow manage to return a record with 001 = 1234 and 003 = FI-XXX. Using double quotes prevents that. Also using parenthesis around the latter part of the OR seems to work: (rcn='1234' AND cni='FI-XXX') OR (rcn='FI-XXX 1234') Signed-off-by: Pasi Kallinen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:17:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:17:36 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 --- Comment #3 from Didier Gautheron --- Created attachment 114335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114335&action=edit Bug 22038: Disable excel export if CurrencyFormat is FR DataTables excel export is broken if number decimal separator is a comma. Test plan: 1 - Set syspref CurrencyFormat to US 2 - Export as excel a table with decimal numbers, patrons list with fines for example. 3 - Open in libreoffice or excel, numbers are ok. 4 - Set syspref CurrencyFormat to FR 5 - Export and open again, number are wrong 25,10 is imported as 2510 6 - Apply patch 7 - Redo 1 to 4 8 - Excel export is not available with FR. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:19:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:19:32 +0000 Subject: [Koha-bugs] [Bug 27189] Unable to delete patron In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27189 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE --- Comment #1 from Jonathan Druart --- Can you confirm it's fixed by bug 27144? *** This bug has been marked as a duplicate of bug 27144 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:19:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:19:32 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nishathahmed at gmail.com --- Comment #12 from Jonathan Druart --- *** Bug 27189 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:19:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:19:48 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |didier.gautheron at biblibre.c |ity.org |om CC| |frederic at tamil.fr Status|NEW |Needs Signoff Component|Fines and fees |I18N/L10N -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:22:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:22:03 +0000 Subject: [Koha-bugs] [Bug 27194] Using Batch Patron Modification from Reporting Module is not working correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27194 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 27142 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:22:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:22:03 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #8 from Jonathan Druart --- *** Bug 27194 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:22:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:22:21 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:22:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:22:35 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:22:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:22:41 +0000 Subject: [Koha-bugs] [Bug 26031] www/search_utf8.t is failing randomly and must be removed/replaced In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26031 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:22:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:22:43 +0000 Subject: [Koha-bugs] [Bug 26665] OAI 'Set' and 'Metadata' dropdowns broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26665 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:27:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:27:14 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch introduces an release notes| |efficient way of filtering | |Koha::Items result sets, to | |hide items that | |OpacHiddenItems determines | |shouldn't be exposed on | |public interfaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:42:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:42:06 +0000 Subject: [Koha-bugs] [Bug 27201] New: New permission to modify pickup locations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27201 Bug ID: 27201 Summary: New permission to modify pickup locations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 18729, 27117 We need a new subpermission to allow modification of pickup locations. reserveforothers: modify_pickup_location Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:42:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:42:06 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27201 [Bug 27201] New permission to modify pickup locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:42:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:42:06 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27201 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27201 [Bug 27201] New permission to modify pickup locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:44:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:44:50 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent record's component parts in the detailed views In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:45:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:45:16 +0000 Subject: [Koha-bugs] [Bug 27202] New: Hii Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27202 Bug ID: 27202 Summary: Hii Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: mukhlisfadhil8 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114336&action=edit Hallo -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 12:58:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 11:58:58 +0000 Subject: [Koha-bugs] [Bug 27203] New: Order unitprice is not set anymore and totals are 0. Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 Bug ID: 27203 Summary: Order unitprice is not set anymore and totals are 0. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: didier.gautheron at biblibre.com Reporter: didier.gautheron at biblibre.com QA Contact: testopia at bugs.koha-community.org After 23294 commit unitprice is not undefined or equal to '' but is 0. and it's not set to ecost in acqui/addorder.pl. Either set uniprice to '' or if 0. use ecost. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:08:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:08:26 +0000 Subject: [Koha-bugs] [Bug 27204] New: SIP patron information request with fee line items returns incorrect data Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27204 Bug ID: 27204 Summary: SIP patron information request with fee line items returns incorrect data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com There are two primary issues I've identified with requesting line items for fees via SIP: 1) The end boundary is incorrect. For example, if send a request with a BP ( starting item) of 1, and a BQ (end item) of 1, I should get just the first item. Instead I will get two items 2) Our SIP server does not check bounds. For example, if I have 3 fines, but I send a BP of 1 and a BQ of 5, I will get back 5 AVs, two of them being "empty" because the patron only has 3 accountlines! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:08:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:08:44 +0000 Subject: [Koha-bugs] [Bug 27204] SIP patron information request with fee line items returns incorrect data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27204 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:14:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:14:03 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 114337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114337&action=edit Bug 18729: Add more tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:14:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:14:10 +0000 Subject: [Koha-bugs] [Bug 27205] New: Hold routes are not dealing with invalid pickup locations Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Bug ID: 27205 Summary: Hold routes are not dealing with invalid pickup locations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It's possible to PUT or POST /holds with invalid pickup locations. As the staff cannot overwrite invalid pickup locations (to confirmed), we should raise an exception from AddReserve and ModReserve if called with invalid pickup locations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:14:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:14:27 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18729 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:14:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:14:27 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 [Bug 27205] Hold routes are not dealing with invalid pickup locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:15:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:15:40 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:16:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:16:39 +0000 Subject: [Koha-bugs] [Bug 27204] SIP patron information request with fee line items returns incorrect data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27204 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:16:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:16:40 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:16:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:16:42 +0000 Subject: [Koha-bugs] [Bug 27204] SIP patron information request with fee line items returns incorrect data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27204 --- Comment #1 from Kyle M Hall --- Created attachment 114338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114338&action=edit Bug 27204: Add unit tests for fine_items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:16:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:16:51 +0000 Subject: [Koha-bugs] [Bug 27204] SIP patron information request with fee line items returns incorrect data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27204 --- Comment #2 from Kyle M Hall --- Created attachment 114339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114339&action=edit Bug 27204: Fix end boundary index, never return results for non-existant accountlines There are two primary issues I've identified with requesting line items for fees via SIP: 1) The end boundary is incorrect. For example, if send a request with a BP ( starting item) of 1, and a BQ (end item) of 1, I should get just the first item. Instead I will get two items 2) Our SIP server does not check bounds. For example, if I have 3 fines, but I send a BP of 1 and a BQ of 5, I will get back 5 AVs, two of them being "empty" because the patron only has 3 accountlines! Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/SIP/Patron.t 3) Note the failures 4) Apply the second patch 5) prove t/db_dependent/SIP/Patron.t 6) All tests should pass! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:18:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:18:48 +0000 Subject: [Koha-bugs] [Bug 27158] software error In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27158 Nishath Ahmed changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Nishath Ahmed --- Jonathan Druart, Got it! Thanks for your kind help. By the way why it wasn't altered during upgrade I mean (upgrade-database-schema) command. Anyways many thanks! Regards! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:24:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:24:19 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:49:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:49:18 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #24 from Timothy Alexis Vass --- Created attachment 114340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114340&action=edit Bug 27080: Correct help sections and identations. - Correct sentences with punctuation in help section. - Whitespace/indentation corrections. To test: Look at the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 13:51:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 12:51:12 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #25 from Timothy Alexis Vass --- You do whatever you like, we drop any further efforts on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 14:17:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 13:17:18 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a new release notes| |button to basic MARC | |editor. When clicked this | |button will run through all | |controlled fields in the | |MARC record and search the | |existing authority file to | |link them to authorities. | |Depending on system | |preferences unmatched | |headings will create new | |authorities or remain | |unlinked. Results will be | |highlighted so that the | |catakloger can see what was | |done. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 14:25:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 13:25:19 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 --- Comment #13 from Nishath Ahmed --- Created attachment 114341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114341&action=edit After fixing bug 27144 Dear All, I patched this bug by adding semicolon(;) at deletemem.pl, but still I get an unusual error even after setting AnonymousPatron in Global System Preference. Please checkout attachment. Advice is anticipated! Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 14:27:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 13:27:09 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds a new |This patch adds a new release notes|button to basic MARC |button to basic MARC |editor. When clicked this |editor. When clicked this |button will run through all |button will run through all |controlled fields in the |controlled fields in the |MARC record and search the |MARC record and search the |existing authority file to |existing authority file to |link them to authorities. |link them to authorities. |Depending on system |Depending on system |preferences unmatched |preferences unmatched |headings will create new |headings will create new |authorities or remain |authorities or remain |unlinked. Results will be |unlinked. Results will be |highlighted so that the |highlighted so that the |catakloger can see what was |cataloguer can see what was |done. |done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 14:33:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 13:33:52 +0000 Subject: [Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 14:33:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 13:33:55 +0000 Subject: [Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 --- Comment #1 from Didier Gautheron --- Created attachment 114342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114342&action=edit Bug 27203: (Bug 23294 follow up) set unitprice to ecost if it's 0. Test plan: 1 - Create a basket 2 - Add an order line, don't set 'Actual cost: ', but use vendor price and a discount. 3 - Save 4 - Display all columns, 'Actual cost tax inc.' are GST columns aren't set. 5 - Apply batch 6 - Redo 1,2, 3 7 - Display all columns, pre 23294 behaviour is back columns are set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 14:39:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 13:39:12 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 --- Comment #14 from Jonathan Druart --- (In reply to Nishath Ahmed from comment #13) > Created attachment 114341 [details] > After fixing bug 27144 > > Dear All, > I patched this bug by adding semicolon(;) at deletemem.pl, but still I get > an unusual error even after setting AnonymousPatron in Global System > Preference. > Please checkout attachment. > > Advice is anticipated! > > Thanks! Are you trying to delete the anonymous patron? Do you get this error with another patron? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 14:41:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 13:41:19 +0000 Subject: [Koha-bugs] [Bug 27175] Jenkins instance exposed to public In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27175 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 14:44:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 13:44:14 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion Change sponsored?|Sponsored |--- Assignee|timothy_alexis.vass at ub.lu.s |koha-bugs at lists.koha-commun |e |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 14:47:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 13:47:04 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |plugin hook to transform | |item barcodes scanned in to | |Koha. For example, if you | |need to alter your scanned | |item barcodes, but your | |scanners cannot be | |programmed to do so, a | |plugin could be written to | |handle that change in Koha | |instead. One example would | |be to drop the first and | |last characters of the | |scanned barcode, which may | |be check digits rather than | |part of the barcode itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 14:47:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 13:47:45 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds a release notes| |plugin hook to transform | |patron cardnumbers scanned | |in to Koha. For example, if | |you need to alter your | |scanned cardnumbers, but | |your scanners cannot be | |programmed to do so, a | |plugin could be written to | |handle that change in Koha | |instead. One example would | |be to drop the first and | |last characters of the | |scanned barcode, which may | |be check digits rather than | |part of the barcode itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 14:55:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 13:55:45 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #15 from Victor Grousset/tuxayo --- Why was the shebang changed in /debian/koha-common.postinst ? -#!/bin/sh +a!/bin/sh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:04:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:04:09 +0000 Subject: [Koha-bugs] [Bug 12104] Add print label to serials receive In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12104 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #2 from Donna --- This enhancement would be very welcomed! Libraries who don't create items for serials need to be able to print a label for the serials. Ideally it would be customizable to include the call number, collection, and shelving location. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:05:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:05:54 +0000 Subject: [Koha-bugs] [Bug 26894] Marc Modification Templates treat subfield 0 as no subfield set when moving fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26894 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:05:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:05:57 +0000 Subject: [Koha-bugs] [Bug 26894] Marc Modification Templates treat subfield 0 as no subfield set when moving fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26894 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112827|0 |1 is obsolete| | --- Comment #2 from Fridolin Somers --- Created attachment 114343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114343&action=edit Bug 26894: Handle subfield 0 and delete empty fields This patch corrects handling of subfield 0 when copying/moving. Before these patches copying from subfield 0 would copy the entire field. We also correct an error that if moving a single subfield, we can leave behind empty fields with no subfields. They should be deleted. To test: 1 - Define a new MARC Modification template with actions: Delete field 100$0 Add new field 100$0 with value Test Update existing or add new field 100$0 with value TestUpdated Move field 100$0 to 600$0 Copy field 600$0 to 100$0 Copy and replace field 245$0 to 700$0 2 - Define a new record like: LDR 00334nam a22001217a 4500 003 ff 005 20201102111604.0 008 201102b xxu||||| |||| 00| 0 eng d 040 _ _ ‡cvsd 100 1 _ ‡012345‡aKnuth, Donal Ervin‡d1938 245 _ _ ‡012345‡aThe aty of computer programming‡cDonald E. Knuth 650 _ 0 ‡042‡aComputer programming‡9462 3 - Modify this record using the template above 4 - Note that entier 245 is copied to 700, same for 600 field 5 - Apply patch 6 - Now only subfields 0 are copied Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:06:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:06:42 +0000 Subject: [Koha-bugs] [Bug 27202] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27202 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Summary|Hii |SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:11:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:11:37 +0000 Subject: [Koha-bugs] [Bug 26894] Marc Modification Templates treat subfield 0 as no subfield set when moving fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26894 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #3 from Fridolin Somers --- Tested well. Note that I was running manually misc/background_jobs_worker.pl, that must be restarted after applying patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:12:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:12:02 +0000 Subject: [Koha-bugs] [Bug 23499] Show subtitle in serials search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23499 Donna changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com --- Comment #2 from Donna --- I think as a starting point, just displaying the subfield b would be helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:25:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:25:54 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #16 from Victor Grousset/tuxayo --- 13. Review "The following NEW packages will be installed" and note rabbitmq-server is included Not included right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:33:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:33:41 +0000 Subject: [Koha-bugs] [Bug 27206] New: Elasticsearch sort by popularity must use totalissues search field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206 Bug ID: 27206 Summary: Elasticsearch sort by popularity must use totalissues search field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com With Zebra search engine, sort by popularity uses search field 9003. This is from bib1.att : att 9003 totalissues Actually Elasticsearch sort by popularity uses search field 'issues' : https://git.koha-community.org/Koha-community/Koha/src/commit/cae0ef76f398bb3d9f60235ff10611cc8d8eacb7/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm#L593 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:33:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:33:53 +0000 Subject: [Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:40:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:40:58 +0000 Subject: [Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:41:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:41:01 +0000 Subject: [Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206 --- Comment #1 from Fridolin Somers --- Created attachment 114344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114344&action=edit Bug 27206: Elasticsearch sort by popularity must use totalissues search field With Zebra search engine, sort by popularity uses search field 9003. This is from bib1.att : att 9003 totalissues 'totalissues' beeing on 942$0 Actually Elasticsearch sort by popularity uses search field 'issues' : https://git.koha-community.org/Koha-community/Koha/src/commit/cae0ef76f398bb3d9f60235ff10611cc8d8eacb7/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm#L593 Test plan : 1) Use zebra search engine 2) Perform some checkouts and checkins 3) Run misc/cronjobs/update_totalissues.pl 4) Perform a search sorting on popularity 5) Change search engine to Elasticsearch 6) Rebuild all biblios : misc/search_tools/rebuild_elasticsearch.pl -b 7) Perform same search sorting on popularity => You should get same order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:42:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:42:30 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:42:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:42:33 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #7 from Jonathan Druart --- Created attachment 114345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114345&action=edit Bug 8976: Add marc_subfield_structure.display_order Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:42:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:42:37 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #8 from Jonathan Druart --- Created attachment 114346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114346&action=edit Bug 8976: Add the ability to sort subfields for the MARC frameworks This new enhancement adds the ability to change the default order the subfields. Both bibliographic and authority MARC subfield structure are taken into account. And so the item edition as well (in the different screens when item can be added/edited). This will answer the following needs that have been listed in the comments of the bug report: - $i in 7xx fields should be the first subfield in the sequence - 300 fields are sorted number first when cataloguers enter the letter fields first - 100 field, it's commonly $a, $q, $d. Test plan: 1. Edit a MARC frameworks, field 300 2. Resort the subfield (drag and drop the tab of the subfield) as you like 3. Save => Notice that the list of fields are displayed following the order you chose 4. Edit it again => The order is correctly kept! 5. Create a new bibliographic record 6. Notice that the subfields are order in the same sequence 7. Fill different subfields, not all 8. Save, edit again 9. Note that the subfields that have been filled are listed first, then the empty ones. But the sequence defined at the framework level is kept. 10. Do the same for an authority framework and create/edit an authority record 11. Modify item (952) subfields order 12. Create an item and confirm that the order is correct 13. Modify the ACQ framework, 952, modify the order of the subfield 14. Create a new order and confirm that the item form has the subfield ordered following the sequence defined at the framework level QA: Note that this patch is about bibliographic records only, next patches deal with authotiries and items. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:42:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:42:41 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #9 from Jonathan Druart --- Created attachment 114347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114347&action=edit Bug 8976: Sort subfields for authority records Same patch for the authority frameworks/records Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:42:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:42:45 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #10 from Jonathan Druart --- Created attachment 114348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114348&action=edit Bug 8976: Change for the item forms Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:42:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:42:49 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #11 from Jonathan Druart --- Created attachment 114349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114349&action=edit Bug 8976: Add Koha::AuthSubfieldStructure[s] Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:42:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:42:53 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #12 from Jonathan Druart --- Created attachment 114350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114350&action=edit Bug 8976: Code cleaning It was tricky to write the previous patch so I decided to clean the ground (a bit) for later, taking advantage of having people who are going to test the whole area. We can move it to its own bug report if QA wants to. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:43:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:43:53 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114347|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart --- Created attachment 114351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114351&action=edit Bug 8976: Sort subfields for authority records Same patch for the authority frameworks/records Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:43:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:43:57 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114348|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 114352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114352&action=edit Bug 8976: Change for the item forms Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:44:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:44:01 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114349|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 114353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114353&action=edit Bug 8976: Add Koha::AuthSubfieldStructure[s] Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:44:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:44:05 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114350|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart --- Created attachment 114354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114354&action=edit Bug 8976: Code cleaning It was tricky to write the previous patch so I decided to clean the ground (a bit) for later, taking advantage of having people who are going to test the whole area. We can move it to its own bug report if QA wants to. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:44:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:44:09 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #17 from Jonathan Druart --- Created attachment 114355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114355&action=edit Bug 8976: DBIC schema changes Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:45:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:45:39 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new enhancement adds release notes| |the ability to change the | |default order the | |subfields. | | | |Both | |bibliographic and authority | |MARC subfield structure are | |taken into account. And so | |the item edition as well. | | | |This will answer, for | |instance, the following | |needs: | | - $i in 7xx fields | |should be the first | |subfield in the sequence | | - | |300 fields are sorted | |number first when | |cataloguers enter the | |letter fields first | | - 100 | |field, it's commonly $a, | |$q, $d. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:52:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:52:40 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #18 from Jonathan Druart --- Some screenshots: Before the sequence change: https://snipboard.io/7ACU0L.jpg During the sequence change: https://snipboard.io/NUXbTY.jpg After the sequence change: https://snipboard.io/tbJYlO.jpg List of the subfields with the new sequence: https://snipboard.io/v3V9tJ.jpg Edition of a new bibliographic record: https://snipboard.io/RlEeV0.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:56:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:56:26 +0000 Subject: [Koha-bugs] [Bug 25942] Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #18 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, no backport. 19.11.x shouldn't be affected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 15:56:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 14:56:27 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Bug 27142 depends on bug 25942, which changed state. Bug 25942 Summary: Batch biblio and borrower operations on report results should not concatenate biblio/cardnumbers into a single string https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25942 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 16:00:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 15:00:34 +0000 Subject: [Koha-bugs] [Bug 27142] Patron batch update from report module - no patrons loaded into view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27142 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #9 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 16:00:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 15:00:35 +0000 Subject: [Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 16:06:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 15:06:40 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Craig changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbutosi at gmail.com --- Comment #3 from Craig --- Confirming that Jonathan's patch has restored the ability to search. However, the error statement is still visible and there are some css adjustments necessary as indicated. To address these, I've simply added the following to OpacUserCSS until they can be patched in a subsequent Koha version: #browse-search .error {display: none;} #browse-search #browse-selection {padding-top: 15px;} #browse-search #browse-searchresults, #browse-search #browse-selectionsearch {border: none;} Thank you to all! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 16:26:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 15:26:32 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Needs Signoff |Failed QA --- Comment #3 from Fridolin Somers --- Patch works well :D But : There is a missing html filter in : data-exclusions="[% CHUNK.exclusions %] Most important : Clicking on "Select all" selects the branchcode :O -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 16:27:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 15:27:39 +0000 Subject: [Koha-bugs] [Bug 27207] New: Add a spell check feature to the Advanced Cataloging Editor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27207 Bug ID: 27207 Summary: Add a spell check feature to the Advanced Cataloging Editor Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Add a spell check feature to the Advanced Cataloging Editor. This would be very helpful for finding errors in notes, subjects, etc. There are a lot of fields in a bib record, such as the 040 or 049, that would not benefit from being spell checked so make it so users can define which MARC tags should be included in spell checking. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:02:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:02:24 +0000 Subject: [Koha-bugs] [Bug 27208] New: Add a configurable time delay feature to notice templates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Bug ID: 27208 Summary: Add a configurable time delay feature to notice templates Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org It would be helpful to have a configurable time delay feature added to the notice templates. In our case, items with holds are immediately trapped, and the hold notice gets sent, when they get returned through our sorter. However, we are quarantining materials for 72 hours so we don’t want the hold pickup notice sent until the items come out of quarantine. Other possible uses for a configurable time delay might be when one library in a system is quarantining items but another is not. In a consortium, with a mix of school and public libraries, they might want to send notices at different times. Other libraries have mentioned their patrons arrive at the library because they got their pickup notice but staff hasn’t actually had time to process the holds. This would be especially helpful with hold notices but could also apply to other notices. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:11:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:11:14 +0000 Subject: [Koha-bugs] [Bug 26903] Authority records not being indexed in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor at tuxayo.net Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo --- index_records doesn't exist in 19.11 Missing dependencies for 19.11.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:11:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:11:15 +0000 Subject: [Koha-bugs] [Bug 26543] Elasticsearch - Importing biblios with multiple items can cause incorrect index In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26543 Bug 26543 depends on bug 26903, which changed state. Bug 26903 Summary: Authority records not being indexed in Elasticsearch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26903 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:14:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:14:29 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:16:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:16:01 +0000 Subject: [Koha-bugs] [Bug 26938] Prevent flash of unstyled content on sales table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:16:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:16:02 +0000 Subject: [Koha-bugs] [Bug 26939] Account payment_type in the cash register details page should use description instead of code. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26939 Bug 26939 depends on bug 26938, which changed state. Bug 26938 Summary: Prevent flash of unstyled content on sales table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26938 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:20:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:20:32 +0000 Subject: [Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #18 from Victor Grousset/tuxayo --- I think I remember not having this bug in 19.11.x when I tried it once. But anyone now it's affected. Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:20:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:20:45 +0000 Subject: [Koha-bugs] [Bug 25752] Current directory not kept when using koha-shell In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25752 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in| |19.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:28:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:28:31 +0000 Subject: [Koha-bugs] [Bug 25514] REST/Plugin/Objects.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #14 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:28:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:28:32 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Bug 25551 depends on bug 25514, which changed state. Bug 25514 Summary: REST/Plugin/Objects.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25514 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:40:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:40:43 +0000 Subject: [Koha-bugs] [Bug 7607] Advanced search: Index and search term don't match when leaving fields empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #55 from Victor Grousset/tuxayo --- Conflict in koha-tmpl/intranet-tmpl/prog/js/staff-global.js Can't resolve and can't backport to 19.11.x <<<<<<< HEAD if (typeof $.cookie("lastborrowernumber") === "undefined" || ($("#hiddenborrowernumber").val() != $.cookie("lastborrowernumber") && $.cookie("currentborrowernumber") != $("#hiddenborrowernumber").val())) { $.cookie("lastborrowernumber", $("#hiddenborrowernumber").val(), { path: "/" }); $.cookie("lastborrowername", $("#hiddenborrowername").val(), { path: "/" }); $.cookie("lastborrowercard", $("#hiddenborrowercard").val(), { path: "/" }); } $.cookie("currentborrowernumber", $("#hiddenborrowernumber").val(), { path: "/" }); ||||||| parent of b460a630ef (Bug 7607: Remove empty inputs when submitting search form) /* Search results browsing */ /* forms with action leading to search */ $("form[action*='search.pl']").submit(function(){ resetSearchContext(); }); /* any link to launch a search except navigation links */ $("[href*='search.pl?']").not(".nav").not('.searchwithcontext').click(function(){ resetSearchContext(); }); /* any link to a detail page from the results page. */ $("#bookbag_form a[href*='detail.pl?']").click(function(){ resetSearchContext(); }); ======= /* Search results browsing */ /* forms with action leading to search */ $("form[action*='search.pl']").submit(function(){ var removedPrior = false; $(".search_set").each(function(){ if( removedPrior ){ $(this).find('select[name="op"]').remove(); removedPrior = false; } if( $(this).find('input[name="q"]').val() == "" ){ $(this).remove(); removedPrior = true; } }); resetSearchContext(); }); /* any link to launch a search except navigation links */ $("[href*='search.pl?']").not(".nav").not('.searchwithcontext').click(function(){ resetSearchContext(); }); /* any link to a detail page from the results page. */ $("#bookbag_form a[href*='detail.pl?']").click(function(){ resetSearchContext(); }); >>>>>>> b460a630ef (Bug 7607: Remove empty inputs when submitting search form) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:40:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:40:44 +0000 Subject: [Koha-bugs] [Bug 9234] Koha's search code needs to be rewritten In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9234 Bug 9234 depends on bug 7607, which changed state. Bug 7607 Summary: Advanced search: Index and search term don't match when leaving fields empty https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:40:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:40:44 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 Bug 25548 depends on bug 7607, which changed state. Bug 7607 Summary: Advanced search: Index and search term don't match when leaving fields empty https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7607 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 17:44:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 16:44:38 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #33 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 18:24:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 17:24:04 +0000 Subject: [Koha-bugs] [Bug 26369] Set use_zebra_facets to 0 in the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26369 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- Hi :) My two cents: I'm not sure it's worth it to add a more complex behavior (which might need offer an override) depending on the number of records for Zebra. Maybe it could be a warning in about.pl? Also, what can give the worst experience in the case where the admin won't find the root cause? The slow search or the bad facets? I don't know ^^" Question for a dev meeting? Question about the patch: shouldn't debian/templates/koha-conf-site.xml.in be modified also? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 18:42:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 17:42:30 +0000 Subject: [Koha-bugs] [Bug 25760] Holds Ratio report is not reporting on records with 1 hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25760 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Needs Signoff |Signed Off --- Comment #10 from Victor Grousset/tuxayo --- These patches are already signed off right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 18:52:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 17:52:46 +0000 Subject: [Koha-bugs] [Bug 26528] Koha return no result if there's invalid records in Z39.50/SRU server reply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26528 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #2 from Victor Grousset/tuxayo --- Hi :) Please can you provide the coordinates of the BNF SRU server? Unfortunately, I don't have them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 20:32:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 19:32:38 +0000 Subject: [Koha-bugs] [Bug 27209] New: Add Koha::Hold->set_pickup_location Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Bug ID: 27209 Summary: Add Koha::Hold->set_pickup_location Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org We need a clean and fully tested method to set a hold's pickup location. It should throw exceptions if: - No pickup location passed - The passed pickup location is not a valid one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 20:48:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 19:48:26 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27205 Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 [Bug 27205] Hold routes are not dealing with invalid pickup locations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 20:48:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 19:48:26 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27209 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 [Bug 27209] Add Koha::Hold->set_pickup_location -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 20:55:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 19:55:48 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 114356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114356&action=edit Bug 27209: Unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 20:55:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 19:55:52 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 114357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114357&action=edit Bug 27209: Add Koha::Hold->set_pickup_location This patch introduces a method to safely update a hold's pickup location. It will raise exceptionis if the passed parameters are invalid or absent. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS; Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 21:05:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 20:05:13 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 21:13:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 20:13:26 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27205 |18729 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 [Bug 27205] Hold routes are not dealing with invalid pickup locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 21:13:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 20:13:26 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27209 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 [Bug 27209] Add Koha::Hold->set_pickup_location -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 21:13:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 20:13:26 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27209 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 [Bug 27209] Add Koha::Hold->set_pickup_location -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 21:17:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 20:17:41 +0000 Subject: [Koha-bugs] [Bug 27210] New: Typo in patron-attr-types.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27210 Bug ID: 27210 Summary: Typo in patron-attr-types.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org When adding a new patron attribute, next to the 'Editable in OPAC' field, there is this sentence: (Requires above, does not work during self-registration if PatronSelfRegistrationVerifyByEmail **if** set.) Which should be (Requires above, does not work during self-registration if PatronSelfRegistrationVerifyByEmail **is** set.) To replicate: 1) Make sure the ExtendedPatronAttributes syspref is active 2) Go to Administration > Patron attribute types 3) Click New patron attribute type 4) Check the sentence next to the Editable in OPAC checkbox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 21:27:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 20:27:27 +0000 Subject: [Koha-bugs] [Bug 26128] Proxy Error while importing a large number of patrons (e.g. 6000 patrons) with Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26128 AspenCat Team changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 21:31:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 20:31:57 +0000 Subject: [Koha-bugs] [Bug 26128] Proxy Error while importing a large number of patrons (e.g. 6000 patrons) with Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26128 --- Comment #35 from AspenCat Team --- Fixing this bug would be helpful to our consortium. I don't know what the limit is on the number of patrons we can import. The process now is make the edits, save the file, run the import tool and wait (a very long time) to see if it will successfully load. If it doesn't load, open a ticket and send the file, update our own help ticket and then when loaded, check to see if changes were correct. If not, start over. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 21:57:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 20:57:17 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 114358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114358&action=edit Bug 27205: Check valid pickup location on PUT /holds/:hold_id This patch adds a test for valid pickup locations when updating a hold through the API. Tests are adjusted to reflect this change. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 21:58:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 20:58:34 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Tomás Cohen Arazi --- I submit this patch for review. If the approach is accepted, I will adjust the POST route too. The tests are obviously the difficult bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 22:10:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 21:10:44 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #19 from Michal Denar --- Hi Jonathan, I'm testing this patch. I think the testplan works, but I found a problem if I pull record from z39.50. Subfields order doesn't correspond to framework settings. What about the Batch item modification tool? Or the item editing form? How will we display the subfields order there? Alphabetically or based on the framework definition? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 22:11:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 21:11:10 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbit at rbit.cz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 22:23:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 21:23:30 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 George Williams (NEKLS) changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #2 from George Williams (NEKLS) --- We are having the same problem on Koha 19.05 and Chrome 87 for these pages: tools_batchMod-edit tools_stage-marc-import admin_preferences For admin_preferences the "Save all . . . preferences" buttons at the bottom of the page are covered by the language selector whenever the length of .col-sm-10.col-sm-push-2 is greater than the length of .col-sm-2.col-sm-pull-10 As far as I can tell, it's only happening on Chrome 87. I can't recreate the same problem on Firefox or older versions of Chrome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 22:26:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 21:26:13 +0000 Subject: [Koha-bugs] [Bug 27211] New: Shelving locations for holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27211 Bug ID: 27211 Summary: Shelving locations for holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Every library handles holds differently, but one thing remains the same through most, if not all...when a hold is triggered, it waits somewhere in the building. Some libraries might have more than one shelving location. One issue that has always been a problem for libraries that have automatically expired holds, or any library that has a cancelled hold. Unless someone is going through each of the holds on the hold shelf daily, how do you find the item? If you look up an held item that has automatically expired (guessing on this, as we don't do this), or an item that is cancelled, the item shows the regular shelving location and that it is AVAILABLE. This is of no help to staff or the patron. One solution might be to use the CART feature, and update the temporary location to reflect a given shelving location for holds. There are a few issues for using this feature: 1) the CART location reverts back to the permanent shelving location after X amount of days. This would have to be overridden to stick until the item is actually not being held and is checked in, and then go through the regular CART routine, if any. 2) When triggering a hold, the hold would have to know which shelving location is being used. We could either define a default location that could be changed to a select few locations (maybe a HOLDLOC table?), so the default could be used without extra steps, OR even further, a default shelving location defined for each desk (I know the desk feature is part of an upcoming Koha upgrade). If staff don't want the public to know that the item is on a public hold pickup shelf, the OPAC description could simply read "See staff for assistance". Thoughts? Is this doable? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 22:41:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 21:41:53 +0000 Subject: [Koha-bugs] [Bug 27212] New: Add column configuration to the acquisitions home page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27212 Bug ID: 27212 Summary: Add column configuration to the acquisitions home page Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org It would be helpful to be able to hide columns from the accounts table when viewing available funds on acqui-home.pl We're a single site library so we don't need the library column and we don't use the owner column. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 22:47:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 21:47:50 +0000 Subject: [Koha-bugs] [Bug 27213] New: Convert vendor search box to a dropdown Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27213 Bug ID: 27213 Summary: Convert vendor search box to a dropdown Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org Convert the vendor search box on acqui-home.pl to a dropdown so that it's possible to select a vendor from the list rather than having to type it in which would be more efficient. Also there are times when I don't remember the name of vendor and seeing it in the list of choices would be helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 11 23:05:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 11 Dec 2020 22:05:52 +0000 Subject: [Koha-bugs] [Bug 27214] New: Add column configuration to view of funds in acquisitions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27214 Bug ID: 27214 Summary: Add column configuration to view of funds in acquisitions Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org It would be helpful to be able to hide columns from the budgeth table when viewing funds on aqbudgets.pl. This table has columns for 'base-level amounts' and 'total amounts' which, in our case, display the same amounts. We'd like to be able to hide the columns we don't need in order to make the table cleaner, easier to read and improve the understanding of new employees in acquisitions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 03:01:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 02:01:40 +0000 Subject: [Koha-bugs] [Bug 27215] New: Halo Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27215 Bug ID: 27215 Summary: Halo Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: arieveliantano at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114359&action=edit Hshsh -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 05:17:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 04:17:53 +0000 Subject: [Koha-bugs] [Bug 27161] Base.pm complains about unitialized value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 Alvaro Cornejo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114295|0 |1 is obsolete| | --- Comment #5 from Alvaro Cornejo --- Created attachment 114360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114360&action=edit Base.pm patch to fix uninitialize variable error >From 32bfd2fe945e7aef6f489ddaf1c80be018622663 Mon Sep 17 00:00:00 2001 From: Alvaro Cornejo Date: Fri, 11 Dec 2020 23:02:06 -0500 Subject: [PATCH] Bug 27161: Base.pm complains about unitialized value This patch does validate that $metadata exists and is set in sub get_metadata TEST PLAN Before applying the patch tail plack error log and see errors like: Use of uninitialized value in subroutine entry at line 182 in Base.pm Apply the patch restart koha-common service tail plack error log and verify no more erros appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 06:12:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 05:12:40 +0000 Subject: [Koha-bugs] [Bug 26128] Proxy Error while importing a large number of patrons (e.g. 6000 patrons) with Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26128 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 06:38:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 05:38:02 +0000 Subject: [Koha-bugs] [Bug 27216] New: We are anonymous Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27216 Bug ID: 27216 Summary: We are anonymous Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: mr.l59exploit at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 114361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114361&action=edit Hai semua -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 08:20:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 07:20:35 +0000 Subject: [Koha-bugs] [Bug 27217] New: Hacked By ./AlfanXploit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27217 Bug ID: 27217 Summary: Hacked By ./AlfanXploit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: alfanajisetia at gmail.com QA Contact: testopia at bugs.koha-community.org Aku Vs Hatimu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 08:23:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 07:23:31 +0000 Subject: [Koha-bugs] [Bug 27218] New: Hacked By ./AlfanXploit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27218 Bug ID: 27218 Summary: Hacked By ./AlfanXploit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: alfanajisetia at gmail.com QA Contact: testopia at bugs.koha-community.org Aku Vs Hatimu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 08:25:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 07:25:40 +0000 Subject: [Koha-bugs] [Bug 27217] Hacked By ./AlfanXploit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27217 axgans changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alfanajisetia at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 08:26:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 07:26:41 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Nishath Ahmed changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |20.11 --- Comment #15 from Nishath Ahmed --- Dear Jonathan Druart, No I set a different user as AnonymousPatron in Global System Preferences and I want to delete other patrons like students and staff category. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 08:29:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 07:29:11 +0000 Subject: [Koha-bugs] [Bug 27220] New: Hacked By ./AlfanXploit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27220 Bug ID: 27220 Summary: Hacked By ./AlfanXploit Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: alfanajisetia at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114363&action=edit Hacked Aku Vs Hatimu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 08:48:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 07:48:21 +0000 Subject: [Koha-bugs] [Bug 27221] New: ./AlfanXploit Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27221 Bug ID: 27221 Summary: ./AlfanXploit Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: alfanajisetia at gmail.com Created attachment 114364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114364&action=edit Ax F -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 08:58:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 07:58:59 +0000 Subject: [Koha-bugs] [Bug 27222] New: ayolah bisa Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27222 Bug ID: 27222 Summary: ayolah bisa Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: faristjaharema00 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114365&action=edit bug ini -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 09:00:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 08:00:18 +0000 Subject: [Koha-bugs] [Bug 27222] ayolah bisa In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27222 --- Comment #1 from Mr.MetazX --- hai cok -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 09:01:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 08:01:09 +0000 Subject: [Koha-bugs] [Bug 27222] ayolah bisa In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27222 --- Comment #2 from Mr.MetazX --- (In reply to Mr.MetazX from comment #1) > hai cok -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 09:05:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 08:05:51 +0000 Subject: [Koha-bugs] [Bug 27223] New: Mr.MetazX Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27223 Bug ID: 27223 Summary: Mr.MetazX Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: faristjaharema00 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 114366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114366&action=edit IRI BILANG BOS Hai Cok -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 10:26:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 09:26:54 +0000 Subject: [Koha-bugs] [Bug 27224] New: We Are Anonymous Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27224 Bug ID: 27224 Summary: We Are Anonymous Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: chanelabidzar at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Hai ini aku -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:13:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:13:39 +0000 Subject: [Koha-bugs] [Bug 27215] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27215 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Halo |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:14:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:14:27 +0000 Subject: [Koha-bugs] [Bug 27216] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27216 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|We are anonymous |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:15:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:15:05 +0000 Subject: [Koha-bugs] [Bug 27217] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27217 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Hacked By ./AlfanXploit |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:15:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:15:45 +0000 Subject: [Koha-bugs] [Bug 27218] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27218 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Hacked By ./AlfanXploit |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:16:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:16:54 +0000 Subject: [Koha-bugs] [Bug 27220] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27220 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Hacked By ./AlfanXploit |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:17:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:17:39 +0000 Subject: [Koha-bugs] [Bug 27221] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27221 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|./AlfanXploit |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:18:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:18:22 +0000 Subject: [Koha-bugs] [Bug 27222] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27222 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ayolah bisa |SPAM Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:19:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:19:00 +0000 Subject: [Koha-bugs] [Bug 27223] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27223 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Mr.MetazX |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:19:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:19:33 +0000 Subject: [Koha-bugs] [Bug 27224] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|We Are Anonymous |SPAM Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:32:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:32:05 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer --- I don't feel like taking away the whole export functionality is a good solution. Especially if done for all tables and even those not containing monetary values. We just promoted the functionality to our libraries after the last update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:32:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:32:31 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:43:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:43:43 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #29 from Katrin Fischer --- Have to still read discussion, but I also am in favor of keeping stuff readable in templates to some extent. Using only variables in templates and having to look them up in a Perl script adds an extra step and will make it harder again for people to contribute simple changes. Also I foresee use of a lot of silly variable names with the amount of strings we have. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 11:52:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 10:52:49 +0000 Subject: [Koha-bugs] [Bug 27153] ElasticSearch should search keywords apostrophe blind In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27153 --- Comment #7 from Katrin Fischer --- Could we treat it ' as a space and 'no space' at the same time maybe? And how do we currently handle this with Zebra? I guess we'd want Don't Dont don t Pierre d'Anjou Pierre dAnjou Pierre d Anjou to be the same? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 12:04:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 11:04:39 +0000 Subject: [Koha-bugs] [Bug 27213] Convert vendor search box to a dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27213 --- Comment #1 from Katrin Fischer --- The issue here is that we have libraries with a few hundred vendors they use or have used (special libraries tend to have a lot). So a pull down would not work here. Could an auto-complete feature be helpful here? Or only displaying a pull down up to x vendors? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 12:06:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 11:06:25 +0000 Subject: [Koha-bugs] [Bug 27213] Convert vendor search box to a dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27213 --- Comment #2 from Katrin Fischer --- I know we do have some pull downs now and they are a bit problematic in some cases - would love some discussion about what works best and have that added to other spots as well! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 12:59:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 11:59:35 +0000 Subject: [Koha-bugs] [Bug 27225] New: We are anonymous Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27225 Bug ID: 27225 Summary: We are anonymous Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: chanelabidzar at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 114367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114367&action=edit Hai ini aku -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 13:00:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 12:00:47 +0000 Subject: [Koha-bugs] [Bug 27226] New: We are anonymous Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27226 Bug ID: 27226 Summary: We are anonymous Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: chanelabidzar at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 13:02:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 12:02:03 +0000 Subject: [Koha-bugs] [Bug 27226] We are anonymous In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27226 Mr.RAZ13 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chanelabidzar at gmail.com --- Comment #1 from Mr.RAZ13 --- Created attachment 114368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114368&action=edit Hai ini aku -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 13:05:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 12:05:40 +0000 Subject: [Koha-bugs] [Bug 27226] We are anonymous In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27226 --- Comment #2 from Mr.RAZ13 --- Created attachment 114369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114369&action=edit Hai ini aku -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 13:14:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 12:14:54 +0000 Subject: [Koha-bugs] [Bug 27225] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27225 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|We are anonymous |SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 13:15:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 12:15:50 +0000 Subject: [Koha-bugs] [Bug 27226] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27226 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|We are anonymous |SPAM Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 14:37:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 13:37:48 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114100|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 114370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114370&action=edit Bug 27133: (bug 19351 follow-up) Add missing "Copy no" header to relative's checkouts Test plan: Add a guarantee, go to the relative's checkouts list and confirm that the number of headers is not correct Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 15:16:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 14:16:02 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor at tuxayo.net QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | --- Comment #5 from Victor Grousset/tuxayo --- QA script ok, code ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 15:32:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 14:32:56 +0000 Subject: [Koha-bugs] [Bug 26797] Error when trying to access Relative Checkouts between Professional and Organizational patron categories In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26797 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #6 from Victor Grousset/tuxayo --- I have an organization (school) with a guarantee that doesn't have a firstname. (empty string, also tested with a patron created without firstname) But I don't have an error in the console and the table loads. What is missing in my test plan? https://picat.drycat.fr/aXxAy7eU.png I even tried with a library being the guarantee of a school. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 15:57:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 14:57:04 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- Even after restarting the services, the tests don't pass: kohadev-koha at kohadevbox:/kohadevbox/koha$ prove t/db_dependent/api/v1/holds.t t/db_dependent/api/v1/holds.t .. 10/11 # Failed test '400 Bad Request' # at t/db_dependent/api/v1/holds.t line 817. # got: '500' # expected: '400' # Failed test '400 Bad Request' # at t/db_dependent/api/v1/holds.t line 850. # got: '500' # expected: '400' # Looks like you failed 2 tests of 12. t/db_dependent/api/v1/holds.t .. 11/11 # Failed test 'edit() tests' # at t/db_dependent/api/v1/holds.t line 868. # Looks like you failed 1 test of 11. t/db_dependent/api/v1/holds.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/11 subtests Test Summary Report ------------------- t/db_dependent/api/v1/holds.t (Wstat: 256 Tests: 11 Failed: 1) Failed test: 11 Non-zero exit status: 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 16:42:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 15:42:23 +0000 Subject: [Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #2 from Victor Grousset/tuxayo --- Is there a test plan that would make sense for this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 16:57:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 15:57:14 +0000 Subject: [Koha-bugs] [Bug 26698] Hold can show as waiting and in transit at the same time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- Tried twice the test plan and at step 5 didn't got the issue. But got «Priority="In transit" and Pickup library="Item being transferred"» Does the issue still happens? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 12 20:20:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 12 Dec 2020 19:20:20 +0000 Subject: [Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice --- I believe Starman is not strictly required, as other PSGI servers should work as well. And we also have an option to run Koha as a Mojolicious application. Would it make sense to move it to the 'recommends' section of cpanfile instead ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 05:41:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 04:41:06 +0000 Subject: [Koha-bugs] [Bug 27227] New: Itailan PO: "your charges" typo Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27227 Bug ID: 27227 Summary: Itailan PO: "your charges" typo Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: john at voipsupport.it QA Contact: testopia at bugs.koha-community.org There is a typo in a localization string /usr/share/koha/misc/translator/po/it-IT-opac-bootstrap.po #: koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc:17 #, c-format msgid "your charges" msgstr "le mtue multe" Should be #: koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc:17 #, c-format msgid "your charges" msgstr "le tue multe" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 05:47:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 04:47:24 +0000 Subject: [Koha-bugs] [Bug 27228] New: Italian Translation typo Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27228 Bug ID: 27228 Summary: Italian Translation typo Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: john at voipsupport.it QA Contact: testopia at bugs.koha-community.org This is related to 27227 In the file /usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/it-IT/includes/usermenu.inc The text that contains "mtue" should be "tue" - le mtue multe
    3. + le tue multe
    3. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 06:04:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 05:04:33 +0000 Subject: [Koha-bugs] [Bug 27229] New: Italian translation of State Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27229 Bug ID: 27229 Summary: Italian translation of State Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: john at voipsupport.it QA Contact: testopia at bugs.koha-community.org In these files: /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/it-IT/includes/member-main-address-style.inc /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/it-IT/includes/member-alt-address-style.inc the Italian translation given for State is "Stato", but that is only going to be useful for Italian speakers living in a country divided into states (e.g. US, Germany). In Italy the geographical division used in mailing addresses after city is "province". Unless there are objections, I would just change it to the Italian translation of Province (Provincia). If there are useful cases for maintaining State, then I would favour as a second option changing to "State or Province" ("Stato o Provincia"). The change for both files is - [% END %] Stato: + [% END %] Provincia: -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 12:36:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 11:36:02 +0000 Subject: [Koha-bugs] [Bug 27228] Italian Translation typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27228 --- Comment #1 from Katrin Fischer --- Hi John, translations are maintained on translate.koha-community.org and any typos can be fixed there directly and usually don't need to be reported. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 12:38:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 11:38:05 +0000 Subject: [Koha-bugs] [Bug 27229] Italian translation of State In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27229 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Katrin Fischer --- Hi John, I suggest to bring this up on the koha-translate mailing list instead. This is were translation matters are discussed - you will probably not reach the Italian translators via bugzilla. Only very few people (like the QA manager) check on the newly reported bugs. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 13:04:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 12:04:07 +0000 Subject: [Koha-bugs] [Bug 27228] Italian Translation typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27228 --- Comment #2 from John Fawcett --- Hi Katrin thanks for the feedback. I'll modify the .po types there. What about typos in .pl or .tt files. I don't see that type of file on the translate site, only .po files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 13:05:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 12:05:18 +0000 Subject: [Koha-bugs] [Bug 27228] Italian Translation typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27228 --- Comment #3 from Katrin Fischer --- The template files you see locally are generated from the po files. The strings all come from the po files originally. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 13:07:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 12:07:56 +0000 Subject: [Koha-bugs] [Bug 27228] Italian Translation typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27228 John Fawcett changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from John Fawcett --- Closing this as .inc file strings are generated from .po as per previous comment -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 13:08:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 12:08:45 +0000 Subject: [Koha-bugs] [Bug 27227] Itailan PO: "your charges" typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27227 John Fawcett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from John Fawcett --- Closing this as .po files can be modified directly on translate site. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 13:09:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 12:09:57 +0000 Subject: [Koha-bugs] [Bug 27229] Italian translation of State In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27229 John Fawcett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #2 from John Fawcett --- Closing this as this is more appropriate to translate mailing list and if modification agreed, it can be done directly in .po files on translate site -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 14:42:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 13:42:44 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #221 from Katrin Fischer --- I've added a suggestion for this on the Koha 21.05 Road Map - please sign up if you are interested to finally get this one in :) https://annuel.framapad.org/p/koha_21.05_roadmap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 18:00:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 17:00:22 +0000 Subject: [Koha-bugs] [Bug 26897] Blank SIP message closes SIP server connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26897 Ed Veal changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal at mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 18:05:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 17:05:19 +0000 Subject: [Koha-bugs] [Bug 24387] Rename News tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24387 Ed Veal changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal at mckinneytexas.org --- Comment #7 from Ed Veal --- I support separating news and html customizations. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 18:38:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 17:38:53 +0000 Subject: [Koha-bugs] [Bug 26851] Overdue notices should not send a report to the library if there is no content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26851 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112650|0 |1 is obsolete| | --- Comment #2 from Victor Grousset/tuxayo --- Created attachment 114371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114371&action=edit Bug 26851: Don't generate a notice to library if no content To test: 1 - Check out an over due to a patron 2 - Set overdue triggers to a trigger less than number of days overdue 3 - Make sure the patron has no email 4 - Set content of ODUE notice to: [%# Comment will not print %] 5 - perl misc/cronjobs/overdue_notices.pl 6 - Check the message queue 7 - There is a notice sent to the library: "These messages were not sent directly to the patrons." With no messages 8 - Apply patch 9 - Repeat 10 - No new message generated Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 18:40:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 17:40:56 +0000 Subject: [Koha-bugs] [Bug 26851] Overdue notices should not send a report to the library if there is no content In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26851 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Needs Signoff |Signed Off --- Comment #3 from Victor Grousset/tuxayo --- It works :) QA question, is that expected for a space char in the content to cause the message to be sent? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 22:50:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 21:50:40 +0000 Subject: [Koha-bugs] [Bug 27230] New: purchase suggestion authorized value opac_sug doesn't show opac description Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 Bug ID: 27230 Summary: purchase suggestion authorized value opac_sug doesn't show opac description Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 13 22:53:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 21:53:45 +0000 Subject: [Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 --- Comment #1 from Donna --- In the purchase suggestion form on the OPAC, the reason for purchase, linked to opac_sug authorized value does not show the OPAC description label, it shows the description instead. To recreate: 1. Create an auth value in opac_sug, with different text for the description and OPAC description. 2. Go to the OPAC and open the purchase suggestion form. 3. Note in the Reason for purchase drop down, the descriptions appear, not the text entered in the OPAC description field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 00:44:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 13 Dec 2020 23:44:07 +0000 Subject: [Koha-bugs] [Bug 26685] Move Starman out of debian/control.in and into cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26685 --- Comment #4 from David Cook --- (In reply to Julian Maurice from comment #3) > I believe Starman is not strictly required, as other PSGI servers should > work as well. And we also have an option to run Koha as a Mojolicious > application. > Would it make sense to move it to the 'recommends' section of cpanfile > instead ? I think that your argument has merit, but if we want Koha to work out-of-the-box, we do need to provide a default requirement, which is going to be starman for the time being. Maybe we could put it as "recommends" in the cpanfile, and then keep "starman" in debian/control for koha-common and koha-full... and allow people to install whatever PSGI/Mojolicious server they want for koha-core... It seems that "C4/Installer/PerlModules.pm" and "debian/list-deps" won't process "recommends", so that could work... Perhaps something to discuss further.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 01:01:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 00:01:11 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #30 from David Cook --- (In reply to Julian Maurice from comment #27) > I really don't see how what you're describing is a better solution than what > we already have. This is looking worse actually. Correct me if I'm wrong but > are you're suggesting that > > [% t('Hello, World!') %] > > should be replaced by > > $template->param('hello_world_str' => fetch('hello_world_str')) > > in Perl script and > > [% hello_world_str %] > > in template ? I don't find that very clean. I would say that the latter example is actually much *cleaner*. I think that you mean that it is less *convenient*. A different example could be:

    [% opac_access_denied %]

    vs

    [% t('Sorry, the system doesn\'t think you have permission to access this page.') %]

    That being said... I suppose using t() does make it easier to automate string extraction from templates rather than forcing developers to put their strings into translation files and to reference them correctly in the Perl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 01:02:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 00:02:46 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #31 from David Cook --- (In reply to Julian Maurice from comment #27) > If we can't expect developers to use 8 functions, what can we expect from > them ? We can expect developers to follow consistent simple rules. > We can probably reduce the number of functions to 2: t and tn, and transform > the other ones into optional arguments of these 2 functions (the same as > drupal). But developers would now have to remember the name of the options. > (And the parser which extracts translatable strings would have to be > modified too) This sounds better to me. It is easier to lookup options for 2 functions than to lookup, compare, and contrast 8 different functions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 01:05:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 00:05:27 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #32 from David Cook --- (In reply to Katrin Fischer from comment #29) > Have to still read discussion, but I also am in favor of keeping stuff > readable in templates to some extent. Using only variables in templates and > having to look them up in a Perl script adds an extra step and will make it > harder again for people to contribute simple changes. Easier doesn't always mean better. > Also I foresee use of > a lot of silly variable names with the amount of strings we have. With DSpace, you see keys like this: "jsp.dspace-admin.eperson-edit.emailexists". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 01:24:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 00:24:29 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #33 from David Cook --- (In reply to Martin Renvoize from comment #28) > Just for documentation, we had a good discussion around this on IRC this > morning with a few options to think about.. discussion is around 8.13: > http://irc.koha-community.org/koha/2020-12-11#i_2316124 Looking at http://irc.koha-community.org/koha/2020-12-11#i_2316124, I'm thinking about separation of concerns... On one hand, using t() could make it easier for a frontend web designer to do their design in English and offload translations to others without worrying about the backend. On the other hand, using t() is looking quite complex and not designer-friendly. It really looks like we're trying to shoehorn a solution into the templates. Take the following example: [% tx('Published on {published_on} by {author}', { published_on = filter(date_var, 'KohaDates', options), author = filter(author, 'html') }) | html %] Compare it with this much simpler Vue.js i18n example: https://kazupon.github.io/vue-i18n/guide/formatting.html#named-formatting A lot of the i18n systems out there work based on this token idea. Now of course in the Koha version we're doing a lot of extra things. I'd actually argue that we shouldn't be using KohaDates in the templates and really should format the date in the Perl and then push the correctly formatted date to the template (ie view). After all, if we were getting the date by an AJAX call (say using Vue.js), we'd want the correct data, since we're just rendering it in the presentation layer of our application. Regarding html escaping, we'd just have that on by default. To avoid double-encoding, we could turn off the html filter at the function level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 01:34:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 00:34:12 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #34 from David Cook --- I reiterate though that I'm not an expert on this and I'm happy to defer to others. I'm just saying that the current proposal looks complex and difficult to use. Since the OPAC is much smaller than the Staff Interface, it's probably reasonable to experiment there. As Owen said on https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988#c50, it makes sense to try a proof-of-concept before trying to update everything, and it seems Julian opened this bug as that proof-of-concept (it probably would've been good to announce it as such but oh well). Maybe we'll even find that due to the complexity of the 8 functions that people try to make simpler text constructs so that they can just use t(). To quote Jonathan (from ages ago), let's focus on code rather than on talk. I'm sure we could endlessly debate this one back and forth and never get anywhere. So why don't we just move forward and see how we go? (The only downside to that approach is that a new release isn't for half a year.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 01:44:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 00:44:04 +0000 Subject: [Koha-bugs] [Bug 26128] Proxy Error while importing a large number of patrons (e.g. 6000 patrons) with Plack In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26128 --- Comment #36 from David Cook --- It's unlikely that I'm going to work on this any time soon, since this doesn't impact any of my clients and I have other priorities. At this point, I'd suggest a temporary workaround of requesting a high ProxyTimeout, or asking one's vendor to create a more robust patron import. If someone sponsored the development, I could work on it, although I'd need to take some time to analyze the code to estimate the effort/cost involved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 01:46:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 00:46:08 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #17 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #15) > Why was the shebang changed in /debian/koha-common.postinst ? > > -#!/bin/sh > +a!/bin/sh That's definitely a vim typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 01:47:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 00:47:16 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #18 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #16) > 13. Review "The following NEW packages will be installed" and note > rabbitmq-server is included > > Not included right? Hopefully... October feels a long time ago. I'd probably mark this as Failed QA. I doubt I'm going to work on it again though. Plus, I think that this is handled by a different bug now anyway... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 01:54:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 00:54:25 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 --- Comment #10 from David Cook --- (In reply to Jonathan Druart from comment #9) > There is "Failed to connect: Error connecting to localhost:61613: Cannot > assign requested address at /usr/share/perl5/Net/Stomp.pm line 27.; giving > up at /usr/share/perl5/Net/Stomp.pm line 27" that is raised by the > constructor. > So you are right, not by $stomp->connect but already by our > Koha::BackgroundJob->connect. > Hmm, did you get that when RabbitMQ was down? What if RabbitMQ is up but the auth details are wrong? I feel like I didn't get an exception in that latter case. > It hasn't been advertised by the commit message, I think it need discussion > and tests are missing. Can we move this part to its own bug report? I suppose so. I don't really have the stamina at the moment to work on anything, so happy to just have it moved to Failed QA as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 02:52:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 01:52:22 +0000 Subject: [Koha-bugs] [Bug 27161] Base.pm complains about unitialized value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 Alvaro Cornejo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 08:34:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 07:34:04 +0000 Subject: [Koha-bugs] [Bug 26528] Koha return no result if there's invalid records in Z39.50/SRU server reply In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26528 --- Comment #3 from Didier Gautheron --- Hi, cf: https://doc.biblibre.com/koha/autour_de_koha/serveurs_z3950_sru and sql code adding it: https://git.biblibre.com/biblibre/tools/src/branch/master/koha/bnf_sru_aut.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 10:02:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 09:02:19 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #26 from Martin Renvoize --- OK, it's time for someone to put a pragmatic hat on here.. and it appears that person is me today. Whilst I agree with allot of what Joonas is saying, and he's really only trying to help by offering constructive criticism, I think this patch is reasonable and with the polishing that has already taken place I think it's reasonable to expect it to progress into Koha and as such I will take a look at testing myself with a view to signing off. Explanation of Joonas's views: Koha is a massive project with countless users worldwide and huge numbers of developers contributing to it. As a general rule, if you don't have a unit test covering a change you are making you cannot expect that feature to not get broken by future development. (This is NOT koha specific, a massive number of projects out there require a unit test as part of every/any submission). Joonas was merely making suggestions on how best to submit the code allowing for such unit tests. Yes, in an ideal world, C4:: would be gone and Koha:: would be fully unit tested and have fully replaced it with cleaner more modern code. Unfortunately, Koha is a victim of it's own success, having grown organically. We are lacking tests in many places, but things are always improving.. and it takes time to migrate everything (and most of that time is unfunded!) Koha is also a huge international project, so the terms are important and so is the flexibility of features... I've been caught by that one a number of times myself, where a feature is obvious to me, but I quickly learn it's not at all clear to my counterparts elsewhere or that for it to work for them it needs a little tweaking. I tend to try and code with that in mind these days and make the foundations as flexible as I can so others can build atop them. For example with this feature I personally would love to see it all controlled by system preferences.. i.e. the list of what constitutes a fee that may be statute-barred, and the timeings.. then simply passing a binary flag to the script would be required to enable it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 10:07:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 09:07:33 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 --- Comment #11 from Jonathan Druart --- Created attachment 114372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114372&action=edit Bug 26742: Remove die from connect The change was not advertised and it needs to be done on a separate bug report (+ test coverage) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 10:07:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 09:07:52 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 10:12:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 09:12:39 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #27 from Joonas Kylmälä --- In case someone is continuing to work on this I got one idea of alternative implementation for this that should accommodate everybody quite nicely: let's do options to delete the fees for all fee types which are older than X days and unpaid. Ideally we generate the options automatically based on the fees that Koha can generate (to reduce maintenance need). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 10:13:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 09:13:55 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #28 from Martin Renvoize --- Comment on attachment 114323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114323 Bug 27080: Add --statute-barred-fees option to cleanup_database.pl. Review of attachment 114323: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=27080&attachment=114323) ----------------------------------------------------------------- A few comments whilst I wrap my head around the requirements. ::: misc/cronjobs/cleanup_database.pl @@ +354,5 @@ > +if ($statue_barred_fees_days) { > + my $date = $dtf->format_datetime( DateTime->now->subtract(days => $statue_barred_fees_days) ); > + my $accountlines = Koha::Account::Lines->search({ > + amountoutstanding => { '>' => 0 }, > + status => 'RETURNED', 1) Do you not want to limit by "debit_type_code => 'OVERDUE'" to ensure you only catch overdue fines? 2) Limiting to "status => 'RETURNED'" will mean you miss accruing fines, fines fixed at the point of the lose of the item being reported and others 3) Is there any difference between a partially paid and completely unpaid fee in the legal context that needs taking care of? @@ +359,5 @@ > + date => { '<=' => $date } > + }); > + if ( $confirm ) { > + say "Purging " . $accountlines->count . " statute-barred fees from accountlines." if $verbose; > + $accountlines->delete; Hmm.. should this really be a delete rather than a recorded writeoff... the mere fact the function is found inside cleanup_database makes me think you know that you do want to delete entirely rather than record the writeoff (of a statute-barred type). You may want to also take care of offsets here, else you will be leaving behind related data I think. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 10:53:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 09:53:29 +0000 Subject: [Koha-bugs] [Bug 22405] Funds from inactive budgets appear in 'Funds' dropdown on acqui/orderreceive.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22405 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 10:56:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 09:56:47 +0000 Subject: [Koha-bugs] [Bug 26897] Blank SIP message closes SIP server connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26897 --- Comment #1 from Jonathan Druart --- Created attachment 114373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114373&action=edit Bug 26897: Don't close SIP connection when empty message is received -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 10:57:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 09:57:12 +0000 Subject: [Koha-bugs] [Bug 26897] Blank SIP message closes SIP server connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26897 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- Nick, can you test this patch where you faced the problem? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:11:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:11:05 +0000 Subject: [Koha-bugs] [Bug 22405] Funds from inactive budgets appear in 'Funds' dropdown on acqui/orderreceive.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22405 --- Comment #1 from Holly --- Funds from inactive budgets are also appearing under the 'Acquisition Information' area of a purchase suggestion. 1) Try to create a new purchase suggestion 2) Look in the 'Fund' dropdown under the 'Acquisition information' section 3) Funds from both active and inactive budgets will appear Should I open a new bug for this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:24:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:24:01 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Version|19.05 |unspecified See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21814 --- Comment #3 from Jonathan Druart --- Confirmed on master with Chrome 87. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:24:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:24:01 +0000 Subject: [Koha-bugs] [Bug 21814] System preferences save button can be hidden by language menu In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21814 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27099 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:37:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:37:11 +0000 Subject: [Koha-bugs] [Bug 27150] Batch delete items broke. Returns "0 item(s) deleted" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27150 --- Comment #2 from Stefan Norinder --- I think that the problem occurred due to a misconfiguration in our environment. Closing the bug report. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:37:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:37:46 +0000 Subject: [Koha-bugs] [Bug 27150] Batch delete items broke. Returns "0 item(s) deleted" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27150 Stefan Norinder changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:42:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:42:34 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 114374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114374&action=edit Bug 27209: (follow-up) Add ->is_pickup_location_valid This patch simply refactors the pickup location check into a method that can be called on its own. Tests are added, and the tests for ->set_pickup_location should pass unmodified. To test: 1. Apply the first two patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: tests pass 3. Apply this refactoring patch 4. Notice the tests are similar, but check for boolean output 5. Repeat 2 => SUCCESS: New tests pass, set_pickup_location() behavior unchanged. 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:42:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:42:53 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20032 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:42:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:42:53 +0000 Subject: [Koha-bugs] [Bug 20032] Switch single-column templates to Bootstrap grid: Tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20032 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27099 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:43:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:43:24 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27209 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 [Bug 27209] Add Koha::Hold->set_pickup_location -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:43:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:43:24 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27205 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 [Bug 27205] Hold routes are not dealing with invalid pickup locations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:53:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:53:29 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114358|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:55:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:55:07 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:56:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:56:10 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #4 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #3) > Even after restarting the services, the tests don't pass: Sorry for that, it was a missing dependency on the bug. Anyway, I updated the dependency, and this bug, so better start over. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 11:56:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 10:56:44 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 114375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114375&action=edit Bug 27205: Check valid pickup location on PUT /holds/:hold_id This patch adds a test for valid pickup locations when updating a hold through the API. Tests are adjusted to reflect this change. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 12:13:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 11:13:46 +0000 Subject: [Koha-bugs] [Bug 27177] t/db_dependent/api/v1/holds.t failing after bug 26988 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 12:18:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 11:18:36 +0000 Subject: [Koha-bugs] [Bug 27177] t/db_dependent/api/v1/holds.t failing after bug 26988 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 --- Comment #4 from Jonathan Druart --- I think you are actually missing bug 27002. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 12:24:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 11:24:09 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 --- Comment #5 from Didier Gautheron --- Created attachment 114376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114376&action=edit Bug 22038: Fix excel export if CurrencyFormat is FR DataTables excel export is broken if number decimal separator is a comma. Test plan: 1 - Set syspref CurrencyFormat to US 2 - Export as excel a table with decimal numbers, patrons list with fines for example. 3 - Open in libreoffice or excel, numbers are ok. 4 - Set syspref CurrencyFormat to FR 5 - Export and open again, number are wrong 25,10 is imported as 2510 6 - Apply patch 7 - Redo 1 to 4 8 - Excel export, number is 25,10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 12:25:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 11:25:25 +0000 Subject: [Koha-bugs] [Bug 27177] t/db_dependent/api/v1/holds.t failing after bug 26988 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart --- I haven't been digging very deep, but this patch is wrong: 416 return try { 417 my @pickup_locations = 418 $hold->itemnumber 419 ? @{ $hold->item->pickup_locations( { patron => $hold->patron } )->as_list() } 420 : @{ $hold->biblio->pickup_locations( { patron => $hold->patron } )->as_list() }; vs 216 sub pickup_locations { ... 231 return \@pickup_locations; So you are calling ->as_list on an arrayref (I bet this is not tested in the tests are you trying to fix). As said in the previous comment, look at bug 27002 instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 12:27:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 11:27:29 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 12:27:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 11:27:42 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 12:29:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 11:29:06 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 --- Comment #6 from Didier Gautheron --- (In reply to Katrin Fischer from comment #4) > I don't feel like taking away the whole export functionality is a good > solution. Especially if done for all tables and even those not containing > monetary values. We just promoted the functionality to our libraries after > the last update. Ok, replace , with . in excel export if syspref CurrencyFormat is FR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 12:49:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 11:49:10 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #29 from Timothy Alexis Vass --- > A few comments whilst I wrap my head around the requirements. We will need to include those requesting this, to look at answering these questions, they are important. Writing them off instead of deleting them makes sense. If they need to be removed, they can be so with the other 0-balance fees. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 12:54:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 11:54:29 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #12 from Tomás Cohen Arazi --- I think koha-create should handle this. Also, shouldn't we set a default vhost? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 13:25:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 12:25:15 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 13:34:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 12:34:19 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114375|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 114377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114377&action=edit Bug 27205: Check valid pickup location on PUT /holds/:hold_id This patch adds a test for valid pickup locations when updating a hold through the API. Tests are adjusted to reflect this change. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 13:47:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 12:47:24 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114356|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 114378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114378&action=edit Bug 27209: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 13:47:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 12:47:27 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114357|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 114379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114379&action=edit Bug 27209: Add Koha::Hold->set_pickup_location This patch introduces a method to safely update a hold's pickup location. It will raise exceptionis if the passed parameters are invalid or absent. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS; Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 13:47:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 12:47:30 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114374|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 114380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114380&action=edit Bug 27209: (follow-up) Add ->is_pickup_location_valid This patch simply refactors the pickup location check into a method that can be called on its own. Tests are added, and the tests for ->set_pickup_location should pass unmodified. To test: 1. Apply the first two patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: tests pass 3. Apply this refactoring patch 4. Notice the tests are similar, but check for boolean output 5. Repeat 2 => SUCCESS: New tests pass, set_pickup_location() behavior unchanged. 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 13:57:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 12:57:46 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:03:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:03:40 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:03:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:03:43 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 --- Comment #4 from Owen Leonard --- Created attachment 114381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114381&action=edit Bug 27099: Stage for import button not showing up In the latest version of Chrome, pages where the Humansmg library is included have a problem where the language footer obscures the bottom of the page. The problem traces back to some CSS in the Humanmsg library's CSS file: html, body { height: 100%; /* Damn you IE! */ } Removing the line doesn't have any ill effects that I can see in Chrome or Firefox, and it fixes the problem in Chrome. IE can be damned. To test you must have one or more translations enabled in the staff interface. - Apply the patch and clear your browser cache if necessary. - View pages in the staff interface which use the Humansmg library, e.g.: - Administration -> System preferences. Choose a category of preferences which will be numerous enough to require scrolling to reach the bottom of the page. - Tools -> Stage MARC records for import. Upload a file to display the form for staging the import. - Cataloging -> Advanced MARC editor On each page the language footer should not obscure the bottom of the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:16:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:16:08 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #13 from Jonathan Druart --- Yes, changes to koha-create, makefile.pl and rewrite-config.PL are missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:18:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:18:14 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:18:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:18:16 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:18:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:18:18 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:18:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:18:19 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:22:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:22:38 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #7 from Tomás Cohen Arazi --- Created attachment 114382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114382&action=edit Bug 27205: Check valid pickup location on POST /holds This patch adds a check for valid pickup location to the POST /holds route. A 400 code is returned if the supplied pickup library is not valid. To test: 1. Apply this patch 2. Run; $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:28:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:28:41 +0000 Subject: [Koha-bugs] [Bug 27231] New: Set focus on first search field in item search Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27231 Bug ID: 27231 Summary: Set focus on first search field in item search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When going to the item search page, the focus is on the search form at the top of the page (Circulation tab). It would be much nicer if the focus was on the first search option on this page (or more specifically the first text input field) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:42:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:42:50 +0000 Subject: [Koha-bugs] [Bug 22038] When exporting account table to excel, decimal is lost In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22038 Didier Gautheron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:43:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:43:36 +0000 Subject: [Koha-bugs] [Bug 27232] New: Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Bug ID: 27232 Summary: Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org >From the koha-translate ML: #. %1$s: END #: koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-contact-style.inc:162 #, c-format msgid "%s State:" msgstr "%s Provincia:" #. For the first occurrence, #. %1$s: END #: koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style.inc:177 #: koha-tmpl/intranet-tmpl/prog/en/includes/member-main-address-style.inc:168 #, c-format msgid "%s State: " msgstr "%s Stato: " We need to add a space between ":" and "" https://lists.koha-community.org/pipermail/koha-translate/2020-December/002815.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:46:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:46:44 +0000 Subject: [Koha-bugs] [Bug 27232] Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:46:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:46:47 +0000 Subject: [Koha-bugs] [Bug 27232] Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 --- Comment #1 from Jonathan Druart --- Created attachment 114383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114383&action=edit Bug 27232: Add missing space between : and in member-alt-contact-style.inc It caused the strings to appear twice in the po file Test plan: Apply this patch and regenerate the PO for a given language. Notice that the string "%s State: " only appears once in the PO file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:47:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:47:08 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114382|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 114384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114384&action=edit Bug 27205: Check valid pickup location on POST /holds This patch adds a check for valid pickup location to the POST /holds route. A 400 code is returned if the supplied pickup library is not valid. To test: 1. Apply this patch 2. Run; $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:48:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:48:48 +0000 Subject: [Koha-bugs] [Bug 27233] New: We Are Anonymous Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27233 Bug ID: 27233 Summary: We Are Anonymous Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: zhencyber2020 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 114385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114385&action=edit Index20.html -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:49:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:49:41 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:52:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:52:11 +0000 Subject: [Koha-bugs] [Bug 27233] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27233 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Summary|We Are Anonymous |SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:52:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:52:51 +0000 Subject: [Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:52:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:52:53 +0000 Subject: [Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 --- Comment #2 from Jonathan Druart --- Created attachment 114386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114386&action=edit Bug 27230: Display OPAC description for OPAC_SUG The authorised values OPAC_SUG displayed at the OPAC show the staff description. Test plan: 1. Create an auth value in opac_sug, with different text for the description and OPAC description. 2. Go to the OPAC and open the purchase suggestion form. 3. Note in the Reason for purchase drop down, the descriptions appear, the text entered in the OPAC description field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:53:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:53:18 +0000 Subject: [Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal Version|19.11 |unspecified Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:55:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:55:35 +0000 Subject: [Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1883 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1883 [Bug 1883] Managing Suggestions - authorised list of reasons why patron requesting book -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 14:55:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 13:55:35 +0000 Subject: [Koha-bugs] [Bug 1883] Managing Suggestions - authorised list of reasons why patron requesting book In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27230 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 15:39:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 14:39:58 +0000 Subject: [Koha-bugs] [Bug 14654] Add desk filter in Holds awaiting pickup list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 15:47:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 14:47:27 +0000 Subject: [Koha-bugs] [Bug 27177] t/db_dependent/api/v1/holds.t failing after bug 26988 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #6 from Andrew Fuerste-Henry --- Thanks, Jonathan. Closing this and pushing 27002 to 20.05 instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 15:49:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 14:49:18 +0000 Subject: [Koha-bugs] [Bug 27002] Make Koha::Biblio->pickup_locations return a Koha::Libraries resultset In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27002 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | --- Comment #19 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 15:51:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 14:51:57 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart --- What's the expected behaviour? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 15:55:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 14:55:35 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #3 from Jonathan Druart --- Created attachment 114387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114387&action=edit Bug 27196: Don't explode if item that is waiting if checked in by SIP -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 15:56:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 14:56:32 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #4 from Jonathan Druart --- Can you detail what's the expected behaviour, Nick? I am not sure this fix is correct (ie. do we want to start the transfer on a SIP operation?) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 15:56:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 14:56:38 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:03:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:03:04 +0000 Subject: [Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080 --- Comment #30 from Timothy Alexis Vass --- We have discussed the statute-barred fines further in our team. To clean up statute-barred fees would require the system to know how such are defined. This would need to be defined specifically for each library. For our purpose, these would the answers specific to Lund University Library: > 1) Do you not want to limit by "debit_type_code => 'OVERDUE'" to ensure you > only catch overdue fines? We only want those with debit_type_code => 'OVERDUE' > 2) Limiting to "status => 'RETURNED'" will mean you miss accruing fines, > fines fixed at the point of the lose of the item being reported and others We only want those with status => 'RETURNED' > 3) Is there any difference between a partially paid and completely unpaid > fee in the legal context that needs taking care of? They all need to be deleted. > Hmm.. should this really be a delete rather than a recorded write-off... They need to be deleted. > You may want to also take care of offsets here. The offsets also need to be deleted. - It could be that most libraries would prefer setting the balance to 0 rather than deleting them. - It could be that a few libraries would want different status and debit_type_code criteria. - There could be other requirements which are relevant to other libraries than ours. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:04:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:04:01 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #19 from Victor Grousset/tuxayo --- For the record, > 11. Review "The following NEW packages will be installed" and note > rabbitmq-server is included Indeed, rabbitmq-server is listed in: - The following additional packages will be installed: - The following NEW packages will be installed: > 13. Review "The following NEW packages will be installed" and note > rabbitmq-server is included Indeed, rabbitmq-server is listed in: - The following additional packages will be installed: - The following NEW packages will be installed: (In reply to David Cook from comment #18) > (In reply to Victor Grousset/tuxayo from comment #16) > > 13. Review "The following NEW packages will be installed" and note > > rabbitmq-server is included > > > > Not included right? > > Hopefully... October feels a long time ago. I don't know, the original text matches the test plan results, so maybe I just confused you ^^ > I'd probably mark this as Failed QA. > > I doubt I'm going to work on it again though. Plus, I think that this is > handled by a different bug now anyway... Failed QA (+unassigned) is because that would better indicate that this can be eventually rescued right? Compared to in discussion. (not an expert in statuses ^^) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:04:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:04:13 +0000 Subject: [Koha-bugs] [Bug 27072] Don't process staff interface CSS with rtlcss In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27072 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry --- Missing dependency, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:09:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:09:51 +0000 Subject: [Koha-bugs] [Bug 26819] Error when adding items to course reserves - can't view items in the staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26819 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #16 from Andrew Fuerste-Henry --- Missing dependencies, not backported for 20.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:14:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:14:35 +0000 Subject: [Koha-bugs] [Bug 27082] Problem when a basket has more of 20 orders with uncertain price In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27082 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | Status|Pushed to master |Pushed to stable CC| |andrew at bywatersolutions.com --- Comment #14 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:14:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:14:42 +0000 Subject: [Koha-bugs] [Bug 27082] Problem when a basket has more of 20 orders with uncertain price In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27082 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:19:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:19:49 +0000 Subject: [Koha-bugs] [Bug 27070] Elasticsearch - with Elasticsearch 6 searches failing unless all terms are in the same field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27070 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | --- Comment #15 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:19:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:19:55 +0000 Subject: [Koha-bugs] [Bug 27070] Elasticsearch - with Elasticsearch 6 searches failing unless all terms are in the same field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27070 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:22:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:22:11 +0000 Subject: [Koha-bugs] [Bug 27026] New circulation rule "Days mode" values are not explained anywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #21 from Andrew Fuerste-Henry --- Missing dependencies, not backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:27:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:27:45 +0000 Subject: [Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #34 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:27:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:27:52 +0000 Subject: [Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:28:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:28:43 +0000 Subject: [Koha-bugs] [Bug 27016] Make the pickup locations dropdowns use Select2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27016 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:30:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:30:17 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:30:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:30:19 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:30:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:30:22 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114311|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:30:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:30:43 +0000 Subject: [Koha-bugs] [Bug 26672] Create metapackage to install Koha and all its dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26672 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #29 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05.x, please rebase if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:30:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:30:53 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 114388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114388&action=edit Bug 18729: Add PUT /holds/{hold_id}/pickup_priority Bug 18729: Fix return type Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:30:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:30:58 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 114389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114389&action=edit Bug 18729: Add more tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:31:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:31:04 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 114390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114390&action=edit Bug 18729: (follow-up) Adjust API to new spec The previous patch introduces some behavioural changes to the API, as well as the data types that need to be passed; all happens in the tests. This patch adapts the route so it complies with those changes: - JSON object containing pickup_library_id attribute is now passed back and forth. - The controller should take care of checking the pickup location is valid, using the available tools. To test: 1. Apply the patches, up to the tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => ERROR: Tests fail because the controller doesn't implement the desired behavior 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:31:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:31:11 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 114391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114391&action=edit Bug 18729: Adapt holds.js Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:33:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:33:07 +0000 Subject: [Koha-bugs] [Bug 27092] Remove note about "synced mirror" from the README.md In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27092 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | --- Comment #3 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:33:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:33:13 +0000 Subject: [Koha-bugs] [Bug 27092] Remove note about "synced mirror" from the README.md In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27092 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:40:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:40:14 +0000 Subject: [Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | CC| |andrew at bywatersolutions.com --- Comment #20 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:40:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:40:20 +0000 Subject: [Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:41:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:41:51 +0000 Subject: [Koha-bugs] [Bug 25534] Add ability to specifying and store a reason when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 --- Comment #94 from Andrew Fuerste-Henry --- Enhancement, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 16:42:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 15:42:08 +0000 Subject: [Koha-bugs] [Bug 27103] Adding a hold cancellation reason should not always send a notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27103 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry --- Missing dependencies, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 17:08:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 16:08:17 +0000 Subject: [Koha-bugs] [Bug 27070] Elasticsearch - with Elasticsearch 6 searches failing unless all terms are in the same field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27070 --- Comment #16 from Nick Clemens --- There is an issue here, this breaks searching with Elasticsearch 5.x It may be okay, ES5 is no longer supported, so this may be the point at which we want to support only Es6+, but we will need to announce that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 17:10:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 16:10:19 +0000 Subject: [Koha-bugs] [Bug 27044] Deprecate core support for PayPal payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27044 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #12 from Andrew Fuerste-Henry --- Not backporting to 20.05, request if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 17:23:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 16:23:08 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 17:23:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 16:23:10 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114387|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 114392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114392&action=edit Bug 27196: Don't explode if item that is waiting if checked in by SIP Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 17:25:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 16:25:45 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #6 from Nick Clemens --- (In reply to Jonathan Druart from comment #4) > Can you detail what's the expected behaviour, Nick? > I am not sure this fix is correct (ie. do we want to start the transfer on a > SIP operation?) I believe this is the expected behaviour, it should mimic what happens when a hold is found in general via sip - all you have done is prevent an error, not changed behaviour -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:17:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:17:55 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:18:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:18:21 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:18:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:18:44 +0000 Subject: [Koha-bugs] [Bug 19351] Add copynumber in the checkouts table in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19351 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:18:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:18:45 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Bug 27133 depends on bug 19351, which changed state. Bug 19351 Summary: Add copynumber in the checkouts table in staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19351 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:22 +0000 Subject: [Koha-bugs] [Bug 25138] Terminology: Point of sale should use library instead of branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25138 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:22 +0000 Subject: [Koha-bugs] [Bug 24823] Drop Catmandu dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:23 +0000 Subject: [Koha-bugs] [Bug 26309] Elasticsearch cxn_pool must be configurable (again) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26309 Bug 26309 depends on bug 24823, which changed state. Bug 24823 Summary: Drop Catmandu dependency https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:23 +0000 Subject: [Koha-bugs] [Bug 25955] compare_es_to_db.pl broken by drop of Catmandu dependency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25955 Bug 25955 depends on bug 24823, which changed state. Bug 24823 Summary: Drop Catmandu dependency https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24823 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:24 +0000 Subject: [Koha-bugs] [Bug 13547] Item field 'Materials specified' would be useful to see in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13547 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:24 +0000 Subject: [Koha-bugs] [Bug 24211] Compress/uncompress translation files In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24211 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:25 +0000 Subject: [Koha-bugs] [Bug 25279] Make the cities list use the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:25 +0000 Subject: [Koha-bugs] [Bug 25288] Make the libraries list use the API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25288 Bug 25288 depends on bug 25279, which changed state. Bug 25279 Summary: Make the cities list use the API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25279 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:26 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:26 +0000 Subject: [Koha-bugs] [Bug 26460] Wrong line ending (semicolon vs comma) in request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 Bug 26460 depends on bug 23777, which changed state. Bug 23777 Summary: Text converted to html entity codes in cataloguing edit form https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:27 +0000 Subject: [Koha-bugs] [Bug 24696] We should output completion times in the updatedatabase output. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:27 +0000 Subject: [Koha-bugs] [Bug 27059] Adding elapsed times/durations to updatedatabase would be nice. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27059 Bug 27059 depends on bug 24696, which changed state. Bug 24696 Summary: We should output completion times in the updatedatabase output. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24696 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:27 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:28 +0000 Subject: [Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Bug 24631 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:28 +0000 Subject: [Koha-bugs] [Bug 24632] Plugins should support simple signing for security/verifiability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24632 Bug 24632 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:28 +0000 Subject: [Koha-bugs] [Bug 24634] Support display of changelog files for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24634 Bug 24634 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:29 +0000 Subject: [Koha-bugs] [Bug 24635] Support display of readme files for plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24635 Bug 24635 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:29 +0000 Subject: [Koha-bugs] [Bug 25952] Github search for plugin throwing errors due to API rate limits In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25952 Bug 25952 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:29 +0000 Subject: [Koha-bugs] [Bug 24633] Add support for gitlab searching of plugins In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24633 Bug 24633 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:29 +0000 Subject: [Koha-bugs] [Bug 26751] Fatal exception if only one repo defined In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26751 Bug 26751 depends on bug 23975, which changed state. Bug 23975 Summary: Add ability to search and install plugins from GitHub https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:30 +0000 Subject: [Koha-bugs] [Bug 5334] Omnibus: Add explicit foreign key constraints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Bug 5334 depends on bug 22887, which changed state. Bug 22887 Summary: authorised_values is missing a unique constraint on category + authorised_value https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:29 +0000 Subject: [Koha-bugs] [Bug 22887] authorised_values is missing a unique constraint on category + authorised_value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:30 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Bug 17809 depends on bug 22887, which changed state. Bug 22887 Summary: authorised_values is missing a unique constraint on category + authorised_value https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22887 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:30 +0000 Subject: [Koha-bugs] [Bug 24545] Replace Franklin Street by gnu.org/licenses in copyright In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:30 +0000 Subject: [Koha-bugs] [Bug 26401] xt/fix-old-fsf-address* are no longer needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26401 Bug 26401 depends on bug 24545, which changed state. Bug 24545 Summary: Replace Franklin Street by gnu.org/licenses in copyright https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24545 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:31 +0000 Subject: [Koha-bugs] [Bug 22774] Add ability to limit the number of purchase suggestions a patron may submit in a specified time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22774 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:31 +0000 Subject: [Koha-bugs] [Bug 25109] Add execution locking to Koha::Script In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25109 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:32 +0000 Subject: [Koha-bugs] [Bug 26645] t/Koha/Script.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26645 Bug 26645 depends on bug 25109, which changed state. Bug 25109 Summary: Add execution locking to Koha::Script https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25109 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:32 +0000 Subject: [Koha-bugs] [Bug 23571] Add measures to prevent concurrent execution of fines.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Bug 23571 depends on bug 25109, which changed state. Bug 25109 Summary: Add execution locking to Koha::Script https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25109 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:32 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:33 +0000 Subject: [Koha-bugs] [Bug 25464] Add ability to specify client IP and SIP account used in SIP2 logging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25464 Bug 25464 depends on bug 15253, which changed state. Bug 15253 Summary: Add Koha::Logger based logging for SIP2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:33 +0000 Subject: [Koha-bugs] [Bug 25510] Typo in koha-common.postinst causing shell errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25510 Bug 25510 depends on bug 15253, which changed state. Bug 15253 Summary: Add Koha::Logger based logging for SIP2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:34 +0000 Subject: [Koha-bugs] [Bug 25992] SIP2 server doesn't start - Undefined subroutine set_logger In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25992 Bug 25992 depends on bug 15253, which changed state. Bug 15253 Summary: Add Koha::Logger based logging for SIP2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:34 +0000 Subject: [Koha-bugs] [Bug 24380] Add option to recalculate fines upon a backdated return distinctly from `CalculateFinesOnReturn` In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:35 +0000 Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:35 +0000 Subject: [Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Bug 23070 depends on bug 23185, which changed state. Bug 23185 Summary: Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:36 +0000 Subject: [Koha-bugs] [Bug 25423] Methods update and empty from Koha::Objects are not class methods In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25423 Bug 25423 depends on bug 23185, which changed state. Bug 23185 Summary: Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:36 +0000 Subject: [Koha-bugs] [Bug 23112] Add circulation process to inter-library loans In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:37 +0000 Subject: [Koha-bugs] [Bug 26114] ILL should mark status=RET only if a return happened In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26114 Bug 26114 depends on bug 23112, which changed state. Bug 23112 Summary: Add circulation process to inter-library loans https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:37 +0000 Subject: [Koha-bugs] [Bug 26115] Remove leftover Carp::Always In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26115 Bug 26115 depends on bug 23112, which changed state. Bug 23112 Summary: Add circulation process to inter-library loans https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:37 +0000 Subject: [Koha-bugs] [Bug 21190] Add logging of successful/unsuccessful login attempts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:38 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Bug 22794 depends on bug 21190, which changed state. Bug 21190 Summary: Add logging of successful/unsuccessful login attempts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21190 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:38 +0000 Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:39 +0000 Subject: [Koha-bugs] [Bug 26341] Database update for bug 21443 is not idempotent and will destroy settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26341 Bug 26341 depends on bug 21443, which changed state. Bug 21443 Summary: Add ability to exclude holidays when calculating rentals fees by time period https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:39 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:40 +0000 Subject: [Koha-bugs] [Bug 23204] Add script for exporting Elasticsearch mappings to YAML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:40 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Bug 19482 depends on bug 23204, which changed state. Bug 23204 Summary: Add script for exporting Elasticsearch mappings to YAML https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:41 +0000 Subject: [Koha-bugs] [Bug 22639] Elasticsearch ability export mappings and facets settings In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22639 Bug 22639 depends on bug 23204, which changed state. Bug 23204 Summary: Add script for exporting Elasticsearch mappings to YAML https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:42 +0000 Subject: [Koha-bugs] [Bug 24997] Test to ensure mappings.yaml is in the correct order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24997 Bug 24997 depends on bug 23204, which changed state. Bug 23204 Summary: Add script for exporting Elasticsearch mappings to YAML https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:42 +0000 Subject: [Koha-bugs] [Bug 25325] ElasticSearch mapping export lacks staff_client/opac fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25325 Bug 25325 depends on bug 23204, which changed state. Bug 23204 Summary: Add script for exporting Elasticsearch mappings to YAML https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:42 +0000 Subject: [Koha-bugs] [Bug 25337] Export/import of Elasticsearch configuration is lacking information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25337 Bug 25337 depends on bug 23204, which changed state. Bug 23204 Summary: Add script for exporting Elasticsearch mappings to YAML https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:42 +0000 Subject: [Koha-bugs] [Bug 26832] Elasticsearch mappings export should use UTF-8 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26832 Bug 26832 depends on bug 23204, which changed state. Bug 23204 Summary: Add script for exporting Elasticsearch mappings to YAML https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23204 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:43 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:43 +0000 Subject: [Koha-bugs] [Bug 8149] Deleting Records/Biblios Omnibus In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8149 Bug 8149 depends on bug 8132, which changed state. Bug 8132 Summary: Batch delete tool deletes items with holds on them https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:44 +0000 Subject: [Koha-bugs] [Bug 25469] Typo: Item does not belongs to your library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25469 Bug 25469 depends on bug 8132, which changed state. Bug 8132 Summary: Batch delete tool deletes items with holds on them https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:44 +0000 Subject: [Koha-bugs] [Bug 25718] Correct typo in additem.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25718 Bug 25718 depends on bug 8132, which changed state. Bug 8132 Summary: Batch delete tool deletes items with holds on them https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:44 +0000 Subject: [Koha-bugs] [Bug 24185] 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:45 +0000 Subject: [Koha-bugs] [Bug 26523] In reserve/request.pl biblioitemnumber is used where biblionumber is required. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26523 Bug 26523 depends on bug 24185, which changed state. Bug 24185 Summary: 'If all unavailable' state for 'on shelf holds' makes holds page very slow if there's a lot of items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24185 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:45 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:46 +0000 Subject: [Koha-bugs] [Bug 26846] serial-collections page should select the expected and late serials automatically In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26846 Bug 26846 depends on bug 17674, which changed state. Bug 17674 Summary: Allow UI to delete serials issues in batch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:47 +0000 Subject: [Koha-bugs] [Bug 26992] On serial collection page, impossible to delete issues and related items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26992 Bug 26992 depends on bug 17674, which changed state. Bug 17674 Summary: Allow UI to delete serials issues in batch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:47 +0000 Subject: [Koha-bugs] [Bug 24819] Add ability for librarians to choose a patron when entering a purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:47 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Bug 26738 depends on bug 24819, which changed state. Bug 24819 Summary: Add ability for librarians to choose a patron when entering a purchase suggestion https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24819 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:48 +0000 Subject: [Koha-bugs] [Bug 17268] Advanced cataloging editor - rancor - macros are lost when browser storage cleared In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:49 +0000 Subject: [Koha-bugs] [Bug 26929] Koha will only display the first 20 macros Advanced Editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26929 Bug 26929 depends on bug 17268, which changed state. Bug 17268 Summary: Advanced cataloging editor - rancor - macros are lost when browser storage cleared https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:49 +0000 Subject: [Koha-bugs] [Bug 26954] Display macros in Advanced Cataloging Editor in alphabetical order and add sort capability In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26954 Bug 26954 depends on bug 17268, which changed state. Bug 17268 Summary: Advanced cataloging editor - rancor - macros are lost when browser storage cleared https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:49 +0000 Subject: [Koha-bugs] [Bug 26955] Allow macros in Advanced Cataloging Editor to be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26955 Bug 26955 depends on bug 17268, which changed state. Bug 17268 Summary: Advanced cataloging editor - rancor - macros are lost when browser storage cleared https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:50 +0000 Subject: [Koha-bugs] [Bug 26964] The option to Save is not showing on the Advanced Editor when created a Macro In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26964 Bug 26964 depends on bug 17268, which changed state. Bug 17268 Summary: Advanced cataloging editor - rancor - macros are lost when browser storage cleared https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:50 +0000 Subject: [Koha-bugs] [Bug 25494] Warnings in advanced editor macros routes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25494 Bug 25494 depends on bug 17268, which changed state. Bug 17268 Summary: Advanced cataloging editor - rancor - macros are lost when browser storage cleared https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17268 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:50 +0000 Subject: [Koha-bugs] [Bug 23084] Replace grep {^$var$} with grep {$var eq $_} In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:51 +0000 Subject: [Koha-bugs] [Bug 23166] Simplify code related to orders in catalogue/*detail.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23166 Bug 23166 depends on bug 23084, which changed state. Bug 23084 Summary: Replace grep {^$var$} with grep {$var eq $_} https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:51 +0000 Subject: [Koha-bugs] [Bug 25137] PatronSelfRegistrationLibraryList results in empty branch list on opac-memberentry.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25137 Bug 25137 depends on bug 23084, which changed state. Bug 23084 Summary: Replace grep {^$var$} with grep {$var eq $_} https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23084 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:52 +0000 Subject: [Koha-bugs] [Bug 4461] Add a context-sensitive report a problem process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:52 +0000 Subject: [Koha-bugs] [Bug 25213] Notify reporter when an OPAC problem is resolved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25213 Bug 25213 depends on bug 4461, which changed state. Bug 4461 Summary: Add a context-sensitive report a problem process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:53 +0000 Subject: [Koha-bugs] [Bug 25214] It would be beneficial for patrons to be able to see their OPAC problem reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25214 Bug 25214 depends on bug 4461, which changed state. Bug 4461 Summary: Add a context-sensitive report a problem process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:53 +0000 Subject: [Koha-bugs] [Bug 25215] 'Report a problem' could be enhanced to become a generic 'Inquiry management' process. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25215 Bug 25215 depends on bug 4461, which changed state. Bug 4461 Summary: Add a context-sensitive report a problem process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:53 +0000 Subject: [Koha-bugs] [Bug 25626] Translation issues with OPAC problem reports (status and 'sent to') In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25626 Bug 25626 depends on bug 4461, which changed state. Bug 4461 Summary: Add a context-sensitive report a problem process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:53 +0000 Subject: [Koha-bugs] [Bug 25466] Review 'problem_reports' column names and types In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25466 Bug 25466 depends on bug 4461, which changed state. Bug 4461 Summary: Add a context-sensitive report a problem process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:53 +0000 Subject: [Koha-bugs] [Bug 25627] Move OPAC problem reports from administration to tools In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25627 Bug 25627 depends on bug 4461, which changed state. Bug 4461 Summary: Add a context-sensitive report a problem process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:54 +0000 Subject: [Koha-bugs] [Bug 26127] When reporting an Error from the OPAC, the URL does not display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26127 Bug 26127 depends on bug 4461, which changed state. Bug 4461 Summary: Add a context-sensitive report a problem process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:54 +0000 Subject: [Koha-bugs] [Bug 25582] Don't show OPAC problems entry on dashboard when there are no reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25582 Bug 25582 depends on bug 4461, which changed state. Bug 4461 Summary: Add a context-sensitive report a problem process https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:54 +0000 Subject: [Koha-bugs] [Bug 23871] Add check for 'title exists' to `search_for_data_inconsistencies.pl` In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23871 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:54 +0000 Subject: [Koha-bugs] [Bug 21010] Script to search for data inconsistencies [omnibus] In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21010 Bug 21010 depends on bug 23871, which changed state. Bug 23871 Summary: Add check for 'title exists' to `search_for_data_inconsistencies.pl` https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23871 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:55 +0000 Subject: [Koha-bugs] [Bug 26407] fix query in 'title exists' in `search_for_data_inconsistencies.pl` In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26407 Bug 26407 depends on bug 23871, which changed state. Bug 23871 Summary: Add check for 'title exists' to `search_for_data_inconsistencies.pl` https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23871 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:55 +0000 Subject: [Koha-bugs] [Bug 24476] Allow patrons to opt-out of auto-renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:56 +0000 Subject: [Koha-bugs] [Bug 25029] AllowPatronToControlAutorenewal needs to have a disable setting In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25029 Bug 25029 depends on bug 24476, which changed state. Bug 24476 Summary: Allow patrons to opt-out of auto-renewal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:56 +0000 Subject: [Koha-bugs] [Bug 24988] autorenew_checkouts should default to yes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24988 Bug 24988 depends on bug 24476, which changed state. Bug 24476 Summary: Allow patrons to opt-out of auto-renewal https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24476 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:56 +0000 Subject: [Koha-bugs] [Bug 23590] Add the ability to change the manager of a suggestion and notify the new manager In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:57 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Bug 23991 depends on bug 23590, which changed state. Bug 23590 Summary: Add the ability to change the manager of a suggestion and notify the new manager https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:57 +0000 Subject: [Koha-bugs] [Bug 26898] Notify new manager when updating suggestions from suggestions homepage In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26898 Bug 26898 depends on bug 23590, which changed state. Bug 23590 Summary: Add the ability to change the manager of a suggestion and notify the new manager https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:57 +0000 Subject: [Koha-bugs] [Bug 24887] columns of suggestions need to be renamed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24887 Bug 24887 depends on bug 23590, which changed state. Bug 23590 Summary: Add the ability to change the manager of a suggestion and notify the new manager https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:57 +0000 Subject: [Koha-bugs] [Bug 22784] Add the ability to archive purchase suggestions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Bug 22784 depends on bug 23590, which changed state. Bug 23590 Summary: Add the ability to change the manager of a suggestion and notify the new manager https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:57 +0000 Subject: [Koha-bugs] [Bug 26738] Unable to change manager of purchase suggestion In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26738 Bug 26738 depends on bug 23590, which changed state. Bug 23590 Summary: Add the ability to change the manager of a suggestion and notify the new manager https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:58 +0000 Subject: [Koha-bugs] [Bug 20415] Remove UseKohaPlugins system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:59 +0000 Subject: [Koha-bugs] [Bug 20396] Omnibus: Cleanup Koha and fight feature creep In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 Bug 20396 depends on bug 20415, which changed state. Bug 20415 Summary: Remove UseKohaPlugins system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:26:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:26:59 +0000 Subject: [Koha-bugs] [Bug 25131] Web installer broken if enable_plugin is set In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25131 Bug 25131 depends on bug 20415, which changed state. Bug 20415 Summary: Remove UseKohaPlugins system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:00 +0000 Subject: [Koha-bugs] [Bug 26908] EDI vendor accounts edit no longer allows plugins to be selected for an account In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26908 Bug 26908 depends on bug 20415, which changed state. Bug 20415 Summary: Remove UseKohaPlugins system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20415 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:00 +0000 Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:00 +0000 Subject: [Koha-bugs] [Bug 24492] Add a 'library cashup' workflow to the point of sale system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24492 Bug 24492 depends on bug 24082, which changed state. Bug 24082 Summary: Add a 'refund' option to anonymous payments https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:00 +0000 Subject: [Koha-bugs] [Bug 17374] Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:01 +0000 Subject: [Koha-bugs] [Bug 26916] Allow patron attributes in DefaultPatronSearchFields syspref and patron search dropdown In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 Bug 26916 depends on bug 17374, which changed state. Bug 17374 Summary: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17374 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:01 +0000 Subject: [Koha-bugs] [Bug 13881] Add ability to defined circulation desks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:02 +0000 Subject: [Koha-bugs] [Bug 24201] Attach desk to intranet session In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Bug 24201 depends on bug 13881, which changed state. Bug 13881 Summary: Add ability to defined circulation desks https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:03 +0000 Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:03 +0000 Subject: [Koha-bugs] [Bug 24821] Add percentage handling to discount process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24821 Bug 24821 depends on bug 24081, which changed state. Bug 24081 Summary: Add a 'discount' process to accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:03 +0000 Subject: [Koha-bugs] [Bug 24822] Add discount processing to paycollect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24822 Bug 24822 depends on bug 24081, which changed state. Bug 24081 Summary: Add a 'discount' process to accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:03 +0000 Subject: [Koha-bugs] [Bug 24849] Permissions checks are missing in borracount controller In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24849 Bug 24849 depends on bug 24081, which changed state. Bug 24081 Summary: Add a 'discount' process to accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:03 +0000 Subject: [Koha-bugs] [Bug 26541] Apply discount button misleading In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26541 Bug 26541 depends on bug 24081, which changed state. Bug 24081 Summary: Add a 'discount' process to accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:04 +0000 Subject: [Koha-bugs] [Bug 24812] Add permission for 'discount' process In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24812 Bug 24812 depends on bug 24081, which changed state. Bug 24081 Summary: Add a 'discount' process to accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:04 +0000 Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:05 +0000 Subject: [Koha-bugs] [Bug 23433] Make consistent use of patron-title.inc in hold confirmation dialogs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:05 +0000 Subject: [Koha-bugs] [Bug 26961] Patron name not shown at checkin if HidePatronName set to "Don't show" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26961 Bug 26961 depends on bug 23433, which changed state. Bug 23433 Summary: Make consistent use of patron-title.inc in hold confirmation dialogs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23433 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:05 +0000 Subject: [Koha-bugs] [Bug 21674] Data integrity not enforced for library groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:06 +0000 Subject: [Koha-bugs] [Bug 24741] Recent creation of unique index on library_groups erroneously removes rows In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24741 Bug 24741 depends on bug 21674, which changed state. Bug 21674 Summary: Data integrity not enforced for library groups https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21674 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:06 +0000 Subject: [Koha-bugs] [Bug 23794] Convert OpacMainUserBlock system preference to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:06 +0000 Subject: [Koha-bugs] [Bug 26050] [OMNIBUS] Convert system preferences to news block In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26050 Bug 26050 depends on bug 23794, which changed state. Bug 23794 Summary: Convert OpacMainUserBlock system preference to news block https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23794 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:06 +0000 Subject: [Koha-bugs] [Bug 23051] Add ability to optionally renew fine accruing items when all fines on item are paid off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:07 +0000 Subject: [Koha-bugs] [Bug 25508] Confusing renewal message when paying accruing fine with RenewAccruingItemWhenPaid turned off In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25508 Bug 25508 depends on bug 23051, which changed state. Bug 23051 Summary: Add ability to optionally renew fine accruing items when all fines on item are paid off https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:07 +0000 Subject: [Koha-bugs] [Bug 25717] Improve messages for automatic renewal errors In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25717 Bug 25717 depends on bug 23051, which changed state. Bug 23051 Summary: Add ability to optionally renew fine accruing items when all fines on item are paid off https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:08 +0000 Subject: [Koha-bugs] [Bug 26915] Koha explodes when writing off a fee with FinePaymentAutoPopup In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26915 Bug 26915 depends on bug 23051, which changed state. Bug 23051 Summary: Add ability to optionally renew fine accruing items when all fines on item are paid off https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:27:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:27:08 +0000 Subject: [Koha-bugs] [Bug 24897] Remove es-ES installer data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24897 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 18:33:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 17:33:27 +0000 Subject: [Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 19:28:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 18:28:20 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114388|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 19:28:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 18:28:25 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114389|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 19:28:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 18:28:29 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114390|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 19:28:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 18:28:34 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114391|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 19:29:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 18:29:34 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 114393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114393&action=edit Bug 18729: Add PUT /holds/{hold_id}/pickup_location This patch adds a route to overwrite the current pickup location. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 19:29:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 18:29:40 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 114394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114394&action=edit Bug 18729: Add more tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 19:29:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 18:29:45 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 114395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114395&action=edit Bug 18729: (follow-up) Adjust API to new spec The previous patch introduces some behavioural changes to the API, as well as the data types that need to be passed; all happens in the tests. This patch adapts the route so it complies with those changes: - JSON object containing pickup_library_id attribute is now passed back and forth. - The controller should take care of checking the pickup location is valid, using the available tools. To test: 1. Apply the patches, up to the tests 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => ERROR: Tests fail because the controller doesn't implement the desired behavior 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 19:29:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 18:29:50 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 114396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114396&action=edit Bug 18729: Adapt holds.js Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 19:30:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 18:30:07 +0000 Subject: [Koha-bugs] [Bug 27070] Elasticsearch - with Elasticsearch 6 searches failing unless all terms are in the same field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27070 --- Comment #17 from Victor Grousset/tuxayo --- EOL since 2019-03-11 IIUC https://www.elastic.co/support/eol -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 19:46:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 18:46:33 +0000 Subject: [Koha-bugs] [Bug 25674] Add RabbitMQ options to koha-create In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26742 Assignee|tomascohen at gmail.com |dcook at prosentient.com.au Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 [Bug 26742] Add configuration for message broker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 19:46:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 18:46:33 +0000 Subject: [Koha-bugs] [Bug 26742] Add configuration for message broker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25674 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 [Bug 25674] Add RabbitMQ options to koha-create -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 20:20:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 19:20:13 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 20:20:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 19:20:16 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114304|0 |1 is obsolete| | --- Comment #7 from David Nind --- Created attachment 114397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114397&action=edit Bug 26397: [20.05.x] opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. This patch is specifically for Koha 20.05.x. The bug does not appear in master. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 21:08:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 20:08:28 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114312|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 114398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114398&action=edit Bug 24398: Fix 500 when viewing a single news item at the OPAC Test plan: 0. Set the NewsAuthorDisplay preference to 'OPAC' or 'Both OPAC and staff client.' 1. Open the OPAC main page and click on an individual news item Without this patch you get an ugly 500 Template process failed: undef error - The method Koha::NewsItem->author_title is not covered by tests! With this patch applied you see the news with the author's info Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 22:21:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 21:21:10 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #5 from Victor Grousset/tuxayo --- As a step towards QA, here is another signoff. It even works with an account of an organization. (which only has a name field, but it's actually a surname, so it's normal that it works) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 22:40:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 21:40:23 +0000 Subject: [Koha-bugs] [Bug 27234] New: Indicate if item is reserved when loaning to localuse patron Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27234 Bug ID: 27234 Summary: Indicate if item is reserved when loaning to localuse patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When using the statistical patron to record localuse, there are no indications whether the items is reserved or already on loan. To test: 1) In Administration > Patron categories > New category, create a category called Local use and make sure to choose the Category type 'Statistical' 2) Go to Patrons > New patron and create a Local use patron 3) Place a hold on an item 4) Check out the item to the statistical local use patron --> Message says 'local use recorded' It would be nice if the system could alert the staff that the item is on hold while they have the item in hand. Otherwise, they shelve it and they have to get it again when they check the holds to pull list. In comparison, when using the checkin system to record local use, with RecordLocalUseOnReturn, the hold pop-up appears with the message 'local use recorded' also. Another comparison, if you try to check out an item that has a hold to another patron, the system will alert you that there is a hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 23:07:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 22:07:33 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #34 from Tomás Cohen Arazi --- (In reply to Victor Grousset/tuxayo from comment #33) > Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. It is needed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 23:11:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 22:11:14 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #35 from Tomás Cohen Arazi --- This did actually break sql reports with empty parameters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 23:18:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 22:18:00 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #35 from Katrin Fischer --- (In reply to David Cook from comment #32) > (In reply to Katrin Fischer from comment #29) > > Have to still read discussion, but I also am in favor of keeping stuff > > readable in templates to some extent. Using only variables in templates and > > having to look them up in a Perl script adds an extra step and will make it > > harder again for people to contribute simple changes. > > Easier doesn't always mean better. Not always, but I think in this case it applies. Forcing people to invent tons of variables will not make things more readable, but much likely less so. Koha is a very string heavy application. Look at the numbers in our po files on Pootle - I am an active translator. > > > Also I foresee use of > > a lot of silly variable names with the amount of strings we have. > > With DSpace, you see keys like this: > "jsp.dspace-admin.eperson-edit.emailexists". And you say that's easier? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 23:38:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 22:38:11 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #20 from David Cook --- (In reply to Victor Grousset/tuxayo from comment #19) > Failed QA (+unassigned) is because that would better indicate that this can > be eventually rescued right? Compared to in discussion. (not an expert in > statuses ^^) You're probably right. Although I keep thinking that Mason, myself, and others talked about how we're going to stay with "requires" for the time being. I can't find that conversation now though. Plus Bug 26672 provides some alternatives for people who don't want to install rabbitmq-server on the same server, although I'm not sure how functional those are in practice.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 23:38:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 22:38:23 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook at prosentient.com.au |koha-bugs at lists.koha-commun | |ity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 23:38:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 22:38:34 +0000 Subject: [Koha-bugs] [Bug 26741] Make rabbitmq-server suggested rather than required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26672 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 23:38:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 22:38:34 +0000 Subject: [Koha-bugs] [Bug 26672] Create metapackage to install Koha and all its dependencies In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26672 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26741 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 23:38:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 22:38:45 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #36 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #35) > (In reply to David Cook from comment #32) > > (In reply to Katrin Fischer from comment #29) > > > Have to still read discussion, but I also am in favor of keeping stuff > > > readable in templates to some extent. Using only variables in templates and > > > having to look them up in a Perl script adds an extra step and will make it > > > harder again for people to contribute simple changes. > > > > Easier doesn't always mean better. > > Not always, but I think in this case it applies. Forcing people to invent > tons of variables will not make things more readable, but much likely less > so. Koha is a very string heavy application. Look at the numbers in our po > files on Pootle - I am an active translator. > > > > > > Also I foresee use of > > > a lot of silly variable names with the amount of strings we have. > > > > With DSpace, you see keys like this: > > "jsp.dspace-admin.eperson-edit.emailexists". > > And you say that's easier? Yes! intranet.admin.libraries.list_title -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 23:42:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 22:42:06 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io --- Comment #36 from Agustín Moyano --- (In reply to Tomás Cohen Arazi from comment #35) > This did actually break sql reports with empty parameters. Yes, we just found out this was the reason why filtered reports didn't work as expected when leaving blank inputs... For example, If you define a report like this: select <> as lib, <> as itype, <> as cc, <> as date_from, <> as date_to, <> as invoice and submit the form with one parameter.. for example the one that says 'Invoice' the form posts to the report with the following query string parameters: reports: 41 phase: Run this report param_name: Library|branches:all sql_params: % param_name: Item type|itemtypes:all sql_params: % param_name: CC|CC:all sql_params: % param_name: Date from sql_params: param_name: Date to sql_params: param_name: Invoice sql_params: invoice_1 But after redirection, empty parameters are filtered, leaving things like this reports: 41 phase: Run this report param_name: Library|branches:all sql_params: % param_name: Item type|itemtypes:all sql_params: % param_name: CC|CC:all sql_params: % param_name: Date from param_name: Date to param_name: Invoice sql_params: invoice_1 Notice missing sql_params. This ended up the query to be built like this: select '%' as lib, '%' as itype, '%' as cc, 'invoice_1' as date_from, NULL as date_to, NULL as invoice notice that 'invoice_1' is placed in date_from instead of invoice column. This fix is more awesome than you realized, ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 23:43:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 22:43:18 +0000 Subject: [Koha-bugs] [Bug 25548] Package install Apache performs unnecessary redirects In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25548 --- Comment #37 from David Cook --- (In reply to Agustín Moyano from comment #36) > This fix is more awesome than you realized, ;) That's a good way to start the day! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 23:46:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 22:46:51 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #37 from Katrin Fischer --- (In reply to Tomás Cohen Arazi from comment #36) > (In reply to Katrin Fischer from comment #35) > > (In reply to David Cook from comment #32) > > > (In reply to Katrin Fischer from comment #29) > > > > Have to still read discussion, but I also am in favor of keeping stuff > > > > readable in templates to some extent. Using only variables in templates and > > > > having to look them up in a Perl script adds an extra step and will make it > > > > harder again for people to contribute simple changes. > > > > > > Easier doesn't always mean better. > > > > Not always, but I think in this case it applies. Forcing people to invent > > tons of variables will not make things more readable, but much likely less > > so. Koha is a very string heavy application. Look at the numbers in our po > > files on Pootle - I am an active translator. > > > > > > > > > Also I foresee use of > > > > a lot of silly variable names with the amount of strings we have. > > > > > > With DSpace, you see keys like this: > > > "jsp.dspace-admin.eperson-edit.emailexists". > > > > And you say that's easier? > > Yes! > > intranet.admin.libraries.list_title I really don't see the advantage of this. To me it adds an extra step with no visible win. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 14 23:56:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 22:56:49 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #38 from David Cook --- (In reply to Katrin Fischer from comment #35) > Not always, but I think in this case it applies. Forcing people to invent > tons of variables will not make things more readable, but much likely less > so. I think that we'll just have to agree to disagree on that one. The variables would be formulaic so they shouldn't be difficult to create. It would also make templates easier to wrangle, as you wouldn't have as much line wrapping and thick blocks of text adding bulk to the templates. > Koha is a very string heavy application. Look at the numbers in our po > files on Pootle - I am an active translator. I agree that the PO files are huge, but looking through them that are also lots of junk lines, duplicate translations, unnecessary translations, etc. Using tokens would cut down on a lot of that. I'm looking at ./misc/translator/po/fr-FR-staff-prog.po right now, and lots of these lines would be eliminated or reduced by using tokens. I think that we could work smarter rather than harder. > > > > > Also I foresee use of > > > a lot of silly variable names with the amount of strings we have. > > > > With DSpace, you see keys like this: > > "jsp.dspace-admin.eperson-edit.emailexists". > > And you say that's easier? Absolutely. I work with this style in DSpace and Keycloak and it's so easy. Also, it also makes it much easier to customize strings for existing installations, since you can update "string files" rather than updating templates which have been hard-coded with English strings. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 15 00:04:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 23:04:50 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #39 from David Cook --- (In reply to Katrin Fischer from comment #37) > I really don't see the advantage of this. To me it adds an extra step with > no visible win. Here are some random examples from DSpace and Koha. https://github.com/DSpace/DSpace/blob/dspace-6.3/dspace-jspui/src/main/webapp/tools/edit-community.jsp https://github.com/Koha-Community/Koha/blob/master/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt For DSpace, just do a Ctrl+F for "fmt:message". Personally, I think that the DSpace template is cleaner (notwithstanding the JSP block near the top but DSpace isn't perfect either). The template is easy to read. The tokens are logical. You can lookup keys in https://github.com/DSpace/DSpace/blob/dspace-6.3/dspace-api/src/main/resources/Messages.properties. Admittedly DSpace is smaller than Koha, but the Java model used by DSpace is used far and wide. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 15 00:10:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 23:10:09 +0000 Subject: [Koha-bugs] [Bug 26392] Wrap all translatable strings in opac-main.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26392 --- Comment #40 from David Cook --- But I reiterate... this is basically a philosophical discussion at this point. I'm not planning to do any work on Java style token-based translations, and Julian is doing work on the t() style translations, so we can just do it that way. It'll probably be fine. If there are problems later, then there are problems later. No system is perfect anyway. Plus, we're a decentralized community and don't have any roadmaps, so there's no point going in circles. Whoever is willing to do the work does the work, and if it works then it gets into Koha. The early coder gets the worm ;). At this point, I think that I'm going to stop commenting on this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 15 00:10:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 23:10:50 +0000 Subject: [Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 15 00:10:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 23:10:53 +0000 Subject: [Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114386|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 114399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114399&action=edit Bug 27230: Display OPAC description for OPAC_SUG The authorised values OPAC_SUG displayed at the OPAC show the staff description. Test plan: 1. Create an auth value in opac_sug, with different text for the description and OPAC description. 2. Go to the OPAC and open the purchase suggestion form. 3. Note in the Reason for purchase drop down, the descriptions appear, the text entered in the OPAC description field. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 15 00:24:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 23:24:07 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 15 00:24:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 14 Dec 2020 23:24:10 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114300|0 |1 is obsolete| | --- Comment #13 from Lucas Gass --- Created attachment 114400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114400&action=edit Bug 27124: JS error "select2Width is not defined" This patch changes the default width paramter passed to the select2 plugin. This allows the basic MARC editor's Select2 widgets to be styled differently than on other pages. To test, apply the patch and view various pages where the select2 plugin is used: - Basic MARC editor - Items edit - Batch item edit - Authority editor In each case check that the Select2 plugin works correctly to style fields like collection code and home library. On the basic MARC editor page these s should have a width that adjusts as the browser window changes. On other pages the width should be fixed. Check the browser console and confirm that there are no JavaScript errors. Update: Thanks to Julian for the suggested optimization Signed-off-by: Lucas Gass Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:02:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:02:11 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | Status|Signed Off |Passed QA Keywords|rel_20_11_candidate |rel_21_05_candidate --- Comment #16 from Josef Moravec --- QA script passed Bug fixed, no regression found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:02:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:02:46 +0000 Subject: [Koha-bugs] [Bug 27085] Corrections in overdue_notices.pl help text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27085 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:02:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:02:49 +0000 Subject: [Koha-bugs] [Bug 27085] Corrections in overdue_notices.pl help text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27085 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113970|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers --- Created attachment 114442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114442&action=edit Bug 27085: Corrections in overdue_notices.pl help text -library only deal with overdues from this library (repeatable : several libraries can be given) Should be Help text should also be proper sentences. To test: 0) Run misc/cronjobs/overdue_notices.pl -h 1) Check that the text is now: -library Only deal with overdues from this library. 2) Check that the rest of the help text are proper sentences, with leading capital letter and punctuation. 3) Sign off. Sponsored-by: Lunds Universitetsbibliotek Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:03:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:03:52 +0000 Subject: [Koha-bugs] [Bug 27085] Corrections in overdue_notices.pl help text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27085 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #4 from Fridolin Somers --- Fix makes sens. I corrected the commit message, see https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:06:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:06:14 +0000 Subject: [Koha-bugs] [Bug 22332] Limit to currently available items in home library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22332 Jaki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jaki.frisina at leblibrary.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:12:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:12:03 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:12:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:12:07 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114378|0 |1 is obsolete| | Attachment #114379|0 |1 is obsolete| | Attachment #114380|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 114443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114443&action=edit Bug 27209: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:13:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:13:05 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 --- Comment #8 from Kyle M Hall --- Created attachment 114444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114444&action=edit Bug 27209: Add Koha::Hold->set_pickup_location This patch introduces a method to safely update a hold's pickup location. It will raise exceptionis if the passed parameters are invalid or absent. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS; Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:13:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:13:08 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 --- Comment #9 from Kyle M Hall --- Created attachment 114445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114445&action=edit Bug 27209: (follow-up) Add ->is_pickup_location_valid This patch simply refactors the pickup location check into a method that can be called on its own. Tests are added, and the tests for ->set_pickup_location should pass unmodified. To test: 1. Apply the first two patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: tests pass 3. Apply this refactoring patch 4. Notice the tests are similar, but check for boolean output 5. Repeat 2 => SUCCESS: New tests pass, set_pickup_location() behavior unchanged. 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:14:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:14:46 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:14:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:14:49 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114377|0 |1 is obsolete| | Attachment #114384|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 114446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114446&action=edit Bug 27205: Check valid pickup location on PUT /holds/:hold_id This patch adds a test for valid pickup locations when updating a hold through the API. Tests are adjusted to reflect this change. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:15:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:15:00 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #10 from Kyle M Hall --- Created attachment 114447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114447&action=edit Bug 27205: Check valid pickup location on POST /holds This patch adds a check for valid pickup location to the POST /holds route. A 400 code is returned if the supplied pickup library is not valid. To test: 1. Apply this patch 2. Run; $ kshell k$ prove t/db_dependent/api/v1/holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:15:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:15:03 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114443|0 |1 is obsolete| | --- Comment #10 from Josef Moravec --- Created attachment 114448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114448&action=edit Bug 27209: Unit tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:15:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:15:08 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114444|0 |1 is obsolete| | --- Comment #11 from Josef Moravec --- Created attachment 114449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114449&action=edit Bug 27209: Add Koha::Hold->set_pickup_location This patch introduces a method to safely update a hold's pickup location. It will raise exceptionis if the passed parameters are invalid or absent. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS; Tests pass 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:15:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:15:13 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114445|0 |1 is obsolete| | --- Comment #12 from Josef Moravec --- Created attachment 114450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114450&action=edit Bug 27209: (follow-up) Add ->is_pickup_location_valid This patch simply refactors the pickup location check into a method that can be called on its own. Tests are added, and the tests for ->set_pickup_location should pass unmodified. To test: 1. Apply the first two patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: tests pass 3. Apply this refactoring patch 4. Notice the tests are similar, but check for boolean output 5. Repeat 2 => SUCCESS: New tests pass, set_pickup_location() behavior unchanged. 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:26:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:26:22 +0000 Subject: [Koha-bugs] [Bug 27244] items with a negative not for loan values are considered available in the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27244 --- Comment #2 from Lucas Gass --- (In reply to Jonathan Druart from comment #1) > Does it work on the staff interface? Jonathan, I just test it and no, it does not work in the staff client either. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:35:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:35:53 +0000 Subject: [Koha-bugs] [Bug 27161] Base.pm complains about unitialized value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- if ( $metadata & $metadata !~ "") second test is useless I think, if ($metadata) with skip undefined, empty string and 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:43:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:43:53 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:43:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:43:56 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114310|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 114451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114451&action=edit Bug 27117: Only place_holds permission is needed to adjust pickup locations The GET /pickup_locations route is requesting the whole reserveforothers permission whereas only the subpermission place_holds is needed. Test plan: 0. Don't apply this patch 1. Set the subpermission place_holds but modify_holds_priority 2. Edit a hold and click the pickup library dropdown list 3. You get a JS alert and log displays GET /api/v1/app.pl/api/v1/holds/5/pickup_locations 403 Forbidden 4. Apply this patch 5. Reload the page, click the dropdown list, modify the pickup location and save => Success! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 16:52:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 15:52:49 +0000 Subject: [Koha-bugs] [Bug 27232] Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers --- There is also Surname: in moremember.tt : https://git.koha-community.org/Koha-community/Koha/src/commit/ec1979a385cb35228d39d139d7c0bd8c685dd4a2/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt#L638 Creating : msgid "Surname: " So maybe better add a span in other places : Surname: It removes the %s which is not a real PO var, it must not be moved. What do you think ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 17:02:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 16:02:04 +0000 Subject: [Koha-bugs] [Bug 27035] Shows the number of results in a facets after facet selection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27035 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Indeed, number of results are useful before selecting a facet. After, it may be confusing and not really useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 17:34:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 16:34:39 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113128|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 114452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114452&action=edit Bug 26921: Don't generate an invalid custom cover image if the url cannot be generated In case a custom cover image url is used to generate the cover image of bibliographic records, we should not build one if the record does not have the necessary data. For instance if you have CustomCoverImagesURL set to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpb and a biblio does not have the isbn defined, we should not generate and empty image (empty or invalid src) Test plan: 0. Set CustomCoverImagesURL to https://covers.openlibrary.org/b/isbn/{isbn}-M.jpb Enable CustomCoverImages and OPACCustomCoverImages To highlight the issue you should disable LocalCoverImages and OPACLocalCoverImages. 1. Make sure you have some of your bibliographic records with a valid isbn 2. Make sure you have at least 1 bibliographic record without an isbn set 3. Visit the search result and detail views (OPAC and staff interfaces) => Without this patch you should see a "Cover image" link, and an empty block/div on the detail page => With this patch applied you should only see images when the url can be generated Note that the problem will persist if the isbn is not valid (ie. no image is generated) Sponsored-by: Orex Digital Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 17:35:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 16:35:02 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 17:47:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 16:47:03 +0000 Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113701|0 |1 is obsolete| | --- Comment #5 from Josef Moravec --- Created attachment 114453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114453&action=edit Bug 24519: Match paycollect form validation for change collection This patch adds form validation to the Point Of Sale payment page such that one cannot submit the form with a 'collected' value that is less than the 'owed' amount. Signed-off-by: Sally Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 17:47:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 16:47:22 +0000 Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:01:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:01:29 +0000 Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113685|0 |1 is obsolete| | --- Comment #16 from Josef Moravec --- Created attachment 114454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114454&action=edit Bug 14564: Set permissions on configuration backups This patch sets the group and group read permissions on configuration backups, so that they can be downloaded via the web staff interface. Test plan: 0. Apply the patch 1. cp debian/scripts/koha-dump /usr/sbin/koha-dump 2. koha-run-backups --days 2 --output /var/spool/koha 3. Note *.tar.gz backups in /var/spool/koha/kohadev now have root:kohadev-koha ownership and 640 permissions 4. vi /etc/koha/sites/kohadev/koha-conf.xml 5. Set backup_db_via_tools and backup_conf_via_tools to 1 6. echo 'flush_all' | nc -q 1 memcached 1121 7. koha-plack --restart kohadev 8. Go to http://localhost:8081/cgi-bin/koha/tools/export.pl 9. Click on "Export configuration" 10. Choose a file 11. Click Download configuration 12. Note that *.tar.gz file downloaded correctly Signed-off-by: David Cook Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:03:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:03:03 +0000 Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | Status|Signed Off |Passed QA --- Comment #17 from Josef Moravec --- This is definitely a bug. Now at least both backup files have same permissions which is good. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:24:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:24:55 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:24:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:24:59 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88295|0 |1 is obsolete| | --- Comment #83 from Alexis Ripetti --- Created attachment 114455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114455&action=edit Bug 12532 - Send emails to guarantee and guarantor Checks for the syspref "RedirectGuaranteeEmail" in Koha::Patrons::notice_email_address. When enabled, emails to a patron with a guarantor will be sent to both guarantor and guarantee. It does not affect values in the message_queue table. Test plan: Before applying 1) Search, or create, a patron with guarantor 2) Enable checkout emails 3) Checkout an item. An email should be sent only to the guarantee 4) Apply this patch 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' 7) Go through step 1) to 3). Email should now be sent to both. 8) Run t/db_dependant/Members.t Sponsored by: Ville de Victoriaville Bug 12532 - (follow-up) clean up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:25:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:25:18 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #84 from Alexis Ripetti --- Created attachment 114456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114456&action=edit Bug 12532 - Rebase and correction of the patch by adding the possibility of sending emails to several guarantors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:25:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:25:25 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 --- Comment #85 from Alexis Ripetti --- Created attachment 114457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114457&action=edit Bug 12532 - Correction of tests involving guarantorid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:27:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:27:46 +0000 Subject: [Koha-bugs] [Bug 27082] Problem when a basket has more of 20 orders with uncertain price In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27082 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor at tuxayo.net Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in| |19.11.13 --- Comment #15 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:32:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:32:41 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114455|0 |1 is obsolete| | --- Comment #86 from Alexis Ripetti --- Created attachment 114458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114458&action=edit Bug 12532 - Send emails to guarantee and guarantor Checks for the syspref "RedirectGuaranteeEmail" in Koha::Patrons::notice_email_address. When enabled, emails to a patron with a guarantor will be sent to both guarantor and guarantee. It does not affect values in the message_queue table. Test plan: Before applying 1) Search, or create, a patron with guarantor 2) Enable checkout emails 3) Checkout an item. An email should be sent only to the guarantee 4) Apply this patch 5) Run updatedatabase.pl 6) Enable 'RedirectGuaranteeEmail' 7) Go through step 1) to 3). Email should now be sent to both. 8) Run t/db_dependant/Members.t Sponsored by: Ville de Victoriaville Bug 12532 - (follow-up) clean up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:32:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:32:50 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88296|0 |1 is obsolete| | --- Comment #87 from Alexis Ripetti --- Created attachment 114459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114459&action=edit Bug 12532 - (follow-up) clean up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:32:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:32:55 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114456|0 |1 is obsolete| | --- Comment #88 from Alexis Ripetti --- Created attachment 114460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114460&action=edit Bug 12532 - Rebase and correction of the patch by adding the possibility of sending emails to several guarantors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:33:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:33:01 +0000 Subject: [Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114457|0 |1 is obsolete| | --- Comment #89 from Alexis Ripetti --- Created attachment 114461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114461&action=edit Bug 12532 - Correction of tests involving guarantorid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:42:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:42:39 +0000 Subject: [Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Michael Adamyk changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk at ckls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:45:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:45:57 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #244 from Chris Cormack --- Test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:49:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:49:10 +0000 Subject: [Koha-bugs] [Bug 27070] Elasticsearch - with Elasticsearch 6 searches failing unless all terms are in the same field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27070 --- Comment #20 from Victor Grousset/tuxayo --- Does this mean that for now, 19.11 and 20.05 will have to advertise (and test in the CI) ES 5 only? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 18:53:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 17:53:37 +0000 Subject: [Koha-bugs] [Bug 27254] New: Damaged items need more control over holds Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27254 Bug ID: 27254 Summary: Damaged items need more control over holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Currently, NOT_LOAN is setup so that negative values will allow holds and positive values will not. DAMAGED does not have this functionality, to my knowledge. AllowHoldsOnDamagedItems gives you an ON/OFF setting for DAMAGED items. It would be great if we did away with AllowHoldsOnDamagedItems and instead DAMAGED would function the same as NOT_LOAN in terms of positive and negative values distinguishing whether or not the item can be put on hold. This way, a library can determine if a damaged item is a lost cause and change it to a damaged status that can't be held. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 19:04:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 18:04:52 +0000 Subject: [Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #35 from Victor Grousset/tuxayo --- I doesn't seem to work on 19.11.x 1. apply 2. restart services 3. optional: prove t/db_dependent/Biblio.t (passes) 4. fill a record with 010 = ThisisgoingtobetoomanycharactersfortheLCCNfield 5. save 6. error: "Bibliographic record not found." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 19:05:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 18:05:58 +0000 Subject: [Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #36 from Victor Grousset/tuxayo --- *It doesn't Not backporting unless this is need and a fix is provided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 19:05:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 18:05:59 +0000 Subject: [Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Bug 27245 depends on bug 26518, which changed state. Bug 26518 Summary: Adding a record can succeed even if adding the biblioitem fails https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:00:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:00:20 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:00:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:00:23 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 --- Comment #4 from Owen Leonard --- Created attachment 114462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114462&action=edit Bug 27200: (follow-up) Browse search interface update This patch updates the browse search interface to confirm to new interface patterns in the Bootstrap 4 framework, especially in the form markup. The results list has been changed to a Bootstrap "Collapse" component configured as an accordion (https://getbootstrap.com/docs/4.5/components/collapse/#accordion-example). Instead of loading the bibliographic record results below the list of terms returned, the bibliographic results are now displayed in the "panel" expanded below the selected term. Subtitle has been added to the information displayed about the bibliographic record. To test you must be using ElasticSearch and the OpacBrowseSearch preference must be enabled. Apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the "Browse search" page in the OPAC. - Test various searches: Author, Subject, and Title. - When results are found, the should be displayed as a Bootstrap-styled accordion widget. Clicking any individual result should expand the panel containing the corresponding records. - Clicking the record link should open the bibliographic detail page in a new window. - When no results are found, a Bootstrap-style "alert" box should appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:06:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:06:36 +0000 Subject: [Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 --- Comment #37 from Victor Grousset/tuxayo --- Wait, I got confused. «Yes, that's the expected behaviour» Ok, will backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:08:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:08:02 +0000 Subject: [Koha-bugs] [Bug 27255] New: Authorized values does not allow you to provide a description for the category Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27255 Bug ID: 27255 Summary: Authorized values does not allow you to provide a description for the category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I am noticing that AV has descriptions for the categories that come with Koha, but when you create a category, you are not allowed to provide a description. This is probably an oversight, but I think it would be great if we could add descriptions to new or existing categories. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:25:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:25:19 +0000 Subject: [Koha-bugs] [Bug 27256] New: Add button on point of sale page fails on table paging Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Bug ID: 27256 Summary: Add button on point of sale page fails on table paging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The default paging for our DataTables is 20 items, so if we have more than 20 different items that can be sold via the point of sale page then the table of items will be paged. The 'add' button works perfectly for the first page or results, but if you navigate to the second page, or filter/search the the table and find an item from a subsequent page, the add button does nothing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:25:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:25:31 +0000 Subject: [Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:25:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:25:31 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 [Bug 27256] Add button on point of sale page fails on table paging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:25:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:25:37 +0000 Subject: [Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:25:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:25:42 +0000 Subject: [Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:30:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:30:34 +0000 Subject: [Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 --- Comment #1 from Martin Renvoize --- Created attachment 114463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114463&action=edit Bug 27256: Update click handler for point of sale This patch updates the click handler to bind to the table element in the DOM as aposed to the individual buttons by their classes. We then use the event propogation and filter on the button class to catch the clicks we want. Test plan 1/ Add 22 debit_types that can be sold to the system (or reduce the datatable paging size) 2/ Confirm that items on the second page of results cannot be added for sale on the point of sale page. 3/ Apply the patch 4/ Confirm items from the second table page can now be added correctly 5/ Clicking add when navigating to such an item should leave the items table unmodified. 6/ Clicking aa when the table was filtered should reset the filters bringing the table back to the first page 7/ Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:30:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:30:49 +0000 Subject: [Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:30:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:30:57 +0000 Subject: [Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:31:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:31:09 +0000 Subject: [Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:31:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:31:20 +0000 Subject: [Koha-bugs] [Bug 27256] Add button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:32:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:32:07 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:32:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:32:10 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114074|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 114464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114464&action=edit Bug 27109: Remove Replay action - not implemented Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:32:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:32:13 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114075|0 |1 is obsolete| | --- Comment #4 from David Nind --- Created attachment 114465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114465&action=edit Bug 27109: Improve labels on the background job views Replace "enqueued_on" with "Enqueued on", same for started_on and ended_on Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:36:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:36:50 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:36:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:36:52 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #1 from Nick Clemens --- Created attachment 114466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114466&action=edit Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:39:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:39:36 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #5 from David Nind --- Rather than "Enqueued" I think I would prefer "Queued". Enqueued is a valid English word, according to Oxford English Dictionary (https://www.lexico.com/definition/enqueue). However, it is not something in common usage or that I have come across before except in Koha. As this one improves the display, I've signed it off. I will add a new bug for changing the term and see what others think. Testing notes: - Applied patch: applied successfully - Reviewed diff, makes sense to me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 20:49:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 19:49:42 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 --- Comment #6 from Tomás Cohen Arazi --- (In reply to David Nind from comment #5) > Rather than "Enqueued" I think I would prefer "Queued". Enqueued is a valid > English word, according to Oxford English Dictionary > (https://www.lexico.com/definition/enqueue). However, it is not something in > common usage or that I have come across before except in Koha. As this one > improves the display, I've signed it off. I will add a new bug for changing > the term and see what others think. > > Testing notes: > - Applied patch: applied successfully > - Reviewed diff, makes sense to me I agree. Can you submit a follow-up on this bug for 'Queued'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 21:15:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 20:15:17 +0000 Subject: [Koha-bugs] [Bug 23966] Library transfer limits editor unusable for sites with many libraries and ccodes/itemtypes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 21:30:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 20:30:13 +0000 Subject: [Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Depends on| |23294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 [Bug 23294] Restore actual cost input field on order page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 21:30:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 20:30:13 +0000 Subject: [Koha-bugs] [Bug 23294] Restore actual cost input field on order page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23294 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27203 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 [Bug 27203] Order unitprice is not set anymore and totals are 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 21:57:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 20:57:03 +0000 Subject: [Koha-bugs] [Bug 27239] FRBRizeEditions is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27239 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 21:59:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 20:59:28 +0000 Subject: [Koha-bugs] [Bug 8948] MARC21 field 787 doesn't display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 HeinrichJBHeidenreich at gmx.de changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |HeinrichJBHeidenreich at gmx.d | |e Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 22:34:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 21:34:09 +0000 Subject: [Koha-bugs] [Bug 26518] Adding a record can succeed even if adding the biblioitem fails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26518 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in| |19.11.13 --- Comment #38 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 22:39:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 21:39:53 +0000 Subject: [Koha-bugs] [Bug 27092] Remove note about "synced mirror" from the README.md In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27092 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in| |19.11.13 Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor at tuxayo.net --- Comment #4 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 16 23:58:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 22:58:38 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass --- (In reply to Fridolin Somers from comment #5) > (In reply to Fridolin Somers from comment #3) > > > > Most important : > > Clicking on "Select all" selects the branchcode :O > > Do you reproduce this ? > Its a major issue no ? I cannot reproduce this. When I click 'Select All' the branchcode option does appear to be select (it gets a check) but if I load the registration form I am able to complete it. Also if I click 'Select All' and save then immediately reopen the modal you will see that branchcode is not selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 00:05:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 23:05:18 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #7 from Lucas Gass --- Can we do the same for PatronSelfRegistrationBorrowerUnwantedField? With all the hard work Nick did it would not be easy to add easily add the 'exclusions: branchcode' line to opac.pref now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 00:06:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 16 Dec 2020 23:06:27 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #8 from Lucas Gass --- (In reply to Lucas Gass from comment #7) > Can we do the same for PatronSelfRegistrationBorrowerUnwantedField? With all > the hard work Nick did it would not be easy to add easily add the > 'exclusions: branchcode' line to opac.pref now it would be easy* -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 01:03:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 00:03:59 +0000 Subject: [Koha-bugs] [Bug 27247] Missing highlighting in Quote of the day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 01:04:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 00:04:02 +0000 Subject: [Koha-bugs] [Bug 27247] Missing highlighting in Quote of the day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114432|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 114467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114467&action=edit Bug 27247: Re-add highlighting to the quote editor Caused by commmit 247dca306407ac9568344a0a37aca3bbcffc2468 Bug 23013: Upgrade DataTables in the staff client which removed -tr.even.selected td { - background-color: #D3D3D3; -} There was no more highlighting when trying to delete an imported quote, as there was before (see screenshot from the manual https://gitlab.com/koha-community/koha-manual/-/blob/master/source/images/tools/qotd/selectfordelete.png) It was, however, possible to delete imported quotes, you just don't see which ones you are deleting. Test plan: 1) Create a CSV with two columns first the name, then the quote (I've attached a CSV that I've done for testing purposes) 2) Go to Tools > Edit quotes for the QOTD feature 3) Click 'Import quotes' 4) Click 'Browse' and choose the CSV created earlier 5) Click on the id of a couple of quotes. Notice those lintes are highlighted Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 01:25:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 00:25:47 +0000 Subject: [Koha-bugs] [Bug 27079] UpdateFine adds refunds for fines paid off before return In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27079 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in| |19.11.13 Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #21 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 01:28:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 00:28:29 +0000 Subject: [Koha-bugs] [Bug 23475] Search context is lost when simple search leads to a single record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23475 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #37 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 01:32:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 00:32:01 +0000 Subject: [Koha-bugs] [Bug 27144] Cannot delete any patrons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #17 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 01:32:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 00:32:02 +0000 Subject: [Koha-bugs] [Bug 27145] Patron deletion via intranet doesn't handle exceptions well In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27145 Bug 27145 depends on bug 27144, which changed state. Bug 27144 Summary: Cannot delete any patrons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27144 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 01:38:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 00:38:53 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #10 from Aleisha Amohia --- I'm currently working on this, and a big goal is to make it work as a notice with the template toolkit syntax. I believe this depends on moving some of the old C4/Biblio.pm subroutines (GetMarcAuthors etc) into Koha/Biblio.pm. That work would be substantial and needs to be done first, in separate bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 02:53:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 01:53:17 +0000 Subject: [Koha-bugs] [Bug 27139] Search errors are incorrectly shown to users as no results found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #4 from David Cook --- (In reply to Fridolin Somers from comment #3) > I like the idea I've done more thinking this morning, and now I'm starting to think about just monitoring Zebra better. Possibly putting together a Koha plugin to act as a Prometheus exporter, so it would scan Zebra logs for errors and then let Prometheus pull that data into itself. It could then be interrogated in Prometheus, and we as developers could then track back issues and improve Koha's Zebra integration as a result. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 05:08:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 04:08:41 +0000 Subject: [Koha-bugs] [Bug 26199] Record matching rule match check should include Leader/LDR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 05:08:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 04:08:45 +0000 Subject: [Koha-bugs] [Bug 26199] Record matching rule match check should include Leader/LDR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 --- Comment #2 from David Cook --- Created attachment 114468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114468&action=edit Bug 26199: Include LDR for match check/match point This patch adds the ability to specify the LDR instead of a numeric tag when defining match checks in record matching rules. This is particularly useful for checking LDR6 "Type of record" when importing records. Test plan: 0. prove t/Matcher.t 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1 2. Click "Save" and choose "MARCXML" 3. Copy bib-1.marcxml to bib-1-mod.marcxml 4. Change "01344cam a22003014i 4500" to "01344cmm a22003014i 4500" 5. Go to http://localhost:8081/cgi-bin/koha/admin/matching-rules.pl?op=edit_matching_rule&matcher_id=3 6. Click "Add match check" 7. Fill out the match checks: Source: Tag: LDR Offset: 6 Length: 1 Target: Tag: LDR Offset: 6 Length: 1 8. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 9. Choose "bib-1-mod.marcxml" and click "Upload file" 10. Choose "KohaBiblio (999$c)" for "Record matching rule" 11. Click "Stage for import" 12. Click "Manage staged records" on resulting page 13. Note the "Match type" says "No match" 14. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 15. Choose "bib-1.marcxml" and click "Upload file" 16. Choose "KohaBiblio (999$c)" for "Record matching rule" 17. Click "Stage for import" 18. Click "Manage staged records" on resulting page 19. Note the Match type says "Match found" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 05:09:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 04:09:32 +0000 Subject: [Koha-bugs] [Bug 26199] Record matching rule match check should include Leader/LDR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 06:08:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 05:08:51 +0000 Subject: [Koha-bugs] [Bug 27257] New: Hai Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27257 Bug ID: 27257 Summary: Hai Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: hisyamnur533 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114469&action=edit Hai -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 07:10:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 06:10:08 +0000 Subject: [Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 07:18:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 06:18:03 +0000 Subject: [Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #18 from David Cook --- I was thinking about this idea just the other day... If you look at https://www.loc.gov/marc/bibliographic/ecbdcntf.html, you'll see that $0 can also be a URI. That could be pretty cool. It seems too that the $0 is repeatable so that you could have different identifiers... I guess so you could reference VIAF and something else? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 07:18:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 06:18:33 +0000 Subject: [Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #19 from David Cook --- (In reply to Katrin Fischer from comment #4) > I think another reason might be that Koha was using $9 when there was no $0 > subfield in MARC21 yet. Bingo. According to https://www.loc.gov/marc/bibliographic/ecbdcntf.html, the $0 was added (for this purpose) in 2007. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 07:23:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 06:23:12 +0000 Subject: [Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #20 from David Cook --- (In reply to David Cook from comment #18) > I was thinking about this idea just the other day... > > If you look at https://www.loc.gov/marc/bibliographic/ecbdcntf.html, you'll > see that $0 can also be a URI. That could be pretty cool. > > It seems too that the $0 is repeatable so that you could have different > identifiers... I guess so you could reference VIAF and something else? We could index a URI, so that Koha's bib to auth link search would still work... We could actually build in a RDF dereferencing system eventually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 07:54:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 06:54:10 +0000 Subject: [Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #21 from Johanna Räisä --- (In reply to David Cook from comment #20) > (In reply to David Cook from comment #18) > > I was thinking about this idea just the other day... > > > > If you look at https://www.loc.gov/marc/bibliographic/ecbdcntf.html, you'll > > see that $0 can also be a URI. That could be pretty cool. > > > > It seems too that the $0 is repeatable so that you could have different > > identifiers... I guess so you could reference VIAF and something else? > > We could index a URI, so that Koha's bib to auth link search would still > work... > > We could actually build in a RDF dereferencing system eventually. Do you mean putting Koha's internal link to authority linking subfield? We are using national metadata repository and mainly the URI in $0 subfield has a link to that. It might be a good idea that Koha would use URI in authority linking subfield also. We are facing problem with this $9 subfield because it is used in our national metadata repository for other things and it should not change if we are pulling data to Koha. This is why it would be nice to choose which subfield is used for the authority linking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 07:57:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 06:57:34 +0000 Subject: [Koha-bugs] [Bug 27050] Allow multiple category_codes in delete_patrons.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27050 Timothy Alexis Vass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |timothy_alexis.vass at ub.lu.s | |e -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 09:00:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 08:00:22 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #9 from Fridolin Somers --- (In reply to Lucas Gass from comment #6) > (In reply to Fridolin Somers from comment #5) > > (In reply to Fridolin Somers from comment #3) > > > > > > Most important : > > > Clicking on "Select all" selects the branchcode :O > > > > Do you reproduce this ? > > Its a major issue no ? > > I cannot reproduce this. When I click 'Select All' the branchcode option > does appear to be select (it gets a check) but if I load the registration > form I am able to complete it. Also if I click 'Select All' and save then > immediately reopen the modal you will see that branchcode is not selected. Indeed, disabled inputs are not posted in forms. But its very disturbing to see it checked in my opinion. I try to create a fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 09:07:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 08:07:10 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #10 from Fridolin Somers --- Created attachment 114470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114470&action=edit Bug 17364: (follow-up) Do not check excluded fields When clicking on "Select all" excluded fields are selected. Even if they are not saved into preference, this is disturbing. Test plan : 1) Edit BorroweUnwantedFields system preference 2) Click "Select all" 3) See that branchcode is not selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 09:08:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 08:08:31 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #11 from Fridolin Somers --- Was easy ^^ Maybe we need some CSS on excluded fields name, grey color for example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 09:10:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 08:10:36 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113239|0 |1 is obsolete| | --- Comment #12 from Fridolin Somers --- Created attachment 114471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114471&action=edit Bug 17364: Add ability to exclude some columns from selection for system preferences Bug 22844 Added the option to provide a modal for selecting database columns for system preferences Some system preferences are limited to a subset of the columns allowed. For instance, setting branchcode in BorrowerUnwantedFields prevents adding new patrons This patch allows for defining exclusions in the .pref file To test: 1 - Alter BorroweUnwantedFields and select branchcode 2 - Attempt to add a new patron 3 - Get a message like "Something went wrong. Check the logs" 4 - Apply patches 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Add a patron 9 - It succeeds Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 09:10:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 08:10:55 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114409|0 |1 is obsolete| | --- Comment #13 from Fridolin Somers --- Created attachment 114472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114472&action=edit Bug 17364: (follow-up) Add missing filter Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 09:11:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 08:11:27 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114470|0 |1 is obsolete| | --- Comment #14 from Fridolin Somers --- Created attachment 114473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114473&action=edit Bug 17364: (follow-up) Do not check excluded fields When clicking on "Select all" excluded fields are selected. Even if they are not saved into preference, this is disturbing. Test plan : 1) Edit BorroweUnwantedFields system preference 2) Click "Select all" 3) See that branchcode is not selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 09:12:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 08:12:03 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 --- Comment #15 from Fridolin Somers --- I signed 2 first patches, leaving NSO for my followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 09:17:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 08:17:23 +0000 Subject: [Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 Johanna Räisä changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114433|0 |1 is obsolete| | --- Comment #22 from Johanna Räisä --- Created attachment 114474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114474&action=edit Bug 17511 - Authority linking subfield The patch had wrong author information, replaced with my own. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 10:32:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 09:32:52 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements (concatenations, substrings, conditions...) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual --- Comment #59 from Katrin Fischer --- Appears sadly to be undocumented! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 10:35:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 09:35:27 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #11 from Katrin Fischer --- Could we imagine replacing the old subroutines by a more generic approach of accessing the information in the MARC record instead of moving them? Thinking of something like: [% record.245a %] We can actually do something similar in CSV profiles, but it appears sadly undocumented in the manual: Bug 12404 (the help file with the documentation was removed, but some examples in the comment of the bug) I think if we don't match the current output 100% that would actually be a good thing as the old routines sometimes display subfields that you don't really want to see in the notices, and it's all hard coded and not nice to use or change or format. So we will likely have more issues to deal with later on always coming back to these methods. And it could be really useful for other notices as well (later). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 10:59:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 09:59:51 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart --- Hello Aleisha, This is a very interesting part to move to the notice templates! However I am expecting it to be tricky, as you saw already :) Before starting to implement anything I would suggest you to come with a plan. I can provide you early feedback to see if we are starting with the best solution. In my opinion we should only pass Koha::Objects-based variables to the template. Reusing the existing variables will make us start with obsolete code (it will be harder to improve it in the future as the libraries will have this TT code in their templates). (In reply to Katrin Fischer from comment #11) > Could we imagine replacing the old subroutines by a more generic approach of > accessing the information in the MARC record instead of moving them? > > Thinking of something like: > > [% record.245a %] Says we are talking about GetMarcUrls, it could be something like: [% SET marc_record = biblio.metadata.record %] [% FOR f IN marc_record.field('856') %] [%# Then do something for every 856 field [% END %] But then you are going to rewrite the code that is in a subroutine to a TT syntax, that will be copy/pasted in different places. And it's not what we want, it's too error prone (no test coverage, dup of code). The only long term and viable solution is to move them to the Koha namespace. Have the Get* subroutines moved to Koha::Biblio methods, have the test coverage, replace the existing occurrences, and finally reuse them from the template notices. But this task is huge... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 11:55:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 10:55:49 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Looks good, however I think the Koha::Biblio method should not return a MARC::Field set, but instead hashrefs with the info you need. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 11:57:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 10:57:10 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add button on point of sale |"Add" button on point of |page fails on table paging |sale page fails on table | |paging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 11:58:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 10:58:51 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #13 from Jonathan Druart --- I would start with passing Koha::Biblios to the template and see how easy/hard it is to replace the existing template file with a notice template using the TT syntax. [% FOR biblio IN biblios %] [%# title and subtitle are easy to retrieve %] [%# authors, we loop on the MARC fields %] [%# isbn, we need Koha::Biblio->get_isbns %] [%# and so on... [% END %] First with send shelves at the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:04:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:04:43 +0000 Subject: [Koha-bugs] [Bug 13044] Deprecate old book drop mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #18 from Nick Clemens --- *** This bug has been marked as a duplicate of bug 14591 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:04:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:04:43 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #36 from Nick Clemens --- *** Bug 13044 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:09:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:09:12 +0000 Subject: [Koha-bugs] [Bug 27243] Add new patron column for date of last successful SIP2 authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 15504 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:09:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:09:12 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #30 from Jonathan Druart --- *** Bug 27243 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:13:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:13:10 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #5 from Katrin Fischer --- Thx Joubu for your comment! Took a first glance at the code too, but need to spend some more time. Problem is that $0 and $9 subfields are not MARC standard, but only used for Koha's EasyAnalytics feature, which we can't use as it clashes with our union catalog workflow. I want to check how it all fits together with our 773 not having either in comparison, to give you better feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:19:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:19:34 +0000 Subject: [Koha-bugs] [Bug 27238] Kohan koko signum In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27238 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:20:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:20:56 +0000 Subject: [Koha-bugs] [Bug 27232] Missing spaces in member-alt-contact-style.inc make some strings appearing twice in po In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27232 --- Comment #3 from Jonathan Druart --- Yes good idea, but feeling lazy to add the missing span tags. Feel free to follow-up :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:25:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:25:52 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #14 from Katrin Fischer --- Hi Aleisha, I think Joubu's right... after looking at the methods I realized that we need something easier to use for people in the templates and also something that will work with MARC21 and UNIMARC. Moving them one by one on separate bugs like you suggested is a good idea. Maybe we could use the feedback on bug 16522 or start with one to make sure we got a good pattern before moving all of them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:26:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:26:47 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:26:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:26:50 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114473|0 |1 is obsolete| | --- Comment #16 from Nick Clemens --- Created attachment 114475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114475&action=edit Bug 17364: (follow-up) Do not check excluded fields When clicking on "Select all" excluded fields are selected. Even if they are not saved into preference, this is disturbing. Test plan : 1) Edit BorroweUnwantedFields system preference 2) Click "Select all" 3) See that branchcode is not selected Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:28:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:28:43 +0000 Subject: [Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:36:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:36:24 +0000 Subject: [Koha-bugs] [Bug 27258] New: Rename BackgroundJobs => Tasks Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27258 Bug ID: 27258 Summary: Rename BackgroundJobs => Tasks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org We should make the change now it is fresh. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:38:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:38:13 +0000 Subject: [Koha-bugs] [Bug 27257] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27257 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Summary|Hai |SPAM -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:43:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:43:48 +0000 Subject: [Koha-bugs] [Bug 27258] Rename BackgroundJobs => Tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27258 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22417 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:43:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:43:48 +0000 Subject: [Koha-bugs] [Bug 22417] Add a task queue In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27258 [Bug 27258] Rename BackgroundJobs => Tasks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 12:43:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 11:43:48 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27258 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 13:31:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 12:31:55 +0000 Subject: [Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 --- Comment #2 from Nick Clemens --- Created attachment 114476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114476&action=edit Bug 27203: [alternate] Calculate tax based on ecost if unitprice not set There is code in populate_order_with_prices that is intended to use ecost over unitprice, it just doens't seem to be working. Making it more explicit seems to take care of the issue. To test: 1 - Create a basket 2 - Add an order line, don't set 'Actual cost: ', but use vendor price and a discount. 3 - Save 4 - Display all columns, 'Actual cost tax inc.' are GST columns aren't set. 5 - Apply batch 6 - Redo 1,2, 3 7 - Display all columns, GST is calculated correctly, unitprice remains 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:10:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:10:21 +0000 Subject: [Koha-bugs] [Bug 27258] Rename BackgroundJobs => Tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27258 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:24:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:24:42 +0000 Subject: [Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114435|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 114477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114477&action=edit Bug 27251: Rewrite QOTD with the Koha REST API This patch replace the QOTD editor with our new way to CRUD the adminitration page (like libraries and STMP servers) Test plan: Play with the QOTD by adding, removing, updating quotes Try to find bugs :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:38:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:38:03 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #20 from Jonathan Druart --- (In reply to Michal Denar from comment #19) > Hi Jonathan, > I'm testing this patch. I think the testplan works, but I found a problem if > I pull record from z39.50. Subfields order doesn't correspond to framework > settings. In that case we are pulling the record with the subfields ordered like they are coming from the z3950 server. I don't think we should reprocess them when importing them. > What about the Batch item modification tool? Or the item editing form? How > will we display the subfields order there? Alphabetically or based on the > framework definition? I am not sure I understand. How would the batch modification tools modify the order of the subfields? The item edition form is following the sequence of the framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:38:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:38:22 +0000 Subject: [Koha-bugs] [Bug 26199] Record matching rule match check should include Leader/LDR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:38:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:38:25 +0000 Subject: [Koha-bugs] [Bug 26199] Record matching rule match check should include Leader/LDR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114468|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 114478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114478&action=edit Bug 26199: Include LDR for match check/match point This patch adds the ability to specify the LDR instead of a numeric tag when defining match checks in record matching rules. This is particularly useful for checking LDR6 "Type of record" when importing records. Test plan: 0. prove t/Matcher.t 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=1 2. Click "Save" and choose "MARCXML" 3. Copy bib-1.marcxml to bib-1-mod.marcxml 4. Change "01344cam a22003014i 4500" to "01344cmm a22003014i 4500" 5. Go to http://localhost:8081/cgi-bin/koha/admin/matching-rules.pl?op=edit_matching_rule&matcher_id=3 6. Click "Add match check" 7. Fill out the match checks: Source: Tag: LDR Offset: 6 Length: 1 Target: Tag: LDR Offset: 6 Length: 1 8. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 9. Choose "bib-1-mod.marcxml" and click "Upload file" 10. Choose "KohaBiblio (999$c)" for "Record matching rule" 11. Click "Stage for import" 12. Click "Manage staged records" on resulting page 13. Note the "Match type" says "No match" 14. Go to http://localhost:8081/cgi-bin/koha/tools/stage-marc-import.pl 15. Choose "bib-1.marcxml" and click "Upload file" 16. Choose "KohaBiblio (999$c)" for "Record matching rule" 17. Click "Stage for import" 18. Click "Manage staged records" on resulting page 19. Note the Match type says "Match found" Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:40:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:40:26 +0000 Subject: [Koha-bugs] [Bug 27087] Allow encoding level comparison on record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27087 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26199 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:40:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:40:26 +0000 Subject: [Koha-bugs] [Bug 26199] Record matching rule match check should include Leader/LDR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27087 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:40:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:40:48 +0000 Subject: [Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329 Maura Stephens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maura.stephens at gmit.ie --- Comment #5 from Maura Stephens --- Just adding that I need this enhancement as well. We want to add 'Moodle Code' and 'Reading Lists applicable to this title' So more customisation please! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:41:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:41:22 +0000 Subject: [Koha-bugs] [Bug 26199] Record matching rule match check should include Leader/LDR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 --- Comment #4 from Andrew Fuerste-Henry --- Thanks David! I added a See Also to bug 27087, which is sort of tangential, just in case it catches your eye :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:46:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:46:23 +0000 Subject: [Koha-bugs] [Bug 26698] Hold can show as waiting and in transit at the same time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 --- Comment #5 from Victor Grousset/tuxayo --- :o I missed that, thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:47:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:47:20 +0000 Subject: [Koha-bugs] [Bug 12404] CSV profiles improvements (concatenations, substrings, conditions...) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12404 --- Comment #60 from Jonathan Druart --- (In reply to Katrin Fischer from comment #59) > Appears sadly to be undocumented! I can be retrieved from commit 57b48279bdf781e74329735fc3f5068da8398ac4 Bug 12404: Add some documentation in the help page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:48:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:48:49 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #2 from Jonathan Druart --- Shouldn't we turn the feature on for master and 20.11? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:49:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:49:54 +0000 Subject: [Koha-bugs] [Bug 26976] When renewalsallowed is empty the UI is not correct In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26976 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:54:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:54:44 +0000 Subject: [Koha-bugs] [Bug 26336] Cannot import items if items ignored when staging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #12 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 14:55:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 13:55:24 +0000 Subject: [Koha-bugs] [Bug 26336] Cannot import items if items ignored when staging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26336 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 15:03:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 14:03:18 +0000 Subject: [Koha-bugs] [Bug 16067] Koha::Cache, fastmmap caching system is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16067 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #17 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 15:04:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 14:04:57 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 --- Comment #7 from Jonathan Druart --- Created attachment 114479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114479&action=edit Bug 27109: Replace 'Enqueued' with 'Queuee' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 15:22:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 14:22:22 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.01,20.05.07 |21.05.00,20.11.01,20.05.07, released in| |19.11.13 --- Comment #91 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 15:24:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 14:24:29 +0000 Subject: [Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 --- Comment #7 from Jonathan Druart --- Sorry Caroline, I forgot to attach a file to the patch. That should work now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 15:32:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 14:32:47 +0000 Subject: [Koha-bugs] [Bug 27108] Update team for 21.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27108 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | Status|Pushed to master |Pushed to stable CC| |andrew at bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 15:32:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 14:32:53 +0000 Subject: [Koha-bugs] [Bug 27108] Update team for 21.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27108 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 15:41:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 14:41:39 +0000 Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 15:47:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 14:47:16 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 15:52:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 14:52:55 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #50 from Martin Renvoize --- OK, I don't think I'll manage to get to switching the checkbox implementation to a double button one.. Perhaps we can do that in a distinct bug along with cleaning up some of the forms. So.. I reckon this is read for SO/QA again -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 15:59:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 14:59:26 +0000 Subject: [Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 114480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114480&action=edit [ALTERNATE] Bug 27250: Fix stacked event listeners in SMTP delete modal There is a design issue on the click event listener that makes the modal get added new event listeners on each row being deleted. This makes the page call all the event listeners and generates an error. This patch replaces the flawed logic (adding the event listener inside the event listener). It makes the event listener be defined at startup time, and make the .on('click') action just pass information around as required. To test: 1. Create at least 2 SMTP servers 2. Open the browser inspector, on the network tab 3. Click "Delete" for server 1 => SUCCESS: You get a successful message (OK) 4. Click "Delete" for server 2 => SUCCESS: You get a successful message (OK) => FAIL: You get also an alert message about server 1 (KO) => FAIL: The inspector shows more than one AJAX call has been made 5. Apply this patch and reload the page 6. Repeat 3-4 => SUCCESS: Everything goes smooth this time 7. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 15:59:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 14:59:58 +0000 Subject: [Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:04:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:04:00 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:17:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:17:30 +0000 Subject: [Koha-bugs] [Bug 27259] New: HomeOrHoldingBranch is not used in all places Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259 Bug ID: 27259 Summary: HomeOrHoldingBranch is not used in all places Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org If you grep for CircControl in Koha source code you will find that there are few places that are missing the check for HomeOrHoldingBranch and just use item's homebranch. This for example leads to calculating renewability and fines with rules from item's homebranch and not from the holdingbranch as was wanted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:23:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:23:13 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01, 20.05.07 released in| | CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:26:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:26:20 +0000 Subject: [Koha-bugs] [Bug 26346] Add option to make a public list editable by library staff only In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26346 Laura Horgan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |horganl at middlesex.mass.edu --- Comment #3 from Laura Horgan --- This I believe is exactly what I am looking for.... A member of our public services team created a list and currently, I ( in tech services) am unable when new titles are added to edit this list. I would like this to be linked to not only staff but the staff in my organization as we are in a multi-library group. Several libraries have created a local list of their new selections of DVDs, etc. and we would want to make sure that permission to change the list was limited to the institution who created the lists -- further modified by those on our staff that have the permission to add, edit, or delete lists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:35:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:35:21 +0000 Subject: [Koha-bugs] [Bug 27260] New: Add homepage button for users with purchase suggestion management but no other acq permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27260 Bug ID: 27260 Summary: Add homepage button for users with purchase suggestion management but no other acq permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 26905 Bug 26905 added a new "Suggestions" option to the More dropdown for users who have suggestions permissions but not any other Acq permissions. Some users are more accustomed to using the buttons off of the staff client homepage, rather than the More dropdown, and we generally work to make things accessible via either option. I'd suggest *either* adding a new Suggestions button to the homepage (mirroring the More dropdown options) or showing the Acquisitions button on the homepage to users with only suggestion management permissions. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:35:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:35:21 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27260 [Bug 27260] Add homepage button for users with purchase suggestion management but no other acq permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:38:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:38:44 +0000 Subject: [Koha-bugs] [Bug 27261] New: PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Bug ID: 27261 Summary: PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If you check branchcode in PatronSelfRegistrationBorrowerUnwantedField and try to submit the self registration form you will get a ISE. Bug 22844 simplifies the process of selecting database columns. Bug 17364 adds the ability to allow exclusions. We can now easily exclude branchcode from PatronSelfRegistrationBorrowerUnwantedField and probably should do that/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:38:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:38:58 +0000 Subject: [Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:46:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:46:18 +0000 Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry --- As much as "let's add a yaml syspref" gets to be a cliche ... I can see this as a yaml syspref. UpdateItemLostStatusWhenPaid or something similar, give pairs of lost values like "1: 3" to say "when an item with lost=1 hits amountoutstanding=0, change its status to 3." I anticipate issues in cases where a library's policies allow multiple patrons to concurrently have lost fees for the same item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:49:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:49:55 +0000 Subject: [Koha-bugs] [Bug 25583] When ClaimReturnedLostValue is not set, the claim returned tab doesn't appear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:50:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:50:18 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:50:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:50:37 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #51 from Jonathan Druart --- (In reply to Martin Renvoize from comment #50) > OK, I don't think I'll manage to get to switching the checkbox > implementation to a double button one.. > > Perhaps we can do that in a distinct bug along with cleaning up some of the > forms. > > So.. I reckon this is read for SO/QA again The checkbox is displayed even if the letter template does not exist. Should not we hide it? Should not we insert the template for new installs? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:52:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:52:31 +0000 Subject: [Koha-bugs] [Bug 27262] New: We should switch from a checkbox to an alternate submit button for cancelled hold notifications Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27262 Bug ID: 27262 Summary: We should switch from a checkbox to an alternate submit button for cancelled hold notifications Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In bug 26282 we discussed the UX and decided it would be better to use two submit buttons rather than a checkbox approach... it proved a little challenging to implement inline with that bug given the time constraints, so here's a bug to record that intention. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:52:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:52:39 +0000 Subject: [Koha-bugs] [Bug 27262] We should switch from a checkbox to an alternate submit button for cancelled hold notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27262 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:52:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:52:39 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27262 [Bug 27262] We should switch from a checkbox to an alternate submit button for cancelled hold notifications -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:53:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:53:54 +0000 Subject: [Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22844, 17364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 [Bug 22844] Simplify the process of selecting database columns for system preferences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:53:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:53:54 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:53:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:53:54 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27261 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:54:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:54:06 +0000 Subject: [Koha-bugs] [Bug 27262] We should switch from a checkbox to an alternate submit button for cancelled hold notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27262 --- Comment #1 from Martin Renvoize --- Created attachment 114481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114481&action=edit Checkbox approach -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:54:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:54:24 +0000 Subject: [Koha-bugs] [Bug 27262] We should switch from a checkbox to an alternate submit button for cancelled hold notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27262 --- Comment #2 from Martin Renvoize --- Created attachment 114482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114482&action=edit Button approach -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:54:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:54:42 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114254|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:54:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:54:55 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114255|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:55:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:55:12 +0000 Subject: [Koha-bugs] [Bug 27262] We should switch from a checkbox to an alternate submit button for cancelled hold notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27262 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:55:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:55:22 +0000 Subject: [Koha-bugs] [Bug 27262] We should switch from a checkbox to an alternate submit button for cancelled hold notifications In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27262 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:55:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:55:26 +0000 Subject: [Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:55:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:55:28 +0000 Subject: [Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 --- Comment #1 from Lucas Gass --- Created attachment 114483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114483&action=edit Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField To test: 1 - Alter PatronSelfRegistrationBorrowerUnwantedFieldand select branchcode 2 - Attempt to self register via the OPAC 3 - Kabloom, internal server error 4 - Apply patche 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Attempt to self register again 9 - It succeeds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:55:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:55:46 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 16:55:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 15:55:56 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 17:00:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 16:00:18 +0000 Subject: [Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 17:00:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 16:00:21 +0000 Subject: [Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114434|0 |1 is obsolete| | Attachment #114480|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 114484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114484&action=edit Bug 27250: Fix stacked event listeners in SMTP delete modal There is a design issue on the click event listener that makes the modal get added new event listeners on each row being deleted. This makes the page call all the event listeners and generates an error. This patch replaces the flawed logic (adding the event listener inside the event listener). It makes the event listener be defined at startup time, and make the .on('click') action just pass information around as required. To test: 1. Create at least 2 SMTP servers 2. Open the browser inspector, on the network tab 3. Click "Delete" for server 1 => SUCCESS: You get a successful message (OK) 4. Click "Delete" for server 2 => SUCCESS: You get a successful message (OK) => FAIL: You get also an alert message about server 1 (KO) => FAIL: The inspector shows more than one AJAX call has been made 5. Apply this patch and reload the page 6. Repeat 3-4 => SUCCESS: Everything goes smooth this time 7. Sign off :-D Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 17:00:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 16:00:32 +0000 Subject: [Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |tomascohen at gmail.com |ommunity.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 17:20:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 16:20:24 +0000 Subject: [Koha-bugs] [Bug 27108] Update team for 21.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27108 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- > 2/ Update Koha.pm to state 20.11.00.000 > 3/ Update preferences to Version to 20.1100000 Does that mean that only 20.11 will see a difference with this patch? i.e. should it be backported? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 17:30:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 16:30:51 +0000 Subject: [Koha-bugs] [Bug 27263] New: Link to preferences mentioned in system preference descriptions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27263 Bug ID: 27263 Summary: Link to preferences mentioned in system preference descriptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Wherever a system preference description mentions another system preference the name of that preference should be a link. This eliminates a process where the user has to search for that preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 17:30:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 16:30:53 +0000 Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 --- Comment #4 from Martha Fuerst --- I like that solution, Andrew. It sounds super customizable or ignorable, for those systems that wouldn't need it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 17:35:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 16:35:59 +0000 Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 --- Comment #13 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 17:36:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 16:36:07 +0000 Subject: [Koha-bugs] [Bug 26946] Limit size of cash register's name on the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26946 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 17:38:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 16:38:27 +0000 Subject: [Koha-bugs] [Bug 26905] Purchase suggestion button hidden for users with suggestion permission but not acq permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #13 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 17:38:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 16:38:28 +0000 Subject: [Koha-bugs] [Bug 27260] Add homepage button for users with purchase suggestion management but no other acq permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27260 Bug 27260 depends on bug 26905, which changed state. Bug 26905 Summary: Purchase suggestion button hidden for users with suggestion permission but not acq permission https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 17:40:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 16:40:20 +0000 Subject: [Koha-bugs] [Bug 25583] When ClaimReturnedLostValue is not set, the claim returned tab doesn't appear In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25583 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #16 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 17:40:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 16:40:35 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #52 from Martin Renvoize --- Good call.. seems I missed some bits from that final commit.. I'll dig them out tomorrow.. As for bit displaying the checkbox.. are there precidents for that elsewhere? I'm happy to do it, but am also keen to have consistency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 18:15:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 17:15:16 +0000 Subject: [Koha-bugs] [Bug 27264] New: Reword sentence of OPACHoldsHistory Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27264 Bug ID: 27264 Summary: Reword sentence of OPACHoldsHistory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The sentence for the OPACHoldsHistory system preference seems clunky. Allow/Don't allow patrons to see what books they have place holds in the past. First, libraries don't have only books. This should be "items" or "titles". Second "they have place holds in the past" doesn't seem grammatically correct. I suggest Allow/Don't allow patrons to see the list of their past holds. But I'm willing to take other suggestions as I'm not a native English speaker. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 18:15:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 17:15:28 +0000 Subject: [Koha-bugs] [Bug 27264] Reword sentence of OPACHoldsHistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27264 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 18:29:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 17:29:44 +0000 Subject: [Koha-bugs] [Bug 27264] Reword sentence of OPACHoldsHistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27264 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 18:29:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 17:29:47 +0000 Subject: [Koha-bugs] [Bug 27264] Reword sentence of OPACHoldsHistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27264 --- Comment #1 from Caroline Cyr La Rose --- Created attachment 114485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114485&action=edit Bug 27264: Reword sentence of OPACHoldsHistory This patch rewrites the sentence for the OPACHoldsHistory system preference. To test: 1) Go to Administration > Global system preferences > OPAC > Privacy > OPACHoldsHistory 2) Read the sentence and make sure it makes sense, conveys the right information, has no typos and is grammatically correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 18:35:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 17:35:49 +0000 Subject: [Koha-bugs] [Bug 27133] Header missing for "Copy no" on the relative's checkouts table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27133 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #8 from Andrew Fuerste-Henry --- Missing dependencies, not backporting to 20.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 18:39:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 17:39:23 +0000 Subject: [Koha-bugs] [Bug 27265] New: Process message queue cron should be able to take multiple types as a parameter Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Bug ID: 27265 Summary: Process message queue cron should be able to take multiple types as a parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 18:49:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 17:49:20 +0000 Subject: [Koha-bugs] [Bug 26698] Hold can show as waiting and in transit at the same time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111789|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 114486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114486&action=edit Bug 26698: Use is_at_destination to determine if hold is at destination This copies code from bug 12556 and uses a Koha::Hold method rather than code in script TO test: 1 - Place a hold for item from library B for delivery at library A 2 - Check the item in at library B, confirm and transfer 3 - Check item in at Library A but ignore the hold 4 - View the Holds tab of the details page: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=6 5 - Priority = "In transit" Pickup Library = "Item waiting at" 6 - Apply patch 7 - Restart all the thigns 8 - Reload the page 9 - Priority="In transit" and Pickup library="Item being transferred" Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 18:49:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 17:49:40 +0000 Subject: [Koha-bugs] [Bug 26698] Hold can show as waiting and in transit at the same time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Victor Grousset/tuxayo --- It works! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 18:58:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 17:58:25 +0000 Subject: [Koha-bugs] [Bug 26351] Add plugin hooks to transform item barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26351 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 18:58:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 17:58:37 +0000 Subject: [Koha-bugs] [Bug 26352] Add plugin hooks to transform patron barcodes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26352 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 19:18:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 18:18:59 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #92 from Victor Grousset/tuxayo --- Test plan works in 19.11.x but automated test doesn't [1] (t/Search/buildQuery.t) It works in 20.05.x Here is maybe the place to looks in the code. Does anyone understand the difference there or somewhere else that affect $limit_desc and $limit? 20.05.x: https://gitlab.com/koha-community/Koha/-/blob/8a9553c4ae62aa05d7d3529806d8fdbac664b473/C4/Search.pm#L1587 19.11.x: https://gitlab.com/koha-community/Koha/-/blob/608512179cf8f354ca76bab32e874530b3c5df12/C4/Search.pm#L1755 [1] Failed test: kohadev-koha at ec7b568b5d3d:/kohadevbox/koha$ prove t/Search/buildQuery.t t/Search/buildQuery.t .. 1/10 # Failed test 'Limit is correct' # at t/Search/buildQuery.t line 92. # got: undef # expected: '' # Failed test 'Limit desc is correct' # at t/Search/buildQuery.t line 94. # got: undef # expected: '' # Looks like you failed 2 tests of 13. # Failed test 'test weighted autotruncated' # at t/Search/buildQuery.t line 107. # Failed test 'Limit is correct' # at t/Search/buildQuery.t line 130. # got: undef # expected: '' # Failed test 'Limit desc is correct' # at t/Search/buildQuery.t line 132. # got: undef # expected: '' # Looks like you failed 2 tests of 13. # Failed test 'test* weighted autotruncated' # at t/Search/buildQuery.t line 144. # Failed test 'Limit is correct' # at t/Search/buildQuery.t line 167. # got: undef # expected: '' # Failed test 'Limit desc is correct' # at t/Search/buildQuery.t line 169. # got: undef # expected: '' # Looks like you failed 2 tests of 13. # Failed test 'test weighted not-autotruncated' # at t/Search/buildQuery.t line 181. # Failed test 'Limit is correct' # at t/Search/buildQuery.t line 316. # got: undef # expected: '' # Failed test 'Limit desc is correct' # at t/Search/buildQuery.t line 318. # got: undef # expected: '' # Looks like you failed 2 tests of 13. # Failed test 'one and two weighted autotruncated' # at t/Search/buildQuery.t line 330. # Looks like you failed 4 tests of 10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 19:27:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 18:27:09 +0000 Subject: [Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430 --- Comment #93 from Victor Grousset/tuxayo --- It's likely that the tests should just expect undef instead of '' But better ask for confirmation ^_^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 19:32:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 18:32:51 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 --- Comment #8 from David Nind --- Thanks Tomás and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 19:35:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 18:35:45 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Depends on| |25097 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25097 [Bug 25097] Add option to message_queue to allow for only specific sending notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 19:35:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 18:35:45 +0000 Subject: [Koha-bugs] [Bug 25097] Add option to message_queue to allow for only specific sending notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25097 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 [Bug 27265] Process message queue cron should be able to take multiple types as a parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 19:36:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 18:36:29 +0000 Subject: [Koha-bugs] [Bug 27263] Link to preferences mentioned in system preference descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27263 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 19:36:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 18:36:32 +0000 Subject: [Koha-bugs] [Bug 27263] Link to preferences mentioned in system preference descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27263 --- Comment #1 from Owen Leonard --- Created attachment 114487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114487&action=edit Bug 27263: Link to preferences mentioned in system preference descriptions This patch attempts to locate all references to system preference names in various system preference descriptions and link those preference names to a search for that preference. This will allow the user to easily jump between preferences which are related or depend on each other. To test, apply the patch go to Administration -> System preferences. - Open each preference category and confirm that the page loads without error. - Test any system preference links you find to confirm that they work correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 19:36:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 18:36:40 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27096 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 19:36:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 18:36:40 +0000 Subject: [Koha-bugs] [Bug 27096] Add option to message_queue to exclude specific letter codes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27096 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27265 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 19:38:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 18:38:00 +0000 Subject: [Koha-bugs] [Bug 27264] Reword sentence of OPACHoldsHistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27264 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 19:38:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 18:38:02 +0000 Subject: [Koha-bugs] [Bug 27264] Reword sentence of OPACHoldsHistory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27264 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114485|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 114488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114488&action=edit Bug 27264: Reword sentence of OPACHoldsHistory Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 20:11:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 19:11:30 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #21 from Katrin Fischer --- I agree with Jonathan in that we should never change the sequence of subfields in an existing bibliographic record - imported or already in Koha. MARC requires some subfields to be in a specific sequence that is not alphabetical or easy to guess. I am not sure how the item forms are build in several places - only that the ones in acq and serials are "different" and have not all features from the frameworks. Maybe worth checking those for a separate bug. But I think this one here aims mostly at bibliographic and authority records? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 20:14:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 19:14:43 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 20:14:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 19:14:46 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114463|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 114489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114489&action=edit Bug 27256: Update click handler for point of sale This patch updates the click handler to bind to the table element in the DOM as aposed to the individual buttons by their classes. We then use the event propogation and filter on the button class to catch the clicks we want. Test plan 1/ Add 22 debit_types that can be sold to the system (or reduce the datatable paging size) 2/ Confirm that items on the second page of results cannot be added for sale on the point of sale page. 3/ Apply the patch 4/ Confirm items from the second table page can now be added correctly 5/ Clicking add when navigating to such an item should leave the items table unmodified. 6/ Clicking aa when the table was filtered should reset the filters bringing the table back to the first page 7/ Signoff Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 20:33:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 19:33:19 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114489|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 114490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114490&action=edit Bug 27256: Update click handler for point of sale This patch updates the click handler to bind to the table element in the DOM as aposed to the individual buttons by their classes. We then use the event propogation and filter on the button class to catch the clicks we want. Test plan 1/ Add 22 debit_types that can be sold to the system (or reduce the datatable paging size) 2/ Confirm that items on the second page of results cannot be added for sale on the point of sale page. 3/ Apply the patch 4/ Confirm items from the second table page can now be added correctly 5/ Clicking add when navigating to such an item should leave the items table unmodified. 6/ Clicking aa when the table was filtered should reset the filters bringing the table back to the first page 7/ Signoff Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 20:33:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 19:33:29 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114162|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 114491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114491&action=edit Bug 27127: Make Koha::BackgroundJob->messages return a scalar Otherwise the code in the template is not handled correctly: 112 [% FOR m IN job.messages %] m will become each key/val of the message hash: {"type":"success","biblionumber":"1","code":"biblio_modified"} And not the whole hash Test plan: Modify one biblio using the batch record modification tool Modify two biblios using the batch record modification tool Go to the detail view of each job and confirm that with this patch the display is correct Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 20:34:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 19:34:30 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo --- all good :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 20:47:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 19:47:33 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Martha Fuerst changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org --- Comment #16 from Martha Fuerst --- Not being able to use Write Off Selected to select specific fines to write off defeats the purpose of even having the function to select fines for payment/write off. It is essential to being able to clearly communicate to patrons why/for what materials they owe fines. Losing this functionality has made for a lot of mess on the backend that our admin/business office is having to deal with. Please rebase and backport to 20.05. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 20:57:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 19:57:08 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #15 from Aleisha Amohia --- Yup... What Joubu has said is just a longer way of saying what I said in my comment :) so glad we're all agreed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 20:59:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 19:59:23 +0000 Subject: [Koha-bugs] [Bug 16522] Add 773 (Host item entry) to the cart and list displays and e-mails In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16522 --- Comment #6 from Aleisha Amohia --- Thanks Katrin - the host item feature isn't something I've used before so some context and more specific feedback would be useful! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 21:05:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 20:05:44 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #16 from Katrin Fischer --- (In reply to Aleisha Amohia from comment #15) > Yup... What Joubu has said is just a longer way of saying what I said in my > comment :) so glad we're all agreed. Took me a little bit to get there :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 21:24:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 20:24:29 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 --- Comment #17 from George Williams (NEKLS) --- (In reply to Martha Fuerst from comment #16) > Not being able to use Write Off Selected to select specific fines to write > off defeats the purpose of even having the function to select fines for > payment/write off. > > It is essential to being able to clearly communicate to patrons why/for what > materials they owe fines. > > Losing this functionality has made for a lot of mess on the backend that our > admin/business office is having to deal with. Please rebase and backport to > 20.05. > > Thanks! +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 21:31:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 20:31:27 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 21:31:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 20:31:30 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114345|0 |1 is obsolete| | Attachment #114346|0 |1 is obsolete| | Attachment #114351|0 |1 is obsolete| | Attachment #114352|0 |1 is obsolete| | Attachment #114353|0 |1 is obsolete| | Attachment #114354|0 |1 is obsolete| | Attachment #114355|0 |1 is obsolete| | --- Comment #22 from Michal Denar --- Created attachment 114492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114492&action=edit Bug 8976: Add marc_subfield_structure.display_order Sponsored-by: Orex Digital Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 21:31:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 20:31:35 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #23 from Michal Denar --- Created attachment 114493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114493&action=edit Bug 8976: Add the ability to sort subfields for the MARC frameworks This new enhancement adds the ability to change the default order the subfields. Both bibliographic and authority MARC subfield structure are taken into account. And so the item edition as well (in the different screens when item can be added/edited). This will answer the following needs that have been listed in the comments of the bug report: - $i in 7xx fields should be the first subfield in the sequence - 300 fields are sorted number first when cataloguers enter the letter fields first - 100 field, it's commonly $a, $q, $d. Test plan: 1. Edit a MARC frameworks, field 300 2. Resort the subfield (drag and drop the tab of the subfield) as you like 3. Save => Notice that the list of fields are displayed following the order you chose 4. Edit it again => The order is correctly kept! 5. Create a new bibliographic record 6. Notice that the subfields are order in the same sequence 7. Fill different subfields, not all 8. Save, edit again 9. Note that the subfields that have been filled are listed first, then the empty ones. But the sequence defined at the framework level is kept. 10. Do the same for an authority framework and create/edit an authority record 11. Modify item (952) subfields order 12. Create an item and confirm that the order is correct 13. Modify the ACQ framework, 952, modify the order of the subfield 14. Create a new order and confirm that the item form has the subfield ordered following the sequence defined at the framework level QA: Note that this patch is about bibliographic records only, next patches deal with authotiries and items. Sponsored-by: Orex Digital Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 21:31:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 20:31:39 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #24 from Michal Denar --- Created attachment 114494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114494&action=edit Bug 8976: Sort subfields for authority records Same patch for the authority frameworks/records Sponsored-by: Orex Digital Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 21:31:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 20:31:44 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #25 from Michal Denar --- Created attachment 114495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114495&action=edit Bug 8976: Change for the item forms Sponsored-by: Orex Digital Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 21:31:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 20:31:48 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #26 from Michal Denar --- Created attachment 114496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114496&action=edit Bug 8976: Add Koha::AuthSubfieldStructure[s] Sponsored-by: Orex Digital Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 21:31:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 20:31:52 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #27 from Michal Denar --- Created attachment 114497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114497&action=edit Bug 8976: Code cleaning It was tricky to write the previous patch so I decided to clean the ground (a bit) for later, taking advantage of having people who are going to test the whole area. We can move it to its own bug report if QA wants to. Sponsored-by: Orex Digital Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 21:31:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 20:31:57 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #28 from Michal Denar --- Created attachment 114498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114498&action=edit Bug 8976: DBIC schema changes Sponsored-by: Orex Digital Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 21:44:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 20:44:04 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- It's seems that all the CI jobs are using ES6 so the tests should fail with this off by default. prove -r t/Koha/SearchEngine/Elasticsearch* t/db_dependent/Koha_Elasticsearch.t t/Koha_SearchEngine_Elasticsearch_Browse.t t/db_dependent/Koha/SearchEngine/ It turns out not :o -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 22:12:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 21:12:20 +0000 Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 22:12:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 21:12:22 +0000 Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Alexis Ripetti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84566|0 |1 is obsolete| | --- Comment #3 from Alexis Ripetti --- Created attachment 114499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114499&action=edit Bug 22243: Fix unescaped apostrophe in Z target This patch escapes apostrophes in the z39.50 target name prior to them being embedded in the template. To test: - Create a z39.50 target containing an apostrophe in the title - Note that the Advanced Cataloguer editor does not load - Apply the patch - TEST: Note that the Advanced Cataloguer editor does load -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 22:20:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 21:20:34 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114324|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 114500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114500&action=edit Bug 27200: (bug 20168 follow-up) Fix 'Browse search' The 'hidden' class has been replaced by 'd-none' on bug 20168 Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 22:20:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 21:20:37 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114462|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 114501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114501&action=edit Bug 27200: (follow-up) Browse search interface update This patch updates the browse search interface to confirm to new interface patterns in the Bootstrap 4 framework, especially in the form markup. The results list has been changed to a Bootstrap "Collapse" component configured as an accordion (https://getbootstrap.com/docs/4.5/components/collapse/#accordion-example). Instead of loading the bibliographic record results below the list of terms returned, the bibliographic results are now displayed in the "panel" expanded below the selected term. Subtitle has been added to the information displayed about the bibliographic record. To test you must be using ElasticSearch and the OpacBrowseSearch preference must be enabled. Apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the "Browse search" page in the OPAC. - Test various searches: Author, Subject, and Title. - When results are found, the should be displayed as a Bootstrap-styled accordion widget. Clicking any individual result should expand the panel containing the corresponding records. - Clicking the record link should open the bibliographic detail page in a new window. - When no results are found, a Bootstrap-style "alert" box should appear. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 22:21:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 21:21:16 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 22:54:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 21:54:52 +0000 Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 17 22:54:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 21:54:54 +0000 Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114499|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 114502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114502&action=edit Bug 22243: Fix unescaped apostrophe in Z target This patch escapes apostrophes in the z39.50 target name prior to them being embedded in the template. To test: - Create a z39.50 target containing an apostrophe in the title - Note that the Advanced Cataloguer editor does not load - Apply the patch - TEST: Note that the Advanced Cataloguer editor does load Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 00:07:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 23:07:58 +0000 Subject: [Koha-bugs] [Bug 27266] New: Move C4::Biblio::GetMarcAuthors to Koha namespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Bug ID: 27266 Summary: Move C4::Biblio::GetMarcAuthors to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 00:08:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 23:08:43 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Blocks| |3150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 [Bug 3150] Move emails for sending cart and list contents into notices tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 00:08:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 23:08:43 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27266 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 00:09:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 17 Dec 2020 23:09:07 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #17 from Aleisha Amohia --- Starting with GetMarcAuthors at Bug 27266 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 01:27:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 00:27:45 +0000 Subject: [Koha-bugs] [Bug 27267] New: Create more efficient daemon for indexing Zebra Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 Bug ID: 27267 Summary: Create more efficient daemon for indexing Zebra Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au At the moment, each instance of Koha on a server gets its own rebuild_zebra.pl daemon which uses approximately 170MB of RAM when idling. While this is not a huge amount on its own, it does not scale well when you start adding many Koha instances on the server. It would be very possible to have 10GB of RAM taken up on a server by idle rebuild_zebra.pl processes alone. In 2018, I wrote a custom Koha indexer daemon (on a non-Debian based OS) which only uses 12MB of RAM. It gets a list of Koha instances, queries the zebraqueue table in those instances, and then forks child processes to run rebuild_zebra.pl (in non-daemon mode) for Koha instances that need it. It also uses advisory file locking, so that only 1 rebuild_zebra.pl process will run per instance at any given time. I would need to refactor the daemon to run using the Debian Koha tooling, but I think that this would be a useful addition to Koha, especially for vendors and other large organisations running multiple Koha instances. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 01:30:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 00:30:46 +0000 Subject: [Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 --- Comment #1 from David Cook --- At the moment, it's a single threaded single Perl process that does blocking I/O, so the time it takes to query all Koha databases will degrade as you add Koha databases. While the database queries are fast, this is a potential limitation. However, I could use Mojo to do non-blocking I/O for the database queries, which would remove that potential scalability limitation. Alternatively, I could look at benchmarking the database queries to see if it really is just a hypothetical limitation. It is possible that I could get some paid work time to do this work, but I want to see what community feedback I can get before I do a POC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 01:33:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 00:33:40 +0000 Subject: [Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | --- Comment #2 from David Cook --- Another idea is to use the RabbitMQ. Instead of polling the database via a daemon, I could enhance Koha to send RabbitMQ messages when there is data to index. The daemon would just be subscribed to a Koha index queue and it could trigger indexing jobs as I proposed above. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 01:44:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 00:44:08 +0000 Subject: [Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 --- Comment #3 from David Cook --- While these ideas are in the name of efficiency and scalability, there is a downside. They are based on the idea that all the relevant Koha instances are collocated on the same server as the Zebra indexing daemon. Another idea would be to have 1 process per Koha instance (with very minimal memory usage) that either polls the database or listens to RabbitMQ and then forks a child process to run rebuild_zebra.pl (or triggers an API call that does the indexing). This idea is probably the most container friendly. (Another indexing optimization would be to have rebuild_zebra.pl do its work on SSD or RAM disk, since it can perform a lot of I/O for temporarily held data which can be really slow. In the past, we've noticed huge speed improvements by having rebuild_zebra.pl work on a RAM disk.) Reference material: Reading https://stackoverflow.com/questions/9733146/tips-for-keeping-perl-memory-usage-low/9734699#9734699 led to many interesting thoughts on memory usage in Perl, especially the part about garbage collection not working the way I expected in Perl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 01:50:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 00:50:16 +0000 Subject: [Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 --- Comment #4 from David Cook --- (In reply to David Cook from comment #3) > Another idea would be to have 1 process per Koha instance (with very minimal > memory usage) that either polls the database or listens to RabbitMQ and then > forks a child process to run rebuild_zebra.pl (or triggers an API call that > does the indexing). > > This idea is probably the most container friendly. > That said, 60 minimal processes will use more CPU than 1 minimal process, but... that usage should be minimal and non-sustained. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 01:53:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 00:53:09 +0000 Subject: [Koha-bugs] [Bug 27267] Create more efficient daemon for indexing Zebra In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27267 --- Comment #5 from David Cook --- By the way, this would be sponsored by Prosentient Systems, so this isn't a personal project. If people are happy with this idea, I will set aside a work day (or more likely parts of a few work days) and do this work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:11:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:11:45 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:11:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:11:49 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 --- Comment #1 from Aleisha Amohia --- Created attachment 114503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114503&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_marc_authors. This is so get_marc_authors can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm authors show as normal. 9. Click 'send' and confirm the email sent shows the authors as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 11. View the record detail page and confirm the authors show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:12:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:12:08 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:20:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:20:09 +0000 Subject: [Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #23 from David Cook --- (In reply to Johanna Räisä from comment #21) > Do you mean putting Koha's internal link to authority linking subfield? > I'm not 100% sure what you mean, but I think so, yes. > We are using national metadata repository and mainly the URI in $0 subfield > has a link to that. It might be a good idea that Koha would use URI in > authority linking subfield also. > Yeah that sounds good to me. So you wouldn't be storing authority records in Koha? > We are facing problem with this $9 subfield because it is used in our > national metadata repository for other things and it should not change if we > are pulling data to Koha. This is why it would be nice to choose which > subfield is used for the authority linking. Hmm, how are you pulling the authority data to Koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:20:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:20:23 +0000 Subject: [Koha-bugs] [Bug 27268] New: Move C4::Biblio::GetMarcNotes to Koha namespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 Bug ID: 27268 Summary: Move C4::Biblio::GetMarcNotes to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:20:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:20:35 +0000 Subject: [Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Blocks| |3150 Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 [Bug 3150] Move emails for sending cart and list contents into notices tool -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:20:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:20:35 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27268 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:20:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:20:49 +0000 Subject: [Koha-bugs] [Bug 27258] Rename BackgroundJobs => Tasks In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27258 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:21:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:21:22 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #18 from Aleisha Amohia --- GetMarcNotes at Bug 27268 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:23:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:23:12 +0000 Subject: [Koha-bugs] [Bug 27087] Allow encoding level comparison on record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27087 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Hmm that's interesting. I suppose other uses could be a match check on say the 005 to make sure that the incoming record's value is '>=' to the existing record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:23:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:23:28 +0000 Subject: [Koha-bugs] [Bug 26199] Record matching rule match check should include Leader/LDR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26199 --- Comment #5 from David Cook --- (In reply to Andrew Fuerste-Henry from comment #4) > Thanks David! I added a See Also to bug 27087, which is sort of tangential, > just in case it catches your eye :) Thanks for testing! And that bug sounds interesting! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:34:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:34:52 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 --- Comment #9 from David Cook --- (In reply to David Nind from comment #5) > Rather than "Enqueued" I think I would prefer "Queued". Enqueued is a valid > English word, according to Oxford English Dictionary > (https://www.lexico.com/definition/enqueue). However, it is not something in > common usage or that I have come across before except in Koha. I love enqueue/dequeue and they come up a lot for me, but they do seem to be computing terms, so I am willing to admit that they probably should be reserved for backend systems and not displayed to users. I also love splitting hairs so... Should it be "Queued on" or "Queued at"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 02:53:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 01:53:12 +0000 Subject: [Koha-bugs] [Bug 27246] Remove apache only code from C4::Context BEGIN In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27246 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:09:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:09:23 +0000 Subject: [Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:09:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:09:27 +0000 Subject: [Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 --- Comment #1 from Aleisha Amohia --- Created attachment 114504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114504&action=edit Bug 27268: Move GetMarcNotes to Koha namespace This patch moves C4::Biblio::GetMarcNotes to Koha::Biblio->get_marc_notes. This is so get_marc_notes can be used in templates and notices. To test: 1. Find a record that has a note (3xx for UNIMARC, 5xx for MARC21). Confirm the notes still show as normal under the Descriptions tab. 2. Add the record to the cart. 3. View your cart and click 'more details'. Confirm notes show as normal. 4. Log in to the OPAC. Find the record and add it to the cart 5. View the cart and click 'more details'. Confirm notes show as normal. 6. View the record detail page and confirm the notes show as normal under the Title Notes tab. 7. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:14:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:14:10 +0000 Subject: [Koha-bugs] [Bug 27269] New: Move C4::Biblio::GetMarcSubjects to Koha namespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Bug ID: 27269 Summary: Move C4::Biblio::GetMarcSubjects to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:14:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:14:25 +0000 Subject: [Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |aleisha at catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored Blocks| |3150 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 [Bug 3150] Move emails for sending cart and list contents into notices tool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:14:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:14:25 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:35:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:35:35 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #19 from Aleisha Amohia --- GetMarcSubjects at Bug 27269 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:49:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:49:47 +0000 Subject: [Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:49:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:49:50 +0000 Subject: [Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 --- Comment #1 from Aleisha Amohia --- Created attachment 114505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114505&action=edit Bug 27269: Move GetMarcSubjects to Koha namespace This patch moves C4::Biblio::GetMarcSubjects to Koha::Biblio->get_marc_subjects. This is so get_marc_subjects can be used in templates and notices. To test: 1. Find a record that has a subject (6xx). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm subjects show as normal. 4. Click 'send' and confirm the email sent shows the subjects as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the ubjectsas normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm subjects show as normal. 9. Click 'send' and confirm the email sent shows the subjects as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the subjects as normal. 11. View the record detail page and confirm the subjects show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:52:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:52:37 +0000 Subject: [Koha-bugs] [Bug 27270] New: Move C4::Biblio::GetMarcSeries to Koha namespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27270 Bug ID: 27270 Summary: Move C4::Biblio::GetMarcSeries to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:53:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:53:05 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #20 from Aleisha Amohia --- GetMarcSeries at Bug 27270 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:53:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:53:27 +0000 Subject: [Koha-bugs] [Bug 27271] New: Move C4::Biblio::GetMarcUrls to Koha namespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27271 Bug ID: 27271 Summary: Move C4::Biblio::GetMarcUrls to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:53:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:53:43 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #21 from Aleisha Amohia --- GetMarcUrls at Bug 27271 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:58:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:58:09 +0000 Subject: [Koha-bugs] [Bug 27272] New: Move C4::Items::GetItemsInfo to Koha namespace Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Bug ID: 27272 Summary: Move C4::Items::GetItemsInfo to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 03:58:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 02:58:33 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #22 from Aleisha Amohia --- GetItemsInfo at Bug 27272 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 04:08:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 03:08:05 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #1 from Tomás Cohen Arazi --- This method should just be removed and a mix of things used instead: my $biblio = Koha::Biblios->find($biblio_id, {prefetch =>['items', 'biblioitem'] }); my @items = $biblio->items; my $biblioitem = $biblio->biblioitem; ^^^ could do most of it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 05:47:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 04:47:39 +0000 Subject: [Koha-bugs] [Bug 21528] Combine all reserves in a biblio hold-group into a single line entry In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528 --- Comment #7 from David Cook --- Comment on attachment 88124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88124 Bug 21528: UNFINISHED PATCH Review of attachment 88124: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21528&attachment=88124) ----------------------------------------------------------------- ::: svc/holds @@ +103,2 @@ > itemtype_limit => $itemtype_limit, > + hold_group => Koha::Holds->search({ hold_group_id => $h->hold_group_id })->unblessed, This is buggy. I'd suggest changing it to the following: ( $h->hold_group_id ) ? Koha::Holds->search({ hold_group_id => $h->hold_group_id })->unblessed : undef If the hold doesn't have a hold group ID, all holds without a hold_group_id will be fetched. If a borrower has a high number of holds, and there are a high number of holds on the system, you'll be fetching and then transmitting a huge amount of data (the magnitude being megabytes instead of kilobytes). This uses up a lot of system memory and creates huge latency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 05:53:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 04:53:31 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 06:09:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 05:09:32 +0000 Subject: [Koha-bugs] [Bug 27273] New: Hiii Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27273 Bug ID: 27273 Summary: Hiii Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: vicenteuserwin at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114506&action=edit Huhu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 06:20:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 05:20:01 +0000 Subject: [Koha-bugs] [Bug 27274] New: Hiii Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27274 Bug ID: 27274 Summary: Hiii Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: vicenteuserwin at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 06:21:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 05:21:43 +0000 Subject: [Koha-bugs] [Bug 27275] New: Hiiiii Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27275 Bug ID: 27275 Summary: Hiiiii Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: vicenteuserwin at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114507&action=edit HACKED BY KENZY -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 06:55:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 05:55:04 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #222 from David Cook --- Looks like Owen set this to "Patch doesn't apply" back on 2019-07-31, and I can confirm that is the case now in 2020-12-18. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 06:59:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 05:59:06 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #223 from David Cook --- Would it be possible to get squash these patches? I think rebasing 13 patches where the first one is failing is going to be not a very pleasurable task. It looks like these are the files changed: Biblio.pm MultiplePerRecord.t Reserves.pm opac-reserve.pl opac-reserve.tt opac.scss placerequest.pl request.pl request.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 07:01:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 06:01:55 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #224 from David Cook --- (In reply to David Cook from comment #223) > Would it be possible to get squash these patches? I think rebasing 13 > patches where the first one is failing is going to be not a very pleasurable > task. > > It looks like these are the files changed: > > Koha::Biblio.pm > MultiplePerRecord.t > Reserves.pm > opac-reserve.pl > opac-reserve.tt > opac.scss > placerequest.pl > request.pl > request.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 07:06:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 06:06:55 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #218 from David Cook --- Is it possible to squash these patches down a bit? With 16 patches, I think it's difficult to rebase and difficult to have a cohesive idea of how this change is supposed to work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 07:22:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 06:22:52 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #29 from David Cook --- (In reply to Aleisha Amohia from comment #25) > > Code is duplicated but no idea where we could move it to. > I'd suggest something like Koha::Search or a Koha::Search::Something submodule and then add unit tests for it. It's late on a Friday but I could have more of a think about this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 07:34:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 06:34:52 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #225 from David Cook --- Trying to find a base to merge these into easily so I can squash them and it's tough. 18.11, 19.05, 19.11... I never knew that Koha's holds code was changed so frequently. Aleisha, even if you don't squash them, could you let me know the parent commit for these patches from your last rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 07:35:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 06:35:59 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #219 from David Cook --- Julian, what's the commit that these are based off? I'd love to apply these to a stable base so that I could get a sense of the changes... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 07:53:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 06:53:32 +0000 Subject: [Koha-bugs] [Bug 27276] New: borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 Bug ID: 27276 Summary: borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: somesecretemail at mailinator.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz When running borrowers-force-messaging-defaults.pl the error message DBD::mysql::st execute failed: Incorrect DATE value: '0000-00-00' [for Statement "SELECT DISTINCT bo.borrowernumber, bo.categorycode FROM borrowers bo LEFT JOIN borrower_message_preferences mp USING (borrowernumber) is displayed. According to documentation this relates to MySql variable sql_mode and that the following behavior can occur if sql_mode contains NO_ZERO_IN_DATE and/or NO_ZERO_DATE. I can confirm this by executing set sql_mode='STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE'; SELECT * FROM borrowers WHERE borrowers.dateenrolled >= '0000-00-00' The select query will result in "Incorrect DATE value: '0000-00-00'" If I instead write set sql_mode='ALLOW_INVALID_DATES'; SELECT * FROM borrowers WHERE borrowers.dateenrolled >= '0000-00-00' the select query executes correctly and returns a collection of borrowers BUT borrowers-force-messaging-defaults.pl still produces the error. Things I've checked * restarting MySql service * restarting server * that 0 in koha-conf.xml is set to 0 * that /etc/mysql/mysql.conf.d/mysqld.cnf contains sql_mode = "ALLOW_INVALID_DATES" Is this a bug in Koha or is there some configuration that I'm missing? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 09:22:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 08:22:45 +0000 Subject: [Koha-bugs] [Bug 27108] Update team for 21.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27108 --- Comment #9 from Jonathan Druart --- This was for 20.11 only. Need to be reverted from 20.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 09:25:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 08:25:48 +0000 Subject: [Koha-bugs] [Bug 27275] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27275 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Summary|Hiiiii |SPAM Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 09:35:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 08:35:19 +0000 Subject: [Koha-bugs] [Bug 26282] Allow staff to decide if a hold cancellation notice will be sent when cancelling a hold In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26282 --- Comment #53 from Jonathan Druart --- It's how it works right now with the feature. It's disabled if the letter does not exist. And yes, behaviours being disabled if the letter template does not exist is what we are doing in other areas (claims, out of the top of my head). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:03:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:03:03 +0000 Subject: [Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976 --- Comment #29 from Jonathan Druart --- (In reply to Katrin Fischer from comment #21) > I agree with Jonathan in that we should never change the sequence of > subfields in an existing bibliographic record - imported or already in Koha. > MARC requires some subfields to be in a specific sequence that is not > alphabetical or easy to guess. Thanks for the confirmation. > I am not sure how the item forms are build in several places - only that the > ones in acq and serials are "different" and have not all features from the > frameworks. Maybe worth checking those for a separate bug. But I think this > one here aims mostly at bibliographic and authority records? Items as well. Item add/mod form from cataloguing and acq are taken into account in those patches. Thanks Michal for the signoff! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:03:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:03:59 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 --- Comment #18 from Martin Renvoize --- Created attachment 114508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114508&action=edit [20.05.x] Bug 26536: Fix incorrectly scoped variable During work on bug 26076 a variable scope mistake was made when reverting the logic to use distinct queries for selected accountlines. This patch restores the script scope of the varaible by removing the superflous 'my' declaration. Test plan 1/ Add a set of manual invoices 2/ Select a subset of those manual invoices to 'Writeoff selected' 3/ Confirm that only those selected invoices have been written off. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:04:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:04:02 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 --- Comment #19 from Martin Renvoize --- Created attachment 114509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114509&action=edit [20.05.x] Bug 26536: WRITEOFF not writeoff There is inconsistency in variable case between the controller script and the template. This patch corrects those inconsistencies. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:04:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:04:06 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 --- Comment #20 from Martin Renvoize --- Created attachment 114510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114510&action=edit [20.05.x] Bug 26536: Assignment fix Whilst working on this bug I found a weird inconsistent variable assignment line Signed-off-by: Sally Signed-off-by: Katrin Fischer JD: Amended commit message: fix bug number Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:15:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:15:34 +0000 Subject: [Koha-bugs] [Bug 27108] Update team for 21.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27108 --- Comment #10 from Jonathan Druart --- (In reply to Jonathan Druart from comment #9) > This was for 20.11 only. Need to be reverted from 20.05. Don't revert! ashimema> not sure it does Joubu? Joubu> ashimema: hum, why not? ashimema> it'll be the 21.06 stuff it gets the 'Current maintenance team' from ashimema> so.. the column on the right of the 'Koha team' page changes every six months now to reflect the new team ;) ashimema> we don't remove anything.. we just add to that teams yaml file ashimema> so backporting for the three support releases is the right thing to do.. I think ashimema> that way.. if people are actually updating each month, they'll have the correct information available should that want to know who the current maintenance team is. :) Joubu> you are right, it will only add the "21.05" roles next to the names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:19:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:19:50 +0000 Subject: [Koha-bugs] [Bug 27277] New: Queued vs Enqueued Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Bug ID: 27277 Summary: Queued vs Enqueued Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org See bug 27109 comment 5: """ Rather than "Enqueued" I think I would prefer "Queued". Enqueued is a valid English word, according to Oxford English Dictionary (https://www.lexico.com/definition/enqueue). However, it is not something in common usage or that I have come across before except in Koha. As this one improves the display, I've signed it off. I will add a new bug for changing the term and see what others think. Testing notes: - Applied patch: applied successfully - Reviewed diff, makes sense to me """ Then comment 9 """ (In reply to David Nind from comment #5) > Rather than "Enqueued" I think I would prefer "Queued". Enqueued is a valid > English word, according to Oxford English Dictionary > (https://www.lexico.com/definition/enqueue). However, it is not something in > common usage or that I have come across before except in Koha. I love enqueue/dequeue and they come up a lot for me, but they do seem to be computing terms, so I am willing to admit that they probably should be reserved for backend systems and not displayed to users. I also love splitting hairs so... Should it be "Queued on" or "Queued at"? """ And don't forget there is also "Started on" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:20:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:20:33 +0000 Subject: [Koha-bugs] [Bug 27277] Queued vs Enqueued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 --- Comment #1 from Jonathan Druart --- Created attachment 114511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114511&action=edit Bug 27277: Replace 'Enqueued' with 'Queue' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:20:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:20:54 +0000 Subject: [Koha-bugs] [Bug 27277] Queued vs Enqueued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:21:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:21:59 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 --- Comment #10 from Jonathan Druart --- Last patch and discussion moved to bug 27277. This bug report is about making labels consistent, and they are with "Enqueued on" (it already exists and no additional work will be needed from translators). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:22:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:22:06 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114479|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:22:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:22:22 +0000 Subject: [Koha-bugs] [Bug 27109] Better labels for background job details In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27277 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 [Bug 27277] Queued vs Enqueued -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:22:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:22:22 +0000 Subject: [Koha-bugs] [Bug 27277] Queued vs Enqueued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27109 [Bug 27109] Better labels for background job details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:23:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:23:33 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #4 from Jonathan Druart --- Bug 27070 did not add tests so I don't know which tests would be supposed to fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:28:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:28:04 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #23 from Jonathan Druart --- (In reply to Aleisha Amohia from comment #20) > GetMarcSeries at Bug 27270 This is not used and is not needed from send-basket and send-shelves scripts. (ie. no "MARCSERIES" in templates) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:29:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:29:32 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #24 from Jonathan Druart --- (In reply to Aleisha Amohia from comment #18) > GetMarcNotes at Bug 27268 No occurrences of "GetMarcNotes" from send-basket and send-shelves scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 10:46:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 09:46:04 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #25 from Jonathan Druart --- (In reply to Aleisha Amohia from comment #17) > Starting with GetMarcAuthors at Bug 27266 Are you sure you will want to reuse that from the template notice? It seems that to answer bug 17868 you will only need to loop over the MARC subfields (for instance GetMarcAuthors is building links we don't need). Additional questions: should not we take advantage of the move to fix the inconsistencies in the return values? I don't think "just moving" code from C4 to Koha is sufficient. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 11:03:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 10:03:28 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #26 from Katrin Fischer --- (In reply to Jonathan Druart from comment #25) > (In reply to Aleisha Amohia from comment #17) > > Starting with GetMarcAuthors at Bug 27266 > > Are you sure you will want to reuse that from the template notice? > It seems that to answer bug 17868 you will only need to loop over the MARC > subfields (for instance GetMarcAuthors is building links we don't need). > > Additional questions: should not we take advantage of the move to fix the > inconsistencies in the return values? > > I don't think "just moving" code from C4 to Koha is sufficient. To further simplify things we could let go of the marcflavour parameter as this only seems to be used in context where the marcflavour of the installation is used. I think another question is if we are using them only for the notices or to replace all calls to templates - if we want to replace the other calls, we'd need to keep the links etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 11:05:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 10:05:35 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #226 from Jonathan Druart --- (In reply to David Cook from comment #225) > Aleisha, even if you don't squash them, could you let me know the parent > commit for these patches from your last rebase? See https://gist.github.com/jajm/f0b77da1a41b6b1c5ab1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 11:06:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 10:06:53 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #220 from Jonathan Druart --- (In reply to David Cook from comment #219) > Julian, what's the commit that these are based off? I'd love to apply these > to a stable base so that I could get a sense of the changes... See https://gist.github.com/jajm/f0b77da1a41b6b1c5ab1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 11:08:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 10:08:04 +0000 Subject: [Koha-bugs] [Bug 27108] Update team for 21.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27108 --- Comment #11 from Martin Renvoize --- Minor correction.. What this patch actually does is just append the 21.05 team to the end of the teams.yml file. This has the effect of adding 21.05 roles next to individuals names in the overall list of contributors and also updates the entirety of the column on the right side of the 'Koha team' page to reflect the new maintenance team for this six months (and updates the date for when these roles 'expire') In other words.. it should be backported to all maintenance versions :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 11:27:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 10:27:52 +0000 Subject: [Koha-bugs] [Bug 27108] Update team for 21.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27108 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21626 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 11:27:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 10:27:52 +0000 Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha team' page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27108 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 11:56:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 10:56:54 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #11 from Jonathan Druart --- Created attachment 114512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114512&action=edit Bug 27205: Improve logic readability in conditional -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 11:57:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 10:57:46 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #12 from Jonathan Druart --- Tomas, do you agree it reads better like that? - unless ( - !defined $pickup_library_id - or $hold->is_pickup_location_valid( - { library_id => $pickup_library_id } - ) + if ( + defined $pickup_library_id + and not $hold->is_pickup_location_valid({ library_id => $pickup_library_id }) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 11:59:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 10:59:58 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92783|0 |1 is obsolete| | Attachment #92784|0 |1 is obsolete| | Attachment #92785|0 |1 is obsolete| | Attachment #92786|0 |1 is obsolete| | Attachment #92787|0 |1 is obsolete| | Attachment #92788|0 |1 is obsolete| | Attachment #92789|0 |1 is obsolete| | Attachment #92790|0 |1 is obsolete| | Attachment #92791|0 |1 is obsolete| | Attachment #92792|0 |1 is obsolete| | Attachment #92793|0 |1 is obsolete| | Attachment #92794|0 |1 is obsolete| | Attachment #92795|0 |1 is obsolete| | Attachment #92796|0 |1 is obsolete| | Attachment #92797|0 |1 is obsolete| | Attachment #92798|0 |1 is obsolete| | --- Comment #221 from Josef Moravec --- Created attachment 114513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114513&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:00:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:00:07 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #222 from Josef Moravec --- Created attachment 114514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114514&action=edit Bug 15516: Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:00:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:00:16 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #223 from Josef Moravec --- Created attachment 114515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114515&action=edit Bug 15516: Reword 'reserve group' to 'hold group' Signed-off-by: Josef Moravec Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:00:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:00:24 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #224 from Josef Moravec --- Created attachment 114516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114516&action=edit Bug 15516: (follow-up) Fixing modal view and more Fixing - modal view - missed changes from 'reserve group' to 'hold group' - updating atomic update to perl - utf8mb4 Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:00:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:00:33 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #225 from Josef Moravec --- Created attachment 114517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114517&action=edit Bug 15516: (follow-up) Fix QA and rebase issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:00:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:00:43 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #226 from Josef Moravec --- Created attachment 114518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114518&action=edit Bug 15516: (follow-up) Fix db structure and atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:01:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:01:12 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #13 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #12) > Tomas, do you agree it reads better like that? +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:02:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:02:57 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #227 from Josef Moravec --- I rebased and squashed a bit, but this still must be considered as WIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:05:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:05:36 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #12 from Jonathan Druart --- Comment on attachment 114279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114279 Bug 24254: Add Koha::Items->filter_by_visible_in_opac Review of attachment 114279: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24254&attachment=114279) ----------------------------------------------------------------- ::: Koha/Items.pm @@ +70,5 @@ > + $search_params->{$field}->{'-not_in'} = $rules->{$field}; > + } > + > + $search_params->{itemlost}->{'<='} = 0 > + if C4::Context->preference('hidelostitems'); Where is that <= 0 coming from? >From C4::Search: 1919 # hidden because lost 1920 if ($hidelostitems && $item->{itemlost}) { 1921 $hideatopac_count++; 1922 next; 1923 } Remember that -1 is evaluated true. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:07:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:07:42 +0000 Subject: [Koha-bugs] [Bug 27014] SIP2 cannot find patrons at checkin In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27014 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:08:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:08:29 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #13 from Jonathan Druart --- Why does the method take rules in parameter? Why don't we simply build the rules from the pref in the method? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:08:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:08:51 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #14 from Jonathan Druart --- (In reply to Jonathan Druart from comment #13) > Why does the method take rules in parameter? Why don't we simply build the > rules from the pref in the method? ie. do we have other places where we have other rules? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:11:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:11:00 +0000 Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114454|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart --- Created attachment 114519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114519&action=edit Bug 14564: Set permissions on configuration backups This patch sets the group and group read permissions on configuration backups, so that they can be downloaded via the web staff interface. Test plan: 0. Apply the patch 1. cp debian/scripts/koha-dump /usr/sbin/koha-dump 2. koha-run-backups --days 2 --output /var/spool/koha 3. Note *.tar.gz backups in /var/spool/koha/kohadev now have root:kohadev-koha ownership and 640 permissions 4. vi /etc/koha/sites/kohadev/koha-conf.xml 5. Set backup_db_via_tools and backup_conf_via_tools to 1 6. echo 'flush_all' | nc -q 1 memcached 1121 7. koha-plack --restart kohadev 8. Go to http://localhost:8081/cgi-bin/koha/tools/export.pl 9. Click on "Export configuration" 10. Choose a file 11. Click Download configuration 12. Note that *.tar.gz file downloaded correctly Signed-off-by: David Cook Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:11:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:11:17 +0000 Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #19 from Jonathan Druart --- Adjusted commit date. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:12:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:12:51 +0000 Subject: [Koha-bugs] [Bug 27273] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27273 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hiii |SPAM Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:20:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:20:37 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #15 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #13) > Why does the method take rules in parameter? Why don't we simply build the > rules from the pref in the method? If it was called in a loop, we could reuse the rules. That was the idea. Maybe we should read the rules locally if the parameter was not passed at all (i.e. !exists $params->{rules}). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:23:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:23:28 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #16 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #12) > Comment on attachment 114279 [details] [review] > Bug 24254: Add Koha::Items->filter_by_visible_in_opac > > Review of attachment 114279 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Items.pm > @@ +70,5 @@ > > + $search_params->{$field}->{'-not_in'} = $rules->{$field}; > > + } > > + > > + $search_params->{itemlost}->{'<='} = 0 > > + if C4::Context->preference('hidelostitems'); > > Where is that <= 0 coming from? > > From C4::Search: > 1919 # hidden because lost > 1920 if ($hidelostitems && $item->{itemlost}) { > 1921 $hideatopac_count++; > 1922 next; > 1923 } > > Remember that -1 is evaluated true. Good catch! I overlooked the negative values here. All this was very undocumented, so I'd say we need a regression test for that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:23:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:23:39 +0000 Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #20 from Jonathan Druart --- Shouldn't it be $name-koha:$name-koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:34:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:34:18 +0000 Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 --- Comment #21 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #20) > Shouldn't it be $name-koha:$name-koha? Backups are a sysadmin thing, and there shouldn't be permissions allowing the user to delete them. St first glance. I agree with the proposed root:$name-koha and g+r combination. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 12:35:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 11:35:36 +0000 Subject: [Koha-bugs] [Bug 27278] New: FindDuplicate uses 'exact' for searching and is too strict Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 Bug ID: 27278 Summary: FindDuplicate uses 'exact' for searching and is too strict Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When using FindDuplicate to check for existing records the check for suggestions is too strict. Entering an author's name in direct order: John Jacob Jingleheiner-Schmidt Will not match Jingleheimer-Schmidt, John Jacob Entering partial title: The vixens Will not match: The vixens. A novel. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 13:19:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 12:19:37 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #17 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #15) > (In reply to Jonathan Druart from comment #13) > > Why does the method take rules in parameter? Why don't we simply build the > > rules from the pref in the method? > > If it was called in a loop, we could reuse the rules. That was the idea. > Maybe we should read the rules locally if the parameter was not passed at > all (i.e. !exists $params->{rules}). What for? Performance? If we are looping on biblios then it's not that reading the pref and building the rules that will have an impact on perf. If you are concerned about that I would cache it at package level (->{_item_hide_rules}). I think it's better to prevent calls that will forget to pass the rules, or having to update all the callers if we decide to add one rules. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 13:26:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 12:26:44 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #17) > (In reply to Tomás Cohen Arazi from comment #15) > > (In reply to Jonathan Druart from comment #13) > > > Why does the method take rules in parameter? Why don't we simply build the > > > rules from the pref in the method? > > > > If it was called in a loop, we could reuse the rules. That was the idea. > > Maybe we should read the rules locally if the parameter was not passed at > > all (i.e. !exists $params->{rules}). > > What for? Performance? > If we are looping on biblios then it's not that reading the pref and > building the rules that will have an impact on perf. If you are concerned > about that I would cache it at package level (->{_item_hide_rules}). > > I think it's better to prevent calls that will forget to pass the rules, or > having to update all the callers if we decide to add one rules. > > What do you think? I usually prefer explicit vs. implicit. But not a strong position on this particular case. The 'if passed use it, if not, read it' approach seems to me like the best compromise option. This could be a follow-up bug (it requires new tests, probably adapt the callers) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:02:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:02:16 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion Keywords|release-notes-needed | --- Comment #19 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #18) > (In reply to Jonathan Druart from comment #17) > > (In reply to Tomás Cohen Arazi from comment #15) > > > (In reply to Jonathan Druart from comment #13) > > > > Why does the method take rules in parameter? Why don't we simply build the > > > > rules from the pref in the method? > > > > > > If it was called in a loop, we could reuse the rules. That was the idea. > > > Maybe we should read the rules locally if the parameter was not passed at > > > all (i.e. !exists $params->{rules}). > > > > What for? Performance? > > If we are looping on biblios then it's not that reading the pref and > > building the rules that will have an impact on perf. If you are concerned > > about that I would cache it at package level (->{_item_hide_rules}). > > > > I think it's better to prevent calls that will forget to pass the rules, or > > having to update all the callers if we decide to add one rules. > > > > What do you think? > > I usually prefer explicit vs. implicit. But not a strong position on this > particular case. The 'if passed use it, if not, read it' approach seems to > me like the best compromise option. This could be a follow-up bug (it > requires new tests, probably adapt the callers) I don't think it's explicit vs implicit. ->filter_by_visible_in_opac is explicit already. If you are passing a set of rules then it would be ->filter_by_rules As I said I am also concerned about the need to update the callers if rules are added. If we agree on that it should be done on this bug report, not a follow-up bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:06:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:06:32 +0000 Subject: [Koha-bugs] [Bug 27108] Update team for 21.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27108 --- Comment #12 from Andrew Fuerste-Henry --- Phew! I did ponder this one a while, glad I jumped the right way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:08:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:08:45 +0000 Subject: [Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:15:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:15:03 +0000 Subject: [Koha-bugs] [Bug 27087] Allow encoding level comparison on record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27087 --- Comment #2 from Andrew Fuerste-Henry --- So maybe a broader move to allow match checks to use a comparison other than equals? So we'd set a target subfield in the incoming record, a target subfield in the existing record, and a comparison operator? But the values on the encoding level aren't strictly numeric. "#" is the "best" value, followed by 1-8, then "u" for unknown and "z" for not applicable (https://www.loc.gov/marc/bibliographic/bdleader.html). We could hardcode that hierarchy for encoding level, but it seems likely other bits of MARC have comparably idiosyncratic sets of values. Should the match check setup include a mechanism for telling Koha an order of preference for possible values? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:22:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:22:32 +0000 Subject: [Koha-bugs] [Bug 18772] t/ImportBatch.t noise In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18772 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:22:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:22:32 +0000 Subject: [Koha-bugs] [Bug 25515] Remove warnings and errors from tests output In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18772 [Bug 18772] t/ImportBatch.t noise -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:27:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:27:28 +0000 Subject: [Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Blocks| |7806, 17258 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #1 from Jonathan Druart --- It's a bug. Lowering severity a bit however. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 [Bug 7806] Don't use 0000-00-00 to signal a non-existing date https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:27:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:27:28 +0000 Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:27:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:27:28 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27276 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:27:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:27:36 +0000 Subject: [Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|20.11 |unspecified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:29:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:29:42 +0000 Subject: [Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:29:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:29:45 +0000 Subject: [Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 --- Comment #2 from Jonathan Druart --- Created attachment 114520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114520&action=edit Bug 27276: Prevent borrowers-force-messaging-defaults.pl to crash MySQL 5.7 does not allow queries using 0000-00-00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:30:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:30:24 +0000 Subject: [Koha-bugs] [Bug 27276] borrowers-force-messaging-defaults throws Incorrect DATE value: '0000-00-00' even though sql strict mode is dissabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27276 --- Comment #3 from Jonathan Druart --- Stefan, can you try this patch? (I haven't tested it yet!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:43:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:43:43 +0000 Subject: [Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:43:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:43:46 +0000 Subject: [Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 --- Comment #2 from Jonathan Druart --- Created attachment 114521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114521&action=edit Bug 27245: Replace AutoCommit=0 with txn_begin in bulkmarcimport.pl To prevent DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1588, line 1. Test plan: Export more than 100 records Use bulkmarcimport (with -commit=10) to import them Modify a record to make the import fail (for instance having a too long lccn) Use bulkmarcimport (with -commit=10) to import them Notice that the import stops but that the imported record are imported (a part from the last batch of 10) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:43:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:43:56 +0000 Subject: [Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:47:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:47:16 +0000 Subject: [Koha-bugs] [Bug 14973] Add an alert during purchase suggestion submissions to warn the user when an existing biblio appears to satisfy the request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27278 --- Comment #64 from Jonathan Druart --- (In reply to Jonathan Druart from comment #38) > Séverine, this is how FindDuplicate works so far. If we want to improve its > behavior we should done it on a separate bug report. It is out of the scope > of this one. See bug 27278. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:47:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:47:16 +0000 Subject: [Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 [Bug 14973] Add an alert during purchase suggestion submissions to warn the user when an existing biblio appears to satisfy the request -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:48:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:48:48 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #20 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #19) > (In reply to Tomás Cohen Arazi from comment #18) > > (In reply to Jonathan Druart from comment #17) > > > (In reply to Tomás Cohen Arazi from comment #15) > > > > (In reply to Jonathan Druart from comment #13) > > > > > Why does the method take rules in parameter? Why don't we simply build the > > > > > rules from the pref in the method? > > > > > > > > If it was called in a loop, we could reuse the rules. That was the idea. > > > > Maybe we should read the rules locally if the parameter was not passed at > > > > all (i.e. !exists $params->{rules}). > > > > > > What for? Performance? > > > If we are looping on biblios then it's not that reading the pref and > > > building the rules that will have an impact on perf. If you are concerned > > > about that I would cache it at package level (->{_item_hide_rules}). > > > > > > I think it's better to prevent calls that will forget to pass the rules, or > > > having to update all the callers if we decide to add one rules. > > > > > > What do you think? > > > > I usually prefer explicit vs. implicit. But not a strong position on this > > particular case. The 'if passed use it, if not, read it' approach seems to > > me like the best compromise option. This could be a follow-up bug (it > > requires new tests, probably adapt the callers) > > I don't think it's explicit vs implicit. > ->filter_by_visible_in_opac is explicit already. > If you are passing a set of rules then it would be ->filter_by_rules > As I said I am also concerned about the need to update the callers if rules > are added. > If we agree on that it should be done on this bug report, not a follow-up > bug. I understand your point, and agree. I've also reviewed how syspref caching works, and I belive there's no need for the optimization by design I was thinking about. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:53:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:53:24 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 14:53:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 13:53:27 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 --- Comment #1 from Kyle M Hall --- Created attachment 114522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114522&action=edit Bug 27265: Enable message queue cron to accept multiple codes and types It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines Test Plan: 1) Apply this patch 2) Run process_message_queue.pl with a single -c parameter 3) Note behavior is unchanged 4) Run process_message_queue.pl with multiple -c parameters 5) Note all the codes specified are processed 6) Repeat 2-5 with -t for type limits -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:00:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:00:50 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114522|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 114523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114523&action=edit Bug 27265: Enable message queue cron to accept multiple codes and types It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines Test Plan: 1) Apply this patch 2) Run process_message_queue.pl with a single -c parameter 3) Note behavior is unchanged 4) Run process_message_queue.pl with multiple -c parameters 5) Note all the codes specified are processed 6) Repeat 2-5 with -t for type limits -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:02:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:02:00 +0000 Subject: [Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 Séverine Queune changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:02:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:02:06 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114057|0 |1 is obsolete| | --- Comment #7 from Emmi Takkinen --- Created attachment 114524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114524&action=edit Bug 26498: Set default expiration date for holds Koha doesn't automatically set expiration date for holds so they can live in the system forever. This patch adds new sysprefs to control setting of default expiration date for holds. Note that expiration date is only set if input field for it is left blank. To test: 1. Apply patch and update database. 2. Enable syspref "DefaultHoldExpirationdate" and set some values to "DefaultHoldExpirationdatePeriod" and "DefaultHoldExpirationdateUnitOfTime". 3. Add some holds for patron from staff client or OPAC and leave expiration date input field blank. => Holds expiration date should be set according your settings 4. Disable "DefaultHoldExpirationdate" and repeat step 3. => Expiration date shouldn't be set. Also prove prove t/db_dependent/Hold.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:02:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:02:08 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114523|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 114525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114525&action=edit Bug 27265: Enable message queue cron to accept multiple codes and types It would be nice to be able to combine several types in a single run, but exclude others, without having to have multiple cron lines Test Plan: 1) Apply this patch 2) Run process_message_queue.pl with a single -c parameter 3) Note behavior is unchanged 4) Run process_message_queue.pl with multiple -c parameters 5) Note all the codes specified are processed 6) Repeat 2-5 with -t for type limits -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:02:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:02:27 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:04:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:04:22 +0000 Subject: [Koha-bugs] [Bug 14973] Add an alert during purchase suggestion submissions to warn the user when an existing biblio appears to satisfy the request In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #65 from Séverine Queune --- (In reply to Jonathan Druart from comment #64) > (In reply to Jonathan Druart from comment #38) > > Séverine, this is how FindDuplicate works so far. If we want to improve its > > behavior we should done it on a separate bug report. It is out of the scope > > of this one. > > See bug 27278. Thanks ! 👍 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:08:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:08:26 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #8 from Emmi Takkinen --- Either "DefaultHoldExpirationdatePeriod" or "DefaultHoldExpirationdateUnitOfTime" was left undefined causing Datetime error. Added missing default values for all sysprefs and clarified test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:11:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:11:04 +0000 Subject: [Koha-bugs] [Bug 25026] RaiseError must be set for the UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:20:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:20:23 +0000 Subject: [Koha-bugs] [Bug 27274] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27274 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Hiii |SPAM CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:20:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:20:29 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |andrew at bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.07 released in| | --- Comment #21 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:20:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:20:37 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:22:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:22:46 +0000 Subject: [Koha-bugs] [Bug 27279] New: "Checked out by" not populated on issuehistory.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27279 Bug ID: 27279 Summary: "Checked out by" not populated on issuehistory.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Activating the sypref RecordStaffUserOnCheckout, the librarian who checked out the item is not displayed on "Checkout history" tab on biblio view as it's described in release notes for bug 23916. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:23:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:23:40 +0000 Subject: [Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:23:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:23:55 +0000 Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26997 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:23:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:23:55 +0000 Subject: [Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 [Bug 7806] Don't use 0000-00-00 to signal a non-existing date -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:26:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:26:36 +0000 Subject: [Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113495|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 114526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114526&action=edit Bug 26997: Fix upgrade process under MySQL 8 If you are coming from an old version of Koha, you may face an upgrade error for the SQL query using 0000-00-00. The idea was to fix it, but actually the DBMS will raise an error (not blocking the upgrade process however). We can hide them to not cause confusion Errors are like: DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "UPDATE suggestions SET suggesteddate = '1970-01-01' WHERE suggesteddate = '0000-00-00';"] at /kohadevbox/koha/installer/data/mysql/updatedatabase.pl line 23312. Test plan: Checkout an old version of Koha (3.20, not older) Insert a dump, install Koha Checkout a recent version of Koha, apply the patch (or use master) Execute the upgrade process You should not see the errors Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:26:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:26:38 +0000 Subject: [Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113600|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 114527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114527&action=edit Bug 26997: Remove 0000-00-00 from aqorders.datecancellationprinted This patch remove the 0000-00-00 from the WHERE condition from ordered.pl and spent.pl to prevent an error under MySQL 8 It also fixes the wrong values in DB (if possible, ie. under other DBMS that MySQL 8) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:27:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:27:06 +0000 Subject: [Koha-bugs] [Bug 26997] Database Mysql Version 8.0.22 failed to Update During Upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26997 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- I've tested this myself now and am happy with the result.. signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:56:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:56:26 +0000 Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:56:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:56:30 +0000 Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 --- Comment #9 from Jonathan Druart --- Created attachment 114528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114528&action=edit Bug 7806: Fix remaining occurrences of 0000-00-00 We should remove all SQL queries that contain 0000-00-00 and finally assume we do not longer have such value in our DB (for date type) We already dealt with such values in previous update DB entries. The 2 added by this one haven't been replaced already. The code will now assume that either a valid date exist, or NULL/undef. Test plan: QA review is needed and test of the different places where code is modified. Not sure about the change from reports/issues_avg_stats.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:56:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:56:54 +0000 Subject: [Koha-bugs] [Bug 7806] Don't use 0000-00-00 to signal a non-existing date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:58:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:58:14 +0000 Subject: [Koha-bugs] [Bug 17320] MySQL 5.7 doesn't work well with SQL using '0000-00-00' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #12 from Jonathan Druart --- After bug 7806 we will assume that we reached a stable state. Please reopen bug reports if still happened when pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 15:58:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 14:58:14 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Bug 17258 depends on bug 17320, which changed state. Bug 17320 Summary: MySQL 5.7 doesn't work well with SQL using '0000-00-00' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 16:23:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 15:23:08 +0000 Subject: [Koha-bugs] [Bug 27026] New circulation rule "Days mode" values are not explained anywhere In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27280 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 [Bug 27280] Explanation for "Days mode" is not consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 16:23:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 15:23:08 +0000 Subject: [Koha-bugs] [Bug 27280] New: Explanation for "Days mode" is not consistent Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Bug ID: 27280 Summary: Explanation for "Days mode" is not consistent Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Depends on: 27026 We have "Skip closed days" in the dropdown, but "Calendar" on the table. Both must match Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27026 [Bug 27026] New circulation rule "Days mode" values are not explained anywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 16:25:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 15:25:05 +0000 Subject: [Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 16:25:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 15:25:08 +0000 Subject: [Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 --- Comment #1 from Jonathan Druart --- Created attachment 114529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114529&action=edit Bug 27280: (bug 27026 follow-up) Make consistent the explanation for "Days mode" We have "Skip closed days" in the dropdown, but "Calendar" on the table. Both must match Test plan: Go to the circ rules, select a value for "Days mode", save the rule, confirm that the dropdown list values are matching the ones we displayed in the cells -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 16:30:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 15:30:57 +0000 Subject: [Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 16:30:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 15:30:59 +0000 Subject: [Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Caroline Cyr La Rose changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114529|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose --- Created attachment 114530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114530&action=edit Bug 27280: (bug 27026 follow-up) Make consistent the explanation for "Days mode" We have "Skip closed days" in the dropdown, but "Calendar" on the table. Both must match Test plan: Go to the circ rules, select a value for "Days mode", save the rule, confirm that the dropdown list values are matching the ones we displayed in the cells Signed-off-by: Caroline Cyr La Rose -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 16:35:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 15:35:43 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Janet McGowan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 17:07:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 16:07:26 +0000 Subject: [Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 --- Comment #8 from Caroline Cyr La Rose --- Test plan : 1) In Administration > Global system preferences, enable QuoteOfTheDay in both OPAC and staff interface 2) Go to Tools > Edit quotes for QOTD feature Add new quote 3) Click New quote 4) Enter a Source and a Text 5) Click Submit --> There should be a message saying "Quote added successfully." and the added quote should appear in the table. Edit quote 6) Click Edit next to a quote 7) Change the source or the text 8) Click Submit --> There should be a message saying "Quote updated successfully." and the change should be visible in the table Delete a quote 9) Click Delete next to a quote 10) Click Delete again in the confirmation box --> There should be a message saying "Quote #X was deleted successfully." and the quote should not be in the table anymore View quote in the staff interface 11) Go to Koha' staff interface's home page --> Under the news blocks, there should be a block called "Quote of the day" with a quote and source from the table View quote in the OPAC 12) Go to the OPAC's home page --> Under the news blocks, there should be a block called "Quote of the day" with the same quote. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 17:15:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 16:15:57 +0000 Subject: [Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 --- Comment #9 from Caroline Cyr La Rose --- Everything works well with the patch! :) The only things left to correct are the capitalizations and one space: - New Quote should be New quote on the New quote button - text should be Text in the form to add a quote - There should be a space between the trash can and the word Delete on the Delete button - In the staff interface, Quote of the Day should be Quote of the day in the title of the block (this was not introduced by this patch, the capitalization was wrong before) Should these go in another bug? I'm also mentioning this, but it doesn't bother me too much: we lost the ability to import quote from a csv and we lost the ability to select multiple quotes to delete. I'll leave it to QA to decide if those two functions are essential and should be re-added. Caroline -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:01:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:01:18 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:01:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:01:22 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111368|0 |1 is obsolete| | --- Comment #64 from Andrew Fuerste-Henry --- Created attachment 114531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114531&action=edit Bug 8137: Add Default checkout limit by patron category with priority. This patch add the ability to make a 'Default checkout limit by patron category' rule has priority. When a rule has priority, it overrides all others for the same categorycode. For "normal" rule, the behavior is the same than before (like a default rule if no one is specified at branch level). Rule with priority can only be created on the circulation and fine rules page for *all libraries*. The goal is to allow librarian to limit the total number of checkouts by patron category for all libraries. test plan: - Create a rule with 4 checkouts allowed in default checkout limit table for a patron category and make it has priority, - create more permissive rules for all other branches (at least 5 checkouts allowed), - Checkout items of different branches for a patron with the same category, - Patron should be limited to 4 checkouts https://bugs.koha-community.org/show_bug.cgi?id=8137 Rebased: 2018-03-14, by: Alex Arnaud Rebased: 2020-07-23, by: Arthur Suzuki Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:01:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:01:28 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111369|0 |1 is obsolete| | --- Comment #65 from Andrew Fuerste-Henry --- Created attachment 114532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114532&action=edit Bug 8137: Add default issuing rule for all branches. This patch does the same that for 'Default checkout limit by patron category'. test plan: - Create an issuing rule a patron category and itemtype. make it has priority, - create more permissive issuing rules for all other branches, - check that the priority rule is taken into account for this category and itemtype. Rebased: 2018-03-14, by: Alex Arnaud Rebased: 2020-07-34, by: Arthur Suzuki Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:01:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:01:33 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112640|0 |1 is obsolete| | --- Comment #66 from Andrew Fuerste-Henry --- Created attachment 114533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114533&action=edit Bug 8137: (follow-up) Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:01:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:01:38 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113882|0 |1 is obsolete| | --- Comment #67 from Andrew Fuerste-Henry --- Created attachment 114534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114534&action=edit Bug 8137: (follow-up) Fix error on the rules cloning functionality Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:07:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:07:39 +0000 Subject: [Koha-bugs] [Bug 22569] Add a 'Transfers to send' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|25753 |26618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:07:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:07:39 +0000 Subject: [Koha-bugs] [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22569 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Add a 'Transfers to send' report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:07:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:07:39 +0000 Subject: [Koha-bugs] [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Add a 'Transfers to send' report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:08:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:08:17 +0000 Subject: [Koha-bugs] [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26618 |22569 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Add a 'Transfers to send' report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:08:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:08:17 +0000 Subject: [Koha-bugs] [Bug 22569] Add a 'Transfers to send' report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25753 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:08:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:08:17 +0000 Subject: [Koha-bugs] [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25753 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753 [Bug 25753] Replace transferbook in circ/branchtransfers with Koha::Object method calls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:22:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:22:45 +0000 Subject: [Koha-bugs] [Bug 27281] New: Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem` Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281 Bug ID: 27281 Summary: Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem` Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We should remove C4::Circulation::DeleteTransfer. We can use Koha::Item::Transfer->cancel in preference to it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:23:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:23:19 +0000 Subject: [Koha-bugs] [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem` In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26057 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26057 [Bug 26057] Add Koha::Item::Transfer->cancel method -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:23:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:23:19 +0000 Subject: [Koha-bugs] [Bug 26057] Add Koha::Item::Transfer->cancel method In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26057 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281 [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:23:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:23:55 +0000 Subject: [Koha-bugs] [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem` In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:23:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:23:55 +0000 Subject: [Koha-bugs] [Bug 22160] OMNIBUS: Transfers enhancements In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27281 [Bug 27281] Replace call to `C4::Circulation::DeleteTransfer` with `Koha::Item::Transfer->cancel({ comment => $comment })` in `C4::Circulation::LostItem` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:27:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:27:21 +0000 Subject: [Koha-bugs] [Bug 27282] New: Print List (shelves.pl) broken in Chrome Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Bug ID: 27282 Summary: Print List (shelves.pl) broken in Chrome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In more recent version of Chrome if you go to /cgi-bin/koha/virtualshelves/shelves.pl and attempt to 'Print list' the dialog pops up and immediately closes. We fixed this problem in the OPAC with Bug 24061, the same fix is needed in the staff client on shelves.pl Read Bug 24061 for much of the details. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:30:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:30:57 +0000 Subject: [Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:30:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:30:59 +0000 Subject: [Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 --- Comment #1 from Lucas Gass --- Created attachment 114535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114535&action=edit Bug 27282: Add window.onafterprint function TO TEST: -set up a new list with a few items -go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and clear cache -Try again, the print dialouge remains open -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:31:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:31:14 +0000 Subject: [Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:44:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:44:09 +0000 Subject: [Koha-bugs] [Bug 26785] JS errors in pos/pay.tt in 20.05.x In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26785 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:44:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:44:19 +0000 Subject: [Koha-bugs] [Bug 26548] [20.05] Update for 20.05.03.001 has wrong SQL In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26548 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:44:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:44:49 +0000 Subject: [Koha-bugs] [Bug 26361] JS error on returns.tt in 20.05 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26361 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:45:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:45:22 +0000 Subject: [Koha-bugs] [Bug 26131] console errors when attempting to open SCO related system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 18:45:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 17:45:22 +0000 Subject: [Koha-bugs] [Bug 15851] Only display "Analytics: Show analytics" when records have linked analytics In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15851 Bug 15851 depends on bug 26131, which changed state. Bug 26131 Summary: console errors when attempting to open SCO related system preferences https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26131 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 20:53:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 19:53:48 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 --- Comment #10 from Nick Clemens --- Created attachment 114536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114536&action=edit Bug 27166: [20.05.x] Set destination_loc to item->homebranch In bug 21020 we used the issue to fetch the item and then the homebranch. This fails when the item is not issued. We fetch the item already, so we can use it directly In 20.05.x we don't have the item object, so we can just use the SIP transaction item To test: 1 - Have an item belonging to branch A 2 - Check it in via sip at branch B: perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --item CHESS1 -l FPL -m checkin 3 - The read command is blank and there is a warn about uninitialized data 4 - Apply patch 5 - Restart sip server 6 - Check the item in at branch A using the sip cli emulator 7 - Check it in at branch B 8 - This time the checkin should succeed and the output msg should be included Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 21:07:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 20:07:09 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | --- Comment #11 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 21:29:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 20:29:00 +0000 Subject: [Koha-bugs] [Bug 24658] Deleting items with fines does not update itemnumber in accountlines to NULL causing ISE In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24658 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com --- Comment #20 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 22:32:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 21:32:08 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #22 from Victor Grousset/tuxayo --- Got a conflict when backporting from 20.05.x to 19.11.x Tried to fix by selecting the 3rd section (Bug 26536: Assignment fix) <<<<<<< HEAD $payment_id = $account->pay( ||||||| parent of 6d302b741c (Bug 26536: Assignment fix) $pay_result = $payment_id = $account->pay( ======= $pay_result = $account->pay( >>>>>>> 6d302b741c (Bug 26536: Assignment fix) { amount => $total_paid, library_id => $library_id, note => $note, payment_type => $payment_type, interface => C4::Context->interface, payment_type => $payment_type, cash_register => $registerid } ); $payment_id = $pay_result->{payment_id}; } print $input->redirect("/cgi-bin/koha/members/boraccount.pl?borrowernumber=$borrowernumber&payment_id=$payment_id&change_given=$change_given"); } } But when writing off, I got this error: Could not compile /kohadevbox/koha/members/paycollect.pl: Global symbol "$pay_result" requires explicit package name It's not clear either if 19.11.x is affected. I'm not sure I did the test plan right to confirm the issue. Does anyone have hints? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 22:51:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 21:51:01 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #5 from Victor Grousset/tuxayo --- I thought searching with ES6 would be broken by default. And thus that some tests would fail. Because the syspref would allow to choose to have ES 6 working or ES 5 working and would default to ES 5. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 23:03:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 22:03:57 +0000 Subject: [Koha-bugs] [Bug 25811] authentication.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25811 --- Comment #29 from Victor Grousset/tuxayo --- (In reply to Victor Grousset/tuxayo from comment #1) > Reproduced after: > - first try > - 14 tries > - first try Should be fixed with bug 27055, the whole test suite was stable during more than a whole night of looping. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 18 23:17:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 18 Dec 2020 22:17:31 +0000 Subject: [Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in| |19.05.17 --- Comment #13 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 19 04:40:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Dec 2020 03:40:10 +0000 Subject: [Koha-bugs] [Bug 27161] Base.pm complains about unitialized value In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27161 --- Comment #7 from Alvaro Cornejo --- (In reply to Fridolin Somers from comment #6) > if ( $metadata & $metadata !~ "") > > second test is useless I think, > if ($metadata) with skip undefined, empty string and 0 Yes, I thought that but with only one of the tests there are still "undefined" variable errors. Not sure why, but with both tests error does not show anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 19 06:02:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Dec 2020 05:02:32 +0000 Subject: [Koha-bugs] [Bug 27283] New: Hshehehehhehe Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27283 Bug ID: 27283 Summary: Hshehehehhehe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: ayarsj417 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114537&action=edit Hsheueheheh -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 19 06:28:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Dec 2020 05:28:09 +0000 Subject: [Koha-bugs] [Bug 27283] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27283 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|Hshehehehhehe |SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 19 07:15:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Dec 2020 06:15:58 +0000 Subject: [Koha-bugs] [Bug 27284] New: We are anonymous Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27284 Bug ID: 27284 Summary: We are anonymous Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: soulfisionyt at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Created attachment 114538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114538&action=edit SoulFision -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 19 14:27:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Dec 2020 13:27:43 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 114539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114539&action=edit Bug 24354: Compare itemlost with Perl's false values On C4::Search and C4::Circulation the uses of the items.itemlost field highlight the fact that the comparisson itemlost <= 0 was wrong, as it is evaluated as a Perl boolean. As authorised values can take many values that can be casted to 'false', we need to compare with them explicitly. This patch changes the tests to reflect this, and adjust the Koha::Items->filter_by_visible_in_opac implementation to adapt to this. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 19 14:27:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Dec 2020 13:27:48 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 114540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114540&action=edit Bug 24254: Read the OpacHiddenItems preference internally After discussing the 'rules' parameter usefulness we decided it was not the best idea, and the gains in terms of 'performance' would me meaningless (in-memory caching of sysprefs). This patch makes a really minor tweak to the tests so they mock the C4::Context->yaml_preference method, but keeping the same original rules to highlight no behaviour change takes place. Then the rules parameter is removed from the calls, and the tests should keep passing. A minor change to make $rules = undef is made to highlight the // {} behaviour when reading the syspref.. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 19 14:30:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Dec 2020 13:30:17 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #23 from Tomás Cohen Arazi --- Hi y'all. I've adapted the implementation to: 1. Fix the itemlost value comparisson (bug). 2. Remove the rules parameter and read it inside the method (design issue). Setting back to NSO so it gets your eyes on it again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 19 14:30:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Dec 2020 13:30:34 +0000 Subject: [Koha-bugs] [Bug 27284] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27284 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED Summary|We are anonymous |SPAM -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 19 14:48:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Dec 2020 13:48:44 +0000 Subject: [Koha-bugs] [Bug 27285] New: Mansor Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27285 Bug ID: 27285 Summary: Mansor Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: sandalketek at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114541&action=edit Mansor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Dec 19 14:56:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 19 Dec 2020 13:56:46 +0000 Subject: [Koha-bugs] [Bug 27285] SPAM In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27285 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Mansor |SPAM Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 16:29:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 15:29:08 +0000 Subject: [Koha-bugs] [Bug 26849] Fix Array::Utils dependency in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114270|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 114542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114542&action=edit Bug 26849: Fix Array::Utils dependency in cpanfile Since bug 26434, if the module is missing Koha does not start. So it should be marked as required Signed-off-by: Mason James Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 16:30:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 15:30:26 +0000 Subject: [Koha-bugs] [Bug 26849] Fix Array::Utils dependency in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #5 from Victor Grousset/tuxayo --- > if the module is missing Koha does not start yep, bumped into this during RMaint a few months ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 17:17:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 16:17:55 +0000 Subject: [Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114291|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 114543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114543&action=edit Bug 26941: Fix OPAC password recovery error messages In OPAC password recovery perl opac/opac-password-recovery.pl there are some error codes not in Template koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt This patch fixes several bugs: - remove 'use Koha::Patrons' defined twice - remove vars $errTooManyEmailFound $errBadEmail, not used in any template - add in template text for error 'errNoBorrowerEmail' 1) Create a patron A with login but no email 2) Create a patron B with login and valid email 3) Go to system preferences set 'OpacResetPassword' to ON 4) Make sure that OpacPasswordChange is also ON 5) Go to 'Forgot your password' in OPAC 6) Enter login if patron A and save => You get message 'This account has no email address we can send the email to.' 7) Enter login if patron B and save => Password recovery is send, no error message Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 17:19:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 16:19:26 +0000 Subject: [Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor at tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- works, QA script ok, code looks good -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 18:46:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 17:46:49 +0000 Subject: [Koha-bugs] [Bug 22005] System preference DecreaseLoanHighHolds incorrectly counts the number of holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22005 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Victor Grousset/tuxayo --- Conflicts in t/db_dependent/DecreaseLoanHighHolds.t Tried to get my head around this, sorry couldn't review all the test changes. First time learning about decreaseLoanHighHolds. Maybe the review should be left only for QA? I seems there isn't much people that can review this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 20:48:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 19:48:34 +0000 Subject: [Koha-bugs] [Bug 27043] Add to number_of_replicas and number_of_shards to index config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27043 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113734|0 |1 is obsolete| | --- Comment #2 from Victor Grousset/tuxayo --- Created attachment 114544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114544&action=edit Bug 27043: Add to number_of_replicas and number_of_shards to index config With Elasticsearch 6 (>6.4), we have a warning on index creation : the default number of shards will change from [5] to [1] in 7.0.0 See https://github.com/elastic/elasticsearch/pull/30587 I propose to add number_of_shards in index config. Also add number_of_replicas that is better explicit. In case on only one node, it must be 0. Test plan : 1) Use Elasticsearch 2) Apply patch and flush memcached 3) Rebuild indexes : misc/search_tools/rebuild_elasticsearch.pl -v -b -d 4) Check you dont have a warning about number of shards 5) Check the settings of index : curl ':9200/_biblios/_settings?pretty&filter_path=**.number_of_*' 6) You should see : "number_of_shards" : "5", "number_of_replicas" : "1" Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 20:49:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 19:49:27 +0000 Subject: [Koha-bugs] [Bug 27043] Add to number_of_replicas and number_of_shards to index config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27043 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Needs Signoff |Signed Off --- Comment #3 from Victor Grousset/tuxayo --- Thanks Frido :D Testing note: In koha-testing-docker, step 5) is curl 'es:9200/koha_kohadev_biblios/_settings?pretty&filter_path=**.number_of_*' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 20:49:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 19:49:55 +0000 Subject: [Koha-bugs] [Bug 27043] Add to number_of_replicas and number_of_shards to index config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27043 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 20:49:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 19:49:55 +0000 Subject: [Koha-bugs] [Bug 25439] [Omnibus] Prepare Koha to ElasticSearch 7 - ES7 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25439 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27043 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27043 [Bug 27043] Add to number_of_replicas and number_of_shards to index config -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 20:58:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 19:58:01 +0000 Subject: [Koha-bugs] [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 --- Comment #2 from Aleisha Amohia --- Good tip, Tomás! I'll do that when I begin this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 21:16:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 20:16:41 +0000 Subject: [Koha-bugs] [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3150 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 [Bug 3150] Move emails for sending cart and list contents into notices tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 21:16:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 20:16:41 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27268 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27268 [Bug 27268] Move C4::Biblio::GetMarcNotes to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 21:32:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 20:32:33 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #27 from Aleisha Amohia --- Ah I see what you're both saying. i'll give that a go -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 23:18:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 22:18:30 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #28 from Tomás Cohen Arazi --- In my opinion, we should pass Koha::Object(s) to the template as much as possible. It will be much easier to document the things that are available for rendering, as opposed to the current situation, on which it is not straight forward to know what is available in which context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 20 23:51:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 22:51:16 +0000 Subject: [Koha-bugs] [Bug 27087] Allow encoding level comparison on record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27087 --- Comment #3 from David Cook --- (In reply to Andrew Fuerste-Henry from comment #2) > So maybe a broader move to allow match checks to use a comparison other than > equals? So we'd set a target subfield in the incoming record, a target > subfield in the existing record, and a comparison operator? > I'd say a broader move to allow match points to use comparisons other than equals. (LDR and control fields don't have subfields.) > But the values on the encoding level aren't strictly numeric. "#" is the > "best" value, followed by 1-8, then "u" for unknown and "z" for not > applicable (https://www.loc.gov/marc/bibliographic/bdleader.html). We could > hardcode that hierarchy for encoding level, but it seems likely other bits > of MARC have comparably idiosyncratic sets of values. Should the match check > setup include a mechanism for telling Koha an order of preference for > possible values? Mmm that's an interesting wrinkle. That's a lot more complicated. Perhaps we should look at plugins for record matching rules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 00:29:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 23:29:06 +0000 Subject: [Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #14 from David Cook --- I think that this is a beneficial change, as I have a library generating thousands of duplicates due to getting too many search results (due to a Zebra ICU bug it seems). However, I've been thinking it might be good if we can prevent cataloguing editor saves if we can't link headings to authorities, or provide a summary of the linking. The latter would be better for batch imports. I mention this here only because interested parties CCed here might have thoughts... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 00:31:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 20 Dec 2020 23:31:28 +0000 Subject: [Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 02:45:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 01:45:16 +0000 Subject: [Koha-bugs] [Bug 26641] link_bibs_to_authorities.pl: Add the ability to specify the MARC field to operate on In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26641 --- Comment #18 from David Cook --- It's a shame that we didn't make this a repeatable option... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 03:12:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 02:12:43 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114127|0 |1 is obsolete| | --- Comment #29 from Aleisha Amohia --- Created attachment 114545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114545&action=edit Bug 3150: WIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 03:14:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 02:14:28 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #30 from Aleisha Amohia --- I've made some starting changes to the notices to use Koha::Biblio objects mostly (you can see it in the atomic update in the patch). I need some guidance/help with a few things: - I wasn't sure where to get the dewey and classification info from - I wasn't sure which notes field to use (biblioitems or biblio) - the Author and Subjects subroutines are the hardest for me to refactor because I'm not sure how different libraries use them Some feedback would be great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 08:20:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 07:20:38 +0000 Subject: [Koha-bugs] [Bug 27286] New: Patron picture-upload.pl allows arbitrary file extension during upload Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27286 Bug ID: 27286 Summary: Patron picture-upload.pl allows arbitrary file extension during upload Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: saiful at semanticconsulting.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 114546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114546&action=edit Double extension or wrong extension in picture file upload The IT team has flagged two issues with the picture upload tool (Patron Images feature): 1. The tool allows upload of files with double extension. 2. The tool allows upload of files with arbitrary file extension. In essence, the tool does not validate the image file restriction that is mentioned in the top of upload input tag which is: "Only PNG, GIF, JPEG, XPM formats are supported." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 08:22:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 07:22:39 +0000 Subject: [Koha-bugs] [Bug 27286] Patron picture-upload.pl allows arbitrary file extension during upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27286 Saiful Amin changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |saiful at semanticconsulting.c | |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 08:25:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 07:25:14 +0000 Subject: [Koha-bugs] [Bug 27286] Patron picture-upload.pl allows arbitrary file extension during upload In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27286 Saiful Amin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #1 from Saiful Amin --- I have tested the following changes to fix both the issues. Need someone to test and approve (I don't have the full environment to submit the patch). /usr/share/koha/intranet/cgi-bin/tools/picture-upload.pl Line: 96++ output_and_exit( $input, $cookie, $template, 'wrong_image_file_ext' ) unless $uploadfilename =~ m/^[^\.]+\.(png|gif|jpg|jpeg|xpm)$/i; /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/includes/blocking_errors.inc Line: 9++ [% CASE 'wrong_image_file_ext' %]
    Wrong image file extension or double extension in file name
    -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:01:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:01:00 +0000 Subject: [Koha-bugs] [Bug 25811] authentication.t is failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25811 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED --- Comment #30 from Jonathan Druart --- Marked as pushed, will follow-up on a separate bug report if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:01:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:01:01 +0000 Subject: [Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Bug 25551 depends on bug 25811, which changed state. Bug 25811 Summary: authentication.t is failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25811 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:04:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:04:48 +0000 Subject: [Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #24 from Johanna Räisä --- (In reply to David Cook from comment #23) > (In reply to Johanna Räisä from comment #21) > > Do you mean putting Koha's internal link to authority linking subfield? > > > > I'm not 100% sure what you mean, but I think so, yes. I meant that the authid would be changed to URI and saved that instead of integer value. > > > We are using national metadata repository and mainly the URI in $0 subfield > > has a link to that. It might be a good idea that Koha would use URI in > > authority linking subfield also. > > > > Yeah that sounds good to me. So you wouldn't be storing authority records in > Koha? No we won't. > > > We are facing problem with this $9 subfield because it is used in our > > national metadata repository for other things and it should not change if we > > are pulling data to Koha. This is why it would be nice to choose which > > subfield is used for the authority linking. > > Hmm, how are you pulling the authority data to Koha? We are making a plugin which fetches the authority via SRU or REST API while writing it to the field. We have already a similar approach to get vocabularies https://github.com/KohaSuomi/Koha/commit/9dec82f3c28b41946f8b301dd9200cc36e92cd35 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:13:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:13:19 +0000 Subject: [Koha-bugs] [Bug 27287] New: Make note fields from orders searchable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27287 Bug ID: 27287 Summary: Make note fields from orders searchable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org It would be nice if the acquisition search allowed to search for the internal and vendor notes from the order lines. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:16:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:16:25 +0000 Subject: [Koha-bugs] [Bug 27288] New: Offer option to close basket when "E-mail order" is used Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27288 Bug ID: 27288 Summary: Offer option to close basket when "E-mail order" is used Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org As closing the basket sets the order to "ordered" and for many libraries sending the email to the vendor is the last action before doing so, it would be nice if we could safe them an extra step by offering a checkbox or similar to close the basket at the time of sending the email order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:19:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:19:54 +0000 Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:19:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:19:56 +0000 Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 --- Comment #22 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:19:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:19:58 +0000 Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:00 +0000 Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:02 +0000 Subject: [Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:05 +0000 Subject: [Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #18 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:07 +0000 Subject: [Koha-bugs] [Bug 26849] Fix Array::Utils dependency in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:09 +0000 Subject: [Koha-bugs] [Bug 26849] Fix Array::Utils dependency in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:10 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:12 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:14 +0000 Subject: [Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:16 +0000 Subject: [Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:18 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:20 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:21 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:23 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 --- Comment #17 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:25 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:27 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:29 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:31 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 --- Comment #14 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:33 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:20:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:20:34 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 --- Comment #13 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:49:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:49:00 +0000 Subject: [Koha-bugs] [Bug 27260] Add homepage button for users with purchase suggestion management but no other acq permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27260 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:52:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:52:23 +0000 Subject: [Koha-bugs] [Bug 27011] Warnings in returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18789 Keywords| |Academy --- Comment #1 from Jonathan Druart --- The variable is no longer used in the template, it has been removed by: commit 76eb3a0549efe4c1f1557071a6cb4b33d4bd3e4d Bug 18789: (follow-up) Pass a Koha::Patron object from returns.pl - [% name %] + [% INCLUDE 'patron-title.inc' patron=patron %] We can simply remove the $name variable from the controller script. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 [Bug 18789] Send a Koha::Patron object to the templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 10:52:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 09:52:23 +0000 Subject: [Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27011 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27011 [Bug 27011] Warnings in returns.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 11:06:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 10:06:59 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|19.11 |unspecified Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 11:09:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 10:09:11 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14697 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 11:09:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 10:09:11 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 11:10:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 10:10:42 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 11:10:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 10:10:45 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 --- Comment #6 from Jonathan Druart --- Created attachment 114547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114547&action=edit Bug 27004: Prevent claim resolution to fail If the account of the patron who created a claim is removed, then the claim won't be resolvable. Trying to resolve the claim will result in a 500: [2020/12/21 10:05:55] [ERROR] PUT /api/v1/return_claims/1/resolve: unhandled exception (Koha::Exceptions::Checkouts::ReturnClaims::NoCreatedBy)<<[created_by is mandatory]>> Koha::REST::Plugin::Exceptions::__ANON We should not check if created_by exist when we update an existing hold, only when we create it. Test plan: - Login with patron A - Check an item in - Claim returned it - Login with patron B - Delete patron A - Resolve the claim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 11:12:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 10:12:24 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | --- Comment #7 from Jonathan Druart --- QA: should not we have a test/exception for resolved_by? We have one for created_by, it would make sense to have the same behaviour for *_by fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 11:13:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 10:13:02 +0000 Subject: [Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #15 from Fridolin Somers --- Victor and me are working on backport to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 11:18:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 10:18:58 +0000 Subject: [Koha-bugs] [Bug 26913] More than one title element on homepage when news item is displayed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26913 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart --- Phil, can you provide an example? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 11:28:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 10:28:17 +0000 Subject: [Koha-bugs] [Bug 27253] borrowers.updated_on cannot be null on fresh install, but can be null with upgrade In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27253 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart --- What about MAX(date_renewed, dateenrolled, last_seen)? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 11:31:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 10:31:33 +0000 Subject: [Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 e.betemps changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 12:00:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 11:00:29 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 --- Comment #31 from Jonathan Druart --- (In reply to Aleisha Amohia from comment #30) > I've made some starting changes to the notices to use Koha::Biblio objects > mostly (you can see it in the atomic update in the patch). > > I need some guidance/help with a few things: > - I wasn't sure where to get the dewey and classification info from It looks like they are always empty. It's broken since the following commit: commit af466ca41ab02150f4f6c60bf6262b079b2e6e85 Date: Thu Oct 18 18:53:52 2007 -0500 start of reworking call number handling and other Biblio changes IMO we should not reintroduce them on this bug report. > - I wasn't sure which notes field to use (biblioitems or biblio) It's coming GetBiblioData 729 my $query = " SELECT * , biblioitems.notes AS bnotes, itemtypes.notforloan as bi_notforloan, biblio.notes So it's the 'notes' from biblio. > - the Author and Subjects subroutines are the hardest for me to refactor > because I'm not sure how different libraries use them Hum... Another weirdness. On opac-sendshelf: MARCSUBJCTS is set but not used in the template, 'subject' is used instead, but never sent from the pl... and it's the same for the other ones (sendbasket, sendshelf both OPAC and staff interfaces). I'd drop it as well. For MARCAUTHORS I'd try and write the equivalent of C4::Biblio::GetMarcAuthors in TT, and see how it goes (10 lines or 30 lines?). If it's too ugly then move to Koha::Biblio->get_MARC_authors (or get_authors_from_MARC?) > Some feedback would be great! Don't forget that you are in a quite dirty place. Don't loose time with things that are not working, drop them. I'd suggest that you focus on the simplest template first, no need to work in parallel on the four ones. Additional note, in your patch you are not looping at all on a Koha::Biblio set. As it's a WIP maybe you are aware of it, but I prefer to highlight it in case you missed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 12:14:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 11:14:38 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114539|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 12:14:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 11:14:40 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114540|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 12:14:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 11:14:43 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114278|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 12:14:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 11:14:45 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114279|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 12:15:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 11:15:17 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 114548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114548&action=edit Bug 24254: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 12:16:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 11:16:32 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 114549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114549&action=edit Bug 24254: Add Koha::Items->filter_by_visible_in_opac This patch adds a method based on the original idea from Nick, but on Koha::Items. The idea is to build a proper filter, based on the current rules for hiding things, directly on the DBIC query. The caller takes care of knowing if the filtering should apply (i.e. checking the patron category exceptions) and then it would do something like: my @items; if ( ) { @items = $biblio->items->filter_by_visible_in_opac( { rules => $rules } ); } else { # still want to enforce 'hidelostitems' @items = $biblio->items->filter_by_visible_in_opac; } To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Look at the use cases on the tests, read the code => SUCCESS: It all makes sense 4. Compare with Koha::Item->hidden_in_opac => SUCCESS: It all makes sense 5. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 12:16:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 11:16:35 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 114550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114550&action=edit Bug 24254: Compare itemlost with 0 On C4::Search and C4::Circulation the uses of the items.itemlost field highlight the fact that the comparisson itemlost <= 0 was wrong, as it is evaluated as a Perl boolean. The column can only be an int and NOT NULL, so we need to check if it is 0 to ponder if not hidden. This patch changes the tests to reflect this, and adjust the Koha::Items->filter_by_visible_in_opac implementation to adapt to this. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 12:16:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 11:16:39 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 114551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114551&action=edit Bug 24254: Read the OpacHiddenItems preference internally After discussing the 'rules' parameter usefulness we decided it was not the best idea, and the gains in terms of 'performance' would me meaningless (in-memory caching of sysprefs). This patch makes a really minor tweak to the tests so they mock the C4::Context->yaml_preference method, but keeping the same original rules to highlight no behaviour change takes place. Then the rules parameter is removed from the calls, and the tests should keep passing. A minor change to make $rules = undef is made to highlight the // {} behaviour when reading the syspref.. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 12:46:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 11:46:23 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #6 from Nick Clemens --- (In reply to Victor Grousset/tuxayo from comment #5) > I thought searching with ES6 would be broken by default. And thus that some > tests would fail. Because the syspref would allow to choose to have ES 6 > working or ES 5 working and would default to ES 5. After bug 27070 ES5 searching was broken. This patch retores the ability to use ES5 - since Jenkins was using 6 everywhere, there was no problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 12:55:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 11:55:32 +0000 Subject: [Koha-bugs] [Bug 27277] Queued vs Enqueued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 --- Comment #2 from Owen Leonard --- (In reply to Jonathan Druart from comment #0) > Should it be "Queued on" or "Queued at"? I agree with the change to "Queued" and I think we should drop the "on" altogether. Instead of "Queued on," "Started on," and "Ended on" we should use "Queued," "Started," and "Ended." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 12:57:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 11:57:19 +0000 Subject: [Koha-bugs] [Bug 27073] refactor cover image to get image(s) (url) from api call/template include In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27073 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 13:34:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 12:34:28 +0000 Subject: [Koha-bugs] [Bug 27203] Order unitprice is not set anymore and totals are 0. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27203 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 13:35:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 12:35:31 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 --- Comment #23 from Martha Fuerst --- It was not an issue for us in 19.11 at Huntsville-Madison County Public. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 13:37:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 12:37:14 +0000 Subject: [Koha-bugs] [Bug 26536] "Writeoff/Pay selected" deducts from old unpaid debts first In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26536 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #24 from Victor Grousset/tuxayo --- Thanks for the confirmation :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 13:39:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 12:39:32 +0000 Subject: [Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.05.17 |19.11.13 --- Comment #16 from Victor Grousset/tuxayo --- (In reply to Victor Grousset/tuxayo from comment #13) > Backported to 19.05.x branch for 19.05.17 oops, old message sneaked in. Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 13:47:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 12:47:01 +0000 Subject: [Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from Jonathan Druart --- I think we should re-add the CSV import feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 13:59:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 12:59:12 +0000 Subject: [Koha-bugs] [Bug 22405] Funds from inactive budgets appear in 'Funds' dropdown on acqui/orderreceive.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22405 Daphne Hoolahan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 13:59:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 12:59:34 +0000 Subject: [Koha-bugs] [Bug 20150] Acquisitions wizard falsely uses list price for calculating amounts spent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20150 Daphne Hoolahan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:01:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:01:03 +0000 Subject: [Koha-bugs] [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 Daphne Hoolahan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dch at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:06:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:06:45 +0000 Subject: [Koha-bugs] [Bug 26593] Rental discounts are applied in wrong precedence order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26593 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113823|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 114552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114552&action=edit Bug 26593: Remove _get_discount_from_rule This patch remove the private sub used in GetIssuingCharges in favor of get_effective_rule It corrects the wrong precedence for rules and adds tests to cover this subroutine NOTE: the 'branch' for the discount will be determined by the signed in branch, this is a bug to be fixed in the future To test: 1 - Define a rentalcharge for an itemtype 2 - Define a 10% discount for library A, category A, all itemtypes 3 - Define a 50% discount for all libraries, category A, same itemtype 4 - Attempt to checkout an item from library A of the matching itemtype 5 - The 50% discount is applied 6 - Apply patches 7 - Attempt to checkout an item from library A of the matching itemtype 8 - The 10% discount is applied prove -v t/db_dependent/Circulation.t Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:07:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:07:00 +0000 Subject: [Koha-bugs] [Bug 26593] Rental discounts are applied in wrong precedence order In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26593 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:21:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:21:49 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #7 from Victor Grousset/tuxayo --- Alright, I missed «with ES6 - searching should "work" with either pref setting» Thanks for the explanations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:21:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:21:53 +0000 Subject: [Koha-bugs] [Bug 27289] New: Template tweaks for point of sale page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Bug ID: 27289 Summary: Template tweaks for point of sale page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 23354 I have a couple of minor updates for the point of sale page: - buttons inside tables should use "btn-xs" to be a consistent size - required fields in the "Collect payment" form should be styled as required Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:21:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:21:53 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 [Bug 27289] Template tweaks for point of sale page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:37:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:37:07 +0000 Subject: [Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #2 from Nick Clemens --- Elastic uses the sum of the 'issues' field which is set to the default of '952l' - so it should match the output when the totalissues field is counted using items. If you want it to match totalissues using statistics table, then we could map it to 942$0 Using the sum of the issues from items means we don't rely on the cronjob to update_totalissues which is maybe a good thing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:43:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:43:22 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114466|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 114553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114553&action=edit Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:44:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:44:39 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:44:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:44:42 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114398|0 |1 is obsolete| | --- Comment #6 from Nick Clemens --- Created attachment 114554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114554&action=edit Bug 24398: Fix 500 when viewing a single news item at the OPAC Test plan: 0. Set the NewsAuthorDisplay preference to 'OPAC' or 'Both OPAC and staff client.' 1. Open the OPAC main page and click on an individual news item Without this patch you get an ugly 500 Template process failed: undef error - The method Koha::NewsItem->author_title is not covered by tests! With this patch applied you see the news with the author's info Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:44:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:44:44 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 --- Comment #7 from Nick Clemens --- Created attachment 114555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114555&action=edit Bug 24398: (QA follow-up) Add POD Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:45:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:45:43 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Victor Grousset/tuxayo --- Nice changes thanks :) Should it be recommended to enable ElasticsearchCrossFields when using ES 6? To not have bug 27070 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:54:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:54:14 +0000 Subject: [Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:58:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:58:16 +0000 Subject: [Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:58:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:58:20 +0000 Subject: [Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114477|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 114556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114556&action=edit Bug 27251: Rewrite QOTD with the Koha REST API This patch replace the QOTD editor with our new way to CRUD the adminitration page (like libraries and STMP servers) Test plan: Play with the QOTD by adding, removing, updating quotes Try to find bugs :) Bug 27251: Fix capitalization -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 14:59:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 13:59:36 +0000 Subject: [Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 --- Comment #12 from Jonathan Druart --- This last patch fixes the capitalization and re-add the CSV import feature. Thanks Caroline! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:00:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:00:00 +0000 Subject: [Koha-bugs] [Bug 27289] Template tweaks for point of sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 [Bug 27256] "Add" button on point of sale page fails on table paging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:00:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:00:00 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 [Bug 27289] Template tweaks for point of sale page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:00:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:00:47 +0000 Subject: [Koha-bugs] [Bug 27277] Queued vs Enqueued In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27277 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:05:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:05:37 +0000 Subject: [Koha-bugs] [Bug 27289] Template tweaks for point of sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:05:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:05:40 +0000 Subject: [Koha-bugs] [Bug 27289] Template tweaks for point of sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 --- Comment #1 from Owen Leonard --- Created attachment 114557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114557&action=edit Bug 27289: Template tweaks for point of sale page This patch makes a couple of minor changes to the point of sale page in order to make it consistent with other pages in the staff interface: - Buttons inside table cells should have the "btn-xs" class. - Required fields should have a "required" class and should have a "Required" label. Also changed: Replaced according to coding guidelines. To test, apply the patch and enable the EnablePointOfSale and UseCashRegisters system preferences if necessary. - On the Point of Sale page, add some items to purchase. Confirm that the "Add" buttons in the "Items for purchase" table and the "Remove" buttons in the "This sale" table are correctly sized. - In the "Collect payment" form, confirm that "Amount tendered" and "Cash register" fields are styled red with "Required" text after them. - Confirm that the "Amount tendered" field will only accept numeric input. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:12:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:12:24 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:12:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:12:27 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114490|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 114558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114558&action=edit Bug 27256: Update click handler for point of sale This patch updates the click handler to bind to the table element in the DOM as aposed to the individual buttons by their classes. We then use the event propogation and filter on the button class to catch the clicks we want. Test plan 1/ Add 22 debit_types that can be sold to the system (or reduce the datatable paging size) 2/ Confirm that items on the second page of results cannot be added for sale on the point of sale page. 3/ Apply the patch 4/ Confirm items from the second table page can now be added correctly 5/ Clicking add when navigating to such an item should leave the items table unmodified. 6/ Clicking aa when the table was filtered should reset the filters bringing the table back to the first page 7/ Signoff Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:16:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:16:12 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:25:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:25:54 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #10 from Jonathan Druart --- (In reply to Victor Grousset/tuxayo from comment #9) > Should it be recommended to enable ElasticsearchCrossFields when using ES 6? > To not have bug 27070 Yes, see comment 2. I think it should be turned on by default. Nick, what do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:31:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:31:16 +0000 Subject: [Koha-bugs] [Bug 27290] New: Cash register allows for 'amount tendered' less than amount being paid Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Bug ID: 27290 Summary: Cash register allows for 'amount tendered' less than amount being paid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It seems amount tendered is only used to calculate change - if there is a value for the change then there is a confirmation. If there isn't then the transaction simply goes through To test: 1 - Enable 'useCashRegisters' and 'EnablePointofSale' 2 - Add a cash register 3 - Add a debit type that can be sold 4 - Go to point of sale and sell the item multiple times 5 - Enter 'Amount tendered' less than amount being paid 6 - Click confirm 7 - Transaction is processed as if full funds received 8 - Try with a negative number - goes through again -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:31:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:31:30 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:32:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:32:39 +0000 Subject: [Koha-bugs] [Bug 27043] Add to number_of_replicas and number_of_shards to index config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27043 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:32:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:32:41 +0000 Subject: [Koha-bugs] [Bug 27043] Add to number_of_replicas and number_of_shards to index config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27043 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114544|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 114559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114559&action=edit Bug 27043: Add to number_of_replicas and number_of_shards to index config With Elasticsearch 6 (>6.4), we have a warning on index creation : the default number of shards will change from [5] to [1] in 7.0.0 See https://github.com/elastic/elasticsearch/pull/30587 I propose to add number_of_shards in index config. Also add number_of_replicas that is better explicit. In case on only one node, it must be 0. Test plan : 1) Use Elasticsearch 2) Apply patch and flush memcached 3) Rebuild indexes : misc/search_tools/rebuild_elasticsearch.pl -v -b -d 4) Check you dont have a warning about number of shards 5) Check the settings of index : curl ':9200/_biblios/_settings?pretty&filter_path=**.number_of_*' 6) You should see : "number_of_shards" : "5", "number_of_replicas" : "1" Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:33:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:33:19 +0000 Subject: [Koha-bugs] [Bug 27043] Add to number_of_replicas and number_of_shards to index config In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27043 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |nick at bywatersolutions.com CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:37:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:37:18 +0000 Subject: [Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:37:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:37:37 +0000 Subject: [Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:37:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:37:39 +0000 Subject: [Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114530|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 114560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114560&action=edit Bug 27280: (bug 27026 follow-up) Make consistent the explanation for "Days mode" We have "Skip closed days" in the dropdown, but "Calendar" on the table. Both must match Test plan: Go to the circ rules, select a value for "Days mode", save the rule, confirm that the dropdown list values are matching the ones we displayed in the cells Signed-off-by: Caroline Cyr La Rose Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:59:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:59:29 +0000 Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 15:59:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 14:59:32 +0000 Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114502|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 114561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114561&action=edit Bug 22243: Fix unescaped apostrophe in Z target This patch escapes apostrophes in the z39.50 target name prior to them being embedded in the template. To test: - Create a z39.50 target containing an apostrophe in the title - Note that the Advanced Cataloguer editor does not load - Apply the patch - TEST: Note that the Advanced Cataloguer editor does load Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 16:52:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 15:52:55 +0000 Subject: [Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 16:52:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 15:52:58 +0000 Subject: [Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114535|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 114562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114562&action=edit Bug 27282: Add window.onafterprint function TO TEST: -set up a new list with a few items -go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and clear cache -Try again, the print dialouge remains open Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:00:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:00:14 +0000 Subject: [Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- Without the patch I'm getting «Already in a transaction» even with a (supposedly) valid MARCXML file with 120 records. I just exported the first 120 records of the sample data in XML. With the patch, with valid or invalid data, it's just importing one record: kohadev-koha at kohadevbox:/kohadevbox/koha$ misc/migration_tools/bulkmarcimport.pl -commit 10 -file 120-records.xml . 1 MARC records done in 0.0640840530395508 seconds kohadev-koha at kohadevbox:/kohadevbox/koha$ misc/migration_tools/bulkmarcimport.pl -commit 10 -file 120-records-one-invalid.xml . 1 MARC records done in 0.0556449890136719 seconds Maybe I'm missing a param from bulkmarcimport.pl? (-b doesn't help) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:11:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:11:19 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114235|0 |1 is obsolete| | --- Comment #12 from Nick Clemens --- Created attachment 114563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114563&action=edit Bug 27148: Fix bug on self registration when user category is hidden This patch fixes the bug when there is no patron category available for selection in self registration form. It uses PatronSelfRegistrationDefaultCategory to get patron's password length and strength. To test: 1. Do not apply this patch 2. Allow SeflRegistration, set PatronSelfRegistrationDefaultCategory to a valid patron category and finally add categorycode to PatronSelfRegistrationBorrowerUnwantedField 3. Go to opac and enter self registration form CHECK => There is no patron category available for selection => Password's info alert shows "Password must contain at least undefined characters" 4. Fill the form setting a password and send. CHECH => You get an exception saying "You must provide a patron's category to validate password's strength and length" 5. Apply this patch and restart_all 6. repeat steps 3 and 4 SUCCESS => Password's info alert message shows a number instead of "undefined" => Password's strength and length checks are working => If you change default category's lenght or strength parameter it get's reflected when you refresh the page => When you click send, patron is saved Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:11:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:11:23 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114290|0 |1 is obsolete| | --- Comment #13 from Nick Clemens --- Created attachment 114564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114564&action=edit Bug 27148: (follow-up) Fix require_strong variable set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:11:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:11:26 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 --- Comment #14 from Nick Clemens --- Created attachment 114565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114565&action=edit Bug 27148: (QA follow-up) Calculate default_strong_password correctly Fix a typo lenght for length If category strong password is not set, then we fall back to the preference, but that can be "" - which should be treated as 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:11:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:11:38 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |nick at bywatersolutions.com |y.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:20:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:20:21 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:20:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:20:24 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114500|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 114566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114566&action=edit Bug 27200: (bug 20168 follow-up) Fix 'Browse search' The 'hidden' class has been replaced by 'd-none' on bug 20168 Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:20:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:20:27 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114501|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 114567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114567&action=edit Bug 27200: (follow-up) Browse search interface update This patch updates the browse search interface to confirm to new interface patterns in the Bootstrap 4 framework, especially in the form markup. The results list has been changed to a Bootstrap "Collapse" component configured as an accordion (https://getbootstrap.com/docs/4.5/components/collapse/#accordion-example). Instead of loading the bibliographic record results below the list of terms returned, the bibliographic results are now displayed in the "panel" expanded below the selected term. Subtitle has been added to the information displayed about the bibliographic record. To test you must be using ElasticSearch and the OpacBrowseSearch preference must be enabled. Apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Open the "Browse search" page in the OPAC. - Test various searches: Author, Subject, and Title. - When results are found, the should be displayed as a Bootstrap-styled accordion widget. Clicking any individual result should expand the panel containing the corresponding records. - Clicking the record link should open the bibliographic detail page in a new window. - When no results are found, a Bootstrap-style "alert" box should appear. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:22:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:22:51 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:28:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:28:25 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #1 from Martin Renvoize --- Created attachment 114568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114568&action=edit Bug 27290: Update 'type=number' to 'type=text inputmode=numeric' This patch updates the inputs for the pay form on the point of sale page to use numeric inputmode. This appears to also fix the validation issue described in the bug report. To test: 1 - Enable 'useCashRegisters' and 'EnablePointofSale' 2 - Add a cash register 3 - Add a debit type that can be sold 4 - Go to point of sale and sell the item multiple times 5 - Enter 'Amount tendered' less than amount being paid 6 - Click confirm 7 - Transaction is processed as if full funds received 8 - Try with a negative number - goes through again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:28:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:28:38 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:29:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:29:35 +0000 Subject: [Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:29:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:29:38 +0000 Subject: [Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114484|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 114569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114569&action=edit Bug 27250: Fix stacked event listeners in SMTP delete modal There is a design issue on the click event listener that makes the modal get added new event listeners on each row being deleted. This makes the page call all the event listeners and generates an error. This patch replaces the flawed logic (adding the event listener inside the event listener). It makes the event listener be defined at startup time, and make the .on('click') action just pass information around as required. To test: 1. Create at least 2 SMTP servers 2. Open the browser inspector, on the network tab 3. Click "Delete" for server 1 => SUCCESS: You get a successful message (OK) 4. Click "Delete" for server 2 => SUCCESS: You get a successful message (OK) => FAIL: You get also an alert message about server 1 (KO) => FAIL: The inspector shows more than one AJAX call has been made 5. Apply this patch and reload the page 6. Repeat 3-4 => SUCCESS: Everything goes smooth this time 7. Sign off :-D Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:29:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:29:41 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #2 from Martin Renvoize --- I think there's some browser ambiguity here.. I tested on latest Chrome, Firefox and Brave browsers and all worked as expected with this patch... but I'm not entirely confident in my fix... it's a step in the right direction accessibility wise though :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:34:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:34:17 +0000 Subject: [Koha-bugs] [Bug 27247] Missing highlighting in Quote of the day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:34:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:34:20 +0000 Subject: [Koha-bugs] [Bug 27247] Missing highlighting in Quote of the day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114467|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 114570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114570&action=edit Bug 27247: Re-add highlighting to the quote editor Caused by commmit 247dca306407ac9568344a0a37aca3bbcffc2468 Bug 23013: Upgrade DataTables in the staff client which removed -tr.even.selected td { - background-color: #D3D3D3; -} There was no more highlighting when trying to delete an imported quote, as there was before (see screenshot from the manual https://gitlab.com/koha-community/koha-manual/-/blob/master/source/images/tools/qotd/selectfordelete.png) It was, however, possible to delete imported quotes, you just don't see which ones you are deleting. Test plan: 1) Create a CSV with two columns first the name, then the quote (I've attached a CSV that I've done for testing purposes) 2) Go to Tools > Edit quotes for the QOTD feature 3) Click 'Import quotes' 4) Click 'Browse' and choose the CSV created earlier 5) Click on the id of a couple of quotes. Notice those lintes are highlighted Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:53:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:53:43 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:53:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:53:46 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114428|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 114571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114571&action=edit Bug 27099: Stage for import button not showing up In the latest version of Chrome, pages where the Humansmg library is included have a problem where the language footer obscures the bottom of the page. The problem traces back to some CSS in the Humanmsg library's CSS file: html, body { height: 100%; /* Damn you IE! */ } Removing the line doesn't have any ill effects that I can see in Chrome or Firefox, and it fixes the problem in Chrome. IE can be damned. To test you must have one or more translations enabled in the staff interface. - Apply the patch and clear your browser cache if necessary. - View pages in the staff interface which use the Humansmg library, e.g.: - Administration -> System preferences. Choose a category of preferences which will be numerous enough to require scrolling to reach the bottom of the page. - Tools -> Stage MARC records for import. Upload a file to display the form for staging the import. - Cataloging -> Advanced MARC editor On each page the language footer should not obscure the bottom of the page. Signed-off-by: Lucas Gass Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:56:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:56:09 +0000 Subject: [Koha-bugs] [Bug 13326] Add possibilty to edit purchase suggestion on opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13326 Rhonda Kuiper changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov --- Comment #4 from Rhonda Kuiper --- We have found the ability for patron to delete items even after the item has been ordered a problem especially with the functionality in 20.05 that limits the number of patron suggestion within a specified time period. (MAXTOTALSUGGESTION and NUMBEROFSUGGESTIONDAYS). With this function, if the patron deletes a suggestion after it is no longer in pending status, the NUMBEROFSUGGESTIONDAYS calculation isn't accurate. We ended up removing the Delete function on the OPAC with some jquery. The solution I would suggest is two fold: -If the suggestion is in pending status, they can delete it (or edit as suggested earlier). Rationale: The library staff has not spent any time dealing with the suggestion so there is no time lost or confusion about what the person wants. -If the suggestion in any status other that pending, they can delete it from the OPAC display but what is really happening is the suggestion is archived (using the function from bug 22784). What would display on the OPAC is all non-archived suggestions. This way the suggestion stays in the database and the NUMBEROFSUGGESTIONDAYS calculation will still be accurate along with any other stats a library would like to gather. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:56:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:56:27 +0000 Subject: [Koha-bugs] [Bug 13911] Add support for Internet Archive BookReader In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911 Rhonda Kuiper changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 17:56:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 16:56:49 +0000 Subject: [Koha-bugs] [Bug 13911] Add support for Internet Archive BookReader In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911 Rhonda Kuiper changed: What |Removed |Added ---------------------------------------------------------------------------- CC|rkuiper at roundrocktexas.gov | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 18:02:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 17:02:24 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 18:02:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 17:02:26 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114397|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 114572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114572&action=edit Bug 26397: [20.05.x] opac.scss calls non-existent image This patch removes some obsolete CSS from the OPAC which calls a non-existent image. There should be no visible change. This patch is specifically for Koha 20.05.x. The bug does not appear in master. To test, apply the patch and rebuild the OPAC SCSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). View the OPAC and confirm that nothing has changed in the style of the Koha logo in the header. Signed-off-by: David Nind Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 18:47:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 17:47:05 +0000 Subject: [Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured in Elasticsearch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Abbey Holt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt at dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 18:52:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 17:52:39 +0000 Subject: [Koha-bugs] [Bug 27278] FindDuplicate uses 'exact' for searching and is too strict In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27278 Benjamin Daeuber changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com --- Comment #1 from Benjamin Daeuber --- I'm not sure what's in the scope of this bug, but another thing to consider is item type. For example, a suggestion for a movie might reveal the novel adaptation, or vice versa. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 19:00:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 18:00:59 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114547|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 114573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114573&action=edit Bug 27004: Prevent claim resolution to fail If the account of the patron who created a claim is removed, then the claim won't be resolvable. Trying to resolve the claim will result in a 500: [2020/12/21 10:05:55] [ERROR] PUT /api/v1/return_claims/1/resolve: unhandled exception (Koha::Exceptions::Checkouts::ReturnClaims::NoCreatedBy)<<[created_by is mandatory]>> Koha::REST::Plugin::Exceptions::__ANON We should not check if created_by exist when we update an existing hold, only when we create it. Test plan: - Login with patron A - set a value to syspref ClaimReturnedLostValue - Check an item out - Claim returned it - Login with patron B - Delete patron A - Resolve the claim - ERROR in api-error.log an UI never confirming the resolution - apply patch & restart services - Resolve the claim - it works Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 19:03:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 18:03:42 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor at tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- It works :) Completed test plan + fixed "Check an item in" => "Check an item out" (maybe it's actually doable with a checkin) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 19:33:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 18:33:45 +0000 Subject: [Koha-bugs] [Bug 27251] Rewrite the QOTD editor using the Koha REST API In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27251 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Owen Leonard --- Jonathan told me in IRC that one should not be able to "select" a line anymore during the import process because the option to delete has been removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 19:55:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 18:55:28 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 --- Comment #12 from Victor Grousset/tuxayo --- The tests pass in 19.11.x but I have an error message not in 20.05.x kohadev-koha at 9ddfdbbbd877:/kohadevbox/koha$ prove t/db_dependent/SIP/Transaction.t t/db_dependent/SIP/Transaction.t .. 7/10 AddReturn error: branch 'SIP2' not found. Reverting to bH8GNQ at /kohadevbox/koha/C4/Circulation.pm line 1844. AddReturn error: branch 'SIP2' not found. Reverting to bH8GNQ at /kohadevbox/koha/C4/Circulation.pm line 1844. t/db_dependent/SIP/Transaction.t .. 9/10 AddReturn error: branch 'SIP2' not found. Reverting to lw0u4bBY02 at /kohadevbox/koha/C4/Circulation.pm line 1844. AddReturn error: branch 'SIP2' not found. Reverting to lw0u4bBY02 at /kohadevbox/koha/C4/Circulation.pm line 1844. t/db_dependent/SIP/Transaction.t .. ok All tests successful. Files=1, Tests=10, 6 wallclock secs ( 0.04 usr 0.00 sys + 4.78 cusr 0.78 csys = 5.60 CPU) Result: PASS That doesn't look good right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 19:57:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 18:57:41 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 114574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114574&action=edit Bug 24254: Implement separate filters and add patron param This patch introduces two new methods for stacking filters on Koha::Items: - filter_out_lost _ filter_out_opachiddenitems This two filters are what actually happened inside the filter_by_visible_in_opac. Everything is covered by tests. In the process I added a Koha::Patron param to the method that is internally used to decide if the OPACHiddenItems syspref needs to be honoured or not. This *could* be better done with a fallback to C4::Context->userenv if no param is passed. I decided to leave that part for later, if we really find it would help (e.g. if bug 10589 gets some action and we really need something here to handle that). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 20:17:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 19:17:47 +0000 Subject: [Koha-bugs] [Bug 27130] Adding local cover image at item level shows 'File type' section In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27130 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens --- I don't think this makes things much better - why do we have an itemnumber that we cannot edit? It would be better to have that in the breadcrumbs or page title, no? Also, it seems the code for supporting multiple image uploads (zip file) has references to itemnumber, but never actually receive/calculate it. In my opinion the bug is that one cannot choose a zip file to upload item covers. When attaching a cover to the biblio we actually can edit the biblionumber, which seems like a bad idea, but we should at least be consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 20:25:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 19:25:30 +0000 Subject: [Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 20:25:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 19:25:33 +0000 Subject: [Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114050|0 |1 is obsolete| | --- Comment #8 from Nick Clemens --- Created attachment 114575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114575&action=edit Bug 26171: Show biblionumber in Koha::Exceptions::Metadata::Invalid Bug 23846 added a check for invalid MARCXML in search_for_data_inconsistencies.pl. But the error message does not show the biblionumber of invalid biblio record. Test plan: 1) Import a bibliographic record with invalid XML, you can add non printable characters, like 0x1F (CTRL-V 1F with vim) 2) Run misc/maintenance/search_for_data_inconsistencies.pl 3) Check you see correct biblionumber in error message : Invalid data, cannot decode object (id=xxx, biblionumber=yyy, format=marcxml, schema=zzz, decoding_error=... Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 20:25:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 19:25:36 +0000 Subject: [Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114051|0 |1 is obsolete| | --- Comment #9 from Nick Clemens --- Created attachment 114576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114576&action=edit Bug 26171: adapt Koha/Exceptions.t Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 20:25:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 19:25:38 +0000 Subject: [Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 --- Comment #10 from Nick Clemens --- Created attachment 114577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114577&action=edit Bug 26171: (QA follow-up) Add table name and object type to message Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 20:26:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 19:26:35 +0000 Subject: [Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens --- Added a follow-up to clarify which object threw the exception and explain where the id comes from - feel free to drop if you disagree RM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 20:31:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 19:31:30 +0000 Subject: [Koha-bugs] [Bug 15448] Placing hold on specific items doesn't enforce OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #34 from Tomás Cohen Arazi --- Created attachment 114578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114578&action=edit Bug 15448: (follow-up) Adapt to changes on bug 24254 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 21:13:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 20:13:05 +0000 Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us --- Comment #5 from Rebecca Coert --- It would be helpful to have the ability to have a Long Overdue (Lost) items convert to Lost and Paid upon payment. A sys-preference seems the easiest way to make this available for those of us that want it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 21:14:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 20:14:12 +0000 Subject: [Koha-bugs] [Bug 22457] OpacHiddenItemsExceptions should be moved to a category attribute In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 --- Comment #5 from Tomás Cohen Arazi --- Thinking about this in the context of bug bug 10589: this is a clear use case for bug 26129. - This bug tries to implement a flag on Koha::Patron::Categories. - Bug 10589 pretends to make that flag per-category. This could just be a per-branch configuration for each category, or a global value. This is all covered by bug 26129. This bug and 10589 would just be choosing the right 'keyword' for the configuration entry, and adding the UI (on the categories?) and then using the methods to retrieve the configuration based on the parameters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 21:17:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 20:17:13 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #24 from Victor Grousset/tuxayo --- After applying the patch , while restarting the services, I have a compilation issue. root at kohadevbox:koha((6982680ae9...))$ restart_all Restarting Apache httpd web server: apache2. Restarting Koha ILS: koha-commonStopping Plack daemon for kohadev:. Stopping Z39.50/SRU daemon for kohadev:. Stopping Koha worker daemon for kohadev:. Stopping Koha indexing daemon for kohadev:. Starting Plack daemon for kohadev:. Starting Z39.50/SRU daemon for kohadev:syntax error at /kohadevbox/koha/C4/Circulation.pm line 3091, near "->errstr;" Type of arg 1 to List::MoreUtils::any must be block or sub {} (not reference constructor) at /kohadevbox/koha/C4/Circulation.pm line 4397, near "} )" Type of arg 1 to List::MoreUtils::any must be block or sub {} (not reference constructor) at /kohadevbox/koha/C4/Circulation.pm line 4400, near "}) " > 2 - Confirm that 'Renew all' feature continues to work as expected Is testing the "Renew all" button in a patron's checkout list enough? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 21:40:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 20:40:19 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch introduces an |This patch introduces an release notes|efficient way of filtering |efficient way of filtering |Koha::Items result sets, to |Koha::Items result sets, to |hide items that |hide items that that |OpacHiddenItems determines |shouldn't be exposed on |shouldn't be exposed on |public interfaces. |public interfaces. | | |Filtering is governed by | |the following system | |preferences. Two helper | |methods are added to handle | |each of them: | |- | |OpacHiddenItems: | |Koha::Items->filter_out_opa | |chiddenitems is added to | |handle this. | |- | |hidelostitems: | |Koha::Items->filter_out_los | |t is added to handle this. | | | |Some patrons have | |exceptions so | |OpacHiddenItems is not | |enforced on them. That's | |why the new method [1] has | |an optional parameter that | |expects the logged in | |patron to be passed in the | |call. | | | |[1] | |Koha::Items->filter_by_visi | |ble_in_opac CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 21:45:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 20:45:42 +0000 Subject: [Koha-bugs] [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3150 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 [Bug 3150] Move emails for sending cart and list contents into notices tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 21:45:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 20:45:42 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27269 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27269 [Bug 27269] Move C4::Biblio::GetMarcSubjects to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 21:50:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 20:50:11 +0000 Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Jeff Gaines changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jgaine at arlingtonva.us --- Comment #6 from Jeff Gaines --- It would make sense to set the system to handle this for payments that are not staff mediated. Even for staff-mediated payments, it's one less thing for staff to do (or forget to do). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 22:03:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 21:03:16 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 --- Comment #7 from Andrew Fuerste-Henry --- Kyle, can you please rebase this? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 22:04:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 21:04:33 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 22:10:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 21:10:44 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114545|0 |1 is obsolete| | --- Comment #32 from Aleisha Amohia --- Created attachment 114579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114579&action=edit Bug 3150: WIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 22:13:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 21:13:10 +0000 Subject: [Koha-bugs] [Bug 18017] [Unimarc] Importing biblios from Z39.50 servers duplicates related authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #9 from Victor Grousset/tuxayo --- As it's an UNIMARC bug and it's getting old, I think it's okay to have a signoff from the same entity, so Didier or someone else at BibLibre, you can sign this off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 22:38:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 21:38:54 +0000 Subject: [Koha-bugs] [Bug 27266] Move C4::Biblio::GetMarcAuthors to Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27266 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114503|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia --- Created attachment 114580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114580&action=edit Bug 27266: Move GetMarcAuthors to Koha namespace This patch moves C4::Biblio::GetMarcAuthors to Koha::Biblio->get_authors_from_MARC. This is so the method can be used in templates and notices. To test: 1. Find a record that has an author in the added entry field (700-720). 2. Add the record to the cart and a list. 3. View your cart and click 'more details'. Confirm authors show as normal. 4. Click 'send' and confirm the email sent shows the authors as normal. 5. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 6. Set the OPACXSLTDetailsDisplay system preference to empty (for no xslt) 7. Log in to the OPAC. Find the record and add it to the cart and a list 8. View the cart and click 'more details'. Confirm authors show as normal. 9. Click 'send' and confirm the email sent shows the authors as normal. 10. Go to the list you added the record to and click 'send list'. Confirm the email sent shows the authors as normal. 11. View the record detail page and confirm the authors show as normal. 12. Confirm tests pass: - t/Biblio.t - t/db_dependent/Koha/Biblio.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 21 23:44:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 22:44:56 +0000 Subject: [Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 --- Comment #17 from David Cook --- Question for Phil Ringnalda: Phil, do you know if you're using CHR or ICU indexing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 00:18:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 23:18:49 +0000 Subject: [Koha-bugs] [Bug 21287] Report Zebra search errors to web server logs and staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21287 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 00:19:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 23:19:45 +0000 Subject: [Koha-bugs] [Bug 21287] Report Zebra search errors to web server logs and staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21287 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from David Cook --- *** This bug has been marked as a duplicate of bug 27139 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 00:19:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 23:19:45 +0000 Subject: [Koha-bugs] [Bug 27139] Search errors are incorrectly shown to users as no results found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #5 from David Cook --- *** Bug 21287 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 00:22:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 23:22:39 +0000 Subject: [Koha-bugs] [Bug 27291] New: Change datetime format in Zebra logs Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 Bug ID: 27291 Summary: Change datetime format in Zebra logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au At the moment, Zebra logs using a dateformat of "hh:mm:ss-DD/MM". For example, "23:16:22-21/12". I propose that we change it to use the dateformat of "%F %T" or "%FT%T". For example, "2020-12-21 23:16:41" or "2020-12-21T23:21:19" It can be done by adding the following option to zebrasrv: -m "%F %T" or -m "%FT%T" While this option doesn't obviously appear in "man zebrasrv", it does appear in "man yaz-ztest" and the manpage for zebrasrv says that zebrasrv has the same options as "yaz-ztest". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 00:23:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 23:23:03 +0000 Subject: [Koha-bugs] [Bug 27139] Search errors are incorrectly shown to users as no results found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27291 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 00:23:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 23:23:03 +0000 Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27139 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 00:24:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 23:24:11 +0000 Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 --- Comment #1 from David Cook --- One of the reasons for changing the dateformat is to improve log file monitoring of Zebra. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 00:55:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 21 Dec 2020 23:55:12 +0000 Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 Sarah Daviau changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sdaviau at arlingtonva.us --- Comment #7 from Sarah Daviau --- This would be a good way to smooth the process out for both front line staff and on the back end. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 01:23:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 00:23:28 +0000 Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 01:23:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 00:23:34 +0000 Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 --- Comment #2 from David Cook --- Created attachment 114581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114581&action=edit Bug 27291: Reformat Zebra output logs This patch changes the Zebra output log time format from the default "hh:mm:ss-DD/MM" to the more standard ISO 8601 "%FT%T". This change makes the logs easier to read for both humans and machines. One benefit includes easy searching and sorting. Test plan: 1. cp debian/scripts/koha-zebra /usr/sbin/koha-zebra 2. koha-zebra --stop kohadev 3. koha-zebra --start kohadev 4. ps -efww | grep "zebrasrv" 5. Note "-m %FT%T" in the grep output 6. tail -f /var/log/koha/kohadev/zebra-output.log 7. Run a few searches like http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=ccl%3Dargawarga%3D1 or http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=e 8. Note that the timestamp in the Zebra log is formatted "2020-12-22T00:13:42" instead of like "00:13:42-22/12" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 01:25:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 00:25:01 +0000 Subject: [Koha-bugs] [Bug 27139] Search errors are incorrectly shown to users as no results found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #6 from David Cook --- Frido: Bug 27291 may be interesting to you. I think that change would make it a lot easier to monitor the Zebra logs... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 01:25:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 00:25:30 +0000 Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 01:52:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 00:52:21 +0000 Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 01:54:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 00:54:03 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 02:13:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 01:13:11 +0000 Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia at bugs.koha-communit | |y.org Component|Searching - Zebra |Packaging --- Comment #3 from David Cook --- Actually going to switch the component from "Searching - Zebra" to "Packaging" as that might be more accurate... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 02:37:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 01:37:58 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 02:38:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 01:38:07 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114579|0 |1 is obsolete| | --- Comment #33 from Aleisha Amohia --- Created attachment 114582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114582&action=edit Bug 3150: Move emails for sending cart and list contents to notices This patch creates notices using Template Toolkit syntax for sending emails containing cart and list contents. To test: 1. Apply Bug 27266 2. Run update database and restart services 3. In the staff client, add multiple items to your cart and to a list 4. Go to your cart and click Send to email the contents 5. Add an email and a comment and click Send 6. Confirm the information shown in the success message is correct 7. In your terminal, log into the database. View the message queue ( i.e. select * from message_queue; ). Confirm that your email has been queued and the content is all correct. Confirm the cart contents has been included as an attachment. 8. Go to your list and click Send list to email the contents 9. Repeat steps 5-7 10. Log into the OPAC 11. Add multiple items to your cart and to a list 12. Repeat steps 4-9 13. By the end, you should have four emails in your message queue. All of the data about the items should be correct, they should all have attachments, and be addressed to the correct email address. Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 02:40:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 01:40:58 +0000 Subject: [Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #25 from David Cook --- (In reply to Johanna Räisä from comment #24) > (In reply to David Cook from comment #23) > > (In reply to Johanna Räisä from comment #21) > > > Do you mean putting Koha's internal link to authority linking subfield? > > > > > > > I'm not 100% sure what you mean, but I think so, yes. > > I meant that the authid would be changed to URI and saved that instead of > integer value. > Sounds good to me. The only thing to keep in mind is that the $9 is currently indexed into the Koha-Auth-Number:w index which does mean that it's normalized and tokenized. This could cause problems if there is an unencoded space in the URI for instance. It might be wise for us to start using a "p" register instead of a "w" register, and to start doing "exact" searches when querying this index... At least if you're using Zebra. I don't know about Elasticsearch... > > Yeah that sounds good to me. So you wouldn't be storing authority records in > > Koha? > > No we won't. > Interesting! Very interesting! > We are making a plugin which fetches the authority via SRU or REST API while > writing it to the field. We have already a similar approach to get > vocabularies > https://github.com/KohaSuomi/Koha/commit/ > 9dec82f3c28b41946f8b301dd9200cc36e92cd35 Sounds interesting. I'd like to hear more as you progress. When you say that the plugin fetches the authority, do you mean that it fetches it, extracts the relevant data, inserts it into the Koha bibliographic record, and then discards the authority record? I think that's such a great idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 02:51:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 01:51:17 +0000 Subject: [Koha-bugs] [Bug 17511] Change authority linking subfield from $9 to $0 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 --- Comment #26 from David Cook --- (In reply to Johanna Räisä from comment #16) > TEST PLAN: > 1) Add new authority linking to a record. > 2) Verify that the authority records ID is on $9 subfield. > 3) Check index that authority has one record chosen. > 4) Apply the patch. > 5) Check AuthoritySubfieldLink to be 9. > 6) Repeat steps 1, 2 and 3. > 7) Change the preference value > 8) Replace zebradb/marc_defs with new files or/and reset ES configurations. > 9) Add new authority linking to a record. > 10) Verify that the authority records ID is now on the chosen subfield. > 11) Check index again that authority has record chosen. > Could you elaborate on Step 8? I think it would be wise to add an additional example patch (marked with something like DONOTPUSH) with your desired configuration for etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl That'll make it easier for us to test. Otherwise, the tester and QA have to guess at the correct configuration. I think that this sounds like a good change though. Wise to keep the $9 for default, and maybe we can announce a deprecation in favour of moving to $0 at some point... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 03:27:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 02:27:51 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #227 from David Cook --- (In reply to Jonathan Druart from comment #226) > (In reply to David Cook from comment #225) > > Aleisha, even if you don't squash them, could you let me know the parent > > commit for these patches from your last rebase? > > See https://gist.github.com/jajm/f0b77da1a41b6b1c5ab1 I've reviewed it based on your suggestion, but it doesn't actually work. At least not with git 2.16.4. The git rev-list appears to be random, so returning the first result is like picking a name out of a hat. This can be verified by comparing the results of the following command: `git rev-list -n 15 --before="'Tue, 16 Apr 2019 23:00:05 +0000'" origin/master | less` Even if the list weren't random, the dates are from patch creation time rather than merge time, so it would still be a shot in the dark. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 03:36:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 02:36:17 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #228 from David Cook --- It's actually quite interesting... I just tried `git log --before="2019-04-16"`, which looks good at a glance, but it doesn't include f668fecec3771b633068f89dcead2312471f9425. Yet, f668fecec3771b633068f89dcead2312471f9425 should be before "2019-04-16". Something weird going on there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 03:57:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 02:57:05 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #229 from David Cook --- We can trust that commit 1b5635bebd75c418fdda68036e1e91f857cb1e4d was probably made and applied on May 30 2019 as it includes the release notes for 19.05.00. Aleisha posted a comment about patches being rebased on April 15 2019, but the patches conflict with commits from April 11 2019... But then if I go before those I'm still getting lots of conflicts. Without that parent commit or a tonne of work, I don't think anyone can rebase these except Aleisha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 04:04:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 03:04:01 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #230 from Aleisha Amohia --- I don't have time to get to this right now and probably won't for a while, but it is on my list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 04:44:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 03:44:22 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #231 from David Cook --- (In reply to Aleisha Amohia from comment #230) > I don't have time to get to this right now and probably won't for a while, > but it is on my list. I'm happy to collaborate on it as it's increased in priority here. I was just being grumpy before, but I can try rebasing it now against master. I'm off from Dec 25 through Jan 3, so I suppose there is no rush, but I'm hoping to tick this one off sooner rather than later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 04:58:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 03:58:05 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114430|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia --- Created attachment 114583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114583&action=edit Bug 15348: WIP Working on pre-filling values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 06:28:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 05:28:08 +0000 Subject: [Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114005|0 |1 is obsolete| | --- Comment #12 from Mason James --- Created attachment 114584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114584&action=edit Bug 27055: Fix compatibility with newer Firefox+Selenium version Fix "submit is not a function error" A submit button should not be named "submit", in this case, it's id. https://stackoverflow.com/questions/833032/submit-is-not-a-function-error-in-javascript Fix some uses of get_attribute() Fix a fail by setting a global implicit_wait_timeout, default value is 0 in our lib. Other libs set it higher which helps to not have to manually deal with part of the timing issues. Fix: remove usage of click_when_visible() because it doesn't work with elements not in the top of the page. Because they are off screen. Fix: use $driver->quit() in error_handler to not forget an open Firefox. With the current version, it fills /dev/shm and fails with around 5 Firefox opened. Also use quit() it at the end of every script. Fix: filling item fields, to fill only the displayed one (not those with display:none) == Test plan == 1. Update selenium/standalone-firefox to the latest version [1] 2. prove t/db_dependent/selenium/authentication.t 3. It fails with: arguments[0].form.submit is not a function 4. Apply patch 5. Retest 6. Success [1] In koha-testing-docker you can do it with docker-compose.yml: selenium: - image: selenium/standalone-firefox:2.53.1-americium + image: selenium/standalone-firefox Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 06:32:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 05:32:14 +0000 Subject: [Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Mason James --- this patch is working well for me with the following patch applied... https://gitlab.com/koha-community/koha-testing-docker/-/merge_requests/184 so signing off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 06:57:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 05:57:35 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 06:58:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 05:58:58 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #232 from David Cook --- I've put in some effort into rebasing these patches (and skipping many of them), but there's so many different changes that it's difficult to keep it all straight and the existing test plans are chaos. Rather than proceeding with this patch, I reckon that it's smarter to split this patch into separate patches that deal with 1 change at a time (e.g. adding checkboxes to the staff client, adding checkboxes to the OPAC, changing maximum hold logic, etc.) I think that Bug 23457 is a good candidate for adding checkboxes to the staff client, and I think that's probably where I'm going to focus my energy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 07:00:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 06:00:38 +0000 Subject: [Koha-bugs] [Bug 23457] Can't pick the items when placing multiple holds on a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23457 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #3 from David Cook --- Depending on client feedback, I may split out the staff interface code from Bug 15565 and submit it as a separate patch here. I think Bug 15565 suffered scope creep which has made it difficult to rebase and test. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 07:01:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 06:01:46 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #233 from David Cook --- On the plus side, rebasing actually exposed a bug in master! So yay! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 07:01:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 06:01:54 +0000 Subject: [Koha-bugs] [Bug 23457] Can't pick the items when placing multiple holds on a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23457 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 07:05:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 06:05:28 +0000 Subject: [Koha-bugs] [Bug 27292] New: TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Bug ID: 27292 Summary: TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org I was rebasing Bug 15565 when I noticed strange Javascript errors. The following code in master was the actual problem: columns_settings_borrowers_table = [% TablesSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] At the moment in koha-testing-docker, this creates the following Javascript: "columns_settings_borrowers_table = " For some reason, this doesn't currently cause a problem because the next line is blank and that line is followed by "$(document).ready(function() {". Anyway, there should be data coming back there, so that's something to investigate... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 07:06:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 06:06:51 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #228 from David Cook --- (In reply to Josef Moravec from comment #227) > I rebased and squashed a bit, but this still must be considered as WIP I'll hopefully take a look at this tomorrow. Why is it considered a WIP at this point? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 07:20:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 06:20:27 +0000 Subject: [Koha-bugs] [Bug 26792] Create simple is_authenticated and is_authorized methods for AuthN/AuthZ In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26792 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from David Cook --- *** This bug has been marked as a duplicate of bug 26791 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 07:20:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 06:20:27 +0000 Subject: [Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 --- Comment #21 from David Cook --- *** Bug 26792 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 07:21:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 06:21:20 +0000 Subject: [Koha-bugs] [Bug 26845] Refactor get_template_and_user In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26845 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from David Cook --- I don't think we're going to ever fix it, so I think the only real hope is to eventually replace it via Bug 26791 or equivalent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 07:40:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 06:40:33 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #229 from Josef Moravec --- (In reply to David Cook from comment #228) > (In reply to Josef Moravec from comment #227) > > I rebased and squashed a bit, but this still must be considered as WIP > > I'll hopefully take a look at this tomorrow. > > Why is it considered a WIP at this point? I do consider i as WIP mainly because, thinks needs to be moved from C4 to Koha namespace (using Koha::Object[s] of course). Second step would to modify hold to by always a hold group (even on only one title). But this could be eventually done on another report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 07:50:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 06:50:02 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 --- Comment #234 from David Cook --- (Apologies if my above comments came across as rude or disrespectful. I'm not trying to criticize anyone. I'm just really keen to move forward, as I have a library that really wants multiple holds at once functionality ASAP, and I think breaking up the patches might be a good way to move forward.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 08:12:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 07:12:49 +0000 Subject: [Koha-bugs] [Bug 27293] New: Refactor C4::Templates and C4::Languages to not use CGI objects directly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 Bug ID: 27293 Summary: Refactor C4::Templates and C4::Languages to not use CGI objects directly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org If you look through C4::Templates and C4::Languages, you'll see CGI objects being passed around a lot. In the end, all that C4::Templates::gettemplate() and C4::Languages::getlanguage need are the "language" param and the "KohaOpacLanguage" cookie. We should be fetching these appropriately from the CGI or PSGI or whatever context at a higher level and passing back the data rather than the objects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 08:23:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 07:23:08 +0000 Subject: [Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 08:23:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 07:23:08 +0000 Subject: [Koha-bugs] [Bug 27293] Refactor C4::Templates and C4::Languages to not use CGI objects directly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26791 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 08:27:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 07:27:50 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114518|0 |1 is obsolete| | --- Comment #230 from Josef Moravec --- Created attachment 114585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114585&action=edit Bug 15516: (follow-up) Fix db structure and atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 08:27:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 07:27:59 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #231 from Josef Moravec --- Created attachment 114586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114586&action=edit Bug 15516: DO NOT PUSH - Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 08:28:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 07:28:01 +0000 Subject: [Koha-bugs] [Bug 27293] Refactor C4::Templates and C4::Languages to not use CGI objects directly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 --- Comment #1 from David Cook --- We could also remove the following warnings since they're not actually useful: [2020/12/22 07:00:36] [WARN] no query in gettemplate at /kohadevbox/koha/C4/Templates.pm line 206. [2020/12/22 07:00:36] [WARN] no query in themelanguage at /kohadevbox/koha/C4/Templates.pm line 266. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 10:12:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 09:12:00 +0000 Subject: [Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206 --- Comment #3 from Fridolin Somers --- (In reply to Nick Clemens from comment #2) > Elastic uses the sum of the 'issues' field which is set to the default of > '952l' - so it should match the output when the totalissues field is counted > using items. Ah sure. But I don't see where Elastic does this sum ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 10:16:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 09:16:21 +0000 Subject: [Koha-bugs] [Bug 26171] Show biblionumber in Koha::Exceptions::Metadata::Invalid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26171 --- Comment #12 from Fridolin Somers --- (In reply to Nick Clemens from comment #11) > Added a follow-up to clarify which object threw the exception and explain > where the id comes from - feel free to drop if you disagree RM +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 10:17:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 09:17:21 +0000 Subject: [Koha-bugs] [Bug 18017] [Unimarc] Importing biblios from Z39.50 servers duplicates related authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #10 from Fridolin Somers --- I'm on creating more patches so I set to ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 10:21:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 09:21:05 +0000 Subject: [Koha-bugs] [Bug 27291] Change datetime format in Zebra logs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27291 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 10:21:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 09:21:19 +0000 Subject: [Koha-bugs] [Bug 27139] Search errors are incorrectly shown to users as no results found In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27139 --- Comment #7 from Fridolin Somers --- (In reply to David Cook from comment #6) > Frido: Bug 27291 may be interesting to you. I think that change would make > it a lot easier to monitor the Zebra logs... Oooo nice -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 10:26:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 09:26:02 +0000 Subject: [Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 --- Comment #22 from David Cook --- Created attachment 114587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114587&action=edit Bug 26791: Use Mojolicious record exporter when using ExportCircHistory This patch uses the Mojolicious record exporter to export records from the Circulation module. Test plan: 1. Change system preference "ExportCircHistory" to "Show" 2. Checkout items 39999000004571 and 39999000001310 to the "koha" borrower 3. Select checkouts from list and check the "Export" checkboxes 4. Click "Export" at the bottom of the page 5. Note that valid ISO 2709 MARC is generated in the export -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 10:38:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 09:38:16 +0000 Subject: [Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 --- Comment #23 from David Cook --- I still have more work to do, but the core is there. It's really now just about building out the controller, hopefully moving code into modules, and adding unit tests for those modules. Actually, exporting as CSV is going to be annoying, but I have some ideas. I'm hoping to look at this more over the holidays. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 10:55:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 09:55:19 +0000 Subject: [Koha-bugs] [Bug 27091] Document how Elasticsearch is supposed to work and implement respective configurations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27091 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 11:02:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 10:02:05 +0000 Subject: [Koha-bugs] [Bug 18017] [Unimarc] Importing biblios from Z39.50 servers duplicates related authorities In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59675|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 11:02:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 10:02:41 +0000 Subject: [Koha-bugs] [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[Unimarc] Importing biblios |Use index_heading and |from Z39.50 servers |index_match_heading in |duplicates related |UNIMARC authorities zebra |authorities |configuration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 11:33:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 10:33:42 +0000 Subject: [Koha-bugs] [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 11:33:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 10:33:46 +0000 Subject: [Koha-bugs] [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #11 from Fridolin Somers --- Created attachment 114588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114588&action=edit Bug 18017: Add subdivisions to UNIMARC authorities zebra configuration Like for MARC21, UNIMARC authorities has subdivisions form, general, chronological and geographic. In C4::Heading::UNIMARC, use subdivisions in _get_search_heading like in C4::Heading::MARC21. Adds subdivisions variables into UNIMARC authorities zebra configuration. Note that unlike MARC21 geographic is subfield $y and chronological is subfield $z. See https://www.ifla.org/publications/unimarc-formats-and-related-documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 11:34:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 10:34:08 +0000 Subject: [Koha-bugs] [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #12 from Fridolin Somers --- Created attachment 114589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114589&action=edit Bug 18017: Use index_heading and index_match_heading in UNIMARC authorities zebra configuration For a good management of autorities linking to biblio records, MARC21 uses index_heading and index_match_heading in authorities zebra configuration. UNIMARC configuration must use the same. This patch adds in UNIMARC authorities zebra configuration index_heading and index_match_heading to earch heading in order to be maximum close to MARC21 authorities zebra configuration. See changes made in MARC21 : https://git.koha-community.org/Koha-community/Koha/commit/32cf2af700dfea15d9c4f99bee97e97c85643896 It fixes some indexes names : Personal-name-see => Personal-name-see-from Removes useless Term-geographic index, a duplicate of Name-geographic. Sometimes parallel 7xx form whas only on $a, it must contains same subfields has the main heading. Test plan : =========== 1.0) Use a UNIMARC install without patch 1.1) Set sysprefs BiblioAddsAuthorities = ON AutoCreateAuthorities = ON LinkerModule = First Match 1.2) Replace authorities zebra configuration files cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl 1.3) Restart zebra server and indexer services 1.4) Reindex authorities ./misc/migration_tools/rebuild_zebra.pl -r -a -v 1.5) Search in Z3950 a record with complex heading (with subdivisions), for example ISBN 2877620115 "Facteurs culturels et sociaux de la santé en Afrique de l'Oues" 1.6) Import this record and save it : authorities are created go to staff:/cgi-bin/koha/cataloguing/addbooks.pl 1.7) Reimport the same record (when asked, say that it's not a duplicate) 1.8) The authority should have been duplicated : different url and different $9 value 2.0) Apply this patch 2.1) Replace again the authorities zebra configuration files 2.2) Restart zebra server and indexer services 2.3) Reindex authorities 2.4) Reimport the same record 2.5) The authority should have not been duplicated 3.0) Play with authorities search to check every mode : Search main heading ($a only) Search main heading Search all headings Search entire record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 11:48:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 10:48:15 +0000 Subject: [Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin Somers --- +1 Very strange to see hardcoded field 245 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 11:49:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 10:49:43 +0000 Subject: [Koha-bugs] [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114589|0 |1 is obsolete| | --- Comment #13 from Fridolin Somers --- Created attachment 114590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114590&action=edit Bug 18017: Use index_heading and index_match_heading in UNIMARC authorities zebra configuration For a good management of autorities linking to biblio records, MARC21 uses index_heading and index_match_heading in authorities zebra configuration. UNIMARC configuration must use the same. This patch adds in UNIMARC authorities zebra configuration index_heading and index_match_heading to earch heading in order to be maximum close to MARC21 authorities zebra configuration. See changes made in MARC21 : https://git.koha-community.org/Koha-community/Koha/commit/32cf2af700dfea15d9c4f99bee97e97c85643896 It fixes some indexes names : Personal-name-see => Personal-name-see-from Removes useless Term-geographic index, a duplicate of Name-geographic. Sometimes parallel 7xx form whas only on $a, it must contains same subfields has the main heading. Test plan : =========== 1.0) Use a UNIMARC install without patch 1.1) Set sysprefs BiblioAddsAuthorities = ON AutoCreateAuthorities = ON LinkerModule = First Match 1.2) Replace authorities zebra configuration files cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-koha-indexdefs.xml cp $KOHA_CLONE/etc/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl $KOHA_CONF_DIR/zebradb/marc_defs/unimarc/authorities/authority-zebra-indexdefs.xsl 1.3) Restart zebra server and indexer services 1.4) Reindex authorities ./misc/migration_tools/rebuild_zebra.pl -r -a -v 1.5) Search in Z3950 a record with complex heading (with subdivisions), for example ISBN 2877620115 "Facteurs culturels et sociaux de la santé en Afrique de l'Oues" 1.6) Import this record and save it : authorities are created go to staff:/cgi-bin/koha/cataloguing/addbooks.pl 1.7) Reimport the same record (when asked, say that it's not a duplicate) 1.8) The authority should have been duplicated : different url and different $9 value 2.0) Apply this patch 2.1) Replace again the authorities zebra configuration files 2.2) Restart zebra server and indexer services 2.3) Reindex authorities 2.4) Reimport the same record 2.5) The authority should have not been duplicated 3.0) Play with authorities search to check every mode : Search main heading ($a only) Search main heading Search all headings Search entire record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 11:51:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 10:51:00 +0000 Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 11:51:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 10:51:04 +0000 Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259 --- Comment #1 from Joonas Kylmälä --- Created attachment 114591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114591&action=edit Bug 27259: Test HomeOrHoldingBranch usage in TooMany() This shows that HomeOrHoldingBranch syspref is incorrectly not used by TooMany() when it decides which circ rule to use. Run "prove t/db_dependent/Circulation/TooMany.t" to notice the tests now fail. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 11:51:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 10:51:07 +0000 Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259 --- Comment #2 from Joonas Kylmälä --- Created attachment 114592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114592&action=edit Bug 27259: Test HomeOrHoldingBranch usage in _CalculateAndUpdateFine() This shows that HomeOrHoldingBranch syspref is incorrectly not used by _CalculateAndUpdateFine() when it decides which circ rule to use. Run "prove t/db_dependent/Circulation/_CalculateAndUpdateFine.t" to notice the tests now fail. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 11:51:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 10:51:09 +0000 Subject: [Koha-bugs] [Bug 27259] HomeOrHoldingBranch is not used in all places In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27259 --- Comment #3 from Joonas Kylmälä --- Created attachment 114593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114593&action=edit Bug 27259: Add HomeOrHoldingBranch checks where it was missing from The TooMany() function and fine calculation functions were incorrectly hard coded to use homebranch for fetching the circulation rules. Those ignored completely the syspref HomeOrHoldingBranch where the user might have set it to holdingbranch and therefore the fines and whether patron has too many checkouts (TooMany()) were counted using the unintended branch's rules. This problem only arises in the cases where there are branch specific circulation rules defined. Test plan: 1. Make sure following tests pass: $ prove t/db_dependent/Circulation/_CalculateAndUpdateFine.t $ prove t/db_dependent/Circulation/TooMany.t Test plan for fines.pl: 1. Add branch specific fine rules for branches A and B. A having a fine of 1 per day and B having a fine of 0 per day. 2. Set sysprefs: CircControl = the library the items is from finesMode = Calculate and charge HomeOrHoldingBranch = holdingbranch 3. Create an item with home and holding branch of A 4. Checkout the item with a due date in the past (the past due date can be specified by clicking "Checkout settings" in the checkout page) and make sure the branch you are checking from is B. 5. Run perl /usr/share/koha/bin/cronjobs/fines.pl 6. Notice that fines have popped up now to the patron incorrectly 7. Apply patch 8. Pay fines, Check-in the item and check it out again 9. Run perl /usr/share/koha/bin/cronjobs/fines.pl 10. Notice that fine is now 0. This means that the branch B (holdingbranch of the checked-out item) specific rule is used. Test plan for staticfines.pl: 1. Add branch specific fine rules for branches A and B. A having a fine of 1 per day and B having a fine of 0 per day. 2. Set sysprefs: CircControl = the library the items is from finesMode = Calculate and charge HomeOrHoldingBranch = holdingbranch 3. Create an item with homebranch A and holding branch of A 4. Checkout the item with a due date in the past (the past due date can be specified by clicking "Checkout settings" in the checkout page) and make sure the branch you are checking from is B. 5. Run perl staticfines.pl --library A --library B --category and notice that now there is inccorectly fines 6. Apply patch 7. Pay fines, Check-in the item and check it out again 8. Run perl staticfines.pl --library A --library B --category and notice the fines are now not generated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 12:10:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 11:10:22 +0000 Subject: [Koha-bugs] [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 --- Comment #14 from Fridolin Somers --- See also https://github.com/indexdata/idzebra/issues/24 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 12:40:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 11:40:50 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114548|0 |1 is obsolete| | Attachment #114549|0 |1 is obsolete| | Attachment #114550|0 |1 is obsolete| | Attachment #114551|0 |1 is obsolete| | Attachment #114574|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 114594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114594&action=edit Bug 24254: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 12:41:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 11:41:15 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 12:41:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 11:41:21 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114594|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall --- Created attachment 114595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114595&action=edit Bug 24254: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 12:41:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 11:41:32 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #31 from Kyle M Hall --- Created attachment 114596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114596&action=edit Bug 24254: Add Koha::Items->filter_by_visible_in_opac This patch adds a method based on the original idea from Nick, but on Koha::Items. The idea is to build a proper filter, based on the current rules for hiding things, directly on the DBIC query. The caller takes care of knowing if the filtering should apply (i.e. checking the patron category exceptions) and then it would do something like: my @items; if ( ) { @items = $biblio->items->filter_by_visible_in_opac( { rules => $rules } ); } else { # still want to enforce 'hidelostitems' @items = $biblio->items->filter_by_visible_in_opac; } To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Look at the use cases on the tests, read the code => SUCCESS: It all makes sense 4. Compare with Koha::Item->hidden_in_opac => SUCCESS: It all makes sense 5. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 12:41:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 11:41:35 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #32 from Kyle M Hall --- Created attachment 114597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114597&action=edit Bug 24254: Compare itemlost with 0 On C4::Search and C4::Circulation the uses of the items.itemlost field highlight the fact that the comparisson itemlost <= 0 was wrong, as it is evaluated as a Perl boolean. The column can only be an int and NOT NULL, so we need to check if it is 0 to ponder if not hidden. This patch changes the tests to reflect this, and adjust the Koha::Items->filter_by_visible_in_opac implementation to adapt to this. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 12:41:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 11:41:38 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #33 from Kyle M Hall --- Created attachment 114598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114598&action=edit Bug 24254: Read the OpacHiddenItems preference internally After discussing the 'rules' parameter usefulness we decided it was not the best idea, and the gains in terms of 'performance' would me meaningless (in-memory caching of sysprefs). This patch makes a really minor tweak to the tests so they mock the C4::Context->yaml_preference method, but keeping the same original rules to highlight no behaviour change takes place. Then the rules parameter is removed from the calls, and the tests should keep passing. A minor change to make $rules = undef is made to highlight the // {} behaviour when reading the syspref.. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 12:41:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 11:41:41 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 --- Comment #34 from Kyle M Hall --- Created attachment 114599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114599&action=edit Bug 24254: Implement separate filters and add patron param This patch introduces two new methods for stacking filters on Koha::Items: - filter_out_lost _ filter_out_opachiddenitems This two filters are what actually happened inside the filter_by_visible_in_opac. Everything is covered by tests. In the process I added a Koha::Patron param to the method that is internally used to decide if the OPACHiddenItems syspref needs to be honoured or not. This *could* be better done with a fallback to C4::Context->userenv if no param is passed. I decided to leave that part for later, if we really find it would help (e.g. if bug 10589 gets some action and we really need something here to handle that). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 12:45:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 11:45:06 +0000 Subject: [Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206 --- Comment #4 from Nick Clemens --- (In reply to Fridolin Somers from comment #3) > (In reply to Nick Clemens from comment #2) > > Elastic uses the sum of the 'issues' field which is set to the default of > > '952l' - so it should match the output when the totalissues field is counted > > using items. > Ah sure. > But I don't see where Elastic does this sum ? https://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=Koha/SearchEngine/Elasticsearch.pm;h=4a2d75d03decd5413ceb1969601d561ae8251f3f;hb=HEAD#l645 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 12:56:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 11:56:05 +0000 Subject: [Koha-bugs] [Bug 27168] Most popular doesn't always sort correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27168 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114292|0 |1 is obsolete| | --- Comment #9 from Victor Grousset/tuxayo --- Created attachment 114600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114600&action=edit Bug 27168: Sort most popular by number of issues desc It seems that there is a weird behavior when the title is used as a second sort Test plan: Turn on OpacTopissue Make sure the table always displays entries sorted by number of issues desc Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 13:05:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 12:05:24 +0000 Subject: [Koha-bugs] [Bug 27168] Most popular doesn't always sort correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27168 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 13:23:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 12:23:33 +0000 Subject: [Koha-bugs] [Bug 22740] Automatically change lost status when item is paid for In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22740 --- Comment #8 from Martha Fuerst --- (In reply to Jeff Gaines from comment #6) > It would make sense to set the system to handle this for payments that are > not staff mediated. Even for staff-mediated payments, it's one less thing > for staff to do (or forget to do). Even for Paypal payments - if the payment is for a lost item, the lost status should be changed to lost and paid for. Otherwise, it is very unlikely that staff will (without looking for it via a report or somehow stumbling on it) will know the item was paid for and the status should be changed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 13:30:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 12:30:37 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 13:30:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 12:30:41 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104611|0 |1 is obsolete| | Attachment #104612|0 |1 is obsolete| | Attachment #104798|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 114601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114601&action=edit Bug 25429: Cleanup Database - remove resolved claims returned from db after X days Add option to cleanup_database script to removed 'resolved' return claims from the database after a specified number of days. Test Plan: 1) Apply this patch 2) Test cleanup_database with the new --return-claims DAYS option -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 13:30:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 12:30:51 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 --- Comment #9 from Kyle M Hall --- Created attachment 114602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114602&action=edit Bug 25429: Implement system preference, remove command line switch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 14:31:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 13:31:32 +0000 Subject: [Koha-bugs] [Bug 27293] Refactor C4::Templates and C4::Languages to not use CGI objects directly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27293 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Architecture, internals, | |and plumbing Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 14:41:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 13:41:30 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #232 from Josef Moravec --- Created attachment 114603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114603&action=edit Bug 15516: (follow-up) Move to Koha::Object[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 14:41:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 13:41:52 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 14:50:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 13:50:43 +0000 Subject: [Koha-bugs] [Bug 27292] TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 [Bug 22477] Missing DataTables configuration when searching patrons for holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 14:50:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 13:50:43 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27292 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 [Bug 27292] TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 14:54:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 13:54:58 +0000 Subject: [Koha-bugs] [Bug 27206] Elasticsearch sort by popularity must use totalissues search field In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27206 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #5 from Fridolin Somers --- Ohhhh thanks a lot. Field issues is indeed type sum. This is for the best ;) I mark this as invalid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 15:44:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 14:44:30 +0000 Subject: [Koha-bugs] [Bug 27294] New: Error when deleting claim Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 Bug ID: 27294 Summary: Error when deleting claim Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org To reproduce: - View a patron who has resolved claims, either the checkout page or the patron detail page. - From the claim's "Action" menu, choose "Delete" - In the browser console you will see an error: Uncaught ReferenceError: issuesTable is not defined The claim is deleted, but the action is supposed to trigger a refresh of the checkouts table. Because "issueTable" is defined within a different function it can't be referenced here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 15:53:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 14:53:36 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 --- Comment #2 from Matthias Meusburger --- Created attachment 114604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114604&action=edit Bug 19220: Allow XSLT processing for Z39.50 authority targets Test plan: 1) Apply the patch 2) Edit an authority Z3950/SRU source in Home > Administration > Z39.50/SRU servers 3) Add the path to an XSLT file in the "XSLT File(s) for transforming results" input, and save 4) Remove the content of the import_records table to avoid cache issues 5) Search for an authority with the "New from Z39.50/SRU" button in authorities home 6) Check that the XSLT transformation has been applied, both in results list and in the import window Here is an example XSLT which removes the 801 field from authorities: -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 15:54:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 14:54:06 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 15:54:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 14:54:26 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 15:55:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 14:55:53 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 --- Comment #3 from Matthias Meusburger --- I didn't add any new unit tests, since t/db_dependent/Breeding.t still passes with this patch, and _do_xslt_proc is already tested in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 16:00:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 15:00:08 +0000 Subject: [Koha-bugs] [Bug 27294] Error when deleting claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 16:00:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 15:00:10 +0000 Subject: [Koha-bugs] [Bug 27294] Error when deleting claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 --- Comment #1 from Owen Leonard --- Created attachment 114605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114605&action=edit Bug 27294: Error when deleting claim This patch corrects an error which occurs when deleting a claim from the claims tab on the checkout or patron detail page. To test, apply the patch and clear your browser cache if necessary. - If necessary, Enable claims returned functionality by defining a value in the ClaimReturnedLostValue system preference. - Open for checkout a patron who has items checked out. - From the table of checkouts, click "Claim returned" for one or more items. - Under the "Claims" tab, resolve one or more of the unresolved claims by choosing "Resolve" under the corresponding "Actions" menu. - Open the same "Actions" menu again and choose "Delete." - The claim should be deleted and there should be no error in the browser console. - Under the checkouts tab, the table should have refreshed so that the item which had been marked as "Claimed returned" no longer indicates an outstanding claim. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 16:00:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 15:00:16 +0000 Subject: [Koha-bugs] [Bug 24895] Elasticsearch CCL searching with phr modifier doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24895 --- Comment #4 from Nick Clemens --- Koha/SearchEngine/Elasticsearch/QueryBuilder.pm : _convert_index_strings_freeform 781 This is similar to L<_convert_index_strings>, however it'll search out the 782 things to change within the string. So it can handle strings such as 783 C<(su:foo) AND (su:bar)>, converting the C appropriately. 784 785 If there is something of the form "su,complete-subfield" or something, the 786 second part is stripped off as we can't yet handle that. Making it work 787 will have to wait for a real query parser. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 16:04:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 15:04:15 +0000 Subject: [Koha-bugs] [Bug 27294] Error when deleting claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114605|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 114606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114606&action=edit Bug 27294: Error when deleting claim This patch corrects an error which occurs when deleting a claim from the claims tab on the checkout or patron detail page. To test, apply the patch and clear your browser cache if necessary. - If necessary, Enable claims returned functionality by defining a value in the ClaimReturnedLostValue system preference. - Open for checkout a patron who has items checked out. - From the table of checkouts, click "Claim returned" for one or more items. - Under the "Claims" tab, resolve one or more of the unresolved claims by choosing "Resolve" under the corresponding "Actions" menu. - Open the same "Actions" menu again and choose "Delete." - The claim should be deleted and there should be no error in the browser console. - Under the checkouts tab, the table should have refreshed so that the item which had been marked as "Claimed returned" no longer indicates an outstanding claim. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:08:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:08:39 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112703|0 |1 is obsolete| | --- Comment #105 from Martin Renvoize --- Created attachment 114607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114607&action=edit Bug 20212: Add more embeddable objects to orders This patch adds options to embed more related objects based on the needs by parcel.tt. For filtering by biblioitems fields (ISBN and EAN) I had to make the 'list' method a modified version of the objects->search helper. I thought of doing it in a more generic way but I didn't find any other use cases and it would certainly make an already complex piece of code even more complex. So this is quite similar, but at some steps the biblio. gets translated into the proper relation names, and the same happens for prefetching. A new parameter is also added: only_active. It makes the controller use Koha::Acquisition::Orders->filter_by_active, avoiding the need to build complex queries in the UI. The same handling is done when the order_id parameter is passed (outside the q= parameters). In this case using Koha::Acquisition::Orders->filter_by_id_including_transfers This is all respecting the C4::Acquisitions::SearchOrders behaviour. TL;DR: This patch adapts the code from the list() sub so it manipulates the query parameters and the embed header so: - the biblioitem relationship is prefetch - any queries on biblio.isbn and biblio.ean are correctly translated into search on the biblioitems table. - Adds an only_active parameter to the /acquisitions/orders route to easily request only the active orders. Signed-off-by: Séverine QUEUNE Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:08:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:08:44 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112704|0 |1 is obsolete| | --- Comment #106 from Martin Renvoize --- Created attachment 114608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114608&action=edit Bug 20212: Clean parcel.pl Signed-off-by: Tomas Cohen Arazi Signed-off-by: Séverine QUEUNE Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:08:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:08:48 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112705|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize --- Created attachment 114609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114609&action=edit Bug 20212: Add missing relation in Biblio Signed-off-by: Tomas Cohen Arazi Signed-off-by: Séverine QUEUNE Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:08:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:08:53 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112706|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize --- Created attachment 114610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114610&action=edit Bug 20212: Use API to render orders datatable This patch makes the pending orders datatable render using the API instead of hte old controller script. It implements native server-side pagination thanks to the API and the datatables wrapper. On polishing it, we found that data can contain many null values, and it got dirtier in the process. This code with all the checks that are done on the data is the result of testing this dev with real-life production databases, huge ones with thousands of orderlines. To test: 1. You should compare the behaviour between this table, and the original one in master. Signed-off-by: Séverine QUEUNE Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:08:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:08:57 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112868|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize --- Created attachment 114611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114611&action=edit Bug 20212: (QA follow-up) Remember current filter This patch restores the original behaviour: if you jump into receiving an order, and then go back to receiving, you want the page to remember your filters. This feature was overlooked. On fixing it, I wrapped some JS code in a function for reusing it and simplified it a bit as well. To test: 1. Enter a search term in either of the search fields 2. Add a note, receive or do another action => SUCCESS: The search term is kept 3. Apply this patch set 4. Repeat 2 => SUCCESS: The search term is kept Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:09:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:09:02 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112882|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize --- Created attachment 114612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114612&action=edit Bug 20212: Controller changes regression tests This patchset did a copy and paste of the objects->search helper inside the controller, to handle a very special case that wasn't worth generalizing: the fact that the biblio object (that this patchset makes embeddable) is actually built from two tables, and we want to filter by fields in both tables. This requires us to translate: - Any filter reference to fields in biblioitems we allow to search on, through an allow list. - For filtering to work, we need to tweak the stashed 'embed' object so the prefetch is done correctly This patchset also adds a new query parameter: only_active. It is used to only request active orders (see the spec for more details). This patch adds tests for: - Filtering by a column in bilbioitems (this implies correctly prefetching the bilbio => biblioitems relation, and translating the filtering parameter. - Using the only_active query parameter to retrieve only active orders To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Verify the tests check for the explained behaviours. => SUCCESS: They do! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:09:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:09:06 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112987|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize --- Created attachment 114613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114613&action=edit Bug 20212: (QA follow-up) Restore table filter sticky Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:09:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:09:11 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113278|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize --- Created attachment 114614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114614&action=edit Bug 20212: (QA follow-up) Resurrect column filtering This patch adds per-column filtering to the order receiving table. The order cost column proved difficult to filter, because of the syntax DBIC requires for comparing replacement_cost * quantity, and passing that all the way down from the API request to DBIC itself. I'm still looking for options. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:09:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:09:15 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113279|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize --- Created attachment 114615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114615&action=edit Bug 20212: Make all biblioitems.* fields searchable Prior to this bug, only a few bilbio fields were actually searchable through the orders API. This patch adds all of them to the mapping, so other pages can take advantage of them. My first approach was to add things as needed. But this is trivial to make complete. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:09:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:09:20 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #114 from Martin Renvoize --- Created attachment 114616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114616&action=edit Bug 20212: (QA follow-up) Restore missing comma Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:09:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:09:24 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #115 from Martin Renvoize --- Created attachment 114617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114617&action=edit Bug 20212: (QA follow-up) Spelling typo fix Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:10:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:10:52 +0000 Subject: [Koha-bugs] [Bug 20212] Slowness in receiving in acquisitions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #116 from Martin Renvoize --- Works as expected. No regressions found and QA script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 17:57:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 16:57:17 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Abbey Holt changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aholt at dubuque.lib.ia.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 18:53:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 17:53:39 +0000 Subject: [Koha-bugs] [Bug 27295] New: Hshehehehhehe Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27295 Bug ID: 27295 Summary: Hshehehehhehe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: ayarsj417 at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114618&action=edit Hsheueheheh -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 19:16:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 18:16:03 +0000 Subject: [Koha-bugs] [Bug 27296] New: Return claims should be filtered by default to show unresolved claims Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27296 Bug ID: 27296 Summary: Return claims should be filtered by default to show unresolved claims Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I would like to add a default filter on the table of claims shown on the checkout and patron detail pages. The table will be filtered by default to show only unresolved claims, with links to switch back and forth between this view and a view of all claims. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 19:20:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 18:20:11 +0000 Subject: [Koha-bugs] [Bug 27296] Return claims should be filtered by default to show unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27296 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 [Bug 27294] Error when deleting claim -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 19:20:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 18:20:11 +0000 Subject: [Koha-bugs] [Bug 27294] Error when deleting claim In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27294 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27296 [Bug 27296] Return claims should be filtered by default to show unresolved claims -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 19:55:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 18:55:16 +0000 Subject: [Koha-bugs] [Bug 27296] Return claims should be filtered by default to show unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27296 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 19:55:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 18:55:18 +0000 Subject: [Koha-bugs] [Bug 27296] Return claims should be filtered by default to show unresolved claims In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27296 --- Comment #1 from Owen Leonard --- Created attachment 114619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114619&action=edit Bug 27296: Return claims should be filtered by default to show unresolved claims This patch modifies the DataTables configuration of the return claims table on the checkout and patron detail pages. Using the footerCallback function, the count of resolved and unresolved claims is calculated and used to filter the list of claims to show only unresolved claims by default. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - If necessary, Enable claims returned functionality by defining a value in the ClaimReturnedLostValue system preference. - Open for checkout a patron who has items checked out. - From the table of checkouts, click "Claim returned" for one or more items. - As you mark items "Clamed returned," the the items should appear under the "Claims" tab. The corresonding filter links should be updated accordingly, "Show all X claims." - Mark one or more claims resolved. As you do so they should disappear from the list of claims. The filter links should be updated to reflect that there are some resolved and some unresolved claims. - Clicking each filter link should trigger the correct filter. - Test this process when the count of unresolved claims is zero and when the cound of resolved claims is zero. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/checkouts.js for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:1086 msgid "Show 1 claim" msgid_plural "Show all {count} claims" msgstr[0] "" msgstr[1] "" - Edit the "msgstr" strings however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and repeat the test plan above. The translated strings should appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 20:02:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 19:02:01 +0000 Subject: [Koha-bugs] [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 20:06:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 19:06:20 +0000 Subject: [Koha-bugs] [Bug 27297] New: When itemtype is marked as required in OpacSuggestion MandatoryFields the field is not required Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Bug ID: 27297 Summary: When itemtype is marked as required in OpacSuggestion MandatoryFields the field is not required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Two issues: 1 - We only add the required class, we don't make the input required 2 - We don't add a 'blank' option, so the field is preselected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 20:31:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 19:31:38 +0000 Subject: [Koha-bugs] [Bug 27297] When itemtype is marked as required in OpacSuggestion MandatoryFields the field is not required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 20:31:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 19:31:40 +0000 Subject: [Koha-bugs] [Bug 27297] When itemtype is marked as required in OpacSuggestion MandatoryFields the field is not required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 --- Comment #1 from Nick Clemens --- Created attachment 114620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114620&action=edit Bug 27297: Add required and blank options to av-build-dropbox.inc This patch adds two options to av-build-drobx required - which will add the required attribute to the select blank - which will add a blank option to avoid preselecting others To test: 1 - In OpacSuggestionMandatoryFeilds select itemtype 2 - Go to OPAC 3 - Add a suggestion 4 - Don't fill out any fields 5 - Submit 6 - Suggestion is added 7 - Delete it 8 - Apply patch 9 - Add a suggestion 10 - Note itemtyp edefaults to 'None' 11 - You cannot submit until you select a value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 20:31:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 19:31:52 +0000 Subject: [Koha-bugs] [Bug 27297] When itemtype is marked as required in OpacSuggestion MandatoryFields the field is not required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 20:49:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 19:49:48 +0000 Subject: [Koha-bugs] [Bug 26953] Phone & SMS transports always displayed in overdue status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26953 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114293|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo --- Created attachment 114621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114621&action=edit Bug 26953: Hide phone and itiva from "Overdue notice/status triggers" If the prefs are off we should not display the checkboxes Test plan: 1. Turn off PhoneNotification and TalkingTechItivaPhoneNotification 2. Go to the "Overdue notice/status triggers" and confirm that phone and itiva columns are not displayed 3. Turn the prefs on and confirm the checkboxes are now displayed Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 20:50:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 19:50:15 +0000 Subject: [Koha-bugs] [Bug 26953] Phone & SMS transports always displayed in overdue status triggers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26953 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 21:31:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 20:31:34 +0000 Subject: [Koha-bugs] [Bug 27298] New: Adjusting a Numbering Pattern will not show in receiving next issue Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27298 Bug ID: 27298 Summary: Adjusting a Numbering Pattern will not show in receiving next issue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Publishers will sometimes change how their serials are numbered mid-year or a library may have their prediction pattern originally set up correctly, for whatever the reason, if a library edits an existing serial's prediction numbering pattern-the first expected issue after this change does not show the revised prediction. Steps: 1. Have a serial in which there is a numbering pattern and an issue has been received. For example, monthly magazine Vol. 25, No 3 2. Edit this existing subscription and alter the numbering pattern- to Vol 31 No.1. 3. Test this subscription and see Koha is accurately predicting the new numbering pattern of Vol 31 No. 1, Vol 31 No 2 etc. 4. Save subscription. 5. Attempt to receive that new issue, Vol 31, No.1 - see that Koha believes it is still receiving Vol 25, No 3. 6. Receive this issue, alter the enumeration for this issue. 7. Receive the next issue, and see Koha is successfully predicting the next issue Vol 31 No 2. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 22:01:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 21:01:46 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114392|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo --- Created attachment 114622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114622&action=edit Bug 27196: Don't explode if item that is waiting if checked in by SIP Signed-off-by: Nick Clemens Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 22:03:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 21:03:08 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #8 from Victor Grousset/tuxayo --- As a step towards QA, here is another signoff :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 22:22:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 21:22:00 +0000 Subject: [Koha-bugs] [Bug 15348] Change/Edit estimated delivery date per order line In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Aleisha Amohia changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114583|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia --- Created attachment 114623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114623&action=edit Bug 15348: Add estimated delivery date field to individual orders This patch allows you to specify an estimated delivery date per order. Work to do: - Make the Late Orders page check the estimated delivery date field - Make the Late Orders export functionality handle this - Edit the estimated delivery date from Late Orders page Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:01:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:01:05 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114513|0 |1 is obsolete| | --- Comment #233 from Josef Moravec --- Created attachment 114624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114624&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:01:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:01:14 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114514|0 |1 is obsolete| | --- Comment #234 from Josef Moravec --- Created attachment 114625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114625&action=edit Bug 15516: Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:01:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:01:22 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114515|0 |1 is obsolete| | --- Comment #235 from Josef Moravec --- Created attachment 114626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114626&action=edit Bug 15516: Reword 'reserve group' to 'hold group' Signed-off-by: Josef Moravec Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:01:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:01:31 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114516|0 |1 is obsolete| | --- Comment #236 from Josef Moravec --- Created attachment 114627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114627&action=edit Bug 15516: (follow-up) Fixing modal view and more Fixing - modal view - missed changes from 'reserve group' to 'hold group' - updating atomic update to perl - utf8mb4 Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:01:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:01:40 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114517|0 |1 is obsolete| | --- Comment #237 from Josef Moravec --- Created attachment 114628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114628&action=edit Bug 15516: (follow-up) Fix QA and rebase issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:01:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:01:49 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114585|0 |1 is obsolete| | --- Comment #238 from Josef Moravec --- Created attachment 114629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114629&action=edit Bug 15516: (follow-up) Fix db structure and atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:01:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:01:56 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114586|0 |1 is obsolete| | --- Comment #239 from Josef Moravec --- Created attachment 114630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114630&action=edit Bug 15516: DO NOT PUSH - Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:02:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:02:05 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114603|0 |1 is obsolete| | --- Comment #240 from Josef Moravec --- Created attachment 114631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114631&action=edit Bug 15516: (follow-up) Move to Koha::Object[s] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:02:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:02:48 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #241 from Josef Moravec --- Just rebased on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:05:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:05:45 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114631|0 |1 is obsolete| | --- Comment #242 from Josef Moravec --- Created attachment 114632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114632&action=edit Bug 15516: (follow-up) Move to Koha::Object[s] Test plan: prove t/db_dependent/Koha/HoldGroup.t prove t/db_dependent/Koha/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:19:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:19:03 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #243 from Josef Moravec --- Created attachment 114633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114633&action=edit Bug 15516: (follow-up) Remove C4::Reserves::GetHoldGroupHolds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:22:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:22:57 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #244 from Josef Moravec --- Created attachment 114634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114634&action=edit Bug 15516: (follow-up) Fix creating hold group in placerequest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:39:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:39:28 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:39:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:39:33 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114624|0 |1 is obsolete| | Attachment #114625|0 |1 is obsolete| | Attachment #114626|0 |1 is obsolete| | Attachment #114627|0 |1 is obsolete| | Attachment #114628|0 |1 is obsolete| | Attachment #114629|0 |1 is obsolete| | Attachment #114630|0 |1 is obsolete| | Attachment #114632|0 |1 is obsolete| | Attachment #114633|0 |1 is obsolete| | Attachment #114634|0 |1 is obsolete| | --- Comment #245 from Michal Denar --- Created attachment 114635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114635&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:39:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:39:41 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #246 from Michal Denar --- Created attachment 114636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114636&action=edit Bug 15516: Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:39:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:39:48 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #247 from Michal Denar --- Created attachment 114637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114637&action=edit Bug 15516: Reword 'reserve group' to 'hold group' Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:39:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:39:55 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #248 from Michal Denar --- Created attachment 114638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114638&action=edit Bug 15516: (follow-up) Fixing modal view and more Fixing - modal view - missed changes from 'reserve group' to 'hold group' - updating atomic update to perl - utf8mb4 Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:40:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:40:02 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #249 from Michal Denar --- Created attachment 114639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114639&action=edit Bug 15516: (follow-up) Fix QA and rebase issues Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:40:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:40:08 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #250 from Michal Denar --- Created attachment 114640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114640&action=edit Bug 15516: (follow-up) Fix db structure and atomic update Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:40:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:40:14 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #251 from Michal Denar --- Created attachment 114641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114641&action=edit Bug 15516: DO NOT PUSH - Schema changes Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:40:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:40:20 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #252 from Michal Denar --- Created attachment 114642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114642&action=edit Bug 15516: (follow-up) Move to Koha::Object[s] Test plan: prove t/db_dependent/Koha/HoldGroup.t prove t/db_dependent/Koha/Holds.t Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:40:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:40:27 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #253 from Michal Denar --- Created attachment 114643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114643&action=edit Bug 15516: (follow-up) Remove C4::Reserves::GetHoldGroupHolds Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:40:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:40:34 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #254 from Michal Denar --- Created attachment 114644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114644&action=edit Bug 15516: (follow-up) Fix creating hold group in placerequest Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:41:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:41:50 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #255 from Josef Moravec --- I have still some concerns: - ModReserveAffect, when hold from group is set to waiting (or transfer), this just delete other reserves from group and even group itself. I don't think it is what we want... We probably want to keep history - The changes in ModReserveAffect are not covered by tests - Is there other way of set hold waiting? If so, we need to make changes an all places where the hold status is affected - hold-group.js contains TT tags ;) (I will fix it) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:44:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:44:44 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114642|0 |1 is obsolete| | Attachment #114643|0 |1 is obsolete| | Attachment #114644|0 |1 is obsolete| | --- Comment #256 from Josef Moravec --- Created attachment 114645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114645&action=edit Bug 15516: (follow-up) Move to Koha::Object[s] Test plan: prove t/db_dependent/Koha/HoldGroup.t prove t/db_dependent/Koha/Holds.t Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:46:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:46:07 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #257 from Josef Moravec --- Just squashed last three patches into one for better readability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:56:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:56:39 +0000 Subject: [Koha-bugs] [Bug 27299] New: Zebra phrase register is incorrectly tokenized Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 Bug ID: 27299 Summary: Zebra phrase register is incorrectly tokenized Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au Recently, I noticed issues with "exact" matching for authority linking when using Zebra ICU. I've documented those issues upstream on the idzebra project on Github: https://github.com/indexdata/idzebra/issues/24 Adam Dickmeiss and I are still working through this issue, but it seems very likely to me that the issue is that we are tokenizing strings for the "p" register when we should not be. Looking at Zebra CHR, the "p" register is not tokenized. According to Zebra's own documentation (https://software.indexdata.com/zebra/doc/querymodel-zebra.html#querymodel-pqf-apt-mapping-structuretype), the "p" register is supposed to be "Character normalized, but not tokenized index for phrase matches". I'm still waiting for Adam to confirm my solution, but I've opened this bug report to track things on the Koha side, and to include a patch which I hope will resolve these problems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:56:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:56:52 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Zebra phrase register is |Zebra phrase register is |incorrectly tokenized |incorrectly tokenized when | |using ICU -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:58:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:58:57 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 --- Comment #1 from David Cook --- Created attachment 114646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114646&action=edit Bug 27299: Remove tokenization for phrase register/index with ICU This patch removes tokenization for phrase register/index when using ICU. This should cause "exact" searches to work the same way with ICU as they do with CHR. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:59:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:59:05 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:59:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:59:21 +0000 Subject: [Koha-bugs] [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27299 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 22 23:59:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 22:59:21 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18017 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:00:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:00:46 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #258 from Josef Moravec --- Created attachment 114647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114647&action=edit Bug 15516: (follow-up) Fix showing list of titles in hold group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:08:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:08:21 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114647|0 |1 is obsolete| | --- Comment #259 from Josef Moravec --- Created attachment 114648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114648&action=edit Bug 15516: (follow-up) Fix showing list of titles in hold group -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:12:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:12:40 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 --- Comment #2 from David Cook --- Here's a line for testing phrases-icu.xml: echo "Gontarski, S. E." | yaz-icu -c ./etc/zebradb/etc/phrases-icu.xml With the patch, I get the following: 1 1 'gontarski s e ' 'Gontarski S E ' Without the patch, I get the following: 1 1 'gontarski ' 'Gontarski ' 2 1 's ' 'S ' 3 1 'e ' 'E ' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:14:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:14:07 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #260 from Josef Moravec --- Created attachment 114649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114649&action=edit Bug 15516: (follow-up) Remove loading-small.gif reference Test plan: Ensure the hold group modal is still working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:14:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:14:53 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 --- Comment #3 from David Cook --- Actually, I have tested my change using the test_files.zip that I provided at https://github.com/indexdata/idzebra/issues/24, and this patch works well. I'm still going to wait to hear from Indexdata, but I think this is probably the right approach. Once I've confirmed with them, then I could look at adding a more Koha-centric test plan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:17:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:17:16 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #261 from Josef Moravec --- (In reply to Josef Moravec from comment #255) > - hold-group.js contains TT tags ;) (I will fix it) fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:20:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:20:16 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114635|0 |1 is obsolete| | Attachment #114636|0 |1 is obsolete| | Attachment #114637|0 |1 is obsolete| | Attachment #114638|0 |1 is obsolete| | Attachment #114639|0 |1 is obsolete| | Attachment #114640|0 |1 is obsolete| | Attachment #114641|0 |1 is obsolete| | Attachment #114645|0 |1 is obsolete| | Attachment #114649|0 |1 is obsolete| | --- Comment #262 from Michal Denar --- Created attachment 114650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114650&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:20:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:20:25 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #263 from Michal Denar --- Created attachment 114651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114651&action=edit Bug 15516: Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:20:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:20:31 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #264 from Michal Denar --- Created attachment 114652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114652&action=edit Bug 15516: Reword 'reserve group' to 'hold group' Signed-off-by: Josef Moravec Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:20:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:20:38 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #265 from Michal Denar --- Created attachment 114653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114653&action=edit Bug 15516: (follow-up) Fixing modal view and more Fixing - modal view - missed changes from 'reserve group' to 'hold group' - updating atomic update to perl - utf8mb4 Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:20:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:20:44 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #266 from Michal Denar --- Created attachment 114654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114654&action=edit Bug 15516: (follow-up) Fix QA and rebase issues Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:20:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:20:50 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #267 from Michal Denar --- Created attachment 114655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114655&action=edit Bug 15516: (follow-up) Fix db structure and atomic update Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:20:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:20:57 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #268 from Michal Denar --- Created attachment 114656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114656&action=edit Bug 15516: DO NOT PUSH - Schema changes Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:21:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:21:04 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #269 from Michal Denar --- Created attachment 114657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114657&action=edit Bug 15516: (follow-up) Move to Koha::Object[s] Test plan: prove t/db_dependent/Koha/HoldGroup.t prove t/db_dependent/Koha/Holds.t Signed-off-by: Michal Denar Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:21:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:21:11 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Michal Denar changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114648|0 |1 is obsolete| | --- Comment #270 from Michal Denar --- Created attachment 114658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114658&action=edit Bug 15516: (follow-up) Fix showing list of titles in hold group Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 00:21:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 22 Dec 2020 23:21:18 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #271 from Michal Denar --- Created attachment 114659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114659&action=edit Bug 15516: (follow-up) Remove loading-small.gif reference Test plan: Ensure the hold group modal is still working Signed-off-by: Michal Denar -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 01:58:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 00:58:17 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #272 from David Cook --- My test plan: Test plan: 0a. koha-shell kohadev -c /kohadevbox/koha/installer/data/mysql/updatedatabase.pl #0b. koha-shell kohadev -c "/kohadevbox/koha/misc/devel/update_dbix_class_files.pl --koha-conf /etc/koha/sites/kohadev/koha-conf.xml --db_name koha_kohadev" 0c. koha-plack --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=e 2. Click checkboxes next to # 1 and # 2 3. Click "Place hold" button at the top of search results 4. Enter "koha" into patron search and press "Search", then choose "koha," 5. Check the box for "Hold next available item" 6. Click "Place hold" 7. Note the text "(part of a hold group)" in Details column. 8. Click on the "hold group" link text 9. Note a modal with a title of "Hold group" and containing the two titles that you've previously selected 10. Go to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 11. Click on the "Holds" tab and note that there are 2 holds. One for each of the titles that you've selected. (There is no evidence here that they're part of a hold group.) 12. Checkin "39999000002195" 13. Note a modal saying "Hold found" and click "Confirm hold" 14. Go to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 15. Note that the 2nd hold for "The Arden edition of the works of William Shakespeare." has been removed. -- I'm failing QA as I can only see the "hold group" link on the following page: - reserve/request.pl It does *not* appear on the following pages (although it is claimed it is in the commit messages): - circ/circulation.pl - members/moremember.pl It is unknown whether or not it appears on the following pages because there were no tests for these pages: - circ/pendingreserves.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 02:03:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 01:03:35 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #273 from David Cook --- (In reply to Josef Moravec from comment #255) > I have still some concerns: > - ModReserveAffect, when hold from group is set to waiting (or transfer), > this just delete other reserves from group and even group itself. I don't > think it is what we want... We probably want to keep history I am curious about that as well. > - The changes in ModReserveAffect are not covered by tests That's not good. I think that might be an automatic QA fail? > - Is there other way of set hold waiting? If so, we need to make changes an > all places where the hold status is affected I don't know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 02:04:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 01:04:34 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #274 from David Cook --- Output from qa tool: testing 10 commit(s) (applied to 6982680 'e9 Bug 14564: Set permissions on conf') Processing files before patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 312. |========================>| 31 / 31 (100.00%) Processing files after patches Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt line 312. |========================>| 31 / 31 (100.00%) OK C4/Reserves.pm OK Koha/HoldGroup.pm OK Koha/HoldGroups.pm OK Koha/Holds.pm FAIL Koha/Schema/Result/HoldGroup.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK Koha/Schema/Result/OldReserve.pm OK Koha/Schema/Result/Reserve.pm OK Koha/Template/Plugin/Biblio.pm OK circ/pendingreserves.pl FAIL installer/data/mysql/atomicupdate/bug_15516.sql FAIL git manipulation The file has been added and deleted in the same patchset OK installer/data/mysql/kohastructure.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/hold-group-modal.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc FAIL koha-tmpl/intranet-tmpl/prog/en/includes/reserve-group-modal.inc FAIL git manipulation The file has been added and deleted in the same patchset OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/hold-group.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt OK koha-tmpl/intranet-tmpl/prog/en/modules/reserve/reserve-group.tt OK koha-tmpl/intranet-tmpl/prog/js/hold-group.js OK koha-tmpl/intranet-tmpl/prog/js/holds.js OK opac/opac-reserve.pl OK reserve/hold-group.pl OK reserve/placerequest.pl OK reserve/request.pl FAIL reserve/reserve-group.pl FAIL file permissions File must have the exec flag OK svc/holds OK t/db_dependent/Koha/HoldGroup.t OK t/db_dependent/Koha/Holds.t FAIL t/db_dependent/Reserves/HoldCount.t FAIL file permissions File must have the exec flag FAIL git manipulation The file has been added and deleted in the same patchset Processing additional checks OK! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 02:41:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 01:41:17 +0000 Subject: [Koha-bugs] [Bug 27300] New: Create a hold group for multiple items in one record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27300 Bug ID: 27300 Summary: Create a hold group for multiple items in one record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Some libraries want to be able to create a hold group for multiple items in one record. (There could be a variety of reasons relating to location, itype, etc.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 02:41:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 01:41:26 +0000 Subject: [Koha-bugs] [Bug 27300] Create a hold group for multiple items in one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27300 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15565 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 02:41:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 01:41:26 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27300 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 02:41:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 01:41:39 +0000 Subject: [Koha-bugs] [Bug 27300] Create a hold group for multiple items in one record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27300 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15516, 23457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 [Bug 15516] Allow to place a hold on first available item from a group of titles https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23457 [Bug 23457] Can't pick the items when placing multiple holds on a record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 02:41:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 01:41:39 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27300 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27300 [Bug 27300] Create a hold group for multiple items in one record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 02:41:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 01:41:39 +0000 Subject: [Koha-bugs] [Bug 23457] Can't pick the items when placing multiple holds on a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23457 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27300 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27300 [Bug 27300] Create a hold group for multiple items in one record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 02:42:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 01:42:11 +0000 Subject: [Koha-bugs] [Bug 27300] Create a hold group for multiple items in one record in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27300 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Create a hold group for |Create a hold group for |multiple items in one |multiple items in one |record |record in staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 02:47:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 01:47:05 +0000 Subject: [Koha-bugs] [Bug 27301] New: Harmonize methods for providing biblionumbers to opac-reserve.pl Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 Bug ID: 27301 Summary: Harmonize methods for providing biblionumbers to opac-reserve.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com At the moment, you can send biblionumbers to opac-reserve.pl either as multiple "biblionumbers" arguments or as a single compacted string like "1/2/3". It seems silly to me to have all this code for handling these different scenarios. We should just harmonize the callers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 03:43:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 02:43:52 +0000 Subject: [Koha-bugs] [Bug 27300] Create a hold group for multiple items in one record in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27300 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24857 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 03:43:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 02:43:52 +0000 Subject: [Koha-bugs] [Bug 24857] Add ability to create "Volumes" for records, and assign items to volumes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27300 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 04:55:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 03:55:24 +0000 Subject: [Koha-bugs] [Bug 27198] Sync marc21-retrieval-info-auth-dom.xml with retrieval-info-auth-dom.xml In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27198 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #3 from David Cook --- Listing this one as Academy as it's pretty straight-forward. Happy to help people with this one too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 04:55:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 03:55:48 +0000 Subject: [Koha-bugs] [Bug 26328] incremental barcode generation fails when incorrectly converting strings to numbers In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26328 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 05:01:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 04:01:16 +0000 Subject: [Koha-bugs] [Bug 26363] Provide a systemd unit file for background_jobs_worker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26363 --- Comment #21 from David Cook --- Should this be "In discussion" or "Failed QA" or...? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 05:41:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 04:41:42 +0000 Subject: [Koha-bugs] [Bug 27292] TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 05:44:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 04:44:30 +0000 Subject: [Koha-bugs] [Bug 27292] TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 05:44:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 04:44:33 +0000 Subject: [Koha-bugs] [Bug 27292] TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 --- Comment #1 from David Cook --- Created attachment 114660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114660&action=edit Bug 27292: Add TablesSettings directive to fix columns_settings_borrowers_table This patch adds the USE TablesSettings directive which allows the plugin to be invoked to fill the columns_settings_borrowers_table variable. Test plan: 0. Do not apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 2. View source on the page and note columns_settings_borrowers_table has no value assigned 2. Apply the patch 3. In a new tab, go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 4. Note that nothing has changed on the surfeace 5. View source ont he page and note columns_settings_borrowers_table now has a value assigned -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 05:45:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 04:45:02 +0000 Subject: [Koha-bugs] [Bug 27292] TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #2 from David Cook --- Thanks for adding that dependency, Owen. That helped a lot. And now a patch for you (or someone else) to test :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 05:45:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 04:45:12 +0000 Subject: [Koha-bugs] [Bug 27299] Zebra phrase register is incorrectly tokenized when using ICU In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27299 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 05:47:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 04:47:02 +0000 Subject: [Koha-bugs] [Bug 26657] "Unlinked" output of LinkBibHeadingsToAuthorities is ambiguous In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26657 --- Comment #2 from David Cook --- I would love to see some love on this one, as it's actually quite a handy change for sysadmins. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 05:51:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 04:51:47 +0000 Subject: [Koha-bugs] [Bug 12548] Auth::checkauth() needs more in-line comments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12548 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #2 from David Cook --- While C4::Auth::checkauth() is a nightmare, this bug report doesn't really add value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 05:52:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 04:52:42 +0000 Subject: [Koha-bugs] [Bug 9277] Counter-intuitive Display of Authtypetext in Authority Searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9277 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from David Cook --- I think that this is actually no longer relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 05:57:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 04:57:08 +0000 Subject: [Koha-bugs] [Bug 12547] Create better API for handling external authentication In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #6 from David Cook --- This is a vague report. It's better to open a bug report for a specific enhancement to authentication like Bug 21586. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 06:00:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 05:00:46 +0000 Subject: [Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #20 from David Cook --- Hmm, are you sure that this is actually needed? I think that this one might be invalid now. Bug 26199 uses required match checks and MARCXML and it works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 06:02:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 05:02:32 +0000 Subject: [Koha-bugs] [Bug 27087] Allow encoding level comparison on record import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27087 --- Comment #4 from David Cook --- (In reply to David Cook from comment #3) > (In reply to Andrew Fuerste-Henry from comment #2) > > So maybe a broader move to allow match checks to use a comparison other than > > equals? So we'd set a target subfield in the incoming record, a target > > subfield in the existing record, and a comparison operator? > > > > I'd say a broader move to allow match points to use comparisons other than > equals. (LDR and control fields don't have subfields.) > I'm just reviewing my old bug reports and what do you know. I had this idea 5 years ago heh. Bug 15536. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 06:57:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 05:57:30 +0000 Subject: [Koha-bugs] [Bug 27301] Harmonize methods for providing biblionumbers to opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 --- Comment #1 from David Cook --- These appear to be the templates that reference opac-reserve.pl using the concatenated "biblionumbers" syntax: 1. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt 2. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt 3. koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt 4. koha-tmpl/opac-tmpl/bootstrap/js/basket.js Test plan: _Search Results_ (opac-results.tt) 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Click "Place hold" _Cart_ (basket.js) 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Add to cart 4. Click on "Cart" 5. Click "Select all" 6. Click "Place hold" _Detail page_ TBC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 06:58:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 05:58:34 +0000 Subject: [Koha-bugs] [Bug 27301] Harmonize methods for providing biblionumbers to opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 --- Comment #2 from David Cook --- Using jQuery, it's fairly trivial to build a querystring of "biblionumber=1&biblionumber=2&biblionumber=3". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 07:42:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 06:42:06 +0000 Subject: [Koha-bugs] [Bug 27301] Harmonize methods for providing biblionumbers to opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 07:42:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 06:42:09 +0000 Subject: [Koha-bugs] [Bug 27301] Harmonize methods for providing biblionumbers to opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 --- Comment #3 from David Cook --- Created attachment 114661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114661&action=edit Bug 27301: Pass biblionumbers to opac-reserve.pl in one style only This patch forces biblionumbers to be passed to opac-reserve.pl as individual "biblionumber" parameters instead of sending a concatenated string as a "biblionumbers" parameter. Test plan: _Search Results_ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Click "Place hold" 4. Click "Confirm hold" 5. Note that holds are made 6. Cancel holds to prepare for next test... _Cart_ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Add to cart 4. Click on "Cart" 5. Click "Select all" 6. Click "Place hold" 7. Click "Confirm hold" 8. Note that holds are made 9. Cancel holds to prepare for next test... _List_ 1. Go to http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=&q=test&weight_search=1 2. Checkbox # 1 and # 2 3. Add to new list 4. Click on list 5. Click "Select all" 6. Click "Place hold" 7. Click "Confirm hold" 8. Note that holds are made 9. Cancel holds to prepare for next test... _Detail page_ 1. Go to http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=29 2. Click "Place hold" 3. Click "Confirm hold" 4. Note that holds are made 5. Cancel hold (because you may as well at this point) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 07:42:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 06:42:57 +0000 Subject: [Koha-bugs] [Bug 15565] Place multiple holds at once for the same record in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27301 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 07:42:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 06:42:57 +0000 Subject: [Koha-bugs] [Bug 27301] Harmonize methods for providing biblionumbers to opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15565 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 07:43:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 06:43:23 +0000 Subject: [Koha-bugs] [Bug 27301] Harmonize methods for providing biblionumbers to opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 07:44:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 06:44:02 +0000 Subject: [Koha-bugs] [Bug 27300] Create a hold group for multiple items in one record in staff interface In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27300 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 07:44:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 06:44:27 +0000 Subject: [Koha-bugs] [Bug 27301] Harmonize methods for providing biblionumbers to opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 07:46:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 06:46:59 +0000 Subject: [Koha-bugs] [Bug 27301] Harmonize methods for providing biblionumbers to opac-reserve.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27301 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23457 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 07:46:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 06:46:59 +0000 Subject: [Koha-bugs] [Bug 23457] Can't pick the items when placing multiple holds on a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23457 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27301 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 08:37:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 07:37:03 +0000 Subject: [Koha-bugs] [Bug 27302] New: couldn't view biblio.author on reports Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27302 Bug ID: 27302 Summary: couldn't view biblio.author on reports Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: nishathahmed at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 114662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114662&action=edit Koha-report hi There, I just want to take report of item bar code and author of book. I can get barcode and failed to fetch author by executing following SQL SELECT items.barcode, biblio.author FROM items LEFT JOIN biblioitems on (items.biblioitemnumber=biblioitems.biblioitemnumber) LEFT JOIN biblio on (biblioitems.biblionumber=biblio.biblionumber) GROUP BY items.barcode,biblio.author. I get empty column on author when I execute this SQL statement. I entered my catalogue entry on fast add framework with statement of responsibility as author. But still no luck. You can refer attachments of output. Correct me if I am wrong or raise as bug. Thanks! Nishath -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 08:37:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 07:37:13 +0000 Subject: [Koha-bugs] [Bug 27302] couldn't view biblio.author on reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27302 Nishath Ahmed changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nishathahmed at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 11:21:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 10:21:55 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 11:21:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 10:21:59 +0000 Subject: [Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114524|0 |1 is obsolete| | --- Comment #9 from Andrew Isherwood --- Created attachment 114663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114663&action=edit Bug 26498: Set default expiration date for holds Koha doesn't automatically set expiration date for holds so they can live in the system forever. This patch adds new sysprefs to control setting of default expiration date for holds. Note that expiration date is only set if input field for it is left blank. To test: 1. Apply patch and update database. 2. Enable syspref "DefaultHoldExpirationdate" and set some values to "DefaultHoldExpirationdatePeriod" and "DefaultHoldExpirationdateUnitOfTime". 3. Add some holds for patron from staff client or OPAC and leave expiration date input field blank. => Holds expiration date should be set according your settings 4. Disable "DefaultHoldExpirationdate" and repeat step 3. => Expiration date shouldn't be set. Also prove prove t/db_dependent/Hold.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Andrew Isherwood -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 12:25:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 11:25:41 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114595|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize --- Created attachment 114664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114664&action=edit Bug 24254: Unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 12:25:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 11:25:44 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114596|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize --- Created attachment 114665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114665&action=edit Bug 24254: Add Koha::Items->filter_by_visible_in_opac This patch adds a method based on the original idea from Nick, but on Koha::Items. The idea is to build a proper filter, based on the current rules for hiding things, directly on the DBIC query. The caller takes care of knowing if the filtering should apply (i.e. checking the patron category exceptions) and then it would do something like: my @items; if ( ) { @items = $biblio->items->filter_by_visible_in_opac( { rules => $rules } ); } else { # still want to enforce 'hidelostitems' @items = $biblio->items->filter_by_visible_in_opac; } To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Look at the use cases on the tests, read the code => SUCCESS: It all makes sense 4. Compare with Koha::Item->hidden_in_opac => SUCCESS: It all makes sense 5. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 12:25:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 11:25:48 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114597|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize --- Created attachment 114666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114666&action=edit Bug 24254: Compare itemlost with 0 On C4::Search and C4::Circulation the uses of the items.itemlost field highlight the fact that the comparisson itemlost <= 0 was wrong, as it is evaluated as a Perl boolean. The column can only be an int and NOT NULL, so we need to check if it is 0 to ponder if not hidden. This patch changes the tests to reflect this, and adjust the Koha::Items->filter_by_visible_in_opac implementation to adapt to this. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 12:25:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 11:25:51 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114598|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize --- Created attachment 114667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114667&action=edit Bug 24254: Read the OpacHiddenItems preference internally After discussing the 'rules' parameter usefulness we decided it was not the best idea, and the gains in terms of 'performance' would me meaningless (in-memory caching of sysprefs). This patch makes a really minor tweak to the tests so they mock the C4::Context->yaml_preference method, but keeping the same original rules to highlight no behaviour change takes place. Then the rules parameter is removed from the calls, and the tests should keep passing. A minor change to make $rules = undef is made to highlight the // {} behaviour when reading the syspref.. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 12:25:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 11:25:55 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114599|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize --- Created attachment 114668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114668&action=edit Bug 24254: Implement separate filters and add patron param This patch introduces two new methods for stacking filters on Koha::Items: - filter_out_lost _ filter_out_opachiddenitems This two filters are what actually happened inside the filter_by_visible_in_opac. Everything is covered by tests. In the process I added a Koha::Patron param to the method that is internally used to decide if the OPACHiddenItems syspref needs to be honoured or not. This *could* be better done with a fallback to C4::Context->userenv if no param is passed. I decided to leave that part for later, if we really find it would help (e.g. if bug 10589 gets some action and we really need something here to handle that). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Items.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 12:28:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 11:28:50 +0000 Subject: [Koha-bugs] [Bug 24254] Add Koha::Items->filter_by_visible_in_opac In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24254 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #40 from Martin Renvoize --- Right.. I think this is pretty solid now.. Passing QA. However, it does make me ask the question as to why our Koha::Item->store routine and cataloguing/additem.pl both do a >=/ge check on itemlost. I think you've discussed and proved to me that the check on itemlost is purely boolean.. false (0/undef) vs defined/not zero... but I can't help but have a nagging feeling the negatives used to be meaningful in some dim and distant past. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 12:48:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 11:48:27 +0000 Subject: [Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 12:48:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 11:48:27 +0000 Subject: [Koha-bugs] [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24295 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 13:59:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 12:59:09 +0000 Subject: [Koha-bugs] [Bug 15536] Additional match check comparison operators In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15536 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 14:08:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 13:08:58 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114190|0 |1 is obsolete| | --- Comment #25 from Nick Clemens --- Created attachment 114669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114669&action=edit Bug 26457: Throw exception if update of issues table fails While this won't prevent the deadlock, it should catch the case where a deadlock causes the DB update to fail and provide feedback to the user and rollback the transaction I don't know how to trigger the deadlock, I can only confirm that we see it, and that this should catch it. To test: 1 - Apply patches 2 - Checkout several items to a patron 3 - Confirm that 'Renew all' feature continues to work as expected and all items are renewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 14:10:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 13:10:00 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 --- Comment #26 from Nick Clemens --- (In reply to Jonathan Druart from comment #22) > Could you provide a test? I have tried, but it seems it requires a lot of mocking and I have not been successful, help would be appreciated :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 14:36:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 13:36:12 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 --- Comment #13 from Nick Clemens --- (In reply to Victor Grousset/tuxayo from comment #12) > The tests pass in 19.11.x but I have an error message not in 20.05.x > > kohadev-koha at 9ddfdbbbd877:/kohadevbox/koha$ prove > t/db_dependent/SIP/Transaction.t > t/db_dependent/SIP/Transaction.t .. 7/10 AddReturn error: branch 'SIP2' not > found. Reverting to bH8GNQ at /kohadevbox/koha/C4/Circulation.pm line 1844. > AddReturn error: branch 'SIP2' not found. Reverting to bH8GNQ at > /kohadevbox/koha/C4/Circulation.pm line 1844. > t/db_dependent/SIP/Transaction.t .. 9/10 AddReturn error: branch 'SIP2' not > found. Reverting to lw0u4bBY02 at /kohadevbox/koha/C4/Circulation.pm line > 1844. > AddReturn error: branch 'SIP2' not found. Reverting to lw0u4bBY02 at > /kohadevbox/koha/C4/Circulation.pm line 1844. > t/db_dependent/SIP/Transaction.t .. ok > All tests successful. > Files=1, Tests=10, 6 wallclock secs ( 0.04 usr 0.00 sys + 4.78 cusr 0.78 > csys = 5.60 CPU) > Result: PASS > > That doesn't look good right? I get the same warnings before this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 15:11:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 14:11:29 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 15:11:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 14:11:32 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114568|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 114670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114670&action=edit Bug 27290: Update 'type=number' to 'type=text inputmode=numeric' This patch updates the inputs for the pay form on the point of sale page to use numeric inputmode. This appears to also fix the validation issue described in the bug report. To test: 1 - Enable 'useCashRegisters' and 'EnablePointofSale' 2 - Add a cash register 3 - Add a debit type that can be sold 4 - Go to point of sale and sell the item multiple times 5 - Enter 'Amount tendered' less than amount being paid 6 - Click confirm 7 - Transaction is processed as if full funds received 8 - Try with a negative number - goes through again Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 15:11:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 14:11:34 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #4 from Nick Clemens --- Created attachment 114671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114671&action=edit Bug 27290: (follow-up) fix filters - make register required Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 15:12:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 14:12:16 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #5 from Nick Clemens --- (In reply to Martin Renvoize from comment #2) > I think there's some browser ambiguity here.. I tested on latest Chrome, > Firefox and Brave browsers and all worked as expected with this patch... but > I'm not entirely confident in my fix... it's a step in the right direction > accessibility wise though :) I can also no longer recreate - though now I was able to submit the form without a register selected? Follow-up attached, but maybe I am having other issues :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 15:27:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 14:27:47 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 15:31:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 14:31:13 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114553|0 |1 is obsolete| | --- Comment #11 from Nick Clemens --- Created attachment 114672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114672&action=edit Bug 27252: Add deprecation warning, cross_fields pref, and add version to ES info This patch prepares Koha to officially no longer support Elasticsearch 5.X It adds a new system preference 'ElasticsearchCrossFields' to allow users to choose whether or not to enable this feature It updates the about page to add a deprecation warning if a site is running ES5 To test: 1 - Be running Koha with Elasticsearch 5.X 2 - Attempt to search Error: Unable to perform your search. Please try again. 3 - Apply patch 4 - Update database 5 - Searching works 6 - Find syspref 'ElasticsearchCrossFields' 7 - Enable it 8 - Searching is now broken 9 - Check the about page 10 - you can now see the Elasticsearch version 11 - The systeminformation tab has a deprectaion warning 12 - Set SearchEngine preference to 'Zebra' 13 - View the about page - no warnings 14 - Test again with ES6 - searching should "work" with either pref setting 15 - There should be no warning on about pages Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 15:31:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 14:31:16 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #12 from Nick Clemens --- Created attachment 114673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114673&action=edit Bug 27252: [20.05 and earlier] Default to cross fields off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 15:31:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 14:31:38 +0000 Subject: [Koha-bugs] [Bug 27252] ES5 no longer supported (since 20.11.00) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27252 --- Comment #13 from Nick Clemens --- (In reply to Jonathan Druart from comment #2) > Shouldn't we turn the feature on for master and 20.11? Yes, amended patch and attached followup for earlier versions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 15:35:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 14:35:38 +0000 Subject: [Koha-bugs] [Bug 23763] Move pagination calculations to a subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23763 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 15:35:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 14:35:41 +0000 Subject: [Koha-bugs] [Bug 23763] Move pagination calculations to a subroutine In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23763 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93825|0 |1 is obsolete| | --- Comment #4 from Nick Clemens --- Created attachment 114674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114674&action=edit Bug 23763: Make search on staff and opac use new routine To test: 1 - Apply patch 2 - Search on staff and opac side 3 - Confirm you can paginate results 4 - Confirm you see 10 pages on pagination if under page 10 5 - Confirm you see 20 pages in pagination if over page 10 6 - Confirm you can go to first or last page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 15:58:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 14:58:24 +0000 Subject: [Koha-bugs] [Bug 27265] Process message queue cron should be able to take multiple types as a parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27265 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Andrew Fuerste-Henry --- This isn't working for me. Here's what I see: 1- have a patron with email enabled for CHECKOUT, CHECKIN notices and an email address on their account 2- check item out to patron, check item in again 3- confirm on patron notices page that they have pending CHECKOUT and CHECKIN notices 4- perl misc/cronjobs/process_message_queue.pl -c CHECKOUT -c CHECKIN 5- notices are not sent 6- perl misc/cronjobs/process_message_queue.pl -c CHECKOUT 7- one notice is sent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:07:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:07:09 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:07:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:07:13 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107793|0 |1 is obsolete| | Attachment #107794|0 |1 is obsolete| | Attachment #107795|0 |1 is obsolete| | --- Comment #42 from Nick Clemens --- Created attachment 114675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114675&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "Cannot place hold: no item are available to be placed on hold" 7 - Try placing a multihold with either record above and a holdable record, message should end "Cannot place hold on some items' 8 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:07:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:07:17 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #43 from Nick Clemens --- Created attachment 114676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114676&action=edit Bug 16787: Add noReservesAllowed to club holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:07:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:07:21 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #44 from Nick Clemens --- Created attachment 114677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114677&action=edit Bug 16787: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:25:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:25:08 +0000 Subject: [Koha-bugs] [Bug 25763] Allow update of order fund after receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:25:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:25:11 +0000 Subject: [Koha-bugs] [Bug 25763] Allow update of order fund after receipt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25763 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105892|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 114678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114678&action=edit Bug 25763: Allow updating of order fund from invoice To test: 1 - Receive some orders via acquisitions 2 - View the invoice with these orders 3 - Click 'Modify fund' on the received orders list 4 - Confirm you can change the fund 5 - Set some authorised value categories for funds 6 - Reload the invoice 7 - Confirm the categories dropdowns change when different funds selected 8 - Confirm updating the statistic fields saves correctly 9 - Add an inactive budget with some funds 10 - Test the 'show inactive' button on shipment fund, adjustments, and modifying order fund -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:39:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:39:37 +0000 Subject: [Koha-bugs] [Bug 27303] New: Behaviour depends on DB user permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27303 Bug ID: 27303 Summary: Behaviour depends on DB user permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org I was writing a helper method to check if a table is a view, for the merger of 'reserves' and 'old_reserves' into 'holds', and found that running things like [1]: my $sth = $dbh->prepare(" SELECT COUNT( * ) AS count FROM information_schema.COLUMNS WHERE COLUMN_NAME = 'reserve_id' AND ( TABLE_NAME LIKE 'reserves' OR TABLE_NAME LIKE 'old_reserves' ) "); Will give different results depending on the user permissions. So if (for some reason) the sysadmin sets two Koha instances on the same DB server, and the user has more privileges than expected, it will count things from databases other than those of the running instance. In the case of the views this was easy to spot: root at kohadevbox:misc4dev(master)$ mysql -hdb -ppassword Welcome to the MariaDB monitor. Commands end with ; or \g. Your MariaDB connection id is 232 Server version: 10.3.27-MariaDB-1:10.3.27+maria~focal mariadb.org binary distribution Copyright (c) 2000, 2018, Oracle, MariaDB Corporation Ab and others. Type 'help;' or '\h' for help. Type '\c' to clear the current input statement. MariaDB [(none)]> SELECT TABLE_SCHEMA, TABLE_NAME FROM information_schema.tables WHERE TABLE_NAME='reserves'; +--------------+------------+ | TABLE_SCHEMA | TABLE_NAME | +--------------+------------+ | koha_test | reserves | | koha_kohadev | reserves | +--------------+------------+ 2 rows in set (0.02 sec) What we need to do, is adding the database name on the WHERE condition, like: my $db_name = C4::Context->config('database'); ... WHERE TABLE_SCHEMA=$db_name; [1] taken from updatedatabase.pl:5573~5582 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:40:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:40:42 +0000 Subject: [Koha-bugs] [Bug 26996] Elasticsearch: Multiprocess reindexing sometimes doesn't reindex all records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26996 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:40:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:40:45 +0000 Subject: [Koha-bugs] [Bug 26996] Elasticsearch: Multiprocess reindexing sometimes doesn't reindex all records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26996 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114232|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 114679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114679&action=edit Bug 26996: Convert Elasticsearch indexer commit buffer size to integer When multithreaded indexing is used, the commit size for children are spread out resulting in them being of type float. When records are processed and the commit counter decreased it may then never reach *exactly* 0. This means records are never commited. This patch makes sure the counter is an integer to avoid the problem. To test you must find a set of circumstances that causes the issue. For me: 1. Run: ./rebuild_elasticsearch -v -b -p 2 -c 400 2. Note that only one process is logging "Committing xxx records..." 3. Kill processes. 4. Apply patch. 5. Repeat 1 6. Note that both processes are logging "Committing xxx records..." Sponsored-by: Lund University Library Signed-off-by: Joonas Kylmälä Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:42:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:42:00 +0000 Subject: [Koha-bugs] [Bug 26996] Elasticsearch: Multiprocess reindexing sometimes doesn't reindex all records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26996 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens --- In testing it did seem as if the records were committed in the end, caught by the final index of remaining records, but very not ideal, especially in a large system -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:45:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:45:33 +0000 Subject: [Koha-bugs] [Bug 27085] Corrections in overdue_notices.pl help text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27085 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:45:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:45:36 +0000 Subject: [Koha-bugs] [Bug 27085] Corrections in overdue_notices.pl help text In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27085 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114442|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 114680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114680&action=edit Bug 27085: Corrections in overdue_notices.pl help text -library only deal with overdues from this library (repeatable : several libraries can be given) Should be Help text should also be proper sentences. To test: 0) Run misc/cronjobs/overdue_notices.pl -h 1) Check that the text is now: -library Only deal with overdues from this library. 2) Check that the rest of the help text are proper sentences, with leading capital letter and punctuation. 3) Sign off. Sponsored-by: Lunds Universitetsbibliotek Signed-off-by: Fridolin Somers Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:52:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:52:23 +0000 Subject: [Koha-bugs] [Bug 25954] Header search forms should be labeled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:52:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:52:26 +0000 Subject: [Koha-bugs] [Bug 25954] Header search forms should be labeled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113747|0 |1 is obsolete| | --- Comment #20 from Nick Clemens --- Created attachment 114681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114681&action=edit Bug 25954: Replace paragraph tags with labels in header search forms This patch replaces instances of

    with

    is kept. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) Test the header search forms on the following pages: - Staff interface home page - Acquisitions home - Acquisitions -> Vendor -> Contracts - Acquisitions -> Vendor -> Add to basket -> From a suggestion - Advanced catalog search - Authorities - Administration - Administration -> Funds - Administration -> Desks (UseCirculationDesks must be enabled) - Administration -> Cities and towns - Administration -> Currencies and exchange rates - Administration -> Patron categories - Administration -> Z39.50/SRU servers - Catalog -> Search results - Cataloging - Circulation - Circulation -> Check in - Patrons - Serials - Tools -> Notices and Slips In each case, check that the search form labels work as expected to move focus to the corresponding form field. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:52:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:52:29 +0000 Subject: [Koha-bugs] [Bug 25954] Header search forms should be labeled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113748|0 |1 is obsolete| | --- Comment #21 from Nick Clemens --- Created attachment 114682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114682&action=edit Bug 25954: (follow-up) Correct label "for" attribute This patch updates a couple of search include forms to change the "for" attribute of the label. Although "idx" is the first field in this situation, the label's text applies to the keyword field so it should give focus to the keyword field. Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:52:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:52:33 +0000 Subject: [Koha-bugs] [Bug 25954] Header search forms should be labeled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25954 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113749|0 |1 is obsolete| | --- Comment #22 from Nick Clemens --- Created attachment 114683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114683&action=edit Bug 25954: (QA follow-up) Correct label "for" attribute in authorities search Change it from first select box to text input for consistancy with other search forms Test plan: 1) Apply the patch 2) Go to authorities search 3) Confirm the labels in all search tabs are linked to text input field Signed-off-by: Josef Moravec Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:52:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:52:38 +0000 Subject: [Koha-bugs] [Bug 25429] Cleanup Database - remove resolved claims returned from db after X days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25429 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Andrew Fuerste-Henry --- After applying this patch, I get the error "unknown option: return-claims" when I run "perl misc/cronjobs/cleanup_database.pl --return-claims 40 --confirm" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:58:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:58:00 +0000 Subject: [Koha-bugs] [Bug 27178] OPAC results and lists pages contain invalid attributes (xmlns:str="http://exslt.org/strings") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27178 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 16:58:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 15:58:02 +0000 Subject: [Koha-bugs] [Bug 27178] OPAC results and lists pages contain invalid attributes (xmlns:str="http://exslt.org/strings") In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27178 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114308|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 114684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114684&action=edit Bug 27178: Add 'str' namespace to exclude-result-prefixes Some nodes in the generated HTML document contain the 'str' namespace. For instance, at the OPAC on the search result list, you can see: The solution is to add 'str' to exclude-result-prefixes. >From https://developer.mozilla.org/en-US/docs/Web/XSLT/Element/stylesheet """ Specifies any namespace used in this document that should not be sent to the output document. The list is whitespace separated. """ Test plan: 0. Don't apply this patch 1. Launch a search at the OPAC 2. Inspect the title link for the records => Note the 'xmlns:str' attribute on tag "a" 3. Apply this patch 4. restart_all 5. Repeat 1. and 2. => Note that the attribute is gone now. QA will check that no other occurrences is missing (note that one NORMARC xsl is missing it, but NORMARC is deprecated) Signed-off-by: Martin Renvoize Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 17:02:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 16:02:27 +0000 Subject: [Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 17:02:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 16:02:30 +0000 Subject: [Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114562|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 114685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114685&action=edit Bug 27282: Add window.onafterprint function TO TEST: -set up a new list with a few items -go to /cgi-bin/koha/virtualshelves/shelves.pl and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and clear cache -Try again, the print dialouge remains open Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 17:02:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 16:02:51 +0000 Subject: [Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens --- I don't recreate, but it works before and after and this makes code consistent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 17:06:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 16:06:56 +0000 Subject: [Koha-bugs] [Bug 27304] New: Show subtitle in Claims tab of patron record Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27304 Bug ID: 27304 Summary: Show subtitle in Claims tab of patron record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We should show the subtitle in the Claims tab on circulation.pl and moremember.pl. Title alone is often insufficient to identify a specific work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 17:25:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 16:25:20 +0000 Subject: [Koha-bugs] [Bug 18861] branch_transfer_limits needs keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64764|0 |1 is obsolete| | --- Comment #7 from Nick Clemens --- Created attachment 114686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114686&action=edit Bug 18861 - branch_transfer_limits needs keys The branch transfers limits are edited in : /cgi-bin/koha/admin/branch_transfer_limits.pl This page calls a loop on IsBranchTransferAllowed with all destination branches and codes (ccodes or itemtypes). This can takes a huge time because table branch_transfer_limits has no keys. Since ccode or itemtype may be used, this patch adds a key on both combinaison : ccode/fromBranch/toBranch and itemtype/fromBranch/toBranch. Tested on a table with 66000 entries, time whent from 26 second to less than 1 second. Test plan : - Go to Administration > Library transfer limits - Check page load is faster - Uncheck a checkbox - Save => Verify save is OK - Change branch and same tests Followed test plan which worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 17:26:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 16:26:16 +0000 Subject: [Koha-bugs] [Bug 18861] branch_transfer_limits needs keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Signed Off |Failed QA --- Comment #8 from Nick Clemens --- I updated the patch, but in testing I didn't see any difference. I added many types and branches: INSERT INTO itemtypes (itemtype,description) SELECT CONCAT(itemtype,"A"),CONCAT(description,"A") FROM itemtypes; INSERT INTO itemtypes (itemtype,description) SELECT CONCAT(itemtype,"B"),CONCAT(description,"B") FROM itemtypes; INSERT INTO itemtypes (itemtype,description) SELECT CONCAT(itemtype,"C"),CONCAT(description,"C") FROM itemtypes; INSERT INTO itemtypes (itemtype,description) SELECT CONCAT(itemtype,"D"),CONCAT(description,"D") FROM itemtypes; INSERT INTO branches (branchcode,branchname,pickup_location) SELECT CONCAT(branchcode,"A"),CONCAT(branchname,"A"),pickup_location FROM branches; INSERT INTO branches (branchcode,branchname,pickup_location) SELECT CONCAT(branchcode,"B"),CONCAT(branchname,"B"),pickup_location FROM branches; INSERT INTO branches (branchcode,branchname,pickup_location) SELECT CONCAT(branchcode,"C"),CONCAT(branchname,"C"),pickup_location FROM branches; INSERT INTO branches (branchcode,branchname,pickup_location) SELECT CONCAT(branchcode,"D"),CONCAT(branchname,"D"),pickup_location FROM branches; Before and after the indexes it took about 30 seconds for the page to load -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 17:58:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 16:58:26 +0000 Subject: [Koha-bugs] [Bug 26397] opac.scss calls non-existent image In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26397 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch removes some release notes| |obsolete CSS from the OPAC | |which calls a non-existent | |image. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 18:45:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 17:45:26 +0000 Subject: [Koha-bugs] [Bug 27305] New: RSS feed for due dates Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305 Bug ID: 27305 Summary: RSS feed for due dates Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nicobako at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl As a user, when I browse the books that I am currently borrowing from the library, I can download the due dates as an ical file. This is wonderful, but it would be really nice to be able to have an RSS feed (a url link) to this calendar. That way I can sync the due dates to my personal calendar, like Gmail, for example. I can add an RSS feed to my personal calendar, and it will automagically populate my personal calendar with the due dates. Thank you in advance! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 19:59:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 18:59:18 +0000 Subject: [Koha-bugs] [Bug 27164] Fix item search CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 19:59:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 18:59:21 +0000 Subject: [Koha-bugs] [Bug 27164] Fix item search CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114315|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry --- Created attachment 114687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114687&action=edit Bug 27164: Fix item search CSV export In item search CSV export, data cells are exported with double quotes. There should also be double quotes in header cells. Also some spaces can be removed. Delimiter must be from system preference 'delimiter'. TT filter must be $raw not html, only double quotes must be espaped by duplication of it. This may help to open the CSV with any table/calc software. Test plan : 1.0) Create a record with title : Laurel & "Hardy" 1.2) Create an item on this record 2.0) Without patch 2.1) Perform an item search on title 'Laurel' 2.2) Export as a CSV file and save the file locally 2.3) Open the file with a table/calc software 3.0) Apply patch 3.1) Perform same item search 3.2) Export as a CSV file and save the file locally 3.3) Open the file with a table/calc software 4.0) Compare files with diff/meld => you see double quotes arround header cells and removal of space after coma 4.1) Check that delimiter is from system preference 'delimiter' 4.2) In table/calc software they should look the same Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 19:59:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 18:59:42 +0000 Subject: [Koha-bugs] [Bug 27164] Fix item search CSV export In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27164 --- Comment #14 from Andrew Fuerste-Henry --- Thanks for clarifying! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 21:19:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 20:19:00 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 21:19:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 20:19:05 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Agustín Moyano changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112744|0 |1 is obsolete| | Attachment #112745|0 |1 is obsolete| | Attachment #112746|0 |1 is obsolete| | Attachment #112747|0 |1 is obsolete| | --- Comment #33 from Agustín Moyano --- Created attachment 114688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114688&action=edit Bug 8179: Add tests This patch adds tests in: * t/db_dependent/Koha/Acquisition/Fund.t * t/db_dependent/Koha/Acquisitoin/Order.t * t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 21:19:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 20:19:10 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #34 from Agustín Moyano --- Created attachment 114689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114689&action=edit Bug 8179: Add syspref to database This patch adds the AcqReceiveMultipleOrderLines syspref by atomicupdate and in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 21:19:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 20:19:14 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #35 from Agustín Moyano --- Created attachment 114690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114690&action=edit Bug 8179: Add AcqReceiveMultipleOrderLines syspref to preference configuration This patch adds AcqReceiveMultipleOrderLines to koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 21:19:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 20:19:20 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #36 from Agustín Moyano --- Created attachment 114691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114691&action=edit Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 21:46:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 20:46:13 +0000 Subject: [Koha-bugs] [Bug 27306] New: add subtitle to return-claims-table Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27306 Bug ID: 27306 Summary: add subtitle to return-claims-table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com For some librarians it would be handy if the claims return table (#return-claims-table) included the subtitle (245b). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 21:46:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 20:46:36 +0000 Subject: [Koha-bugs] [Bug 27306] add subtitle to return-claims-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27306 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 21:52:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 20:52:46 +0000 Subject: [Koha-bugs] [Bug 27306] add subtitle to return-claims-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27306 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 21:52:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 20:52:48 +0000 Subject: [Koha-bugs] [Bug 27306] add subtitle to return-claims-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27306 --- Comment #1 from Lucas Gass --- Created attachment 114692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114692&action=edit Bug 27306: add subtitle to return-claims-table To test: -turn on claim returned -find some items with a 245b or add a 245b to some items -check those items out and mark them as claimed returned -on the borrowers /cgi-bin/koha/circ/circulation.pl page look at the return-claims-table -no subtitle -apply patch and clear browser cache, restart_all -now you should see the subtitle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 21:56:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 20:56:18 +0000 Subject: [Koha-bugs] [Bug 27304] Show subtitle in Claims tab of patron record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27304 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |lucas at bywatersolutions.com Status|NEW |RESOLVED --- Comment #1 from Lucas Gass --- *** This bug has been marked as a duplicate of bug 27306 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 21:56:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 20:56:18 +0000 Subject: [Koha-bugs] [Bug 27306] add subtitle to return-claims-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27306 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #2 from Lucas Gass --- *** Bug 27304 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 23:22:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 22:22:17 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 --- Comment #27 from David Cook --- (In reply to Nick Clemens from comment #26) > (In reply to Jonathan Druart from comment #22) > > Could you provide a test? > > I have tried, but it seems it requires a lot of mocking and I have not been > successful, help would be appreciated :-) Couldn't you add a unit test for AddRenewal that just puts in junk data to trigger the exception? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 23:48:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 22:48:50 +0000 Subject: [Koha-bugs] [Bug 27305] RSS feed for due dates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- I think that you probably mean an iCal feed rather than a RSS feed. It's an interesting idea. I can certainly see the appeal. I haven't implemented something like that myself, but it would have security implications. Google calendar seems to only be able to use URLs with embedded secrets, so it's not very secure. I would say your best bet is to bring it up with your particular library, and then maybe they'll look at getting someone to create the enhancement. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 23:49:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 22:49:07 +0000 Subject: [Koha-bugs] [Bug 27305] iCal feed for circulation issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|RSS feed for due dates |iCal feed for circulation | |issues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 23 23:51:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 22:51:03 +0000 Subject: [Koha-bugs] [Bug 27303] Behaviour depends on DB user permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27303 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- Yikes. Yep. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 00:16:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 23:16:30 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #9 from David Cook --- My test plan: 0. koha-sip --restart kohadev 1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 2. Click "Place hold" 3. koha-shell kohadev 4. perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --item 39999000001310 -l FPL -m checkin 5. Note that SIP emulator does not die and you get the following output: Attempting socket connection to localhost:6001...connected! SEND: 9300CNterm1|COterm1|CPFPL| READ: 941 Trying 'checkin' SEND: 09N20201223 23152620201223 231526APFPL|AOFPL|AB39999000001310|ACterm1|BIN| READ: 101YNY20201223 231526AOFPL|AB39999000001310|AQCPL|AJGairm.|CY42|CTCPL|DAkoha|CRREF|CV02| 6. Go to http://localhost:8081/cgi-bin/koha/members/moremember.pl?borrowernumber=51 7. Note that the hold displays normally as in transit from Fairview 8. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumbers=29/ 9. Note that the hold displays normally as being transferred to Centerville -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 00:19:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 23:19:55 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #10 from David Cook --- prove t/db_dependent/SIP/Transaction.t t/db_dependent/SIP/Transaction.t .. ok All tests successful. Files=1, Tests=11, 5 wallclock secs ( 0.04 usr 0.00 sys + 3.66 cusr 0.40 csys = 4.10 CPU) Result: PASS -- qa -c 2 -v 2 testing 2 commit(s) (applied to 470c760 '69 Bug 26941: Fix OPAC password recov') Processing files before patches |========================>| 2 / 2 (100.00%) Processing files after patches |========================>| 2 / 2 (100.00%) OK C4/SIP/ILS/Transaction/Checkin.pm OK t/db_dependent/SIP/Transaction.t Processing additional checks OK! -- Code review looks good to me. Sensible change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 00:20:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 23:20:52 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 00:20:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 23:20:54 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114622|0 |1 is obsolete| | --- Comment #11 from David Cook --- Created attachment 114693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114693&action=edit Bug 27196: Don't explode if item that is waiting if checked in by SIP Signed-off-by: Nick Clemens Signed-off-by: Victor Grousset/tuxayo Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 00:23:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 23:23:41 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #275 from David Cook --- Ugh, "holds group" is already being used by Bug 22284. That's already confusing me when I read Bugzilla reports... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 00:24:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 23 Dec 2020 23:24:03 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |dcook at prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 01:00:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 00:00:36 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() could be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update header.inc to use |Koha.Preference() could be |Koha plugin for system |used more often in |preferences |header.inc and | |js_includes.inc Severity|enhancement |minor Assignee|oleonard at myacpl.org |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 01:09:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 00:09:18 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() could be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 01:09:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 00:09:21 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() could be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 --- Comment #1 from David Cook --- Created attachment 114694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114694&action=edit Bug 27031: Use Koha.Preference() more often in header.inc and js_includes.inc This patch uses the Koha.Preference() macro more often in key includes. (In the longer term, it will help reduce dependency in problematic C4::Auth code.) Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/mainpage.pl 2. Note "Cart" link in nav bar 3. Click "Cart" and note "Your cart is currently empty" text 4. Click "More" and note "Course Reserves" in dropdown menu 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 6. Click "Select all" above search results 7. Click "Add to cart" 8. Note "Cart" now has 3 displaying next to it 9. Click "Cart" 10. Note there are three titles in the cart 11. Click "Empty and close" and click "OK" to confirm 12. Note "Cart (0)" now appears in the top nav 13. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 14. Save the following content in the system preference:

  3. New Home
    4. 15. Refresh the page 16. Note "New Home" appears in the top nav between "Cart" and "More" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 01:09:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 00:09:43 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() could be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 01:11:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 00:11:01 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha.Preference() could be |Koha.Preference() should be |used more often in |used more often in |header.inc and |header.inc and |js_includes.inc |js_includes.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 01:13:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 00:13:15 +0000 Subject: [Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20582 |27031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 [Bug 20582] Turn Koha into a Mojolicious application https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 01:13:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 00:13:15 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|26791 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 [Bug 26791] Build Mojolicious controller replacement for export.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 01:13:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 00:13:15 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 [Bug 26791] Build Mojolicious controller replacement for export.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 01:45:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 00:45:27 +0000 Subject: [Koha-bugs] [Bug 26791] Build Mojolicious controller replacement for export.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26791 --- Comment #24 from David Cook --- (In reply to David Cook from comment #23) > I'm hoping to look at this more over the holidays. Next steps: 1. Finish Perl coding a. Finish controller code b. Move code out of controller and into modules c. Possibly refactor or add new CSV export code... 2. Write unit tests for modules 3. Final E2E testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 01:45:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 00:45:43 +0000 Subject: [Koha-bugs] [Bug 27305] iCal feed for circulation issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305 --- Comment #2 from Nico Bako --- Thanks for the quick response. Yeah, I definitely mean iCal feed. I had some success trying to come up with a hacky solution. The link to my iCal (via my library account) is: https://catalog.hmcpl.org/cgi-bin/koha/opac-ics.pl I thought that if I set up my iCal feed to be: https://catalog.hmcpl.org/cgi-bin/koha/opac-ics.pl?userid={user-id}&password={password} then it should work... but this only worked as long as I was logged in. Once I logged out that link no longer worked. The CRAZY thing is, this curl command works: curl https://catalog.hmcpl.org/cgi-bin/koha/opac-ics.pl -d 'userid={user-id}&password={password}' No joke, the curl command works! Do you have any other ideas for a hacky way to get the iCal feed to work? I know that my solution has security implications (since my userid and password are part of the url)... but it might be a good workaround for now. I did talk to my library, and they said they weren't aware of an iCal feed feature, but that they would look into it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 02:04:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 01:04:10 +0000 Subject: [Koha-bugs] [Bug 27305] iCal feed for circulation issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305 --- Comment #3 from David Cook --- (In reply to Nico Bako from comment #2) > I had some success trying to come up with a hacky solution. The link to my > iCal (via my library account) is: > > https://catalog.hmcpl.org/cgi-bin/koha/opac-ics.pl > > I thought that if I set up my iCal feed to be: > > https://catalog.hmcpl.org/cgi-bin/koha/opac-ics.pl?userid={user- > id}&password={password} > > then it should work... but this only worked as long as I was logged in. Once > I logged out that link no longer worked. > > The CRAZY thing is, this curl command works: > > curl https://catalog.hmcpl.org/cgi-bin/koha/opac-ics.pl -d > 'userid={user-id}&password={password}' > > No joke, the curl command works! Koha's authentication and authorization code is a pet peeve of mine :p. With the browser, you have already have an anonymous session (indicated by a browser cookie) after logging out, so it's prompting you to sign in again. With cURL, you're not sending a browser cookie, so it accepts your credentials to create a new session. > Do you have any other ideas for a hacky way to get the iCal feed to work? I > know that my solution has security implications (since my userid and > password are part of the url)... but it might be a good workaround for now. > I wouldn't call it a good workaround ;). As you say, including your credentials in a URL is a very bad idea. That said, your hack might work with Google calendar for instance. I wouldn't be surprised if it did. But... I do have plans to prevent userid and password from being sent via query string parameters. Your hack actually gives me more incentive to do that, in fact ;). > I did talk to my library, and they said they weren't aware of an iCal feed > feature, but that they would look into it. Which library is it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 02:11:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 01:11:55 +0000 Subject: [Koha-bugs] [Bug 21325] Should we still allow user and password via GET parameters? In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21325 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #1 from David Cook --- (In reply to Marcel de Rooy from comment #0) > In testing bug 13779, I just noticed that an URL like this works: > > https://[your_domain]/cgi-bin/koha/opac-reserve. > pl?biblionumber=[some_biblionumber]&userid=[your_userid]&password=[your_passw > ord] > > Obviously, we should not expose credentials like that. But it raises the > question: should we allow it then? In my opinion, we 100% should not allow it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 02:12:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 01:12:07 +0000 Subject: [Koha-bugs] [Bug 21325] Prevent authentication when sending userid and password via querystring parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21325 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Should we still allow user |Prevent authentication when |and password via GET |sending userid and password |parameters? |via querystring parameters -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 02:32:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 01:32:21 +0000 Subject: [Koha-bugs] [Bug 21325] Prevent authentication when sending userid and password via querystring parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21325 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 02:32:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 01:32:23 +0000 Subject: [Koha-bugs] [Bug 21325] Prevent authentication when sending userid and password via querystring parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21325 --- Comment #2 from David Cook --- Created attachment 114695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114695&action=edit Bug 21325: Prevent authentication when sending userid and password in querystring This patch permits authentication via userid/password only when the HTTP method is POST when using C4::Auth::checkauth(). The goal is to stop people from supplying userid and password in querystrings in order to log into web pages. Test plan: 0. Do not apply patch yet 1. Open a new browser (ie we don't want any existing CGISESSID cookies available - opening a new tab/window isn't enough. It must be a new instance or you can clear your cookies) 2. Go to http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=29&userid=koha&password=koha 3. Note the user has been logged in and is being asked to confirm hold. 4. Apply the patch 5. Go to http://localhost:8080/cgi-bin/koha/opac-reserve.pl?biblionumber=29&userid=koha&password=koha 6. Note the user is not logged in and the user is presented with a login screen -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 02:44:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 01:44:41 +0000 Subject: [Koha-bugs] [Bug 21325] Prevent authentication when sending userid and password via querystring parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21325 --- Comment #3 from David Cook --- Created attachment 114696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114696&action=edit Bug 21325: Fix t/db_dependent/Auth.t test This patch fixes some warnings in t/db_dependent/Auth.t. Note that it doesn't add any tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 02:46:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 01:46:32 +0000 Subject: [Koha-bugs] [Bug 21325] Prevent authentication when sending userid and password via querystring parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21325 --- Comment #4 from David Cook --- It's a quick and dirty patch, but it works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 03:30:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 02:30:04 +0000 Subject: [Koha-bugs] [Bug 27305] iCal feed for circulation issues In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27305 --- Comment #4 from Nico Bako --- Haha, yeah, sending user name and password as parameters is not a good idea... So far I've tried that url (with user name and password) with Google calendar and it doesn't seem to work. I'm going to try a few more things, and if I figure out something that works I'll definitely let you know. If anything, it might give you even more inspiration for improving the security ;) My library is Huntsville Madison County Public Library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 13:23:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 12:23:25 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 --- Comment #28 from Nick Clemens --- Created attachment 114697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114697&action=edit Bug 26457: Unit test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 13:24:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 12:24:28 +0000 Subject: [Koha-bugs] [Bug 26457] DB DeadLock when renewing checkout items In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26457 --- Comment #29 from Nick Clemens --- (In reply to David Cook from comment #27) > (In reply to Nick Clemens from comment #26) > > (In reply to Jonathan Druart from comment #22) > > > Could you provide a test? > > > > I have tried, but it seems it requires a lot of mocking and I have not been > > successful, help would be appreciated :-) > > Couldn't you add a unit test for AddRenewal that just puts in junk data to > trigger the exception? Indeed I can! Turns out we pass 'lastreneweddate' right through, so adding junk data in the call lets us trigger the exception -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 14:29:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 13:29:58 +0000 Subject: [Koha-bugs] [Bug 27307] New: "Keyword as phrase" option in search dropdown doesn't work with Elastic Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27307 Bug ID: 27307 Summary: "Keyword as phrase" option in search dropdown doesn't work with Elastic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com When using Elastic, selecting "Keyword as phrase" from the search dropdown does not properly perform a phrase search. Other "as phrase" options work correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 14:29:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 13:29:58 +0000 Subject: [Koha-bugs] [Bug 24895] Elasticsearch CCL searching with phr modifier doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24895 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27307 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 14:34:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 13:34:38 +0000 Subject: [Koha-bugs] [Bug 27308] New: Advanced editor should skip blank lines when inserting new fields Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Bug ID: 27308 Summary: Advanced editor should skip blank lines when inserting new fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl The intent of the macro insert new function is to add a new field at the correct numerical place in the record. If you have a blank line while editing, however, the new line will be inserted at the blank line, rather than checking the rest of the record. To recreate: 1 - Create a macro like new 690=‡aLOCAL SUBJECT 2 - Insert a blank line into your record somewhere before where the 690 should be inserted 3 - Run the macro 4 - Line is inserted before the blank line -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 14:37:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 13:37:25 +0000 Subject: [Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 14:37:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 13:37:27 +0000 Subject: [Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 --- Comment #1 from Nick Clemens --- Created attachment 114698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114698&action=edit Bug 27308: Skip blank lines when inserting new The intent of the macro insert new function is to add a new field at the correct numerical place in the record. If you have a blank line while editing, however, the new line will be inserted at the blank line, rather than checking the rest of the record. To test: 1 - Create a macro like new 690=‡aLOCAL SUBJECT 2 - Insert a blank line into your record somewhere before where the 690 should be inserted 3 - Run the macro 4 - Line is inserted before the blank line 5 - Apply patch 6 - Reload (ensure cache is cleared and JS files are reloaded) 7 - Remove the previously created field, but leave the blank 8 - Run the macro 9 - Field is created at correct position -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 14:37:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 13:37:35 +0000 Subject: [Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 14:38:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 13:38:25 +0000 Subject: [Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 15:08:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 14:08:43 +0000 Subject: [Koha-bugs] [Bug 27307] "Keyword as phrase" option in search dropdown doesn't work with Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27307 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 15:08:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 14:08:45 +0000 Subject: [Koha-bugs] [Bug 27307] "Keyword as phrase" option in search dropdown doesn't work with Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27307 --- Comment #1 from Nick Clemens --- Created attachment 114699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114699&action=edit Bug 27307: Unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 15:08:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 14:08:48 +0000 Subject: [Koha-bugs] [Bug 27307] "Keyword as phrase" option in search dropdown doesn't work with Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27307 --- Comment #2 from Nick Clemens --- Created attachment 114700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114700&action=edit Bug 27307: Don't drop phrase directive when searching keyword index We convert 'keyword' to '' as an index since we want it to search all fields When we are searching 'as phrase', however, we should not drop the search type To test: 1 - Enable IntranetCatalogPullDown 2 - Set searchEngine to Elasticsearch 3 - Perform a search for 'Keyword as phrase' for a phrase that does appear in a record 4 - You get the result 5 - Reverse the order of words in the phrase 6 - You still get a result? 7 - Apply patch 8 - Restart all the things 9 - Reversed search does not return record 10 - Correct order and search, correct record returned -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 15:08:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 14:08:53 +0000 Subject: [Koha-bugs] [Bug 27307] "Keyword as phrase" option in search dropdown doesn't work with Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27307 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 15:46:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 14:46:27 +0000 Subject: [Koha-bugs] [Bug 27166] SIP2 Connection is killed when an item that was not issued is checked in and generates a transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27166 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.01,20.05.07 |21.05.00,20.11.01,20.05.07, released in| |19.11.13 --- Comment #14 from Victor Grousset/tuxayo --- My bad, thanks for doing the right check. Backported to 19.11.x branch for 19.11.13 :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 16:33:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 15:33:29 +0000 Subject: [Koha-bugs] [Bug 27307] "Keyword as phrase" option in search dropdown doesn't work with Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27307 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 16:33:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 15:33:31 +0000 Subject: [Koha-bugs] [Bug 27307] "Keyword as phrase" option in search dropdown doesn't work with Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27307 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114699|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 114701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114701&action=edit Bug 27307: Unit test Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 16:33:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 15:33:34 +0000 Subject: [Koha-bugs] [Bug 27307] "Keyword as phrase" option in search dropdown doesn't work with Elastic In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27307 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114700|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 114702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114702&action=edit Bug 27307: Don't drop phrase directive when searching keyword index We convert 'keyword' to '' as an index since we want it to search all fields When we are searching 'as phrase', however, we should not drop the search type To test: 1 - Enable IntranetCatalogPullDown 2 - Set searchEngine to Elasticsearch 3 - Perform a search for 'Keyword as phrase' for a phrase that does appear in a record 4 - You get the result 5 - Reverse the order of words in the phrase 6 - You still get a result? 7 - Apply patch 8 - Restart all the things 9 - Reversed search does not return record 10 - Correct order and search, correct record returned Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 17:06:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 16:06:01 +0000 Subject: [Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 --- Comment #18 from Myka Kennedy Stephens --- (In reply to David Cook from comment #14) > > However, I've been thinking it might be good if we can prevent cataloguing > editor saves if we can't link headings to authorities, or provide a summary > of the linking. The latter would be better for batch imports. > > I mention this here only because interested parties CCed here might have > thoughts... I love this idea, David! It would probably need to be two enhancements. One for individual record saves that would prompt for authorities that would be created or can't be linked if the auto-create permission is turned off. The second would be a summary report of linking, failed links, and newly created authorities for batch imports. Our copy cataloging workflow is a one-at-a-time import via Z39.50, so something that would prompt before the record is saved would probably work better for us. If prompted, the cataloger could go back through the record to manually link any fields that came back with too many search results to link. Please share when you have bug numbers for this and thank you for the idea! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 21:17:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 20:17:36 +0000 Subject: [Koha-bugs] [Bug 27292] TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 21:17:39 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 20:17:39 +0000 Subject: [Koha-bugs] [Bug 27292] TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114660|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 114703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114703&action=edit Bug 27292: Add TablesSettings directive to fix columns_settings_borrowers_table This patch adds the USE TablesSettings directive which allows the plugin to be invoked to fill the columns_settings_borrowers_table variable. Test plan: 0. Do not apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 2. View source on the page and note columns_settings_borrowers_table has no value assigned 2. Apply the patch 3. In a new tab, go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 4. Note that nothing has changed on the surfeace 5. View source ont he page and note columns_settings_borrowers_table now has a value assigned Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 21:29:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 20:29:52 +0000 Subject: [Koha-bugs] [Bug 27108] Update team for 21.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27108 --- Comment #13 from Victor Grousset/tuxayo --- Backporting to 19.11.x: Why do we have IF t.packaging.size / 2 == 1 to condition the part where there is one person ? [% IF t.packaging.size / 2 == 1 %]
  4. Packaging manager: [% INCLUDE person p=t.packaging %]
    5. [% ELSE %]
  5. Packaging team: For the 19.11 cycle, packaging has only one person. Which makes the code go to the ELSE branch and display an empty packaging team. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 21:44:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 20:44:04 +0000 Subject: [Koha-bugs] [Bug 27108] Update team for 21.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27108 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.07 |20.11.00, 20.05.07, released in| |19.11.13 --- Comment #14 from Victor Grousset/tuxayo --- Meanwhile, backported to 19.11.x branch for 19.11.13 as it fixes the whole current team. And checked that teams.yaml about-team.inc are the same as 20.05 and master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 24 21:44:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 24 Dec 2020 20:44:11 +0000 Subject: [Koha-bugs] [Bug 27108] Update team for 21.05 cycle In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27108 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 25 20:27:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Dec 2020 19:27:45 +0000 Subject: [Koha-bugs] [Bug 26956] Allow "Show checkouts/fines to guarantor" to be set without a guarantor saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26956 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114294|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 114704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114704&action=edit Bug 26956: Allow guarantor's controls to be set when a guarantee is created With AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowStaffToSetFinesVisibilityForGuarantor set to Allow, one can only see the controls for these values in the patron record *after* the patron has been saved with a guarantor. That makes a frustrating 2-step process. We should be able to set those values regardless of whether or not there is currently a guarantor on the account. Test plan: Create a guarantee and confirm that the 2 options "Show checkouts to guarantors" and "Show fines to guarantors" are displayed Select Yes, save Confirm that the values have been correctly saved Signed-off-by: Kelly McElligott Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 25 20:33:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Dec 2020 19:33:34 +0000 Subject: [Koha-bugs] [Bug 26956] Allow "Show checkouts/fines to guarantor" to be set without a guarantor saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26956 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #4 from Victor Grousset/tuxayo --- QA script ok, test plan ok, code ok :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Dec 25 21:52:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 25 Dec 2020 20:52:22 +0000 Subject: [Koha-bugs] [Bug 25572] Permissions for Mana Reports are currently linked to Permissions in Serials In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25572 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #6 from Victor Grousset/tuxayo --- Hi, I have a patron with just the catalogue and create_reports permissions. I can't create a report from Mana, when clicking on "import" the button spins infinitely. When refreshing the page, I'm logged out. When giving the create_subscription permission, it works, the form is filled with the SQL of the report. Could I be missing a step? First time using Mana to create a report I think. Services where restarted after applying the patch. Logs look alright: 172.24.0.1 - - [25/Dec/2020:20:32:06 +0000] "POST /intranet/svc/mana/use HTTP/1.1" 200 0 "http://172.24.0.6:8081/cgi-bin/koha/reports/guided_reports.pl?phase=Create%20report%20from%20SQL" "Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101 Firefox/85.0" As for the subscriptions, it works with minimal permissions. BTW was there a simpler way to test with sample than to search the web for the ISSN of a famous newspaper then import (the right one) with Z39.50? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 14:38:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 13:38:21 +0000 Subject: [Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114399|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 114705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114705&action=edit Bug 27230: Display OPAC description for OPAC_SUG The authorised values OPAC_SUG displayed at the OPAC show the staff description. Test plan: 1. Create an auth value in opac_sug, with different text for the description and OPAC description. 2. Go to the OPAC and open the purchase suggestion form. 3. Note in the Reason for purchase drop down, the descriptions appear, the text entered in the OPAC description field. Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 14:38:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 13:38:47 +0000 Subject: [Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |victor at tuxayo.net Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 15:23:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 14:23:25 +0000 Subject: [Koha-bugs] [Bug 27180] Fines cronjob does not update fines on holidays when finesCalendar is set to ignore In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27180 --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 114706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114706&action=edit Bug 27180: (follow-up) Remove unused %is_holiday -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:14:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:14:59 +0000 Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:01 +0000 Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 --- Comment #6 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:03 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:05 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:07 +0000 Subject: [Koha-bugs] [Bug 26956] Allow "Show checkouts/fines to guarantor" to be set without a guarantor saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26956 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:09 +0000 Subject: [Koha-bugs] [Bug 26956] Allow "Show checkouts/fines to guarantor" to be set without a guarantor saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26956 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:12 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:15 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 --- Comment #8 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:17 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:20 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 --- Comment #15 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:23 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:25 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #12 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:27 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:30 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 --- Comment #9 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:32 +0000 Subject: [Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:34 +0000 Subject: [Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:36 +0000 Subject: [Koha-bugs] [Bug 27247] Missing highlighting in Quote of the day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:38 +0000 Subject: [Koha-bugs] [Bug 27247] Missing highlighting in Quote of the day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:40 +0000 Subject: [Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:43 +0000 Subject: [Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:45 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:47 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 --- Comment #5 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:50 +0000 Subject: [Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 18:15:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 17:15:52 +0000 Subject: [Koha-bugs] [Bug 27280] Explanation for "Days mode" is not consistent In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27280 --- Comment #4 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 19:12:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 18:12:41 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20885 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 19:12:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 18:12:41 +0000 Subject: [Koha-bugs] [Bug 20885] Transferring an item on hold results in bypassing restrictions, actually doing the transfer and can be piled up if repeated In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20885 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27064 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Dec 26 23:24:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 26 Dec 2020 22:24:34 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #2 from Victor Grousset/tuxayo --- Anyone else getting a compilation error after applying the patch, restarting the services and going to Circulation->Transfers ? Could not compile /kohadevbox/koha/circ/branchtransfers.pl: Global symbol "$holds" requires explicit package name (did you forget to declare "my $holds"?) at /kohadevbox/koha/circ/branchtransfers.pl line 112. BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/circ/branchtransfers.pl line 246. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 27 17:41:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Dec 2020 16:41:06 +0000 Subject: [Koha-bugs] [Bug 26051] Elasticsearch field local-classification must be sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26051 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107237|0 |1 is obsolete| | --- Comment #2 from Victor Grousset/tuxayo --- Created attachment 114707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114707&action=edit Bug 26051: Elasticsearch field local-classification sort=1 in mapping.yaml With Elasticsearch the search field use for sorting by callnumber is "local-classification" (from Koha::SearchEngine::Elasticsearch::QueryBuilder::_convert_sort_fields). So this search field must be sortable in default mappings.yaml. If not you see this error in logs : No mapping found for [local-classification__sort] Test plan : 1) Install Koha with Elasticsearch with mappings.yaml from sources (admin/searchengine/elasticsearch/mappings.yaml) It should be the case on all developement instalations 2) Reset mappings (Administration › Search engine configuration (Elasticsearch)) 3) Rebuild indexes: misc/search_tools/rebuild_elasticsearch.pl -v -d 4) Perform a search 5) Check sorting by callnumber is OK (add some call numbers if necessary) Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 27 17:41:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Dec 2020 16:41:48 +0000 Subject: [Koha-bugs] [Bug 26051] Elasticsearch field local-classification must be sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26051 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |victor at tuxayo.net --- Comment #3 from Victor Grousset/tuxayo --- Completed a bit the plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 27 18:36:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Dec 2020 17:36:45 +0000 Subject: [Koha-bugs] [Bug 27090] In the location column of an Opac basket the 'In transit from' and 'to' fields are empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 114708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114708&action=edit Bug 26051: Elasticsearch field local-classification sort=1 in mapping.yaml With Elasticsearch the search field use for sorting by callnumber is "local-classification" (from Koha::SearchEngine::Elasticsearch::QueryBuilder::_convert_sort_fields). So this search field must be sortable in default mappings.yaml. If not you see this error in logs : No mapping found for [local-classification__sort] Test plan : 1) Install Koha with Elasticsearch with mappings.yaml from sources (admin/searchengine/elasticsearch/mappings.yaml) It should be the case on all developement instalations 2) Reset mappings (Administration › Search engine configuration (Elasticsearch)) 3) Rebuild indexes: misc/search_tools/rebuild_elasticsearch.pl -v -d 4) Perform a search 5) Check sorting by callnumber is OK (add some call numbers if necessary) Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 27 18:36:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Dec 2020 17:36:48 +0000 Subject: [Koha-bugs] [Bug 27090] In the location column of an Opac basket the 'In transit from' and 'to' fields are empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 114709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114709&action=edit Bug 27090: Opac basket: fix the 'In transit from' and 'to' To see the 'In transit from' and 'to' fields in an Opac basket we have : In transit from [% Branches.GetName( item.transfertfrom ) | html %] to [% Branches.GetName( item.transfertto ) | html %] since [% item.transfertwhen | $KohaDates %] But in koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc we have no : [% USE Branches %] This patch just corrects this lack Test plan: 1° find an item in a transit status or create one with this status 2° put it in an Opac basket 3° note that in the location column of the Opac basket the 'In transit from' and 'to' fields are empty. 4° apply the patch 5° check again and validate that the 2 fields are now filled Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 27 18:37:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Dec 2020 17:37:15 +0000 Subject: [Koha-bugs] [Bug 27090] In the location column of an Opac basket the 'In transit from' and 'to' fields are empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113971|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 27 18:37:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Dec 2020 17:37:57 +0000 Subject: [Koha-bugs] [Bug 27090] In the location column of an Opac basket the 'In transit from' and 'to' fields are empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Attachment #114708|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 27 18:42:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Dec 2020 17:42:06 +0000 Subject: [Koha-bugs] [Bug 27090] In the location column of an Opac basket the 'In transit from' and 'to' fields are empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27090 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Victor Grousset/tuxayo --- Oops, attached an additional patch that was from another ticket. Thanks, it works as expected :) Fixed the commit message to include the description of the fix and test plan. (I just copied comment 1 and comment 2) And made the first line of the commit message shorter to be in git recommendations (70 chars max) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 27 19:50:06 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Dec 2020 18:50:06 +0000 Subject: [Koha-bugs] [Bug 26417] Remove warn in Koha::Patron is_valid_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26417 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109790|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 114710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114710&action=edit Bug 26417: Remove warn in Koha::Patron is_valid_age In Koha::Patron is_valid_age the is a compare : $age < $low But $low may be undef. It generates a warn : Use of uninitialized value $low in numeric lt (<) Needs a test like for $high. Test plan : 1) Run prove t/db_dependent/Koha/Patrons.t 2) Edit a patron catetory, empty "Age required" and save 3) Edit a patron of this category 4) Check in logs you don't see "Use of uninitialized value $low in numeric lt (<)" Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 27 19:50:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Dec 2020 18:50:22 +0000 Subject: [Koha-bugs] [Bug 26417] Remove warn in Koha::Patron is_valid_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26417 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Dec 27 19:52:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Dec 2020 18:52:00 +0000 Subject: [Koha-bugs] [Bug 26417] Remove warn in Koha::Patron is_valid_age In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26417 --- Comment #5 from Victor Grousset/tuxayo --- Note: no warning in the tests before the patch. Only when using the UI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 00:03:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Dec 2020 23:03:45 +0000 Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112933|0 |1 is obsolete| | --- Comment #14 from Victor Grousset/tuxayo --- Created attachment 114711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114711&action=edit Bug 24541: Purge old messages misc/cronjobs/cleanup_database.pl provides some database cleanup. This patch adds cleanup for messages table. Test plan : - Count messages : select count(*),date(message_date) from messages group by date(message_date); - Run cleanup : misc/cronjobs/cleanup_database.pl -v --confirm --messages 365 - Recount messages Signed-off-by: Séverine QUEUNE Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 00:03:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 27 Dec 2020 23:03:57 +0000 Subject: [Koha-bugs] [Bug 24541] Database cleanups, purge messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24541 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA --- Comment #15 from Victor Grousset/tuxayo --- Works as expected, QA script ok, code ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 12:55:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 11:55:23 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #31 from Magnus Enger --- Relevat code: C4/SIP/ILS/Patron.pm: 476 =head2 update_lastseen 477 478 $patron->update_lastseen(); 479 480 Patron method to update lastseen field in borrower 481 to record that patron has been seen via sip connection 482 483 =cut 484 485 sub update_lastseen { 486 my $self = shift; 487 my $kohaobj = Koha::Patrons->find( $self->{borrowernumber} ); 488 $kohaobj->track_login if $kohaobj; # track_login checks the pref 489 } Koha/Patron.pm: 910 =head3 track_login 911 912 $patron->track_login; 913 $patron->track_login({ force => 1 }); 914 915 Tracks a (successful) login attempt. 916 The preference TrackLastPatronActivity must be enabled. Or you 917 should pass the force parameter. 918 919 =cut 920 921 sub track_login { 922 my ( $self, $params ) = @_; 923 return if 924 !$params->{force} && 925 !C4::Context->preference('TrackLastPatronActivity'); 926 $self->lastseen( dt_from_string() )->store; 927 } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 13:13:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 12:13:28 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113877|0 |1 is obsolete| | --- Comment #3 from Nick Clemens --- Created attachment 114712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114712&action=edit Bug 27064: Only allow transferring a hold from the transfers page These patches replace the 'Waiting' button on the transfers page with a 'Transfer' button and correct some other related problem by passing the hold object to the template and using that to fetch patron info as well as passing the reserve_id through to ensure the correct hold is affected at all times To test: 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found (missing patron/branch info) 6 - You have the option to set the hold waiting - click it 7 - The transfer is generated and marked completed 8 - The hold is marked as waiting, but the item is still at Library A and no transfer is active 9 - The patron is notified that the hold is waiting 10 - Revert the hold or cancel and place a new one 11 - Apply patches 12 - Attempt transfer again 13 - You now have the option to transfer the hold 14 - Click that 15 - Hold is in transit and transfer is generated correctly 16 - Transfer again and choose 'cancel' 17 - Confirm hold is cancelled and transfer generated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:05:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:05:02 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25189 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:05:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:05:02 +0000 Subject: [Koha-bugs] [Bug 25189] AutoCreateAuthorities can repeatedly generate authority records when using Default linker In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11299 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:09:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:09:24 +0000 Subject: [Koha-bugs] [Bug 26268] Remove items.paid for once and for all In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26268 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:21:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:21:42 +0000 Subject: [Koha-bugs] [Bug 27309] New: Add plugin hooks for capturing raw passwords (NNPDB) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27309 Bug ID: 27309 Summary: Add plugin hooks for capturing raw passwords (NNPDB) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org Bug 22706 tried to add hooks to make it possible to implement support for the Norwegian National Patron Database (NNPDB) via a plugin. That bug added a new hook called check_password, and this was called in two places: 1. In Koha::Patron::set_password https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/Patron.pm#L774 2. In Koha::Patron::store https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/Patron.pm#L167 The second call to check_password was initially placed after this call: $self = $self->SUPER::store; so we could send both the raw password and the borrowernumber to the hook. This is of course a problem, since checking the password after the borrower has been stored means we can't reject the user completely based on the password. And so the call to the check_password hook was placed bwfore this line. This meant that the check_password hook could not serve the intended purpose of implementing the NNPDB. This bug proposes a new plugin hook, to be implemented after the ->store, to finally make it possible to implement NNPDB as a plugin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:25:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:25:31 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:34:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:34:47 +0000 Subject: [Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | --- Comment #19 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:36:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:36:44 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:40:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:40:18 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:43:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:43:25 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | --- Comment #15 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:46:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:46:36 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:48:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:48:28 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:52:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:52:00 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 14:53:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 13:53:42 +0000 Subject: [Koha-bugs] [Bug 26849] Fix Array::Utils dependency in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 15:22:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 14:22:27 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 --- Comment #4 from Victor Grousset/tuxayo --- > 16 - Transfer again and choose 'cancel' I go back to the "Reserve found" page with the 3 options. I'm trapped there if I only click 'cancel' ^^" And the hold is not canceled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 15:34:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 14:34:56 +0000 Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 15:36:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 14:36:57 +0000 Subject: [Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 15:39:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 14:39:37 +0000 Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #23 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 15:42:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 14:42:24 +0000 Subject: [Koha-bugs] [Bug 26634] Hold rules applied incorrectly when All Libraries rules are more specific than branch rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26634 --- Comment #20 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05.x, please rebase for backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 15:46:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 14:46:17 +0000 Subject: [Koha-bugs] [Bug 27124] JS error "select2Width is not defined" In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27124 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #19 from Andrew Fuerste-Henry --- Missing dependencies, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 15:52:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 14:52:57 +0000 Subject: [Koha-bugs] [Bug 18861] branch_transfer_limits needs keys In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18861 --- Comment #9 from Fridolin Somers --- (In reply to Nick Clemens from comment #8) > I updated the patch, but in testing I didn't see any difference. > > I added many types and branches: > INSERT INTO itemtypes (itemtype,description) SELECT > CONCAT(itemtype,"A"),CONCAT(description,"A") FROM itemtypes; > INSERT INTO itemtypes (itemtype,description) SELECT > CONCAT(itemtype,"B"),CONCAT(description,"B") FROM itemtypes; > INSERT INTO itemtypes (itemtype,description) SELECT > CONCAT(itemtype,"C"),CONCAT(description,"C") FROM itemtypes; > INSERT INTO itemtypes (itemtype,description) SELECT > CONCAT(itemtype,"D"),CONCAT(description,"D") FROM itemtypes; > INSERT INTO branches (branchcode,branchname,pickup_location) SELECT > CONCAT(branchcode,"A"),CONCAT(branchname,"A"),pickup_location FROM branches; > INSERT INTO branches (branchcode,branchname,pickup_location) SELECT > CONCAT(branchcode,"B"),CONCAT(branchname,"B"),pickup_location FROM branches; > INSERT INTO branches (branchcode,branchname,pickup_location) SELECT > CONCAT(branchcode,"C"),CONCAT(branchname,"C"),pickup_location FROM branches; > INSERT INTO branches (branchcode,branchname,pickup_location) SELECT > CONCAT(branchcode,"D"),CONCAT(branchname,"D"),pickup_location FROM branches; > > Before and after the indexes it took about 30 seconds for the page to load How many entries do you have in table branch_transfer_limits ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 15:55:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 14:55:52 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 15:58:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 14:58:16 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 15:58:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 14:58:49 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 16:00:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 15:00:37 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #44 from Victor Grousset/tuxayo --- Created attachment 114713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114713&action=edit Bug 17809: FR installer: fix duplicate authorised value qualif 370 Monteur vs Réalisateur -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 16:02:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 15:02:12 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 16:05:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 15:05:33 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #13 from Fridolin Somers --- Patch removes a # in C4/SIP/ILS/Transaction/Checkin.pm : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114693&action=diff#a/C4/SIP/ILS/Transaction/Checkin.pm_sec1 Is this on purpose ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 16:05:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 15:05:58 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Failed QA |Needs Signoff --- Comment #45 from Victor Grousset/tuxayo --- With those patches, reset_all_unimarc finishes without errors in koha-testing-docker :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 16:06:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 15:06:12 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | --- Comment #16 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 16:19:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 15:19:30 +0000 Subject: [Koha-bugs] [Bug 26921] Create cover image even when there is no record identificator In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26921 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05, please rebase if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 16:27:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 15:27:25 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 16:31:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 15:31:11 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry --- Missing dependencies, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 16:33:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 15:33:43 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #14 from Nick Clemens --- (In reply to Fridolin Somers from comment #13) > Patch removes a # in C4/SIP/ILS/Transaction/Checkin.pm : > > https://bugs.koha-community.org/bugzilla3/attachment. > cgi?id=114693&action=diff#a/C4/SIP/ILS/Transaction/Checkin.pm_sec1 > > Is this on purpose ? It was not, but shouldn't hurt anything -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 16:33:44 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 15:33:44 +0000 Subject: [Koha-bugs] [Bug 26849] Fix Array::Utils dependency in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 18:35:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 17:35:25 +0000 Subject: [Koha-bugs] [Bug 26875] Allow printing of just one barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26875 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112973|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 114714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114714&action=edit Bug 26875: Allow printing of just one barcode in batch To test: 1- go to the Print Barcode Range page 2- enter From=1 and To=1 3- confirm error "Must be greater than from value." 4- apply patch, restart, reload page 5- enter From=1, To=1 6- confirm no error 7- change From to 2, error reappears Signed-off-by: David Nind Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 18:36:31 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 17:36:31 +0000 Subject: [Koha-bugs] [Bug 26875] Allow printing of just one barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26875 --- Comment #4 from Victor Grousset/tuxayo --- Created attachment 114715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114715&action=edit Bug 26875: (follow-up) Fix error message ("greater or equal") Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 18:37:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 17:37:01 +0000 Subject: [Koha-bugs] [Bug 26875] Allow printing of just one barcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26875 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 19:27:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 18:27:55 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #16 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 19:27:55 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 18:27:55 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Bug 18729 depends on bug 27209, which changed state. Bug 27209 Summary: Add Koha::Hold->set_pickup_location https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 19:27:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 18:27:56 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Bug 27205 depends on bug 27209, which changed state. Bug 27209 Summary: Add Koha::Hold->set_pickup_location https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 19:42:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 18:42:11 +0000 Subject: [Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209 --- Comment #17 from Victor Grousset/tuxayo --- Tried to backport to 19.11.x it because it's the dependency of a major bug (bug 27205) but the tests don't pass. Help needed here in order to backport bug 27205. kohadev-koha at 6a2e5bab0d87:/kohadevbox/koha$ prove t/db_dependent/Koha/Hold.t t/db_dependent/Koha/Hold.t .. # No tests run! t/db_dependent/Koha/Hold.t .. 1/3 # Failed test 'No tests run for subtest "patron() tests"' # at t/db_dependent/Koha/Hold.t line 55. The method Koha::Hold->patron is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 661 Koha::Object::AUTOLOAD('Koha::Hold=HASH(0x556f6652aa00)') called at t/db_dependent/Koha/Hold.t line 50 main::__ANON__ at /usr/share/perl5/Test/Builder.pm line 310 eval {...} at /usr/share/perl5/Test/Builder.pm line 310 Test::Builder::subtest('Test::Builder=HASH(0x556f5d6558b0)', 'patron() tests', 'CODE(0x556f5d5c2918)') called at /usr/share/perl5/Test/More.pm line 807 Test::More::subtest('patron() tests', 'CODE(0x556f5d5c2918)') called at t/db_dependent/Koha/Hold.t line 55 # Looks like your test exited with 255 just after 1. t/db_dependent/Koha/Hold.t .. Dubious, test returned 255 (wstat 65280, 0xff00) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 19:45:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 18:45:33 +0000 Subject: [Koha-bugs] [Bug 27205] Hold routes are not dealing with invalid pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #17 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, can't backport. Send help to bug 27209 if you need this one in 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 19:45:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 18:45:34 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Bug 18729 depends on bug 27205, which changed state. Bug 27205 Summary: Hold routes are not dealing with invalid pickup locations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27205 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 19:57:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 18:57:41 +0000 Subject: [Koha-bugs] [Bug 27117] Staff without modify_holds_priority permission can't update hold pick-up from biblio In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |victor at tuxayo.net Status|Pushed to oldstable |RESOLVED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 19:57:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 18:57:42 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Bug 18729 depends on bug 27117, which changed state. Bug 27117 Summary: Staff without modify_holds_priority permission can't update hold pick-up from biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 19:57:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 18:57:42 +0000 Subject: [Koha-bugs] [Bug 27201] New permission to modify pickup locations In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27201 Bug 27201 depends on bug 27117, which changed state. Bug 27117 Summary: Staff without modify_holds_priority permission can't update hold pick-up from biblio https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27117 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 20:04:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 19:04:45 +0000 Subject: [Koha-bugs] [Bug 26849] Fix Array::Utils dependency in cpanfile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26849 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, can't backport. cpanfile doesn't exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 21:49:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 20:49:17 +0000 Subject: [Koha-bugs] [Bug 26123] Show info about existing OPAC note/Patron message on patron's dashboard In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26123 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #21 from Victor Grousset/tuxayo --- IIUC the dashboard will mention the messages until the opac note is cleared and/or the old messages are purged by bug 24541 for example. That's ok right? Even if it looks like a "new messages" feature, it's consistent with the patron page that will display them all, old or new. So it won't add much confusion. Other opinions on that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 22:25:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 21:25:13 +0000 Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |andrew at bywatersolutions.com Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | --- Comment #8 from Andrew Fuerste-Henry --- pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 22:27:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 21:27:48 +0000 Subject: [Koha-bugs] [Bug 26941] Missing OPAC password recovery error messages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26941 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #12 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05. Please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 22:36:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 21:36:17 +0000 Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #24 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 22:37:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 21:37:07 +0000 Subject: [Koha-bugs] [Bug 27148] Internal Server Error during self registration 20.11 In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27148 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #17 from Andrew Fuerste-Henry --- Missing dependencies, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 22:43:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 21:43:25 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01,20.05.07 released in| | --- Comment #7 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Dec 28 22:55:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 28 Dec 2020 21:55:52 +0000 Subject: [Koha-bugs] [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #10 from Andrew Fuerste-Henry --- This applies to 20.05.x and appears to work ok, but I'm getting the following error from the QA tools: "Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/opac-tmpl/bootstrap/en/includes/html_helpers.inc line 23." Not backporting, but let me know if needed and I'll chase someone to fix the error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 11:43:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 10:43:47 +0000 Subject: [Koha-bugs] [Bug 26957] Find duplicate removes operators from the middle of search terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26957 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 11:43:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 10:43:50 +0000 Subject: [Koha-bugs] [Bug 26957] Find duplicate removes operators from the middle of search terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26957 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113935|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers --- Created attachment 114716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114716&action=edit Bug 26957: Don't remove words that are also operators from search terms FindDuplicate has a hardcoded regex to remove 'and', 'or', and 'not' from any search fields, however, is does this with no regard for these terms being embedded in the middle of a word or phrase. E.g.: 'Coupland' becomes 'Coupl' 'Frog and toad' becomes 'frog toad' etc. This patch simplay removes the substitutions as we already quote the terms as well To test: 1 - Add records to your system like: The night circus by Erin Morgenstern Frog and toad all year Nothing ever happens 2 - Attempt to add purchase suggestions like title: the night circus, author:Morgenstern, Erin title: For and toad all year title:nothing ever happens (case is important) 3 - No warnings about existing biblios 4 - Apply patches 5 - Delete existing suggestions 6 - Repeat step 2 7 - Each attempt should warn you of existing biblio Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 11:46:07 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 10:46:07 +0000 Subject: [Koha-bugs] [Bug 26957] Find duplicate removes operators from the middle of search terms In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26957 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Whaou what an ugly bug ^^. I confirm finding duplicate works even with title containing operators like 'and'. For example 'War and'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 11:46:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 10:46:23 +0000 Subject: [Koha-bugs] [Bug 27064] Transferring an item with a hold allows the user to set a hold waiting without transferring to the correct branch In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27064 Emmi Takkinen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen at koha-suomi.fi --- Comment #5 from Emmi Takkinen --- (In reply to Victor Grousset/tuxayo from comment #4) > > 16 - Transfer again and choose 'cancel' > > I go back to the "Reserve found" page with the 3 options. > I'm trapped there if I only click 'cancel' ^^" > > And the hold is not canceled. Can confirm this happening, transfer is generated but hold isn't cancelled. It seems reserve_id is not send as query parameter when 'Cancel' is clicked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 11:54:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 10:54:45 +0000 Subject: [Koha-bugs] [Bug 27310] New: Wrong CSS float on 'Visibility' in framework edition Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 Bug ID: 27310 Summary: Wrong CSS float on 'Visibility' in framework edition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In administration > framework edition > subfield edition, 'Visibility' label as a CSS rule float none. This seems obsolete, removing it will align label like others. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 11:54:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 10:54:51 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 11:56:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 10:56:35 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 --- Comment #1 from Fridolin Somers --- Created attachment 114717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114717&action=edit Screenshot without patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 11:58:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 10:58:54 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 11:59:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 10:59:58 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:00:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:00:01 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 --- Comment #2 from Fridolin Somers --- Created attachment 114718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114718&action=edit Bug 27310: Remove CSS float on 'Visibility' in framework edition In administration > framework edition > subfield edition, 'Visibility' label as a CSS rule float none. This seems obsolete, removing it will align label like others. Test plan : 1) Go to Administration 2) Edit any framework 3) Edit any subfield 4) Look at 'Visibility' => Without patch label is sticked to the left => With patch label postion is like others -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:01:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:01:15 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |/cgi-bin/koha/admin/marc_su | |bfields_structure.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:03:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:03:30 +0000 Subject: [Koha-bugs] [Bug 27309] Add plugin hooks for capturing raw passwords (NNPDB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27309 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:03:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:03:33 +0000 Subject: [Koha-bugs] [Bug 27309] Add plugin hooks for capturing raw passwords (NNPDB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27309 --- Comment #1 from Magnus Enger --- Created attachment 114719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114719&action=edit Bug 27309 - Add plugin hooks for capturing passwords This might sound like a stupid idea, but it is necessary in order to implement support for the Norwegian National Patron Database as a plugin in Koha. The plugin hook captures the borrowernumber and raw password of a user and sends it to a plugin. I created a tiny plugin to be able to test the functionality: https://github.com/Libriotech/koha-plugin-capturepw This plugin will capture borrowernumbers and raw passwords when a user is added or updated. The borrowernumber and a md5-hashed version of the password is stored in a tiny database table (koha_plugin_no_libriotech_capturepw_capturepw) created by the plugin. To test: - Enable plugins - Install the CapturePW plugin - Add and edit users in all possible ways, including -- Setting a password for a new user -- Changing a password in the staff client -- Changing a password in the OPAC -- Creating a disabled user account Check the database table for updates after each operation. If a new line is added to the database for each operation, and the md5 hash changes when a password is changed, everything should be ok. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:04:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:04:11 +0000 Subject: [Koha-bugs] [Bug 27309] Add plugin hooks for capturing raw passwords (NNPDB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27309 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22706 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:04:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:04:11 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to allow custom password strength checking modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27309 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:22:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:22:19 +0000 Subject: [Koha-bugs] [Bug 27309] Add plugin hooks for capturing raw passwords (NNPDB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27309 --- Comment #2 from Magnus Enger --- Added capture_raw_password to https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks#Implemented_or_under_development_hooks -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:25:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:25:45 +0000 Subject: [Koha-bugs] [Bug 27311] New: Don't pass borrowernumber to check_password plugin hook Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27311 Bug ID: 27311 Summary: Don't pass borrowernumber to check_password plugin hook Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org check_password is implemented in two places: 1. In Koha::Patron::set_password https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/Patron.pm#L774 2. In Koha::Patron::store https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koha/Patron.pm#L167 The call to the plugin inside Koha::Patron::store comes before this line: $self = $self->SUPER::store; which means there is not yet a borrowernumber to pass to the plugin, and this never worked. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:26:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:26:01 +0000 Subject: [Koha-bugs] [Bug 27311] Don't pass borrowernumber to check_password plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27311 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27309 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:26:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:26:01 +0000 Subject: [Koha-bugs] [Bug 27309] Add plugin hooks for capturing raw passwords (NNPDB) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27309 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27311 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:26:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:26:26 +0000 Subject: [Koha-bugs] [Bug 27311] Don't pass borrowernumber to check_password plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27311 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22706 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 [Bug 22706] Add plugin hooks to allow custom password strength checking modules -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:26:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:26:26 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to allow custom password strength checking modules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27311 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27311 [Bug 27311] Don't pass borrowernumber to check_password plugin hook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:39:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:39:21 +0000 Subject: [Koha-bugs] [Bug 17429] Document the --plack option for koha-list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17429 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos at dataly.gr Status|NEW |ASSIGNED Assignee|magnus at libriotech.no |a.roussos at dataly.gr --- Comment #1 from Andreas Roussos --- I've emailed Magnus about this Bug, and he graciously agreed to let me assign this to myself and also re-use his test plan from Bug 10622. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:41:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:41:33 +0000 Subject: [Koha-bugs] [Bug 17429] Document the --plack option for koha-list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17429 Andreas Roussos changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:41:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:41:35 +0000 Subject: [Koha-bugs] [Bug 17429] Document the --plack option for koha-list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17429 --- Comment #2 from Andreas Roussos --- Created attachment 114720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114720&action=edit Bug 17429: document the --plack/--noplack options of koha-list The man page of koha-list does not list the --plack and --noplack options. This patch fixes that. Test plan: 1) View the current man page for `koha-list` (with `man koha-list`) and notice how the --plack and --noplack options are missing. 2) Apply this patch. 3) Run the following command to re-generate the man page: xsltproc /usr/share/xml/docbook/stylesheet/docbook-xsl/manpages/docbook.xsl \ debian/docs/koha-list.xml View the manual page again (with `man -l koha-list.8`), the two options are now displayed under SYNOPSIS and OPTIONS. 4) Make sure this test passes: prove -v xt/verify-debian-docbook.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:44:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:44:54 +0000 Subject: [Koha-bugs] [Bug 27311] Don't pass borrowernumber to check_password plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27311 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 12:44:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 11:44:57 +0000 Subject: [Koha-bugs] [Bug 27311] Don't pass borrowernumber to check_password plugin hook In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27311 --- Comment #1 from Magnus Enger --- Created attachment 114721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114721&action=edit Bug 27311 - Don't pass borrowernumber to check_password Bug 22706 added the check_password plugin hook, taking both a borrowernumber and the raw password as arguments. The hook is called in two places in Koha::Patron, but because of how the code that calls the hook is placed, passing borrowernumber to the plugin inside "sub store" never worked. This patch removes the passing of the borrowernumber from both calls. A tiny plugin that uses the check_password hooks can ve found here: https://github.com/Libriotech/koha-plugin-pin To test: - Enable plugins - Optionally install the PIN plugin - Add and edit users in all possible ways, including -- Setting a password for a new user -- Changing a password in the staff client -- Changing a password in the OPAC -- Creating a disabled user account Sign off, if all this works as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 13:31:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 12:31:26 +0000 Subject: [Koha-bugs] [Bug 27312] New: Add a syspref to redirect patron after self registration Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27312 Bug ID: 27312 Summary: Add a syspref to redirect patron after self registration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org We need to implement a workflow that looks like this: 1. A new patron self registers in the OPAC, with a temporary category code, including providing a social security number 2. After the data is saved, the patron is redirected to a Script (similar to opac/svc/auth/googleopenidconnect, but provided by a plugin) 3. The script redirects the patron again, to an OpenID provider, where (s)he has to login in a secure manner 4. After logging in, the user is redirected back to the Script, and the Script can tell what the correct social security number of the patron is 5. If the social security number provided by the OpenID provider matches one of a temporary patron, that patron is updated to a permanent patron We need to be able to set the URL that the user should be redirected to in step 2 above. This could be done in a couple of ways: 1. As a syspref This would be fairly simple. The syspref holds the URL and if it is set, the user is redirected at the right place in opac/opac-memberentry.pl 2. As a plugin hook The first plugin hook of the right type called would provide the URL and, if there is a URL, the patron is redirected. One advantage of the plugin hook approach is that the information about where to redirect the user would be contained in the same plugin that provides the Script. But a plugin hook does seem like a bit of overkill for providing a single, static URL. And I guess the plugin could set the syspref, if it wanted to, so I will submit a patch that uses a syspref. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 13:56:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 12:56:25 +0000 Subject: [Koha-bugs] [Bug 27313] New: bulkmarcimport.pl -d foreign key constraint fails Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27313 Bug ID: 27313 Summary: bulkmarcimport.pl -d foreign key constraint fails Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: davewood at gmx.at QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz 11:41 < cait1> hm can you file a bug report please? 11:41 < cait1> we have tightened some things in the db, this might be a side effect 11:41 < cait1> but basically... you have issues 11:41 < cait1> Ausleihen 11:41 < cait1> so it's correct in failing 11:41 < cait1> if you truncate the issues first this is probably going to work better 11:42 < cait1> the script is not supposed to be used once you have loaded other transactional data atm 11:42 < cait1> for the same data... perl /usr/share/koha/bin/migration_tools/bulkmarcimport.pl -d -m=*MARCXML* -file test.marc.xml deleting biblios DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_libelle`.`issues`, CONSTRAINT `issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON UPDATE CASCADE) [for Statement "DELETE FROM biblio"] at /usr/share/koha/bin/migration_tools/bulkmarcimport.pl line 174. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_libelle`.`issues`, CONSTRAINT `issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON UPDATE CASCADE) [for Statement "DELETE FROM biblioitems"] at /usr/share/koha/bin/migration_tools/bulkmarcimport.pl line 176. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_libelle`.`issues`, CONSTRAINT `issues_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON UPDATE CASCADE) [for Statement "DELETE FROM items"] at /usr/share/koha/bin/migration_tools/bulkmarcimport.pl line 178. .DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1588, line 2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 14:07:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 13:07:32 +0000 Subject: [Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Attachment #112393|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 14:08:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 13:08:45 +0000 Subject: [Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112970|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo --- Created attachment 114722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114722&action=edit Bug 24863: QueryFuzzy syspref says it requires Zebra but ElasticSearch has some support. This patch updates the description of the QueryFuzzy system preference to make it more clear how it works with Zebra and how Elasticsearch has some amount of fuzzy available for searches. To test: 1. Go to administration 2. Search for QueryFuzzy 3. Observe the current description, which only includes Zebra. 4. Apply patch 5. Repeat steps 1-2 6. Observe the updated description. 7. Sign off Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 14:09:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 13:09:43 +0000 Subject: [Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114722|0 |1 is obsolete| | --- Comment #9 from Victor Grousset/tuxayo --- Created attachment 114723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114723&action=edit Bug 24863: QueryFuzzy syspref says it requires Zebra but ElasticSearch has some support. This patch updates the description of the QueryFuzzy system preference to make it more clear how it works with Zebra and how Elasticsearch has some amount of fuzzy available for searches. To test: 1. Go to administration 2. Search for QueryFuzzy 3. Observe the current description, which only includes Zebra. 4. Apply patch 5. Repeat steps 1-2 6. Observe the updated description. 7. Sign off Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Fridolin Somers Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 14:10:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 13:10:23 +0000 Subject: [Koha-bugs] [Bug 24863] QueryFuzzy syspref says it requires Zebra but Elasticsearch has some support In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24863 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Signed Off |Passed QA --- Comment #10 from Victor Grousset/tuxayo --- Thanks Fridolin for the proof reading :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 14:15:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 13:15:10 +0000 Subject: [Koha-bugs] [Bug 27313] bulkmarcimport.pl -d foreign key constraint fails when entries in issues exist In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27313 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|bulkmarcimport.pl -d |bulkmarcimport.pl -d |foreign key constraint |foreign key constraint |fails |fails when entries in | |issues exist -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 14:40:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 13:40:58 +0000 Subject: [Koha-bugs] [Bug 27312] Add a syspref to redirect patron after self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27312 --- Comment #1 from Magnus Enger --- Created attachment 114724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114724&action=edit Bug 27312 - Add a syspref to redirect patron after self registration We have an authentication workflow that requires redirecting the patron to a URL or path after successfull self registration. See Bugzilla for further details. This patch adds a syspref that takes a full URL or local path, and if this is set, a patron will be redirected after completing the self registration in the OPAC. To test: - Apply this patch, including running the atomic database update - Enable PatronSelfRegistration and set a patron category in PatronSelfRegistrationDefaultCategory - Do a self registration in the OPAC and check it works as expeced - Fill inn a complete URL in RedirectURLAfterPatronSelfReg - Do a new self registration in the OPAC and note that you are redirected to the URL you entered - Check in the staff client that the patron was registered as expected, before being redirected - Sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 14:41:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 13:41:28 +0000 Subject: [Koha-bugs] [Bug 27312] Add a syspref to redirect patron after self registration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27312 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 16:12:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 15:12:28 +0000 Subject: [Koha-bugs] [Bug 27314] New: Update default Elastic mapping Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27314 Bug ID: 27314 Summary: Update default Elastic mapping Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: nick at bywatersolutions.com Reporter: andrew at bywatersolutions.com As we've been bringing libraries online with Elastic searching, we've run into a handful of changes to the default mappings. I'm filing this bug to remind us to push some of those back into the community defaults. I'll circle back here with details of changes we've made. Anyone else have changes they'd like to see in the community ES mappings? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 16:14:30 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 15:14:30 +0000 Subject: [Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 16:14:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 15:14:33 +0000 Subject: [Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114584|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 16:18:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 15:18:45 +0000 Subject: [Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 114725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114725&action=edit Bug 27055: Fix compatibility with newer Firefox+Selenium version Fix "submit is not a function error" A submit button should not be named "submit", in this case, it's id. https://stackoverflow.com/questions/833032/submit-is-not-a-function-error-in-javascript Fix some uses of get_attribute() Fix a fail by setting a global implicit_wait_timeout, default value is 0 in our lib. Other libs set it higher which helps to not have to manually deal with part of the timing issues. Fix: remove usage of click_when_visible() because it doesn't work with elements not in the top of the page. Because they are off screen. Fix: use $driver->quit() in error_handler to not forget an open Firefox. With the current version, it fills /dev/shm and fails with around 5 Firefox opened. Also use quit() it at the end of every script. Fix: filling item fields, to fill only the displayed one (not those with display:none) == Test plan == 1. Update selenium/standalone-firefox to the latest version [1] 2. prove t/db_dependent/selenium/authentication.t 3. It fails with: arguments[0].form.submit is not a function 4. Apply patch 5. Retest 6. Success [1] In koha-testing-docker you can do it with docker-compose.yml: selenium: - image: selenium/standalone-firefox:2.53.1-americium + image: selenium/standalone-firefox Signed-off-by: Mason James Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 16:20:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 15:20:18 +0000 Subject: [Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | --- Comment #15 from Tomás Cohen Arazi --- I tested this with the latest selenium-firefox image. It works after the patch is applied. The changes are sensible. Specially the submit id change. And how things got adjusted makes sense. QA script is happy as well. Well done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 16:22:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 15:22:57 +0000 Subject: [Koha-bugs] [Bug 27068] HoldsQueue doesn't know how to use holds groups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27068 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |agustinmoyano at theke.io -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 16:23:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 15:23:50 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net --- Comment #42 from Victor Grousset/tuxayo --- Can't QA this one but got a question about -holidays, why is it better to not take them into account by default? I don't have much functional experience so I might miss something obvious ^^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 16:29:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 15:29:13 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #43 from Andrew Fuerste-Henry --- The various sysprefs that determine whether or not to consult the calendar for various tasks are inconsistent in a new install -- some are on and some are off. However, ExcludeHolidaysFromMaxPickUpDelay defaults to off. That's not exactly the same as the --holiday flag here, but seems close enough that I'm happy to make this new feature keep the same default choice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 17:07:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 16:07:20 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 --- Comment #5 from Victor Grousset/tuxayo --- Created attachment 114726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114726&action=edit Bug 26847: Add UI test for categorycode in masthead This test adds a regression test for the addition of categorycode into the masthead of the staff client. Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 17:07:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 16:07:24 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113013|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo --- Created attachment 114727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114727&action=edit Bug 26847: Add data-categorycode to opac pages This patch adds the data-categorycode attribute to the loggedinuser span for all pages in the opac. Test plan 1/ Apply first patch, varify unit test fails. 2/ Apply second patch, varify unit test now passes. 3/ Navigate to opac and login 4/ Varify that data-categorycode is present in the loggedinuser span in the client. Signed-off-by: Lucas Gass Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 17:09:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 16:09:45 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch QA Contact|testopia at bugs.koha-communit |victor at tuxayo.net |y.org | Status|Signed Off |Passed QA CC| |victor at tuxayo.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 17:13:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 16:13:59 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify search like in the OPAC (advanced search) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 17:14:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 16:14:01 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify search like in the OPAC (advanced search) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #2 from Nick Clemens --- Created attachment 114728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114728&action=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Library limits can be applied multiple times either as 'AND' option, or using groups for 'OR' 2 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 3 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 17:15:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 16:15:24 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17170 CC| |andrew at bywatersolutions.com | |, | |nick at bywatersolutions.com, | |oleonard at myacpl.org Summary|Adding the option to modify |Adding the option to |search like in the OPAC |modify/edit searches on the |(advanced search) |staff client Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 17:15:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 16:15:24 +0000 Subject: [Koha-bugs] [Bug 17170] Add the ability to create 'saved searches' for use as filters when searching the catalog In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17170 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22605 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 [Bug 22605] Adding the option to modify/edit searches on the staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 17:36:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 16:36:19 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #36 from Martin Renvoize --- Created attachment 114729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114729&action=edit Bug 11983: Centralised Koha::Patrons method OPTION 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 17:37:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 16:37:13 +0000 Subject: [Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76701|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 114730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114730&action=edit Bug 11983: Centralised Koha::Patrons method OPTION 2 https://bugs.koha-community.org/show_bug.cgi?id=11982 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 17:37:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 16:37:40 +0000 Subject: [Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #114729|0 |1 is obsolete| | Attachment #114729|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 17:39:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 16:39:00 +0000 Subject: [Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114730|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 114731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114731&action=edit Bug 11983: Centralised Koha::Patrons method OPTION 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 17:40:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 16:40:27 +0000 Subject: [Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #15 from Martin Renvoize --- Rebased OPTION 2 as it seemed to be the one we landed on.. I can't for the life of me get rid of that last HAVING in the amountsoutstanding.. I think this is ready for review again at this point.. running the included tests should be enough for SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 18:04:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 17:04:17 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Andrew Fuerste-Henry --- I'm running into problems: - apply patch - restart all - go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl - search title: Street, get results (http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=ti&q=street&idx=kw&q=&idx=kw&q=&sort_by=relevance) - click Edit Search - go to page where my title is not shown in the search form but does appear in the url? (http://localhost:8081/cgi-bin/koha/catalogue/search.pl?advsearch=1&idx=ti&q=street&idx=kw&q=&idx=kw&q=&sort_by=relevance) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 18:13:42 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 17:13:42 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #4 from Andrew Fuerste-Henry --- Additionally, the more I think about this the more I dislike adding this new wrinkle of and/or multi-branch searching as sort of an afterthought to this feature. I'd be happier to see that split into a separate bug, in hopes of it getting more eyes and feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 18:41:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 17:41:41 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 18:41:45 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 17:41:45 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114573|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 18:42:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 17:42:20 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 --- Comment #10 from Tomás Cohen Arazi --- Created attachment 114732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114732&action=edit Bug 27004: Regression tests This patch introduces regression tests for the change in Koha::Checkouts::ReturnClaim->store. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Checkouts/ReturnClaim.t => FAIL: Tests fail Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 18:42:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 17:42:28 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 --- Comment #11 from Tomás Cohen Arazi --- Created attachment 114733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114733&action=edit Bug 27004: Prevent claim resolution to fail If the account of the patron who created a claim is removed, then the claim won't be resolvable. Trying to resolve the claim will result in a 500: [2020/12/21 10:05:55] [ERROR] PUT /api/v1/return_claims/1/resolve: unhandled exception (Koha::Exceptions::Checkouts::ReturnClaims::NoCreatedBy)<<[created_by is mandatory]>> Koha::REST::Plugin::Exceptions::__ANON We should not check if created_by exist when we update an existing hold, only when we create it. Test plan: - Login with patron A - set a value to syspref ClaimReturnedLostValue - Check an item out - Claim returned it - Login with patron B - Delete patron A - Resolve the claim - ERROR in api-error.log an UI never confirming the resolution - apply patch & restart services - Resolve the claim - it works Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 18:47:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 17:47:13 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114728|0 |1 is obsolete| | --- Comment #5 from Nick Clemens --- Created attachment 114734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114734&action=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Library limits can be applied multiple times either as 'AND' option, or using groups for 'OR' 2 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 3 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 18:47:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 17:47:34 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 18:56:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 17:56:02 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Daniel Gaghan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan at pueblolibrary | |.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 19:00:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 18:00:04 +0000 Subject: [Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114731|0 |1 is obsolete| | --- Comment #16 from Victor Grousset/tuxayo --- Created attachment 114735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114735&action=edit Bug 11983: Centralised Koha::Patrons method OPTION 2 == Test plan == prove t/db_dependent/Koha/Patrons.t Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 19:01:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 18:01:02 +0000 Subject: [Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized (use of filter_by) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 19:02:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 18:02:11 +0000 Subject: [Koha-bugs] [Bug 27004] Deleting a staff account who have created claims returned causes problem in the return_claims table because of a NULL value in return_claims.created_by. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27004 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 20:11:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 19:11:33 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 20:11:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 19:11:36 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify/edit searches on the staff client In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114734|0 |1 is obsolete| | --- Comment #6 from Kelly McElligott --- Created attachment 114736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114736&action=edit Bug 22605: Add ability to edit a search on staff interface This patch adds the ability to parse the current search and populate the advanced search page on the staff side accordingly. When searching you will now have an 'Edit this search' link underneath your current search terms A few notes: 1 - Library limits can be applied multiple times either as 'AND' option, or using groups for 'OR' 2 - Previous selected items appear with a checkbox, unchecking 'disables' them and removes from the search 3 - Facets and unrecognized limits will appear at the end of the form under 'Other limits' - there could be future enhancement to parse there better, but I believe this is sufficient for now To test: 1 - Perform a variety of search on the staff interface 2 - Confirm the 'edit search' button appear below your search 3 - Confirm that options are retained and correctly parsed 4 - Test with library groups - you should be able to combine groups after initial search, or remove individual libraries when editing 5 - Test that selecting a goup disables the individual libraries options QA note: Missing filters on deletion of keys form hash are false positives Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 20:37:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 19:37:10 +0000 Subject: [Koha-bugs] [Bug 26847] Make borrower category code accessible in all pages of the OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26847 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113012|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo --- Comment on attachment 113012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113012 Bug 26847: Add unit test for categorycode in masthead Fixed test terminology in the commit message "unit test" => "UI test" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 21:09:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 20:09:41 +0000 Subject: [Koha-bugs] [Bug 27152] Add a batch/bulk renewal endpoint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27152 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |tomascohen at gmail.com CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 22:08:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 21:08:34 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #44 from Victor Grousset/tuxayo --- > The various sysprefs that determine whether or not to consult the calendar for various tasks are inconsistent in a new install :o > However, ExcludeHolidaysFromMaxPickUpDelay defaults to off. That's not exactly the same as the --holiday flag here, but seems close enough that I'm happy to make this new feature keep the same default choice. Thanks for the analysis. Is there an obviously less surprising default choice there? Or does it depend too much? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 22:21:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 21:21:29 +0000 Subject: [Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986 --- Comment #45 from Andrew Fuerste-Henry --- I don't really get the sense one option is more standard or more likely to be correct for any given library -- it's just one of those things one ends up asking every new library about. Same with UseDaysMode, finesCalendar, OverdueNoticeCalendar, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Dec 29 22:49:59 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 21:49:59 +0000 Subject: [Koha-bugs] [Bug 27306] add subtitle to return-claims-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27306 Rebecca Coert changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert at arlingtonva.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 00:26:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 23:26:01 +0000 Subject: [Koha-bugs] [Bug 15933] Add cataloguing plugin to search for existing publishers in other records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15933 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 00:29:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 23:29:51 +0000 Subject: [Koha-bugs] [Bug 27297] When itemtype is marked as required in OpacSuggestion MandatoryFields the field is not required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 00:29:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 23:29:54 +0000 Subject: [Koha-bugs] [Bug 27297] When itemtype is marked as required in OpacSuggestion MandatoryFields the field is not required In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27297 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114620|0 |1 is obsolete| | --- Comment #2 from Kelly McElligott --- Created attachment 114737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114737&action=edit Bug 27297: Add required and blank options to av-build-dropbox.inc This patch adds two options to av-build-drobx required - which will add the required attribute to the select blank - which will add a blank option to avoid preselecting others To test: 1 - In OpacSuggestionMandatoryFeilds select itemtype 2 - Go to OPAC 3 - Add a suggestion 4 - Don't fill out any fields 5 - Submit 6 - Suggestion is added 7 - Delete it 8 - Apply patch 9 - Add a suggestion 10 - Note itemtyp edefaults to 'None' 11 - You cannot submit until you select a value Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 00:41:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 23:41:12 +0000 Subject: [Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 00:41:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 23:41:15 +0000 Subject: [Koha-bugs] [Bug 18989] Allow displaying biblios with all items hidden by OpacHiddenItems In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109657|0 |1 is obsolete| | --- Comment #10 from Kelly McElligott --- Created attachment 114738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114738&action=edit Bug 18989: add atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 00:48:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 23:48:35 +0000 Subject: [Koha-bugs] [Bug 27306] add subtitle to return-claims-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27306 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 00:48:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 23:48:38 +0000 Subject: [Koha-bugs] [Bug 27306] add subtitle to return-claims-table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27306 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114692|0 |1 is obsolete| | --- Comment #3 from Kelly McElligott --- Created attachment 114739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114739&action=edit Bug 27306: add subtitle to return-claims-table To test: -turn on claim returned -find some items with a 245b or add a 245b to some items -check those items out and mark them as claimed returned -on the borrowers /cgi-bin/koha/circ/circulation.pl page look at the return-claims-table -no subtitle -apply patch and clear browser cache, restart_all -now you should see the subtitle Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 00:54:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 23:54:40 +0000 Subject: [Koha-bugs] [Bug 26630] Allow custom text for each library on Purchase Suggestion Page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 00:54:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 29 Dec 2020 23:54:43 +0000 Subject: [Koha-bugs] [Bug 26630] Allow custom text for each library on Purchase Suggestion Page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26630 Kelly McElligott changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113795|0 |1 is obsolete| | --- Comment #3 from Kelly McElligott --- Created attachment 114740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114740&action=edit Bug 26630: Add OpacSuggestionInstructions options to News Test plan: 1. Apply patch 2. Go to /cgi-bin/koha/tools/koha-news.pl and create 'New entry' with a dsiplay location of OpacSuggestionInstructions 3. Login to the OPAC and go to the purchase suggestion page (/cgi-bin/koha/opac-suggestions.pl) 4. Your new content should be there. 5. Delete the OpacSuggestionInstructions news entry. 6. Re-load the OPAC purchase suggestion page and the original text will be restored. Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 08:40:17 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 07:40:17 +0000 Subject: [Koha-bugs] [Bug 27315] New: The man pages for the command line utilities do not display properly Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27315 Bug ID: 27315 Summary: The man pages for the command line utilities do not display properly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: a.roussos at dataly.gr QA Contact: testopia at bugs.koha-community.org Created attachment 114741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114741&action=edit problem with koha-list man page When viewing the man page for the `koha-list` command, the output does not appear correctly: there appears to be a "staircase" like effect on the text. The same is true for all other man pages, actually. Oddly enough, on an older Koha install of mine (19.11.03) the man page for `koha-list` displays fine. I attach a screenshot which displays the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 09:48:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 08:48:43 +0000 Subject: [Koha-bugs] [Bug 27314] Update default Elastic mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27314 Joonas Kylmälä changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 09:55:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 08:55:50 +0000 Subject: [Koha-bugs] [Bug 27314] Update default Elastic mapping In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27314 --- Comment #1 from Katrin Fischer --- +1 I'd love to see good defaults for the libraries just starting out with Elasticseach! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 10:09:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 09:09:38 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 10:09:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 09:09:41 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114718|0 |1 is obsolete| | --- Comment #3 from David Nind --- Created attachment 114742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114742&action=edit Bug 27310: Remove CSS float on 'Visibility' in framework edition In administration > framework edition > subfield edition, 'Visibility' label as a CSS rule float none. This seems obsolete, removing it will align label like others. Test plan : 1) Go to Administration 2) Edit any framework 3) Edit any subfield 4) Look at 'Visibility' => Without patch label is sticked to the left => With patch label postion is like others Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 10:11:15 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 09:11:15 +0000 Subject: [Koha-bugs] [Bug 27310] Wrong CSS float on 'Visibility' in framework edition In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27310 David Nind changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #4 from David Nind --- Tested on Ubuntu 18.04 with Google Chrome, Firefox and Firefox Developer Edition. With the patch applied the Visibility are aligns nicely like all the other options. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 14:30:24 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 13:30:24 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #106 from Fridolin Somers --- OK for QA ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 14:33:14 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 13:33:14 +0000 Subject: [Koha-bugs] [Bug 27316] New: In mappings use yes/no for sortable Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Bug ID: 27316 Summary: In mappings use yes/no for sortable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com In search engine configuration (Elasticsearch), there is a colum 'sortable'. It contains 'Undef', 0 or 1. 0 and 1 are not really friendly values for a boolean. And also the translation seems to replace 0 by empty string (seen in fr-FR translation). I propose to replace by Yes/No like other boolean. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 14:33:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 13:33:23 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 14:39:23 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 13:39:23 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 14:39:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 13:39:25 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 --- Comment #1 from Fridolin Somers --- Created attachment 114743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114743&action=edit Bug 27316: In Elasticsearch mappings use yes/no for sortable In search engine configuration (Elasticsearch), there is a colum 'sortable'. It contains 'Undef', 0 or 1. 0 and 1 are not really friendly values for a boolean. And also the translation seems to replace 0 by empty string (seen in fr-FR translation). I propose to replace by Yes/No like other boolean. Test plan : 1) Without patch, look at Administration > Search engine configuration (Elasticsearch) 2) Look at tab 'Bibliographic records' 3) Look at a row containing 0 and a row containing 1 4) Apply patch 5) Refresh page 6) Check 0 is now 'No' and 1 is now 'Yes' 7) Check creating a new row with 'Yes' or 'No' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 14:40:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 13:40:12 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20588 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 14:40:12 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 13:40:12 +0000 Subject: [Koha-bugs] [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27316 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 14:49:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 13:49:50 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 --- Comment #15 from Fridolin Somers --- (In reply to Nick Clemens from comment #14) > (In reply to Fridolin Somers from comment #13) > > Patch removes a # in C4/SIP/ILS/Transaction/Checkin.pm : > > > > https://bugs.koha-community.org/bugzilla3/attachment. > > cgi?id=114693&action=diff#a/C4/SIP/ILS/Transaction/Checkin.pm_sec1 > > > > Is this on purpose ? > > It was not, but shouldn't hurt anything OK no pb. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:06:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:06:29 +0000 Subject: [Koha-bugs] [Bug 27317] New: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Bug ID: 27317 Summary: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 27127 changed Koha::BackgroundJob->messages to return arrayref instead of array. This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on : not ok 10 - 10 messages generated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:06:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:06:37 +0000 Subject: [Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27127 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 [Bug 27127] Wrong display of messages if there was only 1 record modified -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:06:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:06:37 +0000 Subject: [Koha-bugs] [Bug 27127] Wrong display of messages if there was only 1 record modified In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27127 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:06:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:06:49 +0000 Subject: [Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|chris at bigballofwax.co.nz |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:07:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:07:57 +0000 Subject: [Koha-bugs] [Bug 24519] Change calculation and validation in Point of Sale should match Paycollect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor at tuxayo.net --- Comment #9 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:07:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:07:58 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Bug 13985 depends on bug 24519, which changed state. Bug 24519 Summary: Change calculation and validation in Point of Sale should match Paycollect https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24519 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:09:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:09:25 +0000 Subject: [Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:09:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:09:28 +0000 Subject: [Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 --- Comment #1 from Fridolin Somers --- Created attachment 114744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114744&action=edit Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t Bug 27127 changed Koha::BackgroundJob->messages to return arrayref instead of array. This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on : not ok 10 - 10 messages generated Test plan : prove t/db_dependent/Koha/BackgroundJobs.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:16:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:16:19 +0000 Subject: [Koha-bugs] [Bug 27196] Waiting title level hold checked in at wrong location via SIP leaves hold in a broken state and drops connection In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27196 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:20:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:20:26 +0000 Subject: [Koha-bugs] [Bug 27200] "Browse search" is broken In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27200 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:30:29 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:30:29 +0000 Subject: [Koha-bugs] [Bug 14564] Incorrect permissions prevent web download of configuration backups In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14564 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|21.05.00,20.11.01,20.05.07 |21.05.00,20.11.01,20.05.07, released in| |19.11.13 --- Comment #25 from Victor Grousset/tuxayo --- Backported to 19.11.x branch for 19.11.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:31:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:31:19 +0000 Subject: [Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:31:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:31:22 +0000 Subject: [Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114744|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:36:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:36:20 +0000 Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin Somers --- Not sure this was the best way to fix. There are only a few places with 'html_entity' filter. Other places use double-quotes for JS strings and html TT filter replaces double-quotes with " -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:36:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:36:52 +0000 Subject: [Koha-bugs] [Bug 22243] Advanced Cataloguer editor fails if the target contains an apostrophe in the name In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22243 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:39:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:39:10 +0000 Subject: [Koha-bugs] [Bug 26956] Allow "Show checkouts/fines to guarantor" to be set without a guarantor saved In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26956 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:39:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:39:58 +0000 Subject: [Koha-bugs] [Bug 27230] purchase suggestion authorized value opac_sug doesn't show opac description In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27230 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:41:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:41:38 +0000 Subject: [Koha-bugs] [Bug 27247] Missing highlighting in Quote of the day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27247 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:43:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:43:04 +0000 Subject: [Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 114745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114745&action=edit Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t Bug 27127 changed Koha::BackgroundJob->messages to return arrayref instead of array. This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on : not ok 10 - 10 messages generated Test plan : prove t/db_dependent/Koha/BackgroundJobs.t Signed-off-by: Tomas Cohen Arazi Edit: I fixed the indentation of the test label. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:46:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:46:03 +0000 Subject: [Koha-bugs] [Bug 27099] Stage for import button not showing up In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27099 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:47:41 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:47:41 +0000 Subject: [Koha-bugs] [Bug 27250] DELETE calls are stacked on the SMTP servers admin page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27250 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|21.05.00 |21.05.00,20.11.01 released in| | --- Comment #6 from Fridolin Somers --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:52:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:52:21 +0000 Subject: [Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114745|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo --- Created attachment 114746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114746&action=edit Bug 27317: (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t Bug 27127 changed Koha::BackgroundJob->messages to return arrayref instead of array. This impacts Unit Test t/db_dependent/Koha/BackgroundJobs.t failling on : not ok 10 - 10 messages generated Test plan : prove t/db_dependent/Koha/BackgroundJobs.t Signed-off-by: Tomas Cohen Arazi Edit: I fixed the indentation of the test label. Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 15:52:32 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 14:52:32 +0000 Subject: [Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:06:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:06:37 +0000 Subject: [Koha-bugs] [Bug 27055] Update Firefox version used in Selenium GUI tests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27055 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master --- Comment #16 from Tomás Cohen Arazi --- Pushed, to end the year with happy Jenkins. Thanks everyone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:07:05 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:07:05 +0000 Subject: [Koha-bugs] [Bug 27317] (Bug 27127 follow-up) fix t/db_dependent/Koha/BackgroundJobs.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27317 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master --- Comment #4 from Tomás Cohen Arazi --- Pushed, to end the year with happy Jenkins. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:21:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:21:54 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114670|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 114747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114747&action=edit Bug 27290: Update 'type=number' to 'type=text inputmode=numeric' This patch updates the inputs for the pay form on the point of sale page to use numeric inputmode. This appears to also fix the validation issue described in the bug report. To test: 1 - Enable 'useCashRegisters' and 'EnablePointofSale' 2 - Add a cash register 3 - Add a debit type that can be sold 4 - Go to point of sale and sell the item multiple times 5 - Enter 'Amount tendered' less than amount being paid 6 - Click confirm 7 - Transaction is processed as if full funds received 8 - Try with a negative number - goes through again Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:21:57 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:21:57 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114671|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 114748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114748&action=edit Bug 27290: (follow-up) fix filters - make register required Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:22:00 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:22:00 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #8 from Martin Renvoize --- Created attachment 114749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114749&action=edit Bug 27290: Clean up validation It seems we had the validator instantiated twice and we used a mix of validation of required at form element level and in JS instantiator. This patch moves the rules to consistently apply at the instantiation and removes the duplicate lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:24:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:24:16 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #9 from Martin Renvoize --- OK, reading the followup highlighted some further issues.. I think during a rebase somewhere we ended up with duplication of code blocks causing random issues. I've cleaned up the duplication in the final patch. I'm not entirely sure we need the 'on_editing' option added to the $Price filter of the readonly field, but I may be wrong there.. I not Nick you added it back in so I'm happy to defer.. not sure it makes much difference in this case. So.. all in all.. back to NQA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:30:22 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:30:22 +0000 Subject: [Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 --- Comment #4 from Fridolin Somers --- For me its ok, works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:31:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:31:10 +0000 Subject: [Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:31:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:31:13 +0000 Subject: [Koha-bugs] [Bug 27245] bulkmarcimport.pl error 'Already in a transaction' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27245 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114521|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers --- Created attachment 114750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114750&action=edit Bug 27245: Replace AutoCommit=0 with txn_begin in bulkmarcimport.pl To prevent DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1588, line 1. Test plan: Export more than 100 records Use bulkmarcimport (with -commit=10) to import them Modify a record to make the import fail (for instance having a too long lccn) Use bulkmarcimport (with -commit=10) to import them Notice that the import stops but that the imported record are imported (a part from the last batch of 10) Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:35:35 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:35:35 +0000 Subject: [Koha-bugs] [Bug 18017] Use index_heading and index_match_heading in UNIMARC authorities zebra configuration In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18017 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alex.arnaud at biblibre.com |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:39:33 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:39:33 +0000 Subject: [Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin Somers --- Great :D Maybe we need some CSS on excluded fields name, grey color for example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:40:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:40:36 +0000 Subject: [Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:40:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:40:40 +0000 Subject: [Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114483|0 |1 is obsolete| | --- Comment #3 from Fridolin Somers --- Created attachment 114751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114751&action=edit Bug 27261: exlude branchcode from PatronSelfRegistrationBorrowerUnwantedField To test: 1 - Alter PatronSelfRegistrationBorrowerUnwantedFieldand select branchcode 2 - Attempt to self register via the OPAC 3 - Kabloom, internal server error 4 - Apply patche 5 - Alter the preference again 6 - Note that branchcode is unchecked and disabled 7 - Save the pref 8 - Attempt to self register again 9 - It succeeds Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 16:43:47 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 15:43:47 +0000 Subject: [Koha-bugs] [Bug 17485] Add Marc modification templates to z39.50 import In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17485 Holly changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 17:12:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 16:12:16 +0000 Subject: [Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Needs Signoff |Failed QA --- Comment #5 from Fridolin Somers --- Bug 20145 removed preference 'UseKohaPlugins', please remove it from your patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 17:13:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 16:13:20 +0000 Subject: [Koha-bugs] [Bug 24589] Add plugin hook addbiblio_check_record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24589 --- Comment #6 from Fridolin Somers --- Bug 20415 removed preference 'UseKohaPlugins', please remove it from your patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 17:16:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 16:16:49 +0000 Subject: [Koha-bugs] [Bug 25306] Unnecessary update of framework in ModBiblioMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25306 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Fridolin Somers --- Sorry does not apply on current master. I get : Applying: Bug 25306: Remove framework paramter from ModBiblioMarc error: sha1 information is lacking or useless (C4/Biblio.pm). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 17:30:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 16:30:04 +0000 Subject: [Koha-bugs] [Bug 23295] Automatically debar patrons if SMS or email notice fail In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23295 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #9 from Fridolin Somers --- Nice work. I just wonder about get_failed_notices() method in Koha/Notice/Message.pm. It does not use current object. And why using SQL and not the ORM ? Also : Koha::Notice::Message::restrict_patron_when_notice_fails($failed_notice); This is strange. Method restrict_patron_when_notice_fails() should be called on a Koha::Notice::Message object instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 21:31:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 20:31:28 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #2 from Lucas Gass --- much more user friendly, thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 21:32:18 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 20:32:18 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 21:32:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 20:32:20 +0000 Subject: [Koha-bugs] [Bug 27316] In mappings use yes/no for sortable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27316 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114743|0 |1 is obsolete| | --- Comment #3 from Lucas Gass --- Created attachment 114752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114752&action=edit Bug 27316: In Elasticsearch mappings use yes/no for sortable In search engine configuration (Elasticsearch), there is a colum 'sortable'. It contains 'Undef', 0 or 1. 0 and 1 are not really friendly values for a boolean. And also the translation seems to replace 0 by empty string (seen in fr-FR translation). I propose to replace by Yes/No like other boolean. Test plan : 1) Without patch, look at Administration > Search engine configuration (Elasticsearch) 2) Look at tab 'Bibliographic records' 3) Look at a row containing 0 and a row containing 1 4) Apply patch 5) Refresh page 6) Check 0 is now 'No' and 1 is now 'Yes' 7) Check creating a new row with 'Yes' or 'No' Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 21:42:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 20:42:25 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114694|0 |1 is obsolete| | --- Comment #2 from Lucas Gass --- Created attachment 114753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114753&action=edit Bug 27031: Use Koha.Preference() more often in header.inc and js_includes.inc This patch uses the Koha.Preference() macro more often in key includes. (In the longer term, it will help reduce dependency in problematic C4::Auth code.) Test plan: 0. Apply patch 1. Go to http://localhost:8081/cgi-bin/koha/mainpage.pl 2. Note "Cart" link in nav bar 3. Click "Cart" and note "Your cart is currently empty" text 4. Click "More" and note "Course Reserves" in dropdown menu 5. Go to http://localhost:8081/cgi-bin/koha/catalogue/search.pl?q=test 6. Click "Select all" above search results 7. Click "Add to cart" 8. Note "Cart" now has 3 displaying next to it 9. Click "Cart" 10. Note there are three titles in the cart 11. Click "Empty and close" and click "OK" to confirm 12. Note "Cart (0)" now appears in the top nav 13. Go to http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav 14. Save the following content in the system preference:
  6. New Home
    7. 15. Refresh the page 16. Note "New Home" appears in the top nav between "Cart" and "More" Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 21:42:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 20:42:56 +0000 Subject: [Koha-bugs] [Bug 27031] Koha.Preference() should be used more often in header.inc and js_includes.inc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27031 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 21:52:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 20:52:09 +0000 Subject: [Koha-bugs] [Bug 12044] Checkout should not be possible if a patron's fines will block the transaction In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12044 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #3 from Andrew Fuerste-Henry --- +1, this is confusing. Currently in master: If AllowFineOverride is off, then all staff see a message of "Checkouts are BLOCKED because fine balance is OVER THE LIMIT" when looking at the checkout tab of a patron over the fines limit. The behavior is great! If AllowFineOverride is on, then all staff see the checkout box when looking at the checkout tab of a patron over the fines limit. When a staff member who has force_checkout permission attempts a checkout, Koha gives a confirmation message "Please confirm checkout The patron has a debt of XXX" and the user picks Yes or no. When a staff member who does not have force_checkout permission attempts a checkout, the checkout fails and the staff member gets a message of "Cannot check out The patron has a debt of XXX." If AllowFineOverride is on and the staff member does not have force_checkout permission, I think we should show them the same "Checkouts are BLOCKED because fine balance is OVER THE LIMIT" as when the syspref is off. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 22:50:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 21:50:36 +0000 Subject: [Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 22:50:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 21:50:40 +0000 Subject: [Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104520|0 |1 is obsolete| | --- Comment #11 from Lucas Gass --- Created attachment 114754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114754&action=edit Bug 25405: clearly define local login and shib login sections This patch attempts to clearly seperate local login from shibboleth login in the OPAC loginModal. It includes seperate id's for local and shibboleth to make it easier to customize this login To test: 1. Enable shibboleth in your koha-conf.xml by changng the value of to 1. 2. I also add the following to my koha-conf: email 3. Look at the loginModal in the OPAC by clicking 'Log in to your account' in the top right corner. 4. Apply patch, restart all, and regenerate CSS. (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) 5. Look at the loginModal again the shibboleth section should be underneath the local login stuff. 6. Inscept the loginModal and make sure there is a
    for both local_login and shibboleth_login 7. Make sure it all works. 8. Turn Shibboleth back off and restart all. 9. Make sure everything still works and looks good without Shibboleth off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 22:58:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 21:58:46 +0000 Subject: [Koha-bugs] [Bug 27318] New: make shibboleth instructions customizable in the loginModal Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Bug ID: 27318 Summary: make shibboleth instructions customizable in the loginModal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If you enable shibboleth for sign on in the OPAC and go to the loginModal the instructions say "If you have a Shibboleth account, please click here to login." That language is confusing to most users who don't know what shibboleth is. This area should be editable via the News Tool so librarians can add their own language here. I have moved some things in the loginModal in Bug 25405 and this would build upon that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Dec 30 22:58:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 21:58:58 +0000 Subject: [Koha-bugs] [Bug 27318] make shibboleth instructions customizable in the loginModal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 00:04:04 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 23:04:04 +0000 Subject: [Koha-bugs] [Bug 27318] make shibboleth instructions customizable in the loginModal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 --- Comment #1 from Lucas Gass --- Created attachment 114755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114755&action=edit Bug 27318: Add ShibbolethLoginInstructions to News This patch adds ShibbolethLoginInstructions as an option in the News Tool so librarians customize the wording within the loginModal To test: 1. Enable shibboleth in your koha-conf.xml by changng the value of to 1. 2. I also add the following to my koha-conf: email 3. Look at the OPAC loginModal and make sure something like "If you have a Shibboleth account, please click here to login." is visiible. 4. Apply patch 5. Go to /cgi-bin/koha/tools/koha-news.pl and make a New entry 6. Choose ShibbolethLoginInstructions and enter something like: '

    Sign in using:

    Google
    ' 7. Reload the OPAC and look at the loginModal again, it should show your new login instructions instead of the default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 00:04:01 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 23:04:01 +0000 Subject: [Koha-bugs] [Bug 27318] make shibboleth instructions customizable in the loginModal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 00:04:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 23:04:20 +0000 Subject: [Koha-bugs] [Bug 27318] make shibboleth instructions customizable in the loginModal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25405 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 00:04:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 30 Dec 2020 23:04:20 +0000 Subject: [Koha-bugs] [Bug 25405] Make separation of Shibboleth and Local login clearer in modal login on OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25405 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27318 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27318 [Bug 27318] make shibboleth instructions customizable in the loginModal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 02:21:51 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 01:21:51 +0000 Subject: [Koha-bugs] [Bug 27208] Add a configurable time delay feature to notice templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27208 Lisette Scheer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 04:14:13 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 03:14:13 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #111 from Lari Taskula --- (In reply to Joonas Kylmälä from comment #110) > I see these message preferences as their own object tied to a patron (not to > a patron's individual message). This would mean the name would be Koha::Patron::MessagePreference and Koha::Patron::MessagePreferences. Good point. That makes sense. Let's go with that. > As far as I can > tell the table message_attributes is incorrectly named / created, the > columns should be in my opinion in the borrower_message_preferences table. > ... > Koha::Patron::MessagePreference (contains both > borrower_message_preferences and message_attributes with JOIN) This is basically what the current patches do, but without a join. The Message::Preference object has an accessor called "message_name" even though it's not physically part of borrower_message_preferences table. JOIN sounds interesting. But doesn't DBIx require you to use "table.column" key format when referencing to a column of a joined table? That's not very user friendly. Would it work with DBIx's "+as" option? Then we could get rid of the "find_with_message_name" method pointed out in comment #80 by Jonathan. I wonder if it's possible to define the JOIN in DBIx schema file so that we don't have to override search/find/whatever methods manually? While there could be improvement at database level, imo that's outside of this Bug's scope. At database level, I don't think they should be merged either. We need message_attribute for database normalization. borrower_message_preferences could also be improved by splitting it in two; borrower_message_preferences and category_message_preferences (the default category preferences). Anyways I think it's outside of the scope here. > The message_transports seems to contains also unrelated columns to transport > types, namely the is_digest information which seems to be preference of the > patron instead of something that is decided based on the transportation > medium. But maybe you can fit this somehow nicely anyway? If it seems > impossible we could restructure first the messaging preference related > tables. "message_options" would better describe its current data. It should also have a primary key integer. Then borrower_message_preferences columns "message_attribute_id" and "wants_digest" could be replaced with a foreign key to "message_option_id". So, borrower_message_preference would simply be a reference to a borrowernumber and message_option_id (and additionally having the days_in_advance setting). But your suggestion works as well. It's just a matter of selecting where the digest information should be at. > Also see comment #80 from Jonathan, I think it the > $patron->messaging_preferences suggestion is a bit like what I have here but > instead with an object. We can implement the Koha::Patron accessors from comment #80, I've nothing against that. But $patron->messaging_preferences would be an object (of MessagingPreferences class), I'm not sure what you mean. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 12:51:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 11:51:10 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 [Bug 27289] Template tweaks for point of sale page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 12:51:10 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 11:51:10 +0000 Subject: [Koha-bugs] [Bug 27289] Template tweaks for point of sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 12:51:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 11:51:16 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 12:51:16 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 11:51:16 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:03:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:03:21 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 [Bug 27282] Print List (shelves.pl) broken in Chrome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:03:21 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:03:21 +0000 Subject: [Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:06:46 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:06:46 +0000 Subject: [Koha-bugs] [Bug 27289] Template tweaks for point of sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114557|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 114756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114756&action=edit Bug 27289: Template tweaks for point of sale page This patch makes a couple of minor changes to the point of sale page in order to make it consistent with other pages in the staff interface: - Buttons inside table cells should have the "btn-xs" class. - Required fields should have a "required" class and should have a "Required" label. Also changed: Replaced according to coding guidelines. To test, apply the patch and enable the EnablePointOfSale and UseCashRegisters system preferences if necessary. - On the Point of Sale page, add some items to purchase. Confirm that the "Add" buttons in the "Items for purchase" table and the "Remove" buttons in the "This sale" table are correctly sized. - In the "Collect payment" form, confirm that "Amount tendered" and "Cash register" fields are styled red with "Required" text after them. - Confirm that the "Amount tendered" field will only accept numeric input. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:07:09 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:07:09 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114749|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 114757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114757&action=edit Bug 27290: Clean up validation It seems we had the validator instantiated twice and we used a mix of validation of required at form element level and in JS instantiator. This patch moves the rules to consistently apply at the instantiation and removes the duplicate lines. To test: 1 - Enable 'useCashRegisters' and 'EnablePointofSale' 2 - Add a cash register 3 - Add a debit type that can be sold 4 - Go to point of sale and sell the item multiple times 5 - Enter 'Amount tendered' less than amount being paid 6 - Click confirm 7 - Transaction is processed as if full funds received 8 - Try with a negative number - goes through again Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:07:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:07:36 +0000 Subject: [Koha-bugs] [Bug 27289] Template tweaks for point of sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize --- Seems we were working on similar things around the same time.. Thanks for the fixes here.. they look good.. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:07:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:07:54 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114747|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:08:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:08:02 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114748|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:08:50 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:08:50 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 --- Comment #11 from Martin Renvoize --- Looks like Owen was working on similar improvements at the same time.. so I've tested and signed off his work on bug 27282 and made this dependant upon it and squashed the final outcome here.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:12:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:12:27 +0000 Subject: [Koha-bugs] [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27282 |27289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 [Bug 27282] Print List (shelves.pl) broken in Chrome https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 [Bug 27289] Template tweaks for point of sale page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:12:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:12:27 +0000 Subject: [Koha-bugs] [Bug 27282] Print List (shelves.pl) broken in Chrome In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27282 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27290 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:12:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:12:27 +0000 Subject: [Koha-bugs] [Bug 27289] Template tweaks for point of sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27290 [Bug 27290] Cash register allows for 'amount tendered' less than amount being paid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:13:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:13:02 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:13:02 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:13:02 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27256 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 [Bug 27256] "Add" button on point of sale page fails on table paging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:13:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:13:48 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:13:48 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:13:48 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 [Bug 27256] "Add" button on point of sale page fails on table paging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:13:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:13:56 +0000 Subject: [Koha-bugs] [Bug 27289] Template tweaks for point of sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23354 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:13:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:13:56 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27289 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 [Bug 27289] Template tweaks for point of sale page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:14:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:14:25 +0000 Subject: [Koha-bugs] [Bug 27289] Template tweaks for point of sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:14:25 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:14:25 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|27289 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 [Bug 27289] Template tweaks for point of sale page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:14:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:14:58 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23354 |26161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26161 [Bug 26161] Confirm and cancel buttons should be underneath the right hand form on the POS page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:14:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:14:58 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Point of sale' screen to allow anonymous payments In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27256 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 [Bug 27256] "Add" button on point of sale page fails on table paging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:14:58 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:14:58 +0000 Subject: [Koha-bugs] [Bug 26161] Confirm and cancel buttons should be underneath the right hand form on the POS page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26161 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 [Bug 27256] "Add" button on point of sale page fails on table paging -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:15:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:15:20 +0000 Subject: [Koha-bugs] [Bug 26161] Confirm and cancel buttons should be underneath the right hand form on the POS page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26161 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 13:15:20 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 12:15:20 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|26161 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26161 [Bug 26161] Confirm and cancel buttons should be underneath the right hand form on the POS page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 14:27:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 13:27:53 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113304|0 |1 is obsolete| | --- Comment #46 from Fridolin Somers --- Created attachment 114758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114758&action=edit Bug 17809: Correct authorised values for fr-FR This corrects: CC -- duplicate, but name not full. GQ -- duplicate, but only one name correct. PK -- Poland was mislabelled. This removes and edits duplicates and corrects PK to PL. Signed-off-by: Luke Honiss Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 14:28:08 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 13:28:08 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113305|0 |1 is obsolete| | --- Comment #47 from Fridolin Somers --- Created attachment 114759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114759&action=edit Bug 17809: Fix ER country appearing twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 14:28:37 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 13:28:37 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 14:28:40 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 13:28:40 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Fridolin Somers changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114713|0 |1 is obsolete| | --- Comment #48 from Fridolin Somers --- Created attachment 114760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114760&action=edit Bug 17809: FR installer: fix duplicate authorised value qualif 370 Monteur vs Réalisateur Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 14:30:36 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 13:30:36 +0000 Subject: [Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #49 from Fridolin Somers --- Thanks a lot Victor ;) Hope it will soon be QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 14:40:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 13:40:43 +0000 Subject: [Koha-bugs] [Bug 27319] New: Authorities permissions Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27319 Bug ID: 27319 Summary: Authorities permissions Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fiona.borthwick at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Staff still see the Authorities button on the Koha home screen despite having no access to authorities. It would appear that you can grant access to editauthorities but there is not a separate permission to allow someone to search and / or select authorities whilst cataloguing. So a staff login can see the Authorities button on the home screen and can search for these even though they have the editauthorities permission deselected. Whilst I can see this logic, one of our customers has queried how they can hide the button completely as some staff should never have to work with authorities / cataloguing and this made me think that it might be a good idea to have a separate permission for searching. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 15:57:43 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 14:57:43 +0000 Subject: [Koha-bugs] [Bug 26355] Tie account renewals to patron modification requests In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26355 Jaki changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jaki.frisina at leblibrary.com --- Comment #6 from Jaki --- We would love to see this as the majority of our emails for the past few months have been patrons requesting to renew their accounts. If they could do it themselves without going through us, that would be great! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 16:23:03 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 15:23:03 +0000 Subject: [Koha-bugs] [Bug 27320] New: Add collection code and shelving location options to MARC export tool Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27320 Bug ID: 27320 Summary: Add collection code and shelving location options to MARC export tool Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: barbara.johnson at bedfordtx.gov QA Contact: testopia at bugs.koha-community.org The MARC export tool allows you to export records based on item type which is great but sometimes does not provide enough granularity for our needs. It would be useful to also be able to select records based on collection code or shelving location. While a report could be created to capture this data it would provide additional efficiency to be able to select these options from a dropdown like you can with item type. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 16:35:34 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 15:35:34 +0000 Subject: [Koha-bugs] [Bug 27321] New: Make excluded database columns in system preferences more clearly disabled Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Bug ID: 27321 Summary: Make excluded database columns in system preferences more clearly disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 17364 added the ability to exclude database columns in system preferences. When something is disabled the checkbox is disabled but it is still hard to tell its disabled because the corresponding label remains the same color as all the others. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 16:41:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 15:41:28 +0000 Subject: [Koha-bugs] [Bug 27321] Make excluded database columns in system preferences more clearly disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 16:41:28 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 15:41:28 +0000 Subject: [Koha-bugs] [Bug 17364] branchcode in BorrowerUnwantedField causes software error when saving patron record. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17364 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 [Bug 27321] Make excluded database columns in system preferences more clearly disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 16:41:49 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 15:41:49 +0000 Subject: [Koha-bugs] [Bug 27321] Make excluded database columns in system preferences more clearly disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Lucas Gass changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 16:41:52 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 15:41:52 +0000 Subject: [Koha-bugs] [Bug 27321] Make excluded database columns in system preferences more clearly disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 --- Comment #1 from Lucas Gass --- Created attachment 114761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114761&action=edit Bug 27321: make disabled labels #cccccc To test: 1. Apply patch and its dependency (bug 17364) 2. Go the system pref BorroweUnwantedFields 3. branchcode should cleary stand out as disabled (#cccccc) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 16:42:27 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 15:42:27 +0000 Subject: [Koha-bugs] [Bug 27261] PatronSelfRegistrationBorrowerUnwantedField should exclude branchcode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27261 --- Comment #4 from Lucas Gass --- (In reply to Fridolin Somers from comment #2) > Great :D > > Maybe we need some CSS on excluded fields name, grey color for example. I agree, I have opened Bug 27321. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 18:55:19 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 17:55:19 +0000 Subject: [Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 PTFS Europe Sandboxes changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114698|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 114762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114762&action=edit Bug 27308: Skip blank lines when inserting new The intent of the macro insert new function is to add a new field at the correct numerical place in the record. If you have a blank line while editing, however, the new line will be inserted at the blank line, rather than checking the rest of the record. To test: 1 - Create a macro like new 690=‡aLOCAL SUBJECT 2 - Insert a blank line into your record somewhere before where the 690 should be inserted 3 - Run the macro 4 - Line is inserted before the blank line 5 - Apply patch 6 - Reload (ensure cache is cleared and JS files are reloaded) 7 - Remove the previously created field, but leave the blank 8 - Run the macro 9 - Field is created at correct position Signed-off-by: Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 19:05:38 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 18:05:38 +0000 Subject: [Koha-bugs] [Bug 27319] Authorities permissions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27319 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 19:06:11 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 18:06:11 +0000 Subject: [Koha-bugs] [Bug 27320] Add collection code and shelving location options to MARC export tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27320 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 19:35:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 18:35:53 +0000 Subject: [Koha-bugs] [Bug 27321] Make excluded database columns in system preferences more clearly disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 19:35:56 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 18:35:56 +0000 Subject: [Koha-bugs] [Bug 27321] Make excluded database columns in system preferences more clearly disabled In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27321 Andrew Fuerste-Henry changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114761|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 114763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114763&action=edit Bug 27321: make disabled labels #cccccc To test: 1. Apply patch and its dependency (bug 17364) 2. Go the system pref BorroweUnwantedFields 3. branchcode should cleary stand out as disabled (#cccccc) Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 20:14:26 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 19:14:26 +0000 Subject: [Koha-bugs] [Bug 27308] Advanced editor should skip blank lines when inserting new fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27308 Barbara Johnson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 22:28:53 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 21:28:53 +0000 Subject: [Koha-bugs] [Bug 27256] "Add" button on point of sale page fails on table paging In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor at tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo --- Missing dependencies for 19.11.x, it doesn't affect it, no backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Dec 31 22:28:54 2020 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Dec 2020 21:28:54 +0000 Subject: [Koha-bugs] [Bug 27289] Template tweaks for point of sale page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27289 Bug 27289 depends on bug 27256, which changed state. Bug 27256 Summary: "Add" button on point of sale page fails on table paging https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27256 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.