[Koha-bugs] [Bug 27131] Move code from circ/pendingreserves.pl to modules

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27131

--- Comment #4 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
(In reply to Jonathan Druart from comment #2)
> Joonas, is that what you had in mind? Or where you talking about more code?

Thanks! Something like this but I hope we could add more checks here for this
to be useful for many other places in Koha, at least similar stuff is needed in
<https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26659#c6>. So
ideally this would be the same check as when you check-in a book in staff
interface and Koha check's whether the item can satisfy any of the holds in
that biblio using this item. This includes checking also circulation rules.
Currently the pendingreserves.pl has more bugs than just the incorrect patron
information, it lists at least also wrong amount of items to pull and wrongs
items / callnumbers to pull.

To achieve a reusable solution across the whole Koha codebase we probably need
to go on more granular level:

Koha::Item::can_fill_hold
Koha::Hold::get_items_that_can_fill
Koha::Holds::get_items_that_can_fill

-- 
You are receiving this mail because:
You are watching all bug changes.