[Koha-bugs] [Bug 27080] Add --statute-barred option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at helsinki.fi
             Status|Needs Signoff               |Failed QA

--- Comment #3 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Hi,

I spotted few things to improve:

1) Instead of doing RAW SQL use Koha Koha::Account::Line objects and ->delete.
2) Move code somewhere else than C4:
https://wiki.koha-community.org/wiki/Coding_Guidelines#DEPR3:_C4_deprecated_for_new_modules
– unfortunately I don't have good suggestions as to what could be better place
right now.
3) Split the formatting changes of the patch to its own patch in order to ease
reviewing the changes and give us more confidence that the whitespace change
won't accidentally do any logic changes, also it eases reverting and usage of
git in general.
4) Add unit test for the new function

I must say I don't know what those RETURNED accountlines are about so regarding
whether this feature is something we want or if it should be implemented in
some other way I cannot say, maybe I can research this topic later.

-- 
You are receiving this mail because:
You are watching all bug changes.