[Koha-bugs] [Bug 12388] IssueSlip output should be sorted by date_due, not timestamp

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12388

--- Comment #15 from Emmi Takkinen <emmi.takkinen at koha-suomi.fi> ---


(In reply to Joonas Kylmälä from comment #14)
> I think earlier I must have meant that in the patch "Bug 12388: Adjust
> tests" the tests' the changes are made so that the expected order is by
> issue date). If you read the code for the first test case changed here it
> sets for both of the checkouts the same due date "$date_due = $today_daily;"
> so it won't be able to test whether the sorting by date_due works. But yes,
> what I meant that maybe we should have tests for the correct sorting, now I
> understand that the original patch "Adjust tests" might have not had that
> goal because it changed a test that was only for checking whether we get
> separate "Checked out" and "Overdues" sections in the slip. So I think the
> patch "Bug 12388: Adjust tests" is okay, but/and if you think it is
> important there should be test for testing sorting order as well for the
> slip.
Yeah, "Bug 12388: Adjust tests" was simply meant to prevent tests from failing
after adding sort with date_due. Just swapping titles and barcodes was enough
to achieve this but maybe it wouldn't hurt to have different date due for
another of those items (or just add another item with different date due).

-- 
You are receiving this mail because:
You are watching all bug changes.