[Koha-bugs] [Bug 26208] Overdues restrictions not consistently removed when renewing multiple items at once

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26208

--- Comment #4 from Nick Clemens <nick at bywatersolutions.com> ---
(In reply to David Cook from comment #3)
> This sounds like an anti-feature to me.
> 
> Nick's note on Bug 26457 says that renewals are silently failing. I'd say it
> would be better to make them fail loudly rather than making this work
> serially?

In these cases with restrictions there are no failures, just a race condition:
        # Remove any OVERDUES related debarment if the borrower has no overdues
        if ( $patron
          && $patron->is_debarred
          && ! $patron->has_overdues
          && @{ GetDebarments({ borrowernumber => $borrowernumber, type =>
'OVERDUES' }) } 
        ) {
            DelUniqueDebarment({ borrowernumber => $borrowernumber, type =>
'OVERDUES' });
        }

When all the transactions hit at once they are getting conflicting information
and not removing the debarment, so all items renewed but restrictions stay

I filed bug 27152, but currently this is a bug affecting many sites and this is
a simple solution. There is a performance cost, but there will be with a bulk
endpoint too

-- 
You are receiving this mail because:
You are watching all bug changes.