[Koha-bugs] [Bug 26996] Elasticsearch: Multiprocess reindexing sometimes doesn't reindex all records

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26996

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |joonas.kylmala at helsinki.fi
             Status|Needs Signoff               |Failed QA

--- Comment #2 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Thanks, this fixes the problem indeed. Few things to improve on the patch:

- In the commit title describe what the fix does, not what the problem is. E.g.
"Convert Elasticsearch indexer commit buffer size to int" and in the body
describe that it fixes the buffer counter not resetting and the reason why it
fixes it.

- In the commit title use "Bug XXXX: YYY" format which is used by every other
commit we have (now there is the "-" character instead).

- Add whitespace between the multiplication and parentheses.

-- 
You are receiving this mail because:
You are watching all bug changes.