[Koha-bugs] [Bug 26848] Fix Readonly dependency in cpanfile

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Dec 9 09:21:47 CET 2020


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26848

--- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> ---
Hi Mason,

What did you modify in the benchmark ?
I ran the non-modified benchmark with and without Readonly::XS installed and I
saw no differences.

Also, on https://metacpan.org/pod/Readonly#Internals it is written:
> In the years since Readonly::XS was released, the then private internal
> methods have been exposed and can be used in pure perl. Similar modules were
> written to take advantage of this and a patch to Readonly was created. We no
> longer need to build and install another module to make Readonly useful on
> modern builds of perl.
> - You do not need to install Readonly::XS.
> - You should stop listing Readonly::XS as a dependency or expect it to be installed.
> - Stop testing the $Readonly::XSokay variable!

So I think Readonly::XS should be removed from our cpanfile.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list