[Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080

Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #19 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> ---
Hi,

- can you explain why only RETURNED fees? It would probably good to have this
explanation in the help documentation too. Some other fees that might need to
be removed also could be RENEWED and LOST? Please see
installer/data/mysql/mandatory/account_debit_types.sql, although it doesn't
contain every type of fee Koha generates currently.

- Depending on your answer to the above question, would it make sense to make
the name of this option something more generic, like --unpaid-fees?

- The commit title is still too long, see comment #4.

- The code is now not in a function, i.e. cannot be tested. Would something
like Koha::Account::Lines::statute_barred (depending on the scope of this
function maybe a different name) sound good to you? Then you can call ->delete
or ->count on those and the code will look super cool in the script, wouldn't
it? :)

- The whitespace changes would still be nice to have, just in a separate patch.
Tip: add it as last in the series so any rebase conflicts will be easier to
resolve when you only need to redo the whitespace patch and not also the
feature patch.

-- 
You are receiving this mail because:
You are watching all bug changes.