[Koha-bugs] [Bug 26498] Add option to set a default expire date for holds at reservation time

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26498

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andrew.isherwood at ptfs-europ
                   |                            |e.com

--- Comment #5 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Hi Emmi

I tried to sign this off but ran into a few problems, sorry!

1. prove -v t/db_dependent/Hold.t fails with:
t/db_dependent/Hold.t .. 1/34 found extra parameters: []# Looks like your test
exited with 2 just after 1.
t/db_dependent/Hold.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 33/34 subtests 

Test Summary Report
-------------------
t/db_dependent/Hold.t (Wstat: 512 Tests: 1 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 34 tests but ran 1.
Files=1, Tests=1,  4 wallclock secs ( 0.04 usr  0.01 sys +  3.28 cusr  0.42
csys =  3.75 CPU)
Result: FAIL

2. In your test plan, you say "Holds expiration date should be set according
your settings", this doesn't appear to be happening. The expiry date is not
being populated according to the value in the DefaultHoldExpirationdatePeriod
syspref. Maybe I'm misunderstanding the test plan? You can see what I mean
here: https://nimb.ws/Sw048R

3. In the video I manually selected a date and the hold was created, however,
if I leave the date selection blank I receive an error page (the relevant part
of which is here https://nimb.ws/pWzZNO), I note the error is the same as the
one in the failing test.

Sorry to report bad news!

-- 
You are receiving this mail because:
You are watching all bug changes.