[Koha-bugs] [Bug 26742] Add configuration for message broker

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742

--- Comment #8 from David Cook <dcook at prosentient.com.au> ---
(In reply to Jonathan Druart from comment #7)
> 1. Wouldn't it make sense to keep "login" instead of "username" in the
> koha-conf.xml?
> 

I don't think so, since "username" is more standard than "login". It correlates
better with the RabbitMQ documentation for instance
(https://www.rabbitmq.com/access-control.html), so I think sysadmins and such
would find username more user-friendly.

> 2. You are adding a die in the ->connect method, is it really useful?
> If $stomp->connect fails we already get an exception.

I am very sure that $stomp->connect does not raise an exception when it fails
without my patch. 

Without my patch, when would you get that exception? When it tries to
subscribe? if that's the case, I think that's raising an exception too late.

-- 
You are receiving this mail because:
You are watching all bug changes.