[Koha-bugs] [Bug 25026] RaiseError must be set for the UI

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25026

--- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
The problem also exists for the install, when the tables don't exist yet.

I can try to explain again, it's as simple as: Without unsafe we cannot disable
RaiseError (passing RaiseError => 0 to ->connect), because DBIC set its own
HandleError (and will raise the error anyway, because it considers it's the
right thing to do, unless you passed unsafe => 1).

The idea of this patch is the remove this HandleError and ignore the error in
both case:
- KOHA_DB_DO_NOT_RAISE_OR_PRINT_ERROR is set (to not have errors *displayed* on
reset_all, ie. misc4dev/do_all_you_can_do.pl)
- we are hitting the installer for the first time

I have not retested, but I don't think misc4dev could deal with the replacement
of the HandleError, $dbh is init at compilation and that's why we have
KOHA_DB_DO_NOT_RAISE_OR_PRINT_ERROR in the BEGIN block.
Even if we could, I don't think we should drop
KOHA_DB_DO_NOT_RAISE_OR_PRINT_ERROR's behaviour without deprecation notice.

-- 
You are receiving this mail because:
You are watching all bug changes.