[Koha-bugs] [Bug 27080] Add --statute-barred-fees option to cleanup_database.pl to purge all fees where the item has been returned and the fee is older than the given number of days.

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27080

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.renvoize at ptfs-europe
                   |                            |.com

--- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
OK, it's time for someone to put a pragmatic hat on here.. and it appears that
person is me today.

Whilst I agree with allot of what Joonas is saying, and he's really only trying
to help by offering constructive criticism, I think this patch is reasonable
and with the polishing that has already taken place I think it's reasonable to
expect it to progress into Koha and as such I will take a look at testing
myself with a view to signing off.

Explanation of Joonas's views:
Koha is a massive project with countless users worldwide and huge numbers of
developers contributing to it.  As a general rule, if you don't have a unit
test covering a change you are making you cannot expect that feature to not get
broken by future development. (This is NOT koha specific, a massive number of
projects out there require a unit test as part of every/any submission). 
Joonas was merely making suggestions on how best to submit the code allowing
for such unit tests.

Yes, in an ideal world, C4:: would be gone and Koha:: would be fully unit
tested and have fully replaced it with cleaner more modern code. 
Unfortunately, Koha is a victim of it's own success, having grown organically.
We are lacking tests in many places, but things are always improving.. and it
takes time to migrate everything (and most of that time is unfunded!)

Koha is also a huge international project, so the terms are important and so is
the flexibility of features... I've been caught by that one a number of times
myself, where a feature is obvious to me, but I quickly learn it's not at all
clear to my counterparts elsewhere or that for it to work for them it needs a
little tweaking. I tend to try and code with that in mind these days and make
the foundations as flexible as I can so others can build atop them. For example
with this feature I personally would love to see it all controlled by system
preferences.. i.e. the list of what constitutes a fee that may be
statute-barred, and the timeings.. then simply passing a binary flag to the
script would be required to enable it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.