[Koha-bugs] [Bug 27177] t/db_dependent/api/v1/holds.t failing after bug 26988

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27177

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
I haven't been digging very deep, but this patch is wrong:

416     return try { 
417         my @pickup_locations =                                              
418             $hold->itemnumber
419           ? @{ $hold->item->pickup_locations( { patron => $hold->patron }
)->as_list() }             
420           : @{ $hold->biblio->pickup_locations( { patron => $hold->patron }
)->as_list() };   

vs

216 sub pickup_locations {
...
231     return \@pickup_locations; 

So you are calling ->as_list on an arrayref (I bet this is not tested in the
tests are you trying to fix).

As said in the previous comment, look at bug 27002 instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.