[Koha-bugs] [Bug 27209] Add Koha::Hold->set_pickup_location
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Dec 14 13:47:30 CET 2020
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27209
Victor Grousset/tuxayo <victor at tuxayo.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #114374|0 |1
is obsolete| |
--- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Created attachment 114380
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114380&action=edit
Bug 27209: (follow-up) Add ->is_pickup_location_valid
This patch simply refactors the pickup location check into a method that
can be called on its own. Tests are added, and the tests for
->set_pickup_location should pass unmodified.
To test:
1. Apply the first two patches
2. Run:
$ kshell
k$ prove t/db_dependent/Koha/Hold.t
=> SUCCESS: tests pass
3. Apply this refactoring patch
4. Notice the tests are similar, but check for boolean output
5. Repeat 2
=> SUCCESS: New tests pass, set_pickup_location() behavior unchanged.
6. Sign off :-D
Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io>
Signed-off-by: Victor Grousset/tuxayo <victor at tuxayo.net>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list