[Koha-bugs] [Bug 12430] Relevance ranking should also be used without QueryWeightFields system preference

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #92 from Victor Grousset/tuxayo <victor at tuxayo.net> ---
Test plan works in 19.11.x but automated test doesn't [1]
(t/Search/buildQuery.t)
It works in 20.05.x

Here is maybe the place to looks in the code. Does anyone understand the
difference there or somewhere else that affect $limit_desc and $limit?

20.05.x:
https://gitlab.com/koha-community/Koha/-/blob/8a9553c4ae62aa05d7d3529806d8fdbac664b473/C4/Search.pm#L1587
19.11.x:
https://gitlab.com/koha-community/Koha/-/blob/608512179cf8f354ca76bab32e874530b3c5df12/C4/Search.pm#L1755


[1] Failed test:

kohadev-koha at ec7b568b5d3d:/kohadevbox/koha$ prove t/Search/buildQuery.t
t/Search/buildQuery.t .. 1/10 
    #   Failed test 'Limit is correct'
    #   at t/Search/buildQuery.t line 92.
    #          got: undef
    #     expected: ''

    #   Failed test 'Limit desc is correct'
    #   at t/Search/buildQuery.t line 94.
    #          got: undef
    #     expected: ''
    # Looks like you failed 2 tests of 13.

#   Failed test 'test weighted autotruncated'
#   at t/Search/buildQuery.t line 107.

    #   Failed test 'Limit is correct'
    #   at t/Search/buildQuery.t line 130.
    #          got: undef
    #     expected: ''

    #   Failed test 'Limit desc is correct'
    #   at t/Search/buildQuery.t line 132.
    #          got: undef
    #     expected: ''
    # Looks like you failed 2 tests of 13.

#   Failed test 'test* weighted autotruncated'
#   at t/Search/buildQuery.t line 144.

    #   Failed test 'Limit is correct'
    #   at t/Search/buildQuery.t line 167.
    #          got: undef
    #     expected: ''

    #   Failed test 'Limit desc is correct'
    #   at t/Search/buildQuery.t line 169.
    #          got: undef
    #     expected: ''
    # Looks like you failed 2 tests of 13.

#   Failed test 'test weighted not-autotruncated'
#   at t/Search/buildQuery.t line 181.

    #   Failed test 'Limit is correct'
    #   at t/Search/buildQuery.t line 316.
    #          got: undef
    #     expected: ''

    #   Failed test 'Limit desc is correct'
    #   at t/Search/buildQuery.t line 318.
    #          got: undef
    #     expected: ''
    # Looks like you failed 2 tests of 13.

#   Failed test 'one and two weighted autotruncated'
#   at t/Search/buildQuery.t line 330.
# Looks like you failed 4 tests of 10.

-- 
You are receiving this mail because:
You are watching all bug changes.