[Koha-bugs] [Bug 21528] Combine all reserves in a biblio hold-group into a single line entry

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21528

--- Comment #7 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 88124
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88124
Bug 21528: UNFINISHED PATCH

Review of attachment 88124:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21528&attachment=88124)
-----------------------------------------------------------------

::: svc/holds
@@ +103,2 @@
>          itemtype_limit => $itemtype_limit,
> +        hold_group     => Koha::Holds->search({ hold_group_id => $h->hold_group_id })->unblessed,

This is buggy. I'd suggest changing it to the following:
( $h->hold_group_id ) ? Koha::Holds->search({ hold_group_id =>
$h->hold_group_id })->unblessed : undef

If the hold doesn't have a hold group ID, all holds without a hold_group_id
will be fetched. 

If a borrower has a high number of holds, and there are a high number of holds
on the system, you'll be fetching and then transmitting a huge amount of data
(the magnitude being megabytes instead of kilobytes). This uses up a lot of
system memory and creates huge latency.

-- 
You are receiving this mail because:
You are watching all bug changes.